Page MenuHomePhabricator

ssastry (Subbu)
User

Projects (20)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 5:34 AM (477 w, 1 d)
Availability
Available
IRC Nick
subbu
LDAP User
Subramanya Sastry
MediaWiki User
SSastry (WMF) [ Global Accounts ]

Recent Activity

Yesterday

ssastry closed T287419: `mediawiki-core-php72-phan-docker` job runs `composer install` instead of using packages from mediawiki/vendor as Declined.

Since we have gone the way of pinning Parsoid version in core, this is no longer an issue and am closing this as declined.

Tue, Nov 28, 5:55 PM · Parsoid (Tracking), Release-Engineering-Team (Radar), Continuous-Integration-Config, ci-test-error (WMF-deployed Build Failure), MediaWiki-Vendor
ssastry committed rIVDI183d8c30b062: Make self-link handling deal with absolute links as well (authored by ssastry).
Make self-link handling deal with absolute links as well
Tue, Nov 28, 2:40 PM
ssastry added a comment to T350083: 1.42.0-wmf.7 deployment blockers.

@hashar https://gerrit.wikimedia.org/r/c/mediawiki/core/+/977625 should be merged and backported before rolling out the train.

Tue, Nov 28, 4:15 AM · Release-Engineering-Team (Priority Backlog 📥), Release, Train Deployments

Mon, Nov 27

ssastry added a comment to T351995: Error in Displaying Qing Dynasty's Largest River Station.

What page on what wiki is this? Is this a content issue OR a wikitext parsing issue OR an issue with content being differently on desktop and the Android app?

Mon, Nov 27, 2:01 PM · Maps, Content-Transform-Team, Wikipedia-Android-App-Backlog
ssastry added a comment to T351461: InvalidArgumentException: Multiple conflicting values given for wgDiscussionToolsPageThreads.

Turns out this is a different manifestation of T303015#7770480 with the ParserAfterTidy hook that triggers the DiscussionTools extension's CommentFormatter which sets the JS config var in question whenever Parsoid's pipeline processes a <templatestyles> tag (or some other extension tag that Parsoid calls core to handle). This information is accumulated and propagated to the final top level parse of the page and stored in ParserCache. Now, when Parsoid tries to get DT rendered, ParserOutput finds that the wgDiscussionToolsPageThreads has been set and barfs as above.

Mon, Nov 27, 3:38 AM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Maintenance-Worktype, DiscussionTools, Content-Transform-Team-WIP, Wikimedia-production-error

Tue, Nov 21

ssastry committed rIVDI27ff8554e5fe: Don't suppress the footer anymore (authored by ssastry).
Don't suppress the footer anymore
Tue, Nov 21, 8:59 PM

Mon, Nov 20

ssastry closed T333023: Complete Parsoid TOC implementation as Resolved.

I am going to close this and if we find any bugs / gaps, we can file new tasks.

Mon, Nov 20, 7:52 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry closed T347426: Disable support for custom offsetType and custom outputContentVersion major versions in Parsoid as Resolved.
Mon, Nov 20, 7:51 PM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
ssastry closed T252246: Borrow functionality from the LinkHandlerUtils::figureHandler for serializing media in gallery as Resolved.
Mon, Nov 20, 7:50 PM · Maintenance-Worktype, Content-Transform-Team-WIP, Parsoid
ssastry closed T206940: Quote marks in "alt" text break media attribute parsing as Resolved.
Mon, Nov 20, 7:47 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Parsoid, VisualEditor
ssastry committed rIVDI4874d4bc9117: Re-enable DiscussionTools since Parsoid supports it now (authored by ssastry).
Re-enable DiscussionTools since Parsoid supports it now
Mon, Nov 20, 7:43 PM

Fri, Nov 17

ssastry committed rIVDI65f42799aebd: Re-enable kartographer since Parsoid supports it now (authored by ssastry).
Re-enable kartographer since Parsoid supports it now
Fri, Nov 17, 1:01 PM

Thu, Nov 16

ssastry added a subtask for T341010: DiscussionTools doesn't recognize talk threads with Parsoid HTML: T351461: InvalidArgumentException: Multiple conflicting values given for wgDiscussionToolsPageThreads.
Thu, Nov 16, 8:36 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Content-Transform-Team-WIP, Editing-team, DiscussionTools, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry added a parent task for T351461: InvalidArgumentException: Multiple conflicting values given for wgDiscussionToolsPageThreads: T341010: DiscussionTools doesn't recognize talk threads with Parsoid HTML.
Thu, Nov 16, 8:36 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Maintenance-Worktype, DiscussionTools, Content-Transform-Team-WIP, Wikimedia-production-error
ssastry claimed T351461: InvalidArgumentException: Multiple conflicting values given for wgDiscussionToolsPageThreads.

These errors are from a visual diffing test run I kicked off about 45 mins back or so. DiscussionTools with Parsoid isn't used anywhere else right now. But, this gives me a clue for some diffs I was noticing in the test run. So, I'll fix this and hopefully that will fix the diffs too!

Thu, Nov 16, 8:36 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Maintenance-Worktype, DiscussionTools, Content-Transform-Team-WIP, Wikimedia-production-error
ssastry moved T341010: DiscussionTools doesn't recognize talk threads with Parsoid HTML from To Verify to In Progress on the Content-Transform-Team-WIP board.
Thu, Nov 16, 7:39 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Content-Transform-Team-WIP, Editing-team, DiscussionTools, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry added a comment to T341010: DiscussionTools doesn't recognize talk threads with Parsoid HTML.

Now that wmf.5 has rolled out to group 2, I am seeing another issue on enwiki talk pages.

Thu, Nov 16, 7:38 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Content-Transform-Team-WIP, Editing-team, DiscussionTools, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry added a comment to T341010: DiscussionTools doesn't recognize talk threads with Parsoid HTML.

On itwiki which is now on wmf.5, many pages now render DiscussionTools with "?useparsoid=1" ( this, this, this ).

Thu, Nov 16, 5:08 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Content-Transform-Team-WIP, Editing-team, DiscussionTools, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry closed T350625: Unable to save edits via Parsoid on pages with unclosed <div> in a template, because of TOC insertion as Resolved.

Failed test on en.wikipedia.org with wmf.4 -- page corruption / dirty diffs because template encapsulation is broken.

Thu, Nov 16, 5:02 PM · Maintenance-Worktype, Content-Transform-Team-WIP, Editing-team, Parsoid, VisualEditor
ssastry added a comment to T351047: PHP Notice: Undefined index: counter.

This is only an issue in round trip testing for non-wikitext content models, But I'll see if I can suppress the error or remove these non-wikitext content model pages from the test set.

Thu, Nov 16, 4:30 AM · Patch-For-Review, Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-REST-API, Parsoid, Wikimedia-production-error
ssastry moved T333402: Switching from source editing to visual editing mode is broken with the REST API from Backlog to To Verify on the Content-Transform-Team-WIP board.
Thu, Nov 16, 4:27 AM · Maintenance-Worktype, MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Content-Transform-Team-WIP, Patch-For-Review, VisualEditor, Parsoid
ssastry moved T350625: Unable to save edits via Parsoid on pages with unclosed <div> in a template, because of TOC insertion from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Thu, Nov 16, 4:21 AM · Maintenance-Worktype, Content-Transform-Team-WIP, Editing-team, Parsoid, VisualEditor
ssastry moved T206940: Quote marks in "alt" text break media attribute parsing from Code Review to To Verify on the Content-Transform-Team-WIP board.
Thu, Nov 16, 4:20 AM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Parsoid, VisualEditor
ssastry moved T305210: Parsoid's timed media output is missing data- attributes from In Progress to Backlog on the Content-Transform-Team-WIP board.
Thu, Nov 16, 4:09 AM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry assigned T313875: Parsoid should probably be calling a File's MediaTransformOutput->toHtml() to Arlolra.
Thu, Nov 16, 4:08 AM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry added a project to T313875: Parsoid should probably be calling a File's MediaTransformOutput->toHtml(): Content-Transform-Team-WIP.
Thu, Nov 16, 4:07 AM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T341010: DiscussionTools doesn't recognize talk threads with Parsoid HTML from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Thu, Nov 16, 4:06 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Content-Transform-Team-WIP, Editing-team, DiscussionTools, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid

Wed, Nov 15

ssastry closed T342352: Create ParsoidExperimentalDeprecatedPostProcessingHookDoNotUse hook for DiscussionTools testing as Declined.

We ended up reusing an existing hook and not creating a new hook for this purpose .The abandoned code is all in gerrit if we ever need a new hook again. So, declining this.

Wed, Nov 15, 12:29 AM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), DiscussionTools, Parsoid
ssastry closed T342352: Create ParsoidExperimentalDeprecatedPostProcessingHookDoNotUse hook for DiscussionTools testing, a subtask of T341010: DiscussionTools doesn't recognize talk threads with Parsoid HTML, as Declined.
Wed, Nov 15, 12:29 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Content-Transform-Team-WIP, Editing-team, DiscussionTools, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T342352: Create ParsoidExperimentalDeprecatedPostProcessingHookDoNotUse hook for DiscussionTools testing from Code Review to To Deploy on the Content-Transform-Team-WIP board.
Wed, Nov 15, 12:28 AM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), DiscussionTools, Parsoid
ssastry claimed T350625: Unable to save edits via Parsoid on pages with unclosed <div> in a template, because of TOC insertion.
Wed, Nov 15, 12:27 AM · Maintenance-Worktype, Content-Transform-Team-WIP, Editing-team, Parsoid, VisualEditor

Mon, Nov 13

ssastry closed T351026: VisualEditor adding nonsense code to file pages as Resolved.

This is now fixed. But it uncovered an issue with the 'Review Changes' output in VE which now incorrectly shows that structured data information will be removed on save, but on save, there is no such deletion happening. We'll track and fix that separately.

Mon, Nov 13, 10:01 PM · Maintenance-Worktype, Content-Transform-Team-WIP, API Platform, WikibaseMediaInfo, Structured-Data-Backlog, Parsoid, VisualEditor
ssastry created T351113: Figure out how Parsoid will work with MCR slots to support both reading and editing clients.
Mon, Nov 13, 6:31 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Multi-Content-Revisions, Parsoid-Read-Views, Parsoid

Sun, Nov 12

ssastry added projects to T351026: VisualEditor adding nonsense code to file pages: API Platform, Content-Transform-Team-WIP.
Sun, Nov 12, 2:49 PM · Maintenance-Worktype, Content-Transform-Team-WIP, API Platform, WikibaseMediaInfo, Structured-Data-Backlog, Parsoid, VisualEditor
ssastry added a comment to T351026: VisualEditor adding nonsense code to file pages.

This broke when we rolled out https://gerrit.wikimedia.org/r/c/mediawiki/core/+/953342 about 3 weeks back. Somewhere in the code paths, we forgot to account for the fact that when VE needs to edit a page, it only needs to edit the "main" slot of a page with multiple MCR slots. File pages on commons have multiple slots and with that change, we seem to be giving VE the combined HTML from non-wikitext slots.

Sun, Nov 12, 2:41 PM · Maintenance-Worktype, Content-Transform-Team-WIP, API Platform, WikibaseMediaInfo, Structured-Data-Backlog, Parsoid, VisualEditor

Fri, Nov 10

ssastry added a comment to T350952: After fixing subpage links in Parsoid read views, TOC links are broken.

I merged and pushed to beta, but TOC link fragments are broken (see https://en.wikipedia.beta.wmflabs.org/wiki/African_linsang?useparsoid=1 )

Fri, Nov 10, 6:26 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
ssastry added a comment to T350952: After fixing subpage links in Parsoid read views, TOC links are broken.

I think we should fix this sooner than later .. I suspect officewiki has subpage links.

Fri, Nov 10, 4:25 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid

Thu, Nov 9

ssastry added a comment to T350625: Unable to save edits via Parsoid on pages with unclosed <div> in a template, because of TOC insertion.

An explicit wrapper could help in some scenarios but doesn't eliminate the need to know if you are in templated content before doing an operation ... you still to have to walk up to detect the wrapper and move before/after before doing that operation.

Thu, Nov 9, 4:58 PM · Maintenance-Worktype, Content-Transform-Team-WIP, Editing-team, Parsoid, VisualEditor
ssastry added a comment to T350844: Unhandled case in TableFixups .

There are about 3 or 4 tables where Parosid's output is missing <td>s.

Thu, Nov 9, 4:41 AM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Wikimedia-production-error
ssastry created T350844: Unhandled case in TableFixups .
Thu, Nov 9, 4:38 AM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Wikimedia-production-error
ssastry added a comment to T350625: Unable to save edits via Parsoid on pages with unclosed <div> in a template, because of TOC insertion.

This is an oversight in Parsoid's TOC insertion code and has been there since end-March when https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/903797 got merged. The short summary is that the synthetic TOC Insertion code doesn't check if the insertion point is in the middle of a transclusion. As such, it breaks the continuity of the transclusion markup.

Thu, Nov 9, 3:30 AM · Maintenance-Worktype, Content-Transform-Team-WIP, Editing-team, Parsoid, VisualEditor

Wed, Nov 8

ssastry added a comment to T349674: <noinclude> renders incorrectly.

This edit name broke it for Parsoid. It moved the </onlinclude> from *outside* the transclusion to *inside* the transclusion. So, Parsoid looked at the content within <onlyinclude> ... </onlyinclude> and found an unclosed transclusion and rendered it as text.

Wed, Nov 8, 8:16 PM · Parsoid, Wikipedia-Android-App-Backlog

Tue, Nov 7

ssastry added a comment to T287419: `mediawiki-core-php72-phan-docker` job runs `composer install` instead of using packages from mediawiki/vendor.

I pushed that patch above for discussion.

Tue, Nov 7, 10:14 PM · Parsoid (Tracking), Release-Engineering-Team (Radar), Continuous-Integration-Config, ci-test-error (WMF-deployed Build Failure), MediaWiki-Vendor
ssastry added a comment to T287419: `mediawiki-core-php72-phan-docker` job runs `composer install` instead of using packages from mediawiki/vendor.

I can see scenarios where composer install makes sense for master development .. i.e. when you want to use a new version of a package and use code available there which would fail if you tested it against vendor versions.

Tue, Nov 7, 9:53 PM · Parsoid (Tracking), Release-Engineering-Team (Radar), Continuous-Integration-Config, ci-test-error (WMF-deployed Build Failure), MediaWiki-Vendor

Mon, Nov 6

ssastry updated the task description for T349123: Backport Parsoid ParserCache unification to 1.41.
Mon, Nov 6, 11:05 PM · Content-Transform-Team-WIP, Maintenance-Worktype, MW-1.41-release
ssastry added a comment to T350627: No longer possible to collapse sections on mobile.

Looks like this query selector in MFE is the problem:

		$containers = $xpath->query( 'body/div[@class="mw-parser-output"][1]' );
Mon, Nov 6, 10:08 PM · Verified, MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Patch-For-Review, MediaWiki-Platform-Team, Content-Transform-Team, Wikimedia-production-error, Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3)
ssastry added a comment to T350627: No longer possible to collapse sections on mobile.

I thought MFE didn't use Parsoid HTML?

Mon, Nov 6, 10:00 PM · Verified, MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Patch-For-Review, MediaWiki-Platform-Team, Content-Transform-Team, Wikimedia-production-error, Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3)
ssastry updated subscribers of T350627: No longer possible to collapse sections on mobile.
Mon, Nov 6, 9:10 PM · Verified, MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Patch-For-Review, MediaWiki-Platform-Team, Content-Transform-Team, Wikimedia-production-error, Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3)
ssastry added a comment to T341010: DiscussionTools doesn't recognize talk threads with Parsoid HTML.

Only two extensions implement a ParserOutputPostCacheTransformHandler.

Mon, Nov 6, 7:04 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Content-Transform-Team-WIP, Editing-team, DiscussionTools, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid

Fri, Nov 3

ssastry added a comment to T341010: DiscussionTools doesn't recognize talk threads with Parsoid HTML.

There are three possible strategies. I am outlining them here along with links to patches. ( FYI:

Fri, Nov 3, 8:51 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Content-Transform-Team-WIP, Editing-team, DiscussionTools, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid

Thu, Nov 2

ssastry closed T349310: DOMException: Invalid Character Error as Resolved.

Looks like this error has gone away after the train rolled out with the Parsoid & core changes that prevents this error from triggering. So, I am going to resolve this. But, the Remex change still needs to be packaged and deployed. That will prevent future bugs like this in the future.

Thu, Nov 2, 7:06 PM · Content-Transform-Team-WIP, Patch-For-Review, Maintenance-Worktype, User-brennen, Parsoid, Wikimedia-production-error
ssastry updated the task description for T350403: Pool key 'commonswiki:parsoid-pcache:idhash:729388-0!dateformat=default!termboxVersion=1!useParsoid=1!wb=3!wbMobile=0:revid:712601244' (ArticleView): Timeout waiting for the lock.
Thu, Nov 2, 2:55 PM · MediaWiki-REST-API, Parsoid, Wikimedia-production-error
ssastry created T350403: Pool key 'commonswiki:parsoid-pcache:idhash:729388-0!dateformat=default!termboxVersion=1!useParsoid=1!wb=3!wbMobile=0:revid:712601244' (ArticleView): Timeout waiting for the lock.
Thu, Nov 2, 2:54 PM · MediaWiki-REST-API, Parsoid, Wikimedia-production-error
ssastry created T350400: PHP Notice: Trying to get property 'identifiers' of non-object.
Thu, Nov 2, 2:50 PM · MediaWiki-REST-API, Math, Wikimedia-production-error

Wed, Nov 1

ssastry added a comment to T350219: Page html output on testwiki returns 404.

The issue seems to be that the parsoid endpoints send a full URL in redirect responses, e.g. when redirecting from a page URL to a revision URL, e.g. /page/html/Dog to /page/html/Dog/12345. Since the target URL uses an external domain name, it will not be routed to the parsoid cluster, where the Parsoid extension is enabled on MediaWiki. The request will instead be routed to the public API cluster, where the relevant endpoints are unavailable, resulting in a 404 response.

Wed, Nov 1, 2:47 PM · Patch-For-Review, mwbot-rs, RESTBase Sunsetting, RESTBase

Tue, Oct 31

ssastry updated the task description for T341244: ParserOptions and Title::getPageViewLanguage may disagree on the lang/dir.
Tue, Oct 31, 6:50 PM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Content-Transform-Team, MediaWiki-Platform-Team, MediaWiki-ContentHandler
ssastry updated the task description for T350044: Document Parsoid Read Views usage via ParserMigration settings.
Tue, Oct 31, 4:14 AM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP

Oct 27 2023

ssastry created T349941: upgrade nodejs on parsing-qa-02.
Oct 27 2023, 8:33 PM · VPS-Projects, Content-Transform-Team-WIP, Maintenance-Worktype, Parsoid, Parsoid-Read-Views
ssastry removed a project from T321234: Exception: "Malformed UTF-8 characters" in Parser\MagicWordArray (via WikitextContentHandler): Content-Transform-Team.
Oct 27 2023, 6:57 PM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), Patch-For-Review, MediaWiki-Parser, Wikimedia-production-error

Oct 26 2023

ssastry added a project to T349868: page/<title>/html and with_html endpoints fails with InvalidArgumentException for overridden interface messages with JSON content: MediaWiki-Engineering.
Oct 26 2023, 8:08 PM · Patch-For-Review, MediaWiki-Engineering, API Platform, Content-Transform-Team, MediaWiki-REST-API
ssastry reopened T347552: Bad rendering of map links associated map frames in on enwikivoyage (Parsoid) as "Open".

Reopening because there is one one other issue I am noticing. Check https://en.wikivoyage.org/wiki/Jenin?useparsoid=1 vs https://en.wikivoyage.org/wiki/Jenin and see the diff in the icon in the two cases. If you inspect, the issues seems to be that the content of the link is -number-around in Parsoid vs 0°0′0″N 0°0′0″E in legacy rendering.

Oct 26 2023, 4:54 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), SecTeam-Processed, Parsoid, Maps (Kartographer)
ssastry added a project to T321234: Exception: "Malformed UTF-8 characters" in Parser\MagicWordArray (via WikitextContentHandler): Content-Transform-Team.
Oct 26 2023, 4:28 PM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), Patch-For-Review, MediaWiki-Parser, Wikimedia-production-error
ssastry closed T328034: ParsoidCachePrewarmJob should set the useParsoid ParserOption, a subtask of T320529: Configure VE backend to use Parsoid directly, instead of calling RESTbase, as Resolved.
Oct 26 2023, 3:18 PM · User-notice-archive, RESTBase Sunsetting, MediaWiki-Configuration, Editing-team, VisualEditor, Platform Team Workboards (MW Expedition)
ssastry closed T328034: ParsoidCachePrewarmJob should set the useParsoid ParserOption as Resolved.
Oct 26 2023, 3:18 PM · Patch-For-Review, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Content-Transform-Team-WIP, MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), MediaWiki-Parser, RESTBase Sunsetting, Parsoid
ssastry closed T328034: ParsoidCachePrewarmJob should set the useParsoid ParserOption, a subtask of T327164: Trigger ParsoidCachePrewarmJob on page views, as Resolved.
Oct 26 2023, 3:18 PM · Content-Transform-Team, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid (Tracking), MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Performance-Team (Radar), MediaWiki-Parser, RESTBase Sunsetting
ssastry closed T328034: ParsoidCachePrewarmJob should set the useParsoid ParserOption, a subtask of T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry, as Resolved.
Oct 26 2023, 3:18 PM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry closed T332933: Ensure Parsoid Read Views code path correctly handles ParserOptions as Resolved.

Patches rolled out as part of the parent task handled this.

Oct 26 2023, 3:16 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry closed T332933: Ensure Parsoid Read Views code path correctly handles ParserOptions, a subtask of T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry, as Resolved.
Oct 26 2023, 3:16 PM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry closed T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry as Resolved.

Nothing else to do here.

Oct 26 2023, 3:15 PM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry closed T330677: Ensure ParserCacheMetadata isn't corrupted by 'useParsoid' option as Resolved.

Looks there was nothing new to do here and we have had the ParsoidOutputAccess merge with ParserOutputAccess patch in production for more than a week now.

Oct 26 2023, 3:15 PM · Content-Transform-Team-WIP, MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, MediaWiki-Parser

Oct 24 2023

ssastry triaged T349310: DOMException: Invalid Character Error as Low priority.
Oct 24 2023, 8:55 PM · Content-Transform-Team-WIP, Patch-For-Review, Maintenance-Worktype, User-brennen, Parsoid, Wikimedia-production-error
ssastry added a comment to T349310: DOMException: Invalid Character Error.

We are going to sweep this under the carpet at least for this scenario as noted in T349310#9277286 .. but yes, if wikis use attribute names that trip up against this, such pages will not render. For now, we hold our breath till PHP's new DOM implementation comes online and the WMF cluster upgrades to that version (which is probably a few years away). Given that this is the first time we ran against this, I am comfortable with that approach.

Oct 24 2023, 8:51 PM · Content-Transform-Team-WIP, Patch-For-Review, Maintenance-Worktype, User-brennen, Parsoid, Wikimedia-production-error
ssastry added a comment to T349310: DOMException: Invalid Character Error.

Presumably this is the result of some patches being applied for T346657

Oct 24 2023, 8:02 PM · Content-Transform-Team-WIP, Patch-For-Review, Maintenance-Worktype, User-brennen, Parsoid, Wikimedia-production-error
ssastry updated subscribers of T349310: DOMException: Invalid Character Error.

Based on @cscott's hunch, I explored more and it turns out 16 pages account for all the errors seen so far. We wonder if these errors were triggered by a template edit (causing these pages to *now* go through Parsoid with the new code paths from 3 weeks back).

Oct 24 2023, 7:14 PM · Content-Transform-Team-WIP, Patch-For-Review, Maintenance-Worktype, User-brennen, Parsoid, Wikimedia-production-error
ssastry added a comment to T349310: DOMException: Invalid Character Error.

It is baffling .. the first error was about 12:10 UTC and https://wikitech.wikimedia.org/wiki/Server_Admin_Log#2023-10-19 shows nothing for tht timeframe. group2 rollout was a full 6 hours later and there were about ~3600 errors logged already by then.

Oct 24 2023, 5:39 PM · Content-Transform-Team-WIP, Patch-For-Review, Maintenance-Worktype, User-brennen, Parsoid, Wikimedia-production-error
ssastry added a comment to T349310: DOMException: Invalid Character Error.

Separately, independent of what caused this once we roll out https://gerrit.wikimedia.org/r/c/mediawiki/core/+/967275 and its parent Parsoid patch on the next train, we will no longer parse the zhwki HTML on the Parsoid side just go generate metadata -- so this will disappear then, but still curious what happened last week.

Oct 24 2023, 5:29 PM · Content-Transform-Team-WIP, Patch-For-Review, Maintenance-Worktype, User-brennen, Parsoid, Wikimedia-production-error
ssastry added a comment to T349310: DOMException: Invalid Character Error.

And, this is for zhwiki, so, this would have called core's zhwiki language conversion routines before passing that on to Parsoid for metadata conversion. So, the HTML is being parsed to DOM on this converted HTML. So, that is probably the source of it.

Oct 24 2023, 5:27 PM · Content-Transform-Team-WIP, Patch-For-Review, Maintenance-Worktype, User-brennen, Parsoid, Wikimedia-production-error
ssastry added a comment to T349310: DOMException: Invalid Character Error.

Oh, this phab task is for 1.41.0-wmf.30 not 1.42.0-wmf.1 as I originally thought ... so the error manifested even before wmf.1 was rolled out!

Oct 24 2023, 5:16 PM · Content-Transform-Team-WIP, Patch-For-Review, Maintenance-Worktype, User-brennen, Parsoid, Wikimedia-production-error
ssastry added a comment to T349310: DOMException: Invalid Character Error.

We have about 140 langconv (pb2pb) reqs/s but not sure how many are for zhwiki titles. But, these are about 1 every 7 second with multiple errors per request which means absolute # of error titles are smaller. But multiple errors per title is confusing me unless Remex is catching these errors, logging them, and recovering.

Oct 24 2023, 4:30 PM · Content-Transform-Team-WIP, Patch-For-Review, Maintenance-Worktype, User-brennen, Parsoid, Wikimedia-production-error
ssastry created T349646: PHP Notice: Undefined variable: arg.
Oct 24 2023, 3:57 PM · Parsoid, Wikimedia-production-error

Oct 23 2023

ssastry claimed T347632: Remove ParserCache hack added to support merging ParsoidOutputAccess and ParserOutputAccess without cold cache misses.
Oct 23 2023, 8:45 PM · MW-1.41-notes, MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), Maintenance-Worktype, MW-1.41-release, Content-Transform-Team-WIP
ssastry moved T347632: Remove ParserCache hack added to support merging ParsoidOutputAccess and ParserOutputAccess without cold cache misses from Backlog to Code Review on the Content-Transform-Team-WIP board.
Oct 23 2023, 8:45 PM · MW-1.41-notes, MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), Maintenance-Worktype, MW-1.41-release, Content-Transform-Team-WIP
ssastry added a project to T311648: Allow WikitextContentHandler to use Parsoid for rendering wikitext: Content-Transform-Team.
Oct 23 2023, 4:57 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Content-Transform-Team, RESTBase Sunsetting, Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid (Tracking), VisualEditor
ssastry removed a subtask for T264669: Move VE API from RESTBase into core.: T317018: Make HtmlOutputRendererHelper use ParserOutputAccess.
Oct 23 2023, 4:56 PM · API Platform (RESTbase Deprecation Roadmap), RESTBase Sunsetting, Epic, Platform Team Workboards (MW Expedition), Code-Health-Objective, VisualEditor, Platform Engineering Roadmap, Platform Engineering Roadmap Decision Making
ssastry removed a subtask for T311728: Gracefully handle non-wikitext pages when returning HTML from the page endpoints: T317018: Make HtmlOutputRendererHelper use ParserOutputAccess.
Oct 23 2023, 4:56 PM · MW-1.40-notes (1.40.0-wmf.19; 2023-01-16), RESTBase Sunsetting, Parsoid, Platform Team Workboards (MW Expedition), User-xSavitar, API Platform, VisualEditor
ssastry removed a subtask for T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry: T317018: Make HtmlOutputRendererHelper use ParserOutputAccess.
Oct 23 2023, 4:56 PM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry removed parent tasks for T317018: Make HtmlOutputRendererHelper use ParserOutputAccess: T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry, T311728: Gracefully handle non-wikitext pages when returning HTML from the page endpoints, T264669: Move VE API from RESTBase into core..
Oct 23 2023, 4:56 PM · Content-Transform-Team, Technical-Debt, RESTBase Sunsetting, Platform Team Workboards (MW Expedition)
ssastry edited projects for T317018: Make HtmlOutputRendererHelper use ParserOutputAccess, added: Technical-Debt, Content-Transform-Team; removed Parsoid-Read-Views, Content-Transform-Team-WIP, affects-Kiwix-and-openZIM.
Oct 23 2023, 4:55 PM · Content-Transform-Team, Technical-Debt, RESTBase Sunsetting, Platform Team Workboards (MW Expedition)
ssastry added a comment to T317018: Make HtmlOutputRendererHelper use ParserOutputAccess.

The first step of this process is done. ParsoidOutputAccess is a thin wrapper over ParserOutputAccess and unblocks the parent tasks. I am going to remove this as a subtask and also remove the read views tag since the rest of the work is primarily tech debt removal.

Oct 23 2023, 4:54 PM · Content-Transform-Team, Technical-Debt, RESTBase Sunsetting, Platform Team Workboards (MW Expedition)
ssastry closed T311523: Move code which depends on wfMessage out to core as Resolved.
Oct 23 2023, 4:51 PM · MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T330677: Ensure ParserCacheMetadata isn't corrupted by 'useParsoid' option from In Progress to To Verify on the Content-Transform-Team-WIP board.
Oct 23 2023, 4:50 PM · Content-Transform-Team-WIP, MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, MediaWiki-Parser
ssastry closed T332934: Add tests to ensure we catch ParserCache divergences between edit and read view code paths as Declined.

We figured out that after all the patches and other testing, we didn't need to do this anymore.

Oct 23 2023, 4:50 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry closed T332934: Add tests to ensure we catch ParserCache divergences between edit and read view code paths, a subtask of T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry, as Declined.
Oct 23 2023, 4:50 PM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T311523: Move code which depends on wfMessage out to core from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Oct 23 2023, 4:49 PM · MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Oct 23 2023, 4:49 PM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T328034: ParsoidCachePrewarmJob should set the useParsoid ParserOption from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Oct 23 2023, 4:49 PM · Patch-For-Review, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Content-Transform-Team-WIP, MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), MediaWiki-Parser, RESTBase Sunsetting, Parsoid
ssastry moved T332933: Ensure Parsoid Read Views code path correctly handles ParserOptions from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Oct 23 2023, 4:49 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry added a project to T349235: "InvalidArgumentException: The revision does not belong to the given page." after 1.42.0-wmf.1 deployed to group1: Content-Transform-Team-WIP.
Oct 23 2023, 4:49 PM · MW-1.41-notes, Content-Transform-Team-WIP, MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), User-brennen, Wikimedia-production-error
ssastry closed T349235: "InvalidArgumentException: The revision does not belong to the given page." after 1.42.0-wmf.1 deployed to group1 as Resolved.

This will ride the train this week.

Oct 23 2023, 4:48 PM · MW-1.41-notes, Content-Transform-Team-WIP, MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), User-brennen, Wikimedia-production-error
ssastry closed T349235: "InvalidArgumentException: The revision does not belong to the given page." after 1.42.0-wmf.1 deployed to group1, a subtask of T348355: 1.42.0-wmf.2 deployment blockers, as Resolved.
Oct 23 2023, 4:48 PM · Patch-For-Review, Release-Engineering-Team (Social Piranhas 🐟), Release, Train Deployments