ssastry (Subramanya Sastry)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 5:34 AM (175 w, 5 d)
Availability
Available
LDAP User
Subramanya Sastry
MediaWiki User
SSastry (WMF)

Recent Activity

Fri, Feb 16

ssastry added a comment to T186912: Make token transform handlers unit testable.

A good baby step along this way would to take an individual token handler and add a test/unit-test function to it.

QuoteTransformer is a good one because it has a single entry point (onQuote -- as registered in the init function).

Fri, Feb 16, 7:56 PM · Parsoid-Tests, Parsoid
ssastry added a comment to T157418: RFC: Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec".

Note to TechCom: we need to tackle this soon -- see https://www.mediawiki.org/wiki/Topic:U7ovc7uujsvcwb8f. This might benefit from a relatively early TechCom discussion and potentially IRC office hour to figure out what the spec ought to be. If the TechCom is agreeable, I can update this task that summarizes the proposal along with some open questions that need to be resolved so that we can implement them in the PHP parser and Parsoid.

Fri, Feb 16, 1:10 AM · TechCom-RFC, Tidy, Community-Liaisons, Parsoid, MediaWiki-Parser
ssastry renamed T157418: RFC: Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec" from Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec" to RFC: Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec".
Fri, Feb 16, 1:07 AM · TechCom-RFC, Tidy, Community-Liaisons, Parsoid, MediaWiki-Parser
ssastry raised the priority of T157418: RFC: Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec" from Normal to High.
Fri, Feb 16, 1:06 AM · TechCom-RFC, Tidy, Community-Liaisons, Parsoid, MediaWiki-Parser

Mon, Feb 12

ssastry added a comment to T181086: Quote transformation bug.

PHP parser output on ''a'' (<span>'''c'''</span>) l'''boo''\n\n''a'' ('''c''') l'''boo'' below:

<p><i>a</i> (<span><b>c</b></span>) l'<i>boo</i>
</p><p><i>a</i> ('<i>c<b>) l</b>boo</i>
</p>

So, it appears that the PHP parser is aware of tag nesting in this case (!) whereas Parsoid isn't.

Mon, Feb 12, 9:01 PM · Parsoid
ssastry moved T186281: titles with trailing question marks aren't properly URL-encoded from Backlog to Links on the Parsoid board.
Mon, Feb 12, 6:04 PM · Parsoid
ssastry triaged T186281: titles with trailing question marks aren't properly URL-encoded as Normal priority.
Mon, Feb 12, 6:04 PM · Parsoid
ssastry moved T186298: Crash on tree depth of ~4k from Backlog to Performance on the Parsoid board.
Mon, Feb 12, 5:52 PM · Parsoid
ssastry moved T186906: Blacklist changes should count as failures from Backlog to Testing on the Parsoid board.
Mon, Feb 12, 5:52 PM · Patch-For-Review, Parsoid
ssastry triaged T186912: Make token transform handlers unit testable as Normal priority.
Mon, Feb 12, 5:51 PM · Parsoid-Tests, Parsoid

Sun, Feb 11

ssastry added a comment to T184280: Linter multiple database issues.

@Johan @Elitre FYI. See https://www.mediawiki.org/wiki/Topic:U7bdlw783vtf38fg

While we figure out how to tackle this, note that wikis are going to see their linter counts artificially inflated since we are no longer reporting exact counts. Could this be reported in tech news so that wikis are aware and don't freak out?

Yes, but I believe it's too late for the one that goes out on Monday. As a temporary thing a note could be dropped to wikitech + ambassadors as a FYI, if you think it's important.

Sun, Feb 11, 6:18 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team (Radar), Security, Patch-For-Review, Wikimedia-log-errors, MediaWiki-extensions-Linter

Fri, Feb 9

ssastry updated subscribers of T184280: Linter multiple database issues.

@Johan @Elitre FYI. See https://www.mediawiki.org/wiki/Topic:U7bdlw783vtf38fg

Fri, Feb 9, 10:36 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team (Radar), Security, Patch-For-Review, Wikimedia-log-errors, MediaWiki-extensions-Linter
ssastry added a project to T184280: Linter multiple database issues: User-notice.
Fri, Feb 9, 10:34 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team (Radar), Security, Patch-For-Review, Wikimedia-log-errors, MediaWiki-extensions-Linter
ssastry added a comment to T186912: Make token transform handlers unit testable.

A good baby step along this way would to take an individual token handler and add a test/unit-test function to it.

Fri, Feb 9, 7:43 PM · Parsoid-Tests, Parsoid
ssastry created T186912: Make token transform handlers unit testable.
Fri, Feb 9, 7:40 PM · Parsoid-Tests, Parsoid
ssastry added a comment to T186834: Selfref template produces nested div.hatnote elements, causing duplicate hatnote output in MCS.

https://en.wikipedia.org/w/api.php?action=expandtemplates&text={{selfref|{{for|the%20project%20page%20on%20the%20foundation%20itself|:Wikipedia:Wikimedia%20Foundation}}|hat}} shows that the m/w API is generating that output that Parsoid emits. Not sure why expandtemplates and parse endpoints are doing different things here.

Fri, Feb 9, 6:25 AM · Reading-Infrastructure-Team-Backlog, Mobile-Content-Service

Thu, Feb 8

ssastry added a comment to T186834: Selfref template produces nested div.hatnote elements, causing duplicate hatnote output in MCS.

Try {{selfref|{{for|the project page on the foundation itself|:Wikipedia:Wikimedia Foundation}}|hat}} in the https://en.wikipedia.org/wiki/Wikipedia:Sandbox?action=edit and inspect. I find the output as below.

<div role="note" class="hatnote navigation-not-searchable">
<div role="note" class="hatnote navigation-not-searchable"><span class="plainlinks selfreference noprint">For the project page on the foundation itself, see <a href="/wiki/Wikipedia:Wikimedia_Foundation" title="Wikipedia:Wikimedia Foundation">Wikipedia:Wikimedia Foundation</a>.</span></div>
</div>
Thu, Feb 8, 10:42 PM · Reading-Infrastructure-Team-Backlog, Mobile-Content-Service
ssastry closed T186822: Entity decoding bug (manifests as difference in output between SAX based serialization and DOM based serialization)? as Invalid.

Yes, not passing those options took care of it.

Thu, Feb 8, 8:48 PM · RemexHtml
ssastry added a comment to T186822: Entity decoding bug (manifests as difference in output between SAX based serialization and DOM based serialization)?.

This is because of the options passed into the tokenizer to ignoreCharRefs -- presumably as a perf. optimization for scenarios where they need not be decoded. I'll keep this open till I resolve that the computeDSR handling matches up.

Thu, Feb 8, 8:36 PM · RemexHtml
ssastry triaged T186822: Entity decoding bug (manifests as difference in output between SAX based serialization and DOM based serialization)? as Normal priority.
Thu, Feb 8, 7:12 PM · RemexHtml
ssastry created T186822: Entity decoding bug (manifests as difference in output between SAX based serialization and DOM based serialization)?.
Thu, Feb 8, 7:11 PM · RemexHtml
ssastry changed the status of T111604: RFC: Split parser tests info multiple files from Open to Stalled.
Thu, Feb 8, 4:23 PM · TechCom-RFC, MediaWiki-Core-Tests, Parsoid, MediaWiki-Parser

Wed, Feb 7

ssastry added a comment to T111604: RFC: Split parser tests info multiple files.

@ssastry Are you still interested in pushing this forward? What should the next steps be? Are you interested in having an IRC discussion about this?

Wed, Feb 7, 10:21 PM · TechCom-RFC, MediaWiki-Core-Tests, Parsoid, MediaWiki-Parser
ssastry closed T184656: Enable RemexHTML on additional wikis with < 10 high-priority linter errors in all linter categories as Resolved.
Wed, Feb 7, 12:34 AM · Patch-For-Review, User-notice, RemexHtml, Parsing-Team, Tidy
ssastry closed T184656: Enable RemexHTML on additional wikis with < 10 high-priority linter errors in all linter categories, a subtask of T175706: Progressively switch Wikimedia wikis from Tidy to RemexHTML, as Resolved.
Wed, Feb 7, 12:34 AM · Wikimedia-Site-requests, Tidy, Parsing-Team

Tue, Feb 6

ssastry committed rELINT5d82c45feecb: WIP: Display count of linter errors in the main namespace (authored by ssastry).
WIP: Display count of linter errors in the main namespace
Tue, Feb 6, 9:34 PM
ssastry added a comment to T186585: Review m5 backups.

testreduce can be dropped. The other two are needed. No backups necessary.

Tue, Feb 6, 6:46 PM · DBA, cloud-services-team (Kanban), Data-Services
ssastry closed T185945: Enable RemexHTML on ruwiki, fiwiki, svwiki, hewiki as Resolved.
Tue, Feb 6, 2:37 PM · Patch-For-Review, RemexHtml, Tidy, Parsing-Team
ssastry closed T185945: Enable RemexHTML on ruwiki, fiwiki, svwiki, hewiki, a subtask of T175706: Progressively switch Wikimedia wikis from Tidy to RemexHTML, as Resolved.
Tue, Feb 6, 2:37 PM · Wikimedia-Site-requests, Tidy, Parsing-Team

Mon, Feb 5

ssastry added a comment to T179259: Visual Editor removing whitespace from infoboxes by default.

As TheDJ tried to explain, as I tried to explain, we have all known for years that generating dirty diffs is considered a bug. Unsurprisingly, you are getting a stream of requests for this bug be fixed.

If Bob's infobox has aligned parameters and born 1942, and Rob's infobox has unaligned parameters and born 1942, and I edit each from 1942 to 1943, they should both be one-character diffs. There's no reason for VE to touch anything before the existing = sign. And more importantly VE must not modify unchanged parameters.

Mon, Feb 5, 5:37 PM · User-Ryasmeen, Parsoid, VisualEditor

Sun, Feb 4

ssastry added a comment to T186278: Attributes that expand to block? elements fail to roundtrip.

Wait, why is that syntax being tokenized at all?

Sun, Feb 4, 10:35 PM · Parsoid

Fri, Feb 2

ssastry renamed T184656: Enable RemexHTML on additional wikis with < 10 high-priority linter errors in all linter categories from On Feb 6, 2018, enable RemexHTML on additional wikis with < 10 high-priority linter errors in all linter categories (as of Feb 5, 2018) to Enable RemexHTML on additional wikis with < 10 high-priority linter errors in all linter categories.
Fri, Feb 2, 6:21 PM · Patch-For-Review, User-notice, RemexHtml, Parsing-Team, Tidy
ssastry committed rELINTc085dfd1688e: WIP: Display count of linter errors in the main namespace (authored by ssastry).
WIP: Display count of linter errors in the main namespace
Fri, Feb 2, 5:50 PM
ssastry committed rELINT7a8484a07a83: WIP: Display count of linter errors in the main namespace (authored by ssastry).
WIP: Display count of linter errors in the main namespace
Fri, Feb 2, 5:31 PM
ssastry committed rELINT0d99cdb70d1b: WIP: Display count of linter errors in the main namespace (authored by ssastry).
WIP: Display count of linter errors in the main namespace
Fri, Feb 2, 5:31 PM

Thu, Feb 1

ssastry added a comment to T152540: Migrate to HTML5 section ids.

@Niharika: The migration isn't totally complete as we still want to phase out the legacy IDs at some point. Probably need to make a new subtask for that.

Thu, Feb 1, 8:20 PM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Readers-Web-Backlog (Tracking), User-notice, Mobile-Content-Service, Reading-Infrastructure-Team-Backlog, Community-Wishlist-Survey-2016, Community-Tech, ContentTranslation, MediaWiki-Parser, Parsoid, Parsing-Team
ssastry triaged T186241: Add rel="nofollow" to Parsoid links as Normal priority.
Thu, Feb 1, 5:16 PM · Parsoid
ssastry moved T186241: Add rel="nofollow" to Parsoid links from Backlog to Read Views on the Parsoid board.
Thu, Feb 1, 5:16 PM · Parsoid
ssastry added a comment to T184280: Linter multiple database issues.

Are you still concerned about bullet item #1 after my clarification above?

Thu, Feb 1, 5:14 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team (Radar), Security, Patch-For-Review, Wikimedia-log-errors, MediaWiki-extensions-Linter
ssastry added a comment to T184280: Linter multiple database issues.

Are you still concerned about bullet item #1 after my clarification above?

Thu, Feb 1, 5:11 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team (Radar), Security, Patch-For-Review, Wikimedia-log-errors, MediaWiki-extensions-Linter
ssastry added a comment to T184280: Linter multiple database issues.

how to optimize the count query

If the query takes more than 60 seconds (actually, more than 1 second) it cannot be run in the foreground (here foreground means synchronous to a client-initiated request). The optimization is to stop doing that query, whatever it takes. That is a pure code issue, not a database optimization problem.

Thu, Feb 1, 4:46 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team (Radar), Security, Patch-For-Review, Wikimedia-log-errors, MediaWiki-extensions-Linter
ssastry added a comment to T184280: Linter multiple database issues.

The queries are cached, but, are right now run online (when a request comes in and the cached info needs a refresh), not as a maintenance job. @jcrespo do you have any suggestions for how to optimize the count query?

Thu, Feb 1, 3:49 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team (Radar), Security, Patch-For-Review, Wikimedia-log-errors, MediaWiki-extensions-Linter

Wed, Jan 31

ssastry added a comment to T107561: MediaWiki support for Composer equivalent for JavaScript packages.
Wed, Jan 31, 9:24 PM · Performance-Team, MediaWiki-ResourceLoader, Developer-Wishlist (2017), TechCom-RFC, Front-end-Standards-Group

Tue, Jan 30

ssastry added a comment to T147702: NWE's 'Show preview' doesn't load in new modules based on added content, e.g. gallery/maps.

Yeah... Since we use Parsoid instead of the MW parser for this, it might take a bit of guesswork based on what we get back. The MW api.php action=parse gives a list of the ResourceLoader modules used on the page - Parsoid doesn't.

Tue, Jan 30, 6:47 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Parsoid, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor-MediaWiki, VisualEditor
ssastry updated subscribers of T185139: Popups should respect user's language variant preferences.
Tue, Jan 30, 6:44 PM · Readers-Web-Backlog (Tracking), Services (blocked), Page-Previews
ssastry added a comment to T185139: Popups should respect user's language variant preferences.

This is likely to impact Chinese as well and other languages with variants.
Services: Can we serve language content variants in RESTBase? Is there a ticket open relating to that if not.

T159985 was used to track this. I'm not sure what's the latest status of variants implementation in Parsoid. @ssastry ?

Tue, Jan 30, 6:44 PM · Readers-Web-Backlog (Tracking), Services (blocked), Page-Previews

Mon, Jan 29

ssastry triaged T185945: Enable RemexHTML on ruwiki, fiwiki, svwiki, hewiki as Normal priority.
Mon, Jan 29, 9:20 PM · Patch-For-Review, RemexHtml, Tidy, Parsing-Team
ssastry renamed T184656: Enable RemexHTML on additional wikis with < 10 high-priority linter errors in all linter categories from On Jan 31, 2018, enable RemexHTML on additional wikis with < 10 high-priority linter errors in all linter categories (as of Jan 30, 2018) to On Feb 6, 2018, enable RemexHTML on additional wikis with < 10 high-priority linter errors in all linter categories (as of Feb 5, 2018).
Mon, Jan 29, 9:17 PM · Patch-For-Review, User-notice, RemexHtml, Parsing-Team, Tidy
ssastry added a comment to T184656: Enable RemexHTML on additional wikis with < 10 high-priority linter errors in all linter categories.

Looks like this is a no-swat and no-mediawiki train week as per https://wikitech.wikimedia.org/wiki/Deployments#Week_of_January_29th .. so, looks like this has to wait till next week. Postponed to Feb 6th.

Mon, Jan 29, 9:16 PM · Patch-For-Review, User-notice, RemexHtml, Parsing-Team, Tidy

Fri, Jan 26

ssastry added a comment to T129372: gallery syntax claims to require 'px' for widths/heights attributes, but actually discards all strings after the number.

So I think this will have very little impact, except for pl.wp and de.wp, where we might want to ask somebody to run a bot or something. (I can do pl.wp myself.)

@matmarex Still want to take that on?

Fri, Jan 26, 7:16 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Parsing-Team, Multimedia, Patch-For-Review, MediaWiki-Gallery

Wed, Jan 24

ssastry updated the task description for T184656: Enable RemexHTML on additional wikis with < 10 high-priority linter errors in all linter categories.
Wed, Jan 24, 12:51 AM · Patch-For-Review, User-notice, RemexHtml, Parsing-Team, Tidy

Tue, Jan 23

ssastry added a comment to T185012: WMDS 18: Collect feedback as it comes.
  • keeping the rooms/attendence smaller feels really good in terms of helping to facilitate actual conversation, but people who didn't get to come felt left out -- it's been a morale issue for some. I think the best way to handle this is to really concentrate on the idea that we're sending delegates/representatives -- not a full meeting of everyone involved in MediaWiki, but a representative group who can bring up the concerns of their colleagues.
Tue, Jan 23, 7:43 PM · Wikimedia-Developer-Summit (2018)
ssastry added a comment to T183313: Wikimedia Developer Summit 2018 Topic: Evolving the MediaWiki Architecture.

Again, I have no idea if it would actually be more effective to move to something other than MediaWiki. I am however, really discouraged at the overwhelming majority view which is completely dismissive. I think it takes a great deal of intellectual dishonesty to completely dismiss an idea based on the premise and that makes me sad. I can be completely wrong, and that's fine, but I think it's worth considering. I don't want to sacrifice the mission on the alter of MediaWiki.

Tue, Jan 23, 5:41 PM · MediaWiki-Platform-Team, User-Jdlrobson, Services (watching), User-mobrovac, User-Daniel, Wikimedia-Developer-Summit (2018)
ssastry added a comment to T183313: Wikimedia Developer Summit 2018 Topic: Evolving the MediaWiki Architecture.

*[ Subbu responding after the fact: This was before my time, but here is what I understand. It was NOT possible to write this in PHP in 2012 when this started. There was no HTML5 parser, performance was a concern because of all the additional work that needed to happen. There was PEG.js available. So, the separation wasn't necessarily on a whim but because writing it in PHP wasn't feasible at that time. I don't know if I am speculating here, but there was some passing idea / thought of possibly running Parsoid in the browser and node.js was what enabled it. So, if we had to do it all in PHP, Parsoid, and VE launch might have taken much longer. The original Parsoid design had (and still has remnants) an integrated preprocessor and wasn't meant to be a separate call into M/W api. The call to M/W api happened in the rush to have things ready for the Dec 2012 VE launch and since that worked, it stuck and we didn't pursue the preprocessor integration beyond that. Also see https://www.mediawiki.org/wiki/Parsing#E:_Evaluate_feasibility_of_porting_Parsoid_to_PHP Note that, RemexHTML, the HTML5 parser in PHP is based off the node.js HTML5 parser, domino, which is something we switched to around 2014 from another HTML5 parser. ]

I recall that when Parsoid was started, the nodejs service was supposed to be a prototype before rewriting it in C++, perhaps with the ability to compile it as a PHP extension (cf. php-luasandbox). The nodejs service wasn't originally supposed to be the final product of the project. Of course, the original idea of rewriting in C++ was "deprioritized" in 2013.<ref>https://www.mediawiki.org/wiki/Parsoid/status</ref>

Tue, Jan 23, 5:34 PM · MediaWiki-Platform-Team, User-Jdlrobson, Services (watching), User-mobrovac, User-Daniel, Wikimedia-Developer-Summit (2018)
ssastry added a comment to T183313: Wikimedia Developer Summit 2018 Topic: Evolving the MediaWiki Architecture.

I also wonder whether the Parsoid nodejs service is anywhere near being able to replace the PHP parser's generation of links table metadata and other metadata, or to support extensions such as Scribunto.

Yeah, I'm not sure about that part. @ssastry do you have a read on this?

Tue, Jan 23, 5:24 PM · MediaWiki-Platform-Team, User-Jdlrobson, Services (watching), User-mobrovac, User-Daniel, Wikimedia-Developer-Summit (2018)

Sat, Jan 20

ssastry committed rELINT1a87f6322630: WIP: Display count of linter errors in the main namespace (authored by ssastry).
WIP: Display count of linter errors in the main namespace
Sat, Jan 20, 6:13 AM

Fri, Jan 19

ssastry added a comment to T173943: Display count of remaining content space errors.

Change 405327 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/extensions/Linter@master] WIP: Display count of linter errors in the main namespace

https://gerrit.wikimedia.org/r/405327

There is a config variable $wgContentNamespaces which is the list of all the namespaces of interest for a particular wiki. (I was careful to request content namespaces -- most projects have more than just the mainspace in the content space. ;)

Fri, Jan 19, 6:12 PM · DBA, Patch-For-Review, MediaWiki-extensions-Linter
ssastry committed rELINT048d5d031db9: WIP: Display count of linter errors in the main namespace (authored by ssastry).
WIP: Display count of linter errors in the main namespace
Fri, Jan 19, 5:34 PM
ssastry committed rELINT670ae4acdcf2: WIP: Display count of linter errors in the main namespace (authored by ssastry).
WIP: Display count of linter errors in the main namespace
Fri, Jan 19, 5:31 PM
ssastry committed rELINT84633fa2eb31: WIP: Display count of linter errors in the main namespace (authored by ssastry).
WIP: Display count of linter errors in the main namespace
Fri, Jan 19, 5:29 PM
ssastry lowered the priority of T184280: Linter multiple database issues from High to Normal.

That patch seems to have done the trick in terms of reducing the # of errors. However, the core problem still exists. I am going to lower the priority since the immediate issue is ameliorated.

Fri, Jan 19, 5:26 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team (Radar), Security, Patch-For-Review, Wikimedia-log-errors, MediaWiki-extensions-Linter
ssastry committed rELINT882a009b6b81: WIP: Display count of linter errors in the main namespace (authored by ssastry).
WIP: Display count of linter errors in the main namespace
Fri, Jan 19, 5:25 PM
ssastry committed rELINT2ed2c1fc1a11: WIP: Display count of linter errors in the main namespace (authored by ssastry).
WIP: Display count of linter errors in the main namespace
Fri, Jan 19, 5:25 PM
ssastry raised the priority of T173943: Display count of remaining content space errors from Normal to High.
Fri, Jan 19, 3:28 PM · DBA, Patch-For-Review, MediaWiki-extensions-Linter

Jan 18 2018

ssastry added a comment to T183319: Wikimedia Developer Summit 2018 Topic: Embracing Open Source Software.

Other repositories that are potentially useful outside WMF:

Jan 18 2018, 9:56 PM · Wikimedia-Developer-Summit (2018)
ssastry assigned T58756: Parsoid doesn't give external links class="external free|text" to Sbailey.
Jan 18 2018, 5:48 PM · Patch-For-Review, Parsoid
ssastry added a comment to T58756: Parsoid doesn't give external links class="external free|text".

Also note that mwgrep indicates 724 uses of the a.external selector on wikis, including in JS files, so changing this selector in the new parser would create a large piece of technical debt.

Jan 18 2018, 5:48 PM · Patch-For-Review, Parsoid
ssastry added a comment to T184021: Content from Page: namespace on wikisource not appended at SOL.

Worth verifying that T162935: Wikisource page is unexpectedly listed under "fostered" and T185221: Placing table syntax outside the main body of a Page: (on Wikisource) causes a stray <div> tag to be generated get resolved after the above patch is reviewed, merged, and deployed, and if necessary reopen one or the other.

Jan 18 2018, 5:47 PM · ProofreadPage, Patch-For-Review, Parsoid
ssastry merged T185221: Placing table syntax outside the main body of a Page: (on Wikisource) causes a stray <div> tag to be generated into T162935: Wikisource page is unexpectedly listed under "fostered".
Jan 18 2018, 4:33 PM · MediaWiki-Parser, Parsoid, MediaWiki-extensions-Linter
ssastry merged task T185221: Placing table syntax outside the main body of a Page: (on Wikisource) causes a stray <div> tag to be generated into T162935: Wikisource page is unexpectedly listed under "fostered".
Jan 18 2018, 4:33 PM · ProofreadPage, MediaWiki-extensions-Linter
ssastry closed T161556: Implement a way to have linter reprocess all pages as Resolved.
Jan 18 2018, 4:32 PM · Services (watching), Parsoid, MediaWiki-extensions-Linter
ssastry triaged T185221: Placing table syntax outside the main body of a Page: (on Wikisource) causes a stray <div> tag to be generated as Normal priority.
Jan 18 2018, 4:12 PM · ProofreadPage, MediaWiki-extensions-Linter
ssastry added a comment to T185221: Placing table syntax outside the main body of a Page: (on Wikisource) causes a stray <div> tag to be generated.
<subbu> so, on that Page:Cowie's page ... the problem is the {{nop}} in the first line ... it generates a <div></div> .. but it is embedded inside a table outside a table-cell .. i.e. there is no preceding | 
<subbu> so, it gets "fostered" out of the table and also causes the missing </div> error .. but, the core problem is that the {{nop}} there is out of place. it doesn't belong there.
<ShakespeareFan00> subbu: Yet that {{nop}} is the advised approach for split tables
<ShakespeareFan00> According to the disscussion at Wikisource
<ShakespeareFan00> https://en.wikisource.org/wiki/Wikisource:Scriptorium#LintErrors
<ShakespeareFan00> If you'd like to tell the long-standing and respected contributor there that THEY are wrong
<ShakespeareFan00> I wish you the best of luck
<subbu> ShakespeareFan00, maybe so .. but it has to be proper markup. if it is broken markup, nothing the parser / browser can do with it. i cannot wade into that discussion now, but maybe the instructions are missing steps / are being misinterpreted.
<ShakespeareFan00> subbu:  Without the {{nop}} there's no line-feed so that the starting |-
<ShakespeareFan00> gets rendered into the last cell of the preceeding table row
<ShakespeareFan00> due to the way Proofread Page works
<ShakespeareFan00> This mangles all kinds of tables
<ShakespeareFan00> The correct way of doing this would be to have "proper" directives to use changing the parser handling
<ShakespeareFan00> but when I suggested the same a while back there absolutely no interest
<ShakespeareFan00> (sigh)
Jan 18 2018, 4:08 PM · ProofreadPage, MediaWiki-extensions-Linter
ssastry added a comment to T185203: Show a Linter error (like "Malformed table syntax") for || at the beginning of a line in a table and other table errors....

We have had some requests to expand the coverage to catch more / other lint errors. We also have T152817: Implement WP:CHECKWIKI errors in Linter (tracking). But, at this time we don't have enough people to work on this project to get to this right away. But, we have it on our radar.

Jan 18 2018, 3:44 PM · MediaWiki-extensions-Linter
ssastry added a comment to T183313: Wikimedia Developer Summit 2018 Topic: Evolving the MediaWiki Architecture.
  1. Everyone finds <translate> tags annoying – it looks like MCR or parsoid or WikiText 2.0 will provide a better way to do it, but more work is needed, work that goes across teams. Some content is not made translatable because of this. T131516
Jan 18 2018, 5:08 AM · MediaWiki-Platform-Team, User-Jdlrobson, Services (watching), User-mobrovac, User-Daniel, Wikimedia-Developer-Summit (2018)

Jan 16 2018

ssastry updated the task description for T184656: Enable RemexHTML on additional wikis with < 10 high-priority linter errors in all linter categories.
Jan 16 2018, 3:54 PM · Patch-For-Review, User-notice, RemexHtml, Parsing-Team, Tidy

Jan 15 2018

ssastry added a comment to T184280: Linter multiple database issues.

Another alternative is to increase wgLinterStatsdSampleFactor to more than 1000 for commonswiki which should reduce # of aggregate queries for those wikis. Right now, I see it set to 1000 ... which, for commons, based on how common lint errors are there, and rate of edits .. would probably be once every 5-10 mins. So, we could bump that to 5000.

Jan 15 2018, 1:26 AM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team (Radar), Security, Patch-For-Review, Wikimedia-log-errors, MediaWiki-extensions-Linter

Jan 13 2018

ssastry added a comment to T184280: Linter multiple database issues.

Looks like things have calmed down last few days. I had filed the now abandoned https://gerrit.wikimedia.org/r/#/c/403581/ but @Legoktm thinks we should be able to suppress these high volume low-priority categories on commons by editing the mediawiki-config repo. So, we have that option available.

Jan 13 2018, 6:13 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team (Radar), Security, Patch-For-Review, Wikimedia-log-errors, MediaWiki-extensions-Linter
ssastry added a comment to T161546: Missing CSS styles / resources on some wikis.
.. but rather that the rest api does not work for pages not in the main namespace.
Jan 13 2018, 6:06 PM · Parsoid
ssastry added a comment to T161546: Missing CSS styles / resources on some wikis.

I tried to find out the answer for myself but https://www.mediawiki.org/api/rest_v1/page/html/User:Nirmos/Sandbox just gives an error.

Jan 13 2018, 5:53 PM · Parsoid

Jan 12 2018

ssastry moved T160572: Some edit links on the Special:LintErrors page aren't highlighting the affected text from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.
Jan 12 2018, 11:43 PM · MediaWiki-extensions-Linter
ssastry moved T152760: jquery.textSelection does not scroll textbox in Chromium, works in Firefox from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.
Jan 12 2018, 11:43 PM · Browser-Support-Google-Chrome, MediaWiki-General-or-Unknown, MediaWiki-extensions-Linter
ssastry closed T183893: Block elements within inline elements reported as "Multiple unclosed formatting tags" as Resolved.
Jan 12 2018, 11:42 PM · Parsoid, MediaWiki-extensions-Linter
ssastry closed T176596: Re-evaluate Linter update mechanism as Declined.

I don't think there is anything to do here.

Jan 12 2018, 11:41 PM · Services (watching), Parsoid, MediaWiki-extensions-Linter
ssastry triaged T184706: Badly introduced inline references do not throw a warning as Normal priority.
Jan 12 2018, 11:39 PM · MediaWiki-extensions-Linter, Cite
ssastry triaged T184755: Consider not removing multiple blank lines/white space between paragraphs as Normal priority.
Jan 12 2018, 11:38 PM · Parsoid, VisualEditor
ssastry moved T161278: Add default gadget styling to Parsoid's output from Backlog to Read Views on the Parsoid board.
Jan 12 2018, 11:38 PM · Gadgets, MediaWiki-API, Parsoid
ssastry added a comment to T161546: Missing CSS styles / resources on some wikis.

Will TemplateStyles solve this?

Jan 12 2018, 11:37 PM · Parsoid
ssastry added a comment to T184755: Consider not removing multiple blank lines/white space between paragraphs.

Thanks. Yes, I see that now. So, it is not some edge case behavior.

[subbu@earth tools] echo "<p>foo</p><p></p><p></p><p></p><p>bar</p>" | parse.js --html2wt
foo
Jan 12 2018, 9:35 PM · Parsoid, VisualEditor
ssastry added a comment to T184755: Consider not removing multiple blank lines/white space between paragraphs.

This normalisation is done by Parsoid, but seemingly not documented here: https://www.mediawiki.org/wiki/Parsoid/Normalizations nor do I remember it being added.

Jan 12 2018, 3:37 PM · Parsoid, VisualEditor
ssastry triaged T184779: Clean up a rare edge case in section-wrapping and extension-content interaction as High priority.
Jan 12 2018, 12:24 AM · Parsoid
ssastry created T184779: Clean up a rare edge case in section-wrapping and extension-content interaction.
Jan 12 2018, 12:24 AM · Parsoid

Jan 11 2018

ssastry merged task T149447: Parsoid doesn't handle transclusions from the Special: namespace into T59886: Support special page transclusion.
Jan 11 2018, 9:52 PM · Parsoid, User-Urbanecm
ssastry merged T149447: Parsoid doesn't handle transclusions from the Special: namespace into T59886: Support special page transclusion.
Jan 11 2018, 9:52 PM · Parsoid
ssastry moved T50812: Get ParserOutput options from expandtemplates or similar action, and encode them as properties from Backlog to Read Views on the Parsoid board.
Jan 11 2018, 9:51 PM · Parsoid
ssastry moved T53245: Link MediaWiki styles and create Parsoid-specific CSS styling to match MediaWiki's for differing DOM elements from Backlog to Read Views on the Parsoid board.
Jan 11 2018, 9:51 PM · Parsoid
ssastry moved T53587: Parsoid needs to run findVariantLink or some equivalent thing from Backlog to Read Views on the Parsoid board.
Jan 11 2018, 9:50 PM · Parsoid
ssastry moved T59886: Support special page transclusion from Backlog to Read Views on the Parsoid board.
Jan 11 2018, 9:50 PM · Parsoid
ssastry moved T66214: Define an official thumb API from Backlog to Non-Parsoid Tasks on the Parsoid board.
Jan 11 2018, 9:49 PM · Performance-Team (Radar), Services (watching), Reading Epics (Thumbnails), Traffic, Operations, TechCom-RFC, Zero, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Reading-Admin, Commons, Epic, Parsoid, Multimedia, MediaWiki-File-management
ssastry moved T85581: Parsoid page views: need to do something about {{int:}} from Backlog to Read Views on the Parsoid board.
Jan 11 2018, 9:49 PM · Services (watching), I18n, Parsoid