Page MenuHomePhabricator

ssastry (Subbu)
User

Projects (19)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 5:34 AM (509 w, 5 d)
Availability
Busy Busy until Aug 12.
IRC Nick
subbu
LDAP User
Subramanya Sastry
MediaWiki User
SSastry (WMF) [ Global Accounts ]

Recent Activity

Jun 7 2024

ssastry committed rIVDI9b198755d4b3: Couple tweaks to the MFE config.
Couple tweaks to the MFE config
Jun 7 2024, 10:40 PM

Jun 1 2024

ssastry added a comment to T366408: CTT tasks week of 2024-05-31.

RT-testing regression script shows no regressions.

Jun 1 2024, 3:59 PM · MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Essential-Work, Content-Transform-Team-WIP
ssastry updated the task description for T366408: CTT tasks week of 2024-05-31.
Jun 1 2024, 3:59 PM · MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Essential-Work, Content-Transform-Team-WIP
ssastry created T366408: CTT tasks week of 2024-05-31.
Jun 1 2024, 3:56 PM · MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Essential-Work, Content-Transform-Team-WIP

May 31 2024

ssastry committed rIVDI0a05c056afcc: Purge all custom CSS styles -- not needed anymore.
Purge all custom CSS styles -- not needed anymore
May 31 2024, 9:31 PM
ssastry committed rIVDIc2696ac4fb21: First pass at addition MFE-specific config.
First pass at addition MFE-specific config
May 31 2024, 9:31 PM
ssastry moved T364751: Run visualdiff testing on mobile front end from Current Deploy Target to In Progress on the Content-Transform-Team-WIP board.
May 31 2024, 6:04 PM · Parsoid-Read-Views, Content-Transform-Team-WIP
ssastry claimed T364751: Run visualdiff testing on mobile front end.
May 31 2024, 6:03 PM · Parsoid-Read-Views, Content-Transform-Team-WIP

May 29 2024

ssastry moved T53587: Parsoid needs to run findVariantLink or some equivalent thing from To Deploy to To Verify on the Content-Transform-Team-WIP board.
May 29 2024, 9:07 PM · Content-Transform-Team-WIP, MediaWiki-Language-converter, Patch-For-Review, Parsoid-Read-Views (Phase 4 - Parsoid generates metadata needed by core), Parsoid-Rendering, Parsoid, Chinese-Sites
ssastry moved T258856: Links to variants titles in Parsoid are still marked as red links from To Deploy to To Verify on the Content-Transform-Team-WIP board.
May 29 2024, 9:07 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid-Rendering, Parsoid
ssastry added a project to T364925: Scraper: Parsoid attaches mw:Transclusion data in <ref> tag to unexpected DOM node: Essential-Work.
May 29 2024, 9:06 PM · Essential-Work, WMDE-TechWish-Sprint-2024-05-29, Content-Transform-Team-WIP, Documentation, WMDE-TechWish-Sprint-2024-05-08, WMDE-References-FocusArea, Parsoid
ssastry moved T363170: Invisible TemplateStyles objects in the visual editor from Needs Triage to Bugs & Crashers on the Parsoid board.
May 29 2024, 8:52 PM · Essential-Work, Content-Transform-Team-WIP, Parsoid, TemplateStyles, VisualEditor
ssastry moved T363170: Invisible TemplateStyles objects in the visual editor from Backlog to To Deploy on the Content-Transform-Team-WIP board.
May 29 2024, 8:51 PM · Essential-Work, Content-Transform-Team-WIP, Parsoid, TemplateStyles, VisualEditor
ssastry closed T364925: Scraper: Parsoid attaches mw:Transclusion data in <ref> tag to unexpected DOM node as Resolved.

I actually went ahead and did it -- https://www.mediawiki.org/wiki/Specs/HTML/2.8.0#[DRAFT]:_DOM_Ranges .. so going to close this ticket now. Feel free to tweak the language or poke us on slack if something is unclear and we'll update the docs.

May 29 2024, 7:32 PM · Essential-Work, WMDE-TechWish-Sprint-2024-05-29, Content-Transform-Team-WIP, Documentation, WMDE-TechWish-Sprint-2024-05-08, WMDE-References-FocusArea, Parsoid
ssastry closed T364925: Scraper: Parsoid attaches mw:Transclusion data in <ref> tag to unexpected DOM node, a subtask of T364981: Scraper: Fix how template output is collected, as Resolved.
May 29 2024, 7:31 PM · Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-05-08, WMDE-References-FocusArea
ssastry updated subscribers of T364925: Scraper: Parsoid attaches mw:Transclusion data in <ref> tag to unexpected DOM node.

Yes, we plan to update the docs -- @cscott and I chatted about a bunch of other documentation updates that is on our plate as well and we may pool everything together and update the docs. But, you can leave the ticket open.

May 29 2024, 7:15 PM · Essential-Work, WMDE-TechWish-Sprint-2024-05-29, Content-Transform-Team-WIP, Documentation, WMDE-TechWish-Sprint-2024-05-08, WMDE-References-FocusArea, Parsoid

May 24 2024

ssastry claimed T364830: Parsoid should render empty references list the same as default parser.
May 24 2024, 9:37 PM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid (Tracking), Cite, Parsoid-Read-Views
ssastry moved T364830: Parsoid should render empty references list the same as default parser from Backlog to Code Review on the Content-Transform-Team-WIP board.
May 24 2024, 9:36 PM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid (Tracking), Cite, Parsoid-Read-Views
ssastry moved T328695: Parsoid's Cite output could break gadgets, bots, user scripts from Backlog to In Progress on the Content-Transform-Team-WIP board.
May 24 2024, 9:35 PM · MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), MW-1.41-notes (1.41.0-wmf.18; 2023-07-18), Cite, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry added a comment to T363617: Reference Tooltips gadget needs tweaking for Parsoid HTML.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/1035809 fixes the accessibility markup. Maybe the changes from that patch also fixes the reference tooltip gadget?

May 24 2024, 9:26 PM · Content-Transform-Team-WIP, Cite, Parsoid-Read-Views
ssastry updated subscribers of T364687: DiscussionTools does not correctly identify titles with some variant differences.

While some fixes have landed related to T53587, we have zhwiki lang conversion disabled in Parsoid (for perf reasons), and since the findVariantLink code calls Parsoid's converter directly, those fixes are skipped for zhwiki. There are planned changes to add a level of indirection where Parsoid asks core for all language conversion which will then call Parsoid's converters if there is a native converter available. That fix will solve this problem. @cc @cscott @Arlolra

May 24 2024, 6:53 PM · Essential-Work, Content-Transform-Team-WIP, Parsoid, Chinese-Sites, DiscussionTools
ssastry added a comment to T328695: Parsoid's Cite output could break gadgets, bots, user scripts.

For completeness, here are github (non-HTML) uses of:

May 24 2024, 6:38 PM · MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), MW-1.41-notes (1.41.0-wmf.18; 2023-07-18), Cite, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid

May 23 2024

ssastry added a comment to T328695: Parsoid's Cite output could break gadgets, bots, user scripts.

I updated the stats in T328695#9125350. Given what I see there, here is an updated proposal:

May 23 2024, 9:35 PM · MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), MW-1.41-notes (1.41.0-wmf.18; 2023-07-18), Cite, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry updated subscribers of T365746: Deploy mni-Beng language converter on mniwiki.
May 23 2024, 8:19 PM · MediaWiki-Language-converter
ssastry moved T361081: Fix Special:LintErrors to use standard Title selector widget from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.
May 23 2024, 8:02 PM · Patch-For-Review, MediaWiki-extensions-Linter
ssastry moved T361411: Parsoid lints should be added to ParserOutput from Backlog to General / Tech Debt on the MediaWiki-extensions-Linter board.
May 23 2024, 8:02 PM · MediaWiki-extensions-Linter
ssastry moved T365284: Linter error location offsets point to incorrect location when multi-byte characters are present from Backlog to Parsoid on the MediaWiki-extensions-Linter board.
May 23 2024, 8:02 PM · MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Content-Transform-Team-WIP, Essential-Work, MediaWiki-extensions-Linter
ssastry added a project to T358818: Check MassMessages for Linter errors before sending: Content-Transform-Team.
May 23 2024, 7:53 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Essential-Work, Content-Transform-Team-WIP, Editing-team, MassMessage, MediaWiki-extensions-Linter
ssastry added a project to T365746: Deploy mni-Beng language converter on mniwiki: MediaWiki-Language-converter.
May 23 2024, 5:41 PM · MediaWiki-Language-converter
ssastry added a project to T363421: Prototype selective HTML updates in Parsoid: Content-Transform-Team-WIP.
May 23 2024, 3:51 PM · OKR-Work, Content-Transform-Team-WIP, Patch-For-Review, Wikimedia-Hackathon-2024, Parsoid
ssastry moved T363421: Prototype selective HTML updates in Parsoid from Needs Triage to Feature requests on the Parsoid board.
May 23 2024, 3:51 PM · OKR-Work, Content-Transform-Team-WIP, Patch-For-Review, Wikimedia-Hackathon-2024, Parsoid
ssastry removed a project from T363720: Provide ParserMigration option to exclude mobile frontend : Parsoid.
May 23 2024, 3:50 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), Content-Transform-Team-WIP, MediaWiki-extensions-ParserMigration
ssastry removed a project from T364316: Run visualdiff testing on arwiki/cswiki/huwiki Talk namespace: Parsoid.
May 23 2024, 2:30 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Hungarian-Sites, Content-Transform-Team-WIP, Editing-team (Tracking), Parsing-Active-Work, DiscussionTools
ssastry created T365706: WrapSections: PHP Notice: Undefined property: Wikimedia\Parsoid\NodeData\DataParsoid::$dsr.
May 23 2024, 12:58 PM · Parsoid, Wikimedia-production-error

May 22 2024

ssastry added a comment to T156351: Add wiki-specific CSS styles for Parsoid Cite output so that it renders exactly like core Cite output.

Anyway, to answer my own question, looks like they may be identical for most wikis, but for some wikis, they may not be (ex: eswiki). I'm going to start doing this copy-paste operation from Common.css to Minerva.css over the next couple weeks. https://www.mediawiki.org/wiki/Parsoid/Parser_Unification/Cite_CSS/Change_Log will help me with the wikis that will need this targeting. Meanwhile, I found https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/1035049 will need to also be deployed (either in Cite extension or that rule would be moved to Minerva skin codebase and added there).

May 22 2024, 9:43 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Cite, Parsoid-Rendering
ssastry added a comment to T156351: Add wiki-specific CSS styles for Parsoid Cite output so that it renders exactly like core Cite output.

Are the styles identical for each project?
If so perhaps we could use the new module proposed in T360386 ?

May 22 2024, 1:16 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Cite, Parsoid-Rendering
ssastry added a comment to T364652: Make component boundaries in MediaWiki core easier to discover.

I think the description could be edited for clarity -- we can discuss when we chat next. But, your gerrit patches helped clarify your proposal -- and I like it overall. Component boundaries in MW was something that came up in discussions in the code ownership working group and moving in this direction will make it possible to better isolate components for ownership (with all the other attendant benefits in gerrit, phab, wiki, etc. around simplifying descriptions).

May 22 2024, 2:20 AM · MW-1.43-notes (1.43.0-wmf.12; 2024-07-02), MediaWiki-Engineering
ssastry awarded T364652: Make component boundaries in MediaWiki core easier to discover a Stroopwafel token.
May 22 2024, 2:15 AM · MW-1.43-notes (1.43.0-wmf.12; 2024-07-02), MediaWiki-Engineering

May 21 2024

ssastry assigned T365433: Cannot save VisualEditor content in File namespace to ihurbain.
May 21 2024, 2:45 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Essential-Work, Content-Transform-Team-WIP, Parsoid, VisualEditor, Multi-Content-Revisions
ssastry added a project to T365433: Cannot save VisualEditor content in File namespace: Content-Transform-Team-WIP.
May 21 2024, 2:45 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Essential-Work, Content-Transform-Team-WIP, Parsoid, VisualEditor, Multi-Content-Revisions
ssastry moved T358452: Vector 2022 dynamic table of contents broken on Parsoid from Backlog to Current Deploy Target on the Content-Transform-Team-WIP board.
May 21 2024, 2:34 PM · Verified, MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), Web-Team-Backlog (FY2024-25 Q1 Sprint 1), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Web Team Essential Work 2024, Desktop Improvements (Vector 2022)
ssastry moved T353697: Parsoid/legacy parser {{Pre}} template rendering difference from Current Deploy Target to Backlog on the Content-Transform-Team-WIP board.
May 21 2024, 2:32 PM · Content-Transform-Team-WIP, Patch-For-Review, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T53587: Parsoid needs to run findVariantLink or some equivalent thing from Code Review to To Deploy on the Content-Transform-Team-WIP board.
May 21 2024, 2:29 PM · Content-Transform-Team-WIP, MediaWiki-Language-converter, Patch-For-Review, Parsoid-Read-Views (Phase 4 - Parsoid generates metadata needed by core), Parsoid-Rendering, Parsoid, Chinese-Sites
ssastry moved T258856: Links to variants titles in Parsoid are still marked as red links from Code Review to To Deploy on the Content-Transform-Team-WIP board.
May 21 2024, 2:28 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid-Rendering, Parsoid
ssastry moved T364597: Missing content on discussion tools on Parsoid from To Deploy to To Verify on the Content-Transform-Team-WIP board.
May 21 2024, 2:28 PM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), Content-Transform-Team-WIP, Parsoid, Parsoid-Read-Views

May 20 2024

ssastry updated the task description for T365309: CTT tasks week of 2024-05-17.
May 20 2024, 6:32 PM · MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), Essential-Work, Content-Transform-Team-WIP
ssastry updated the task description for T365309: CTT tasks week of 2024-05-17.
May 20 2024, 5:30 PM · MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), Essential-Work, Content-Transform-Team-WIP
ssastry added a comment to T365309: CTT tasks week of 2024-05-17.

Patch 6fe99186fb7847dd271503e23fdd03ca32f1af0f is not deployable; on hold for decisions.

May 20 2024, 5:27 PM · MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), Essential-Work, Content-Transform-Team-WIP
ssastry updated the task description for T365309: CTT tasks week of 2024-05-17.
May 20 2024, 5:19 PM · MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), Essential-Work, Content-Transform-Team-WIP

May 15 2024

ssastry merged task T364947: CTT tasks week of 2024-05-10 into T364634: CTT tasks week of 10/05/2024.
May 15 2024, 9:34 AM · Content-Transform-Team
ssastry merged T364947: CTT tasks week of 2024-05-10 into T364634: CTT tasks week of 10/05/2024.
May 15 2024, 9:34 AM · Essential-Work, Content-Transform-Team-WIP
ssastry created T364947: CTT tasks week of 2024-05-10.
May 15 2024, 5:58 AM · Content-Transform-Team
ssastry added a comment to T364024: CTT tasks week of 2024-05-03.

I've already separately monitored the known issues wiki page and discussion (and also updated that wiki page) last week. So, consider that part done as well.

May 15 2024, 5:56 AM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), Essential-Work, Content-Transform-Team-WIP
ssastry closed T364024: CTT tasks week of 2024-05-03 as Resolved.

Checked Logstash and grafana and nothing notable from the deployment.

May 15 2024, 5:55 AM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), Essential-Work, Content-Transform-Team-WIP
ssastry added a comment to T364925: Scraper: Parsoid attaches mw:Transclusion data in <ref> tag to unexpected DOM node.

In general, for any node with a typeof and an about id, you should walk the DOM forward while the about id matches and all of those dom nodes effectively belong to the structure identified by the typeof & about id. But, typeof and data-mw is only attached to the first element in the list.

May 15 2024, 3:38 AM · Essential-Work, WMDE-TechWish-Sprint-2024-05-29, Content-Transform-Team-WIP, Documentation, WMDE-TechWish-Sprint-2024-05-08, WMDE-References-FocusArea, Parsoid
ssastry closed T364925: Scraper: Parsoid attaches mw:Transclusion data in <ref> tag to unexpected DOM node as Invalid.

That is handled by the about-id assignment ("#mwt18"). Parsoid markups up a DOM forest (made up of a contiguous list of dom nodes) as "template-affected" (typically, just the template output, but sometimes also swallows up content from the top level when the template's output is not well-structured DOM output).

May 15 2024, 3:32 AM · Essential-Work, WMDE-TechWish-Sprint-2024-05-29, Content-Transform-Team-WIP, Documentation, WMDE-TechWish-Sprint-2024-05-08, WMDE-References-FocusArea, Parsoid

May 14 2024

ssastry added a comment to T364830: Parsoid should render empty references list the same as default parser.

Looks like this CSS rule doesn't apply in Parsoid because of the empty refs lists: .mw-parser-output .ts-Неоднозначность-reflist > [role="heading"]:only-child

May 14 2024, 10:57 AM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid (Tracking), Cite, Parsoid-Read-Views
ssastry added a comment to T364830: Parsoid should render empty references list the same as default parser.

Shouldn't be too hard to fix -- we just need to update the post-processing in the Cite extension code to remove empty wrappers.

May 14 2024, 10:01 AM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid (Tracking), Cite, Parsoid-Read-Views
ssastry edited projects for T364830: Parsoid should render empty references list the same as default parser, added: Cite, Parsoid (Tracking), Content-Transform-Team-WIP; removed Parsoid.
May 14 2024, 9:52 AM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid (Tracking), Cite, Parsoid-Read-Views

May 13 2024

ssastry added a comment to T358193: Investigate and fix the behaviour of Language Converter around redlinks and self-links in Parsoid.

I hope this Phase 5: (Later) doesn’t mean Parsoid read views will be enabled on wikis with language conversion (even in talk namespaces) before this is done.

May 13 2024, 12:40 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid

May 11 2024

ssastry closed T363599: Edge case parsing difference of dt/dd lists as Resolved.
May 11 2024, 3:47 AM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry moved T133673: Add width/height attributes to the <audio><video> tag from To Deploy to To Verify on the Content-Transform-Team-WIP board.
May 11 2024, 3:46 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), TimedMediaHandler, Parsoid
ssastry moved T363599: Edge case parsing difference of dt/dd lists from To Deploy to To Verify on the Content-Transform-Team-WIP board.
May 11 2024, 3:46 AM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid

May 4 2024

ssastry closed T363520: Parsoid fails to render gallery lines with filenames with html entities when missing the File: prefix as Resolved.
May 4 2024, 3:39 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), Content-Transform-Team-WIP, Parsoid
ssastry moved T363520: Parsoid fails to render gallery lines with filenames with html entities when missing the File: prefix from To Deploy to To Verify on the Content-Transform-Team-WIP board.
May 4 2024, 3:38 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), Content-Transform-Team-WIP, Parsoid
ssastry moved T133673: Add width/height attributes to the <audio><video> tag from Current Deploy Target to To Deploy on the Content-Transform-Team-WIP board.
May 4 2024, 3:38 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), TimedMediaHandler, Parsoid
ssastry added a comment to T351113: Figure out how Parsoid will work with MCR slots to support both reading and editing clients.

That said, ParserOutput already has a json object, so maybe I am worried about nothing here.

May 4 2024, 3:30 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Multi-Content-Revisions, Parsoid-Read-Views, Parsoid
ssastry added a comment to T351113: Figure out how Parsoid will work with MCR slots to support both reading and editing clients.

For now, one solution here is for us to figure out a HTML representation that lets us extract HTML for a specific slot from the combined slot output that is stored in ParserOutput. Alternatively, we would have to store slot output separately in ParserOutput in a json array -- but that leads to encoding bloat and encoding/decoding overheads. But, in either case, once we agree on the representation for this in ParserOutput, when VE asks to edit the page, we can extract the main slot output here. Ideally, VE would also ask for the slot it wants to edit in which case, we wouldn't have to hardcode this either.

May 4 2024, 3:28 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Multi-Content-Revisions, Parsoid-Read-Views, Parsoid

Apr 30 2024

ssastry moved T363599: Edge case parsing difference of dt/dd lists from Needs Triage to Bugs & Crashers on the Parsoid board.
Apr 30 2024, 5:53 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid

Apr 29 2024

ssastry moved T363599: Edge case parsing difference of dt/dd lists from Current Deploy Target to Code Review on the Content-Transform-Team-WIP board.
Apr 29 2024, 5:36 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry added a comment to T363599: Edge case parsing difference of dt/dd lists.

This is nasty ... the list handler converts the ":" in "1:00" from a listitem token to a ":" string token. But, the later occurence of ":" doesn't now get reparsed as a "lisitem"!

Apr 29 2024, 2:27 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry updated the task description for T363599: Edge case parsing difference of dt/dd lists.
Apr 29 2024, 2:23 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry committed rIVDI68ffa3945d3a: Suppress one more vertical-whitespace noisy diff on enwikivoyage.
Suppress one more vertical-whitespace noisy diff on enwikivoyage
Apr 29 2024, 2:18 PM
ssastry updated the task description for T363547: CTT tasks week of 2024-04-26.
Apr 29 2024, 1:24 PM · MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), Essential-Work, Content-Transform-Team-WIP
ssastry added a comment to T346196: Wikimedia\Assert\InvariantException: Invariant failed: Expected valid DSR.

Just documenting discussion so we don't forget. One option is to run all passes on well-formed fragments (which extension fragments are -- and enforced to be that way -- in Parsoid). This ensures that table fixups run on the extension fragment while we still have DSR offsets rather than try to run them all at once on the top-level page *after* we have cleared DSR offests on some extension fragments (like <poem>).

Apr 29 2024, 1:12 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Patch-For-Review, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ssastry added a comment to T363617: Reference Tooltips gadget needs tweaking for Parsoid HTML.

I'll update here / there once we finalize those details -- feel free to leave your thoughts there as well. But, we expect some gadgets will still need tweaking.

Apr 29 2024, 2:31 AM · Content-Transform-Team-WIP, Cite, Parsoid-Read-Views

Apr 27 2024

ssastry moved T331483: Resolve diferences between Parsoid & legacy parser TOC metadata output for template, extension, and parser-function generated content from Current Deploy Target to Backlog on the Content-Transform-Team-WIP board.
Apr 27 2024, 12:26 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry created T363617: Reference Tooltips gadget needs tweaking for Parsoid HTML.
Apr 27 2024, 6:41 AM · Content-Transform-Team-WIP, Cite, Parsoid-Read-Views
ssastry closed T358242: Reference previews don't work everywhere when using parsoid read views as Resolved.
Apr 27 2024, 6:39 AM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
ssastry added a comment to T358242: Reference previews don't work everywhere when using parsoid read views.

I am going to close this ticket and create a new one for the gadget.

Apr 27 2024, 6:38 AM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid

Apr 26 2024

ssastry moved T359882: Parsoid renders multiple TOCs if there are multiple __TOC__ magic words present from In Progress to Code Review on the Content-Transform-Team-WIP board.
Apr 26 2024, 6:26 PM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP
ssastry moved T363599: Edge case parsing difference of dt/dd lists from Backlog to Current Deploy Target on the Content-Transform-Team-WIP board.
Apr 26 2024, 6:26 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry created T363599: Edge case parsing difference of dt/dd lists.
Apr 26 2024, 5:48 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid

Apr 25 2024

ssastry added a comment to T303627: Translation unit markers interferes with comment markup in Parsoid rendering.

Is there any appetite for generic wikitext mechanism of having content that is not part of the rendered page, apart from the html-like comments that cannot be nested?

Apr 25 2024, 4:20 PM · Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsoid, MediaWiki-extensions-Translate
ssastry committed rIVDIe3a20db1300c: Remove code to strip p-tags around indicators: No longer necessary.
Remove code to strip p-tags around indicators: No longer necessary
Apr 25 2024, 12:32 PM
ssastry assigned T359886: Undefined whitespace handling behavior around category and language links to cscott.
Apr 25 2024, 8:54 AM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Content-Transform-Team-WIP

Apr 23 2024

ssastry added a comment to T363170: Invisible TemplateStyles objects in the visual editor.

That looks like a Parsoid bug - text nodes (whitespace included) should typically get span-wrapped so they get an about-id. There shouldn't be any discontinuity in about ids.

Apr 23 2024, 4:22 PM · Essential-Work, Content-Transform-Team-WIP, Parsoid, TemplateStyles, VisualEditor

Apr 20 2024

ssastry added a comment to T358242: Reference previews don't work everywhere when using parsoid read views.

This is already in production now.

Apr 20 2024, 3:45 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
ssastry updated subscribers of T361396: 1.43.0-wmf.2 deployment blockers.

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/832495 is riding this train which looks potentially risk and could cause ParserCache errors if the train is rolled back. Not sure if 1.43.1 can correctly process PC entries produced by master (1.43.2). So, I would not roll forward the train till we can establish that. I am signing off for the weekend but wanted to flag this before I disappeared because this came up in a slack conversation with Jon Robson. @cscott FYI.

Apr 20 2024, 4:58 AM · User-brennen, Release-Engineering-Team (Priority Backlog 📥), Release, Train Deployments
ssastry added a reverting change for rIVDI465d88c1a75f: Force lazy elements to be loaded: rIVDId5e75869c139: Revert "Force lazy elements to be loaded".
Apr 20 2024, 3:33 AM
ssastry committed rIVDId5e75869c139: Revert "Force lazy elements to be loaded".
Revert "Force lazy elements to be loaded"
Apr 20 2024, 3:33 AM
ssastry updated the task description for T362988: CTT tasks week of 2024-04-19.
Apr 20 2024, 3:06 AM · Essential-Work, MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Content-Transform-Team-WIP
ssastry updated the task description for T362988: CTT tasks week of 2024-04-19.
Apr 20 2024, 2:50 AM · Essential-Work, MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Content-Transform-Team-WIP

Apr 19 2024

ssastry closed T359483: Parsoid output is sometimes missing geolocation indicators as Resolved.
Apr 19 2024, 1:15 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
ssastry triaged T362034: Parsoid Kartographer causes UTF-8 errors on some pages. as Medium priority.
Apr 19 2024, 1:14 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Parsoid, Content-Transform-Team-WIP
ssastry closed T362034: Parsoid Kartographer causes UTF-8 errors on some pages. as Resolved.
Apr 19 2024, 1:14 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Parsoid, Content-Transform-Team-WIP
ssastry added a comment to T346197: Wikimedia\Assert\InvariantException: Invariant failed: Bad UTF-8 at end of string (3 byte sequence).

Those enwiki pages look fixed now.

Apr 19 2024, 1:11 PM · Patch-For-Review, Essential-Work, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ssastry added a comment to T358242: Reference previews don't work everywhere when using parsoid read views.

These work everywhere now, but the reference previews are slightly different from legacy ... the content selection code in the reference preview code probably needs an update for Parsoid's cite output. The difference is especially obvious for named references, unless of course the new output is the preferred version. :)

Apr 19 2024, 1:09 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
ssastry moved T353530: Category defaultsort should be applied in CategoryLinkTable.php from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Apr 19 2024, 1:06 PM · MW-1.42-notes, MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), MediaWiki CodeJam Dec 2023, Parsoid
ssastry moved T359483: Parsoid output is sometimes missing geolocation indicators from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Apr 19 2024, 1:06 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid