ssastry (Subramanya Sastry)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 5:34 AM (223 w, 4 d)
Availability
Available
LDAP User
Subramanya Sastry
MediaWiki User
SSastry (WMF) [ Global Accounts ]

Recent Activity

Thu, Jan 17

ssastry updated the task description for T214119: Tech Talks Proposal 2019: [WIP]: The long and winding road to making Parsoid the default MediaWiki parser.
Thu, Jan 17, 11:34 PM · Parsing-Team
ssastry created T214119: Tech Talks Proposal 2019: [WIP]: The long and winding road to making Parsoid the default MediaWiki parser.
Thu, Jan 17, 11:29 PM · Parsing-Team
ssastry renamed T214103: Instrument Parsoid language variant conversions from Instrument Parsoid language variance conversions to Instrument Parsoid language variant conversions.
Thu, Jan 17, 10:35 PM · Services (watching), Parsoid
ssastry triaged T213995: Parsoid does not apply "format" from TemplateData if the template is transcluded via a redirect as Normal priority.
Thu, Jan 17, 4:44 AM · Parsoid-Edit-Support

Wed, Jan 16

ssastry added a comment to T213922: VE removes all new lines when editing a template.

@ssastry Note that the Parsoid query is for "Infobox Officeholder" (with uppercase "O"), which is a redirect to "Infobox officeholder" (lowercase "o"). Only the latter page has templatedata. Parsoid should probably ask the MediaWiki API to follow redirects (&redirects=1). But that seems like a separate issue.

Wed, Jan 16, 11:16 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-notice, VisualEditor (Current work), Parsoid, VisualEditor-MediaWiki-Templates
ssastry created T213980: For every ported file, audit all regular expressions for subtle mismatches (especially around \s usage).
Wed, Jan 16, 11:14 PM · Parsoid-PHP
ssastry added a comment to T213922: VE removes all new lines when editing a template.

CC @Krinkle in case this is related to recent TemplateData changes?

I've re-reviewed the paramOrder change that landed week but don't see a connection for the formatting.

The aforementioned fa.wikipedia diff (link) is about a template "Infobox Officeholder". The TemplateData query for that (link) yield the following:

"format": "block",

So it seems the backend is describing the template correctly. That leaves Parsoid and VisualEditor as potential suspects. As far as I know, the serialisation based on TemplateData happens in Parsoid, not VE, so perhaps something regressed there and it no longer honouring the format?

Wed, Jan 16, 9:32 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-notice, VisualEditor (Current work), Parsoid, VisualEditor-MediaWiki-Templates
ssastry added a comment to T213922: VE removes all new lines when editing a template.

Strange. There have been no deployments since Jan 8 and even that doesn't touch any serialization code. Anyway, we test html2wt locally for this.

Wed, Jan 16, 9:17 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-notice, VisualEditor (Current work), Parsoid, VisualEditor-MediaWiki-Templates

Tue, Jan 15

ssastry updated the task description for T213228: Implement class (name to be decided) to provide access to preprocessor, extensions, and other metadata needed by Parsoid.
Tue, Jan 15, 6:12 PM · Parsoid-PHP
ssastry updated the task description for T212982: Create a ParsingEnvironment class for use with Parsoid/PHP.
Tue, Jan 15, 6:11 PM · Parsoid-PHP

Mon, Jan 14

ssastry removed a project from T208901: TemplateStyles breaks a paragraph if a file is inserted inline: RemexHtml.
Mon, Jan 14, 5:24 PM · Parsoid, TemplateStyles, MediaWiki-Parser
ssastry added a comment to T134469: doBlockLevels() inserts <p> and </p> randomly with no regard for HTML validity.
Mon, Jan 14, 5:13 PM · MediaWiki-Parser
ssastry added a comment to T208901: TemplateStyles breaks a paragraph if a file is inserted inline.

Arlo's comment here says that RemexCompatMunger treats style as a block tag.

Mon, Jan 14, 5:10 PM · Parsoid, TemplateStyles, MediaWiki-Parser
ssastry added a comment to T208901: TemplateStyles breaks a paragraph if a file is inserted inline.

After some experimentation, the issue seems to be in RemexHtml when it's adding the wrapping <p> tags:

anomie@mwmaint1002:~$ mwrepl enwiki
hphpd> $tidy = new MediaWiki\Tidy\RemexDriver( $wgTidyConfig );
hphpd> =$tidy->tidy( '<p>foo <style>/* ... */</style> bar</p>' );
"<p>foo <style>/* ... */</style> bar</p>"
hphpd> =$tidy->tidy( 'foo <style>/* ... */</style> bar' );
"<p>foo </p><style>/* ... */</style><p> bar</p>"
hphpd> =$tidy->tidy( '<div>foo <style>/* ... */</style> bar</div>' ); 
"<div>foo <style>/* ... */</style> bar</div>"
hphpd> =$tidy->tidy( '<blockquote>foo <style>/* ... */</style> bar</blockquote>' );
"<blockquote><p>foo </p><style>/* ... */</style><p> bar</p></blockquote>"

So any wikitext construct that causes the Parser to not output <p> tags itself around something Remex will add <p> tags to will result in this bug. In T208901#4726406 it's the <div> from the image syntax, while in T208901#4855856 with the <ref> added it's the <div> around the auto-generated reference list that winds up appended to the end of the paragraph there.

Mon, Jan 14, 4:59 PM · Parsoid, TemplateStyles, MediaWiki-Parser

Thu, Jan 10

ssastry edited projects for T106431: Audit SOL state of subpipelines, added: Parsoid-Read-Views; removed Parsoid.
Thu, Jan 10, 11:29 PM · Parsoid-Read-Views, Parsoid-Tokenizer
ssastry moved T213494: Installing composer modules for deployment from Backlog to Testing / QA / Deployment on the Parsoid-PHP board.
Thu, Jan 10, 11:15 PM · Parsoid-PHP
ssastry added a comment to T213493: Install PHP7 on ruthenium.

Hi @ssastry We already have ticket T201366 to setup scandium as the replacement for ruthenium. That includes a jessie to stretch upgrade which means PHP7.0, 7.1 or 7.2 could be installed.

Thu, Jan 10, 11:10 PM · Parsoid-PHP
ssastry triaged T213494: Installing composer modules for deployment as Normal priority.
Thu, Jan 10, 10:58 PM · Parsoid-PHP
ssastry created T213494: Installing composer modules for deployment.
Thu, Jan 10, 10:54 PM · Parsoid-PHP
ssastry moved T213493: Install PHP7 on ruthenium from Backlog to Testing / QA / Deployment on the Parsoid-PHP board.
Thu, Jan 10, 10:45 PM · Parsoid-PHP
ssastry triaged T213493: Install PHP7 on ruthenium as Normal priority.
Thu, Jan 10, 10:43 PM · Parsoid-PHP
ssastry created T213493: Install PHP7 on ruthenium.
Thu, Jan 10, 10:43 PM · Parsoid-PHP

Wed, Jan 9

ssastry renamed T213345: RFC: Spin off (Parsoid) language variants functionality as a Node.js microservice? from RFC: Spin off language variants functionality as a Node.js microservice? to RFC: Spin off (Parsoid) language variants functionality as a Node.js microservice?.
Wed, Jan 9, 9:47 PM · User-mobrovac, TechCom, Core Platform Team Backlog (Designing), Services (designing), MediaWiki-Language-converter, Parsoid, Language-Team, Parsing-Team
ssastry triaged T213345: RFC: Spin off (Parsoid) language variants functionality as a Node.js microservice? as Normal priority.
Wed, Jan 9, 9:35 PM · User-mobrovac, TechCom, Core Platform Team Backlog (Designing), Services (designing), MediaWiki-Language-converter, Parsoid, Language-Team, Parsing-Team
ssastry created T213345: RFC: Spin off (Parsoid) language variants functionality as a Node.js microservice?.
Wed, Jan 9, 9:35 PM · User-mobrovac, TechCom, Core Platform Team Backlog (Designing), Services (designing), MediaWiki-Language-converter, Parsoid, Language-Team, Parsing-Team
ssastry added a comment to T213228: Implement class (name to be decided) to provide access to preprocessor, extensions, and other metadata needed by Parsoid.

I note that Parsoid probably currently ignores things such as ParserOptions::getCurrentRevisionCallback() which are used in various places (e.g. previews, MediaWiki-extensions-TemplateSandbox) to affect parses for previews and such. To replace the existing PHP Parser, implementations of the interface described here will need to take those sorts of things into account when fetching template contents.

Wed, Jan 9, 3:32 PM · Parsoid-PHP

Tue, Jan 8

ssastry added a comment to T206183: Will Parsoid-PHP be a composer library, an extension, or something else?.

We have since resolved that this will be a composer library and will interface with MediaWiki core via T212982: Create a ParsingEnvironment class for use with Parsoid/PHP, T213228: Implement class (name to be decided) to provide access to preprocessor, extensions, and other metadata needed by Parsoid and one more MediaWiki core class (task yet to be created) that implements the REST API provided by Parsoid/JS.

Tue, Jan 8, 11:26 PM · Parsoid-PHP
ssastry closed T206183: Will Parsoid-PHP be a composer library, an extension, or something else? as Resolved.

We have since resolved that this will be a composer library and will interface with MediaWiki core via T212982: Create a ParsingEnvironment class for use with Parsoid/PHP, T213228: Implement class (name to be decided) to provide access to preprocessor, extensions, and other metadata needed by Parsoid and one more MediaWiki core class (task yet to be created) that implements the REST API provided by Parsoid/JS.

Tue, Jan 8, 11:25 PM · Parsoid-PHP
ssastry moved T213228: Implement class (name to be decided) to provide access to preprocessor, extensions, and other metadata needed by Parsoid from Backlog to Porting on the Parsoid-PHP board.
Tue, Jan 8, 11:23 PM · Parsoid-PHP
ssastry triaged T213228: Implement class (name to be decided) to provide access to preprocessor, extensions, and other metadata needed by Parsoid as Normal priority.
Tue, Jan 8, 11:22 PM · Parsoid-PHP
ssastry created T213228: Implement class (name to be decided) to provide access to preprocessor, extensions, and other metadata needed by Parsoid.
Tue, Jan 8, 11:22 PM · Parsoid-PHP

Mon, Jan 7

ssastry merged T206181: Low-overhead config (parsoid, wiki, env) initialization in a Parsoid-PHP world into T212982: Create a ParsingEnvironment class for use with Parsoid/PHP.
Mon, Jan 7, 11:00 PM · Parsoid-PHP
ssastry merged task T206181: Low-overhead config (parsoid, wiki, env) initialization in a Parsoid-PHP world into T212982: Create a ParsingEnvironment class for use with Parsoid/PHP.
Mon, Jan 7, 11:00 PM · Parsoid-PHP
ssastry removed a project from T205338: Extract and use a DOMHandler interface (API) for HTML -> wt handlers defined on DOM nodes: Patch-For-Review.
Mon, Jan 7, 10:59 PM · Parsoid-PHP
ssastry added a comment to T205338: Extract and use a DOMHandler interface (API) for HTML -> wt handlers defined on DOM nodes.

Oops .. I used the wrong task id on those patches

Mon, Jan 7, 10:58 PM · Parsoid-PHP
ssastry moved T211161: Tweaks to genTest option in parse.js from Prototype / Evaluation to Porting on the Parsoid-PHP board.
Mon, Jan 7, 10:55 PM · Parsoid-PHP
ssastry added a comment to T208901: TemplateStyles breaks a paragraph if a file is inserted inline.

The original discussion about template styles is T155813: Decide on storage and delivery method for TemplateStyles CSS which discusses these tradeoffs about where <style> tags appear.

Mon, Jan 7, 4:08 PM · Parsoid, TemplateStyles, MediaWiki-Parser
ssastry added a comment to T212982: Create a ParsingEnvironment class for use with Parsoid/PHP.

We'll probably want to have more than one class here.

  • One that holds the "Parsoid config" and the "Wiki config".
  • One that holds the "Page config". Which would include things Parsoid probably currently has no direct concept of like ParserOptions::getCurrentRevisionCallback().

    The former would be passed to the Parsoid service's constructor (e.g. in ServiceWiring.php), while the latter would be passed into the equivalent of Parser::parse(). The former is more likely to benefit from caching than the latter.

    We could go as far as having three objects by separating the "Parsoid config" from the "Wiki config", but my guess at this point is that in MediaWiki the line between the two will quickly be blurred. as they'll both in the end come from the Config object.
Mon, Jan 7, 4:04 PM · Parsoid-PHP

Sat, Jan 5

ssastry updated subscribers of T212987: stretch version of uprightdiff package.

@Legoktm In case you can help with this packaging of uprightdiff.

Sat, Jan 5, 12:31 AM · Packaging, Operations, Parsoid-Tests, uprightdiff

Fri, Jan 4

ssastry moved T212982: Create a ParsingEnvironment class for use with Parsoid/PHP from Backlog to Porting on the Parsoid-PHP board.
Fri, Jan 4, 11:28 PM · Parsoid-PHP
ssastry triaged T212982: Create a ParsingEnvironment class for use with Parsoid/PHP as Normal priority.
Fri, Jan 4, 11:28 PM · Parsoid-PHP
ssastry created T212982: Create a ParsingEnvironment class for use with Parsoid/PHP.
Fri, Jan 4, 11:27 PM · Parsoid-PHP

Wed, Jan 2

ssastry assigned T204617: Identify a suitable PEG.js replacement in PHP to tstarling.
Wed, Jan 2, 11:18 PM · Parsoid-PHP
ssastry closed T211365: Run all token transformers through transformTests.js to identify any other env.* mocking that needs to be in place as Resolved.
Wed, Jan 2, 11:18 PM · Parsoid-PHP
ssastry added a comment to T207303: VE doubles reference with URL–wikilink conflict.

Ya, using wikilinks in extlinks can cause this - work has begun on a new linter category T202905: Outreach-17 Project: Add a new Linter Category: Links-in-Links to identify these usages and have editors fix them.

Wed, Jan 2, 9:30 PM · Parsoid, VisualEditor

Sun, Dec 30

ssastry added a comment to T210695: Hieroglyphs are no longer inline.

https://web.archive.org/web/20171216123532/https://en.wikipedia.org/wiki/Female_genital_mutilation#Antiquity demonstrates what I am saying there. The text preceding and following the hieroglyphs have been paragraph wrapped and the hierographys render on a different line.

Sun, Dec 30, 7:39 PM · Regression, WikiHiero
ssastry added a comment to T210695: Hieroglyphs are no longer inline.

I don't see how bare text will remain p-unwrapped when tidied (whether with Tidy or with Remex). See below. I am checking out mediawiki 1.29.0 which is very old and has Tidy (not Remex). See mediawiki HTML output below. So, this is a broken expectation of the wikihiero extension if it is relying on bare text not being p-wrapped.

[subbu@earth:~/work/wmf/mediawiki] git checkout 1.29.0
HEAD is now at a112e4fa48 Allow SVGs using an older proposed recommendation DTD
[subbu@earth:~/work/wmf/mediawiki] echo "x <table><tr><td>foo</td></tr></table> y <table><tr><td>foo</td></tr></table> z" | php maintenance/parse.php --tidy
parse.php: warning: reading wikitext from STDIN. Press CTRL+D to parse.
Sun, Dec 30, 2:55 PM · Regression, WikiHiero
ssastry removed a project from T210695: Hieroglyphs are no longer inline: RemexHtml.
Sun, Dec 30, 5:36 AM · Regression, WikiHiero
ssastry added a comment to T210695: Hieroglyphs are no longer inline.

I verified that this would fix the problem by opening https://de.wikipedia.org/wiki/%C3%84gyptische_Hieroglyphen in Firefox and adding the above CSS rule -- it fixes the rendering to the desired version.

Sun, Dec 30, 5:35 AM · Regression, WikiHiero
ssastry added a comment to T210695: Hieroglyphs are no longer inline.

Inspecting the HTML and CSS of the affected hieroglyphics in Firefox, it looks like it is not the HTML that has changed, but the CSS that applies. The Sep 2017 snapshot has this CSS that isn't in the Nov 2018 snapshot

.mw-hiero-outer {
    display: inline-block;
}

Hope this helps you all in tracking down the problem.

Sun, Dec 30, 5:32 AM · Regression, WikiHiero
ssastry added a comment to T210695: Hieroglyphs are no longer inline.

@ssastry - Do you know of any changes in the HTML rendering on Commons around November 25th that might be related to this?

Sun, Dec 30, 5:22 AM · Regression, WikiHiero

Fri, Dec 21

ssastry closed T204595: Evaluate and document performance of RemexHtml vs Domino as Resolved.
Fri, Dec 21, 11:44 PM · RemexHtml, Parsoid-PHP
ssastry triaged T212543: RemexHtml DOM construction performance increases non-linearly wrt HTML size as Normal priority.
Fri, Dec 21, 11:15 PM · Parsing-Team, Performance, RemexHtml
ssastry created T212543: RemexHtml DOM construction performance increases non-linearly wrt HTML size.
Fri, Dec 21, 11:15 PM · Parsing-Team, Performance, RemexHtml
ssastry added a project to T204595: Evaluate and document performance of RemexHtml vs Domino: RemexHtml.
Fri, Dec 21, 11:13 PM · RemexHtml, Parsoid-PHP
ssastry added a comment to T204595: Evaluate and document performance of RemexHtml vs Domino.

Here are better raw numbers on different pages (and where they stack up wrt output HTML sizes relative to all wt parses on the Wikimedia cluster): Skating (< p50); Hospet (p50 - p95), Hampi (> p95), Berlin (p99), Barack_Obama (> p99) .

Fri, Dec 21, 11:07 PM · RemexHtml, Parsoid-PHP
ssastry closed T204614: Evaluate and document performance of one or two DOM transformers in node.js vs PHP as Resolved.
Fri, Dec 21, 5:48 AM · Parsoid-PHP
ssastry updated subscribers of T204614: Evaluate and document performance of one or two DOM transformers in node.js vs PHP.

Here are results on multiple pages on 3 different transforms. 50 iterations each. Script that produced raw numbers is enclosed further below. But, the net result seems to be that on smaller pages, PHP version is faster than the JS version and on larger pages, JS version gets faster than the PHP version. But, on a typical page, it seems that the PHP and JS versions might even out. However, different passes yield different results. A compute-intensive pass like DSR computation that visits every node and does a bunch of work is slower in PHP. But, a compute-lean pass like section wrapping is always much faster in PHP -- likely because the DOM API in PHP is C-backed. That is a good thing to know and maybe a good reason to consider maybe implementing the PEG tokenizer in C instead of PHP. (/cc @tstarling, @Anomie, @Tgr)

Fri, Dec 21, 5:42 AM · Parsoid-PHP

Dec 18 2018

ssastry closed T205491: QuoteTransformer and quote-tokens use a ".value" property on the token instead of adding it to the token's attributes as Resolved.
Dec 18 2018, 8:50 PM · Patch-For-Review, Parsoid-PHP
ssastry closed T209186: Create a "unit-testing" framework for DOM transformers as Resolved.
Dec 18 2018, 8:17 PM · Patch-For-Review, Parsoid-PHP
ssastry claimed T205491: QuoteTransformer and quote-tokens use a ".value" property on the token instead of adding it to the token's attributes.
Dec 18 2018, 5:37 PM · Patch-For-Review, Parsoid-PHP
ssastry added a comment to T209772: visitDOM makes an invalid assumption about its handlers.

For this helper to work the way you want, you'd either need to bind the handler before passing it in or pass in a context to apply to. The execution context of a reassigned method just isn't what this task implies it should be.

Dec 18 2018, 4:58 AM · Patch-For-Review, Parsoid

Dec 17 2018

ssastry closed T205298: Outreachy-17 microtask (Parsoid): Add new mocha tests for Parsoid's DSR functionality as Resolved.
Dec 17 2018, 4:59 PM · Parsoid-Tests, Parsoid
ssastry moved T210346: CX2: Strange display of a source paragraph in French with the {{citation}} template from Backlog to Non-Parsoid Tasks on the Parsoid board.
Dec 17 2018, 3:23 PM · Parsoid, ContentTranslation
ssastry added a comment to T210346: CX2: Strange display of a source paragraph in French with the {{citation}} template.

I doubt this is a Parsoid issue -- whenever you run into this, check the Parsoid HTML for the page from the REST API. For example, https://fr.wikipedia.org/api/rest_v1/page/html/Pierre_Gripari ... My suspicion is that there is something going on in the CX code itself. IIRC, it splits content into atomic chunks for adaptation, so maybe the duplication is happening in rendering these chunks if there is something goofy with the keys assigned to these chunks?

Dec 17 2018, 3:23 PM · Parsoid, ContentTranslation

Dec 14 2018

ssastry claimed T205337: Extract and use a token transformation interface (API) in place of custom token handlers.
Dec 14 2018, 7:08 PM · Patch-For-Review, Parsoid-PHP
ssastry added a comment to T205337: Extract and use a token transformation interface (API) in place of custom token handlers.

I decided to a quick whack at this to see what shakes out ... this can actually lead to a good amount of code simplification. Performance doesn't seem to be impacted. The code right now I have makes this work with both the NewSyncTTM and the old SyncTTM, (with parser.js configuring with one or the other), but if we find that NewSyncTTM is going to work out, we can kill ranks, add, remove, get transform code from all handlers.

Dec 14 2018, 7:08 PM · Patch-For-Review, Parsoid-PHP

Dec 13 2018

ssastry triaged T211946: Bump parsoid resource limits in production as High priority.
Dec 13 2018, 11:57 PM · Parsoid
ssastry created T211946: Bump parsoid resource limits in production.
Dec 13 2018, 11:57 PM · Parsoid
ssastry added a comment to T205337: Extract and use a token transformation interface (API) in place of custom token handlers.

Looks like at least for the sync token transformers, the following four handlers would be sufficient: onTag, onNewline, onEOF, onAny in priority order with the default implementation in the TokenHandler base class that simply returns the token unchanged. Individual transformers would override one or more of these handlers.

Dec 13 2018, 11:46 PM · Patch-For-Review, Parsoid-PHP
ssastry closed T204598: Evaluate and document performance of one or two token transformers in node.js vs PHP as Resolved.

@tstarling, @Anomie, @Legoktm: FYI. Closing this task for now, but, we can discuss these numbers and review code next quarter.

Dec 13 2018, 9:38 PM · Parsoid-PHP
ssastry updated subscribers of T204598: Evaluate and document performance of one or two token transformers in node.js vs PHP.
Dec 13 2018, 9:37 PM · Parsoid-PHP
ssastry added a comment to T204598: Evaluate and document performance of one or two token transformers in node.js vs PHP.

See numbers below. Looks like current PHP port of the transformer code takes ~1.6-1.8x longer compared to the Node.js versions. T205337: Extract and use a token transformation interface (API) in place of custom token handlers is potentially related.

Dec 13 2018, 9:34 PM · Parsoid-PHP
ssastry added a comment to T211909: Cannot read property '0' of undefined.

Ugh .. this section - template conflict and edge cases thereof are annoying.

Dec 13 2018, 6:24 PM · Parsoid
GTirloni awarded T204566: cloudvps: wikitextexp project trusty deprecation a Yellow Medal token.
Dec 13 2018, 4:52 PM · Cloud-VPS (Ubuntu Trusty Deprecation), Parsing-Team

Dec 12 2018

ssastry awarded T197242: Transition citoid to use Zotero's translation-server-v2 a Party Time token.
Dec 12 2018, 11:17 PM · Patch-For-Review, Services (done), VisualEditor (Current work), Citoid, Operations
ssastry added a comment to T211816: Wikitext parsing of unescaped < and > inside tag attributes is unexpected (different from HTML rules).

I think we can and should break compatibility in these cases.

I think we should make Parsoid the only parser and then remove the compatibility hack.

Dec 12 2018, 9:55 PM · Parsoid, MediaWiki-Parser
ssastry added a comment to T211816: Wikitext parsing of unescaped < and > inside tag attributes is unexpected (different from HTML rules).

The result is identical in the PHP parser as well as Parsoid (probably since rGPAR00ac33236f2a: Match broken attribute parsing with the php parser).

Yeah, Parsoid is going out of its way to match the PHP parser, bug for bug.

Dec 12 2018, 9:50 PM · Parsoid, MediaWiki-Parser
ssastry updated subscribers of T209493: VE is "substing" citation templates (when copying a reference defined within template-generated reflist).

@JTannerWMF For now, I moved this to the non-parsoid tasks column on the phab board. This substing looks like a VE issue as far as I can tell. Parsoid won't subst a template unless the template annotations are missing or get dropped. But, if your investigation points at Parsoid, we'll take a look.

Dec 12 2018, 3:09 PM · Cite, Parsoid, VisualEditor
ssastry moved T209493: VE is "substing" citation templates (when copying a reference defined within template-generated reflist) from Backlog to Non-Parsoid Tasks on the Parsoid board.
Dec 12 2018, 3:08 PM · Cite, Parsoid, VisualEditor
ssastry moved T211738: Clarify "mw:ExpandedAttr" annotation from Backlog to Tech Debt / Big changes on the Parsoid board.
Dec 12 2018, 3:07 PM · Patch-For-Review, Parsoid

Dec 10 2018

ssastry added a comment to T204566: cloudvps: wikitextexp project trusty deprecation.

@bd808 .. I think we are all set now with the new VMs. The old labs vms can be removed and their ips freed, etc. Let me know if you want me do anything on my end.

Dec 10 2018, 11:40 PM · Cloud-VPS (Ubuntu Trusty Deprecation), Parsing-Team
ssastry added a comment to T204566: cloudvps: wikitextexp project trusty deprecation.

Something that is missing that I noticed right away is that the skins aren't localized on these new vms .. http://de-expt-wikitextexp.wmflabs.org/wiki/Main_Page vs http://de.expt.wikitextexp.wmflabs.org/wiki/Main_Page ... but, this may just be a matter of tweaking some mediawiki config (unless I am missing some vagrant role). @Arlolra fyi in case you know what this is since I remember you messed with this on the old vms.

If memory serves me, something is detecting your Accept-Language header and giving you what you ask for. @Legoktm figured that out last time and helped me disable it. I think it was a setting from UniversalLanguageSelector.

Dec 10 2018, 11:39 PM · Cloud-VPS (Ubuntu Trusty Deprecation), Parsing-Team
ssastry added a comment to T211527: Notice: Undefined variable: wgTidyConf in /srv/mediawiki/wmf-config/CommonSettings.php on line 3672.

We anticipated that ParserMigration will have to be disabled at some point and I had specifically asked on enwiki about this ( https://en.wikipedia.org/wiki/Wikipedia_talk:Linter#Question_about_ParserMigration_extension ). I think we can disable that extension for now.

Excellent.

ParserMigration is meant to be a generic tool and was used for the Tidy migration project right now and we anticipate it will be useful for other such projects in the future. Does it need to be de-deployed or is it sufficient to have it be disabled via the config?

Nothing will break, but it's a mess. Re-deploying it later when we have a need won't be hard.

Dec 10 2018, 8:24 PM · Core Platform Team Backlog (Watching / External), Parsing-Team
ssastry added a comment to T211527: Notice: Undefined variable: wgTidyConf in /srv/mediawiki/wmf-config/CommonSettings.php on line 3672.

So this is now fixed by emergency-disabling the extension. I've written the patches to de-deploy it, but I'll wait for sign-off from the team that this was an intended consequence of their work. https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/478726/

Dec 10 2018, 8:16 PM · Core Platform Team Backlog (Watching / External), Parsing-Team
ssastry added a comment to T211527: Notice: Undefined variable: wgTidyConf in /srv/mediawiki/wmf-config/CommonSettings.php on line 3672.

Looks like this may just be a missing config patch.

Dec 10 2018, 5:07 PM · Core Platform Team Backlog (Watching / External), Parsing-Team
ssastry assigned T211527: Notice: Undefined variable: wgTidyConf in /srv/mediawiki/wmf-config/CommonSettings.php on line 3672 to cscott.
Dec 10 2018, 5:06 PM · Core Platform Team Backlog (Watching / External), Parsing-Team
ssastry closed T211461: Section edit endpoints in RESTBase: Still needed? as Resolved.

Okay, I'll close this as resolved then. No action needed.

Dec 10 2018, 4:32 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Done with CPT), User-Ryasmeen, Services (blocked), Parsoid, VisualEditor, RESTBase

Dec 9 2018

ssastry added a comment to T204566: cloudvps: wikitextexp project trusty deprecation.

The results are good. http://mw-expt-tests.wmflabs.org/ -- the failures are known issues with either db import and/or transient failures .. some of which go away when repeatedly retried.

Dec 9 2018, 9:32 PM · Cloud-VPS (Ubuntu Trusty Deprecation), Parsing-Team
ssastry closed T205336: Use lambda functions instead of .bind as Resolved.
Dec 9 2018, 8:17 PM · Patch-For-Review, Parsoid-PHP

Dec 7 2018

ssastry added a comment to T49963: Block content in links..
Dec 7 2018, 11:52 PM · Parsoid-Robustness, Parsoid, Parsoid-DOM
ssastry created T211461: Section edit endpoints in RESTBase: Still needed?.
Dec 7 2018, 10:53 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Done with CPT), User-Ryasmeen, Services (blocked), Parsoid, VisualEditor, RESTBase
ssastry added a comment to T204566: cloudvps: wikitextexp project trusty deprecation.

Results are looking good so far. Since I've identical code and identical configs on both lab and base vms, this should be a baseline number with 100% green (barring some transient errors).

Dec 7 2018, 4:51 PM · Cloud-VPS (Ubuntu Trusty Deprecation), Parsing-Team
ssastry added a comment to T204566: cloudvps: wikitextexp project trusty deprecation.

Okay .. updated the list of steps above based on what I and @bd808 did here and as part of T211367.

Dec 7 2018, 4:46 PM · Cloud-VPS (Ubuntu Trusty Deprecation), Parsing-Team
ssastry added a comment to T211367: Setting up bulk proxies for two multi-wiki mw-vagrant labs vms.

Can you say more what this manual fixing was about? Was this because of something I did wrong (or a missing puppet class or something transient)? Or do we need to this always? Asking because I am putting together all the steps in one place for next time.

I think it was related to your dump and then load of all database tables from the older deployment.

Dec 7 2018, 4:30 PM · Patch-For-Review, cloud-services-team (Kanban), Cloud-VPS (Ubuntu Trusty Deprecation), Parsing-Team
ssastry added a comment to T211367: Setting up bulk proxies for two multi-wiki mw-vagrant labs vms.
$ vagrant provision
...
Failed miserably
$ vagrant ssh
$ mysql
# manually fixed root and vagrant users to use unix_socket auth
Dec 7 2018, 4:12 PM · Patch-For-Review, cloud-services-team (Kanban), Cloud-VPS (Ubuntu Trusty Deprecation), Parsing-Team

Dec 6 2018

ssastry added a comment to T211367: Setting up bulk proxies for two multi-wiki mw-vagrant labs vms.

I think this means that we need to:

  1. Add quota to allow 2 more floating IPs for the project
  2. Attach floating ips to the new hosts
  3. Ensure that the new hosts have the necessary locally installed nginx reverse proxy
  4. Update the *.base.wikitextexp.wmflabs.org and *.expt.wikitextexp.wmflabs.org DNS entries to point to the new hosts
  5. Verify that things work as expected
  6. Release the old floating IPs
  7. Reduce the floating IP quota back to 2
  8. Delete the old vms
  9. Profit!

Alternately, we could make this less of a special snowflake project

Dec 6 2018, 7:48 PM · Patch-For-Review, cloud-services-team (Kanban), Cloud-VPS (Ubuntu Trusty Deprecation), Parsing-Team
ssastry created T211367: Setting up bulk proxies for two multi-wiki mw-vagrant labs vms.
Dec 6 2018, 7:04 PM · Patch-For-Review, cloud-services-team (Kanban), Cloud-VPS (Ubuntu Trusty Deprecation), Parsing-Team
ssastry renamed T205339: Implement Parsoid's API / URL routing in MediaWiki core from Evaluate ease / difficulty of implementing Parsoid's API / URL routing in MediaWiki core to Implement Parsoid's API / URL routing in MediaWiki core.
Dec 6 2018, 6:49 PM · Parsoid-PHP
ssastry moved T205339: Implement Parsoid's API / URL routing in MediaWiki core from Prototype / Evaluation to Porting on the Parsoid-PHP board.
Dec 6 2018, 6:45 PM · Parsoid-PHP