Page MenuHomePhabricator

ssastry (Subramanya Sastry)
User

Projects (18)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 5:34 AM (356 w, 2 d)
Availability
Available
LDAP User
Subramanya Sastry
MediaWiki User
SSastry (WMF) [ Global Accounts ]

Recent Activity

Tue, Aug 3

ssastry changed the subtype of T287931: Investigate DOM with <li> nodes not found in <ol>/<ul> elements from "Production Error" to "Bug Report".
Tue, Aug 3, 3:55 AM · Parsoid
ssastry changed the subtype of T287932: Investigate missing ref id found in Parsoid HTML from "Production Error" to "Bug Report".
Tue, Aug 3, 3:55 AM · Parsoid
ssastry changed the subtype of T287933: [error/html2wt/figure] Couldn't parse media structure from "Production Error" to "Bug Report".
Tue, Aug 3, 3:55 AM · Parsoid
ssastry updated the task description for T287933: [error/html2wt/figure] Couldn't parse media structure.
Tue, Aug 3, 3:54 AM · Parsoid
ssastry created T287933: [error/html2wt/figure] Couldn't parse media structure.
Tue, Aug 3, 3:53 AM · Parsoid
ssastry created T287932: Investigate missing ref id found in Parsoid HTML.
Tue, Aug 3, 3:34 AM · Parsoid
ssastry created T287931: Investigate DOM with <li> nodes not found in <ol>/<ul> elements.
Tue, Aug 3, 3:23 AM · Parsoid

Fri, Jul 30

ssastry added a comment to T270199: Table of contents in Parsoid output.

We can simply move it to ParserOutput as one more derived output property and have clients do what they want to do with it. Between Platform Engineering and us, we are going to be working on T287216 which effectively will create a base class / interface for the current ParserOutput class and that would be a good time to slot it there.

Fri, Jul 30, 2:34 PM · Readers-Web-Backlog (Tracking), Desktop Improvements, Parsoid-Rendering, Parsoid
ssastry added a comment to T286402: Indentation / colons removed from existing comments / list-items when adding a new reply.

Thanks for the reduced test case. Here are example scenarios that all merit handling the same way.

: <div>Hi
:: Ho</div>
Fri, Jul 30, 3:18 AM · Editing-team (Tracking), DiscussionTools, Parsoid

Wed, Jul 28

ssastry added a comment to T287611: TypeError: Argument 1 passed to Wikimedia\Parsoid\Utils\DOMCompat::getOuterHTML() must be an instance of Wikimedia\Parsoid\DOM\Compat\Element, instance of DOMElement given.

But, looks like if we are going to down this class alias route to support Dodo, we will need to figure out how to address non-Parsoid-repo uses of DOMCompat class from Parsoid's repo.

Wed, Jul 28, 6:13 PM · Patch-For-Review, Skipped QA, Editing-team (FY2021-22 Kanban Board), Wikimedia-production-error, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), DiscussionTools, Parsoid
ssastry added a comment to T287611: TypeError: Argument 1 passed to Wikimedia\Parsoid\Utils\DOMCompat::getOuterHTML() must be an instance of Wikimedia\Parsoid\DOM\Compat\Element, instance of DOMElement given.

This is not on production yet. So, all good there. But yes will impact beta cluster. Will make sure @cscott sees this.

Wed, Jul 28, 5:54 PM · Patch-For-Review, Skipped QA, Editing-team (FY2021-22 Kanban Board), Wikimedia-production-error, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), DiscussionTools, Parsoid

Tue, Jul 27

ssastry created T287432: Move FormatJson class from core into a library for use outside core as well..
Tue, Jul 27, 1:35 AM · Parsoid, Librarization

Mon, Jul 26

ssastry lowered the priority of T287419: `mediawiki-core-php72-phan-docker` job runs `composer install` instead of using packages from mediawiki/vendor from Unbreak Now! to Medium.
Mon, Jul 26, 10:55 PM · Parsoid (Tracking), Release-Engineering-Team (Radar), Continuous-Integration-Config, Patch-For-Review, ci-test-error (WMF-deployed Build Failure), MediaWiki-Vendor
ssastry added a comment to T287419: `mediawiki-core-php72-phan-docker` job runs `composer install` instead of using packages from mediawiki/vendor.

Okay, tagged a new version of Parsoid as -a10 and that seems to have fixed the problem.

Mon, Jul 26, 10:48 PM · Parsoid (Tracking), Release-Engineering-Team (Radar), Continuous-Integration-Config, Patch-For-Review, ci-test-error (WMF-deployed Build Failure), MediaWiki-Vendor
ssastry updated subscribers of T287419: `mediawiki-core-php72-phan-docker` job runs `composer install` instead of using packages from mediawiki/vendor.

I am confused by these failures. That reverted patch on vendor should have completely removed all references to Dodo from vendor, so i don't know why those CI jobs are even running into Dodo at all!

Mon, Jul 26, 9:44 PM · Parsoid (Tracking), Release-Engineering-Team (Radar), Continuous-Integration-Config, Patch-For-Review, ci-test-error (WMF-deployed Build Failure), MediaWiki-Vendor

Thu, Jul 22

ssastry added a comment to T287220: Pull out ParsoidOptions from ParserOptions.

This is the domain of the html2html transformations piece (see these preliminary slides -- sorry non-WMF folks, I'll work to make these accessible soonish by updating them and uploading them somewhere accessible). The question of where html2html transforms ought to sit and what is cached or not and whether they are extensions, services, or in core or in Parsoid is all up for discussion. Whether there ought to be a framework / libraries to support ease of spinning these up is also up for discussion.

Thu, Jul 22, 11:37 PM · Parsoid
ssastry added a comment to T287220: Pull out ParsoidOptions from ParserOptions.

I am in the bikeshedding mode, and in that vein, here goes:

Thu, Jul 22, 11:02 PM · Parsoid
ssastry added a comment to T287216: ParserOutput should implement ParsoidOutput.
Thu, Jul 22, 10:32 PM · Parsoid
ssastry added a comment to T287216: ParserOutput should implement ParsoidOutput.
  • WikitextOutput -- doesn't work because there are other content models
  • PageOutput -- doesn't work because you can have page-independent content transformation
  • Output -- doesn't work because it is far too generic
  • PageBundle -- Parsoid already has this concept but probably misnamed for the same reason PageOutput is not
  • ContentBundle -- this or probably Content + some synonym of Bundle ?
Thu, Jul 22, 10:25 PM · Parsoid
ssastry awarded T287216: ParserOutput should implement ParsoidOutput a Yellow Medal token.
Thu, Jul 22, 10:21 PM · Parsoid
ssastry added a comment to T287216: ParserOutput should implement ParsoidOutput.

We need do a quick name bikeshedding for this and maybe not call it ParsoidOutput.

Thu, Jul 22, 10:17 PM · Parsoid
ssastry closed T276512: Common newline diff in DiscussionTools edits as Resolved.
Thu, Jul 22, 8:03 PM · DiscussionTools, Parsoid
ssastry created T287198: [EPIC] Ensure all extensions use on the Talk namespace of Wikimedia wikis are Parsoid-compatible.
Thu, Jul 22, 5:28 PM · Parsing-Active-Work, Parsoid-Rendering, Parsoid
ssastry removed a project from T282499: Consider whether Parsoid will support forced linear parsing.: Parsing-Active-Work.
Thu, Jul 22, 5:13 PM · MediaWiki-extensions-Variables, Parsoid, MediaWiki-Parser

Wed, Jul 21

ssastry added a comment to T208619: Parsoid missing an empty row in table output.

Any reason not to decline this.? This is probably a wontfix and a waste of time to try to sync output.

Wed, Jul 21, 2:36 PM · Parsoid
ssastry awarded T285713: Hard-deprecate Parser::mUser public access, Parser::getUser and ParserOptions::getUser a Yellow Medal token.
Wed, Jul 21, 2:30 PM · Patch-For-Review, MediaWiki-Parser, Platform Team Workboards (MW Expedition)

Tue, Jul 20

ssastry added a comment to T287001: Core tests failing due to Flow HTTP requests and ServiceContainer access.

Might have been caused by https://gerrit.wikimedia.org/r/c/integration/quibble/+/703182 which could have changed the way Parsoid requests made by Flow go, possibly?

Tue, Jul 20, 6:17 PM · Release-Engineering-Team (Radar), Patch-For-Review, User-DannyS712, Growth-Team, ci-test-error (WMF-deployed Build Failure), StructuredDiscussions
ssastry added a comment to T285417: Connect testing flows for push notification development.

@Jgiannelos should be able to devote some time to this next week -- the team has been a bit heads down on the maps rollout preparations and trying to cram things in between availability of others that are needed for this. Thanks for the heads up about your requirements around this.

Tue, Jul 20, 4:12 PM · Product-Infrastructure-Team-Backlog, iOS-app-v6.9-Carp-On-A-Zamboni, Wikipedia-iOS-App-Backlog

Sat, Jul 17

ssastry added a comment to T286839: [error/p-wrap] Failed assertion in onNewLineOrEOF: newline-count:1 ; current line tokens: [" "].

Sample test case based on a metawiki page that triggered this "warning" in rt-testing:

<p>                                                                                                      
<translate> foo</translate>                                                                              
</p>
Sat, Jul 17, 2:11 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Parsoid, Wikimedia-production-error
ssastry created T286840: [error] Unexpected structure when adding media info..
Sat, Jul 17, 5:26 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Parsoid, Wikimedia-production-error
ssastry created T286839: [error/p-wrap] Failed assertion in onNewLineOrEOF: newline-count:1 ; current line tokens: [" "].
Sat, Jul 17, 5:23 AM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Parsoid, Wikimedia-production-error

Fri, Jul 16

ssastry added a comment to T286786: Error: Bad regular expression.

Ah, ok.

Fri, Jul 16, 4:24 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Parsoid, Wikimedia-production-error
ssastry added a comment to T286786: Error: Bad regular expression.
Fri, Jul 16, 3:18 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Parsoid, Wikimedia-production-error
ssastry created T286786: Error: Bad regular expression.
Fri, Jul 16, 2:12 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Parsoid, Wikimedia-production-error

Tue, Jul 13

ssastry added a comment to T286402: Indentation / colons removed from existing comments / list-items when adding a new reply.

All of the en.wp examples involve using {{tq2|{{#section:WT:COUNTRIES|summary}}}} inside nested lists (someone really likes quoting that policy), which I guess ends up generating misnested <blockquote> tags and wikitext list items. Reduced test case: https://en.wikipedia.org/w/index.php?title=User:Matma_Rex/sandbox&oldid=1033331490. It renders wrong in the old parser too!

Tue, Jul 13, 3:55 AM · Editing-team (Tracking), DiscussionTools, Parsoid

Mon, Jul 12

ssastry added a comment to T286402: Indentation / colons removed from existing comments / list-items when adding a new reply.

At first glance, my hunch is that it could potentially be bad DSR values - curious is there is broken wikitext in any of those lists. Will take a look later this week.

Mon, Jul 12, 10:24 PM · Editing-team (Tracking), DiscussionTools, Parsoid
ssastry added a comment to T286401: Mismatched closing </b> tag added.

Aha .... curious why we have that exception there for specific node names.

Mon, Jul 12, 10:06 PM · DiscussionTools, Parsoid
ssastry added a comment to T286401: Mismatched closing </b> tag added.

But, this should impact any stripped closing tag in a list item, not just in this misnested scenario ... so there is that piece as well.

Mon, Jul 12, 8:09 PM · DiscussionTools, Parsoid
ssastry added a comment to T286401: Mismatched closing </b> tag added.

The placeholder has zero width there, so, the DSR should line up properly.

Mon, Jul 12, 8:07 PM · DiscussionTools, Parsoid
ssastry added a comment to T286425: Babel link shown in source form in Parsoid/VisualEditor mode.

The expanded wikitext is This user has [[m::Special:MyLanguage/Main Page|near native speaker]] knowledge of [[m::Category:User_en|English]]. and so Parsoid doesn't recognize the m:: prefix as a valid interwiki prefix whereas the core parser seems to let the :: pass.

Mon, Jul 12, 2:21 AM · MediaWiki-extensions-Babel, Parsoid

Sun, Jul 11

ssastry added a comment to T286401: Mismatched closing </b> tag added.

There is misnested <i><b>...</i></b> (HTML tags, not wikitetx) in there and I suspect something is broken with DSR computation in the wt->html direction causing this. This is some edge case but my recommendation is to just fix up the wikitext and the bad nesting.

Sun, Jul 11, 3:45 PM · DiscussionTools, Parsoid

Jul 2 2021

ssastry reopened T266509: Make testreduce web UI publicly accessible on the internet as "Open".

Reopening to follow up on the failure to fully serve all the static files.

Jul 2 2021, 11:48 PM · Patch-For-Review, Parsoid (Tracking), Parsoid-Tests, serviceops, SRE
ssastry reopened T266509: Make testreduce web UI publicly accessible on the internet, a subtask of T257906: Move testreduce away from scandium to a separate Buster Ganeti VM, as Open.
Jul 2 2021, 11:47 PM · Parsoid (Tracking), Patch-For-Review, Parsoid-Tests, serviceops, SRE

Jul 1 2021

ssastry added a comment to T73962: When Tidy is enabled, wikitext like [[Link|<div>Text</div>]] will not actually produce a clickable link.

I was wondering if perhaps Parsoid handles this correctly if it's the p-wrap logic at fault.

Jul 1 2021, 8:48 PM · HTML5, RemexHtml, Tidy, MediaWiki-Parser

Jun 15 2021

ssastry added a comment to T282585: Provide for asynchronously-available MediaWiki parser content fragments / components.

T268785: IDEA: Move parallel tag parsing logic from Math to core is related.

Jun 15 2021, 4:22 PM · MediaWiki-Parser, tech-decision-forum, Abstract Wikipedia team

Jun 14 2021

ssastry added a comment to T284921: Remove "auto-number headings" preference .

span.tocnumber { display: none; } should do it right?

Nah, this has to be a misunderstanding. This task has nothing to do with the toc.

Jun 14 2021, 10:07 PM · Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-Cache, MediaWiki-Parser, Platform Engineering
ssastry added a comment to T284921: Remove "auto-number headings" preference .

span.tocnumber { display: none; } should do it right?

Jun 14 2021, 8:54 PM · Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-Cache, MediaWiki-Parser, Platform Engineering
ssastry added a comment to T284921: Remove "auto-number headings" preference .

I support removing many of these rarely used user prefs that cause HTML to vary by these prefs. But, independent of that this one is easily controlled by CSS without modifying the HTML.

Jun 14 2021, 7:01 PM · Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-Cache, MediaWiki-Parser, Platform Engineering
ssastry added a comment to T208619: Parsoid missing an empty row in table output.

Also see this:

[subbu@earth:~/work/wmf/parsoid] echo "<table></table>" | php ../core/maintenance/parse.php 
parse.php: warning: reading wikitext from STDIN. Press CTRL+D to parse.
Jun 14 2021, 3:53 PM · Parsoid

Jun 11 2021

ssastry added a comment to T284693: Wikimedia\Assert\InvariantException: Invariant failed: Bad UTF-8 at end of string (3 byte sequence).

These utf-8 errors are caused by a combination of things: either bad encoding stored in the db, "bad markup", or real bugs in Parsoid. These errors helped us find and fix most of these. The remaining ones are still some lingering ones we haven't investigated because there are far fewer of them now. But, yes I agree that it is probably time to migrate these remaining errors to a different log channel. We'll chat about this in the coming week.

Jun 11 2021, 6:14 PM · Parsoid, Wikimedia-production-error
ssastry added a comment to T279825: 504 timeout with Parsoid service and Visual Editor.

Good sleuthing! Didn't realize envoy and parsoid-async timeouts were involved in the picture. That will let us proceed with T244609 where I had landed at the wrong place assuming the problem was in Parsoid's PEG.

Jun 11 2021, 2:15 PM · Parsoid (Tracking), VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Jun 10 2021

ssastry added a comment to T209120: Upgrade Parsoid HTML stored in the StructuredDiscussions tables.

@kostajh, sorry this mail got lost in my post-vacation volume. But, please scope this and if necessary, we can schedule a review meeting to see which pieces need which of us to work on and where the components ought to live.

Jun 10 2021, 4:49 PM · Growth-Team-Filtering, Growth-Team, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Technical-Debt, StructuredDiscussions, Parsoid

Jun 9 2021

ssastry edited projects for T280450: PHP Warning: Cannot modify header information - headers already sent by (output started at /srv/mediawiki/php-1.37.0-wmf.1/includes/MediaWiki.php:817), added: Parsoid (Tracking); removed Parsoid.
Jun 9 2021, 9:48 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Parsoid (Tracking), Wikimedia-production-error
ssastry added a comment to T284693: Wikimedia\Assert\InvariantException: Invariant failed: Bad UTF-8 at end of string (3 byte sequence).

For the benefit of train engineers, I wanted to note that these UTF-8 errors seen in Parsoid are expected to come up in spurts (lots of errors on the same page OR repeated errors because of retries). So, unless there is a significant spike, this shouldn't be a concern for deployments.

Jun 9 2021, 8:00 PM · Parsoid, Wikimedia-production-error

Jun 8 2021

ssastry added a comment to T284135: Add jgianellos and mbsantos to maps-root group.

Indeed. Thanks for flagging me. Approved.

Jun 8 2021, 4:39 PM · SRE-Access-Requests, SRE

Jun 7 2021

ssastry edited projects for T261181: Make Translate extension compatible with Parsoid, added: Parsoid; removed Parsoid (Tracking).
Jun 7 2021, 3:57 PM · Patch-For-Review, Language-Team (Language-2021-July-September), Parsoid, Technical-Debt, Editing-team (Tracking), Editing-Team-Request, MediaWiki-extensions-Translate
ssastry added a comment to T261181: Make Translate extension compatible with Parsoid.

@ssastry T274881: Change translation variable (tvar) syntax is now done pending QA. Does that unblock your work? Is there anything else we should do on our side?

Jun 7 2021, 3:55 PM · Patch-For-Review, Language-Team (Language-2021-July-September), Parsoid, Technical-Debt, Editing-team (Tracking), Editing-Team-Request, MediaWiki-extensions-Translate
ssastry added a member for Trusted-Contributors: ihurbain.
Jun 7 2021, 2:55 PM
ssastry added a comment to T284437: Grant Access to ldap/wmf for ihurbain.

@Volans let me know if you need anything from me as @ihurbain's manager.

Jun 7 2021, 2:36 PM · SRE, LDAP-Access-Requests

Jun 5 2021

ssastry added a comment to T280381: 413 error while trying to fetch using desktop api.

Both those scenarios will be alleviated by addressing T211946: Bump parsoid resource limits in production.

Jun 5 2021, 1:52 PM · Patch-For-Review, Parsoid, Services, affects-Kiwix-and-openZIM, RESTBase-API

May 21 2021

ssastry added a comment to T283353: Dirty diff with newline changes for table inside <onlyinclude>.

I couldn't reproduce readily with a bunch of simplified test cases on the command line. So, this looks like some edge case specific to this page, if at all.

May 21 2021, 2:43 PM · VisualEditor, Parsoid

May 12 2021

ssastry added a comment to T280450: PHP Warning: Cannot modify header information - headers already sent by (output started at /srv/mediawiki/php-1.37.0-wmf.1/includes/MediaWiki.php:817).

The reason I filed it then (and it is being filed repeatedly again) is that this was a change in behavior - this was not being logged before at all. So, did something change in core around request timeouts? Or did something change in logging?

May 12 2021, 7:48 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Parsoid (Tracking), Wikimedia-production-error

May 10 2021

ssastry added a comment to T236809: Refactor Parser.php to allow alternate parser (Parsoid).

Anyway, let us please end this thread here. We'll take a look at your specific usecase and see what we can do.

May 10 2021, 9:41 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), MediaWiki-extensions-Variables, MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Parsing-Active-Work, Patch-For-Review, Parsoid, MediaWiki-Parser
ssastry added a comment to T236809: Refactor Parser.php to allow alternate parser (Parsoid).

I appreciate and welcome your input but was mostly countering your assertion that your viewpoint and experience is representative of small and medium-sized wikis or that we are ignoring small and medium-sized 3rd party wikis in general. When smaller wikis are behind by several versions, a proposed shift in a future LTS doesn't really count as "an overnight shift" nor as a "slap in the face". Please be careful with your charged statements.

May 10 2021, 9:35 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), MediaWiki-extensions-Variables, MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Parsing-Active-Work, Patch-For-Review, Parsoid, MediaWiki-Parser
ssastry added a comment to T236809: Refactor Parser.php to allow alternate parser (Parsoid).

So, hopefully you can understand that migrating to something that will essentially break all of that isn't just a pain point for us, it's simply not a viable option.

May 10 2021, 9:05 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), MediaWiki-extensions-Variables, MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Parsing-Active-Work, Patch-For-Review, Parsoid, MediaWiki-Parser
ssastry added a comment to T236809: Refactor Parser.php to allow alternate parser (Parsoid).

If this is a real blocker, then, we'll have to introduce some kind of page property OR some kind of extension config option that will force full sequential reparse for any page that has that flag or extension config set.

To me that sounds like the Parsing Team is open to modifying Parsoid to support your use case.

I would really appreciate clarification on this point, since right above it is stated "However, if extensions introduce state that depends on the page parsed in linear order, yes, we cannot support that.". At the time I read this, this lead me to the conclusion that this is more of a theoretical possibility which has no real chance to be implemented.

But rereading this again, this might actually be a misunderstanding.

May 10 2021, 8:40 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), MediaWiki-extensions-Variables, MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Parsing-Active-Work, Patch-For-Review, Parsoid, MediaWiki-Parser
ssastry added a comment to T236809: Refactor Parser.php to allow alternate parser (Parsoid).

None of my comments above and here is to engage with any of the criticism of us making WMF-centric decisions. That is a separate issue and I am not going to wade those waters here. I would like to focus my attention and discussion on the specific issues of wikitext engines in MediaWiki and their future and the migration paths.

May 10 2021, 8:22 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), MediaWiki-extensions-Variables, MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Parsing-Active-Work, Patch-For-Review, Parsoid, MediaWiki-Parser
ssastry added a comment to T236809: Refactor Parser.php to allow alternate parser (Parsoid).

As a general principle, we cannot avoid breaking changes or technical upgrades just because there are wikis that use some specific set of features or use them in a particular way.

May 10 2021, 7:12 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), MediaWiki-extensions-Variables, MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Parsing-Active-Work, Patch-For-Review, Parsoid, MediaWiki-Parser

May 5 2021

ssastry added a comment to T281923: npm audit security report for parsoid: found 1 high severity vulnerability (Prototype Pollution in "merge" package).

Awesome! Thanks Arlo for digging. I think we can skip a new security release for Parsoid/JS. If necessary, we can email a security advisory with how to fix this (upgrade package.json and npm update). I cannot wait for the day when Parsoid/JS goes EOL.

May 5 2021, 8:55 PM · SecTeam-Processed, Parsoid, User-DannyS712, Security, Security-Team

May 4 2021

ssastry triaged T281932: Invariant failed: Expected an element (from Parsoid DOMUtils) as Medium priority.
May 4 2021, 11:11 PM · MediaWiki-extensions-Linter, Parsoid, Wikimedia-production-error

Apr 30 2021

ssastry lowered the priority of T281141: Nested subsections are incorrectly tagged with section number from Medium to Low.
Apr 30 2021, 10:46 PM · Parsoid, Parsoid-Rendering, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
ssastry added a comment to T281141: Nested subsections are incorrectly tagged with section number.

Interesting .. I think Parsoid's behavior is the right one here (what if you want to add new content and convert that from an "empty" section to a non-empty one), but that does no one any good since the core notion of sections is what is used by section-edit links.

Apr 30 2021, 6:48 PM · Parsoid, Parsoid-Rendering, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Apr 27 2021

ssastry updated subscribers of T280766: Phase out legacy error, warning and success classes for usage outside the parser.

Good questions.

Apr 27 2021, 10:54 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, MediaWiki-extensions-CentralAuth, User-notice, Technical-Debt

Apr 26 2021

ssastry removed a subtask for T261329: Prepare Parsoid for MW 1.37 (ideally): T261220: Zero Config Install of VE + Parsoid for MW 1.36.
Apr 26 2021, 3:34 PM · Parsoid (Third-party)
ssastry removed a parent task for T261220: Zero Config Install of VE + Parsoid for MW 1.36: T261329: Prepare Parsoid for MW 1.37 (ideally).
Apr 26 2021, 3:34 PM · Editing-team (Third-party), Parsoid (Third-party), VisualEditor, MW-1.36-release
ssastry removed a subtask for T280270: parsoid REL1_36 branch and tag: T261329: Prepare Parsoid for MW 1.37 (ideally).
Apr 26 2021, 3:33 PM · Parsoid (Third-party), MW-1.36-release
ssastry removed a parent task for T261329: Prepare Parsoid for MW 1.37 (ideally): T280270: parsoid REL1_36 branch and tag.
Apr 26 2021, 3:33 PM · Parsoid (Third-party)
ssastry added a comment to T261329: Prepare Parsoid for MW 1.37 (ideally).

We are realistically not going to do all this work before RC0. I am going to remove this as a blocker for MW 1.36 release. We should retarget the tasks for 1.37 and be more realistic and about what we intend to really work on for that release.

Apr 26 2021, 3:33 PM · Parsoid (Third-party)

Apr 23 2021

ssastry assigned T261220: Zero Config Install of VE + Parsoid for MW 1.36 to cscott.
Apr 23 2021, 10:53 PM · Editing-team (Third-party), Parsoid (Third-party), VisualEditor, MW-1.36-release

Apr 21 2021

ssastry added a comment to T276620: Whitespace around comment removed.

Yes, I noticed. I expect it is some edge case where the conditions for whitespace reuse were obviously not satisfied. I'll ignore this for now unless we see more of them showing up.

Apr 21 2021, 3:02 PM · Parsoid, DiscussionTools
ssastry added a comment to T223277: List embedded in description list <dd> (descriptions) causes LISTGAP issues (old Parser only; does not affect Parsoid).

Parsoid doesn't have this bug:

[subbu@earth:~/work/wmf/parsoid] php bin/parse.php --normalize < /tmp/wt
Apr 21 2021, 2:28 PM · MediaWiki-Parser
ssastry updated subscribers of T280051: Make mobilefrontend talk overlay disableable.

See T272987 - this won't be resolved right away, but yes, @cscott has successfully advocated for that to be one of the first Parsoid read view use cases.

Apr 21 2021, 2:34 AM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, Editing-team (FY2021-22 Kanban Board), DiscussionTools

Apr 20 2021

ssastry triaged T280672: RT-testing crashers: DOMException: Not Found Error as Medium priority.
Apr 20 2021, 1:40 PM · Parsoid

Apr 19 2021

ssastry created T280603: html2wt: Be careful about separate reuse from original source in link (and other) misnesting scenarios.
Apr 19 2021, 11:03 PM · Technical-Debt, Parsoid
ssastry edited projects for T265518: Move Parsoid ServiceWorker.php and extension/src/Config into core, added: MW-1.37-release; removed MW-1.36-release.
Apr 19 2021, 5:46 PM · MW-1.37-release, Parsoid

Apr 17 2021

ssastry created T280450: PHP Warning: Cannot modify header information - headers already sent by (output started at /srv/mediawiki/php-1.37.0-wmf.1/includes/MediaWiki.php:817).
Apr 17 2021, 5:29 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Parsoid (Tracking), Wikimedia-production-error
ssastry created T280449: Error: Bad regular expression.
Apr 17 2021, 5:25 PM · Parsoid, Wikimedia-production-error

Apr 16 2021

Esanders awarded T280050: Broken link wikitext leads to content duplication a Yellow Medal token.
Apr 16 2021, 3:49 PM · Patch-For-Review, Parsoid, DiscussionTools

Apr 15 2021

ssastry added a comment to T280246: Error "No such file or directory ... Maintenance.php".

Looks like you are needing a lot of detailed guidance and support in some of this work. I recommend you try to ensure your MediaWiki is set up properly with Parsoid configured properly. And, then, you need to ensure that the XML dump is properly imported (including all templates, modules, and necessary extensions). Then, you can fetch the HTML for it from your MediaWiki install. If you are having trouble doing this setup, please find the appropriate support forum (maybe someone can point you to them). We aren't really set up to provide this level of support. In any case, Phabricator is not the right forum for this level of troubleshooting / MediaWiki support.

Apr 15 2021, 6:22 PM · Parsoid (Third-party)
ssastry added a comment to T280246: Error "No such file or directory ... Maintenance.php".

My ultimate goal is to parse the Wiki xml dump into HTML. There are many parsers available, but Parsoid is of course the best. The resulted HTML will allow me to create contents adapted to different devices and read on different software (GoldenDict, Google Chrome, Microsoft Edge, Mdict, ...). I'm sure that a lot of people will benefit from this. My short-term goal is to build a dictionary for GoldenDict from Wiktionary dump.

Apr 15 2021, 4:20 PM · Parsoid (Third-party)
ssastry added a comment to T280246: Error "No such file or directory ... Maintenance.php".

Oh, none of us had reviewed it. +2ed it now. :-)

Apr 15 2021, 3:34 PM · Parsoid (Third-party)
ssastry updated subscribers of T280246: Error "No such file or directory ... Maintenance.php".
reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core/vendor/wikimedia/parsoid$ echo 'Foo' | MW_INSTALL_PATH=/var/www/wiki/mediawiki/core php bin/parse.php --integrated
Unexpected option integrated!
Apr 15 2021, 3:33 PM · Parsoid (Third-party)

Apr 14 2021

Kozuch awarded T263854: [Maps] Modernize Vector Tile Infrastructure a Like token.
Apr 14 2021, 3:39 PM · Tech-Product API Roadmap, Code-Health-Objective, Platform Engineering Roadmap, Product Infrastructure Roadmap, Maps, Epic, Product-Infrastructure-Team-Backlog

Apr 13 2021

ssastry added a comment to T279867: In the preview, the table syntax is processed even if it is inside nowiki .

Possibly related issue: T248039

Apr 13 2021, 2:55 PM · Patch-For-Review, Parsoid, VisualEditor

Apr 12 2021

ssastry closed T276620: Whitespace around comment removed, a subtask of T250184: Non-semantic (whitespace, formatting) issues w/ Parsoid output on Talk pages, as Resolved.
Apr 12 2021, 10:23 PM · Editing-team (Tracking), DiscussionTools, Parsoid
ssastry closed T276620: Whitespace around comment removed as Resolved.
Apr 12 2021, 10:23 PM · Parsoid, DiscussionTools
ssastry added a comment to T279912: If there are two warnings, then the second falls out of the "permissions-errors" block.

Parsoid doesn't have this bug, so one less thing to worry about there.

Apr 12 2021, 3:11 PM · MediaWiki-Parser, Design, MediaWiki-Interface
ssastry added a comment to T248039: Parsoid misunderstands {{!}} as | and breaks table cell.

Actually, I am not sure this is right. This time around (compared to Mar 2020 when I seem to have hastily reponded), I actually tested this. See https://www.mediawiki.org/w/index.php?title=User:SSastry_(WMF)/Sandbox&oldid=4525962 ...

Apr 12 2021, 2:06 PM · Parsoid

Apr 9 2021

ssastry updated the task description for T279803: PHP Notice: Undefined index: .
Apr 9 2021, 7:09 PM · Patch-For-Review, Parsoid, Wikimedia-production-error
ssastry triaged T279803: PHP Notice: Undefined index: as Medium priority.
Apr 9 2021, 7:09 PM · Patch-For-Review, Parsoid, Wikimedia-production-error