Page MenuHomePhabricator

ssastry (Subbu)
User

Projects (23)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 5:34 AM (441 w, 6 d)
Availability
Available
IRC Nick
subbu
LDAP User
Subramanya Sastry
MediaWiki User
SSastry (WMF) [ Global Accounts ]

Recent Activity

Sat, Mar 25

ssastry added a comment to T156351: Add wiki-specific CSS styles for Parsoid Cite output so that it renders exactly like core Cite output.

... in this case it seems like instead of making improvements in, say, making so that some messages in MediaWiki can be language-agnostic and be used in every language, we went the complicated path of making 200+ language versions have to do (for now at least) two versions of Cite syntax, and silently removed any other customisation.

Sat, Mar 25, 3:58 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Cite, Parsoid-Rendering
ssastry added a comment to T156351: Add wiki-specific CSS styles for Parsoid Cite output so that it renders exactly like core Cite output.

These backports that you are doing across many Wikimedia projects, if they are needed, should be in the core, not in many individual CSS files.

Sat, Mar 25, 3:09 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Cite, Parsoid-Rendering
ssastry added a comment to T333031: <section> wrappers in Parsoid output can interfere with CSS rules that use child (direct descendent) selectors.

I should have written a better description -- I'll update it later. But, the summary is that we won't remove section tags from Parsoid's canonical HTML that is stored in the Parser Cache and which will be available via APIs. But, HTML served for read views might have some post-processing to reduce HTML size. See https://www.mediawiki.org/wiki/Parsoid/Parser_Unification/Performance and T272331: Evaluate and recommend strategies for ensuring Parsoid HTML payload doesn't degrade performance in low-resource contexts..

Sat, Mar 25, 3:25 AM · Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsoid

Fri, Mar 24

ssastry removed a project from T272936: Make CentralNotice extension compatible with Parsoid: Parsoid-Read-Views.

For now, we can continue to rely on the legacy parser for handling wikitext in banners. No need to block read views on this task.

Fri, Mar 24, 9:20 PM · Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Parsoid-Rendering, Parsoid
ssastry removed a project from T272934: Make CiteThisPage extension compatible with Parsoid: Parsoid-Read-Views.

This implements a SpecialPage and as such we can continue to let it be parsed by the legacy parser. No need to block on it for read views.

Fri, Mar 24, 9:14 PM · CiteThisPage, Parsoid-Rendering, Parsoid
ssastry moved T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.
Fri, Mar 24, 9:06 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T332933: Ensure Parsoid Read Views code path correctly handles ParserOptions from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.
Fri, Mar 24, 9:06 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T333023: Complete Parsoid TOC implementation from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.
Fri, Mar 24, 9:06 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T332934: Add tests to ensure we catch ParserCache divergences between edit and read view code paths from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.
Fri, Mar 24, 9:06 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T333031: <section> wrappers in Parsoid output can interfere with CSS rules that use child (direct descendent) selectors from Uncategorized to Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid on the Parsoid-Read-Views board.
Fri, Mar 24, 9:05 PM · Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsoid
ssastry created T333031: <section> wrappers in Parsoid output can interfere with CSS rules that use child (direct descendent) selectors.
Fri, Mar 24, 7:44 PM · Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsoid
ssastry moved T332903: Wikimedia\Parsoid\Utils\TitleException: Invalid Talk namespace title <title> from Backlog to To Deploy on the Content-Transform-Team-WIP board.
Fri, Mar 24, 7:38 PM · Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ssastry moved T332903: Wikimedia\Parsoid\Utils\TitleException: Invalid Talk namespace title <title> from Needs Triage to Bugs & Crashers on the Parsoid board.
Fri, Mar 24, 7:37 PM · Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ssastry assigned T332903: Wikimedia\Parsoid\Utils\TitleException: Invalid Talk namespace title <title> to cscott.
Fri, Mar 24, 7:37 PM · Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ssastry closed T268777: "Responsive References" configuration should be exported by a hook as Resolved.
Fri, Mar 24, 7:12 PM · MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Content-Transform-Team-WIP, Parsoid, Cite
ssastry added a comment to T332243: NOTOC causing API action=parse prop=sections to return nothing.

@cscott is currently working on a fix. It'll take a bit to get it right, get it reviewed and merged. See T332243#8716049 above.

Fri, Mar 24, 5:33 PM · MW-1.40-release, Patch-For-Review, MediaWiki-Action-API, Ultraviolet, MediaWiki-Parser

Thu, Mar 23

ssastry updated the task description for T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry.
Thu, Mar 23, 7:28 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry created T332934: Add tests to ensure we catch ParserCache divergences between edit and read view code paths.
Thu, Mar 23, 7:19 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry created T332933: Ensure Parsoid Read Views code path correctly handles ParserOptions.
Thu, Mar 23, 7:17 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry added a parent task for T328034: ParsoidCachePrewarmJob should set the useParsoid ParserOption: T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry.
Thu, Mar 23, 7:16 PM · Patch-For-Review, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Content-Transform-Team-WIP, MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Performance-Team (Radar), MediaWiki-Parser, RESTbase Sunsetting, Parsoid
ssastry added a subtask for T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry: T328034: ParsoidCachePrewarmJob should set the useParsoid ParserOption.
Thu, Mar 23, 7:16 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry added a subtask for T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry: T317018: Make HtmlOutputRendererHelper use ParserOutputAccess.
Thu, Mar 23, 7:14 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry added a parent task for T317018: Make HtmlOutputRendererHelper use ParserOutputAccess: T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry.
Thu, Mar 23, 7:14 PM · Patch-For-Review, RESTbase Sunsetting, Platform Team Workboards (MW Expedition)
ssastry created T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry.
Thu, Mar 23, 7:13 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry added a comment to T325761: Wikimedia\Assert\InvariantException: Invariant failed: Bad UTF-8 at end of string (2 byte sequence).

The only utf-8 ones left now have always been for "Main Page" of ukwiki, ruwiki, bewiki. That indicates someone is POSTing some wikitext to the API which makes it harder to debug without having access to the wikitext in question. We have been ignoring this in the Parsoid logstash for a while now as possibly user error. But, maybe we should dump the wikitext being POSTed and see if we can figure out if it is an issue in Parsoid. But, need to figure out what the best way to do this is since the POSTed wikitext could be large blobs.

Thu, Mar 23, 3:19 PM · Parsoid, Wikimedia-production-error

Wed, Mar 22

ssastry removed a project from T272938: Make Score extension compatible with Parsoid: Parsoid-Read-Views.
Wed, Mar 22, 7:50 PM · MediaWiki-extensions-Score, Parsoid-Rendering, Parsoid
ssastry updated subscribers of T272938: Make Score extension compatible with Parsoid.

Looking at the Score extension code, it looks like the only markup that is impacted is image linking. But, @Arlolra has been working to have legacy parser generate Parsoid-style output for images. So, we may be have to get away without needing to write a Parsoid-native handler and simply continuing to proxy calls to the legacy parser.

Wed, Mar 22, 7:50 PM · MediaWiki-extensions-Score, Parsoid-Rendering, Parsoid
ssastry removed a project from T272935: Make CharInsert extension compatible with Parsoid: Parsoid-Read-Views.

Looking at the CharInsert code, I think we can safely proxy this to the legacy parser for now without any impact. So, removing this as a blocker.
But, for anyone looking at this, it should be simple to create Parsoid-native handlers.

Wed, Mar 22, 7:45 PM · CharInsert, Parsoid-Rendering, Parsoid
ssastry added a subtask for T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid: T272940: Make SubPageList3 extension compatible with Parsoid.
Wed, Mar 22, 7:36 PM · Parsoid-Read-Views, Parsing-Active-Work, Parsoid-Rendering, Parsoid
ssastry added a parent task for T272940: Make SubPageList3 extension compatible with Parsoid: T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid.
Wed, Mar 22, 7:36 PM · MediaWiki-extensions-SubPageList3, Parsoid-Rendering, Parsoid
ssastry removed a parent task for T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid: T272940: Make SubPageList3 extension compatible with Parsoid.
Wed, Mar 22, 7:36 PM · Parsoid-Read-Views, Parsing-Active-Work, Parsoid-Rendering, Parsoid
ssastry removed a subtask for T272940: Make SubPageList3 extension compatible with Parsoid: T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid.
Wed, Mar 22, 7:36 PM · MediaWiki-extensions-SubPageList3, Parsoid-Rendering, Parsoid
ssastry added a subtask for T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid: T272946: Make timeline extension compatible with Parsoid.
Wed, Mar 22, 7:36 PM · Parsoid-Read-Views, Parsing-Active-Work, Parsoid-Rendering, Parsoid
ssastry added a parent task for T272946: Make timeline extension compatible with Parsoid: T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid.
Wed, Mar 22, 7:36 PM · EasyTimeline, Parsoid-Rendering, Parsoid
ssastry removed a parent task for T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid: T272946: Make timeline extension compatible with Parsoid.
Wed, Mar 22, 7:35 PM · Parsoid-Read-Views, Parsing-Active-Work, Parsoid-Rendering, Parsoid
ssastry removed a subtask for T272946: Make timeline extension compatible with Parsoid: T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid.
Wed, Mar 22, 7:35 PM · EasyTimeline, Parsoid-Rendering, Parsoid
ssastry added a comment to T272946: Make timeline extension compatible with Parsoid.

I added back the parent task -- that epic isn't about read views necessarily - but about ensuring these extensions have native Parsoid handlers.

Wed, Mar 22, 7:35 PM · EasyTimeline, Parsoid-Rendering, Parsoid
ssastry added a comment to T272940: Make SubPageList3 extension compatible with Parsoid.

I added back the parent task -- that epic isn't about read views necessarily - but about ensuring these extensions have native Parsoid handlers.

Wed, Mar 22, 7:34 PM · MediaWiki-extensions-SubPageList3, Parsoid-Rendering, Parsoid
ssastry added a subtask for T272946: Make timeline extension compatible with Parsoid: T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid.
Wed, Mar 22, 7:33 PM · EasyTimeline, Parsoid-Rendering, Parsoid
ssastry added a subtask for T272940: Make SubPageList3 extension compatible with Parsoid: T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid.
Wed, Mar 22, 7:33 PM · MediaWiki-extensions-SubPageList3, Parsoid-Rendering, Parsoid
ssastry added parent tasks for T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid: T272946: Make timeline extension compatible with Parsoid, T272940: Make SubPageList3 extension compatible with Parsoid.
Wed, Mar 22, 7:33 PM · Parsoid-Read-Views, Parsing-Active-Work, Parsoid-Rendering, Parsoid
ssastry added a comment to T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid.

Ooops. I am going to add back all those subtasks (except 3D which isn't a tag extension or uses parser hooks afaict). This epic isn't about read views necessarily - but about ensuring these extensions have native Parsoid handlers.

Wed, Mar 22, 7:32 PM · Parsoid-Read-Views, Parsing-Active-Work, Parsoid-Rendering, Parsoid
ssastry removed a project from T272933: Make CategoryTree extension compatible with Parsoid: Parsoid-Read-Views.

Looking at the CategoryTree code, I think we can safely proxy this to the legacy parser for now without any impact. So, removing this as a blocker.

Wed, Mar 22, 7:30 PM · MediaWiki-extensions-CategoryTree, Parsoid-Rendering, Parsoid
ssastry moved T272937: Make Listings extension compatible with Parsoid from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.
Wed, Mar 22, 7:06 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MediaWiki-extensions-Listings, Parsoid-Rendering, Parsoid
ssastry added a comment to T272937: Make Listings extension compatible with Parsoid.

Looks likes this builds up a bunch of wikitext and then parses it to HTML. This is only enabled on wikivoyages except (en, de, it). This looks like a fairly straightforward (if a bit cumbersome) port to Parsoid.

Wed, Mar 22, 7:05 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MediaWiki-extensions-Listings, Parsoid-Rendering, Parsoid
ssastry removed a subtask for T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid: T272940: Make SubPageList3 extension compatible with Parsoid.
Wed, Mar 22, 7:00 PM · Parsoid-Read-Views, Parsing-Active-Work, Parsoid-Rendering, Parsoid
ssastry removed a parent task for T272940: Make SubPageList3 extension compatible with Parsoid: T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid.
Wed, Mar 22, 7:00 PM · MediaWiki-extensions-SubPageList3, Parsoid-Rendering, Parsoid
ssastry removed a project from T272940: Make SubPageList3 extension compatible with Parsoid: Parsoid-Read-Views.

This extension constructs wikitext for a list with links to subpages and parses it to render the subpage listing. So, we can continue to render this with the legacy parser for now - there is no great loss in not having Parsoid-style HTML for the subpage links, especially given its sparse usage ( only enabled on cswiktionary and wikiversity besides labs and test wiki ).

Wed, Mar 22, 7:00 PM · MediaWiki-extensions-SubPageList3, Parsoid-Rendering, Parsoid
ssastry removed a parent task for T272932: Make 3D extension compatible with Parsoid: T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid.
Wed, Mar 22, 6:51 PM · 3D, Parsoid-Rendering, Parsoid
ssastry removed a subtask for T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid: T272932: Make 3D extension compatible with Parsoid.
Wed, Mar 22, 6:51 PM · Parsoid-Read-Views, Parsing-Active-Work, Parsoid-Rendering, Parsoid
ssastry removed a project from T272932: Make 3D extension compatible with Parsoid: Parsoid-Read-Views.

This is not a tag extension - nothing to do here for read views.

Wed, Mar 22, 6:51 PM · 3D, Parsoid-Rendering, Parsoid
ssastry removed a subtask for T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid: T272946: Make timeline extension compatible with Parsoid.
Wed, Mar 22, 4:09 PM · Parsoid-Read-Views, Parsing-Active-Work, Parsoid-Rendering, Parsoid
ssastry removed a parent task for T272946: Make timeline extension compatible with Parsoid: T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid.
Wed, Mar 22, 4:09 PM · EasyTimeline, Parsoid-Rendering, Parsoid
ssastry removed a project from T272946: Make timeline extension compatible with Parsoid: Parsoid-Read-Views.

Since Parsoid can continue to call the legacy parser for expanding wikitext it doesn't natively support (ex: extension tags like these), Parsoid can continue to proxy expansion of such extensions to the legacy parser. The only constraint is on extensions that accept wikitext constructs and process them.

Wed, Mar 22, 4:00 PM · EasyTimeline, Parsoid-Rendering, Parsoid
ssastry added a comment to T328034: ParsoidCachePrewarmJob should set the useParsoid ParserOption.

.We can't really avoid the complexity of ensuring the right options are set, because we need to options to be set in order to determine which ParserCache instance to use. Otherwise, we'd have to loop this information through separately, which would require us to change method signatures on all the relevant code paths.

Wed, Mar 22, 12:54 PM · Patch-For-Review, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Content-Transform-Team-WIP, MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Performance-Team (Radar), MediaWiki-Parser, RESTbase Sunsetting, Parsoid

Tue, Mar 21

ssastry added a comment to T328034: ParsoidCachePrewarmJob should set the useParsoid ParserOption.

If the different PC instances in code map to the same backing store (mysql for now), presumably, the cache name would be used for the physical "split" of the shared backing store, but that would presumably still be simpler than trying to mess with options? It is possible I am missing something in this discussion.

Tue, Mar 21, 7:06 PM · Patch-For-Review, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Content-Transform-Team-WIP, MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Performance-Team (Radar), MediaWiki-Parser, RESTbase Sunsetting, Parsoid
ssastry added a comment to T328034: ParsoidCachePrewarmJob should set the useParsoid ParserOption.

But, I am asking about actually instantiating a new instance (vs "splitting" a cache). My understanding of splitting is that the same cache instance is used but the cache key ensures that different entries are used within that instance. There seems to be a some complexity in ensuring that the right set of options are set on save and fetch of the right cached entry. It seems like a different instance would avoid that.

Tue, Mar 21, 7:02 PM · Patch-For-Review, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Content-Transform-Team-WIP, MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Performance-Team (Radar), MediaWiki-Parser, RESTbase Sunsetting, Parsoid
ssastry added a comment to T328034: ParsoidCachePrewarmJob should set the useParsoid ParserOption.

I am going ask a possibly stupid question. It seems like the best strategy overall would be to use a different cache instance (instead of a trying to vary by options) for 'useParsoid'. I know we talked about that in the past and I thought that was the solution that you all had landed on as well. Trying to use the same cache instance but use varying options seems unnecessarily complicated to me. Given the different output that Parsoid and legacy parser generate, different PC instances seems like the best approach to me.

Tue, Mar 21, 4:33 PM · Patch-For-Review, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Content-Transform-Team-WIP, MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Performance-Team (Radar), MediaWiki-Parser, RESTbase Sunsetting, Parsoid
ssastry moved T107332: Parsoid-native implementation for <indicator> (page status indicators) from Backlog to In Progress on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
Tue, Mar 21, 4:42 AM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid-Rendering, Parsoid
ssastry moved T270199: Table of contents in Parsoid output from Code Review to To Verify on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
Tue, Mar 21, 4:41 AM · Content-Transform-Team-WIP, Patch-For-Review, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid-Rendering, Parsoid
ssastry moved T156351: Add wiki-specific CSS styles for Parsoid Cite output so that it renders exactly like core Cite output from Code Review to To Deploy on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
Tue, Mar 21, 4:41 AM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Cite, Parsoid-Rendering
ssastry moved T107332: Parsoid-native implementation for <indicator> (page status indicators) from Backlog to In Progress on the Content-Transform-Team-WIP board.
Tue, Mar 21, 4:30 AM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid-Rendering, Parsoid
ssastry claimed T107332: Parsoid-native implementation for <indicator> (page status indicators).
Tue, Mar 21, 4:29 AM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid-Rendering, Parsoid

Sat, Mar 18

ssastry added a comment to T332457: Adopt a stable interface policy refactor.

Core and Ext are the only two namespaces that should be used outside parsoid, and everything in them is @stable unless otherwise marked; everything outside those two namespaces is @internal (and shouldn't be marked otherwise)."

Sat, Mar 18, 3:04 AM · Parsoid

Fri, Mar 17

ssastry closed T331486: Visual Editor produces garbage with HTML entities inside templates as Resolved.

https://en.wikipedia.org/api/rest_v1/page/html/User:SSastry_(WMF)%2FSandbox/1144869788 looks right now.

Fri, Mar 17, 2:50 AM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Editing-team (Tracking), Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Content-Transform-Team-WIP, Parsoid, VisualEditor

Thu, Mar 16

ssastry moved T331486: Visual Editor produces garbage with HTML entities inside templates from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Thu, Mar 16, 1:00 AM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Editing-team (Tracking), Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Content-Transform-Team-WIP, Parsoid, VisualEditor
ssastry closed T331629: HTTP 412 Errors when editing Officewiki as Resolved.
Thu, Mar 16, 12:59 AM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), MediaWiki-REST-API, serviceops, Parsoid
ssastry created T332242: Wikimedia\Parsoid\Utils\TitleException: Invalid characters in title "Special:ParserFunction/REDIRECT [[]]".
Thu, Mar 16, 12:50 AM · Parsoid, Wikimedia-production-error

Tue, Mar 14

ssastry committed rIVDI29115eb04219: Changes after translatewiki fr message change was reverted (authored by ssastry).
Changes after translatewiki fr message change was reverted
Tue, Mar 14, 8:40 PM

Sat, Mar 11

ssastry added a comment to T331733: References display as "[lower-alpha 1]" in mobile VE.

Never mind. I found T190083: Make MediaWiki:Mobile.css render-blocking and friends.

Sat, Mar 11, 5:40 AM · Editing-team (Tracking), MobileFrontend, Parsoid, VisualEditor
ssastry added a comment to T331733: References display as "[lower-alpha 1]" in mobile VE.

It is not possible to move these into template styles or core since these are for references and wikis have traditionally been able to customize their rendering on-wiki. Trying to customize citations server-size in Parsoid doesn't work for VE editing (desktop or mobile) which is why CSS based customization was originally proposed in the first place back in 2013/2014 and nothing fundamental has changed there.

Sat, Mar 11, 4:47 AM · Editing-team (Tracking), MobileFrontend, Parsoid, VisualEditor

Fri, Mar 10

ssastry updated subscribers of T331733: References display as "[lower-alpha 1]" in mobile VE.

Yes, this will require us to copy over wiki-specific CSS changes added to Commons.css to Mobile.css. T156351: Add wiki-specific CSS styles for Parsoid Cite output so that it renders exactly like core Cite output is the task where that happened.

Fri, Mar 10, 4:06 PM · Editing-team (Tracking), MobileFrontend, Parsoid, VisualEditor

Thu, Mar 9

ssastry edited projects for T331629: HTTP 412 Errors when editing Officewiki, added: MediaWiki-REST-API; removed RESTBase.

Officewiki does not use RESTBase.

Thu, Mar 9, 2:55 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), MediaWiki-REST-API, serviceops, Parsoid

Tue, Mar 7

ssastry moved T331486: Visual Editor produces garbage with HTML entities inside templates from Backlog to Code Review on the Content-Transform-Team-WIP board.
Tue, Mar 7, 10:56 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Editing-team (Tracking), Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Content-Transform-Team-WIP, Parsoid, VisualEditor
ssastry moved T331486: Visual Editor produces garbage with HTML entities inside templates from Backlog to Code Review on the Parsoid-Read-Views (Phase 2 - testwiki Main namespace support) board.
Tue, Mar 7, 10:56 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Editing-team (Tracking), Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Content-Transform-Team-WIP, Parsoid, VisualEditor
ssastry moved T331486: Visual Editor produces garbage with HTML entities inside templates from Needs Triage to Bugs & Crashers on the Parsoid board.
Tue, Mar 7, 10:56 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Editing-team (Tracking), Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Content-Transform-Team-WIP, Parsoid, VisualEditor
ssastry triaged T331486: Visual Editor produces garbage with HTML entities inside templates as Medium priority.
Tue, Mar 7, 10:56 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Editing-team (Tracking), Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Content-Transform-Team-WIP, Parsoid, VisualEditor
ssastry claimed T331486: Visual Editor produces garbage with HTML entities inside templates.

This is probably an edge-case bug in the TableFixups code in Parsoid.

Tue, Mar 7, 10:20 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Editing-team (Tracking), Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Content-Transform-Team-WIP, Parsoid, VisualEditor
ssastry created T331483: Resolve diferences between Parsoid & legacy parser TOC metadata output for template, extension, and parser-function generated content.
Tue, Mar 7, 9:15 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T268777: "Responsive References" configuration should be exported by a hook from In Progress to Code Review on the Content-Transform-Team-WIP board.
Tue, Mar 7, 7:25 PM · MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Content-Transform-Team-WIP, Parsoid, Cite
ssastry merged task T329784: Make Proofread Page extension compatible with Parsoid into T278481: Parsoid native implementation of the Proofread Page extension.
Tue, Mar 7, 7:24 PM · Parsoid-Rendering, Parsoid, ProofreadPage
ssastry added a subtask for T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid: T278481: Parsoid native implementation of the Proofread Page extension.
Tue, Mar 7, 7:23 PM · Parsoid-Read-Views, Parsing-Active-Work, Parsoid-Rendering, Parsoid
ssastry added a parent task for T278481: Parsoid native implementation of the Proofread Page extension: T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid.
Tue, Mar 7, 7:23 PM · Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), ProofreadPage, Parsoid
ssastry merged T329784: Make Proofread Page extension compatible with Parsoid into T278481: Parsoid native implementation of the Proofread Page extension.
Tue, Mar 7, 7:23 PM · Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), ProofreadPage, Parsoid
ssastry added a comment to T330802: Stray blockquote tag removed.

Scott: I wouldn't be so sure that Parsoid didn't do this ;-) There are edge case in the newline separator insertion code -- and that whole code needs an overhaul some day based on all the accumulated knowledge of the last decade and test cases. But, yes, it could be a result of the HTML we got from DT. Anyway, all I am saying is "Needs investigation".

Tue, Mar 7, 6:12 PM · Parsoid, DiscussionTools
ssastry moved T328695: Parsoid's Cite output is missing accessibility attributes from Backlog to Blocked on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
Tue, Mar 7, 6:29 AM · Cite, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T328695: Parsoid's Cite output is missing accessibility attributes from Backlog to Blocked on the Content-Transform-Team-WIP board.
Tue, Mar 7, 6:29 AM · Cite, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry added a comment to T328695: Parsoid's Cite output is missing accessibility attributes.

Looks like this will get resolved once Parsoid is integrated into the rendering pipeline and ResourceLoader will add all the relevant modules, in this case, the ext.cite.a11y.js and ext.cite.highlighting.js.

Tue, Mar 7, 6:28 AM · Cite, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry closed T289191: References section heading missing in Portuguese as Resolved.

In https://pt.wikipedia.org/api/rest_v1/page/html/Sebastian_Vettel topics Vitórias por equipe and Referências belong to the same section with data-mw-section-id=13 (see the shot)

Tue, Mar 7, 5:29 AM · Content-Transform-Team-WIP, Parsoid, Product-Infrastructure-Team-Backlog-Deprecated

Mon, Mar 6

ssastry edited projects for T331122: Dirty diffs on Media: links on non-English wikis, added: Parsoid (Tracking); removed Parsoid.

Okay, moving this to Tracking on the Parsoid board.

Mon, Mar 6, 8:38 PM · Editing-team (Tracking), Parsoid (Tracking), VisualEditor

Sun, Mar 5

ssastry committed rIVDI56f5ae9e6212: Remove not needed CSS rules (authored by ssastry).
Remove not needed CSS rules
Sun, Mar 5, 4:36 AM
ssastry committed rIVDIe8a0a010eed2: Reuse counter-styles defined in Mediawiki:Common.css of a few wikis (authored by ssastry).
Reuse counter-styles defined in Mediawiki:Common.css of a few wikis
Sun, Mar 5, 4:36 AM

Sat, Mar 4

ssastry added a comment to T156351: Add wiki-specific CSS styles for Parsoid Cite output so that it renders exactly like core Cite output.

Hi, I'm here regarding the change that was made on nowiki (presumably also on several other wikis) linking to this task.

Will this change work for mobile (MinervaNeue & the mobile apps) too? Asking since Minerva doesn't load MediaWiki:Common.css.

Sat, Mar 4, 3:53 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Cite, Parsoid-Rendering
ssastry added a comment to T156351: Add wiki-specific CSS styles for Parsoid Cite output so that it renders exactly like core Cite output.

Parsoid is trying to encourage wikis to rely on CSS for customizing Cite output instead of site messages.

Why? It feels a lot messier to have 30 lines of code no one would remember what are for and that would likely not be copied to new wikis for years vs a neat 1 line ns8 message.

Sat, Mar 4, 3:49 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Cite, Parsoid-Rendering
ssastry added a comment to T331122: Dirty diffs on Media: links on non-English wikis.

It might be worth checking if Parsoid will not dirty if you run selser with VE's HTML as your new.html but where you update the mw:WikiLink back to mw:MediaLink. If that doesn't get dirtied, it would indicate that a fix in VE would fix the problem. If not, we probably have things to find in both Parsoid and VE.

Sat, Mar 4, 3:56 AM · Editing-team (Tracking), Parsoid (Tracking), VisualEditor

Fri, Mar 3

ssastry created T331084: TypeError: Argument 2 passed to Wikimedia\Parsoid\Config\StubMetadataCollector::collect() must be of the type string, int given,.
Fri, Mar 3, 4:47 AM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Parsoid, Wikimedia-production-error

Wed, Mar 1

ssastry committed rIVDI4f2d7e96e82a: Fix svwiki & eswiki rules + use .mw-ref not sup.reference (authored by ssastry).
Fix svwiki & eswiki rules + use .mw-ref not sup.reference
Wed, Mar 1, 12:02 AM

Tue, Feb 28

ssastry committed rIVDI7b4fa5ae49de: Remove bogus rules from early days of visual diff testing (authored by ssastry).
Remove bogus rules from early days of visual diff testing
Tue, Feb 28, 7:28 PM
ssastry added a comment to T313265: App gives no indication that user script pages are protected when reading them.

Filed T330772: Mobile-html switchover to REST API (from RESTBase) should account for http 400 response for non-wikitext content models.

Tue, Feb 28, 4:29 PM · Wikipedia-Android-App-Backlog (Android Release FY2022-23), Content-Transform-Team-WIP, Page Content Service
ssastry created T330772: Mobile-html switchover to REST API (from RESTBase) should account for http 400 response for non-wikitext content models.
Tue, Feb 28, 4:28 PM · Content-Transform-Team-WIP, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, RESTbase Sunsetting, Page Content Service, MediaWiki-REST-API