Page MenuHomePhabricator

ssastry (Subramanya Sastry)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 5:34 AM (258 w, 2 d)
Availability
Available
LDAP User
Subramanya Sastry
MediaWiki User
SSastry (WMF) [ Global Accounts ]

Recent Activity

Yesterday

ssastry added a comment to T231569: Deploy Parsoid-PHP (integrated with Mediawiki) to the beta cluster.

@mobrovac, Can I punt this puppet updates to you? We cannot do this via the horizon UI and this needs a puppet patch. I tried enabling role::parsoid::testing via the UI and it needs a parsoid_port hieradata property which isn't available right now.

Wed, Sep 18, 7:53 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, Parsoid-PHP
ssastry added a comment to T232183: Potential bugs in SiteConfig.php regular expressions used in WikitextSerializer.

So, y'day I dumped the regexp on scandium on one of the test pages and here it is:

'/^((?:(?:#REDIRECT)[ \t\n\r\x0c]*(?::[ \t\n\r\x0c]*)?\[\[[^\]]+\]\])?(?:\[\[Category\:[^\]]*?\]\]|__(?:(?i:(?P<a_notoc>__NOTOC__)|(?P<a_nogallery>__NOGALLERY__)|(?P<a_forcetoc>__FORCETOC__)|(?P<a_toc>__TOC__)|(?P<a_noeditsection>__NOEDITSECTION__)|(?P<a_notitleconvert>__NOTITLECONVERT__)|(?P<b_notitleconvert>__NOTC__)|(?P<a_nocontentconvert>__NOCONTENTCONVERT__)|(?P<b_nocontentconvert>__NOCC__))|(?P<a_newsectionlink>__NEWSECTIONLINK__)|(?P<a_nonewsectionlink>__NONEWSECTIONLINK__)|(?P<a_hiddencat>__HIDDENCAT__)|(?P<a_expectunusedcategory>__EXPECTUNUSEDCATEGORY__)|(?P<a_index>__INDEX__)|(?P<a_noindex>__NOINDEX__)|(?P<a_staticredirect>__STATICREDIRECT__)|(?P<a_noglobal>__NOGLOBAL__)|(?P<a_disambiguation>__DISAMBIG__))__|\<\!\-\-\(\?\>\[\\s\\S\]\*\?\-\-\>\))*)(<nowiki>\s+<\/nowiki>)([^\n]*(?:\n|$))/Dim';
Wed, Sep 18, 5:35 PM · Parsoid-PHP
ssastry added a comment to T231569: Deploy Parsoid-PHP (integrated with Mediawiki) to the beta cluster.

@ssastry were you able to confirm Parsoid/PHP works as advertised on parsoid-php-beta.wmflabs.org ?

I will need to figure out how to test since that domain isn't configured anywhere in config. So, I imagine I need to use some host headers / proxies or something to actually test. Do you know how I might be able to test this?

Wed, Sep 18, 2:56 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, Parsoid-PHP
ssastry added a comment to T231569: Deploy Parsoid-PHP (integrated with Mediawiki) to the beta cluster.

@ssastry were you able to confirm Parsoid/PHP works as advertised on parsoid-php-beta.wmflabs.org ?

Wed, Sep 18, 2:43 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, Parsoid-PHP

Tue, Sep 17

ssastry added a comment to T231569: Deploy Parsoid-PHP (integrated with Mediawiki) to the beta cluster.

So, some other config seems to be off.

Tue, Sep 17, 10:50 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, Parsoid-PHP
ssastry added a comment to T231569: Deploy Parsoid-PHP (integrated with Mediawiki) to the beta cluster.

I Imagine some config is still using 8000 for testing whether the JS service is up. I don't know what that is and what needs fixing, but other than that, looks like the code got deployed. I'll verify Parsoid/JS manually shortly.

22:00:42 Started deploy [parsoid/deploy@7d2519e] (beta)
22:00:42 Deploying Rev: HEAD = 7d2519e6cf3155819ca7ddb75c81104fb62c37fe
22:00:42 Started deploy [parsoid/deploy@7d2519e] (beta): Updating Parsoid to 6fbdd703 (T231569)
22:00:42 
== DEFAULT ==
:* deployment-mediawiki-parsoid10.deployment-prep.eqiad.wmflabs
:* deployment-parsoid09.deployment-prep.eqiad.wmflabs
parsoid/deploy: fetch stage(s): 100% (ok: 2; fail: 0; left: 0)                  
parsoid/deploy: config_deploy stage(s): 100% (ok: 2; fail: 0; left: 0)          
22:03:03 ['/usr/bin/scap', 'deploy-local', '-v', '--repo', 'parsoid/deploy', '-g', 'default', 'promote', '--refresh-config'] on deployment-parsoid09.deployment-prep.eqiad.wmflabs returned [70]: Linking config files at: /srv/deployment/parsoid/deploy-cache/revs/7d2519e6cf3155819ca7ddb75c81104fb62c37fe/.git/config-files
Check depool is empty and will not be run
Check repool is empty and will not be run
Restarting service 'parsoid'
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Port 8000 not up. Waiting 3.00s
Unhandled error:
deploy-local failed: <OSError> {}
Tue, Sep 17, 10:05 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, Parsoid-PHP
ssastry moved T233159: 30% of time serializing enwiki:Barack_Obama is spent escaping template arguments from Backlog to Post-Port Work on the Parsoid-PHP board.
Tue, Sep 17, 9:07 PM · Performance, Parsoid-PHP
ssastry triaged T233159: 30% of time serializing enwiki:Barack_Obama is spent escaping template arguments as Normal priority.
Tue, Sep 17, 9:07 PM · Performance, Parsoid-PHP
ssastry created T233159: 30% of time serializing enwiki:Barack_Obama is spent escaping template arguments.
Tue, Sep 17, 9:06 PM · Performance, Parsoid-PHP
ssastry closed T221144: Investigate DOMDiff performance regression after March 26 deployment as Declined.

I am going to decline this since we are going to be in Parsoid/PHP land soon enough and this won't be relevant anymore.

Tue, Sep 17, 7:39 PM · Parsoid-PHP
ssastry closed T232180: Zest.php: Pagebundle routes timeout for some pages as Resolved.

This looks resolved based on the new test run on scandium. After about 5 minutes of the test run, I am already noticing that a number of previously crashing tests are completing quickly.

Tue, Sep 17, 7:33 PM · Parsoid-PHP
ssastry updated the task description for T232222: Parsoid/PHP html->wt times scale differently with input/output document size compared to Parsoid/JS.
Tue, Sep 17, 7:24 PM · Patch-For-Review, Performance, Parsoid-PHP
ssastry updated the task description for T232222: Parsoid/PHP html->wt times scale differently with input/output document size compared to Parsoid/JS.
Tue, Sep 17, 7:24 PM · Patch-For-Review, Performance, Parsoid-PHP
ssastry updated the task description for T232222: Parsoid/PHP html->wt times scale differently with input/output document size compared to Parsoid/JS.
Tue, Sep 17, 7:21 PM · Patch-For-Review, Performance, Parsoid-PHP
ssastry added a comment to T232222: Parsoid/PHP html->wt times scale differently with input/output document size compared to Parsoid/JS.

I followed instructions on https://www.mediawiki.org/wiki/Excimer#Profile_a_process_and_produce_a_flame_graph and used Excimer to generate a flamegraph while running html2wt on en:Berlin. I added the instrumentation locally to bin/parse.php and ran php bin/parse.php --html2wt < /tmp/berlin.html > /tmp/berlin.wt
I am uploading the generated flame graph here.


Looking at the flamegraph, it looks like this is similar to T232180: Zest.php: Pagebundle routes timeout for some pages and perhaps https://gerrit.wikimedia.org/r/c/mediawiki/libs/RemexHtml/+/535291 might help with this.

Tue, Sep 17, 5:40 PM · Patch-For-Review, Performance, Parsoid-PHP

Mon, Sep 16

ssastry added a comment to T232222: Parsoid/PHP html->wt times scale differently with input/output document size compared to Parsoid/JS.

No, that won't help because (a) the DOM has id attributes set => the shortcut to avoid checking for id conflicts doesn't apply (b) id conflicts are extremely unlikely => getElementById(..) for the new id will return null, but since we don't trust that, we go and do a full document search anyway.
The better workaround for both the phab tasks is probably https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/535290#message-40b70cf4985a0151e661f557ead69a7f0dfa59da

Mon, Sep 16, 8:56 PM · Patch-For-Review, Performance, Parsoid-PHP
ssastry added a comment to T232180: Zest.php: Pagebundle routes timeout for some pages.

The solution in https://gerrit.wikimedia.org/r/535290 and followups to avoid invoking getElementById fails because cite introduces a number id attributes and so we fallback to the full search.

Mon, Sep 16, 8:16 PM · Parsoid-PHP
ssastry added a comment to T232222: Parsoid/PHP html->wt times scale differently with input/output document size compared to Parsoid/JS.
Mon, Sep 16, 7:49 PM · Patch-For-Review, Performance, Parsoid-PHP
ssastry added a comment to T232180: Zest.php: Pagebundle routes timeout for some pages.

The solution in https://gerrit.wikimedia.org/r/535290 and followups to avoid invoking getElementById fails because cite introduces a number id attributes and so we fallback to the full search.

Mon, Sep 16, 3:24 PM · Parsoid-PHP
ssastry added a comment to T232222: Parsoid/PHP html->wt times scale differently with input/output document size compared to Parsoid/JS.

I followed instructions on https://www.mediawiki.org/wiki/Excimer#Profile_a_process_and_produce_a_flame_graph and used Excimer to generate a flamegraph while running html2wt on en:Berlin. I added the instrumentation locally to bin/parse.php and ran php bin/parse.php --html2wt < /tmp/berlin.html > /tmp/berlin.wt

Mon, Sep 16, 2:17 PM · Patch-For-Review, Performance, Parsoid-PHP

Fri, Sep 13

ssastry added a comment to T232538: Make the parsoid server on the beta cluster a mediawiki app server.

I think that is worth following up on a separate phab ticket.

Fri, Sep 13, 11:02 PM · Patch-For-Review, Beta-Cluster-Infrastructure, Core Platform Team Workboards (Purple), RESTBase, Parsoid-PHP
ssastry created T232901: Investigate cloud VM creation failures for instances with deployment-mediawiki prefix.
Fri, Sep 13, 11:01 PM · Beta-Cluster-Infrastructure
ssastry updated the task description for T231569: Deploy Parsoid-PHP (integrated with Mediawiki) to the beta cluster.
Fri, Sep 13, 10:48 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, Parsoid-PHP
ssastry closed T232538: Make the parsoid server on the beta cluster a mediawiki app server as Resolved.

Ok, I verified that the instance has both Parsoid and Mediawiki latest version of code on there. There are gerrit patches to make this instance a mediawiki and parsoid scap target, but those can proceed independently of this.

Fri, Sep 13, 10:45 PM · Patch-For-Review, Beta-Cluster-Infrastructure, Core Platform Team Workboards (Purple), RESTBase, Parsoid-PHP
ssastry closed T232538: Make the parsoid server on the beta cluster a mediawiki app server, a subtask of T231569: Deploy Parsoid-PHP (integrated with Mediawiki) to the beta cluster, as Resolved.
Fri, Sep 13, 10:45 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, Parsoid-PHP
ssastry added a comment to T232538: Make the parsoid server on the beta cluster a mediawiki app server.

Next update.
I applied all those roles and ran sudo puppet agent -tv on the instance and it failed soon enough:

ssastry@deployment-mediawiki-parsoid10:~$ sudo puppet agent -tv
Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, Could not find template 'varnish/errorpage.body.html.erb' at /etc/puppet/modules/profile/manifests/mediawiki/hhvm.pp:97:20 on node deployment-mediawiki-parsoid10.deployment-prep.eqiad.wmflabs
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

So, I am stalled here at this point and need to hand it off to someone who knows how to proceed.

Fri, Sep 13, 10:31 PM · Patch-For-Review, Beta-Cluster-Infrastructure, Core Platform Team Workboards (Purple), RESTBase, Parsoid-PHP
ssastry added a comment to T232538: Make the parsoid server on the beta cluster a mediawiki app server.

Next update.

Fri, Sep 13, 10:07 PM · Patch-For-Review, Beta-Cluster-Infrastructure, Core Platform Team Workboards (Purple), RESTBase, Parsoid-PHP
ssastry added a comment to T232538: Make the parsoid server on the beta cluster a mediawiki app server.

That puppet prefix is there to not have to remember to apply those classes! Their removal defeat the purpose of the puppet prefix entirely.
If role::mediawiki::appserver and role::beta::mediawiki breaks the instance provisioning, I guess we have to fix them? Have you captured any log?
@jeena do you remember facing issues with puppet when you have created your deployment-mediawiki instance?

Fri, Sep 13, 9:58 PM · Patch-For-Review, Beta-Cluster-Infrastructure, Core Platform Team Workboards (Purple), RESTBase, Parsoid-PHP
ssastry added a comment to T232538: Make the parsoid server on the beta cluster a mediawiki app server.

Okay, a further update.

Fri, Sep 13, 9:39 PM · Patch-For-Review, Beta-Cluster-Infrastructure, Core Platform Team Workboards (Purple), RESTBase, Parsoid-PHP
ssastry updated subscribers of T232538: Make the parsoid server on the beta cluster a mediawiki app server.

An update.

Fri, Sep 13, 9:21 PM · Patch-For-Review, Beta-Cluster-Infrastructure, Core Platform Team Workboards (Purple), RESTBase, Parsoid-PHP
ssastry updated subscribers of T232538: Make the parsoid server on the beta cluster a mediawiki app server.

Change 536598 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[operations/puppet@production] beta cluster: Make deployment-parsoid09 a Mediawiki appserver as well
https://gerrit.wikimedia.org/r/536598

Fri, Sep 13, 4:36 PM · Patch-For-Review, Beta-Cluster-Infrastructure, Core Platform Team Workboards (Purple), RESTBase, Parsoid-PHP
ssastry closed T232042: Direct Parsoid/PHP scandium logs to a different channel as Resolved.

Joe deployed the revert and the puppet patch and I confirmed that this now directs the logs to 'parsoid-tests' type in logstash!

Fri, Sep 13, 2:18 PM · Parsoid-PHP

Thu, Sep 12

ssastry added a comment to T227209: Security Review For Parsoid-PHP.

Update: @Reedy and I are having a look at this and T230140 and should have some reports soon. We're going to timebox to maybe two weeks or so - hopefully that doesn't push back too much on any targeted deployment dates.

Thu, Sep 12, 3:05 PM · Restricted Project, Parsoid-PHP, Security-Team-Reviews

Wed, Sep 11

ssastry added a comment to T232180: Zest.php: Pagebundle routes timeout for some pages.

Hmm ... better, but there is still something to investigate. If this is not zest.php / getElementById, we should close this and open a new ticket. But, I am running out, so reporting the results for now:

ssastry@scandium:/srv/deployment/parsoid/deploy/src$ time curl -x scandium.eqiad.wmnet:80 http://en.wikipedia.org/w/rest.php/en.wikipedia.org/v3/transform/wikitext/to/pagebundle/Ken%20Schrader/913657403 -X POST < /dev/null > /dev/null
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 1431k    0 1431k    0     0  11228      0 --:--:--  0:02:10 --:--:--  340k
Wed, Sep 11, 10:32 PM · Parsoid-PHP
ssastry claimed T224377: Properly implement trace, dump, debug log support via possibly a LoggingUtils.
Wed, Sep 11, 8:18 PM · Patch-For-Review, Parsoid-PHP
ssastry added a comment to T232042: Direct Parsoid/PHP scandium logs to a different channel.

Looks like this code at the end of modules/profile/files/logstash/filter-mediawiki.conf in the puppet repo might do the trick if we revert my mediawiki-config change patch?

# Scandium is a Parsoid test server and treat errors here as
# parsoid-tests errors and don't clog the main mediawiki channel
if [host] == "scandium" {
  mutate {
    replace => [ "type", "parsoid-tests" ]
  }
}
Wed, Sep 11, 8:05 PM · Parsoid-PHP
ssastry closed T232556: Parsoid/PHP roundtrip testing: Period ( . ) in titles fail with a http 403 (Invalid file extension found in the path info or query string.) error as Resolved.

We have a workaround for testing purposes. So resolving this. The bigger qn. that this triggered is covered in T232563.

Wed, Sep 11, 6:17 PM · Patch-For-Review, Parsoid-PHP
ssastry moved T232538: Make the parsoid server on the beta cluster a mediawiki app server from Backlog to Testing / QA on the Parsoid-PHP board.
Wed, Sep 11, 6:16 PM · Patch-For-Review, Beta-Cluster-Infrastructure, Core Platform Team Workboards (Purple), RESTBase, Parsoid-PHP
ssastry moved T232556: Parsoid/PHP roundtrip testing: Period ( . ) in titles fail with a http 403 (Invalid file extension found in the path info or query string.) error from Backlog to Testing / QA on the Parsoid-PHP board.
Wed, Sep 11, 6:16 PM · Patch-For-Review, Parsoid-PHP
ssastry moved T221041: Convert Parsoid to dependency injection from Post-Port Work to Porting Tech Debt Redressal on the Parsoid-PHP board.
Wed, Sep 11, 6:09 PM · CPT Initiatives (Decoupling (CDP2)), User-Daniel, Parsoid-PHP, Technical-Debt
ssastry moved T231570: DomSourceRange serializes with null entries from Post-Port Work to Porting Tech Debt Redressal on the Parsoid-PHP board.
Wed, Sep 11, 6:08 PM · Parsoid-PHP
ssastry moved T226428: Convert stdclass-cast objects to classes wherever possible and use associative arrays elswhere as far as possible from Post-Port Work to Porting Tech Debt Redressal on the Parsoid-PHP board.
Wed, Sep 11, 6:08 PM · Technical-Debt, Parsoid-PHP
ssastry moved T221147: Replace homegrown encodeURIComponents PHPUtils helper with rawurlencode from Post-Port Work to Porting Tech Debt Redressal on the Parsoid-PHP board.
Wed, Sep 11, 6:08 PM · Parsoid-PHP
ssastry moved T229469: Reduce / eliminate Parsoid's knowledge of what mode it is running in (standalone, integrated, offline) from Post-Port Work to Porting Tech Debt Redressal on the Parsoid-PHP board.
Wed, Sep 11, 6:08 PM · Parsoid-PHP
ssastry moved T231568: Push more functionality out of SiteConfig subclasses into the root SiteConfig class from Post-Port Work to Porting Tech Debt Redressal on the Parsoid-PHP board.
Wed, Sep 11, 6:08 PM · Parsoid-PHP
ssastry moved T226437: Audit uses of empty() and isset() and eliminate unnecessary uses from Post-Port Work to Porting Tech Debt Redressal on the Parsoid-PHP board.
Wed, Sep 11, 6:07 PM · Technical-Debt, Parsoid-PHP
ssastry moved T223194: Consider using instanceof checks for DOM Nodes instead of DOMUtils::is* + DOMUtils::assertElt combinations from Post-Port Work to Porting Tech Debt Redressal on the Parsoid-PHP board.
Wed, Sep 11, 6:07 PM · Parsoid-PHP
ssastry moved T217867: Port domino (or another spec-compliant DOM library) to PHP from Post-Port Work to Porting Tech Debt Redressal on the Parsoid-PHP board.
Wed, Sep 11, 6:07 PM · CPT Initiatives (Parsoid PHP (CDP2)), Parsoid-PHP
ssastry reopened T232042: Direct Parsoid/PHP scandium logs to a different channel as "Open".

So, it looks like these logs disappeared from the "mediawiki" type, but they did not make an appearance under the "parsoid-tests" type in logstash (I searched in Kibana). Based on IRC conversations on MediaWiki-General, I learnt that there is puppet code involved in directing the log events from mediawiki to logstash. So, it looks like we'll need some puppet updates to these filters to ensure these events end up in logstash / kibana.

Wed, Sep 11, 6:00 PM · Parsoid-PHP
ssastry added a comment to T217867: Port domino (or another spec-compliant DOM library) to PHP.

@jlinehan, Early heads up from a project mgmt. POV.

Thanks for the heads up. I have had my plate completely full with Better Use of Data work this last quarter, so I haven't had a chance to finish off evaluating this library. I can make some time in Q2 to make sure it gets there so it's easier for your team to make a decision about building on it.

Wed, Sep 11, 5:56 PM · CPT Initiatives (Parsoid PHP (CDP2)), Parsoid-PHP
ssastry added a comment to T217867: Port domino (or another spec-compliant DOM library) to PHP.

https://github.com/ivopetkov/html5-dom-document-php was mentioned in the last JetBrains newsletter as a similar library.
(Wouldn't it be nice if our libraries would be mentioned in major newsletters as well? waves at T171073 and ducks)

Wed, Sep 11, 5:48 PM · CPT Initiatives (Parsoid PHP (CDP2)), Parsoid-PHP
ssastry added a comment to T217867: Port domino (or another spec-compliant DOM library) to PHP.

@jlinehan, Early heads up from a project mgmt. POV. Once we are done with the porting and deployment, we might want to more seriously evaluate this ported library as a replacement for the PHP DOM. Without evaluation, especially performance, I do not want to say we will definitely be using this, but given all the bandaids we've been applying on top of PHP DOM, it is more likely we will want to consider this. I leave that evaluation up to @cscott and you.

Wed, Sep 11, 4:56 PM · CPT Initiatives (Parsoid PHP (CDP2)), Parsoid-PHP
ssastry updated the task description for T232538: Make the parsoid server on the beta cluster a mediawiki app server.
Wed, Sep 11, 3:25 PM · Patch-For-Review, Beta-Cluster-Infrastructure, Core Platform Team Workboards (Purple), RESTBase, Parsoid-PHP
ssastry added a comment to T232538: Make the parsoid server on the beta cluster a mediawiki app server.

hi @ssastry just a clarification: how would we load the parsoid code, if it can't be merged in the wmf vendor repository? Same way we do on scandium?

Wed, Sep 11, 1:44 PM · Patch-For-Review, Beta-Cluster-Infrastructure, Core Platform Team Workboards (Purple), RESTBase, Parsoid-PHP
ssastry added a comment to T232556: Parsoid/PHP roundtrip testing: Period ( . ) in titles fail with a http 403 (Invalid file extension found in the path info or query string.) error.

Here is a possible workaround that seems to work:

ssastry@scandium:~$ curl -x scandium.eqiad.wmnet:80 http://en.wikipedia.org/w/rest.php/en.wikipedia.org/v3/page/html/G.729d/
<!doctype html><title>Redirect</title><a href="http://en.wikipedia.org/w/rest.php/en.wikipedia.org/v3/page/html/G.729d/457575777">http://en.wikipedia.org/w/rest.php/en.wikipedia.org/v3/page/html/G.729d/457575777</a>
Wed, Sep 11, 3:35 AM · Patch-For-Review, Parsoid-PHP
ssastry added a comment to T232556: Parsoid/PHP roundtrip testing: Period ( . ) in titles fail with a http 403 (Invalid file extension found in the path info or query string.) error.

git grep of mediawiki code shows that it comes from https://github.com/wikimedia/mediawiki/blob/master/includes/WebRequest.php#L1127-L1152

Wed, Sep 11, 2:16 AM · Patch-For-Review, Parsoid-PHP
ssastry triaged T232556: Parsoid/PHP roundtrip testing: Period ( . ) in titles fail with a http 403 (Invalid file extension found in the path info or query string.) error as Normal priority.
Wed, Sep 11, 2:09 AM · Patch-For-Review, Parsoid-PHP
ssastry created T232556: Parsoid/PHP roundtrip testing: Period ( . ) in titles fail with a http 403 (Invalid file extension found in the path info or query string.) error.
Wed, Sep 11, 2:09 AM · Patch-For-Review, Parsoid-PHP

Tue, Sep 10

ssastry triaged T232538: Make the parsoid server on the beta cluster a mediawiki app server as High priority.
Tue, Sep 10, 9:29 PM · Patch-For-Review, Beta-Cluster-Infrastructure, Core Platform Team Workboards (Purple), RESTBase, Parsoid-PHP
ssastry created T232538: Make the parsoid server on the beta cluster a mediawiki app server.
Tue, Sep 10, 9:28 PM · Patch-For-Review, Beta-Cluster-Infrastructure, Core Platform Team Workboards (Purple), RESTBase, Parsoid-PHP
ssastry closed T232042: Direct Parsoid/PHP scandium logs to a different channel as Resolved.

Will verify when we start a new test run.

Tue, Sep 10, 5:59 PM · Parsoid-PHP
ssastry assigned T232056: Update roundtrip-test.js script's diff classification code to account for PHP DOMs with byte-based data-parsoid offsets to cscott.

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/504795 might be relevant here.

Tue, Sep 10, 4:58 PM · Parsoid-PHP
ssastry added a comment to T231933: Make services tests not depend on production enwiki pages.

@Jhernandez @Mholloway Do the tests need to actually query Parsoid or can they hit RESTBase instead? If the latter, then, I don't think anything will be affected. Parsoid/JS wasn't exposed to the public internet either.

They hit RB, but it does matter because RB can only access the Parsoid instance local to it. This used to work because, as said above, Parsoid from beta was set up to also respond to requests for production wikis, but without that ability, RB will not be able to produce a meaningful response.

Tue, Sep 10, 4:51 PM · Product-Infrastructure-Team-Backlog, CPT Initiatives (Parsoid PHP (CDP2)), Parsoid-PHP, RESTBase
ssastry added a comment to T229074: Preparing VisualEditor for Parsoid-PHP switch.

Hey @ssastry when should we expect to start paying attention to this?

Once we deploy the code to beta cluster ( T231569 ), I'll ping you.

Tue, Sep 10, 3:52 PM · VisualEditor, Core Platform Team (Needs Cleaning - Services Operations), Parsoid-PHP
ssastry added a comment to T229074: Preparing VisualEditor for Parsoid-PHP switch.

Hey @ssastry when should we expect to start paying attention to this?

Tue, Sep 10, 3:52 PM · VisualEditor, Core Platform Team (Needs Cleaning - Services Operations), Parsoid-PHP
ssastry claimed T230666: git grep strtolower/strtoupper and see which one of them need to be mb_strtolower/mb_strtoupper.
Tue, Sep 10, 4:51 AM · Parsoid-PHP
ssastry moved T217867: Port domino (or another spec-compliant DOM library) to PHP from Non-Porting Tasks to Post-Port Work on the Parsoid-PHP board.
Tue, Sep 10, 4:50 AM · CPT Initiatives (Parsoid PHP (CDP2)), Parsoid-PHP
ssastry moved T219942: Analyse performance of the PHP tokenizer code and do any necessary optimisation work from Performance to Post-Port Work on the Parsoid-PHP board.
Tue, Sep 10, 4:45 AM · CPT Initiatives (Parsoid PHP (CDP2)), Parsoid-PHP
ssastry moved T205479: Fix token datastructure to fix potential perfomance issue from Performance to Post-Port Work on the Parsoid-PHP board.
Tue, Sep 10, 4:45 AM · Parsoid-PHP
ssastry moved T221677: Sanitizer::validateAttributes is not as efficient as it could be from Performance to Post-Port Work on the Parsoid-PHP board.
Tue, Sep 10, 4:45 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Parsoid-PHP, MediaWiki-Parser
ssastry moved T221145: Collapse some post-treebuilder passes onto the tree building pass using Remex's SAX interface from Performance to Post-Port Work on the Parsoid-PHP board.
Tue, Sep 10, 4:44 AM · Parsoid-PHP
ssastry moved T223194: Consider using instanceof checks for DOM Nodes instead of DOMUtils::is* + DOMUtils::assertElt combinations from Performance to Post-Port Work on the Parsoid-PHP board.
Tue, Sep 10, 4:44 AM · Parsoid-PHP

Mon, Sep 9

ssastry lowered the priority of T213980: For every ported file, audit all regular expressions for subtle mismatches from High to Normal.
Mon, Sep 9, 10:24 PM · Parsoid-PHP
ssastry updated the task description for T213980: For every ported file, audit all regular expressions for subtle mismatches.
Mon, Sep 9, 10:21 PM · Parsoid-PHP
ssastry claimed T213980: For every ported file, audit all regular expressions for subtle mismatches.
Mon, Sep 9, 4:42 PM · Parsoid-PHP
ssastry assigned T232180: Zest.php: Pagebundle routes timeout for some pages to cscott.
Mon, Sep 9, 4:01 PM · Parsoid-PHP
ssastry moved T232180: Zest.php: Pagebundle routes timeout for some pages from Backlog to Performance on the Parsoid-PHP board.
Mon, Sep 9, 4:01 PM · Parsoid-PHP

Sun, Sep 8

ssastry updated the task description for T232222: Parsoid/PHP html->wt times scale differently with input/output document size compared to Parsoid/JS.
Sun, Sep 8, 7:26 PM · Patch-For-Review, Performance, Parsoid-PHP

Fri, Sep 6

ssastry claimed T232042: Direct Parsoid/PHP scandium logs to a different channel.
Fri, Sep 6, 8:01 PM · Parsoid-PHP
ssastry changed the status of T156350: Add language-specific CSS modules for Parsoid's Cite output from Open to Stalled.
Fri, Sep 6, 5:13 PM · Parsoid-Read-Views, Parsoid-Rendering, Cite
ssastry changed the status of T156351: Add wiki-specific CSS styles for Parsoid Cite output so that it renders exactly like core Cite output, a subtask of T156350: Add language-specific CSS modules for Parsoid's Cite output, from Open to Stalled.
Fri, Sep 6, 5:12 PM · Parsoid-Read-Views, Parsoid-Rendering, Cite
ssastry changed the status of T156351: Add wiki-specific CSS styles for Parsoid Cite output so that it renders exactly like core Cite output from Open to Stalled.
Fri, Sep 6, 5:12 PM · Parsoid-Read-Views, Cite, Parsoid-Rendering
ssastry changed the status of T166895: CL support for adding wiki-specific CSS for styling citations output in Parsoid HTML, a subtask of T156351: Add wiki-specific CSS styles for Parsoid Cite output so that it renders exactly like core Cite output, from Open to Stalled.
Fri, Sep 6, 5:11 PM · Parsoid-Read-Views, Cite, Parsoid-Rendering
ssastry changed the status of T166895: CL support for adding wiki-specific CSS for styling citations output in Parsoid HTML from Open to Stalled.

We have to resolve what direction we want to go with this. This will get clearer as we start the parser integration process. But, for clarity, I've marked this stalled.

Fri, Sep 6, 5:11 PM · CommRel-Specialists-Support
ssastry moved T232222: Parsoid/PHP html->wt times scale differently with input/output document size compared to Parsoid/JS from Backlog to Performance on the Parsoid-PHP board.
Fri, Sep 6, 4:33 PM · Patch-For-Review, Performance, Parsoid-PHP
ssastry added a project to T232222: Parsoid/PHP html->wt times scale differently with input/output document size compared to Parsoid/JS: Performance.
Fri, Sep 6, 4:32 PM · Patch-For-Review, Performance, Parsoid-PHP
ssastry triaged T232222: Parsoid/PHP html->wt times scale differently with input/output document size compared to Parsoid/JS as Normal priority.
Fri, Sep 6, 4:32 PM · Patch-For-Review, Performance, Parsoid-PHP
ssastry created T232222: Parsoid/PHP html->wt times scale differently with input/output document size compared to Parsoid/JS.
Fri, Sep 6, 4:32 PM · Patch-For-Review, Performance, Parsoid-PHP
ssastry added a comment to T232183: Potential bugs in SiteConfig.php regular expressions used in WikitextSerializer.

So I guess we need a configuration to have MediaWiki on scandium to NOT send logs to logstash since that is just for testing

Fri, Sep 6, 2:17 PM · Parsoid-PHP
ssastry removed a project from T232183: Potential bugs in SiteConfig.php regular expressions used in WikitextSerializer: Wikimedia-production-error.

That is definitely a Wikimedia-production-error log! Not sure why you removed the project tag and the stacktrace :]

Fri, Sep 6, 2:11 PM · Parsoid-PHP
ssastry added a comment to T232183: Potential bugs in SiteConfig.php regular expressions used in WikitextSerializer.

That is definitely a Wikimedia-production-error log! Not sure why you removed the project tag and the stacktrace :]

Fri, Sep 6, 2:09 PM · Parsoid-PHP
ssastry moved T232183: Potential bugs in SiteConfig.php regular expressions used in WikitextSerializer from Backlog to Bugs on the Parsoid-PHP board.
Fri, Sep 6, 1:46 PM · Parsoid-PHP
ssastry changed the subtype of T232183: Potential bugs in SiteConfig.php regular expressions used in WikitextSerializer from "Production Error" to "Bug Report".
Fri, Sep 6, 1:46 PM · Parsoid-PHP
ssastry updated the task description for T232183: Potential bugs in SiteConfig.php regular expressions used in WikitextSerializer.
Fri, Sep 6, 1:46 PM · Parsoid-PHP
ssastry removed Request URL on T232183: Potential bugs in SiteConfig.php regular expressions used in WikitextSerializer.
Fri, Sep 6, 1:44 PM · Parsoid-PHP
ssastry renamed T232183: Potential bugs in SiteConfig.php regular expressions used in WikitextSerializer from parsoid emits: Html2Wt/WikitextSerializer.php:1423 PHP Notice: Undefined offset: 50 to Potential bugs in SiteConfig.php regular expressions used in WikitextSerializer.
Fri, Sep 6, 1:44 PM · Parsoid-PHP
ssastry triaged T232182: Parsoid/PHP performance benchmarking on scandium as Normal priority.
Fri, Sep 6, 4:11 AM · Performance, Parsoid-PHP
ssastry moved T232182: Parsoid/PHP performance benchmarking on scandium from Backlog to Performance on the Parsoid-PHP board.
Fri, Sep 6, 4:11 AM · Performance, Parsoid-PHP
ssastry created T232182: Parsoid/PHP performance benchmarking on scandium.
Fri, Sep 6, 4:11 AM · Performance, Parsoid-PHP
ssastry triaged T232180: Zest.php: Pagebundle routes timeout for some pages as High priority.
Fri, Sep 6, 3:29 AM · Parsoid-PHP