Page MenuHomePhabricator

ssastry (Subramanya Sastry)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 5:34 AM (250 w, 11 h)
Availability
Available
LDAP User
Subramanya Sastry
MediaWiki User
SSastry (WMF) [ Global Accounts ]

Recent Activity

Yesterday

ssastry added a comment to T228217: Ensure all the features of parse.js are covered by parse.php.

Trying to address T178914: parse.js should have standard arguments as part of this port might be something worth considering.

I could address the specific points mentioned there, but I would rather not be on the hook for coming up with a holistic vision

Mon, Jul 22, 9:53 PM · Patch-For-Review, Parsoid-PHP
ssastry added a comment to T228217: Ensure all the features of parse.js are covered by parse.php.

Trying to address T178914: parse.js should have standard arguments as part of this port might be something worth considering.

Mon, Jul 22, 9:20 PM · Patch-For-Review, Parsoid-PHP
ssastry added a comment to T215000: Fill gaps in PHP DOM's functionality.

Change 524385 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Work around PHP DOM's failure to normalize DOM during DOM build
https://gerrit.wikimedia.org/r/524385

Mon, Jul 22, 6:31 PM · Patch-For-Review, Parsoid-PHP
ssastry added a comment to T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments).

@cscott this RFC seems close to an agreement. Implementation is probably blocked on php-parsoid, but the new syntax and semantics could already be approved.

Mon, Jul 22, 4:58 PM · Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016, TechCom-RFC
ssastry renamed T213980: For every ported file, audit all regular expressions for subtle mismatches from For every ported file, audit all regular expressions for subtle mismatches (especially around \s usage and those ending with $ and might require a D regexp modifier) to For every ported file, audit all regular expressions for subtle mismatches.
Mon, Jul 22, 3:46 PM · Patch-For-Review, Parsoid-PHP
ssastry added a comment to T228069: Deploy Parsoid-PHP with Mediawiki to scandium for RT and performance testing.

Can I ask why such parser tests will need to run in production rather than via the CI infrastructure? CI can reach the production wikis via the public interface, so I don't see a reason to keep perpetraring the off-standard thing we have with scandium, unless there are specific reasons to do so.

Mon, Jul 22, 3:06 PM · serviceops, Core Platform Team (Parsoid REST API in PHP (CDP2)), Parsoid-PHP

Sat, Jul 20

ssastry updated subscribers of T130689: Google's services should load data-mw from a separate API call to RESTBase.

@Renxiaoyi: Hi! You assigned this task to yourself a while ago. Could you maybe share a status update? Are you still working (or still plan to work) on this issue? Or is there anything that others could help with? (If you do not plan to work on this issue anymore, please remove yourself as assignee (via Add Action...Assign / Claim in the dropdown menu) so others could work on it.) Thanks a lot!

Sat, Jul 20, 5:29 PM · Core Platform Team Backlog (Watching / External), Parsoid-Edit-Support (Subtree Editing Support), Services (watching), RESTBase

Thu, Jul 18

ssastry added a comment to T228346: PHP 7.2 garbage collector segfault.

Do we have some small piece of code that we can demo this problem?

Thu, Jul 18, 8:31 PM · Parsoid-PHP, PHP 7.2 support
ssastry added a comment to T228217: Ensure all the features of parse.js are covered by parse.php.

genTest is not relevant in the post-javascript world, so I'm crossing those off

Thu, Jul 18, 5:50 PM · Patch-For-Review, Parsoid-PHP

Wed, Jul 17

ssastry added a comment to T228346: PHP 7.2 garbage collector segfault.

FYI: This bug doesn't show up with PS6 of gerrit 523715. So, you need PS5 of that patch.

Wed, Jul 17, 10:25 PM · Parsoid-PHP, PHP 7.2 support
ssastry moved T228346: PHP 7.2 garbage collector segfault from Backlog to Testing / QA / Deployment on the Parsoid-PHP board.
Wed, Jul 17, 10:10 PM · Parsoid-PHP, PHP 7.2 support
ssastry added a project to T228346: PHP 7.2 garbage collector segfault: Parsoid-PHP.
Wed, Jul 17, 10:10 PM · Parsoid-PHP, PHP 7.2 support
ssastry updated the task description for T228346: PHP 7.2 garbage collector segfault.
Wed, Jul 17, 10:09 PM · Parsoid-PHP, PHP 7.2 support
ssastry reassigned T225024: Port wikimedia-langconv's FST runner (FST.js) to PHP from Arlolra to Mholloway.
Wed, Jul 17, 5:48 PM · Patch-For-Review, Parsoid-PHP
ssastry reassigned T225023: Convert wikimedia-langconv npm library into a dual npm / composer library repo from cscott to Mholloway.
Wed, Jul 17, 5:48 PM · Patch-For-Review, Parsoid-PHP
ssastry added a comment to T134469: doBlockLevels() inserts <p> and </p> randomly with no regard for HTML validity.

All in ParagraphWrapper token transformer code.

Wed, Jul 17, 5:04 PM · MediaWiki-Parser
ssastry added a comment to T134469: doBlockLevels() inserts <p> and </p> randomly with no regard for HTML validity.

Unfortunately (?) Parsoid is now bug-compatible with PHP in this regard (example from T227953):

Wed, Jul 17, 4:58 PM · MediaWiki-Parser
ssastry added a comment to T228223: tokensToString being called on KV->V looks like a signature mismatch.

See https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/523845

Wed, Jul 17, 4:01 AM · Patch-For-Review, Parsoid-PHP
ssastry added a comment to T228223: tokensToString being called on KV->V looks like a signature mismatch.

It looks like the KV[] scenario is from https://github.com/wikimedia/parsoid/blob/a66aad7d6697447300a08ca24c0c246f9ac84068/src/Wt2Html/Grammar.pegphp#L274 (same on the JS side). The reason why we might not have tripped over this in tokensToString is probably because ext-tokens never hit this code path. But yes, we should probably add asserts to both JS & PHP side to ensure we catch unhandled scenarios early.

Wed, Jul 17, 3:12 AM · Patch-For-Review, Parsoid-PHP

Tue, Jul 16

ssastry closed T228115: querySelectorAll seems to be malfunctioning on "body > p:nth-child( 1 )" and ...( 2 ) as Invalid.

The problem is with the code that generates the DOM to which the selectors are applied, Zest output is correct for the provided dom.

Tue, Jul 16, 6:03 PM · Patch-For-Review, Parsoid-PHP
ssastry added a comment to T227921: Several {{Collapse top}} templates render incorrectly in Meta wiki.

The {{Collapse bottom}} template generates the |}, and for it to work correctly as an end-of-table markup, it must be on a separate line. In the diff you linked, it was placed by Parsoid on the same line as the closing </syntaxhighlight> tag.

Tue, Jul 16, 4:27 PM · Parsoid, VisualEditor-MediaWiki-Templates, VisualEditor
ssastry moved T228166: html2wt failures from Backlog to Bugs on the Parsoid-PHP board.
Tue, Jul 16, 1:59 PM · Parsoid-PHP
ssastry changed the subtype of T228166: html2wt failures from "Task" to "Bug Report".
Tue, Jul 16, 1:54 PM · Parsoid-PHP
ssastry triaged T228166: html2wt failures as Normal priority.
Tue, Jul 16, 1:54 PM · Parsoid-PHP
ssastry created T228166: html2wt failures.
Tue, Jul 16, 1:51 PM · Parsoid-PHP
ssastry updated the task description for T225024: Port wikimedia-langconv's FST runner (FST.js) to PHP.
Tue, Jul 16, 1:34 PM · Patch-For-Review, Parsoid-PHP
ssastry moved T228069: Deploy Parsoid-PHP with Mediawiki to scandium for RT and performance testing from Backlog to Testing / QA / Deployment on the Parsoid-PHP board.
Tue, Jul 16, 4:09 AM · serviceops, Core Platform Team (Parsoid REST API in PHP (CDP2)), Parsoid-PHP

Mon, Jul 15

ssastry updated the task description for T228069: Deploy Parsoid-PHP with Mediawiki to scandium for RT and performance testing.
Mon, Jul 15, 3:21 PM · serviceops, Core Platform Team (Parsoid REST API in PHP (CDP2)), Parsoid-PHP
ssastry triaged T228069: Deploy Parsoid-PHP with Mediawiki to scandium for RT and performance testing as High priority.
Mon, Jul 15, 3:18 PM · serviceops, Core Platform Team (Parsoid REST API in PHP (CDP2)), Parsoid-PHP
ssastry created T228069: Deploy Parsoid-PHP with Mediawiki to scandium for RT and performance testing.
Mon, Jul 15, 3:17 PM · serviceops, Core Platform Team (Parsoid REST API in PHP (CDP2)), Parsoid-PHP
ssastry closed T225841: Run DOMPostProcessor in hybrid testing mode and fix bugs as Declined.

PHP parser tests script is almost ready, and so this is no longer necessary.

Mon, Jul 15, 3:05 PM · Parsoid-PHP

Sun, Jul 14

ssastry merged T227953: Annoyance: Parser mis-"tidies" end of embedded <span> inside a <div> unless it has additional EOL context, Linter reports as a "Missing end tag","Stripped tag" error pair. into T134469: doBlockLevels() inserts <p> and </p> randomly with no regard for HTML validity.
Sun, Jul 14, 12:44 AM · MediaWiki-Parser
ssastry merged task T227953: Annoyance: Parser mis-"tidies" end of embedded <span> inside a <div> unless it has additional EOL context, Linter reports as a "Missing end tag","Stripped tag" error pair. into T134469: doBlockLevels() inserts <p> and </p> randomly with no regard for HTML validity.
Sun, Jul 14, 12:44 AM · MediaWiki-Parser, MediaWiki-extensions-Linter

Mon, Jul 8

ssastry closed T220857: Tech Talks Proposal June 2019: What in the world is Analytics doing back there?, a subtask of T212978: Wikimedia tech talks and learnings 2019, as Resolved.
Mon, Jul 8, 5:16 PM · Developer-Advocacy, Documentation
ssastry closed T220857: Tech Talks Proposal June 2019: What in the world is Analytics doing back there? as Resolved.
Mon, Jul 8, 5:16 PM · Developer-Advocacy, Documentation

Thu, Jul 4

ssastry closed T219069: Reconcile byte offsets coming from Tokenizer with unicode char offsets used by rest of ported code as Resolved.
Thu, Jul 4, 3:26 PM · Parsoid-PHP
ssastry added a comment to T227216: Adding or editing citations using VisualEditor causes major formatting issues involving pipes, equals signs and nowiki tags.

These steps will probably work on any production wiki as well.

Yes, confirmed on [[enwiki:Hampi]]. Now, waiting for deploy to complete before I can re-try that and verify it is fixed.

Thu, Jul 4, 12:24 AM · User-Ryasmeen, Parsoid, VisualEditor
ssastry added a comment to T227216: Adding or editing citations using VisualEditor causes major formatting issues involving pipes, equals signs and nowiki tags.

These steps will probably work on any production wiki as well.

Thu, Jul 4, 12:20 AM · User-Ryasmeen, Parsoid, VisualEditor
ssastry added a comment to T227216: Adding or editing citations using VisualEditor causes major formatting issues involving pipes, equals signs and nowiki tags.

Instructions from @cscott to reproduce this bug:

1. https://en.wikipedia.beta.wmflabs.org/wiki/Martyrs_of_Gorkum?veaction=edit
2. click VE 'cite' button, insert manual citation.  i used "website", then URL "https://cscott.net" and title "title"
3. now switch to wikitext editor, confirm inserted reference is sane
4. now switch back to VE, click the reference, click edit.
5. the url will be corrupt
Thu, Jul 4, 12:12 AM · User-Ryasmeen, Parsoid, VisualEditor

Wed, Jul 3

ssastry added a comment to T227216: Adding or editing citations using VisualEditor causes major formatting issues involving pipes, equals signs and nowiki tags.

@SUM1, Thanks for your help .. we may have found some leads to track this down.

Wed, Jul 3, 11:26 PM · User-Ryasmeen, Parsoid, VisualEditor
ssastry added a comment to T227216: Adding or editing citations using VisualEditor causes major formatting issues involving pipes, equals signs and nowiki tags.

@ssastry I'm back at a standstill, can't reproduce the bug again. I'll keep testing.
And not yet, but I can go searching for affected edits.

Wed, Jul 3, 11:04 PM · User-Ryasmeen, Parsoid, VisualEditor
ssastry added a comment to T227216: Adding or editing citations using VisualEditor causes major formatting issues involving pipes, equals signs and nowiki tags.

@ssastry The reporting user didn't experience the bug herself (to my knowledge) but encountered numerous other people's edits being affected.

Wed, Jul 3, 10:55 PM · User-Ryasmeen, Parsoid, VisualEditor
ssastry added a comment to T227216: Adding or editing citations using VisualEditor causes major formatting issues involving pipes, equals signs and nowiki tags.

@SUM1, can you let us know if the reporting user was switching back and forth between Wikitext and VisualEditor?

Wed, Jul 3, 9:53 PM · User-Ryasmeen, Parsoid, VisualEditor
ssastry added a comment to T227216: Adding or editing citations using VisualEditor causes major formatting issues involving pipes, equals signs and nowiki tags.

@cscott: one way to narrow this down is to run the deployed version of Parsoid on the revision that was edited and try a selser edit.

Wed, Jul 3, 9:48 PM · User-Ryasmeen, Parsoid, VisualEditor
ssastry added a comment to T227216: Adding or editing citations using VisualEditor causes major formatting issues involving pipes, equals signs and nowiki tags.

It's *possible* that VE is to blame, if for some reason it's not marking subtrees as 'changed' properly, but I agree that this is probably a Parsoid selser bug.

Wed, Jul 3, 9:44 PM · User-Ryasmeen, Parsoid, VisualEditor
ssastry updated subscribers of T227209: [WIP] Security Review For Parsoid-PHP.
Wed, Jul 3, 4:34 PM · Parsoid-PHP, Security-Team-Reviews
ssastry created T227209: [WIP] Security Review For Parsoid-PHP.
Wed, Jul 3, 4:33 PM · Parsoid-PHP, Security-Team-Reviews

Tue, Jul 2

ssastry added a comment to T226692: Add mw-disambig class to original content in VE.

This bug should have been fixed with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ParsoidBatchAPI/+/517479 ... but, maybe that hasn't been deployed to production yet? Or, maybe refresh that page to check?

https://www.mediawiki.org/wiki/MediaWiki_1.34/wmf.10/Changelog#ParsoidBatchAPI says this went out in wmf-10 .. so, let me refresh that page.

Tue, Jul 2, 5:05 PM · User-Ryasmeen, Parsoid, VisualEditor-MediaWiki-Links, VisualEditor, MediaWiki-extensions-Disambiguator
ssastry added a comment to T226692: Add mw-disambig class to original content in VE.

This bug should have been fixed with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ParsoidBatchAPI/+/517479 ... but, maybe that hasn't been deployed to production yet? Or, maybe refresh that page to check?

Tue, Jul 2, 5:01 PM · User-Ryasmeen, Parsoid, VisualEditor-MediaWiki-Links, VisualEditor, MediaWiki-extensions-Disambiguator
ssastry added a comment to T226692: Add mw-disambig class to original content in VE.

This bug should have been fixed with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ParsoidBatchAPI/+/517479 ... but, maybe that hasn't been deployed to production yet? Or, maybe refresh that page to check?

Tue, Jul 2, 4:58 PM · User-Ryasmeen, Parsoid, VisualEditor-MediaWiki-Links, VisualEditor, MediaWiki-extensions-Disambiguator
ssastry claimed T224680: Port bin/parserTests.js, the parser tests runner script.

Given our goal of wanting to run parser tests independently in this code base without having MediaWiki checked out and integrated, it makes sense to port our JS runner. The core runner has tighter integration with MediaWiki internals and isn't suitable if we are serious about the isolation goal. If at a later point, this goal is no longer relevant, we can revisit.

Tue, Jul 2, 3:34 PM · Patch-For-Review, Parsoid-PHP

Sun, Jun 30

ssastry placed T224680: Port bin/parserTests.js, the parser tests runner script up for grabs.
Sun, Jun 30, 9:33 PM · Patch-For-Review, Parsoid-PHP
ssastry edited projects for T226931: Parsoid cache invalidation seems not reliable, added: ChangeProp; removed Parsoid.
Sun, Jun 30, 6:12 PM · ChangeProp, RESTBase
ssastry reopened T217540: Mobile-Sections returns missing images as "Open".

@Kelson. Sorry, I didn't imply this wasn't a bug. I did say this is a ChangePropagation issue and tagged @Pchelolo and @mobrovac and asked them to reopen / file a diferent ticket. But, yes a better solution would have been to untag Parsoid and MCS and tag ChangePropagation, which I am going to do now. Thanks for following up and apologies for my confusing triage.

Sun, Jun 30, 6:04 PM · ChangeProp, Reading-Infrastructure-Team-Backlog

Fri, Jun 28

ssastry closed T225580: html2wt failures (not attributable to unported code) as Resolved.

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/519727 fixes some more.

Fri, Jun 28, 10:01 PM · Parsoid-PHP
ssastry added a comment to T225580: html2wt failures (not attributable to unported code).

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/519537 fixes 4 tests.

Fri, Jun 28, 2:48 PM · Parsoid-PHP

Thu, Jun 27

ssastry added a comment to T215000: Fill gaps in PHP DOM's functionality.

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/519523 fixes that.

Thu, Jun 27, 9:28 PM · Patch-For-Review, Parsoid-PHP
ssastry updated the task description for T226683: Ensure that JS & PHP imageinfo requests return responsive urls in the same order.
Thu, Jun 27, 4:17 AM · Parsoid-PHP
ssastry triaged T226683: Ensure that JS & PHP imageinfo requests return responsive urls in the same order as Normal priority.
Thu, Jun 27, 4:15 AM · Parsoid-PHP
ssastry created T226683: Ensure that JS & PHP imageinfo requests return responsive urls in the same order.
Thu, Jun 27, 4:15 AM · Parsoid-PHP

Wed, Jun 26

ssastry added a comment to T180534: Failed template encapsulation.

Шаблон:Неиспользуемые_шаблоны oldId 96001852 on ruwiki

Wed, Jun 26, 8:55 PM · Parsoid-Read-Views

Tue, Jun 25

ssastry added a comment to T226523: Template in wikilink target position also returns pipe separated params.

At this point, I am tempted to say, this is pretty much a won't support scenario. Ideally, we would detect this wikitext pattern and flag it for wikis to fix their wikitext so that code can be supported unless of course this usage is very common practice. But, given that it has taken these many years for someone to notice this breakage indicates that this is likely not very common. If we want to proceed down the path of independent parsing futures, [[ {{template}} ]] will only parse as a link in the case where {[template}} yields a valid link (which we currently support). But if the templateyields pieces of syntax that has to be combined with other syntax from the top-level page that then happens to resemble a wikilink, then that is not something we want to encourage and support going forward.

Tue, Jun 25, 9:05 PM · Patch-For-Review, Mobile-Content-Service, Parsoid, Reading-Infrastructure-Team-Backlog

Mon, Jun 24

ssastry lowered the priority of T225841: Run DOMPostProcessor in hybrid testing mode and fix bugs from High to Normal.

Now that we have a php parse script, we can run wt2html and html2wt entire in PHP without needing to rely on hybrid testing. Hence lowering priority. But, till T224680 is resolved, hybrid testing is useful for running parser tests.

Mon, Jun 24, 9:14 PM · Parsoid-PHP
ssastry moved T226451: Possible bug in PHP Tokenizer: Unexpected OOM from Backlog to Bugs on the Parsoid-PHP board.
Mon, Jun 24, 9:11 PM · Patch-For-Review, Parsoid-PHP
ssastry triaged T226451: Possible bug in PHP Tokenizer: Unexpected OOM as Normal priority.
Mon, Jun 24, 9:11 PM · Patch-For-Review, Parsoid-PHP
ssastry created T226451: Possible bug in PHP Tokenizer: Unexpected OOM.
Mon, Jun 24, 9:11 PM · Patch-For-Review, Parsoid-PHP
ssastry moved T226437: Audit uses of empty() and isset() and eliminate unnecessary uses from Backlog to Porting on the Parsoid-PHP board.
Mon, Jun 24, 6:21 PM · Parsoid-PHP
ssastry triaged T226437: Audit uses of empty() and isset() and eliminate unnecessary uses as Normal priority.
Mon, Jun 24, 6:21 PM · Parsoid-PHP
ssastry created T226437: Audit uses of empty() and isset() and eliminate unnecessary uses.
Mon, Jun 24, 6:21 PM · Parsoid-PHP
ssastry moved T213980: For every ported file, audit all regular expressions for subtle mismatches from Backlog to Porting on the Parsoid-PHP board.
Mon, Jun 24, 4:27 PM · Patch-For-Review, Parsoid-PHP
ssastry moved T226428: Convert stdclass-cast objects to classes wherever possible and use associative arrays elswhere as far as possible from Backlog to Parsoid Code Refactoring (Potentially post-port) on the Parsoid-PHP board.
Mon, Jun 24, 4:27 PM · Technical-Debt, Parsoid-PHP
ssastry triaged T226428: Convert stdclass-cast objects to classes wherever possible and use associative arrays elswhere as far as possible as Normal priority.
Mon, Jun 24, 4:27 PM · Technical-Debt, Parsoid-PHP
ssastry created T226428: Convert stdclass-cast objects to classes wherever possible and use associative arrays elswhere as far as possible.
Mon, Jun 24, 4:26 PM · Technical-Debt, Parsoid-PHP
ssastry updated the task description for T220857: Tech Talks Proposal June 2019: What in the world is Analytics doing back there?.
Mon, Jun 24, 2:32 PM · Developer-Advocacy, Documentation

Jun 21 2019

ssastry triaged T226276: Fix Parsoid PHP code so that phpunit coverage is happy as Normal priority.
Jun 21 2019, 6:01 PM · Patch-For-Review, Parsoid-PHP, Test-Coverage

Jun 20 2019

ssastry added a comment to T226206: Tokenizer errors: "Expected end of input or tlb but "\r" found".

This is probably some old bug that just got lost in the noise of other ignoreable log reports. We should seriously kill a lot of our non-actionable logspam (error/lint, error/lint/api, warn/*).

Jun 20 2019, 5:59 PM · Parsoid
ssastry triaged T226206: Tokenizer errors: "Expected end of input or tlb but "\r" found" as Normal priority.
Jun 20 2019, 5:56 PM · Parsoid
ssastry created T226206: Tokenizer errors: "Expected end of input or tlb but "\r" found".
Jun 20 2019, 5:56 PM · Parsoid

Jun 18 2019

ssastry updated the task description for T225580: html2wt failures (not attributable to unported code).
Jun 18 2019, 5:33 PM · Parsoid-PHP

Jun 17 2019

ssastry added a comment to T211251: Cannot read property 'nodeName' of undefined.

See 159 of these instances in the last 24 hours.

TypeError: Cannot read property 'nodeName' of undefined
    at Object.getWrapperTokens (/srv/deployment/parsoid/deploy-cache/revs/a8d9f6e0b6a7e61684fffbdac897473b9acf2f82/src/lib/utils/PipelineUtils.js:354:18)
    at Object.encapsulateExpansionHTML (/srv/deployment/parsoid/deploy-cache/revs/a8d9f6e0b6a7e61684fffbdac897473b9acf2f82/src/lib/utils/PipelineUtils.js:477:28)
    at Object.tunnelDOMThroughTokens (/srv/deployment/parsoid/deploy-cache/revs/a8d9f6e0b6a7e61684fffbdac897473b9acf2f82/src/lib/utils/PipelineUtils.js:586:24)
    at DOMFragmentBuilder.wrapDOMFragment (/srv/deployment/parsoid/deploy-cache/revs/a8d9f6e0b6a7e61684fffbdac897473b9acf2f82/src/lib/wt2html/tt/DOMFragmentBuilder.js:105:30)
    at DOMPostProcessor.documentCB (/srv/deployment/parsoid/deploy-cache/revs/a8d9f6e0b6a7e61684fffbdac897473b9acf2f82/src/lib/wt2html/tt/DOMFragmentBuilder.js:96:30)
    at emitOne (events.js:101:20)
    at DOMPostProcessor.emit (events.js:188:7)
    at DOMPostProcessor.<anonymous> (/srv/deployment/parsoid/deploy-cache/revs/a8d9f6e0b6a7e61684fffbdac897473b9acf2f82/src/lib/wt2html/DOMPostProcessor.js:723:7)
    at next (native)
    at tryCatchNext (/srv/deployment/parsoid/deploy-cache/revs/a8d9f6e0b6a7e61684fffbdac897473b9acf2f82/node_modules/prfun/lib/index.js:783:28)
    at continuer (/srv/deployment/parsoid/deploy-cache/revs/a8d9f6e0b6a7e61684fffbdac897473b9acf2f82/node_modules/prfun/lib/index.js:800:24)
    at callback (/srv/deployment/parsoid/deploy-cache/revs/a8d9f6e0b6a7e61684fffbdac897473b9acf2f82/node_modules/prfun/lib/index.js:812:43)
    at tryCatch1 (/srv/deployment/parsoid/deploy-cache/revs/a8d9f6e0b6a7e61684fffbdac897473b9acf2f82/node_modules/babybird/lib/promise.js:40:12)
    at promiseReactionJob (/srv/deployment/parsoid/deploy-cache/revs/a8d9f6e0b6a7e61684fffbdac897473b9acf2f82/node_modules/babybird/lib/promise.js:269:19)
    at PromiseReactionJobTask.call (/srv/deployment/parsoid/deploy-cache/revs/a8d9f6e0b6a7e61684fffbdac897473b9acf2f82/node_modules/babybird/lib/promise.js:284:3)
    at flush (/srv/deployment/parsoid/deploy-cache/revs/a8d9f6e0b6a7e61684fffbdac897473b9acf2f82/node_modules/asap/raw.js:50:29)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)
Jun 17 2019, 10:03 PM · Parsoid
ssastry triaged T220857: Tech Talks Proposal June 2019: What in the world is Analytics doing back there? as Normal priority.
Jun 17 2019, 4:08 PM · Developer-Advocacy, Documentation

Jun 14 2019

ssastry added a comment to T225848: Serialization errors not propagated to web response.

Tangential to the actual bug report, given that mw:Param is only inserted for top-level {{{..}}} that can't be expanded and hence is emitted as is, not sure why Parsoid html2wt insists on data-mw for this case.

Jun 14 2019, 8:35 PM · Parsoid
ssastry closed T219940: Port parser.js (wt2html parser pipeline construction) as Resolved.
Jun 14 2019, 5:32 PM · Parsoid-PHP
ssastry closed T219939: Port TokenTransformManager + AttributeTransformManager as Resolved.
Jun 14 2019, 5:31 PM · Parsoid-PHP
ssastry moved T225841: Run DOMPostProcessor in hybrid testing mode and fix bugs from Backlog to Bugs on the Parsoid-PHP board.
Jun 14 2019, 5:31 PM · Parsoid-PHP
ssastry triaged T225841: Run DOMPostProcessor in hybrid testing mode and fix bugs as High priority.
Jun 14 2019, 5:30 PM · Parsoid-PHP
ssastry created T225841: Run DOMPostProcessor in hybrid testing mode and fix bugs.
Jun 14 2019, 5:30 PM · Parsoid-PHP

Jun 12 2019

ssastry renamed T225550: Categories (and possibly other start-of-line transparent wikitext) that follow indent-pre wikitext get absorbed into <pre> tags and don't round-trip from Escalating whitespace before a category, increasing with each edit to Categories (and possibly other start-of-line transparent wikitext) that follow indent-pre wikitext get absorbed into <pre> tags and don't round-trip.
Jun 12 2019, 9:54 PM · Parsoid
ssastry added a comment to T225217: VE is removing spaces (dirty diffs) on some wikis (wikitech, officewiki).

This should be resolved by the Parsoid patch and now we're just waiting for the next Parsoid deployment, correct?

Jun 12 2019, 3:32 PM · User-Ryasmeen, Patch-For-Review, Parsoid-Edit-Support, VisualEditor

Jun 11 2019

ssastry moved T225580: html2wt failures (not attributable to unported code) from Backlog to Bugs on the Parsoid-PHP board.
Jun 11 2019, 11:42 PM · Parsoid-PHP
ssastry changed the subtype of T225580: html2wt failures (not attributable to unported code) from "Task" to "Bug Report".
Jun 11 2019, 11:42 PM · Parsoid-PHP
ssastry triaged T225580: html2wt failures (not attributable to unported code) as High priority.
Jun 11 2019, 11:41 PM · Parsoid-PHP
ssastry created T225580: html2wt failures (not attributable to unported code).
Jun 11 2019, 11:41 PM · Parsoid-PHP
ssastry merged T225559: VisualEditor edits no longer preserve formatting of unchanged content into T225217: VE is removing spaces (dirty diffs) on some wikis (wikitech, officewiki).
Jun 11 2019, 7:23 PM · User-Ryasmeen, Patch-For-Review, Parsoid-Edit-Support, VisualEditor
ssastry merged task T225559: VisualEditor edits no longer preserve formatting of unchanged content into T225217: VE is removing spaces (dirty diffs) on some wikis (wikitech, officewiki).
Jun 11 2019, 7:23 PM · Regression, Parsoid, VisualEditor
ssastry assigned T225235: Hybrid testing should use the JS mock API on the PHP side, for files at least to Arlolra.
Jun 11 2019, 6:36 PM · Patch-For-Review, Parsoid-PHP
ssastry moved T225235: Hybrid testing should use the JS mock API on the PHP side, for files at least from Backlog to Testing / QA / Deployment on the Parsoid-PHP board.
Jun 11 2019, 2:35 PM · Patch-For-Review, Parsoid-PHP
ssastry triaged T225235: Hybrid testing should use the JS mock API on the PHP side, for files at least as Normal priority.
Jun 11 2019, 2:35 PM · Patch-For-Review, Parsoid-PHP

Jun 10 2019

ssastry triaged T214601: Gallery media is erroneously using sub-typeof if format is supplied as Normal priority.
Jun 10 2019, 8:53 PM · Parsoid
ssastry moved T214601: Gallery media is erroneously using sub-typeof if format is supplied from Backlog to Link syntax (links & media) on the Parsoid board.
Jun 10 2019, 8:53 PM · Parsoid