Page MenuHomePhabricator

ssastry (Subramanya Sastry)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 5:34 AM (240 w, 5 d)
Availability
Available
LDAP User
Subramanya Sastry
MediaWiki User
SSastry (WMF) [ Global Accounts ]

Recent Activity

Fri, May 17

ssastry moved T205455: transformTests.js fails to validate QuoteTransformer on a bunch of wiki pages from Backlog to Bugs on the Parsoid-PHP board.
Fri, May 17, 6:18 PM · Parsoid-PHP, Patch-For-Review, Parsoid-Tests
ssastry moved T223411: PHP regression when switching from extTagWidths to extTagOffsets from Backlog to Bugs on the Parsoid-PHP board.
Fri, May 17, 6:18 PM · Patch-For-Review, Parsoid-PHP
ssastry closed T223411: PHP regression when switching from extTagWidths to extTagOffsets as Resolved.
Fri, May 17, 6:17 PM · Patch-For-Review, Parsoid-PHP
ssastry added a comment to T222988: wt2html test failures in hybrid testing.

Besides the 3 there, there is also Includes and comments at SOL that needs investigation.

Fri, May 17, 6:00 PM · Patch-For-Review, Parsoid-PHP

Tue, May 14

ssastry changed the subtype of T223296: proposal: new &? !? and ~? predicates from "Task" to "Feature Request".
Tue, May 14, 4:34 PM · Patch-For-Review, Parsoid
ssastry triaged T223296: proposal: new &? !? and ~? predicates as Low priority.
Tue, May 14, 4:19 PM · Patch-For-Review, Parsoid
ssastry triaged T221989: Should Parsoid\Wt2Html\PP\Processors\Linter::getNextMatchingNode() be testing nextNonSepSibling() rather than nextSibling? as Normal priority.
Tue, May 14, 4:24 AM · Parsoid-Linter
ssastry claimed T219940: Port parser.js (wt2html parser pipeline construction).
Tue, May 14, 4:24 AM · Parsoid-PHP
ssastry claimed T222988: wt2html test failures in hybrid testing.
Tue, May 14, 4:24 AM · Patch-For-Review, Parsoid-PHP
ssastry moved T223194: Consider using instanceof checks for DOM Nodes instead of DOMUtils::is* + DOMUtils::assertElt combinations from Backlog to Performance on the Parsoid-PHP board.
Tue, May 14, 4:21 AM · Parsoid-PHP
ssastry triaged T223193: Consider using instanceof instead of TokenUtils::getTokenType as Normal priority.
Tue, May 14, 4:21 AM · Parsoid-PHP
ssastry moved T223193: Consider using instanceof instead of TokenUtils::getTokenType from Backlog to Performance on the Parsoid-PHP board.
Tue, May 14, 4:21 AM · Parsoid-PHP
ssastry triaged T223194: Consider using instanceof checks for DOM Nodes instead of DOMUtils::is* + DOMUtils::assertElt combinations as Normal priority.
Tue, May 14, 4:21 AM · Parsoid-PHP
ssastry created T223194: Consider using instanceof checks for DOM Nodes instead of DOMUtils::is* + DOMUtils::assertElt combinations.
Tue, May 14, 4:20 AM · Parsoid-PHP
ssastry created T223193: Consider using instanceof instead of TokenUtils::getTokenType.
Tue, May 14, 4:19 AM · Parsoid-PHP

Mon, May 13

ssastry added a comment to T222988: wt2html test failures in hybrid testing.

With these fixes, we are down to 3 failures (which fail for known reasons)

T107652: <ref>s in templates that also generate table cell attributes should be rendered properly <-- TOKENIZER related which cscott is working on
<pre> inside a link                                                                               <-- KNOWN failure because of bad Parsoid DOM which doesn't roundtrip across serialization and parse
{{!}} is a magic word                                                                             <-- KNOWN failure possibly because of some unported code

So, I think we are good for now here.

I lied it seems. I broke more things by the refactoring in later patches while fixing those other failing tests. While testing, I ran just those failing tests instead of a full test run. Anyway, will take a look today.

Mon, May 13, 10:18 PM · Patch-For-Review, Parsoid-PHP
ssastry added a comment to T222988: wt2html test failures in hybrid testing.

With these fixes, we are down to 3 failures (which fail for known reasons)

T107652: <ref>s in templates that also generate table cell attributes should be rendered properly <-- TOKENIZER related which cscott is working on
<pre> inside a link                                                                               <-- KNOWN failure because of bad Parsoid DOM which doesn't roundtrip across serialization and parse
{{!}} is a magic word                                                                             <-- KNOWN failure possibly because of some unported code

So, I think we are good for now here.

Mon, May 13, 7:00 PM · Patch-For-Review, Parsoid-PHP

Sun, May 12

ssastry lowered the priority of T222988: wt2html test failures in hybrid testing from High to Normal.

With these fixes, we are down to 3 failures (which fail for known reasons)

T107652: <ref>s in templates that also generate table cell attributes should be rendered properly <-- TOKENIZER related which cscott is working on
<pre> inside a link                                                                               <-- KNOWN failure because of bad Parsoid DOM which doesn't roundtrip across serialization and parse
{{!}} is a magic word                                                                             <-- KNOWN failure possibly because of some unported code

So, I think we are good for now here.

Sun, May 12, 3:51 AM · Patch-For-Review, Parsoid-PHP

Sat, May 11

ssastry added a comment to T222988: wt2html test failures in hybrid testing.

Change 509592 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Hybrid testing: Pass env.fragmentMap for pipeline stages

https://gerrit.wikimedia.org/r/509592

Sat, May 11, 5:17 PM · Patch-For-Review, Parsoid-PHP
ssastry added a comment to T217867: Port domino (or another spec-compliant DOM library) to PHP.

Nice work! Quick initial comment now. As far as Parsoid is concerned, assuming feature parity wrt functionality, performance will be the biggest determining factor here since Parsoid's functionality is heavily DOM based.

I'm thinking an initial sanity check could be performance vs. PHP DOM on generic tasks, yes? What could be a good representative task / set of tasks? Build large document? Read, parse (with RemexHtml), modify, write? At least to get a handle on whether it's off by an order of magnitude or something and just isn't going to work.

Sat, May 11, 3:16 AM · Core Platform Team Backlog (Attic), Parsoid-PHP
ssastry added a comment to T222992: Upgrading remex-html to 2.0.2 causes 18 test failures.

...though it seems impossible, I've confirmed that 3058052c756ac7b69ead21b4b237a1cd6714de8a in Remex causes these failures. (If only I knew why!)

Sat, May 11, 3:01 AM · Patch-For-Review, RemexHtml, Parsing-Team, MediaWiki-Parser
ssastry triaged T222992: Upgrading remex-html to 2.0.2 causes 18 test failures as Normal priority.
Sat, May 11, 2:57 AM · Patch-For-Review, RemexHtml, Parsing-Team, MediaWiki-Parser
ssastry assigned T222992: Upgrading remex-html to 2.0.2 causes 18 test failures to cscott.
Sat, May 11, 2:11 AM · Patch-For-Review, RemexHtml, Parsing-Team, MediaWiki-Parser

Fri, May 10

ssastry moved T222988: wt2html test failures in hybrid testing from Backlog to Bugs on the Parsoid-PHP board.
Fri, May 10, 10:35 PM · Patch-For-Review, Parsoid-PHP
ssastry triaged T222988: wt2html test failures in hybrid testing as High priority.
Fri, May 10, 10:34 PM · Patch-For-Review, Parsoid-PHP
ssastry created T222988: wt2html test failures in hybrid testing.
Fri, May 10, 10:34 PM · Patch-For-Review, Parsoid-PHP

Wed, May 8

ssastry moved T103635: Stop the user from adding a langlink when we think they wanted to insert an interwiki instead from Backlog to Links! on the Parsoid-Edit-Support board.
Wed, May 8, 6:49 PM · Parsoid-Edit-Support, VisualEditor-MediaWiki, VisualEditor
ssastry moved T222607: Parsoid doesn't roundtrip multiple category links in a table cell from Backlog to Links! on the Parsoid-Edit-Support board.
Wed, May 8, 6:49 PM · Parsoid-Edit-Support
ssastry edited projects for T103635: Stop the user from adding a langlink when we think they wanted to insert an interwiki instead, added: Parsoid-Edit-Support; removed Parsoid.
Wed, May 8, 6:49 PM · Parsoid-Edit-Support, VisualEditor-MediaWiki, VisualEditor
ssastry added a comment to T222770: Parser rule clean-up: extlink_preprocessor_text_parameterized.

I have marked all these tasks low for now. We'll revisit them post-port.

Wed, May 8, 3:42 PM · Parsoid
ssastry moved T221872: composer-package-php73-docker seems to fail often on Parsoid builds from Backlog to Non-Parsoid Tasks on the Parsoid board.
Wed, May 8, 3:41 PM · Parsoid, Continuous-Integration-Infrastructure, Jenkins
ssastry triaged T221941: Timeouts parsing Portail:Accueil/Bandeaux as Normal priority.
Wed, May 8, 3:41 PM · Parsoid
ssastry triaged T222419: Incorrect section numbering after unclosed subst as Normal priority.
Wed, May 8, 3:41 PM · Parsoid-Read-Views, Patch-For-Review, Reading-Infrastructure-Team-Backlog, Page Content Service
ssastry triaged T222770: Parser rule clean-up: extlink_preprocessor_text_parameterized as Low priority.
Wed, May 8, 3:40 PM · Parsoid
ssastry triaged T222561: Minor: don't test for "/" before autolink as Low priority.
Wed, May 8, 3:40 PM · Patch-For-Review, Parsoid
ssastry triaged T222560: flattenIfArray should just accept null/undefined result as Low priority.
Wed, May 8, 3:40 PM · Patch-For-Review, Parsoid
ssastry triaged T222774: Parser rule clean-up: url & autourl as Low priority.
Wed, May 8, 3:39 PM · Parsoid
ssastry added a comment to T216664: MWException when viewing or comparing certain pages with Preprocessor_DOM (PHP7 beta feature).

Okay, I'll chat with Scott and Tim about this and figure out who can tackle this.

Wed, May 8, 2:35 PM · serviceops, Core Platform Team Kanban (Waiting for Review), Core Platform Team (Security, stability, performance and scalability (TEC1)), PHP 7.2 support, MediaWiki-History-and-Diffs, MediaWiki-Parser, Wikimedia-production-error
ssastry added a comment to T219933: parsoid-vd on scandium randomly died.

did this issue get fixed? i just checked scandium and parsoid-vd has been running for 3 weeks

Thanks! Based on this and also on:

This is not critical. I asked @Dzahn to turn off these alerts for now. Meanwhile, I started a test run to confirm that the service
doesn't terminate when there is activity against the service.

I would say we can close this. @ssastry if you disagree we can of course reopen it right away.

Wed, May 8, 2:34 PM · Patch-For-Review, Operations
ssastry added a comment to T222770: Parser rule clean-up: extlink_preprocessor_text_parameterized.

@Dan1wang thanks very much for all the phab tasks exploring the PEG tokenizer with suggestions for possible simplifications / improvements of the rules. We appreciate the attention and effort you've been putting in here.

Wed, May 8, 3:02 AM · Parsoid

Tue, May 7

ssastry triaged T221790: Parsoid extension API should use DOM fragments, not documents as Normal priority.
Tue, May 7, 9:27 PM · Parsoid-PHP
ssastry moved T221790: Parsoid extension API should use DOM fragments, not documents from Backlog to Parsoid Code Refactoring (Potentially post-port) on the Parsoid-PHP board.
Tue, May 7, 9:26 PM · Parsoid-PHP
ssastry moved T222738: Add annotation about offset-type in the data-parsoid blob from Backlog to Testing / QA / Deployment on the Parsoid-PHP board.
Tue, May 7, 9:26 PM · Parsoid-PHP
ssastry updated subscribers of T222738: Add annotation about offset-type in the data-parsoid blob.
Tue, May 7, 6:32 PM · Parsoid-PHP
ssastry added a comment to T221907: Security Concept Review For Parsoid-PHP.

@ssastry - looking at https://gerrit.wikimedia.org/r/q/project:mediawiki%252Fservices%252Fparsoid - are most of the patch sets here related to the new PHP-Parser development? Is there a specific start date or branch/topic we should be paying attention to right now for the new development? Or does master for mediawiki/services/parsoid fulfill that role right now? Trying to understand if it's worth the Security-Team's time to have a look at recent patch sets or if we should wait for a more stable release branch, etc. Thanks.

Tue, May 7, 6:27 PM · Security-Team-Review-Active, Parsoid-PHP
ssastry triaged T222738: Add annotation about offset-type in the data-parsoid blob as Normal priority.
Tue, May 7, 4:21 PM · Parsoid-PHP
ssastry added a comment to T221941: Timeouts parsing Portail:Accueil/Bandeaux.

Sorry, we are heads down in the porting world and we cannot investigate this deeply at this point. But, at first glance, yes, it seems like some bug in Parsoid. I ran a --trace peg and it took a while before that output stopped. But after that, I didn't see any activity. So, probably it got stuck elsewhere in the pipeline. We have --trace options for almost every stage in the pipeline. So, we'll have to play with them or if that doesn't work hook up a debugged to see what is going on. But, this is not something we can take a look at in the immediate term.

Tue, May 7, 1:44 PM · Parsoid
ssastry added a comment to T222639: VisualEditor should request Parsoid HTML with ?stash=true query parameter.

@ssastry @Arlolra so the TL;DR is: if we have the exact render data-parsoid, send it, otherwise just send the modified HTML. Is that assessment correct?

Tue, May 7, 1:32 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Core Platform Team Kanban (Done with CPT), Services (done), VisualEditor (Current work), Core Platform Team (RESTBase Split (CDP2)), User-mobrovac, Parsoid, RESTBase

Mon, May 6

ssastry closed T219941: Port DOM Post Processor as Resolved.
Mon, May 6, 10:20 PM · Patch-For-Review, Parsoid-PHP
ssastry renamed T222607: Parsoid doesn't roundtrip multiple category links in a table cell from Visual editor inserts line break between table tags truncating the table to Parsoid doesn't roundtrip multiple category links in a table cell.
Mon, May 6, 6:40 PM · Parsoid-Edit-Support
ssastry added a comment to T222607: Parsoid doesn't roundtrip multiple category links in a table cell.

@matmarex thinks this is likely to be a Parsoid issue. @ssastry please let us know if your team disagrees.

Mon, May 6, 6:39 PM · Parsoid-Edit-Support
ssastry added a comment to T222639: VisualEditor should request Parsoid HTML with ?stash=true query parameter.

(b) so, should we send no data-parsoid entirely, or send 'whatever we have even if not matching'?

Mon, May 6, 4:45 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Core Platform Team Kanban (Done with CPT), Services (done), VisualEditor (Current work), Core Platform Team (RESTBase Split (CDP2)), User-mobrovac, Parsoid, RESTBase
ssastry updated subscribers of T222639: VisualEditor should request Parsoid HTML with ?stash=true query parameter.
Mon, May 6, 4:43 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Core Platform Team Kanban (Done with CPT), Services (done), VisualEditor (Current work), Core Platform Team (RESTBase Split (CDP2)), User-mobrovac, Parsoid, RESTBase
ssastry added a comment to T222639: VisualEditor should request Parsoid HTML with ?stash=true query parameter.

@Pchelolo: this doesn't just affect VE but all Parsoid clients that might fetch html for editing and might then post edited html for save. So, couple of comments (a) this should actually be documented in the API docs (swagger?) alongwith the implications of what happens if a client doesn't comply ... which brings me to the next point (b) if data-parsoid is missing, we should make sure RESTBase sends data that Parsoid serializes correctly ... the output should still be correct but it may be normalized (and hence cause a dirty diff).

Mon, May 6, 4:39 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Core Platform Team Kanban (Done with CPT), Services (done), VisualEditor (Current work), Core Platform Team (RESTBase Split (CDP2)), User-mobrovac, Parsoid, RESTBase

Fri, May 3

ssastry added a comment to T217867: Port domino (or another spec-compliant DOM library) to PHP.

As I previously mentioned to @cscott, who provided useful early guidance, I spent my 10% time in April working on a port of Domino.js to native PHP. Most of the core DOM functionality that was covered by Domino.js is complete, so I thought I ought to let folks know this has been going on. I didn't want to "lick the cookie," in case I ended up not getting very far.
...
Anyone who wishes to be involved is welcome. I'll also continue working on it, but now that actual code exists, it might be good to talk specifics so that development goes in a direction beneficial to the Parsing team or whoever else could use it (T218183).

Fri, May 3, 7:46 PM · Core Platform Team Backlog (Attic), Parsoid-PHP

Thu, May 2

ssastry added a project to T221738: Parsoid REST API routes in MediaWiki: StructuredDiscussions.
Thu, May 2, 8:44 PM · Growth-Team, StructuredDiscussions, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Parsoid-PHP, Services (watching), MediaWiki-Parser
ssastry added a comment to T221158: Parsoid REST API in PHP.

StructuredDiscussions folks: note that since you don't talk with RESTBase, you will need to update your code and config to use the new Parsoid-PHP endpoints. I'll create a phab task for you. But this is FYI. You might also be interested in following T221738: Parsoid REST API routes in MediaWiki more specifically.

Thu, May 2, 8:42 PM · Growth-Team, StructuredDiscussions, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Parsoid-PHP, Services (watching), Goal, MediaWiki-Parser
ssastry added a project to T221158: Parsoid REST API in PHP: StructuredDiscussions.
Thu, May 2, 8:37 PM · Growth-Team, StructuredDiscussions, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Parsoid-PHP, Services (watching), Goal, MediaWiki-Parser
ssastry moved T222397: Parsoid-PHP: Audit Flow functionality to make sure it doesn't require use of data-parsoid source offsets from Backlog to Non-parsing Team Work on the Parsoid-PHP board.
Thu, May 2, 8:36 PM · Growth-Team, StructuredDiscussions, Parsoid-PHP
ssastry added a comment to T222397: Parsoid-PHP: Audit Flow functionality to make sure it doesn't require use of data-parsoid source offsets.

We are currently targeting a Parsoid-PHP deploy in Q1 2019/20. So, ideally, this task would be resolved by mid-July.

Thu, May 2, 8:35 PM · Growth-Team, StructuredDiscussions, Parsoid-PHP
ssastry triaged T222397: Parsoid-PHP: Audit Flow functionality to make sure it doesn't require use of data-parsoid source offsets as Normal priority.
Thu, May 2, 8:34 PM · Growth-Team, StructuredDiscussions, Parsoid-PHP
ssastry created T222397: Parsoid-PHP: Audit Flow functionality to make sure it doesn't require use of data-parsoid source offsets.
Thu, May 2, 8:34 PM · Growth-Team, StructuredDiscussions, Parsoid-PHP
ssastry moved T221740: OpenAPI 3.0 Definition for Parsoid REST API from Backlog to Non-parsing Team Work on the Parsoid-PHP board.
Thu, May 2, 8:26 PM · MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Parsoid-PHP, Services (watching), MediaWiki-Parser
ssastry moved T221158: Parsoid REST API in PHP from Porting to Non-parsing Team Work on the Parsoid-PHP board.
Thu, May 2, 8:26 PM · Growth-Team, StructuredDiscussions, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Parsoid-PHP, Services (watching), Goal, MediaWiki-Parser
ssastry moved T221907: Security Concept Review For Parsoid-PHP from Backlog to Testing / QA / Deployment on the Parsoid-PHP board.
Thu, May 2, 4:40 AM · Security-Team-Review-Active, Parsoid-PHP
ssastry moved T221988: Spec a PHP interface that will serve as an entry point into the Parsoid-PHP composer lib from Backlog to Porting on the Parsoid-PHP board.
Thu, May 2, 4:40 AM · Patch-For-Review, Parsoid-PHP
ssastry added a comment to T211161: Tweaks to genTest option in parse.js.

Once porting is done, we are unlikely to use this test mode much. And given hybrid testing is working fairly well, this testing mode doesn't have as much utility as it did in the early days of porting. We can revisit this if this testing mode has utility post-porting.

Thu, May 2, 4:39 AM · Patch-For-Review, Parsoid-PHP
ssastry closed T211161: Tweaks to genTest option in parse.js as Declined.
Thu, May 2, 4:36 AM · Patch-For-Review, Parsoid-PHP
ssastry closed T219071: Set up hybrid JS testing runs in CI as Resolved.

With https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/505681, we have initial CI testing in place now. This can be extended as more code is ported.

Thu, May 2, 4:36 AM · Parsoid-PHP
ssastry reassigned T222130: Simplify `nowiki_text` parsing from ssastry to cscott.
Thu, May 2, 4:33 AM · Patch-For-Review, Parsoid
ssastry closed T222130: Simplify `nowiki_text` parsing as Resolved.
Thu, May 2, 4:33 AM · Patch-For-Review, Parsoid

Wed, May 1

ssastry added a comment to T222266: Edge case difference processing templated styles in table cells.

Because of this bug, a number of cells on this page don't get a background colour.

Wed, May 1, 2:51 PM · Parsoid-Read-Views
ssastry triaged T222266: Edge case difference processing templated styles in table cells as Normal priority.
Wed, May 1, 2:50 PM · Parsoid-Read-Views
ssastry created T222266: Edge case difference processing templated styles in table cells.
Wed, May 1, 2:50 PM · Parsoid-Read-Views
ssastry added a comment to T221988: Spec a PHP interface that will serve as an entry point into the Parsoid-PHP composer lib.

probably review the phab task for dependency injection. the constructor or entry point should probably take an abstract object for Env, I think that's the point at which all our "dependencies are injected"

I don't think we want to inject an Env. The plan I had was that we'd inject a SiteConfig into the constructor, and pass a PageConfig and DataAccess into the entry point methods as it's possible for MediaWiki to want to parse multiple different blobs of wikitext within the course of one request (and ideally without having to reinitialize Parsoid each time). The entry point methods would combine the three to create the Env, which would be completely internal to Parsoid-PHP.

Wed, May 1, 2:40 AM · Patch-For-Review, Parsoid-PHP
ssastry triaged T221988: Spec a PHP interface that will serve as an entry point into the Parsoid-PHP composer lib as High priority.
Wed, May 1, 2:31 AM · Patch-For-Review, Parsoid-PHP

Tue, Apr 30

ssastry merged T222219: phpunit-coverage-docker-publish fails because of incorrect version of PHP into T219319: Parsoid/PHP post-merge doc publishing task needs updating to use PHP 7.2.
Tue, Apr 30, 7:08 PM · Parsoid-PHP
ssastry merged task T222219: phpunit-coverage-docker-publish fails because of incorrect version of PHP into T219319: Parsoid/PHP post-merge doc publishing task needs updating to use PHP 7.2.
Tue, Apr 30, 7:08 PM · Continuous-Integration-Infrastructure, Parsoid
ssastry added a comment to T222064: Parsoid doesn't work with node 12.

@ssastry What do you think about mentioning it on https://www.mediawiki.org/wiki/Parsoid/Setup ?

Tue, Apr 30, 3:39 AM · Parsoid

Mon, Apr 29

ssastry added a comment to T221907: Security Concept Review For Parsoid-PHP.

@ssastry - thanks for submitting this. I was just curious if there's a more concrete deployment date in mind than "Q1 2019/20". That would help us a bit more with our scheduling.

Mon, Apr 29, 3:29 PM · Security-Team-Review-Active, Parsoid-PHP
ssastry triaged T222064: Parsoid doesn't work with node 12 as Low priority.

We are currently focused on the PHP port and won't be able to attend to this for a while.

Mon, Apr 29, 1:37 PM · Parsoid
ssastry closed T222048: Parsoid VE should not decode HTML5 entities as Declined.

Yes, the correct solution is to address T94603.

Mon, Apr 29, 1:33 PM · Parsoid

Fri, Apr 26

ssastry added a comment to T221907: Security Concept Review For Parsoid-PHP.

I recall that we did have the issue with Parsoid being exposed to sensitive content, specifically usernames and deleted revisions. The details are foggy, but I vaguely recall that I had to remove some information from the <head> of the Parsoid document because it could expose information about deleted revisions.

Fri, Apr 26, 3:13 PM · Security-Team-Review-Active, Parsoid-PHP

Thu, Apr 25

ssastry added a comment to T221907: Security Concept Review For Parsoid-PHP.

I would like to explicitly separate two projects: (a) deployment of Parsoid/PHP as a replacement for Parsoid/JS (b) making Parsoid/PHP the default wikitext engine on Wikimedia cluster.

Thu, Apr 25, 11:03 PM · Security-Team-Review-Active, Parsoid-PHP
ssastry updated the task description for T221907: Security Concept Review For Parsoid-PHP.
Thu, Apr 25, 10:37 PM · Security-Team-Review-Active, Parsoid-PHP
ssastry created T221907: Security Concept Review For Parsoid-PHP.
Thu, Apr 25, 10:33 PM · Security-Team-Review-Active, Parsoid-PHP
ssastry added a comment to T221876: Pick one html5 source (whatwg or w3c) and update all code documentation links to point to that source.

This seems pretty low priority; W3C is following the WHATWG spec so there's no real difference. WHATWG tends to lead, and then their decisions are ratified by W3C sometime later.

Thu, Apr 25, 5:19 PM · Documentation, Parsoid-PHP
ssastry moved T221876: Pick one html5 source (whatwg or w3c) and update all code documentation links to point to that source from Backlog to Parsoid Code Refactoring (Potentially post-port) on the Parsoid-PHP board.
Thu, Apr 25, 5:00 PM · Documentation, Parsoid-PHP
ssastry triaged T221876: Pick one html5 source (whatwg or w3c) and update all code documentation links to point to that source as Low priority.
Thu, Apr 25, 4:59 PM · Documentation, Parsoid-PHP
ssastry created T221876: Pick one html5 source (whatwg or w3c) and update all code documentation links to point to that source.
Thu, Apr 25, 4:59 PM · Documentation, Parsoid-PHP

Wed, Apr 24

ssastry triaged T221677: Sanitizer::validateAttributes is not as efficient as it could be as Normal priority.
Wed, Apr 24, 6:58 PM · Parsoid-PHP, MediaWiki-Parser
ssastry moved T221677: Sanitizer::validateAttributes is not as efficient as it could be from Backlog to Performance on the Parsoid-PHP board.
Wed, Apr 24, 6:58 PM · Parsoid-PHP, MediaWiki-Parser
ssastry merged T205339: Implement Parsoid's API / URL routing in MediaWiki core into T221738: Parsoid REST API routes in MediaWiki.
Wed, Apr 24, 6:44 PM · Growth-Team, StructuredDiscussions, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Parsoid-PHP, Services (watching), MediaWiki-Parser
ssastry merged task T205339: Implement Parsoid's API / URL routing in MediaWiki core into T221738: Parsoid REST API routes in MediaWiki.
Wed, Apr 24, 6:44 PM · Parsoid-PHP

Mon, Apr 22

ssastry renamed T221552: Give Sanitizer a HTML5 makeover from Give Sanitizer a HTML5 makover. to Give Sanitizer a HTML5 makeover.
Mon, Apr 22, 4:18 PM · Parsoid-PHP
ssastry moved T221552: Give Sanitizer a HTML5 makeover from Backlog to Parsoid Code Refactoring (Potentially post-port) on the Parsoid-PHP board.
Mon, Apr 22, 4:18 PM · Parsoid-PHP
ssastry triaged T221552: Give Sanitizer a HTML5 makeover as Normal priority.
Mon, Apr 22, 4:18 PM · Parsoid-PHP
ssastry created T221552: Give Sanitizer a HTML5 makeover.
Mon, Apr 22, 4:17 PM · Parsoid-PHP
ssastry moved T219943: Create a composer library for wikipeg from Porting to Non-Porting Tasks on the Parsoid-PHP board.
Mon, Apr 22, 2:31 PM · Patch-For-Review, Core Platform Team (Parsoid PHP (CDP2)), Parsoid-PHP
ssastry removed a project from T219939: Port TokenTransformManager + AttributeTransformManager: Patch-For-Review.
Mon, Apr 22, 2:31 PM · Parsoid-PHP