Page MenuHomePhabricator

ssastry (Subramanya Sastry)
User

Projects (23)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 5:34 AM (403 w, 3 d)
Availability
Available
LDAP User
Subramanya Sastry
MediaWiki User
SSastry (WMF) [ Global Accounts ]

Recent Activity

Yesterday

ssastry updated the task description for T311867: Support redirects to private endpoints.
Fri, Jul 1, 4:58 PM · Patch-For-Review, MediaWiki-REST-API, Platform Team Workboards (MW Expedition)

Thu, Jun 30

ssastry added a comment to T311731: Cannot declare class Wikimedia\MWConfig\Profiler, because the name is already in use in Profiler.php.

I am waving hands here, but I wonder if this is a symptom of OOM / timeout and something not being cleaned up properly on the server, but not sure how / why a new request would be sent to the same process.

Thu, Jun 30, 9:56 PM · Parsoid, Wikimedia-production-error
ssastry moved T311592: Collect information about old Parser `getTargetLanguage` usage from Needs Triage to Missing Functionality on the Parsoid board.
Thu, Jun 30, 6:27 PM · Patch-For-Review, Parsoid, Parsoid-Read-Views (Phase 4 - Parsoid generates metadata needed by core)
ssastry moved T311670: Parsoid Extension API: Should we change signature of sourceToDom so self-closed tags are detectable from the signature? from Needs Triage to Known Differences on the Parsoid board.
Thu, Jun 30, 6:26 PM · Parsoid
ssastry added a project to T290526: Piped links using {{!}} are not rendered correctly: Parsoid-Read-Views (Phase 2 - testwiki Main namespace support).
Thu, Jun 30, 3:32 PM · Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid, Patch-For-Review

Wed, Jun 29

ssastry triaged T311670: Parsoid Extension API: Should we change signature of sourceToDom so self-closed tags are detectable from the signature? as Low priority.
Wed, Jun 29, 8:45 PM · Parsoid
ssastry created T311670: Parsoid Extension API: Should we change signature of sourceToDom so self-closed tags are detectable from the signature?.
Wed, Jun 29, 8:45 PM · Parsoid

Thu, Jun 23

ssastry moved T310878: Consolidate ParsoidHandler base class with ParsoidHTMLHelper from Needs Triage to Tech Debt / Big changes on the Parsoid board.
Thu, Jun 23, 3:02 AM · Parsoid, Platform Team Workboards (MW Expedition), User-xSavitar
ssastry edited projects for T310904: Find out if Varnish is messing with ETags, and what to do about it., added: Parsoid (Tracking); removed Parsoid.
Thu, Jun 23, 3:02 AM · Parsoid (Tracking), SRE, Traffic, API Platform, Platform Team Workboards (MW Expedition), VisualEditor

Tue, Jun 21

ssastry closed T241968: Investigate source of performance improvements in Parsoid/PHP over Parsoid/JS as Declined.

I don't think we'll ever get to this and all this is a bit of water under the bridge. So, I am simply going to decline this.

Tue, Jun 21, 4:45 PM · Parsoid, Performance Issue

Fri, Jun 17

ssastry closed T270310: Parsoid PageConfigFactory should accept a revision record, not wikitextOverride as Resolved.
Fri, Jun 17, 4:58 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Parsoid

Wed, Jun 15

ssastry moved T310667: Parsoid emits nothing rather than 0 when using {{NUMBERINGROUP:}} on a user group with no members from To Verify to To Deploy on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
Wed, Jun 15, 7:28 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T310667: Parsoid emits nothing rather than 0 when using {{NUMBERINGROUP:}} on a user group with no members from Code Review to To Verify on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
Wed, Jun 15, 7:28 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T310667: Parsoid emits nothing rather than 0 when using {{NUMBERINGROUP:}} on a user group with no members from Backlog to Code Review on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
Wed, Jun 15, 11:51 AM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry triaged T310667: Parsoid emits nothing rather than 0 when using {{NUMBERINGROUP:}} on a user group with no members as Medium priority.
Wed, Jun 15, 11:51 AM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry claimed T310667: Parsoid emits nothing rather than 0 when using {{NUMBERINGROUP:}} on a user group with no members.

Interestingly enough, as part of work to run parser tests in Parsoid integrated mode, I was investigating related failures and this isolated bug made it easy for me to fix those. :)

Wed, Jun 15, 11:51 AM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid

Tue, Jun 14

ssastry moved T268144: Add setFunctionHook equivalent support to Parsoid Extension API from Backlog to Code Review on the Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid) board.
Tue, Jun 14, 11:07 PM · Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Patch-For-Review, Parsoid
ssastry edited projects for T268144: Add setFunctionHook equivalent support to Parsoid Extension API, added: Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid); removed Parsoid-Read-Views (Phase 1 - DiscussionTools support).
Tue, Jun 14, 11:06 PM · Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Patch-For-Review, Parsoid
ssastry edited projects for T310511: Metadata comparison testing between Parsoid and the legacy parser, added: Parsoid-Read-Views (Phase 4 - Parsoid generates metadata needed by core); removed Parsoid-Read-Views (Phase 1 - DiscussionTools support).
Tue, Jun 14, 11:06 PM · Parsoid-Read-Views (Phase 4 - Parsoid generates metadata needed by core), Parsoid
ssastry moved T115186: Fix bug in reparseTableAttributes which is broken in some scenarios from Backlog to Mostly edge cases on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
Tue, Jun 14, 11:05 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid-Rendering, Parsoid
ssastry moved T298665: TableFixups getting tripped up on pipe entities from Backlog to Mostly edge cases on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
Tue, Jun 14, 11:05 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T298665: TableFixups getting tripped up on pipe entities from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.
Tue, Jun 14, 11:03 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T115186: Fix bug in reparseTableAttributes which is broken in some scenarios from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.
Tue, Jun 14, 11:03 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid-Rendering, Parsoid
ssastry moved T180534: Failed template encapsulation from Uncategorized to Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid on the Parsoid-Read-Views board.
Tue, Jun 14, 11:00 PM · Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsoid-Rendering, Parsoid
ssastry triaged T310526: Parsoid read views doesn't support -{T|...}- page title markup as Medium priority.
Tue, Jun 14, 10:40 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Editing-team (Tracking), Parsing-Active-Work, DiscussionTools, Parsoid
ssastry triaged T300191: Bikeshed name of 'useParsoid' flag in ParserOptions as High priority.
Tue, Jun 14, 10:40 PM · Patch-For-Review, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Editing-team (Tracking), Parsing-Active-Work, DiscussionTools, Parsoid
ssastry triaged T300190: Ensure that if 'useParsoid' flag is present in ParserOptions that we use Parsoid to parse the page. as High priority.
Tue, Jun 14, 10:40 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Editing-team (Tracking), Parsing-Active-Work, DiscussionTools, Parsoid
ssastry triaged T300981: Ensure extensionData can always be combined asynchronously/out-of-order as Medium priority.
Tue, Jun 14, 10:39 PM · Parsoid-Read-Views, MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), Patch-For-Review, Parsoid, MediaWiki-Parser
ssastry triaged T300986: Ensure Page Properties can always be combined asynchronously/out-of-order as Medium priority.
Tue, Jun 14, 10:39 PM · Parsoid-Read-Views, MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), Patch-For-Review, Parsoid, MediaWiki-Parser
ssastry triaged T300979: Ensure ParserOutput can always be combined asynchronously/out-of-order as Medium priority.
Tue, Jun 14, 10:38 PM · Parsoid-Read-Views, Patch-For-Review, MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), Parsoid, MediaWiki-Parser
ssastry triaged T282499: Consider whether Parsoid will support forced linear parsing. as Low priority.
Tue, Jun 14, 10:30 PM · MediaWiki-extensions-ExternalData, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), MediaWiki-extensions-Variables, Parsoid, MediaWiki-Parser
ssastry triaged T310520: Parsoid content not compatible with `index.php?title=` URLs as Medium priority.
Tue, Jun 14, 10:29 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Editing-team (Tracking), Parsing-Active-Work, DiscussionTools, Parsoid
ssastry triaged T309024: Make Parsoid's red link output compatible with current output as Medium priority.
Tue, Jun 14, 9:28 PM · Patch-For-Review, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid
ssastry triaged T310544: Ensure MobileFrontend works with Parsoid read views for discussion tools as Medium priority.
Tue, Jun 14, 9:25 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Editing-team (Tracking), Parsing-Active-Work, DiscussionTools, Parsoid
ssastry triaged T310512: Parsoid and the legacy parser should emit exactly the same ParserOutput metadata as Medium priority.
Tue, Jun 14, 9:25 PM · Parsoid-Read-Views (Phase 4 - Parsoid generates metadata needed by core), Parsoid
ssastry triaged T310511: Metadata comparison testing between Parsoid and the legacy parser as Medium priority.
Tue, Jun 14, 9:25 PM · Parsoid-Read-Views (Phase 4 - Parsoid generates metadata needed by core), Parsoid
ssastry triaged T310510: Discussion tools visual diff testing between parsoid read views and legacy read views as High priority.
Tue, Jun 14, 9:24 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T310076: Remove deprecated captionLength property of $wgGalleryOptions from Needs Triage to Tech Debt / Big changes on the Parsoid board.
Tue, Jun 14, 9:24 PM · CX-cxserver, Parsoid, Technical-Debt
ssastry moved T308648: nowiki tags in comments on JavaScript pages are rendered incorrectly from Needs Triage to Bugs & Crashers on the Parsoid board.
Tue, Jun 14, 9:21 PM · Parsoid, Android-app-Bugs, Wikipedia-Android-App-Backlog
ssastry moved T307349: Accidental removal of some files under /srv/deployment on deploy1002 from Needs Triage to Tracking on the Parsoid board.
Tue, Jun 14, 9:21 PM · Parsoid (Tracking), Deployments, Release-Engineering-Team (Doing), bacula, SRE
ssastry edited projects for T301371: Preemptively warm caches for Parsoid output, added: Parsoid (Tracking); removed Parsoid.
Tue, Jun 14, 9:21 PM · Platform Team Workboards (MW Expedition), Parsoid (Tracking), Patch-For-Review, VisualEditor, serviceops, Performance-Team (Radar), Platform Engineering Roadmap
ssastry moved T301371: Preemptively warm caches for Parsoid output from Needs Triage to Performance on the Parsoid board.
Tue, Jun 14, 9:20 PM · Platform Team Workboards (MW Expedition), Parsoid (Tracking), Patch-For-Review, VisualEditor, serviceops, Performance-Team (Radar), Platform Engineering Roadmap
ssastry moved T307411: Space character after a template was removed in a reply tool edit from Needs Triage to Bugs & Crashers on the Parsoid board.
Tue, Jun 14, 9:20 PM · DiscussionTools, Parsoid
ssastry moved T308038: Wikitext whitespace information lost when switching from wikitext to VE on a new page from Needs Triage to Bugs & Crashers on the Parsoid board.
Tue, Jun 14, 9:20 PM · RESTBase, Parsoid, VisualEditor
ssastry moved T310467: Remove implementation of the transform endpoint from the parsoid extension from Needs Triage to Tech Debt / Big changes on the Parsoid board.
Tue, Jun 14, 9:19 PM · Patch-For-Review, Parsoid, Platform Team Workboards (MW Expedition)
ssastry moved T310510: Discussion tools visual diff testing between parsoid read views and legacy read views from Needs Triage to Testing on the Parsoid board.
Tue, Jun 14, 9:19 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T310511: Metadata comparison testing between Parsoid and the legacy parser from Needs Triage to Testing on the Parsoid board.
Tue, Jun 14, 9:18 PM · Parsoid-Read-Views (Phase 4 - Parsoid generates metadata needed by core), Parsoid
ssastry moved T310512: Parsoid and the legacy parser should emit exactly the same ParserOutput metadata from Needs Triage to Missing Functionality on the Parsoid board.
Tue, Jun 14, 9:18 PM · Parsoid-Read-Views (Phase 4 - Parsoid generates metadata needed by core), Parsoid
ssastry moved T310520: Parsoid content not compatible with `index.php?title=` URLs from Needs Triage to Missing Functionality on the Parsoid board.
Tue, Jun 14, 9:18 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Editing-team (Tracking), Parsing-Active-Work, DiscussionTools, Parsoid
ssastry moved T310526: Parsoid read views doesn't support -{T|...}- page title markup from Needs Triage to Missing Functionality on the Parsoid board.
Tue, Jun 14, 9:17 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Editing-team (Tracking), Parsing-Active-Work, DiscussionTools, Parsoid
ssastry moved T310544: Ensure MobileFrontend works with Parsoid read views for discussion tools from Needs Triage to Missing Functionality on the Parsoid board.
Tue, Jun 14, 9:17 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Editing-team (Tracking), Parsing-Active-Work, DiscussionTools, Parsoid
ssastry updated the task description for T310512: Parsoid and the legacy parser should emit exactly the same ParserOutput metadata.
Tue, Jun 14, 2:42 PM · Parsoid-Read-Views (Phase 4 - Parsoid generates metadata needed by core), Parsoid

Sat, Jun 11

ssastry added a comment to T310220: After encountering a wikilink-in-extlink, Parsoid incorrectly marks subsequent unrelated fragments (in its DOM subtree) misnested.

Yes, that took me a while to spot but ([https://www.delcampe.net/static/img_large/auction/001/179/750/079_001.jpg image) is missing a closing ] char which causes wikilinks later in the line to get swallowed into it which triggers this bug in a wikilink-in-extlink lint error scenario.

Sat, Jun 11, 10:45 PM · DiscussionTools, Parsoid

Fri, Jun 10

ssastry closed T310220: After encountering a wikilink-in-extlink, Parsoid incorrectly marks subsequent unrelated fragments (in its DOM subtree) misnested as Resolved.

Will likely be deployed on next week's train.

Fri, Jun 10, 9:23 PM · DiscussionTools, Parsoid
ssastry added a comment to T306112: Cloud VPS "wikitextexp" project Stretch deprecation.

So, it is okay to shut down these VMs by end-June. But, if our quota is expanded before end-June, I may look into booting these up again if I have spare time from other tasks.

Fri, Jun 10, 9:09 PM · Parsoid, Cloud-VPS (Debian Stretch Deprecation)
ssastry updated subscribers of T306112: Cloud VPS "wikitextexp" project Stretch deprecation.

Horizon says I don't have quota to launch new VMs.

Fri, Jun 10, 9:08 PM · Parsoid, Cloud-VPS (Debian Stretch Deprecation)
ssastry claimed T310220: After encountering a wikilink-in-extlink, Parsoid incorrectly marks subsequent unrelated fragments (in its DOM subtree) misnested.
Fri, Jun 10, 4:23 AM · DiscussionTools, Parsoid
ssastry moved T310220: After encountering a wikilink-in-extlink, Parsoid incorrectly marks subsequent unrelated fragments (in its DOM subtree) misnested from Needs Triage to Bugs & Crashers on the Parsoid board.
Fri, Jun 10, 4:23 AM · DiscussionTools, Parsoid
ssastry moved T310283: Performance: improve speed of SiteConfig creation from Needs Triage to Performance on the Parsoid board.
Fri, Jun 10, 4:23 AM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Parsoid

Thu, Jun 9

ssastry triaged T310283: Performance: improve speed of SiteConfig creation as Low priority.
Thu, Jun 9, 7:28 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Parsoid

Wed, Jun 8

ssastry renamed T310220: After encountering a wikilink-in-extlink, Parsoid incorrectly marks subsequent unrelated fragments (in its DOM subtree) misnested from Parsoid removed all markup in a fragment of a page in a reply tool edit to After encountering a wikilink-in-extlink, Parsoid incorrectly marks subsequent unrelated fragments (in its DOM subtree) misnested.
Wed, Jun 8, 8:09 PM · DiscussionTools, Parsoid
ssastry merged task T310219: Parsoid corruption in a reply tool edit into T310220: After encountering a wikilink-in-extlink, Parsoid incorrectly marks subsequent unrelated fragments (in its DOM subtree) misnested.
Wed, Jun 8, 8:08 PM · DiscussionTools, Parsoid
ssastry merged T310219: Parsoid corruption in a reply tool edit into T310220: After encountering a wikilink-in-extlink, Parsoid incorrectly marks subsequent unrelated fragments (in its DOM subtree) misnested.
Wed, Jun 8, 8:08 PM · DiscussionTools, Parsoid
ssastry added a comment to T310220: After encountering a wikilink-in-extlink, Parsoid incorrectly marks subsequent unrelated fragments (in its DOM subtree) misnested.

Can be easily reproduced with this snippet:

[subbu@earth:~/work/wmf/parsoid] cat /tmp/wt
* [http://google.com [[Foo]]]. bar ''baz''
Wed, Jun 8, 8:06 PM · DiscussionTools, Parsoid
ssastry triaged T310219: Parsoid corruption in a reply tool edit as High priority.

This looks like probably the same reason as in T310220#7990302

Wed, Jun 8, 7:49 PM · DiscussionTools, Parsoid
ssastry triaged T310220: After encountering a wikilink-in-extlink, Parsoid incorrectly marks subsequent unrelated fragments (in its DOM subtree) misnested as High priority.
Wed, Jun 8, 7:44 PM · DiscussionTools, Parsoid
ssastry added a comment to T310220: After encountering a wikilink-in-extlink, Parsoid incorrectly marks subsequent unrelated fragments (in its DOM subtree) misnested.

There is a wikilink nested inside an extlink. And, all subsequent markup in that DOM level are marked misnested which seems like possibly a buggy outcome of my fix for T307412: Link-in-link wikitext error resulted in duplicated content in a reply tool edit. Will take a look.

Wed, Jun 8, 7:44 PM · DiscussionTools, Parsoid
ssastry triaged T310221: Parsoid normalized links aggresively in a reply tool edit as Low priority.
Wed, Jun 8, 7:40 PM · DiscussionTools, Parsoid
ssastry added a comment to T310221: Parsoid normalized links aggresively in a reply tool edit.

At first glance, (a) these are normalizations in a dom that is considered modified. (b) It is marked modified because an old comment is now nested inside a newly inserted comment and so Parsoid probably treats the whole subtree as modified.

Wed, Jun 8, 7:40 PM · DiscussionTools, Parsoid

Tue, Jun 7

ssastry claimed T306112: Cloud VPS "wikitextexp" project Stretch deprecation.
Tue, Jun 7, 6:03 PM · Parsoid, Cloud-VPS (Debian Stretch Deprecation)
ssastry closed T303368: TemplateHandler crasher: Wikimedia\Assert\InvariantException: Invariant failed: Expecting : in parser function definiton as Resolved.
Tue, Jun 7, 6:02 PM · Parsoid, Wikimedia-production-error
ssastry added a comment to T306112: Cloud VPS "wikitextexp" project Stretch deprecation.

Will take care of it this week.

Tue, Jun 7, 5:58 PM · Parsoid, Cloud-VPS (Debian Stretch Deprecation)
ssastry closed T310025: Parsoid's Sanitizer overwrites attribute values for template generated attributes which breaks templated magic word properties as Resolved.
Tue, Jun 7, 5:57 PM · Parsoid-Read-Views, Parsoid

Mon, Jun 6

ssastry added a comment to T310025: Parsoid's Sanitizer overwrites attribute values for template generated attributes which breaks templated magic word properties.

Fair, but, there may be some tweaks to Sanitizer code nevertheless since we might end up changing the representation here. The general problem is that we don't have a good representation when more than the attribute is templated (or at least that is how our tokenizer / attribute expander sees it).

Mon, Jun 6, 10:30 PM · Parsoid-Read-Views, Parsoid
ssastry triaged T310025: Parsoid's Sanitizer overwrites attribute values for template generated attributes which breaks templated magic word properties as Medium priority.
Mon, Jun 6, 10:05 PM · Parsoid-Read-Views, Parsoid
ssastry created T310025: Parsoid's Sanitizer overwrites attribute values for template generated attributes which breaks templated magic word properties.
Mon, Jun 6, 10:05 PM · Parsoid-Read-Views, Parsoid
ssastry moved T300191: Bikeshed name of 'useParsoid' flag in ParserOptions from Backlog to In Progress on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
Mon, Jun 6, 3:10 PM · Patch-For-Review, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Editing-team (Tracking), Parsing-Active-Work, DiscussionTools, Parsoid

Sat, Jun 4

ssastry closed T270311: Parsoid's integrated test runner in core doesn't support modes other than wt2html as Resolved.
Sat, Jun 4, 11:33 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Patch-For-Review, Parsoid
ssastry reassigned T307720: Transition !!config sections in ParserTests to use JSON-compatible syntax from ssastry to cscott.
Sat, Jun 4, 11:33 PM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Patch-For-Review, Parsoid, MediaWiki-Parser
ssastry closed T307720: Transition !!config sections in ParserTests to use JSON-compatible syntax as Resolved.
Sat, Jun 4, 11:33 PM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Patch-For-Review, Parsoid, MediaWiki-Parser
ssastry added a comment to T309901: TypeError: trim() expects parameter 1 to be string, null given.

https://cy.wikipedia.org/w/index.php?title=Nodyn%3APigion%2FWythnos_34&type=revision&diff=11055970&oldid=2243475 is another one I fixed.

Sat, Jun 4, 3:10 AM · Parsoid, Wikimedia-production-error

Fri, Jun 3

ssastry created T309901: TypeError: trim() expects parameter 1 to be string, null given.
Fri, Jun 3, 9:10 PM · Parsoid, Wikimedia-production-error

Thu, Jun 2

ssastry added a comment to T309765: Retire the old Parsoid deb repository?.

I think so. Parsoid/JS is no longer supported and won't get security releases either. If anyone on the team has any concerns, they will leave their comments here.

Thu, Jun 2, 1:22 PM · Infrastructure-Foundations, SRE, Parsoid

Jun 2 2022

ssastry updated subscribers of T302509: Parsoid strips syntax-critical newlines from template parameters with inline formatting.

Whitespace handling in wikitext is generally very messy. @Arlolra and @cscott both wondering why we trim argument values at all in any context So, I'm going to dump a WIP patch for now exploring that.

Jun 2 2022, 4:17 AM · Patch-For-Review, Editing-team, Parsoid, WMDE-TechWish-Sprint-2022-03-02
ssastry moved T308367: Integrate ParserTestTopLevelSuite $flags with $parserTestFlags from Needs Triage to Tracking on the Parsoid board.
Jun 2 2022, 2:46 AM · Parsoid (Tracking), MediaWiki-Parser
ssastry moved T309024: Make Parsoid's red link output compatible with current output from Needs Triage to Missing Functionality on the Parsoid board.
Jun 2 2022, 2:46 AM · Patch-For-Review, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid
ssastry moved T309305: Ensure Parsoid HTML served for read views doesn't degrade performance in low-resource contexts from Needs Triage to Performance on the Parsoid board.
Jun 2 2022, 2:46 AM · Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Platform Engineering, Performance-Team (Radar), Parsoid, Parsoid-Rendering
ssastry triaged T309305: Ensure Parsoid HTML served for read views doesn't degrade performance in low-resource contexts as Medium priority.
Jun 2 2022, 2:45 AM · Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Platform Engineering, Performance-Team (Radar), Parsoid, Parsoid-Rendering

Jun 1 2022

ssastry added a comment to T303368: TemplateHandler crasher: Wikimedia\Assert\InvariantException: Invariant failed: Expecting : in parser function definiton.

Crasher can easily be duplicated via echo "{{DEFAULTSORTKEY:{{1x|foo}}}}" | php bin/parse.php

Jun 1 2022, 7:53 PM · Parsoid, Wikimedia-production-error
ssastry triaged T302509: Parsoid strips syntax-critical newlines from template parameters with inline formatting as Medium priority.
Jun 1 2022, 2:22 PM · Patch-For-Review, Editing-team, Parsoid, WMDE-TechWish-Sprint-2022-03-02
ssastry added a comment to T302509: Parsoid strips syntax-critical newlines from template parameters with inline formatting.

I was about to type this --> I am not sure what we can do here realisticallly. If a template is marked as inline-formatted, the newlines will be stripped. Without more fine-grained types about parameters (a type that says: "this parameter is a wikitext construct that needs a leading newline"), it is hard to do much there.

Jun 1 2022, 2:22 PM · Patch-For-Review, Editing-team, Parsoid, WMDE-TechWish-Sprint-2022-03-02
ssastry added a comment to T309681: Incorrect handling of TemplateStyles in Editnotices.

We use the VisualEditor API to get the text of the edit notices, and I believe VisualEditor in turn uses Parsoid to parse the notices (and TemplateStyles isn't compatible with Parsoid yet, if I understand correctly). Therefore tagging Parsoid.

Here is an API call to visualeditor that will produce the same results (under the permissions-error notice):
https://en.wikipedia.org/w/api.php?format=json&formatversion=2&errorformat=html&action=visualeditor&paction=metadata&page=Barack_Obama

Jun 1 2022, 1:57 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)
ssastry added a comment to T309681: Incorrect handling of TemplateStyles in Editnotices.

TemplateStyles is compatible with Parsoid. This may be an edge case / bug. We will have to take a look.

Jun 1 2022, 1:38 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)

May 27 2022

ssastry committed rIVDI99f5645054f4: Fix arwiki Cite CSS (authored by ssastry).
Fix arwiki Cite CSS
May 27 2022, 10:14 PM
ssastry committed rIVDIa7f2388f2b79: Look for mw:moduleStyles meta tag in Parsoid output as well (authored by ssastry).
Look for mw:moduleStyles meta tag in Parsoid output as well
May 27 2022, 10:14 PM
ssastry added a comment to T309404: PHP Warning: Illegal offset type (from Parsoid StubMetadataCollector).

/w/rest.php/en.wikipedia.org/v3/transform/wikitext/to/lint/Talk%3ASiln%C3%A1n/1090134717 is the other page.

May 27 2022, 4:40 PM · Parsoid, Wikimedia-production-error
ssastry triaged T309405: PHP Notice: Undefined offset: 0 as Medium priority.
May 27 2022, 4:38 PM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Parsoid, Wikimedia-production-error

May 26 2022

ssastry updated the task description for T309064: Analyze rt-testing data and identify pages whose Parsoid HTML sizes are "outside limits".
May 26 2022, 12:51 PM · Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Performance-Team (Radar), Parsoid-Rendering, Parsoid
ssastry updated subscribers of T309305: Ensure Parsoid HTML served for read views doesn't degrade performance in low-resource contexts.
May 26 2022, 12:38 PM · Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Platform Engineering, Performance-Team (Radar), Parsoid, Parsoid-Rendering
ssastry edited parent tasks for T272331: Evaluate and recommend strategies for ensuring Parsoid HTML payload doesn't degrade performance in low-resource contexts., added: T309305: Ensure Parsoid HTML served for read views doesn't degrade performance in low-resource contexts; removed: T258836: [EPIC] Ensure Parsoid meets performance criteria for serving read views on the Parsoid cluster.
May 26 2022, 12:37 PM · Patch-For-Review, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Performance-Team (Radar), Parsoid-Rendering, Parsoid