Page MenuHomePhabricator

ssastry (Subbu)
User

Projects (20)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 5:34 AM (493 w, 2 h)
Availability
Available
IRC Nick
subbu
LDAP User
Subramanya Sastry
MediaWiki User
SSastry (WMF) [ Global Accounts ]

Recent Activity

Thu, Mar 14

ssastry added a comment to T359881: h1 headings render different in Vector skin with Parsoid HTML.

This diff also showed up on enwikivoyage pages.

Thu, Mar 14, 4:41 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), Web Team Essential Work 2024, Content-Transform-Team-WIP, Vector (legacy skin), Desktop Improvements (Vector 2022), Parsoid-Read-Views
ssastry moved T359450: Parsoid is not adding headings to TOC entries in some templated content scenarios from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Thu, Mar 14, 3:25 PM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T358401: Parsoid assigns wrong anchor in TOCData when there are duplicate IDs from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Thu, Mar 14, 3:14 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry merged T359896: Parsoid EditSectionLink pass adding edit section links in the middle of lists in some cases into T358401: Parsoid assigns wrong anchor in TOCData when there are duplicate IDs.
Thu, Mar 14, 3:14 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry merged task T359896: Parsoid EditSectionLink pass adding edit section links in the middle of lists in some cases into T358401: Parsoid assigns wrong anchor in TOCData when there are duplicate IDs.
Thu, Mar 14, 3:14 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry moved T355099: Difference in paragraph wrapping after transclusion end from Backlog to Current Deploy Target on the Content-Transform-Team-WIP board.
Thu, Mar 14, 3:13 PM · Parsoid-Read-Views, Content-Transform-Team-WIP, Parsoid
ssastry added a comment to T359896: Parsoid EditSectionLink pass adding edit section links in the middle of lists in some cases.

Indeed! The pages linked in the description look fixed now!

Thu, Mar 14, 12:30 AM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid

Wed, Mar 13

ssastry added a project to T359882: Parsoid renders multiple TOCs if there are multiple __TOC__ magic words present: Content-Transform-Team-WIP.
Wed, Mar 13, 4:21 PM · Content-Transform-Team-WIP, Parsoid, Parsoid-Read-Views
ssastry edited projects for T359881: h1 headings render different in Vector skin with Parsoid HTML, added: Content-Transform-Team-WIP; removed Parsoid.
Wed, Mar 13, 4:21 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), Web Team Essential Work 2024, Content-Transform-Team-WIP, Vector (legacy skin), Desktop Improvements (Vector 2022), Parsoid-Read-Views
ssastry moved T359881: h1 headings render different in Vector skin with Parsoid HTML from Backlog to Current Deploy Target on the Content-Transform-Team-WIP board.
Wed, Mar 13, 4:21 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), Web Team Essential Work 2024, Content-Transform-Team-WIP, Vector (legacy skin), Desktop Improvements (Vector 2022), Parsoid-Read-Views

Tue, Mar 12

ssastry moved T359483: Parsoid output is sometimes missing geolocation indicators from Backlog to Current Deploy Target on the Content-Transform-Team-WIP board.
Tue, Mar 12, 2:48 PM · Content-Transform-Team-WIP, Parsoid, Parsoid-Read-Views
ssastry added a project to T359483: Parsoid output is sometimes missing geolocation indicators: Content-Transform-Team-WIP.
Tue, Mar 12, 2:48 PM · Content-Transform-Team-WIP, Parsoid, Parsoid-Read-Views
ssastry triaged T359896: Parsoid EditSectionLink pass adding edit section links in the middle of lists in some cases as High priority.

This seems to affect a lot of pages on enwikivoyage.

Tue, Mar 12, 2:09 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry moved T359886: Undefined whitespace handling behavior around category links from Backlog to Code Review on the Content-Transform-Team-WIP board.
Tue, Mar 12, 2:01 PM · Content-Transform-Team-WIP, Patch-For-Review, Parsoid-Read-Views, Parsoid
ssastry added a project to T359886: Undefined whitespace handling behavior around category links: Content-Transform-Team-WIP.
Tue, Mar 12, 2:01 PM · Content-Transform-Team-WIP, Patch-For-Review, Parsoid-Read-Views, Parsoid
ssastry moved T359897: Parsoid HTML: Possible CSS issue - vertical list rendered as a collapsed hlist on this enwikkivoyage page from Backlog to Current Deploy Target on the Content-Transform-Team-WIP board.
Tue, Mar 12, 1:59 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry added a project to T359897: Parsoid HTML: Possible CSS issue - vertical list rendered as a collapsed hlist on this enwikkivoyage page: Content-Transform-Team-WIP.
Tue, Mar 12, 1:58 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry moved T359896: Parsoid EditSectionLink pass adding edit section links in the middle of lists in some cases from Backlog to Current Deploy Target on the Content-Transform-Team-WIP board.
Tue, Mar 12, 1:57 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry renamed T359896: Parsoid EditSectionLink pass adding edit section links in the middle of lists in some cases from Parsoid EditSectionLink pass adding edit section links in the middle of lists in some casee to Parsoid EditSectionLink pass adding edit section links in the middle of lists in some cases.
Tue, Mar 12, 3:44 AM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry created T359897: Parsoid HTML: Possible CSS issue - vertical list rendered as a collapsed hlist on this enwikkivoyage page.
Tue, Mar 12, 3:43 AM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry created T359896: Parsoid EditSectionLink pass adding edit section links in the middle of lists in some cases.
Tue, Mar 12, 3:39 AM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid

Mon, Mar 11

ssastry created T359886: Undefined whitespace handling behavior around category links.
Mon, Mar 11, 9:14 PM · Content-Transform-Team-WIP, Patch-For-Review, Parsoid-Read-Views, Parsoid
ssastry created T359882: Parsoid renders multiple TOCs if there are multiple __TOC__ magic words present.
Mon, Mar 11, 8:38 PM · Content-Transform-Team-WIP, Parsoid, Parsoid-Read-Views
ssastry created T359881: h1 headings render different in Vector skin with Parsoid HTML.
Mon, Mar 11, 8:37 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), Web Team Essential Work 2024, Content-Transform-Team-WIP, Vector (legacy skin), Desktop Improvements (Vector 2022), Parsoid-Read-Views
ssastry closed T353079: On wikitech, DiscussionTools doesn't render reply links with "?useparsoid=1" when logged out, a subtask of T355374: Use Parsoid for DiscussionTools on wikitech, as Resolved.
Mon, Mar 11, 3:15 PM · wikitech.wikimedia.org, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, DiscussionTools
ssastry closed T353079: On wikitech, DiscussionTools doesn't render reply links with "?useparsoid=1" when logged out as Resolved.
Mon, Mar 11, 3:15 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), DiscussionTools

Fri, Mar 8

ssastry claimed T358958: TableFixups: reparse failures.
Fri, Mar 8, 9:58 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid, Wikimedia-production-error
ssastry added a comment to T358958: TableFixups: reparse failures.

The plwiki URL is a template page and is a mess that Parsoid doesn't know how to render properly ... I consider that an edge case. The use of the template itself on article pages seems to render fine. So, for now, ignoring that page.

Fri, Mar 8, 9:57 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid, Wikimedia-production-error
ssastry added a project to T358958: TableFixups: reparse failures: Content-Transform-Team-WIP.
Fri, Mar 8, 9:51 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid, Wikimedia-production-error
ssastry edited projects for T358973: VisualEditor renders empty table rows (rows with no cells), added: Parsoid (Tracking); removed Parsoid.

I don't see anything to be done here in parsoid, so adding the tracking tag instead.

Fri, Mar 8, 9:47 PM · Parsoid (Tracking), VisualEditor, VisualEditor-Tables
ssastry moved T358242: Reference previews don't work on some pages when using parsoid read views from Needs Triage to Bugs & Crashers on the Parsoid board.
Fri, Mar 8, 9:46 PM · Content-Transform-Team-WIP, Parsoid, Parsoid-Read-Views
ssastry removed a project from T358296: [UX] No obvious way to close notice dialog telling me that I'm using the Parsoid view experimental feature: Parsoid.
Fri, Mar 8, 9:46 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MediaWiki-User-Interface (mw.notifications), Parsoid-Read-Views
ssastry moved T358401: Parsoid assigns wrong anchor in TOCData when there are duplicate IDs from Needs Triage to Bugs & Crashers on the Parsoid board.
Fri, Mar 8, 9:46 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry removed a project from T358452: Vector 2022 dynamic table of contents broken on Parsoid: Parsoid.
Fri, Mar 8, 9:46 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), Web Team Essential Work 2024, Desktop Improvements (Vector 2022), Parsoid-Read-Views
ssastry edited projects for T358980: Images displayed twice in mobile view on main page with Parsoid read views enabled, added: Parsoid (Tracking); removed Parsoid.
Fri, Mar 8, 9:42 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), Patch-For-Review, Web Team Essential Work 2024, Parsoid (Tracking), MobileFrontend, Parsoid-Read-Views
ssastry edited projects for T358981: Talk page discussion parsing is broken on mobile views with Parsoid read views enabled, added: Parsoid (Tracking); removed Parsoid.
Fri, Mar 8, 9:42 PM · Parsoid (Tracking), DiscussionTools, MobileFrontend, Parsoid-Read-Views
ssastry edited projects for T359001: Section collapsing doesnt work on mobile, added: Parsoid (Tracking); removed Parsoid.
Fri, Mar 8, 9:41 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), Web Team Essential Work 2024, Parsoid (Tracking), Parsoid-Read-Views
ssastry edited projects for T359002: Lead paragraph is not hoisted in new Parsoid HTML, added: Parsoid (Tracking); removed Parsoid.
Fri, Mar 8, 9:41 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), Web Team Essential Work 2024, Parsoid (Tracking), Parsoid-Read-Views
ssastry edited projects for T359005: Page issues not clickable in mobile view (new parser), added: Parsoid (Tracking); removed Parsoid.
Fri, Mar 8, 9:41 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), Parsoid (Tracking), MobileFrontend, MinervaNeue, Parsoid-Read-Views
ssastry removed a project from T359079: Allow independent default for mobile web views in ParserMigration extension: Parsoid.
Fri, Mar 8, 9:41 PM · Web-Team-Backlog (Needs Prioritization (Tech)), Parsoid-Read-Views, MediaWiki-extensions-ParserMigration, MobileFrontend
ssastry moved T359221: Parsoid's TOC handling needs to deal with HTML-returning components (exts, SPTs, parser funcs returning HTML) consistently from Needs Triage to Bugs & Crashers on the Parsoid board.
Fri, Mar 8, 9:40 PM · Parsoid, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid)
ssastry edited projects for T359387: Cleanup parsoid-php service, added: Parsoid (Tracking); removed Parsoid.
Fri, Mar 8, 9:40 PM · Parsoid (Tracking), Patch-For-Review, serviceops
ssastry moved T359450: Parsoid is not adding headings to TOC entries in some templated content scenarios from Needs Triage to Bugs & Crashers on the Parsoid board.
Fri, Mar 8, 9:40 PM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry moved T359483: Parsoid output is sometimes missing geolocation indicators from Needs Triage to Bugs & Crashers on the Parsoid board.
Fri, Mar 8, 9:40 PM · Content-Transform-Team-WIP, Parsoid, Parsoid-Read-Views
ssastry removed a project from T359509: REST API calls suddenly all returning 400: Parsoid.
Fri, Mar 8, 9:40 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-Interfaces-Team, Content-Transform-Team-WIP, Patch-For-Review, RESTBase-API
ssastry moved T359450: Parsoid is not adding headings to TOC entries in some templated content scenarios from Backlog to Code Review on the Content-Transform-Team-WIP board.
Fri, Mar 8, 9:08 PM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid

Thu, Mar 7

ssastry added a comment to T359450: Parsoid is not adding headings to TOC entries in some templated content scenarios.

We may not need to block on any of the tasks above actually. It is sufficient to simply check (while processing a heading) if it is nested inside an extension (which is a cheap and robust check and doesn't depends on having explicit nested boundaries).

Thu, Mar 7, 11:49 PM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid

Wed, Mar 6

ssastry added a comment to T214241: data-mw info is clobbered by template annotations.

We are starting to run up against this problem again in multiple instances while trying to tackle Parsoid read view compatibility bugs. So, it is time to pick this up and implement a reasonable b/c solution that only introduces a minor HTML spec version bump.

Wed, Mar 6, 9:08 PM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Rendering, Parsoid
ssastry added a comment to T359483: Parsoid output is sometimes missing geolocation indicators.

@ihurbain identified this as yet another instance of T214241: data-mw info is clobbered by template annotations

Wed, Mar 6, 9:07 PM · Content-Transform-Team-WIP, Parsoid, Parsoid-Read-Views
ssastry created T359483: Parsoid output is sometimes missing geolocation indicators.
Wed, Mar 6, 9:06 PM · Content-Transform-Team-WIP, Parsoid, Parsoid-Read-Views
ssastry raised the priority of T214241: data-mw info is clobbered by template annotations from Medium to High.
Wed, Mar 6, 9:02 PM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Rendering, Parsoid
ssastry added a comment to T359450: Parsoid is not adding headings to TOC entries in some templated content scenarios.

But, there are other ideas in T295171: Use data-mw.rangeId="t:...." instead of "about" for template ranges and T214241: data-mw info is clobbered by template annotations that we could explore.

Wed, Mar 6, 9:01 PM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry added a comment to T359450: Parsoid is not adding headings to TOC entries in some templated content scenarios.

This is actually a near-neighbor of T214241: data-mw info is clobbered by template annotations. The section-wrapping / TOC code isn't able to demarcate the boundary of an extension because the extension output happens to be the first element of a template and so the extension-content boundary is not demarcated. And, so the section wrapping code treats the entire template wrapped DOM forest to be extension content and suppresses headings from it (as required by T355092: Parsoid / legacy parser disagree whether to include extension content in TOC).

Wed, Mar 6, 8:50 PM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry renamed T359450: Parsoid is not adding headings to TOC entries in some templated content scenarios from Parsoid is not adding headings to TOC entries in some templated content scenarios. to Parsoid is not adding headings to TOC entries in some templated content scenarios.
Wed, Mar 6, 8:39 PM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry claimed T359450: Parsoid is not adding headings to TOC entries in some templated content scenarios.
Wed, Mar 6, 8:39 PM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry renamed T359450: Parsoid is not adding headings to TOC entries in some templated content scenarios from Parsoid should emit TOC entries for non-editable sections from templates to Parsoid is not adding headings to TOC entries in some templated content scenarios..
Wed, Mar 6, 8:29 PM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry created T359450: Parsoid is not adding headings to TOC entries in some templated content scenarios.
Wed, Mar 6, 8:20 PM · Patch-For-Review, Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry lowered the priority of T249745: Could not enqueue jobs: "Unable to deliver all events: 503: Service Unavailable" from Unbreak Now! to High.
Wed, Mar 6, 8:14 PM · MediaWiki-Engineering, Data-Engineering, Unstewarded-production-error, User-brennen, serviceops, WMF-JobQueue, Wikimedia-production-error
ssastry added a comment to T249745: Could not enqueue jobs: "Unable to deliver all events: 503: Service Unavailable".

Given the six 9's reliability that Joe cited above ( T249745#958681 ) and Aaron's logstash dive over last 15 days and analysis ( T249745#9592919 ), it seems that we could probably close this task as not additionally actionable.

Wed, Mar 6, 8:14 PM · MediaWiki-Engineering, Data-Engineering, Unstewarded-production-error, User-brennen, serviceops, WMF-JobQueue, Wikimedia-production-error
ssastry added a comment to T214538: MediaWiki shouldn't assign section ids during tokenization, but instead only when headings are generated.

Given that Tim abandoned his attempt and given this is an edge case (see discussion on gerrit patch), I am inclined to decline this since we aren't going to go tweak this now -- we just need to make sure Parsoid's ids match the existing ids for b/c reasons.

Wed, Mar 6, 6:03 PM · Parsoid (Tracking), MediaWiki-Parser
ssastry added a parent task for T359221: Parsoid's TOC handling needs to deal with HTML-returning components (exts, SPTs, parser funcs returning HTML) consistently: T331483: Resolve diferences between Parsoid & legacy parser TOC metadata output for template, extension, and parser-function generated content.
Wed, Mar 6, 5:49 PM · Parsoid, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid)
ssastry added a subtask for T331483: Resolve diferences between Parsoid & legacy parser TOC metadata output for template, extension, and parser-function generated content: T359221: Parsoid's TOC handling needs to deal with HTML-returning components (exts, SPTs, parser funcs returning HTML) consistently.
Wed, Mar 6, 5:49 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid

Tue, Mar 5

ssastry closed T355092: Parsoid / legacy parser disagree whether to include extension content in TOC as Resolved.

Investigating T355704, I noticed that the same as reported in this task is true for special page transclusions and presumably all parser functions returning html.

For example,
https://www.mediawiki.org/w/index.php?title=User:Arlolra/sandbox&oldid=6330524&useskin=Vector&useparsoid=0
vs
https://www.mediawiki.org/w/index.php?title=User:Arlolra/sandbox&oldid=6330524&useskin=Vector&useparsoid=1

Tue, Mar 5, 10:05 PM · Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Content-Transform-Team-WIP, Parsoid
ssastry created T359221: Parsoid's TOC handling needs to deal with HTML-returning components (exts, SPTs, parser funcs returning HTML) consistently.
Tue, Mar 5, 10:03 PM · Parsoid, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid)
ssastry closed T353821: mw-empty-elt class isn't always added to empty p-tags in Parsoid as Resolved.
Tue, Mar 5, 9:59 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsoid
ssastry moved T357812: `DOMCompat::querySelector( $fragment, 'mw\\:editsection' )` throws "InvalidArgumentException: Unknown Selector: :editsection" from Code Review to To Verify on the Content-Transform-Team-WIP board.
Tue, Mar 5, 9:58 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, Essential-Work, Content-Transform-Team-WIP, Parsoid
ssastry moved T358054: Move Parsoid's Poem implementation to the Poem repository from Code Review to To Verify on the Content-Transform-Team-WIP board.
Tue, Mar 5, 9:58 PM · Essential-Work, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Patch-For-Review, Content-Transform-Team-WIP, MediaWiki-extensions-Poem, Parsoid
ssastry moved T357993: Make dismissing parsoid user notice more discoverable from Code Review to To Verify on the Content-Transform-Team-WIP board.
Tue, Mar 5, 9:58 PM · Parsoid, Content-Transform-Team-WIP, Parsoid-Read-Views
ssastry moved T357838: ParserTests's use of dynamic Parser::$static_tag_buf should be rewritten/removed from Code Review to To Verify on the Content-Transform-Team-WIP board.
Tue, Mar 5, 9:58 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Content-Transform-Team-WIP, Parsoid, MediaWiki-Parser, Parsoid-Read-Views

Mon, Mar 4

ssastry added a comment to T359000: Notification misplaced and color contrast issues on mobile.

@ssastry this one does not relate to T269499. The notification puts a Codex message box instead a notification. I've not seen this done before and am not sure the two should be conflated in that way as they exist now. T354967 does talk about issues with the existing notification and pushing in that direction though.

Mon, Mar 4, 5:58 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Parsoid, Parsoid-Read-Views

Sun, Mar 3

ssastry added a comment to T358981: Talk page discussion parsing is broken on mobile views with Parsoid read views enabled.

There is also T310544: Ensure MobileFrontend works with Parsoid read views for discussion tools in case there is any work to be done that is specific to DiscussionTools beyond what is done in T269499.

Sun, Mar 3, 7:42 PM · Parsoid (Tracking), DiscussionTools, MobileFrontend, Parsoid-Read-Views
ssastry added a comment to T358981: Talk page discussion parsing is broken on mobile views with Parsoid read views enabled.

Yes, this is all blocked on T269499: [Epic] Make MobileFrontend compatible with Parsoid HTML -- I think focus should be on that task and this should either be closed as dupes of those (or made subtasks of that). Something the Web Team can figure out based on their triaging.

Sun, Mar 3, 7:41 PM · Parsoid (Tracking), DiscussionTools, MobileFrontend, Parsoid-Read-Views
ssastry added a comment to T358980: Images displayed twice in mobile view on main page with Parsoid read views enabled.

This and all the other mobile web tasks filed by you and Jon are all blocked on T269499: [Epic] Make MobileFrontend compatible with Parsoid HTML.

Sun, Mar 3, 7:24 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), Patch-For-Review, Web Team Essential Work 2024, Parsoid (Tracking), MobileFrontend, Parsoid-Read-Views

Sat, Mar 2

ssastry added a comment to T346197: Wikimedia\Assert\InvariantException: Invariant failed: Bad UTF-8 at end of string (3 byte sequence).

URL triggering the "2 byte sequence" in the last 2 weeks:

  • /w/rest.php/ks.wikipedia.org/v3/page/pagebundle/%D8%B1%D9%8F%DA%A9%D9%8F%D9%86%3A511KeV/85479
Sat, Mar 2, 6:54 PM · Essential-Work, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ssastry created T358958: TableFixups: reparse failures.
Sat, Mar 2, 6:49 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid, Wikimedia-production-error
ssastry added a comment to T346197: Wikimedia\Assert\InvariantException: Invariant failed: Bad UTF-8 at end of string (3 byte sequence).

Couple urls triggering this in the last 2 weeks

  • /w/rest.php/en.wikipedia.org/v3/page/pagebundle/Shringara-manjari-katha/1184261178
  • /w/rest.php/en.wikipedia.org/v3/page/pagebundle/Ajayapala_(Chaulukya_dynasty)/1197445390
Sat, Mar 2, 6:44 PM · Essential-Work, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ssastry added a comment to T357689: UnexpectedValueException: Got revision ID 0 indicating unsaved content. Unsaved content must be provided as a RevisionRecord object..

There are a number of requests where the request URL uses a revid zero:

  • /w/rest.php/en.wikipedia.org/v3/page/pagebundle/Cyborgs_(film)/0
  • /w/rest.php/en.wikipedia.org/v3/page/pagebundle/Monica_Bellucci/0
  • /w/rest.php/en.wikipedia.org/v3/page/pagebundle/11/0
Sat, Mar 2, 6:41 PM · User-brennen, Parsoid, Wikimedia-production-error
ssastry added a project to T358950: Local interlanguage links don’t work with Parsoid read views: Content-Transform-Team.

Similar to T351931, this may just be another case where Parsoid isn't adding these links to metadata?

Sat, Mar 2, 3:15 PM · Content-Transform-Team-WIP, Wikimedia-Interwiki-links, Parsoid, Parsoid-Read-Views
ssastry added a comment to T358955: Interesting code coverage in composer-coverage-patch-docker.

The bulk of Parsoid library's testing isn't through the unit tests in tests/phpunit but through parser test runs in tests/parser/* .... if we can find a way to hook those test runs to the coverage tool, we might get better numbers. There is ongoing work to make parser test runs more phpunit friendly, so maybe that will do the trick? In Parsoid/JS land,

Sat, Mar 2, 3:10 PM · Test-Coverage, Parsoid

Fri, Mar 1

ssastry added a member for Trusted-Contributors: FBellamy-WMF.
Fri, Mar 1, 5:32 PM
ssastry created T358874: Parsoid EditSectionLink edge case on ruwiki.
Fri, Mar 1, 3:51 PM · Content-Transform-Team, Parsoid, Parsoid-Read-Views

Thu, Feb 29

ssastry added projects to T301648: Allow filtering of WhatLinksHere to remove links from templates: Wikimedia Wishathon, Content-Transform-Team.
Thu, Feb 29, 10:40 PM · Content-Transform-Team-WIP, Wikimedia Wishathon, Parsoid, Community-Wishlist-Survey-2022, MediaWiki-Special-pages

Tue, Feb 27

ssastry added a comment to T358588: A lot of `[info] Wikitext for this page has duplicate ids:` in logstash for mw-parsoid. Possibly related to PageBundle.

It doesn't show up in production because the logging level is set to warn or higher there. Separately, we should probably suppress non-actionable logspam like this (there are a few of those in Parsoid).

Tue, Feb 27, 2:34 PM · Content-Transform-Team-WIP, Patch-For-Review, Release-Engineering-Team (Seen), SRE, Traffic, serviceops, MW-on-K8s

Sun, Feb 25

ssastry updated the task description for T358457: Special Page Transclusion doesn't work on this page.
Sun, Feb 25, 11:07 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry created T358457: Special Page Transclusion doesn't work on this page.
Sun, Feb 25, 11:06 PM · Content-Transform-Team-WIP, Parsoid-Read-Views, Parsoid
ssastry added a comment to T358445: "[info/dsr/inconsistent] DSR inconsistency: cs/s mismatch for node: pre s:0 ; cs:49" printed in PHPUnit tests.

Yes, this is known. We cannot eliminate all of them -- since some of them are harmless / informational / false positives. We could maybe suppress them going forward. We'll chat about that.

Sun, Feb 25, 4:06 PM · MediaWiki-Core-Tests, Parsoid
ssastry committed rIVDIaf32bf04e786: Fix hiding of 'rendered by parsoid' indicator (authored by ssastry).
Fix hiding of 'rendered by parsoid' indicator
Sun, Feb 25, 4:03 AM

Sat, Feb 24

ssastry renamed T348722: PTag (phab page indicator) template broken with Parsoid (mediawiki, metawiki) from PTag (phab page indicator) template on mediawikiwiki broken with Parsoid to PTag (phab page indicator) template broken with Parsoid (mediawiki, metawiki).
Sat, Feb 24, 3:22 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry renamed T358242: Reference previews don't work on some pages when using parsoid read views from Reference previews don't work when using parsoid read views to Reference previews don't work on some pages when using parsoid read views.
Sat, Feb 24, 3:21 PM · Content-Transform-Team-WIP, Parsoid, Parsoid-Read-Views

Fri, Feb 23

ssastry committed rIVDI617b34d2e898: Stop suppressing edit section links + hide cdx-info-chip divs (authored by ssastry).
Stop suppressing edit section links + hide cdx-info-chip divs
Fri, Feb 23, 4:26 PM

Thu, Feb 22

ssastry created T358300: Difference in edit section links on enwikivoyage.
Thu, Feb 22, 11:51 PM · Parsoid, Content-Transform-Team-WIP, Parsoid-Read-Views
ssastry added a comment to T358144: Lots of 500 errors on mobileapps k8s.

Not to say there isn't anything to investigate here, but if I zoom out that logstash board to 1 month, the errors seem to be fluctuating up and down within that window. But yes within a smaller time window, you see more dramatic fluctuations.

Thu, Feb 22, 4:28 PM · Content-Transform-Team-WIP, Essential-Work, Mobile-Content-Service, Mobile, Wikimedia-production-error

Tue, Feb 20

ssastry merged T358039: Template on Meta-Wiki is displayed in raw form into T348722: PTag (phab page indicator) template broken with Parsoid (mediawiki, metawiki).
Tue, Feb 20, 6:52 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ssastry merged task T358039: Template on Meta-Wiki is displayed in raw form into T348722: PTag (phab page indicator) template broken with Parsoid (mediawiki, metawiki).
Tue, Feb 20, 6:52 PM · Parsoid-Read-Views, Parsoid

Feb 16 2024

ssastry committed rIVDI9a36f9071c12: Suppress notifications to eliminate spurious diffs (authored by ssastry).
Suppress notifications to eliminate spurious diffs
Feb 16 2024, 11:37 PM
ssastry committed rIVDId8ce0ecc41c1: Remove some of the span wrapper adaptations (authored by ssastry).
Remove some of the span wrapper adaptations
Feb 16 2024, 10:56 PM
ssastry committed rIVDI59db282f602d: Remove adaptation for self-links since Parsoid supports them now (authored by ssastry).
Remove adaptation for self-links since Parsoid supports them now
Feb 16 2024, 10:56 PM

Feb 15 2024

ssastry moved T353821: mw-empty-elt class isn't always added to empty p-tags in Parsoid from Backlog to Code Review on the Content-Transform-Team-WIP board.
Feb 15 2024, 3:04 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsoid
ssastry claimed T353821: mw-empty-elt class isn't always added to empty p-tags in Parsoid.
Feb 15 2024, 3:40 AM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsoid
ssastry added a comment to T353821: mw-empty-elt class isn't always added to empty p-tags in Parsoid.

The analysis in the description is not entirely right. Turns out that the handle empty elements pass was not setting mw-empty-elt class for template output wrappers!

Feb 15 2024, 3:39 AM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsoid