stjn (Saint Johann)
Technical admin in Russian Wikipedia

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 2:35 PM (210 w, 6 d)
Availability
Available
IRC Nick
stjn
LDAP User
Unknown
MediaWiki User
Saint Johann [ Global Accounts ]

Recent Activity

Today

stjn added a comment to T107119: Provide a Lua method mw.loadTemplateData().

I made a patch that adds a method to get TemplateData in Lua. The method is currently named mw.ext.TemplateData.loadTemplateData(), which is long, but according to the conventions available, the prefix for the extension should be mw.ext.TemplateData. Alternatively, it's possible to change the name of the method itself (e.g. to load()). Or, perhaps, someone can indicate the reasons for which the prefix can be removed.

Mon, Oct 22, 2:37 PM · Patch-For-Review, Wikimedia-Israel-Hackers, VisualEditor-MediaWiki, VisualEditor, TemplateData

Fri, Oct 19

stjn added a comment to T50047: client watchlist shows more than just the last change on the item.

Since my report I’ve disabled Wikidata edits entirely because having frequently edited items in your watchlist with Wikidata edits enabled is a massive pain for users in default configuration.

Fri, Oct 19, 5:06 PM · Wikidata-Sprint-2015-11-17, Wikidata, MediaWiki-extensions-WikibaseClient

Fri, Oct 12

stjn added a comment to T172068: Wiki Loves Monuments blog upgrade.

WLM Full dark:



Fri, Oct 12, 12:23 PM · Design, Wiki-Loves-Monuments (2018)

Tue, Oct 9

stjn created T206569: New description of ‘our projects’ has no mention of Wikinews.
Tue, Oct 9, 7:22 PM · wikimediafoundation.org

Mon, Oct 8

stjn added a comment to T112982: OOUI ButtonSelectWidget/ButtonGroupWidget not fluid - breaks surveys with multiple buttons.

Is it possible to see a screenshot of an implementation of that fix @stjn?

Mon, Oct 8, 5:17 PM · Patch-For-Review, Reading Web Sprint 59 - Amsterdam and the hamsters, OOUI, UI-Standardization

Sat, Oct 6

stjn reopened T50047: client watchlist shows more than just the last change on the item as "Open".

It appears that this bug was not fixed or was broken afterwards again, as I mentioned in T90435#4119854 before. If I need to file a new task, feel free to close it and forward me to this. I got down to writing a clear task description before finding this task, so I’ll just copy it below.

Sat, Oct 6, 7:44 PM · Wikidata-Sprint-2015-11-17, Wikidata, MediaWiki-extensions-WikibaseClient
stjn reopened T50047: client watchlist shows more than just the last change on the item, a subtask of T90435: [Epic] Wikidata watchlist improvements (client), as Open.
Sat, Oct 6, 7:44 PM · Growth-Team, Epic, MediaWiki-Watchlist, Tracking, MediaWiki-extensions-WikibaseClient, Wikidata

Fri, Oct 5

stjn added a comment to T205197: Support insertion of Scribunto Lua modules using Visual Editor.

But why is it a bad practice? Till now I haven't heard a single really good explanation of why is it bad, or why using a template that does nothing but call a module is good.

Other than one more word, #invoke:, calling a Lua module is not more complicated than calling a template.

Fri, Oct 5, 7:46 PM · VisualEditor, MediaWiki-extensions-Scribunto, TemplateData
stjn added a comment to T205197: Support insertion of Scribunto Lua modules using Visual Editor.

I guess that the reason for this is that there is an assumption that modules are usually not used directly in articles, but are only used internally in templates. I suspect, however, that this assumption is not quite true: searching the main space of the English Wikipedia for insource:#invoke finds quite a lot of direct module invocations.

Fri, Oct 5, 7:32 PM · VisualEditor, MediaWiki-extensions-Scribunto, TemplateData

Thu, Oct 4

stjn added a comment to T160253: Support Wikitext (links, etc.) in TemplateData.

@Jdforrester-WMF: sorry for writing in an old task, but would it be fine to ask you to reconsider this?

Thu, Oct 4, 9:08 PM · TemplateData, VisualEditor
stjn added a comment to T159262: [EPIC] Improve page issues.

Quick question: after A/B test will be done, will new page issue design display without a delay for users or is it expected to be like this in future?

Thu, Oct 4, 2:25 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Readers-Web-Kanbanana-Board-Old, Page-Issue-Warnings, Epic, Design

Wed, Oct 3

stjn added a comment to T206143: Slow response of new preferences UI: Shows content of all tabs on a single page for a moment.

Don’t know the code exactly, but shouldn’t it be possible to do the hiding part correctly before doing something with every widget or whatever is blocking the performance? For people like the task author, showing first tab for 30 seconds or so still will be a visible performance bug.

Wed, Oct 3, 10:06 PM · Performance, UI-Standardization, MediaWiki-User-preferences
stjn added a comment to T206143: Slow response of new preferences UI: Shows content of all tabs on a single page for a moment.

≈3-5 second delay for me on Firefox 62 (Windows) before new UI starts showing me only the current tab.

Wed, Oct 3, 7:05 PM · Performance, UI-Standardization, MediaWiki-User-preferences
stjn added a comment to T178998: Table collapsing button is too close to the caption - add some CSS spacing.

Just for completion: 0.2em seems reasonable in context for the time being.

Wed, Oct 3, 10:18 AM · Patch-Needs-Improvement, UI-Standardization, Google-Code-in-2017, Wikimedia-Israel-Hackers, MediaWiki-General-or-Unknown, CSS, goodfirstbug

Tue, Oct 2

stjn added a comment to T206007: Russian ambox page issues on Minerva showing secondary information.

Wouldn’t matter to people even without the apologies :-)

Tue, Oct 2, 9:41 PM · Russian-Sites, MinervaNeue, Reading-Web-Local-Wiki-Issues
stjn closed T206007: Russian ambox page issues on Minerva showing secondary information as Resolved.

I dont have editing rights there and would feel more comfortable with a community member doing it. Do you know of any template editors?

Tue, Oct 2, 8:59 PM · Russian-Sites, MinervaNeue, Reading-Web-Local-Wiki-Issues
stjn reopened T113008: Epic: Borders aren't always marked as disputed as "Open".

Reopening per https://lists.wikimedia.org/pipermail/wikitech-l/2018-October/090901.html

Tue, Oct 2, 7:08 PM · Reading-Infrastructure-Team-Backlog, Epic, Maps (Map-Styles)
stjn reopened T113008: Epic: Borders aren't always marked as disputed, a subtask of T155601: Stabilizing Interactive Products, as Open.
Tue, Oct 2, 7:08 PM · Commons-Datasets, Graphs, Maps, Discovery, Maps-Sprint
stjn added a comment to T206007: Russian ambox page issues on Minerva showing secondary information.

Here’s the right page if you want to do it yourself:
https://ru.wikipedia.org/wiki/Википедия:Технические_запросы

Tue, Oct 2, 7:03 PM · Russian-Sites, MinervaNeue, Reading-Web-Local-Wiki-Issues
stjn added a project to T206007: Russian ambox page issues on Minerva showing secondary information: Russian-Sites.

If hide-when-compact class doesn’t bring any additional styling on desktop (as far as I can see), I think that (1) wouldn’t be controversial to do.

Tue, Oct 2, 6:51 PM · Russian-Sites, MinervaNeue, Reading-Web-Local-Wiki-Issues
stjn added a comment to T113346: Add GENDER to username related strings on Special:Contributions.

Is there any complexity to adding this to page title? MediaWiki:Contributions already has gender support, but the parameter is not being passed to the message on Special:Contributions, would it be hard to do? (Not asking to nudge people, but rather to know if I can submit a patch.)

Tue, Oct 2, 6:42 PM · Patch-For-Review, Gender-Support, I18n, MediaWiki-Special-pages
stjn added a comment to T205581: Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinable - use pseudo elements for separating elements.

Sorry, haven’t read the entire discussion. My (minor) concern with this, though, is that it would be a lot harder to copy a log line that doesn’t make much sense as a list inside of a list inside of a list (like edit section links don’t really need this treatment), but I guess I can manage.

Tue, Oct 2, 12:53 AM · MobileFrontend (MobileFrontend Special Pages), MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), MediaWiki-Special-pages, MediaWiki-Watchlist, Growth-Team, MediaWiki-Recent-changes, Front-end-Standards-Group, Patch-For-Review, UI-Standardization, User-Jdlrobson
stjn added a comment to T205581: Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinable - use pseudo elements for separating elements.

This solutions bring additional complexity without much benefit, don’t you think? We don’t render edit section links separators via CSS, why in this case it is more viable to do this than to allow customisation via some API?

Tue, Oct 2, 12:39 AM · MobileFrontend (MobileFrontend Special Pages), MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), MediaWiki-Special-pages, MediaWiki-Watchlist, Growth-Team, MediaWiki-Recent-changes, Front-end-Standards-Group, Patch-For-Review, UI-Standardization, User-Jdlrobson
stjn added a comment to T204090: QA page issues feature.

Confirmation for A/B test readiness - Russian Wikipedia
Sidenote: looks so good!

Noted severity working as expected
status: ready for testing

Tue, Oct 2, 12:33 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Audiences-QA, Page-Issue-Warnings

Mon, Oct 1

stjn added a comment to T112982: OOUI ButtonSelectWidget/ButtonGroupWidget not fluid - breaks surveys with multiple buttons.

Maybe you might find this useful: we’ve dealed with this in a gadget in Russian Wikipedia (with mw-ui-button, however) and the solution we found for overflowing was adding a margin-left of 1px on parent and having margin-left: -1px for every button. That way there won’t be unevenness in position of the buttons on the next line.

Mon, Oct 1, 11:47 PM · Patch-For-Review, Reading Web Sprint 59 - Amsterdam and the hamsters, OOUI, UI-Standardization

Tue, Sep 25

stjn added a comment to T200880: Editor should flag mobile editing warnings.

This, sadly, will prove more annoying for editors than useful if we’d try to implement this on a large scale, in my opinion. Especially if the thing that MobileFrontend has concerns with is in some protected template − how a user is expected to go around this if they don’t want to see the warning in the article they’ve written with it?

Tue, Sep 25, 5:09 PM · TechCom-RFC, Page-Issue-Warnings, Readers-Web-Backlog (Design), Reading-Web-Local-Wiki-Issues, MobileFrontend
stjn closed T205440: Doing English words in Uzbek (Uzwiki) as Invalid.

@Malikxan: No assistance from developers is needed for this. Append &uselang=qqx to a page URL and look for message names in places where there was a button.

Tue, Sep 25, 3:11 PM · User-Urbanecm, Wikimedia-Site-requests

Sep 18 2018

stjn added a comment to T204610: Expose gender of gendered namespace aliases in siteinfo API.

Should the single "gender" attribute indicate "male" or "unknown" for those where they're the same?

Sep 18 2018, 3:33 PM · MediaWiki-API

Sep 17 2018

stjn created T204610: Expose gender of gendered namespace aliases in siteinfo API.
Sep 17 2018, 9:58 PM · MediaWiki-API

Sep 11 2018

stjn added a comment to T204091: JavaScript sometimes fails to load completely in Firefox (due to Ublock Origin).

Issue on Github about EU copyright law banner causing this problem, for future reference:
https://github.com/ryanbr/fanboy-adblock/issues/551

Sep 11 2018, 10:33 PM · MediaWiki-ResourceLoader, Performance-Team, Russian-Sites, Browser-Support-Firefox
stjn closed T204091: JavaScript sometimes fails to load completely in Firefox (due to Ublock Origin) as Invalid.

Sorry for bothering, I’ve rooted out the source of the problem: I use Ublock Origin and one of the lists contains a line ||wikipedia.org/w/load.php?*startup$script blocking all of the scripts from Wikipedias (Fanboy’s Annoyance List, probably due to that fullscreen banner about EU copyright law). No engineering effort is needed.

Sep 11 2018, 10:27 PM · MediaWiki-ResourceLoader, Performance-Team, Russian-Sites, Browser-Support-Firefox
stjn created T204091: JavaScript sometimes fails to load completely in Firefox (due to Ublock Origin).
Sep 11 2018, 10:22 PM · MediaWiki-ResourceLoader, Performance-Team, Russian-Sites, Browser-Support-Firefox
stjn added a comment to T203912: HotCat loads code that can be edited without editsitejs right.

Small comment: this can be mitigated without changing HotCat’s code ASAP by changing content model of such pages in every project to JavaScript (as it should be made, since it vastly improves their editing).

Sep 11 2018, 10:16 PM · Wikimedia-General-or-Unknown, JavaScript, Security
stjn awarded T204076: Consider moving page translation language links to the sidebar a Like token.
Sep 11 2018, 6:01 PM · User-notice, Wikimedia-Site-requests, I18n
stjn added a comment to T64702: Extension:Translate's languages box should look like interwiki language links.

Small design suggestion: maybe only ≈full translations should have icons alongside them? It seems strange to draw notice for incomplete translations, which is what these icons will do for most readers. (Other than that, it’s great, btw.)

Sep 11 2018, 6:00 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Language-2018-July-September, MediaWiki-extensions-Translate

Sep 7 2018

stjn added a comment to T203822: Consider adding .mw-wiki-logo {background-size: 135px} to skin CSS.

Or if we want to preserve aspect ratio (do we? I have no idea. Probably. This only works properly if the image is wider than it is high.)

Sep 7 2018, 6:31 PM · CSS, MediaWiki-Interface

Sep 6 2018

stjn added a comment to T203583: {{subst:REVISIONUSER}} no longer substitutes into the current user name, but the username of the last revision .

Yeah, just read https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/451025/. I've been following MediaWiki development for some 10 years, and i still can't follow half of what is discussed and changed there. No one is playing loose here. It is unfortunate that so many people still don't understand the years of quicksand that MediaWiki is built on and the enormous work that is being done to retroactively repair that. Things break at times, there is no perfection.

Sep 6 2018, 6:35 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), User-notice, Patch-For-Review, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Regression, MediaWiki-Parser, MediaWiki-Page-editing
stjn added a comment to T203583: {{subst:REVISIONUSER}} no longer substitutes into the current user name, but the username of the last revision .

As an aside its too bad we cant kill this behaviour. Its a privacy risk.

Sep 6 2018, 6:31 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), User-notice, Patch-For-Review, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Regression, MediaWiki-Parser, MediaWiki-Page-editing
stjn added a comment to T203583: {{subst:REVISIONUSER}} no longer substitutes into the current user name, but the username of the last revision .

This is not a snarky comment, but really: has no one tested that things like this shouldn’t happen? Can we instruct people to thoroughly test major changes like these so that this wouldn’t happen again?

Sep 6 2018, 6:09 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), User-notice, Patch-For-Review, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Regression, MediaWiki-Parser, MediaWiki-Page-editing
stjn awarded T203583: {{subst:REVISIONUSER}} no longer substitutes into the current user name, but the username of the last revision a Dislike token.
Sep 6 2018, 6:00 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), User-notice, Patch-For-Review, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Regression, MediaWiki-Parser, MediaWiki-Page-editing

Sep 5 2018

stjn added a comment to T203427: <maplink> behavior completely destroyed.

Unless I misunderstand something, maps overall just became non-interactive: if you remove that CSS, with JS active it shouldn’t go to Special:Maps/…, it should display the map in its own modal. The issue is not in having CSS that prevents maps from being interactive before JS does its job, the issue is that JS for maps stopped loading or working.

Sep 5 2018, 2:55 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Reading-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, Maps-Sprint, Regression, Maps (Kartographer)

Aug 30 2018

stjn added a comment to T189240: As a user, when clicking on an image in Media Viewer I want to know in advance if it's going to trigger a download.

A more general approach would also be to not show zoom-in icon if on click there won’t be any enlargement from going to the asset URL, since I’d think that many users would find this confusing (and maybe even going against the spec? haven’t investigated it).

Aug 30 2018, 3:55 PM · Multimedia, MediaWiki-extensions-MultimediaViewer

Aug 28 2018

stjn added a comment to T202989: Administrators can no longer view deleted history of js/css pages.

This is what I intended to convey with the comment above.

Aug 28 2018, 2:38 PM · Patch-For-Review, Trust-and-Safety, Wikimedia-General-or-Unknown, Security, JavaScript, Security-Core
stjn added a comment to T202989: Administrators can no longer view deleted history of js/css pages.

A problem lies here: should administrators see deleted revisions of those files if no ‘pure interface administrator’ can? I don’t really have a preference, but it would be kind of strange to provide more privileges to non-intadmins than to intadmins.

Aug 28 2018, 2:33 PM · Patch-For-Review, Trust-and-Safety, Wikimedia-General-or-Unknown, Security, JavaScript, Security-Core
stjn added a comment to T202346: Change in Wikidata localisation is causing JavaScript errors.

Purge did nothing. No errors were in console as far as I am aware. Any action was being sent to the fallback, yes, so events were probably not subscribing to links with new localisation.

Aug 28 2018, 12:27 PM · User-Addshore, Wikidata-Campsite, Russian-Sites, Wikidata
stjn added a comment to T202346: Change in Wikidata localisation is causing JavaScript errors.

What errors?

I'm afraid without more details It is unlikely that we will be able to determine why it was happening.

Basically, subheaders had new localisation in edit buttons (‘править’), and all AJAX for them didn’t work at all. Properties had old localisation (‘редактировать’) and AJAX worked for them.

Aug 28 2018, 12:19 PM · User-Addshore, Wikidata-Campsite, Russian-Sites, Wikidata

Aug 27 2018

stjn added a comment to T200176: Deletion of user js and css requires deletion and edituser* rights.

Alright, disregard.

Aug 27 2018, 10:44 PM · MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, Security-Core, MediaWiki-User-management, Security
stjn added a comment to T202908: New AWB tag has wrong wikicode.

Since without this any non-Wikipedia project or any user with non-conforming language would see completely botched descriptions, I’ve added the task that introduced these messages in such way as a parent task.

Aug 27 2018, 5:12 PM · MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, WikimediaMessages, AutoWikiBrowser
stjn added a subtask for T111663: Tag AWB edits: T202908: New AWB tag has wrong wikicode.
Aug 27 2018, 5:09 PM · User-notice, Bot-Frameworks, WorkType-NewFunctionality, AutoWikiBrowser
stjn added a parent task for T202908: New AWB tag has wrong wikicode: T111663: Tag AWB edits.
Aug 27 2018, 5:09 PM · MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, WikimediaMessages, AutoWikiBrowser
stjn added a comment to T111663: Tag AWB edits.

About the tag- messages: they should probably contain just [[Project:AutoWikiBrowser]] instead of potentially incorrect interwiki links (especially in the current wording, [[en:w: probably won’t work at all).

Aug 27 2018, 4:55 PM · User-notice, Bot-Frameworks, WorkType-NewFunctionality, AutoWikiBrowser
stjn added a comment to T200176: Deletion of user js and css requires deletion and edituser* rights.

If there’s any way to also include undelete, it should probably be done if we’re allowing deletion of those pages.

Aug 27 2018, 2:03 PM · MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, Security-Core, MediaWiki-User-management, Security
stjn added a comment to T190015: Create separate user group for editing sitewide CSS/JavaScript that does not include administrators by default.

Small question: while separating rights, you have granted sitewide JSON editing to sysops, but not granted it to other groups that had editinterface before (specifically, this situation is concerning RuWP’s engineers). Is this intentional in any way or could this be fixed without additional bureaucracy?

Aug 27 2018, 1:10 PM · MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core

Aug 23 2018

stjn reopened T202346: Change in Wikidata localisation is causing JavaScript errors as "Open".

@Marshmallych, please don’t close my tasks for me in the future.

Aug 23 2018, 5:59 PM · User-Addshore, Wikidata-Campsite, Russian-Sites, Wikidata

Aug 21 2018

stjn updated the task description for T202346: Change in Wikidata localisation is causing JavaScript errors.
Aug 21 2018, 2:34 PM · User-Addshore, Wikidata-Campsite, Russian-Sites, Wikidata
Ghuron awarded T202346: Change in Wikidata localisation is causing JavaScript errors a Burninate token.
Aug 21 2018, 1:23 PM · User-Addshore, Wikidata-Campsite, Russian-Sites, Wikidata

Aug 20 2018

stjn created T202346: Change in Wikidata localisation is causing JavaScript errors.
Aug 20 2018, 11:24 PM · User-Addshore, Wikidata-Campsite, Russian-Sites, Wikidata
stjn added a comment to T200297: Introduce a new namespace for collaborative judgments about wiki entities.

A small comment, sorry if I am asking in the wrong place: in the documentation I didn’t see anywhere an explanation for ‘what would communities do if JADE will not prove useful or they would not want it’. The problem with some deployments is that they are irreversible. If Judgments will be rejected by any community in any events, will it leave a permanent unremoveable namespace for a wiki? There are frequent questions from users about Gadget namespace that is unused for multiple years, it would be strange to explain for years that this was (let’s assume the worst) some failed experiment that we can’t get rid of because it contains discussions and stuff.

Aug 20 2018, 10:45 PM · Scoring-platform-team (Current), DBA, Operations, JADE, TechCom-RFC
stjn awarded T201783: Set `$wmgUseFooterContactLink = true` on Russian Wikipedia a Like token.
Aug 20 2018, 6:51 PM · Patch-For-Review, Wikimedia-Site-requests, Russian-Sites
stjn closed T201783: Set `$wmgUseFooterContactLink = true` on Russian Wikipedia as Resolved.
Aug 20 2018, 6:46 PM · Patch-For-Review, Wikimedia-Site-requests, Russian-Sites

Aug 15 2018

stjn added a comment to T200206: Omit `<link rel="mw-deduplicated-inline-style">` from page view HTML.

You could move the <templatestyles> tag to just inside the <div class="navbox"> (a noticeable FOUC seems unlikely to me since it'd just be an unstyled div, although I'm no expert on FOUC), or you could change the style rule to .navbox + link + .navbox.

Aug 15 2018, 3:46 PM · Performance, MediaWiki-Parser, TemplateStyles

Aug 14 2018

Liuxinyu970226 awarded T190563: Thanking messages don’t check gender on Special:History a Like token.
Aug 14 2018, 1:14 AM · Growth-Team, User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), MediaWiki-History-or-Diffs, I18n, Thanks

Aug 12 2018

stjn added a comment to T201783: Set `$wmgUseFooterContactLink = true` on Russian Wikipedia.

Done both pages, thanks for the reminder:

Aug 12 2018, 9:10 PM · Patch-For-Review, Wikimedia-Site-requests, Russian-Sites
stjn created T201783: Set `$wmgUseFooterContactLink = true` on Russian Wikipedia.
Aug 12 2018, 1:14 PM · Patch-For-Review, Wikimedia-Site-requests, Russian-Sites

Aug 11 2018

stjn added a comment to T201765: Mark FlaggedRevs pages as needing review when data fetched from Wikidata changes.

I would say that this potentially would be a very, very, I mean, very bad feature for any project that uses both Wikidata and FlaggedRevs extensively. This unpatrolling routinely means that you have to recheck pages because file description on Commons changed in some time. When projects use Wikidata, there are some links that go outside to tens of different pages, so that problem would be even worse when each change of information in Wikidata would trigger FlaggedRevs rereview.

Aug 11 2018, 7:47 PM · MediaWiki-extensions-WikibaseClient, Wikidata, MediaWiki-extensions-FlaggedRevs

Aug 2 2018

stjn added a comment to T197915: Add styling for review notice from FlaggedRevs in MobileFrontend.

Yes, thanks.

Aug 2 2018, 2:23 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), User-Jdlrobson, Patch-For-Review, MinervaNeue (Tracking), Mobile, MediaWiki-extensions-FlaggedRevs

Aug 1 2018

stjn added a comment to T197915: Add styling for review notice from FlaggedRevs in MobileFrontend.

Minerva will then replace the 'default' styles.
'default' styles will apply to all other skins.

Aug 1 2018, 9:56 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), User-Jdlrobson, Patch-For-Review, MinervaNeue (Tracking), Mobile, MediaWiki-extensions-FlaggedRevs
stjn added a comment to T199917: RFC: Block users by page, namespace, and/or action (Partial Blocks).

@dbarratt: If we’re going by the mockups, I would think that the merge would not be a right option even if restrictions would be used more than blocks, since they mostly would fulfil different needs. Pages and namespaces blocks will mostly be helpful in content disputes, while current blocks are more suited for dealing with bad behaviour. ‘Uploading files’ and ‘Moving pages’ just look out of place there – you make a point about restricting emails without restricting a person entirely, but it’s the only option that you could justify moving to a different block. Other options are already where they need to be – there’s no real need to block a person from creating new accounts only, there’s no need to not block IPs used by a person from editing while not blocking a person themself.

Aug 1 2018, 9:47 PM · TechCom-RFC (TechCom-Approved), Anti-Harassment

Jul 30 2018

stjn added a comment to T199917: RFC: Block users by page, namespace, and/or action (Partial Blocks).

I'm certainly open to alternative implementations, but from my experience, having more than one place to perform the same type of action, is more confusing for users (I use the term "users" in the general sense of all people using the interface).

Since I’ve been tagged: this is where we differ. In my opinion, site-wide blocks and per-page blocks are not the same type of action, with the latter being akin more to page protection but for users instead of pages. It’s a valid approach to make (to not modify page protection since the task’s design goals are much bigger), but it doesn’t make sense for me from social (communities would have to adapt to new feature because right now the ‘block’ is specifically sitewide action, it would probably increase tensions when people would apply it as an edit war deterrent if we tie it to blocks, and they probably would use it like that) or design standpoint (below).

Jul 30 2018, 3:35 PM · TechCom-RFC (TechCom-Approved), Anti-Harassment
stjn added a comment to T200615: Infobox templates are being parsed and substituted with Content Translation.

OK, thanks, I’ve just (mistakenly) figured that I might clarify that in case of not getting that it is our template instead of original one.

Jul 30 2018, 3:10 PM · ContentTranslation
stjn added a comment to T197915: Add styling for review notice from FlaggedRevs in MobileFrontend.

I don’t see a need in revert, since it doesn’t look critically bad.

Jul 30 2018, 2:56 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), User-Jdlrobson, Patch-For-Review, MinervaNeue (Tracking), Mobile, MediaWiki-extensions-FlaggedRevs
stjn added a comment to T197915: Add styling for review notice from FlaggedRevs in MobileFrontend.

@Jdlrobson: seems like I should’ve asked you for a screenshot when you tested this. It’s been finally deployed and it looks like this in the wild:
https://ru.m.wikipedia.org/wiki/Счисление_координат

Jul 30 2018, 2:44 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), User-Jdlrobson, Patch-For-Review, MinervaNeue (Tracking), Mobile, MediaWiki-extensions-FlaggedRevs
stjn added a comment to T200615: Infobox templates are being parsed and substituted with Content Translation.

One difference with the task you’ve provided is in that in this case, a template exists and was inserted through Content Translation interface with some means (since it has data-name="Фильм" etc. which are present in infoboxes of Russian WP), but was subsequently somehow substituted.

Jul 30 2018, 1:46 PM · ContentTranslation

Jul 28 2018

stjn updated the task description for T200615: Infobox templates are being parsed and substituted with Content Translation.
Jul 28 2018, 6:45 PM · ContentTranslation
stjn created T200615: Infobox templates are being parsed and substituted with Content Translation.
Jul 28 2018, 6:19 PM · ContentTranslation
stjn added a comment to T200614: Provide a way to document template styles or add other text to those pages.

I didn’t talk specifically about the documentation, it’s just one of the solutions that will be the most easy to implement.

Jul 28 2018, 6:00 PM · TemplateStyles
stjn created T200614: Provide a way to document template styles or add other text to those pages.
Jul 28 2018, 5:53 PM · TemplateStyles

Jul 27 2018

stjn added a comment to T190549: Differentiate between internal, interwiki and external links visually.

Seems like the icon doesn’t show in the reference drawer, where it would’ve supposedly be seen the most. Is this intentional?

Jul 27 2018, 12:10 AM · Readers-Web-Backlog (Design), MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), User-notice, Patch-For-Review, MinervaNeue, UI-Standardization, Design

Jul 25 2018

stjn updated the task description for T200367: Tajik Cyrillic shouldn’t use Arabic comma in dates.
Jul 25 2018, 7:34 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-Internationalization
stjn created T200367: Tajik Cyrillic shouldn’t use Arabic comma in dates.
Jul 25 2018, 7:33 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-Internationalization

Jul 24 2018

stjn added a comment to T199255: Translate CountryNope message to other languages.

Great. Small fix needed though: Special:UserLogin/SignupSpecial:UserLogin/signup, the first one doesn’t work as intended and I only noticed this now.

Jul 24 2018, 6:57 PM · Fundraising-Backlog

Jul 23 2018

stjn added a comment to T190549: Differentiate between internal, interwiki and external links visually.

These would normally be prevented by authors through the user of plainlinks. Although, this particular example might also be a bug with the code change (not th general idea), because icons aren't meant to be applied to images - we don't apply icons to external links around images, either.

Also, if not planned already, it may be worth considering to coordinate the change with the desktop skins (at least Vector). Otherwise users are disadvantaged by link-rendering differing significantly between desktop and mobile, which makes it hard to understand and fix issues caused by the change – as well as to prevent it in the future by being able to notice it while creating content.

All links there are internal, not external, so plainlinks wasn’t required before. They aren’t applied to images, they are applied to links, see here:
https://ru.m.wikipedia.org/wiki/Заглавная_страница

Jul 23 2018, 4:17 PM · Readers-Web-Backlog (Design), MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), User-notice, Patch-For-Review, MinervaNeue, UI-Standardization, Design
stjn added a comment to T168333: CSS is duplicated on each template usage.

It doesn’t do anything bad to keep them, the only thing that might be interested in removing them is probably mobile version (since every byte seems to count there).

Jul 23 2018, 3:02 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Performance-Team (Radar), Patch-For-Review, Technical-Debt, TemplateStyles

Jul 21 2018

stjn added a comment to T199917: RFC: Block users by page, namespace, and/or action (Partial Blocks).

Not only is this a lot of duplication of existing functionality, it is confusing for new admins to have to different pages to block a user.

Jul 21 2018, 3:05 PM · TechCom-RFC (TechCom-Approved), Anti-Harassment

Jul 20 2018

stjn added a comment to T198758: Load .json configuration files via ResourceLoaderWikiModule.

You might be interested in the bot that Wikimedia Commons uses for MediaWiki:Gadget-markAdmins-data.js.

Jul 20 2018, 5:54 PM · MediaWiki-Interface, MediaWiki-ResourceLoader, Performance-Team
stjn added a comment to T198758: Load .json configuration files via ResourceLoaderWikiModule.

As another example where this would be helpful: in Russian Wikipedia sysops and bureaucrats frequently edit a gadget for showing users with advanced groups so that it would stay up-to-date. If there won’t be a more comfortable solution such as JSON, quite a lot people might argue either for workarounds that undermine security (such as content model change?) or for giving those rights to them by default when they don’t really edit any other pages.

Jul 20 2018, 5:26 PM · MediaWiki-Interface, MediaWiki-ResourceLoader, Performance-Team
stjn created T200096: Make Uls-plang-title-languages consistent with Otherlanguages (or otherwise).
Jul 20 2018, 4:28 PM · Design, MediaWiki-Internationalization, UniversalLanguageSelector

Jul 16 2018

stjn added a project to T199647: Failing ParserIntegrationTest PHPUnit test causes CI failures for various extensions: MediaWiki-extensions-FlaggedRevs.
Jul 16 2018, 11:40 AM · MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018), Patch-For-Review, SyntaxHighlight, MediaWiki-Parser, User-zeljkofilipin

Jul 15 2018

stjn added a comment to T164445: &#10; breaks lists in CharInsert.

Team project tag was added because I need the opinion from the team as they are the code stewards of this extension. Was that really inappropriate?

Jul 15 2018, 4:06 PM · Patch-For-Review, MediaWiki-Parser, CharInsert
stjn added a comment to T54448: Transclusion dialog should not suggest documentation sub pages as templates.

Suggestion: allow the wiki administrator to designate a particular subpage string, such as doc, as the official place to keep TemplateData. Then VisualEditor can intelligently and unambiguously filter these pages out. See T125222.

Jul 15 2018, 12:05 AM · Patch-For-Review, VisualEditor-MediaWiki-Templates, VisualEditor, VisualEditor-EditingTools

Jul 13 2018

stjn edited projects for T164445: &#10; breaks lists in CharInsert, added: Editing-team; removed Parsing-Team.

About the patch above: since it adds new functionality (and per guide), can someone please tell me if that would be OK? It is a frequently used functionality (adding line breaks) that even more frequently breaks the resulting wiki code and parser because of it (can’t work in lists, frequently breaks even paragraphs etc.). I figured that having it as a handled use case would be less problematic than continuing to advise using hacky HTML code.

Jul 13 2018, 11:43 PM · Patch-For-Review, MediaWiki-Parser, CharInsert
stjn added a comment to T160252: format = inline displays as "custom" while not true.

Are you telling this after testing the patch? (In theory, it should’ve fixed the task above.) Disappointing, if so.

Jul 13 2018, 11:02 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, VisualEditor, TemplateData
stjn closed T100075: Flow: the text above the button switch VE in the right rail as Invalid.

Flow interface was changed since then, and there is no such bug in new interface, so no point in keeping this task open.

Jul 13 2018, 3:28 PM · Growth-Team, goodfirstbug, Collaboration-Team-Triage, StructuredDiscussions
stjn added a comment to T199534: Confirmation prompt for rollback action (#7 2017).

Can’t you just do a gadget please? I seriously don’t understand why all of this development is even needed.

Jul 13 2018, 3:21 PM · WMDE volunteer workboard, Needs-user-research, German-Community-Wishlist-Main-Wishes
stjn added a comment to T160252: format = inline displays as "custom" while not true.

What exactly is, the one in the topic or the one I fixed with it? The one in the topic is still present in wikis, so it’s not in any way an old issue. TemplateData should not display a message about ‘custom format’ on _every_ format, otherwise the message should be removed entirely.

Jul 13 2018, 2:49 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, VisualEditor, TemplateData

Jul 12 2018

stjn added a comment to T160252: format = inline displays as "custom" while not true.

I haven’t tested the patch above, but it looks to me like the problem is happening because isset( $formats[$data->format] ) was referencing an unknown variable, so it always returned custom. If anyone could check this, it would be more than appreciated.

Jul 12 2018, 10:39 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, VisualEditor, TemplateData
stjn added a project to T176956: Add a class to empty TemplateData fields titles (dt): goodfirstbug.
Jul 12 2018, 8:16 PM · Patch-For-Review, goodfirstbug, TemplateData, VisualEditor
stjn awarded T199416: Cache update time for Gadgets and Common.js/css regressed from 5 min to 1 hour a Burninate token.
Jul 12 2018, 3:36 PM · MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review, Core-Platform-Team-Old, Multi-Content-Revisions, Regression, MediaWiki-ResourceLoader, Performance-Team

Jul 11 2018

stjn added a comment to T195053: Reduce page jumps in table of contents.

Didn’t look into a patch before, some small questions (not arguing against the patch or anything):

  1. Does it mean that now you should just check the checkbox if you are modifying the TOC with scripts (Ctrl+F ‘TOC hidden’ in Russian Wikipedia’s Common.js)?
  2. Is CSS-based solution entirely accessible? Here it says that IE11 doesn’t read CSS content.
Jul 11 2018, 9:28 PM · Performance-Team (Radar), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board-Old, CSS, JavaScript, MediaWiki-Interface

Jul 9 2018

stjn added a comment to T190015: Create separate user group for editing sitewide CSS/JavaScript that does not include administrators by default.

Ah, don’t even know how I didn’t notice added lines after clicking on ‘show skipped’. Sorry for misunderstanding.

Jul 9 2018, 12:20 PM · MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core