Page MenuHomePhabricator

stjn
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 2:35 PM (258 w, 6 d)
Availability
Available
IRC Nick
stjn
LDAP User
Unknown
MediaWiki User
Stjn [ Global Accounts ]

Recent Activity

Today

stjn added a comment to T162379: Decide which non-standard CSS properties to support in TemplateStyles.

Theoretically, Autoprefixer just uses Caniuse data to match it with a required set of browsers, so it might be possible to use it in the same way (raw Caniuse data is just a lot of JSON) but in PHP. The esteemed Somebody Else would have to port the code in the first link to css-sanitizer, however, and keep up with development of Autoprefixer in the future (the latter is easier than the former).

Mon, Sep 23, 4:31 PM · Core Platform Team, Patch-For-Review, css-sanitizer, TemplateStyles

Sat, Sep 21

stjn awarded T211881: graphoid: Code stewardship request a Heartbreak token.
Sat, Sep 21, 12:17 PM · Release-Engineering-Team-TODO (201908), Release-Engineering-Team (Code Health), Core Platform Team Legacy (Watching / External), Services (watching), Operations, Code-Stewardship-Reviews, Graphoid

Thu, Aug 29

stjn added a comment to T162379: Decide which non-standard CSS properties to support in TemplateStyles.

Alternatively, zoom: 1 can be dropped from every codebase since it’s a property that does something in IE5-7, browsers that should be used by absolutely no one in 2019.

Thu, Aug 29, 1:31 PM · Core Platform Team, Patch-For-Review, css-sanitizer, TemplateStyles

Aug 19 2019

stjn added a comment to T204089: CirrusSearch: Add filter for exclusion of redirects or finding only them.

I think it could be a keyword, preferably one that allows people both to exclude and include redirects from the search (inredirect:true / inredirect:false then?). As to UI, it can probably be included to AdvancedSearch in some way (and not included in older UI?), but I don’t have a strong opinion about it.

Aug 19 2019, 3:43 PM · Advanced-Search, Discovery-Search, CirrusSearch, TCB-Team

Aug 9 2019

stjn added a comment to T66315: Move "Data item" link outside of sidebar toolbox.

Previously list item with Wikidata item had #t-wikibase ID by virtue of being in Tools section. Some gadgets, stylesheets, and user scripts do use this ID (insource:"t-wikibase" prefix:all: search in ruWP, enWP). Will this be accounted for in some way (like providing a class like wb-otherproject-wikibase-item and doing global replacements)?

Aug 9 2019, 10:04 PM · Wikidata-Campsite, MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Patch-For-Review, User-notice, User-Ladsgroup, User-Noarave, Wikidata, MediaWiki-extensions-WikibaseClient
stjn updated subscribers of T222828: Avoid MagicWord/LCStore cost from WikiEditor in startup module (resourceLoaderGetConfigVars hook).

@Vort reports that customising signature button code via mw.config.set('mw.msg.wikieditor', '~~\~~'); also broke likely due to this change. Is there a viable replacement for that, too? It was used by some people in Russian Wikipedia (including me), and now there’s no easy way to customise it.

Aug 9 2019, 4:23 PM · Editing-team, Performance-Team (Radar)
stjn added a comment to T230124: AddThis gadgets are a violation of the privacy policy.

If the gadget informed the user that information was going to a third party and the user had to opt in to use it (as is the case on ru wikipedia, although i didnt check the others) this was considered a grey area. Afaik this was never officially blessed as being ok, but de-facto was considered ok, or at least we turned a blind eye to it.

Aug 9 2019, 12:01 PM · Wikimedia-General-or-Unknown, Privacy

Aug 6 2019

stjn added a comment to T229664: Thumbnails are too small due to background-size for an icon.

I missed that it had background-size: cover; before, will fix when we get a consensus about naming.

Aug 6 2019, 6:15 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, RelatedArticles

Aug 2 2019

stjn added a comment to T229644: RelatedArticles showing on all German and Russian Wikipedia due to incorrect configuration settings.

You can copy or reference this script, since RelatedArticles wouldn’t load until .read-more-container exists on the page:
https://ru.wikipedia.org/wiki/Участник:Stjn/relatedArticles.js

Aug 2 2019, 7:36 PM · Wikimedia-Site-requests, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), User-notice, Patch-For-Review, RelatedArticles
stjn added a comment to T206578: #p-personal h3 (#p-personal-label) is in all our skins hidden.

I think you misunderstood the point of headings there. For example, in Vector #p-personal-label is used explicitly:
<div id="p-personal" role="navigation" aria-labelledby="p-personal-label">

Aug 2 2019, 7:17 PM · Readers-Web-Backlog (Tracking), MediaWiki-General, Vector
stjn added a comment to T181242: Related Article cards are not shown on Timeless skin.

I can suggest something like:
‘The change in RelatedArticles extension accidentally enabled it for everyone, not just on mobile. This has been fixed.’

Aug 2 2019, 4:20 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), User-notice, Wikimedia-Site-requests, RelatedArticles, Readers-Web-Backlog (Tracking), Patch-For-Review, Timeless
stjn added a comment to T181242: Related Article cards are not shown on Timeless skin.

Tech News usually don't cover Timeless display issues.

Aug 2 2019, 3:32 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), User-notice, Wikimedia-Site-requests, RelatedArticles, Readers-Web-Backlog (Tracking), Patch-For-Review, Timeless
stjn created T229664: Thumbnails are too small due to background-size for an icon.
Aug 2 2019, 1:39 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, RelatedArticles

Aug 1 2019

stjn added a comment to T168420: Drop gradients from Vector tabs.

The patch above affected only background-color shown if background-image doesn’t get loaded. Issue with gradient in background-image still stands.

Aug 1 2019, 11:03 PM · Readers-Web-Backlog (Tracking), MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Design, Vector
stjn added a comment to T181242: Related Article cards are not shown on Timeless skin.

Does default config include Vector? Because I was not speaking about English Wikipedia, btw (I cannot reproduce it there, if that matters, while seeing the change in Russian Wikipedia, both logged in and logged out). The Related articles block was previously not shown on Vector everywhere, now it gets shown. I do not have complaints about that, and did not, certainly, came to grumble from English Wikipedia :-)

Aug 1 2019, 11:02 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), User-notice, Wikimedia-Site-requests, RelatedArticles, Readers-Web-Backlog (Tracking), Patch-For-Review, Timeless
stjn added a comment to T191156: Convert FlaggedRevisions to OOUI.

Recently, FlaggedRevs interface got enabled for reviewers in Minerva (see T181242 and T226199). With that change and OOUI not being used in FlaggedRevs, the interface is looking in Minerva like this:

Aug 1 2019, 10:37 PM · Patch-For-Review, Growth-Team, MediaWiki-extensions-FlaggedRevs, UI-Standardization
stjn added a comment to T181242: Related Article cards are not shown on Timeless skin.

The effect of this change was that related articles feature was enabled for all readers and users in the default skin, Vector. In fact, this has done two things, not one, for wikis using FlaggedRevs extension, since FlaggedRevs interface was moved outside of content area and enabled in Minerva.

Aug 1 2019, 9:57 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), User-notice, Wikimedia-Site-requests, RelatedArticles, Readers-Web-Backlog (Tracking), Patch-For-Review, Timeless
stjn added a comment to T229624: Remove Facebook surveillance network buttons from Wikimedia blog.

Social sharing buttons on wikimediafoundation.org do not seem to load any external scripts unless users purposefully click on them. The only domains that get listed in Ublock Origin for me are wikimediafoundation.org and wikimedia.org (latter is Piwik Analytics), so where exactly is surveillance from Facebook?

Aug 1 2019, 9:31 PM · wikimediafoundation.org, Privacy
stjn added a comment to T226976: Convert linkitem module to use OOUI, instead of jQuery UI.

If Vue that Wikibase team uses is not server-side, shipping 60 Kb of JavaScript to users in Wikipedias for a relatively small tool in the interface is probably not great, even if that makes the developer experience a bit better.

Aug 1 2019, 6:44 PM · Performance-Team (Radar), Wikidata-Campsite, Wikidata, MediaWiki-extensions-WikibaseClient, UI-Standardization

Jul 18 2019

stjn added a comment to T227958: stream.wikimedia.org/?doc returns an error page.

Is component documentation supposed to contain nothing? In fact, there are multiple React errors on doing any action on the page. (Firefox 68.) Sorry if that’s a topic for a new task, the page still is effectively not working, just in a different way.

Jul 18 2019, 4:42 PM · Analytics-Kanban, Analytics, Documentation, Wikimedia-Stream

Jul 16 2019

stjn awarded T188200: Allow signatures to be global a Like token.
Jul 16 2019, 6:34 PM · MediaWiki-extensions-GlobalPreferences
stjn updated the task description for T228194: Every Wikidata edit gets displayed in watchlist despite ‘Expand watchlist to show all settings’ not set.
Jul 16 2019, 5:21 PM · Wikidata-Campsite, Regression, MediaWiki-extensions-WikibaseClient, Wikidata
stjn created T228194: Every Wikidata edit gets displayed in watchlist despite ‘Expand watchlist to show all settings’ not set.
Jul 16 2019, 5:21 PM · Wikidata-Campsite, Regression, MediaWiki-extensions-WikibaseClient, Wikidata
stjn closed T50047: client watchlist shows more than just the last change on the item, a subtask of T90435: [Epic] Wikidata watchlist improvements (client), as Resolved.
Jul 16 2019, 5:14 PM · Growth-Team, Epic, MediaWiki-Watchlist, Tracking-Neverending, MediaWiki-extensions-WikibaseClient, Wikidata
stjn closed T50047: client watchlist shows more than just the last change on the item as Resolved.
Jul 16 2019, 5:14 PM · Wikidata-Campsite, Wikidata-Sprint-2015-11-17, Wikidata, MediaWiki-extensions-WikibaseClient

Jul 13 2019

stjn created T227958: stream.wikimedia.org/?doc returns an error page.
Jul 13 2019, 9:50 PM · Analytics-Kanban, Analytics, Documentation, Wikimedia-Stream
stjn closed T201393: Add Galician Wikipedia to wikistream as Invalid.

This is not a task for stream.wikimedia.org, so closing it as invalid.

Jul 13 2019, 9:49 PM · Wikimedia-Stream

Jul 12 2019

stjn added a comment to T227857: VE saving dialog title is illegible for some languages.

Translate extension mostly facilitates batch translations, and it’s not like everyone knows 100% where each message is going to end up showing (or this is shown to them), so most people probably go for a translation that makes most sense to them rather than the one that fits most in a specific interface.

Jul 12 2019, 7:18 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MediaWiki-Internationalization, I18n, VisualEditor (Current work)
stjn added a comment to T192588: Add user block stop hand icon to OOUI.

Can this be done any time soon? We use OOUI-based design in block notices in Russian Wikipedia (along with others) and we think it would be better if the icon was similar to one in MobileFrontend.

Jul 12 2019, 3:50 PM · OOUI
stjn reopened T201026: Regression: colours not accessible (not conforming to WCAG 2 AA), a subtask of T201682: Accessibility issues of new Wikimedia Foundation website (failing WCAG conformance) (tracking), as Open.
Jul 12 2019, 11:44 AM · Goal, Accessibility, wikimediafoundation.org
stjn reopened T201026: Regression: colours not accessible (not conforming to WCAG 2 AA) as "Open".

Testing with tota11y:

Jul 12 2019, 11:44 AM · Accessibility, Regression, wikimediafoundation.org
stjn added a comment to T227857: VE saving dialog title is illegible for some languages.

This was previously already filed as T212811, but Schnark for some reason closed it as a duplicate. One solution I mentioned here was just making the form a bit wider.

Jul 12 2019, 11:27 AM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MediaWiki-Internationalization, I18n, VisualEditor (Current work)

Jul 11 2019

stjn added a comment to T211881: graphoid: Code stewardship request.

On an unrelated note, I find funny that the top wiki in terms of graphs is very low in requests in graphoid. In fact, I get the impression (could be false) the two ordered datasets don't correlate very well with one another but I think this is a question best left to be answered in some other task.

Jul 11 2019, 11:31 PM · Release-Engineering-Team-TODO (201908), Release-Engineering-Team (Code Health), Core Platform Team Legacy (Watching / External), Services (watching), Operations, Code-Stewardship-Reviews, Graphoid
stjn edited projects for T227789: Increase base font size for wikipedia.org, added: Wikimedia-Portals; removed Wikimedia-General-or-Unknown.
Jul 11 2019, 5:11 PM · Wikimedia-Portals, Design, CSS, Accessibility
stjn awarded T227789: Increase base font size for wikipedia.org a Like token.
Jul 11 2019, 5:11 PM · Wikimedia-Portals, Design, CSS, Accessibility
stjn added a comment to T201041: wikimediafoundation.org main page requires first world bandwidth and data plan.

With https://jakearchibald.github.io/svgomg/ and zero precision in units (since it’s a whooping 14,000×1,400-wide image, they probably won’t make much difference) it’s possible to cut down the SVG file to 400 Kb, but I’d suggest throwing the image out entirely at least on mobile and for people preferring reduced motion.

Jul 11 2019, 5:02 PM · wikimediafoundation.org

Jul 3 2019

Restricted Application added a project to T227228: Recent changes page with RC filters misses margin after heading: Growth-Team.
Jul 3 2019, 9:24 PM · Edit-Review-Improvements-RC-Page, Growth-Team
stjn added a comment to T223793: On non-SET wikis (two edit tabs), links to new pages (red links) should open the user's preferred editor (last used).

I'd counter that existing edit notices are useless on mobile devices, so the problem is the design of the current edit notices which assume desktop screen sizes...

Jul 3 2019, 9:04 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), User-notice, VisualEditor-MediaWiki, VisualEditor (Current work)

Jun 18 2019

stjn added a comment to T137291: Transition all use of EasyTimeline to the Graph extension and decommission it from Wikimedia's servers.

Obviously our Cyrillic-speaking friends have used this a lot more than everyone else, and will need special efforts.

Jun 18 2019, 4:39 PM · Technical-Debt, Wikimedia-Extension-setup, Multimedia, Epic, Graphs, EasyTimeline

Jun 16 2019

stjn added a comment to T223793: On non-SET wikis (two edit tabs), links to new pages (red links) should open the user's preferred editor (last used).

This change has one glaring problem. Most projects have edit notices for people trying to create new pages. This text displays fine in standard wikitext editor, but in any visual editor (we should have a better name for them) it gets shoved away into a small box which usually ends up not fitting the screen. Moreover, an average editor will probably close these notices since they are shown to them once in a tertiary position that gets in the way of editing.

Jun 16 2019, 8:33 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), User-notice, VisualEditor-MediaWiki, VisualEditor (Current work)
stjn created T225888: Add page title to no-JS confirmation page.
Jun 16 2019, 3:43 PM · Confirmation prompt for rollback action

Jun 15 2019

stjn updated the task description for T225873: Infinite scroll in StructuredDiscussions has no loading icon.
Jun 15 2019, 7:44 PM · UI-Standardization, UI-Standardization-Kanban, Patch-For-Review, Regression, StructuredDiscussions, Growth-Team
Restricted Application added a project to T225873: Infinite scroll in StructuredDiscussions has no loading icon: Growth-Team.
Jun 15 2019, 7:43 PM · UI-Standardization, UI-Standardization-Kanban, Patch-For-Review, Regression, StructuredDiscussions, Growth-Team
stjn added a comment to T216431: Graphs create img tags without width and height.

Ah, you’re right. Noticed through the testing on desktop that width and height of <img> and container are different even for simplest images. To be honest, it’s a really strange technical decision that, I guess, invalidates my patch.

Jun 15 2019, 2:58 PM · Patch-For-Review, Readers-Web-Backlog (Tracking), Mobile, Graphs
stjn updated subscribers of T216431: Graphs create img tags without width and height.

Judging by (git) blame, the code for width/height was added a long time ago by @Yurik. Maybe he can fill in about situations where min-width / min-height are preferable to explicit specification on <img>?

Jun 15 2019, 9:19 AM · Patch-For-Review, Readers-Web-Backlog (Tracking), Mobile, Graphs

Jun 13 2019

stjn added a comment to T213995: Parsoid does not apply "format" from TemplateData if the template is transcluded via a redirect.

We have discovered a similar problem in Russian Wikipedia and think it might be instances of this bug. A user edited an infobox {{Карточка ФК}} that redirects to {{Футбольный клуб}}, and although TemplateData shows fine in the VisualEditor frontend, it clearly isn’t being read by backend when forming wiki code (messing up param order). Can you tell us if it’s the same problem?

Jun 13 2019, 6:59 PM · VisualEditor, TemplateData, Parsoid-Edit-Support

Jun 11 2019

stjn added a comment to T225462: Inform about localised special page aliases in Siteinfo API.

Do you have an example? I described the way MediaWiki itself determines the canonical alias, which works based on the same data that the API already returns.

Jun 11 2019, 8:12 PM · MediaWiki-API
stjn added a comment to T225462: Inform about localised special page aliases in Siteinfo API.

It's almost always the first one in the list of aliases. More specifically, it's the first one in the list of aliases that doesn't collide with some other special page, and the code logs a warning if that happens for the first alias in the list (e.g. T89034, T112410, T224841).

Jun 11 2019, 6:10 PM · MediaWiki-API

Jun 10 2019

stjn created T225462: Inform about localised special page aliases in Siteinfo API.
Jun 10 2019, 7:50 PM · MediaWiki-API

Jun 7 2019

stjn added a comment to T155878: Use OOUI icons for FlaggedRevs.

Big regression introduced with this change: the diff that shows to FlaggedRevs reviewers when there are any unreviewed changes can’t be shown anymore because diff toggle gets hidden upon loading. Some reviewers probably won’t be happy with this. I don’t know how we’re going to fix this if there won’t be any deployments for 2 weeks, though.

Jun 7 2019, 12:24 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-Hackathon-2019, MediaWiki-extensions-FlaggedRevs, User-Ladsgroup, User-notice, UI-Standardization

Jun 6 2019

stjn added a comment to T155878: Use OOUI icons for FlaggedRevs.

Thank you for quick response

Jun 6 2019, 7:55 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-Hackathon-2019, MediaWiki-extensions-FlaggedRevs, User-Ladsgroup, User-notice, UI-Standardization
stjn awarded T155878: Use OOUI icons for FlaggedRevs a Like token.
Jun 6 2019, 7:21 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-Hackathon-2019, MediaWiki-extensions-FlaggedRevs, User-Ladsgroup, User-notice, UI-Standardization
stjn added a comment to T155878: Use OOUI icons for FlaggedRevs.

@Volker_E: two issues, not sure if I need to open new tasks.

Jun 6 2019, 7:21 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-Hackathon-2019, MediaWiki-extensions-FlaggedRevs, User-Ladsgroup, User-notice, UI-Standardization

Jun 3 2019

stjn added a comment to T224924: Make suggestions in search box redirect to pages.

Gosh, I’ve really forgot that I’ve already filed a task like this. Now that’s embarrassing. Guess it shows how much I need it :-D

Jun 3 2019, 6:51 PM · Discovery-Search, UI-Standardization, MediaWiki-Search
stjn merged T224924: Make suggestions in search box redirect to pages into T210649: Suggestions in a search field on Special:Search should act the same as suggestions in search bar.
Jun 3 2019, 6:50 PM · Discovery-Search, UI-Standardization, MediaWiki-Search
stjn merged task T224924: Make suggestions in search box redirect to pages into T210649: Suggestions in a search field on Special:Search should act the same as suggestions in search bar.
Jun 3 2019, 6:50 PM · Discovery-Search, UI-Standardization, MediaWiki-Search
stjn renamed T224924: Make suggestions in search box redirect to pages from Make suggestions in search box redirect to to Make suggestions in search box redirect to pages.
Jun 3 2019, 6:46 PM · Discovery-Search, UI-Standardization, MediaWiki-Search
Restricted Application added a project to T224924: Make suggestions in search box redirect to pages: Discovery-Search.
Jun 3 2019, 6:46 PM · Discovery-Search, UI-Standardization, MediaWiki-Search

Jun 1 2019

stjn added a comment to T224737: [Bug] Animated banner changes layout on update.

This is the first banner in years that I’ve willingly closed. It not only shifts layout (they all do), but also flickers far too much for comfortable reading of articles (this, probably, has effects on people with motion sickness) and takes too much place in the layout in comparison with other banners. I am relieved, however, that it doesn’t get shown to readers.

Jun 1 2019, 1:24 PM · MediaWiki-extensions-CentralNotice, Readers-Web-Backlog

May 31 2019

stjn awarded Blog Post: Performance perception: how satisfied are Wikipedia users? a Love token.
May 31 2019, 9:44 AM · Performance-Team

May 29 2019

Amorymeltzer awarded T224524: Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load a Piece of Eight token.
May 29 2019, 10:22 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Search, Discovery-Search, MediaWiki-Special-pages, Regression
stjn edited projects for T224614: Add link trail for Azerbaijani language, added: MediaWiki-Internationalization; removed MediaWiki-General.
May 29 2019, 7:25 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), MediaWiki-Internationalization
stjn awarded T220415: Add API module to get language information a Like token.
May 29 2019, 1:24 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-Hackathon-2019, MediaWiki-API, MediaWiki-Internationalization

May 28 2019

SerDIDG awarded T224524: Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load a Burninate token.
May 28 2019, 11:04 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Search, Discovery-Search, MediaWiki-Special-pages, Regression
stjn renamed T224524: Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load from Special:Contributions shows autocomplete on page load in to Special:Contributions shows autocomplete on page load.
May 28 2019, 9:44 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Search, Discovery-Search, MediaWiki-Special-pages, Regression
stjn created T224524: Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load.
May 28 2019, 9:43 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Search, Discovery-Search, MediaWiki-Special-pages, Regression
stjn added a comment to T174811: Support JavaScript hook events for CodeMirror.

Because It wasn't the primary target of the couple of weeks of development spent on the project: https://meta.wikimedia.org/wiki/Community_Tech/Wikitext_editor_syntax_highlighting

May 28 2019, 6:07 PM · Patch-For-Review, MediaWiki-extensions-CodeMirror
stjn added a comment to T174811: Support JavaScript hook events for CodeMirror.

It seems like any customisation or extendability of CodeMirror by JavaScript developers was completely left out of development by Community Tech team. I’ve first noticed it in T214989 (not exactly first-hand), now I am seeing more issues trying to develop a script with keyboard shortcuts for WikiEditor (link for curious), and this is the most serious issue out of all. It’s really strange to see an important end-user tool to lack all of this stuff.

May 28 2019, 4:47 PM · Patch-For-Review, MediaWiki-extensions-CodeMirror
stjn awarded T174811: Support JavaScript hook events for CodeMirror a Like token.
May 28 2019, 4:40 PM · Patch-For-Review, MediaWiki-extensions-CodeMirror

May 27 2019

stjn created T224445: Permit hidden attribute in Sanitizer.
May 27 2019, 8:46 PM · Security-Team, MediaWiki-Parser

May 26 2019

stjn awarded T194434: Show recently used templates on the home screen for TemplateWizard a Like token.
May 26 2019, 6:46 PM · Community-Tech, MediaWiki-extensions-TemplateWizard
stjn added a comment to T194434: Show recently used templates on the home screen for TemplateWizard.

I wanted to propose users having an option to remember/pin some templates in some sort of speed dial, but given that this task exists, I don’t have to. Great :-)

May 26 2019, 6:46 PM · Community-Tech, MediaWiki-extensions-TemplateWizard

May 10 2019

stjn raised the priority of T50047: client watchlist shows more than just the last change on the item from Normal to Unbreak Now!.

Will anything be done to this? Watchlisting any big item (such as ones for any country) completely breaks my watchlist with multitudes of edits to the same articles, why is this completely neglected? This is a default configuration, not some option, why is no one working on the fix?

May 10 2019, 12:48 PM · Wikidata-Campsite, Wikidata-Sprint-2015-11-17, Wikidata, MediaWiki-extensions-WikibaseClient

May 9 2019

stjn added a comment to T222883: Provide a common class for visually hiding the text.

Yes (is it MediaWiki-General that I should’ve put?).

May 9 2019, 2:13 PM · MediaWiki-General, CSS, Accessibility
stjn added a comment to T213955: Add support for aliased parameter names in source-wiki templates.

If you need an example of a file for which conversion currently doesn’t work in production and should work with the patch, here:

May 9 2019, 2:11 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-04-30, WMDE-QWERTY-Team, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), TCB-Team, Move-Files-To-Commons
stjn added a comment to T175977: Prevent web crawler from indexing buttons in content.

Have you taken into consideration accessibility implications of supplying essentially empty links to users? As long as we’re supporting Internet Explorer 11, there are issues with that.

May 9 2019, 1:53 PM · Patch-For-Review, MediaWiki-General
stjn added a project to T222883: Provide a common class for visually hiding the text: CSS.
May 9 2019, 1:37 PM · MediaWiki-General, CSS, Accessibility
stjn created T222883: Provide a common class for visually hiding the text.
May 9 2019, 1:35 PM · MediaWiki-General, CSS, Accessibility

Apr 23 2019

stjn added a comment to T139221: Make generated table of contents a navigation region.

Heydon Pickering specifically suggests it to us in his book Inclusive Design Patterns:

Apr 23 2019, 5:21 PM · Patch-For-Review, Accessibility, MediaWiki-Parser

Apr 12 2019

stjn created T220856: XmlRcs doesn’t report any new pages.
Apr 12 2019, 9:28 PM · Russian-Sites, Huggle

Apr 10 2019

stjn added a comment to T107069: Convert HistoryAction.php to use OOUI and MW's new DateInputWidget.

I really liked this change because of the ability to pick a concrete date, but the interface clearly wasn’t fledged out. Collapsing the form now seems not like a complete fix of the design, but like a quick and dirty change to appease people. This is especially visible on the screenshots provided here, where OOUI clearly doesn’t support collapsing forms like this and bottom margin is still visible in collapsed view.

Apr 10 2019, 9:02 PM · MediaWiki-Page-History, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), UI-Standardization-Kanban, User-Jdlrobson, Advanced Mobile Contributions, MediaWiki-Page-Diffs, UI-Standardization

Apr 3 2019

stjn updated stjn.
Apr 3 2019, 3:22 PM

Mar 30 2019

stjn added a comment to T204089: CirrusSearch: Add filter for exclusion of redirects or finding only them.

Similar small use case: I was trying to find articles with a specific set of symbols (intitle:/ - /) to see how frequent they are and all the results were the redirects, which was not helpful in a bit. Filter could’ve helped with it.

Mar 30 2019, 11:53 AM · Advanced-Search, Discovery-Search, CirrusSearch, TCB-Team

Mar 21 2019

stjn added a comment to T199534: Confirmation prompt for rollback action (#7 2017).

I suppose a full extension allows revert protection feature to work even without javascript, and in the common case of a click done by the user before the full page load with its scripts.

Mar 21 2019, 11:30 AM · Confirmation prompt for rollback action, German-Community-Wishlist-Main-Wishes

Mar 18 2019

stjn removed a project from T177596: Addition "skipcat" or "supresscat" and "nocat" param for Babel-box: Patch-For-Review.
Mar 18 2019, 1:48 PM · Language-Team, patch-welcome, WorkType-NewFunctionality, good first bug, MediaWiki-extensions-Babel

Mar 2 2019

stjn updated stjn.
Mar 2 2019, 8:22 PM
stjn removed a member for Tech-Ambassadors: stjn.
Mar 2 2019, 8:21 PM

Feb 2 2019

stjn changed the status of T107119: Provide a Lua method mw.templatedata.load() from Stalled to Open.

@jeblad: can you explain your reasoning? Just because no one finished the patch, it doesn’t mean it should be marked as ‘stalled’ (removing it from the view for everyone who wants to work on TemplateData-related tasks).

Feb 2 2019, 8:44 PM · Wikimania-Hackathon-2019, Patch-For-Review, Wikimedia-Israel-Hackers, VisualEditor-MediaWiki, VisualEditor, TemplateData

Jan 31 2019

stjn added a comment to T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL.

Wasn’t aware of this link, thanks for addressing my concern. (‘Mobile view’ link sets cookies that make mobile version permanent for a visitor, though.)

Jan 31 2019, 8:29 PM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations
stjn added a comment to T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL.

If you add some redirection, add a way to circumvent it please (via some specific query?). Right now testing for mobile version involves just changing a domain, with this proposal it would involve changing a user agent string which is much harder to explain to people (and impossible to link to, in fact).

Jan 31 2019, 6:59 PM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations

Jan 30 2019

stjn created T214989: Allow CodeMirror to be used for other textareas with WikiEditor.
Jan 30 2019, 9:33 PM · Convenient-Discussions, MediaWiki-extensions-CodeMirror

Jan 29 2019

stjn added a comment to T213778: Update link colors in Vector for improved UX (and consistency).

Yeah, I get that, that’s why I’m saying that reverting back to black and seeking accessible colours next to pure black is better than having pale link colours that still barely come around WCAG 2.0 AA level requirement (3:1, see https://webaim.org/blog/wcag-2-0-and-link-colors/) because of using dark grey.

Jan 29 2019, 9:26 PM · UI-Standardization, Vector
stjn added a comment to T213778: Update link colors in Vector for improved UX (and consistency).

#3366cc is almost two times lighter against background compared to #0645ad and doesn’t pass WCAG 2.0 AAA level for text.

Jan 29 2019, 5:35 PM · UI-Standardization, Vector
stjn added a comment to T213778: Update link colors in Vector for improved UX (and consistency).

#3366cc is a poorly chosen colour for links. While you’re upping contrast level to almost 3:1 with normal text, like WCAG 2.0 tells us, you’re decreasing it almost in two times for the background (while not against AA level, making it against AAA level). What that really tells us is not that we need to have less visible link colour, but we should’ve not used #222 as main text colour because of purely stylistic choices (and fix contrast of the links in regards to pure black text instead of dark grey).

Jan 29 2019, 2:05 PM · UI-Standardization, Vector

Jan 25 2019

stjn added a comment to T67747: Sanitizer::removeHTMLtags doesn't close tags correctly when $wgUseTidy is enabled.

Another example of this type of bug: unclosed <font> tag affects the entire page due to leaking out of DISPLAYTITLE.

Jan 25 2019, 11:19 AM · MediaWiki-extensions-Linter, RemexHtml, Tidy, MediaWiki-Parser

Jan 18 2019

stjn added a comment to T214063: Move fileimporter configs from Mediawiki.org to Wikimedia meta.

Well, I just saw this task and thought that it’s just moving chairs around the table when there’s a more pressing issue. Most communities have sysops or people involved with the project could’ve asked for global interface editing rights, so I’m not really convinced this was a wise thing to do, but I won’t bother you with further comments.

Jan 18 2019, 4:35 PM · Move-Files-To-Commons, TCB-Team
stjn added a comment to T214063: Move fileimporter configs from Mediawiki.org to Wikimedia meta.

In my opinion, which I said in #wikimedia-tech before, they should be in MediaWiki: namespace of local projects (so, restricted to all local admins), not in any one wiki that hardly anyone pays attention to. Current setup is certainly a vector of attack for Commons.

Jan 18 2019, 3:07 PM · Move-Files-To-Commons, TCB-Team

Jan 7 2019

stjn added a comment to T208901: TemplateStyles breaks a paragraph if a file is inserted inline.

Parser in the web browser is not the problem, that’s what I’m trying to tell. The proposed strategy with <link rel="stylesheet"> is unfeasible, since the point of inline styles is exactly to move away from the additional browser requests. The strategy with extracting <style> elements in <head> was declined before and for a good reason (increasing the time of first paint). The strategy of putting them in the end of <body> will add flashes of unstyled content.

Jan 7 2019, 3:37 PM · Patch-For-Review, Core Platform Team Workboards (Done with CPT), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Parsoid, TemplateStyles, MediaWiki-Parser
stjn added a comment to T208901: TemplateStyles breaks a paragraph if a file is inserted inline.

This issue is not caused by browser logic, which allows to put <style> anywhere as of HTML 5.2 (and even before then, even if it would’ve been semantically incorrect, it would still work in browsers), it is caused by inaccurate parsing rules of MediaWiki wikitext parser. There’s nothing preventing us to fix those rules, especially since browser logic doesn’t require these bugs to happen.

Jan 7 2019, 12:32 PM · Patch-For-Review, Core Platform Team Workboards (Done with CPT), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Parsoid, TemplateStyles, MediaWiki-Parser

Jan 3 2019

stjn added a comment to T212743: Scroll can change when switching out temporary wikitext editor for full surface in NWE.

One possible solution from an outsider’s viewpoint is not to set focus on the text field if the user is outside first visible screen.

Jan 3 2019, 8:06 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor