I stopped working on this extension for a year or two, but now I need to get back into it and upgrade it for the latest version of MW. Probably will not be dealing ith this particular task right now. First need to remember how all of this works. Do we still have to use gerrit? Can extension update be handled with arc and phabricator instead?

This has been completed back in 2019

This is done in master now, but since master branch currently only works on master branch of MW, i will also merge it back into REL1_33 before closing this.

Maintenance script already fixed in master branch, but I also moved it to a correct maintenance subfolder and fixed the name. Now backporting the minimum needed changes to REL1_33 and below.

HitCounter patch has to be handled separately. This issue here has been resolved in master and also REL1_32 and REL1_33 branches. All these branches should work fine with MW 1.25+ now.

Fixed in master and merged to REL1_32 and REL1_33 branches.

Back in 2013, the only thing that could cause no results is that rev_timestamp was not setup as an attribute in sphing configuration. We do not index any timestamps in the default configuration, so sorting by rev_timestamp would not work. You could modify the main sphinx indexing query and add an additional attribute to the sphinx configuration, something like:

sql_query = SELECT page_id, page_title, page_namespace, page_is_redirect, UNIX_TIMESTAMP(page_touched) as page_timestamp, old_id, old_text FROM page, revision, text WHERE rev_id=page_latest AND old_id=rev_text_id

So, I tried following my own instructions from seven years ago and the only issue were some warnings about maintenance script arguments (memory-limit and profiler.) I implemented a quick workaround just to get the setup script to run, but everything else worked out of the box, and now I get suggestions in search results. I will cleanup the setup script properly and submit a code review.

I am setting up a gerrit review for this now.

I am not able to replicate this issue - tried both with current version of the extension and an older one. Thes two queries produce correctly different results:

This has been fixed with https://gerrit.wikimedia.org/r/517711 but i will take a look at the HitCounter patch as well, since it seems that one not only fixed the sql query but adds some missing functionality.

This has been fixed with https://gerrit.wikimedia.org/r/517711

Since there was no activity on this for over a year, I will take it over and submit the patch on gerrit.

I have a working patch for this, though it could be improved some more. I am confused by two things: