Loves pierogi
User Details
- User Since
- Oct 31 2017, 6:51 PM (375 w, 6 d)
- Availability
- Available
- IRC Nick
- takidelfin
- LDAP User
- Takidelfin
- MediaWiki User
- Unknown
Dec 27 2018
Thank you :D
Added it to Morning SWAT schedule
Dec 26 2018
I don't know if I'm permitted to respond under this task - if not, sorry :(
@Urbanecm Could I schedule it for deployment, please? (At January 7 Morning SWAT)
^-^
Dec 16 2018
I couldn't find Grunt plugin for this.
Maybe I could try to make one?
This is maybe a good option: JSON.parse(messageFile) and then JSON.stringify(result, null, 4) <-- indent value
or using Regex?
@SBisson I think it is ready for review
Dec 14 2018
Maybe displaying already logged in/registered error and then redirecting? @Urbanecm
(Multiple patches)
Dec 13 2018
Dec 12 2018
Could I try? It seems to be a good DRF lesson for me :D
Dec 11 2018
Should I comment out cookies thing?
@Trizek-WMF yup, using cookies. But @SBisson says that there can be problems when the user does not accept cookies.
Dec 10 2018
@Gopavasanth hmm, any problems with https://gerrit.wikimedia.org/r/c/mediawiki/skins/Bouquet/+/472515 ? Because it is still 'floating' on Gerrit.
I can help with merging conflicts! :D
Dec 9 2018
Patch set 6:
Dec 8 2018
Changed the assignee as the task got claimed by a student on GCI site
Done!
if ( mw.config.get( 'wgUserName' ) && !mw.user.options.get( 'flow-guidedtour-topic-seen' ) ) { [...] } else if ( !mw.config.get( 'wgUserName' ) && !$.cookie( 'flow-guidedtour-topic-seen' ) ) { [...] }
Patch is ready for a review
@SBisson Looks like I need to add step 5 for IP users too, right? :/
Dec 7 2018
Dec 4 2018
Nov 29 2018
Nov 28 2018
I'll try do it.
Nov 18 2018
Nov 16 2018
@Framawiki @Urbanecm Could you review my patch, please? https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/474372
Nov 13 2018
@Caro_107 Actually you embedded a png image into your SVG :D
The design must not include any bitmap graphics (examples for bitmap file formats: PNG, JPEG, BMP, TIFF, WEBM, etc).
Nov 12 2018
@Jdlrobson Could you look at my newest patch? I have added a comment describing the purpose of max-width media query
>=1000px | >=720px | <720px |
---|---|---|
Ah! I thought that issue is with that spacing! Sorry ;(
I have added that 'internal padding' though.
Nov 11 2018
umm.... but that is how it looks actually.
Is this expected behavior?
yep, there is 1 px padding :/
I really don't understand what is the expected behavior. Do you want consistent padding on all views or different for larger than 720px?
umm, so that padding is expected? But I did it previously D:
Nov 10 2018
@D3r1ck01 @Jdlrobson Could you please review my patch? Jenkins added +2, all tests have passed successfully. :D
>=1000px | >=720px | <720px |
---|---|---|
Nov 9 2018
@Jdlrobson @D3r1ck01 Could you please review my 2nd attempt? https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/472701
Okay, I found a way how to achieve it without !important it:
#section_0 { padding: 34px 16px 0; } .tagline { padding: 0 16px; }
Expected behavior | Actual behavior |
---|---|
Hmm... I have used
!important
because of mobile.special.styles overriding mobile.mobileoptions.styles :/
Does it behave as expected? @D3r1ck01 @Jdlrobson
>= 720px | < 720px |
---|---|
Nov 8 2018
Which version looks better? @matmarex
(yes, I know it should be internationalization)
Oct 30 2018
I optimized and minified SVGs,
My sticker designs. SVG, no raster embeds :D Minified and optimized of course. files are big (over 30 kb) because I converted text to paths (that fixes missing fonts problem). But I can provide a version with raw text too.
Dec 28 2017
Ok, thanks!
It's acctually done? I'm interested in this task. But I can't see it on GCI website, and on WIkimedia Commons are some designs (but old, after it many users proposed something there).
Nov 29 2017
Yes, I'm sure. I tested many variations of ratings.
This issue was fixed.