thcipriani (Tyler Cipriani)
Rappa Ternt RelEng

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 9 2015, 10:04 PM (127 w, 5 d)
Availability
Available
IRC Nick
thcipriani
LDAP User
Unknown
MediaWiki User
TCipriani (WMF)

Recent Activity

Fri, Jul 21

thcipriani closed T171342: VM request for RelEng pwstore as Declined.

The other deployers would still have to decrypt the encrypted files to actually see content though, so it's not really sharing secrets with them unless we don't trust GPG by itself.

Fri, Jul 21, 9:58 PM · Release-Engineering-Team (Watching / External), vm-requests, Operations
demon awarded T171342: VM request for RelEng pwstore a Y So Serious token.
Fri, Jul 21, 9:34 PM · Release-Engineering-Team (Watching / External), vm-requests, Operations
thcipriani added a project to T171342: VM request for RelEng pwstore: Release-Engineering-Team.
Fri, Jul 21, 7:43 PM · Release-Engineering-Team (Watching / External), vm-requests, Operations
thcipriani created T171342: VM request for RelEng pwstore.
Fri, Jul 21, 7:43 PM · Release-Engineering-Team (Watching / External), vm-requests, Operations

Thu, Jul 20

thcipriani committed rMSCA1c2074b5b18a: Move python-semver from Depends to Suggests (authored by thcipriani).
Move python-semver from Depends to Suggests
Thu, Jul 20, 5:25 PM
thcipriani closed D724: Move python-semver from Depends to Suggests by committing rMSCA1c2074b5b18a: Move python-semver from Depends to Suggests.
Thu, Jul 20, 5:25 PM · Release-Engineering-Team
thcipriani created D724: Move python-semver from Depends to Suggests.
Thu, Jul 20, 5:18 PM · Release-Engineering-Team

Wed, Jul 19

Volans awarded T129139: Deploy statsv with scap3 a Like token.
Wed, Jul 19, 5:26 PM · User-fgiunchedi, Patch-For-Review, monitoring, Deployment-Systems, Scap (Scap3-Adoption-Phase1), scap2
thcipriani closed T167893: MW-1.30.0-wmf.9 deployment blockers as Resolved.
Wed, Jul 19, 5:22 PM · Release-Engineering-Team (Kanban), Train Deployments, Release
thcipriani added a comment to T129139: Deploy statsv with scap3.

Completed

Wed, Jul 19, 5:11 PM · User-fgiunchedi, Patch-For-Review, monitoring, Deployment-Systems, Scap (Scap3-Adoption-Phase1), scap2

Mon, Jul 17

thcipriani updated subscribers of T170881: Cleanup /srv/deployment.
Mon, Jul 17, 9:00 PM · Scap (Scap3-Adoption-Phase1), Trebuchet
thcipriani added a parent task for T170881: Cleanup /srv/deployment: T129290: [keyresult] Migrate remaining trebuchet deployed services.
Mon, Jul 17, 8:59 PM · Scap (Scap3-Adoption-Phase1), Trebuchet
thcipriani added a subtask for T129290: [keyresult] Migrate remaining trebuchet deployed services: T170881: Cleanup /srv/deployment.
Mon, Jul 17, 8:59 PM · Trebuchet, releng-201718-q1, releng-201516-q4, Scap (Scap3-Adoption-Phase1)
thcipriani updated subscribers of T170881: Cleanup /srv/deployment.

I think all these can be removed

Mon, Jul 17, 8:58 PM · Scap (Scap3-Adoption-Phase1), Trebuchet
thcipriani created T170881: Cleanup /srv/deployment.
Mon, Jul 17, 8:58 PM · Scap (Scap3-Adoption-Phase1), Trebuchet
thcipriani closed T170648: CirrusSearch/includes/Elastica/PooledHttp.php:67 Timeout reached waiting for an available pooled curl connection! as Resolved.
Mon, Jul 17, 8:52 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Unplanned-Sprint-Work, Reading-Web-Kanban-Board, Patch-For-Review, Discovery-Search (Current work), Discovery, CirrusSearch, Recommendation-API, Wikimedia-log-errors
thcipriani closed T170648: CirrusSearch/includes/Elastica/PooledHttp.php:67 Timeout reached waiting for an available pooled curl connection!, a subtask of T167893: MW-1.30.0-wmf.9 deployment blockers, as Resolved.
Mon, Jul 17, 8:52 PM · Release-Engineering-Team (Kanban), Train Deployments, Release
thcipriani added a comment to T170648: CirrusSearch/includes/Elastica/PooledHttp.php:67 Timeout reached waiting for an available pooled curl connection!.

@EBernhardson thank you for your investigation on this task! Sorry to send you so far down the rabbit hole, but I'm glad you came back with the rabbit :) This is a very satisfying explanation.

Mon, Jul 17, 5:02 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Unplanned-Sprint-Work, Reading-Web-Kanban-Board, Patch-For-Review, Discovery-Search (Current work), Discovery, CirrusSearch, Recommendation-API, Wikimedia-log-errors
thcipriani claimed T150502: Set up experimental Docker CI slave.
Mon, Jul 17, 4:34 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Continuous-Integration-Infrastructure
thcipriani added a parent task for T170839: Migrate dropwizard/metrics to scap3: T129290: [keyresult] Migrate remaining trebuchet deployed services.
Mon, Jul 17, 3:57 PM · Scap (Scap3-Adoption-Phase1)
thcipriani added a subtask for T129290: [keyresult] Migrate remaining trebuchet deployed services: T170839: Migrate dropwizard/metrics to scap3.
Mon, Jul 17, 3:57 PM · Trebuchet, releng-201718-q1, releng-201516-q4, Scap (Scap3-Adoption-Phase1)
thcipriani created T170839: Migrate dropwizard/metrics to scap3.
Mon, Jul 17, 3:57 PM · Scap (Scap3-Adoption-Phase1)
thcipriani added a parent task for T137371: Deploy cassandra metrics collector via scap3: T129290: [keyresult] Migrate remaining trebuchet deployed services.
Mon, Jul 17, 3:55 PM · Services (doing), Patch-For-Review, Cassandra, Scap (Scap3-Adoption-Phase1), RESTBase-Cassandra
thcipriani added a subtask for T129290: [keyresult] Migrate remaining trebuchet deployed services: T137371: Deploy cassandra metrics collector via scap3.
Mon, Jul 17, 3:55 PM · Trebuchet, releng-201718-q1, releng-201516-q4, Scap (Scap3-Adoption-Phase1)

Fri, Jul 14

thcipriani accepted D600: Create a wrapper around conftool for our pooling/depooling needs.
Fri, Jul 14, 8:43 PM · Release-Engineering-Team
thcipriani added a comment to T170648: CirrusSearch/includes/Elastica/PooledHttp.php:67 Timeout reached waiting for an available pooled curl connection!.

While possible, I doubt the cirrus error is related to the train rollout. We have an ongoing intermittent issue related to elasticsearch with T168816 and more generally T169498.

Fri, Jul 14, 6:15 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Unplanned-Sprint-Work, Reading-Web-Kanban-Board, Patch-For-Review, Discovery-Search (Current work), Discovery, CirrusSearch, Recommendation-API, Wikimedia-log-errors
thcipriani accepted D715: Quote CLI arguments in `RunsConfig` instructions.

wfm

Fri, Jul 14, 3:51 PM · Release-Engineering-Team

Thu, Jul 13

thcipriani triaged T170648: CirrusSearch/includes/Elastica/PooledHttp.php:67 Timeout reached waiting for an available pooled curl connection! as Unbreak Now! priority.

Alerts and errors stopped when I rolled back to 1.30.0-wmf.7 so this seems to be caused by 1.30.0-wmf.9. Adding as blocker, raising priority.

Thu, Jul 13, 11:58 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Unplanned-Sprint-Work, Reading-Web-Kanban-Board, Patch-For-Review, Discovery-Search (Current work), Discovery, CirrusSearch, Recommendation-API, Wikimedia-log-errors
thcipriani added a subtask for T167893: MW-1.30.0-wmf.9 deployment blockers: T170648: CirrusSearch/includes/Elastica/PooledHttp.php:67 Timeout reached waiting for an available pooled curl connection!.
Thu, Jul 13, 11:57 PM · Release-Engineering-Team (Kanban), Train Deployments, Release
thcipriani added a parent task for T170648: CirrusSearch/includes/Elastica/PooledHttp.php:67 Timeout reached waiting for an available pooled curl connection!: T167893: MW-1.30.0-wmf.9 deployment blockers.
Thu, Jul 13, 11:57 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Unplanned-Sprint-Work, Reading-Web-Kanban-Board, Patch-For-Review, Discovery-Search (Current work), Discovery, CirrusSearch, Recommendation-API, Wikimedia-log-errors
thcipriani created T170648: CirrusSearch/includes/Elastica/PooledHttp.php:67 Timeout reached waiting for an available pooled curl connection!.
Thu, Jul 13, 11:57 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Unplanned-Sprint-Work, Reading-Web-Kanban-Board, Patch-For-Review, Discovery-Search (Current work), Discovery, CirrusSearch, Recommendation-API, Wikimedia-log-errors
thcipriani removed a subtask for T167893: MW-1.30.0-wmf.9 deployment blockers: T170596: Could not acquire lock 'LinksUpdate:job:pageid:xxx'.
Thu, Jul 13, 9:37 PM · Release-Engineering-Team (Kanban), Train Deployments, Release
thcipriani removed a parent task for T170596: Could not acquire lock 'LinksUpdate:job:pageid:xxx': T167893: MW-1.30.0-wmf.9 deployment blockers.
Thu, Jul 13, 9:37 PM · MediaWiki-JobQueue, Wikimedia-log-errors
thcipriani lowered the priority of T170596: Could not acquire lock 'LinksUpdate:job:pageid:xxx' from Unbreak Now! to Normal.

Removing as train blocker: old log message in a new channel.

Thu, Jul 13, 9:37 PM · MediaWiki-JobQueue, Wikimedia-log-errors
thcipriani added a comment to T170596: Could not acquire lock 'LinksUpdate:job:pageid:xxx'.

I don't see much noise from the logs about refreshLinks at https://logstash.wikimedia.org/goto/a029053d21a195163e68acc0a23e760e.

Thu, Jul 13, 9:25 PM · MediaWiki-JobQueue, Wikimedia-log-errors
thcipriani added a comment to T170599: Wikibase: $idSerialization must match /^Q[1-9]\d{0,9}\z/i.

Removed as train blocker, seems to have been happening pre 1.30.0-wmf.9, sorry for the noise

Thu, Jul 13, 6:55 PM · Patch-For-Review, Wikimedia-log-errors, Wikidata, Wikibase-DataModel
thcipriani added a comment to T170597: Wikidata/extensions/Constraints: InvalidArgumentException:$itemId must be either ItemId or string.

Removed as train blocker, seems to have been happening pre 1.30.0-wmf.9, sorry for the noise

Thu, Jul 13, 6:55 PM · Patch-For-Review, Wikidata, Wikimedia-log-errors
thcipriani removed a parent task for T170597: Wikidata/extensions/Constraints: InvalidArgumentException:$itemId must be either ItemId or string: T167893: MW-1.30.0-wmf.9 deployment blockers.
Thu, Jul 13, 6:55 PM · Patch-For-Review, Wikidata, Wikimedia-log-errors
thcipriani removed subtasks for T167893: MW-1.30.0-wmf.9 deployment blockers: T170599: Wikibase: $idSerialization must match /^Q[1-9]\d{0,9}\z/i, T170597: Wikidata/extensions/Constraints: InvalidArgumentException:$itemId must be either ItemId or string.
Thu, Jul 13, 6:55 PM · Release-Engineering-Team (Kanban), Train Deployments, Release
thcipriani removed a parent task for T170599: Wikibase: $idSerialization must match /^Q[1-9]\d{0,9}\z/i: T167893: MW-1.30.0-wmf.9 deployment blockers.
Thu, Jul 13, 6:55 PM · Patch-For-Review, Wikimedia-log-errors, Wikidata, Wikibase-DataModel
thcipriani lowered the priority of T170597: Wikidata/extensions/Constraints: InvalidArgumentException:$itemId must be either ItemId or string from Unbreak Now! to Normal.
Thu, Jul 13, 6:54 PM · Patch-For-Review, Wikidata, Wikimedia-log-errors
thcipriani lowered the priority of T170599: Wikibase: $idSerialization must match /^Q[1-9]\d{0,9}\z/i from Unbreak Now! to Normal.
Thu, Jul 13, 6:54 PM · Patch-For-Review, Wikimedia-log-errors, Wikidata, Wikibase-DataModel
thcipriani triaged T170596: Could not acquire lock 'LinksUpdate:job:pageid:xxx' as Unbreak Now! priority.

UBN since I added as a train blocker.

Thu, Jul 13, 4:40 PM · MediaWiki-JobQueue, Wikimedia-log-errors
thcipriani triaged T170597: Wikidata/extensions/Constraints: InvalidArgumentException:$itemId must be either ItemId or string as Unbreak Now! priority.

UBN since I added as a train blocker.

Thu, Jul 13, 4:40 PM · Patch-For-Review, Wikidata, Wikimedia-log-errors
thcipriani triaged T170599: Wikibase: $idSerialization must match /^Q[1-9]\d{0,9}\z/i as Unbreak Now! priority.

UBN since I added as a train blocker.

Thu, Jul 13, 4:40 PM · Patch-For-Review, Wikimedia-log-errors, Wikidata, Wikibase-DataModel
thcipriani added subtasks for T167893: MW-1.30.0-wmf.9 deployment blockers: T170596: Could not acquire lock 'LinksUpdate:job:pageid:xxx', T170597: Wikidata/extensions/Constraints: InvalidArgumentException:$itemId must be either ItemId or string, T170599: Wikibase: $idSerialization must match /^Q[1-9]\d{0,9}\z/i.
Thu, Jul 13, 4:37 PM · Release-Engineering-Team (Kanban), Train Deployments, Release
thcipriani added a parent task for T170596: Could not acquire lock 'LinksUpdate:job:pageid:xxx': T167893: MW-1.30.0-wmf.9 deployment blockers.
Thu, Jul 13, 4:37 PM · MediaWiki-JobQueue, Wikimedia-log-errors
thcipriani added a parent task for T170597: Wikidata/extensions/Constraints: InvalidArgumentException:$itemId must be either ItemId or string: T167893: MW-1.30.0-wmf.9 deployment blockers.
Thu, Jul 13, 4:37 PM · Patch-For-Review, Wikidata, Wikimedia-log-errors
thcipriani added a parent task for T170599: Wikibase: $idSerialization must match /^Q[1-9]\d{0,9}\z/i: T167893: MW-1.30.0-wmf.9 deployment blockers.
Thu, Jul 13, 4:37 PM · Patch-For-Review, Wikimedia-log-errors, Wikidata, Wikibase-DataModel
thcipriani created T170599: Wikibase: $idSerialization must match /^Q[1-9]\d{0,9}\z/i.
Thu, Jul 13, 4:36 PM · Patch-For-Review, Wikimedia-log-errors, Wikidata, Wikibase-DataModel
thcipriani created T170597: Wikidata/extensions/Constraints: InvalidArgumentException:$itemId must be either ItemId or string.
Thu, Jul 13, 4:30 PM · Patch-For-Review, Wikidata, Wikimedia-log-errors
thcipriani created T170596: Could not acquire lock 'LinksUpdate:job:pageid:xxx'.
Thu, Jul 13, 4:24 PM · MediaWiki-JobQueue, Wikimedia-log-errors

Wed, Jul 12

thcipriani accepted D711: Broaden base test coverage.
Wed, Jul 12, 7:17 PM · Release-Engineering-Team
thcipriani added a comment to D600: Create a wrapper around conftool for our pooling/depooling needs.

Seems like we've tested all we can test without actually calling the .write() method anywhere, lgtm!

Wed, Jul 12, 2:51 PM · Release-Engineering-Team

Tue, Jul 11

thcipriani closed T170317: Notice: Use of undefined constant NS_MODULE - assumed 'NS_MODULE' in /srv/mediawiki/wmf-config/CommonSettings.php on line 3099 as Resolved.

rolled group0 forward and error has subsided.

Tue, Jul 11, 8:26 PM · Patch-For-Review, MediaWiki-extensions-TemplateSandbox, Wikimedia-log-errors
thcipriani closed T170317: Notice: Use of undefined constant NS_MODULE - assumed 'NS_MODULE' in /srv/mediawiki/wmf-config/CommonSettings.php on line 3099, a subtask of T167893: MW-1.30.0-wmf.9 deployment blockers, as Resolved.
Tue, Jul 11, 8:26 PM · Release-Engineering-Team (Kanban), Train Deployments, Release
thcipriani triaged T170317: Notice: Use of undefined constant NS_MODULE - assumed 'NS_MODULE' in /srv/mediawiki/wmf-config/CommonSettings.php on line 3099 as Unbreak Now! priority.

UBN -- added as train blocker

Tue, Jul 11, 8:06 PM · Patch-For-Review, MediaWiki-extensions-TemplateSandbox, Wikimedia-log-errors
thcipriani added a parent task for T170317: Notice: Use of undefined constant NS_MODULE - assumed 'NS_MODULE' in /srv/mediawiki/wmf-config/CommonSettings.php on line 3099: T167893: MW-1.30.0-wmf.9 deployment blockers.
Tue, Jul 11, 8:06 PM · Patch-For-Review, MediaWiki-extensions-TemplateSandbox, Wikimedia-log-errors
thcipriani added a subtask for T167893: MW-1.30.0-wmf.9 deployment blockers: T170317: Notice: Use of undefined constant NS_MODULE - assumed 'NS_MODULE' in /srv/mediawiki/wmf-config/CommonSettings.php on line 3099.
Tue, Jul 11, 8:06 PM · Release-Engineering-Team (Kanban), Train Deployments, Release
thcipriani added a project to T170317: Notice: Use of undefined constant NS_MODULE - assumed 'NS_MODULE' in /srv/mediawiki/wmf-config/CommonSettings.php on line 3099: MediaWiki-extensions-TemplateSandbox.

+MediaWiki-extensions-TemplateSandbox since that's the line line that seems problematic in CommonSettings.php

Tue, Jul 11, 8:05 PM · Patch-For-Review, MediaWiki-extensions-TemplateSandbox, Wikimedia-log-errors
thcipriani created T170317: Notice: Use of undefined constant NS_MODULE - assumed 'NS_MODULE' in /srv/mediawiki/wmf-config/CommonSettings.php on line 3099.
Tue, Jul 11, 8:04 PM · Patch-For-Review, MediaWiki-extensions-TemplateSandbox, Wikimedia-log-errors
thcipriani moved T167893: MW-1.30.0-wmf.9 deployment blockers from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.
Tue, Jul 11, 6:48 PM · Release-Engineering-Team (Kanban), Train Deployments, Release
thcipriani committed rGBLBR3ad2c475d963: Escape docker output (authored by thcipriani).
Escape docker output
Tue, Jul 11, 3:56 PM
thcipriani closed D705: Escape docker output by committing rGBLBR3ad2c475d963: Escape docker output.
Tue, Jul 11, 3:56 PM · Release-Engineering-Team
thcipriani closed T167999: Escape Blubber config values when compiling to Dockerfile as Resolved by committing rGBLBR3ad2c475d963: Escape docker output.
Tue, Jul 11, 3:56 PM · Release-Engineering-Team (Kanban), Release Pipeline (Blubber)
thcipriani created T170285: blubber: produces empy ENV statements.
Tue, Jul 11, 3:46 PM · Release-Engineering-Team (Kanban), Release Pipeline (Blubber)

Mon, Jul 10

thcipriani closed T170186: Repeat SCAP errors due to some Extension:Scribunto error as Resolved.

The extra noise here was caused by T166348: Scribunto_LuaSandboxInterpreter::callFunction: LuaSandboxFunction::call returned false the root cause of which seems to be the luasandbox hhvm-module. While that is being fixed, we unfortunately have a higher than normal error rate. Scap appears to have been doing the correct thing here since this error rate is unacceptable — releng has made noise about this error potentially causing issues during the last train — however, this error appears unrelated to any specific code deployment over the past several weeks. See the linked task for full discussion.

Mon, Jul 10, 7:29 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Wikimedia-log-errors, Scap
thcipriani updated the diff for D705: Escape docker output.

Idiomatic getter

Mon, Jul 10, 5:39 PM · Release-Engineering-Team
thcipriani added inline comments to D600: Create a wrapper around conftool for our pooling/depooling needs.
Mon, Jul 10, 4:57 PM · Release-Engineering-Team
thcipriani requested changes to D600: Create a wrapper around conftool for our pooling/depooling needs.

Few things I found from futzing on tin.

Mon, Jul 10, 4:03 PM · Release-Engineering-Team
thcipriani claimed T167893: MW-1.30.0-wmf.9 deployment blockers.
Mon, Jul 10, 3:31 PM · Release-Engineering-Team (Kanban), Train Deployments, Release

Fri, Jul 7

thcipriani added inline comments to D704: Configure arcanist, linters, and unit engine.
Fri, Jul 7, 3:38 PM · Release-Engineering-Team
thcipriani abandoned D695: Escape newline chars in Docker output.

rethought this in D705

Fri, Jul 7, 3:30 PM · Release-Engineering-Team

Thu, Jul 6

thcipriani created D705: Escape docker output.
Thu, Jul 6, 9:27 PM · Release-Engineering-Team
thcipriani added a revision to T167999: Escape Blubber config values when compiling to Dockerfile: D705: Escape docker output.
Thu, Jul 6, 9:27 PM · Release-Engineering-Team (Kanban), Release Pipeline (Blubber)

Wed, Jul 5

thcipriani closed T166384: scap: Investigate scaps handling of InitialiseSettings.php as Resolved.

Now that D654 is landed all of the sync-* commands should always touch InitialiseSettings.php. It seems that we don't worry so much about T103886 this should be the correct behavior. This will roll with scap 3.6.0-1

Wed, Jul 5, 4:52 PM · Release-Engineering-Team (Kanban), Scap
thcipriani moved T137124: Scap3 submodule space issues from Kanban to Backlog on the Release-Engineering-Team board.
Wed, Jul 5, 4:41 PM · Release-Engineering-Team (Backlog), WorkType-NewFunctionality, Deployment-Systems, Scap
thcipriani moved T162207: When "scap pull" does a (slow) CDB rebuild, it should tell me that that's what it's doing from Kanban to Next on the Release-Engineering-Team board.
Wed, Jul 5, 4:40 PM · Release-Engineering-Team (Next), Scap

Mon, Jul 3

thcipriani accepted D654: Remove concept of --no-touch / --beta-only-change.
Mon, Jul 3, 8:24 PM · Release-Engineering-Team
thcipriani requested changes to D654: Remove concept of --no-touch / --beta-only-change.
In D654#13833, @demon wrote:

Per pretty extensive IRC discussions, we're reasonably confident that T103886 is no longer an issue. That, coupled with the fact that this option is routinely underused means we're probably safe in dropping this option. Suggest accepting :)

Mon, Jul 3, 8:17 PM · Release-Engineering-Team
thcipriani committed rMSCA85cf3e8c935f: Don't update SHA1 for --service-restart or --dry-run (authored by thcipriani).
Don't update SHA1 for --service-restart or --dry-run
Mon, Jul 3, 7:50 PM
thcipriani closed T169141: Scap3 considers service restarts to be deploys as Resolved by committing rMSCA85cf3e8c935f: Don't update SHA1 for --service-restart or --dry-run.
Mon, Jul 3, 7:50 PM · Release-Engineering-Team (Kanban), Services (watching), Scap
thcipriani closed D700: Don't update SHA1 for --service-restart or --dry-run by committing rMSCA85cf3e8c935f: Don't update SHA1 for --service-restart or --dry-run.
Mon, Jul 3, 7:50 PM · Release-Engineering-Team

Thu, Jun 29

thcipriani accepted D698: Remove utils.deprecated_script().
Thu, Jun 29, 9:07 PM · Release-Engineering-Team
thcipriani added a comment to T153270: Gather requirements for new CI system.

Where did this happen?

Thu, Jun 29, 8:51 PM · Release-Engineering-Team (Kanban), Release Pipeline, releng-201617-q3
thcipriani closed D694: Run go fmt by committing rGBLBR56e09bc388d5: Run go fmt.
Thu, Jun 29, 8:47 PM · Release-Engineering-Team
thcipriani committed rGBLBR56e09bc388d5: Run go fmt (authored by thcipriani).
Run go fmt
Thu, Jun 29, 8:47 PM
thcipriani updated the diff for D694: Run go fmt.

Rebase

Thu, Jun 29, 8:44 PM · Release-Engineering-Team
thcipriani added inline comments to D700: Don't update SHA1 for --service-restart or --dry-run.
Thu, Jun 29, 5:57 PM · Release-Engineering-Team
thcipriani updated subscribers of T166348: Scribunto_LuaSandboxInterpreter::callFunction: LuaSandboxFunction::call returned false.

Looking at the logged data, it appears that there's some sort of a false positive in the luasandbox extension's recursion detection. I'm seeing it report the error when passing something as simple as [ "lang" => "ru" ].

I don't see any reason why it would false-positive though, unless it's possible for something to somehow throw an exception and exit from the middle of luasandbox_push_hashtable so it misses removing the entry from protectionSet, then later it happens to use the same pointer address for a different HashTable and hits the false-positive. Or unless IMPLEMENT_THREAD_LOCAL doesn't actually work.

Thu, Jun 29, 4:48 PM · Patch-For-Review, MediaWiki-extensions-Scribunto, Wikimedia-log-errors
thcipriani claimed T169141: Scap3 considers service restarts to be deploys.
Thu, Jun 29, 4:26 AM · Release-Engineering-Team (Kanban), Services (watching), Scap
thcipriani created D700: Don't update SHA1 for --service-restart or --dry-run.
Thu, Jun 29, 4:23 AM · Release-Engineering-Team
thcipriani added a revision to T169141: Scap3 considers service restarts to be deploys: D700: Don't update SHA1 for --service-restart or --dry-run.
Thu, Jun 29, 4:23 AM · Release-Engineering-Team (Kanban), Services (watching), Scap

Wed, Jun 28

thcipriani triaged T169141: Scap3 considers service restarts to be deploys as High priority.

I think the tl;dr is that scap tasks run from tin that do not run the promote stage should not change the DEPLOY_HEAD.

Wed, Jun 28, 10:03 PM · Release-Engineering-Team (Kanban), Services (watching), Scap

Tue, Jun 27

thcipriani added a project to T168597: Excluded vendor directory from lint tests when it is in an included extension: Continuous-Integration-Config.
Tue, Jun 27, 3:15 AM · Fundraising Sprint Murphy's Lawyer, Continuous-Integration-Config, Fundraising Sprint Loose Lego Carpeting, Fundraising Sprint Kickstopper, Fundraising Sprint Judgement Suspenders, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Gondwanaland Reunification Engine, FR-Email, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog
thcipriani updated the diff for D694: Run go fmt.

Change import style to jive with @dduvall 's suggestion

Tue, Jun 27, 12:54 AM · Release-Engineering-Team
thcipriani created D695: Escape newline chars in Docker output.
Tue, Jun 27, 12:08 AM · Release-Engineering-Team

Mon, Jun 26

thcipriani created D694: Run go fmt.
Mon, Jun 26, 7:23 PM · Release-Engineering-Team
thcipriani moved T167999: Escape Blubber config values when compiling to Dockerfile from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.
Mon, Jun 26, 4:37 PM · Release Pipeline (Blubber), Release-Engineering-Team (Kanban)

Sun, Jun 25

thcipriani updated subscribers of T131949: [Epic] Repeat the big English reader survey in one or two more languages .

Mentioned in SAL (#wikimedia-operations) [2017-06-22T19:31:55Z] <thcipriani@tin> Finished scap: SWAT: [[gerrit:360889|Translation updates for QuickSurveys]] T131949 (duration: 22m 10s)

This updated the translations for the survey buttons for (ar, hi, hu, ja, nl, ro)

It seems this didn't fix the issue. Users in rowiki are reporting that they still see the two buttons in English. I just tested the Arabic version and the issue persists there as well.

Sun, Jun 25, 3:36 PM · Research-Archive, Epic, Patch-For-Review