thcipriani (Tyler Cipriani)
Rappa Ternt RelEng

Projects (16)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 9 2015, 10:04 PM (144 w, 4 d)
Availability
Available
IRC Nick
thcipriani
LDAP User
Unknown
MediaWiki User
TCipriani (WMF)

Recent Activity

Today

thcipriani accepted D887: Various pylint fixes for arg.py.

Seems to work just fine, added a few thoughts inline.

Fri, Nov 17, 6:11 PM · Release-Engineering-Team
thcipriani accepted D883: Fix compile() mode.

Works in testing. python setup.py install works fine, scap version gives me the right thing:

Fri, Nov 17, 4:37 PM · Release-Engineering-Team
thcipriani accepted D885: Drop basestring check for terminal arguments.
Fri, Nov 17, 4:27 PM · Release-Engineering-Team

Yesterday

thcipriani accepted D884: iteritems() -> items() for Python 3 compat.
Thu, Nov 16, 11:09 PM · Release-Engineering-Team
thcipriani created P6335 (An Untitled Masterwork).
Thu, Nov 16, 10:27 PM
thcipriani added a comment to P6334 Blubber Debian package fail.
(/^ヮ^)/*:・゚✧ go install -v -p 1 -ldflags "-X phabricator.wikimedia.org/source/blubber/meta.Version=0.2.0 -X phabricator.wikimedia.org/source/blubber/meta.GitCommit=72fdd23" phabricator.wikimedia.org/source/blubber                                                                                                                            
phabricator.wikimedia.org/source/blubber/vendor/github.com/docker/distribution/digest                                                                                    
phabricator.wikimedia.org/source/blubber/vendor/github.com/docker/distribution/reference                                                                                 
phabricator.wikimedia.org/source/blubber/vendor/github.com/go-playground/locales/currency                                                                                
phabricator.wikimedia.org/source/blubber/vendor/github.com/go-playground/locales                                                                                         
phabricator.wikimedia.org/source/blubber/vendor/github.com/go-playground/universal-translator                                                                            
phabricator.wikimedia.org/source/blubber/vendor/gopkg.in/go-playground/validator.v9                                                                                      
phabricator.wikimedia.org/source/blubber/vendor/gopkg.in/yaml.v2                                                                                                         
phabricator.wikimedia.org/source/blubber/config                                                                                                                          
phabricator.wikimedia.org/source/blubber/docker                                                                                                                          
phabricator.wikimedia.org/source/blubber
Thu, Nov 16, 9:57 PM
thcipriani accepted D882: Use dep for dependency management and commit vendor.

WMF: was able to build a new debian package \o/

Thu, Nov 16, 8:43 PM · Release-Engineering-Team
thcipriani accepted D881: Move arcanist-go submodule from vendor to .arcvendor.
Thu, Nov 16, 5:18 PM · Release-Engineering-Team

Wed, Nov 15

thcipriani added a comment to D844: Require git >= 2.11 in debian package.
In D844#17543, @demon wrote:

Maybe we should just abandon this since we're going the "detect version and fail gracefully" route?

Wed, Nov 15, 5:47 PM · Release-Engineering-Team

Tue, Nov 14

thcipriani reassigned T180530: Use dep to manage vendor dependencies for blubber from thcipriani to dduvall.
Tue, Nov 14, 11:51 PM · Release-Engineering-Team (Kanban), Release Pipeline (Blubber)
thcipriani claimed T180530: Use dep to manage vendor dependencies for blubber.
Tue, Nov 14, 11:46 PM · Release-Engineering-Team (Kanban), Release Pipeline (Blubber)
thcipriani added a subtask for T179984: Update Debian package for Blubber: T180530: Use dep to manage vendor dependencies for blubber.
Tue, Nov 14, 9:09 PM · Release-Engineering-Team (Watching / External), Release Pipeline, Operations
thcipriani added a parent task for T180530: Use dep to manage vendor dependencies for blubber: T179984: Update Debian package for Blubber.
Tue, Nov 14, 9:09 PM · Release-Engineering-Team (Kanban), Release Pipeline (Blubber)
thcipriani triaged T180530: Use dep to manage vendor dependencies for blubber as Normal priority.
Tue, Nov 14, 9:07 PM · Release-Engineering-Team (Kanban), Release Pipeline (Blubber)
thcipriani created T180530: Use dep to manage vendor dependencies for blubber.
Tue, Nov 14, 9:06 PM · Release-Engineering-Team (Kanban), Release Pipeline (Blubber)
thcipriani committed rMSCA475c02516e6f: Correct action for no-log-message (authored by thcipriani).
Correct action for no-log-message
Tue, Nov 14, 3:47 PM
thcipriani committed rMSCAc79e396abecf: Bumping Debian version to 3.7.3-1 (authored by thcipriani).
Bumping Debian version to 3.7.3-1
Tue, Nov 14, 2:53 PM
thcipriani committed rMSCA59266da0f81f: Correct action for command line argument (authored by thcipriani).
Correct action for command line argument
Tue, Nov 14, 2:53 PM
thcipriani committed rMSCA0c3fec4f000b: Bump version to 3.7.3 (authored by thcipriani).
Bump version to 3.7.3
Tue, Nov 14, 2:53 PM

Mon, Nov 13

thcipriani added a comment to T179984: Update Debian package for Blubber.

debian/changelog in that package is wrongly formatted and hence package is currently unbuildable. See D875

Mon, Nov 13, 7:45 PM · Release-Engineering-Team (Watching / External), Release Pipeline, Operations
thcipriani committed rGBLBRddc3be9743b7: Add revisions in debian/changelog (authored by akosiaris).
Add revisions in debian/changelog
Mon, Nov 13, 7:33 PM
thcipriani closed D875: Add revisions in debian/changelog.
Mon, Nov 13, 7:33 PM · Release-Engineering-Team
thcipriani closed T179336: ORES deploy submodule 504 as Resolved.

The problem that this specific task deals with was fixed by removing the specific revision being deployed on the 1 target server that was affected. This may have been a weird interaction between scap and an ORES check https://github.com/wikimedia/mediawiki-services-ores-deploy/blob/master/scap/cmd_worker.sh#L4-L5

Mon, Nov 13, 6:01 PM · ORES, Scoring-platform-team, Release-Engineering-Team (Kanban), Scap
thcipriani accepted D877: Do not include Debian revision in version.py.
Mon, Nov 13, 3:52 PM · Release-Engineering-Team

Fri, Nov 10

thcipriani accepted D875: Add revisions in debian/changelog.
Fri, Nov 10, 2:49 PM · Release-Engineering-Team

Thu, Nov 9

thcipriani added a comment to T176747: When jenkins kills a build due to max execution time the docker containers stay running.

To document the discussion from IRC the other day, docker run requires --sig-proxy=true to proxy signals to running containers; however, --sig-proxy=true doesn't seem to work if a tty has been allocated. To get the stdout/stderr to output to console log while still proxying signals, the docker run command should be something like:

Thu, Nov 9, 4:06 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Continuous-Integration-Infrastructure (shipyard)
thcipriani added a comment to P6294 (An Untitled Masterwork).
(.venv)(/^ヮ^)/*:・゚✧ pip3 freeze
certifi==2017.11.5
chardet==3.0.4
docker==2.6.0
-e git+https://github.com/wikimedia/operations-docker-images-docker-pkg.git@287b719daedefa16bf04439c324aee44adacbade#egg=docker_pkg
docker-pycreds==0.2.1
idna==2.6
Jinja2==2.9.6
MarkupSafe==1.0
python-debian==0.1.31
PyYAML==3.12
requests==2.18.4
six==1.11.0
urllib3==1.22
websocket-client==0.44.0
Thu, Nov 9, 1:22 AM
thcipriani created P6294 (An Untitled Masterwork).
Thu, Nov 9, 1:20 AM

Wed, Nov 8

thcipriani closed T179966: Scap glitch on beta tin: no attribute "git_version" as Resolved.

Look like the fix got lost in the deb build pipeline somewhere. New scap version 3.6.0-1~20171108193833.232 should now be installed with this fix:

Wed, Nov 8, 8:17 PM · Release-Engineering-Team (Kanban), Scap
thcipriani committed rMSCA3e59e84e070c: Fix scap git test (authored by thcipriani).
Fix scap git test
Wed, Nov 8, 7:36 PM

Tue, Nov 7

thcipriani added a project to T179984: Update Debian package for Blubber: Release Pipeline.

adding @akosiaris and @Joe since they have the most background on Blubber: could one of you upload a new version of blubber to the apt repository/let me or @dduvall know if there are changes needed?

Tue, Nov 7, 9:25 PM · Release-Engineering-Team (Watching / External), Release Pipeline, Operations
thcipriani created T179984: Update Debian package for Blubber.
Tue, Nov 7, 9:24 PM · Release-Engineering-Team (Watching / External), Release Pipeline, Operations
thcipriani accepted D868: Validate configuration after unmarshalling.

awesome! LGTM.

Tue, Nov 7, 8:39 PM · Release-Engineering-Team
thcipriani committed rSCAPVAGRANT80f143e6011a: Update scap vagrant setup (authored by thcipriani).
Update scap vagrant setup
Tue, Nov 7, 4:35 PM
thcipriani closed D864: Update scap vagrant setup.
Tue, Nov 7, 4:31 PM · Release-Engineering-Team
thcipriani accepted D868: Validate configuration after unmarshalling.

Everything seems to work as intended, I have a few thoughts/questions inline about your intentions, but overall works well!

Tue, Nov 7, 12:49 AM · Release-Engineering-Team

Mon, Nov 6

thcipriani accepted D841: Documented all exported types, functions, and interfaces.
Mon, Nov 6, 9:18 PM · Release-Engineering-Team
thcipriani added a reverting commit for rMSCA5df545014065: Use sh library to wrap git commands.: rMSCAf708ac9dc910: Revert "Use sh library to wrap git commands.".
Mon, Nov 6, 8:55 PM
thcipriani committed rMSCAf708ac9dc910: Revert "Use sh library to wrap git commands." (authored by thcipriani).
Revert "Use sh library to wrap git commands."
Mon, Nov 6, 8:55 PM
thcipriani closed D870: Revert "Use sh library to wrap git commands.".
Mon, Nov 6, 8:54 PM · Release-Engineering-Team
thcipriani accepted D870: Revert "Use sh library to wrap git commands.".

Change caused a failure to deploy in beta cluster: https://www.irccloud.com/pastebin/aVkJJuka/

Mon, Nov 6, 8:53 PM · Release-Engineering-Team
thcipriani created D870: Revert "Use sh library to wrap git commands.".
Mon, Nov 6, 8:51 PM · Release-Engineering-Team
thcipriani added a comment to T179824: expired gpg key preventing new entries to releng pws.

Seems like he probably needs to extend the signing and encryption subkeys as you mention.

Mon, Nov 6, 3:46 PM · User-zeljkofilipin, Release-Engineering-Team (Kanban)

Wed, Nov 1

thcipriani accepted D867: Remove extra call to git.submodule_update.

Worked for me in testing. Logic seem sound.

Wed, Nov 1, 9:12 PM · Release-Engineering-Team
thcipriani added a comment to D866: Use sh library to wrap git commands..

couple random things from testing this morning.

Wed, Nov 1, 3:04 PM · Release-Engineering-Team

Tue, Oct 31

thcipriani added a comment to D864: Update scap vagrant setup.
In D864#17164, @demon wrote:

Works, but turns out a fresh provision was broken anyway by scap prep:

==> default: Cloning scap into the deployment directory
==> default: Setting up Rsync server
==> default: Cloning https://gerrit.wikimedia.org/r/operations/mediawiki-config to /srv/mediawiki-staging
==> default: Faking /etc/wikimedia-cluster
==> default: Setting up php-master mediawiki checkout
==> default: 23:54:20 Unhandled error:
==> default: Traceback (most recent call last):
==> default:   File "/srv/deployment/scap/scap/scap/cli.py", line 329, in run
==> default:     exit_status = app.main(app.extra_arguments)
==> default:   File "/srv/mediawiki-staging/scap/plugins/prep.py", line 93, in main
==> default:     old_branch = self.active_wikiversions().keys()[0]
==> default:   File "/srv/deployment/scap/scap/scap/cli.py", line 152, in active_wikiversions
==> default:     self.config['wmf_realm'], self.config['datacenter'])
==> default:   File "/srv/deployment/scap/scap/scap/utils.py", line 789, in get_active_wikiversions
==> default:     with open(path) as f:
==> default: IOError: [Errno 2] No such file or directory: '/srv/mediawiki/wikiversions.json'
==> default: 23:54:20 prep failed: <IOError> [Errno 2] No such file or directory: '/srv/mediawiki/wikiversions.json'
==> default: 
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.
Tue, Oct 31, 10:40 PM · Release-Engineering-Team
thcipriani accepted D860: New scap sayings.
Tue, Oct 31, 8:01 PM · Release-Engineering-Team
thcipriani awarded T157646: wfShellExec errors end up in HHVM log a Love token.
Tue, Oct 31, 6:05 PM · User-Tgr, Wikimedia-log-errors, MediaWiki-Debug-Logger
thcipriani updated the diff for D864: Update scap vagrant setup.

Sort packages correctly

Tue, Oct 31, 2:46 AM · Release-Engineering-Team
thcipriani added a comment to D864: Update scap vagrant setup.
In D864#17135, @Paladox wrote:

Is this the same as https://phabricator.wikimedia.org/D863 ? but includes extra's?

Tue, Oct 31, 2:42 AM · Release-Engineering-Team
thcipriani updated the diff for D864: Update scap vagrant setup.

Use bento/debian-9.2

Tue, Oct 31, 2:41 AM · Release-Engineering-Team
thcipriani accepted D845: Conform to all linter warnings/advice.

Ah docker conventions. Making things nicer :)

Tue, Oct 31, 12:08 AM · Release-Engineering-Team
thcipriani added a comment to D844: Require git >= 2.11 in debian package.

T179353: Scap: Standardize git version should resolve whether or not this can merge.

Tue, Oct 31, 12:03 AM · Release-Engineering-Team
thcipriani updated subscribers of T179353: Scap: Standardize git version.

Adding @MoritzMuehlenhoff explicitly since IIRC he did the work to add git 2.11 to jessie-backports.

Tue, Oct 31, 12:01 AM · Operations, Release-Engineering-Team (Watching / External), Scap

Mon, Oct 30

thcipriani created T179353: Scap: Standardize git version.
Mon, Oct 30, 11:59 PM · Operations, Release-Engineering-Team (Watching / External), Scap
thcipriani requested changes to D860: New scap sayings.

squish the risqué one on line 68 to keep us PG/PC, then LGTM.

Mon, Oct 30, 11:51 PM · Release-Engineering-Team
thcipriani accepted D857: Properly capitalize TERM as a constant in terminal.

deploy with fancy_progress: True worked for me.

Mon, Oct 30, 11:48 PM · Release-Engineering-Team
thcipriani removed 1 commit(s) for D857: Properly capitalize TERM as a constant in terminal: rOPUP218ab106cdf7: puppet: update hiera function call in horizon local_settings template.
Mon, Oct 30, 11:44 PM · Release-Engineering-Team
thcipriani accepted D497: Basic documentation for terminal ui.
Mon, Oct 30, 11:43 PM · Release-Engineering-Team
thcipriani created D864: Update scap vagrant setup.
Mon, Oct 30, 11:42 PM · Release-Engineering-Team
thcipriani added a comment to T179336: ORES deploy submodule 504.

In some fiddling I realized this error message is coming from phab and not tin.

Mon, Oct 30, 9:42 PM · ORES, Scoring-platform-team, Release-Engineering-Team (Kanban), Scap
thcipriani added a comment to T179336: ORES deploy submodule 504.

hrm. I was able to clone this locally on tin FWIW:

Mon, Oct 30, 8:54 PM · ORES, Scoring-platform-team, Release-Engineering-Team (Kanban), Scap
thcipriani added a comment to T179336: ORES deploy submodule 504.

A workaround over the short-term may be to use git_upstream_submodules: True in the scap.cfg file. This would cause a fetch of the submodules from whatever is in the .gitmodules file in the repo on tin. This means that any local changes on tin won't be reflected in the checkout on the targets, but hopefully this is a workaround that won't have to stay in place forever.

Mon, Oct 30, 8:46 PM · ORES, Scoring-platform-team, Release-Engineering-Team (Kanban), Scap
thcipriani created T179336: ORES deploy submodule 504.
Mon, Oct 30, 8:44 PM · ORES, Scoring-platform-team, Release-Engineering-Team (Kanban), Scap
thcipriani accepted D841: Documented all exported types, functions, and interfaces.

Inline typo, otherwise looks good!

Mon, Oct 30, 4:45 PM · Release-Engineering-Team

Thu, Oct 19

thcipriani accepted D822: Remove support for DOLOGMSGNOLOG environment variable.

wfm!

Thu, Oct 19, 9:20 PM · Release-Engineering-Team
thcipriani triaged T178454: Icinga disk space alert when a Docker container is running on an host as Normal priority.
Thu, Oct 19, 3:17 PM · Release Pipeline, Operations, monitoring, Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure (shipyard)
thcipriani added a comment to T178454: Icinga disk space alert when a Docker container is running on an host.

This also depends on the storage driver used. So we could use:

Thu, Oct 19, 3:17 PM · Release Pipeline, Operations, monitoring, Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure (shipyard)
thcipriani accepted D818: Include meta data as labels in Dockerfile output.

Looks good. Does what it says on the tin:

Thu, Oct 19, 2:24 PM · Release-Engineering-Team

Oct 18 2017

thcipriani accepted D816: Capture and expose build-time meta data.

nitpick inline, but seems to work in fine. Rebuilt the package and installed locally and all worked well.

Oct 18 2017, 8:41 PM · Release-Engineering-Team
thcipriani added a project to T178454: Icinga disk space alert when a Docker container is running on an host: Release Pipeline.
Oct 18 2017, 2:56 PM · Release Pipeline, Operations, monitoring, Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure (shipyard)
thcipriani claimed T177867: Pipeline image build cleanup.
Oct 18 2017, 2:56 PM · Release-Engineering-Team (Kanban), Release Pipeline
thcipriani reassigned T177954: Add experimental blubber test build/run to mathoid jenkins test pipeline from thcipriani to dduvall.

@dduvall already has a good start here, reassigning.

Oct 18 2017, 2:56 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Mathoid, Release Pipeline

Oct 17 2017

thcipriani added a comment to T178404: Beta: acme-setup failing in beta deployment-cache-upload04.

I don't know if this is related to the work on T174720: letsencrypt::cert::integrated and non-http servers but I added folks from that task here.

Oct 17 2017, 4:56 PM · Beta-Cluster-Infrastructure
thcipriani created T178404: Beta: acme-setup failing in beta deployment-cache-upload04.
Oct 17 2017, 4:55 PM · Beta-Cluster-Infrastructure
thcipriani created E762: Tyler Cipriani AFK.
Oct 17 2017, 2:19 PM · Release-Engineering-Team, events

Oct 16 2017

thcipriani accepted D817: Remove blacklisted variable name "bar".
Oct 16 2017, 8:42 PM · Release-Engineering-Team
thcipriani accepted D815: Fix various indentation/continuation errors.
Oct 16 2017, 8:28 PM · Release-Engineering-Team
thcipriani added a subtask for T157469: Mathoid CI Container Build: T175186: Blubber config input validation.
Oct 16 2017, 5:30 PM · Tracking, User-mobrovac, Release Pipeline
thcipriani added a parent task for T175186: Blubber config input validation: T157469: Mathoid CI Container Build.
Oct 16 2017, 5:30 PM · Release-Engineering-Team (Kanban), Release Pipeline (Blubber)
thcipriani claimed T177954: Add experimental blubber test build/run to mathoid jenkins test pipeline.
Oct 16 2017, 5:27 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Mathoid, Release Pipeline
thcipriani closed T175298: Secret storage on contint1001 for Docker registry password, a subtask of T176896: Establish secure way of passing registry credentials from Jenkins to Docker, as Resolved.
Oct 16 2017, 5:14 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release Pipeline
thcipriani closed T175298: Secret storage on contint1001 for Docker registry password as Resolved.
Oct 16 2017, 5:14 PM · Release-Engineering-Team (Next), Release Pipeline
thcipriani closed T173128: Find CI container build location as Resolved.
Oct 16 2017, 5:10 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Release Pipeline
thcipriani closed T173128: Find CI container build location, a subtask of T175297: Define new Jenkins pipeline for container build phase, as Resolved.
Oct 16 2017, 5:10 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Release Pipeline
thcipriani closed T176896: Establish secure way of passing registry credentials from Jenkins to Docker as Resolved.
Oct 16 2017, 5:09 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release Pipeline
thcipriani closed T176896: Establish secure way of passing registry credentials from Jenkins to Docker, a subtask of T175297: Define new Jenkins pipeline for container build phase, as Resolved.
Oct 16 2017, 5:09 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Release Pipeline
mmodell awarded D807: Key_name is None for some reason. a Evil Spooky Haunted Tree token.
Oct 16 2017, 2:39 PM · Release-Engineering-Team
thcipriani committed rMSCAe24871e7e2eb: Add php-cli to Debian suggests options (authored by thcipriani).
Add php-cli to Debian suggests options
Oct 16 2017, 1:41 PM
thcipriani committed rMSCA0919fd062008: Key_name is None for some reason. (authored by thcipriani).
Key_name is None for some reason.
Oct 16 2017, 1:41 PM
thcipriani closed D807: Key_name is None for some reason..
Oct 16 2017, 1:41 PM · Release-Engineering-Team
thcipriani closed D808: Add php-cli to Debian suggests options.
Oct 16 2017, 1:41 PM · Release-Engineering-Team

Oct 13 2017

thcipriani accepted D813: Consistently SHOUT AT PEOPLE FOR CONSTANTS.

Works for me

Oct 13 2017, 6:41 PM · Release-Engineering-Team
thcipriani updated the diff for D808: Add php-cli to Debian suggests options.

prefer php7 over hhvm

Oct 13 2017, 6:16 PM · Release-Engineering-Team
thcipriani closed T178039: scap should not pull in HHVM on stretch hosts using PHP7 as Resolved.

scap 3.7.1-1 is now live. php5-cli | hhvm | php-cli is now part of Suggests

Oct 13 2017, 6:05 PM · Operations, Scap
thcipriani added a comment to T177276: Unify production and CI docker image build process.
  • Tagging images with date instead of a semver versioning. I am dibated about this one: I do think having a changelog is *a good thing*, and we should explicitly track the history of changes in a docker image (even if it is just a new version of some checked-out repository). I can imagine there are cases where this makes sense, though, like an automated build process to create nightlys, but that can be scripted around for sure. @thcipriani what are your thoughts?
Oct 13 2017, 4:34 PM · Patch-For-Review, User-Joe, Operations, Continuous-Integration-Infrastructure (shipyard)

Oct 12 2017

thcipriani committed rMSCAbdd3ac47909d: Fix local variable 'search_path' referenced before assignment (authored by thcipriani).
Fix local variable 'search_path' referenced before assignment
Oct 12 2017, 9:19 PM
thcipriani closed D809: Fix local variable 'search_path' referenced before assignment.
Oct 12 2017, 9:19 PM · Release-Engineering-Team
thcipriani created D809: Fix local variable 'search_path' referenced before assignment.
Oct 12 2017, 9:16 PM · Release-Engineering-Team
thcipriani created D808: Add php-cli to Debian suggests options.
Oct 12 2017, 8:48 PM · Release-Engineering-Team