thiemowmde (Thiemo Kreuz (WMDE))
Software Developer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 11:45 AM (210 w, 3 d)
Availability
Available
IRC Nick
Thiemo_WMDE
LDAP User
Thiemo Kreuz (WMDE)
MediaWiki User
Thiemo Kreuz (WMDE) [ Global Accounts ]

Recent Activity

Yesterday

thiemowmde added a comment to T202295: Security review major redesign of the TwoColConflict extension.

The only dependency the extension does have is (literally) PHP itself:

"require": {
	"php": ">=5.5.9"
}

All other dependencies (Phan, PHP Parallel Lint, Grunt stuff) are dev-only dependencies. Are these a problem for what this security review is about?

Sat, Oct 20, 5:03 PM · Security-Reviews, Two-Column-Edit-Conflict-Merge, WMDE-QWERTY-Team, TCB-Team
thiemowmde added a comment to T202295: Security review major redesign of the TwoColConflict extension.

"Access Denied: Restricted Task". Sorry, there is really nothing I can do if I'm not allowed to know what you know.

Sat, Oct 20, 4:58 PM · Security-Reviews, Two-Column-Edit-Conflict-Merge, WMDE-QWERTY-Team, TCB-Team
thiemowmde added a comment to T202295: Security review major redesign of the TwoColConflict extension.

That's rather cryptic for people who don't have admin access to the https://github.com/wikimedia/mediawiki-extensions-TwoColConflict mirror (like most of us). Can you please share the details of this alert?

Sat, Oct 20, 4:52 PM · Security-Reviews, Two-Column-Edit-Conflict-Merge, WMDE-QWERTY-Team, TCB-Team

Fri, Oct 19

thiemowmde committed rESCCb740321bc33a: Streamline conflict header code (authored by thiemowmde).
Streamline conflict header code
Fri, Oct 19, 1:49 PM
thiemowmde committed rESCCaf33a3df8c3e: Fix CSS for Chrome on MacOS and Firefox with dark color scheme (authored by jkroll).
Fix CSS for Chrome on MacOS and Firefox with dark color scheme
Fri, Oct 19, 1:14 PM
thiemowmde committed rEWLEaa95f597967a: Add missing limits to explode() (authored by thiemowmde).
Add missing limits to explode()
Fri, Oct 19, 10:04 AM
thiemowmde committed rEWLE5275bdabd23c: Add missing limits to explode() (authored by thiemowmde).
Add missing limits to explode()
Fri, Oct 19, 8:26 AM

Wed, Oct 17

thiemowmde awarded T202295: Security review major redesign of the TwoColConflict extension a Love token.
Wed, Oct 17, 1:24 PM · Security-Reviews, Two-Column-Edit-Conflict-Merge, WMDE-QWERTY-Team, TCB-Team
thiemowmde committed rESCCfc1f7d26e6bf: Streamline fade-out effect CSS on collapsed text blocks (authored by thiemowmde).
Streamline fade-out effect CSS on collapsed text blocks
Wed, Oct 17, 1:24 PM

Tue, Oct 16

thiemowmde updated subscribers of T206956: Wikitext is displaced in Diff on de.wikipedia when Benutzer:TMg/cleanDiff.js is used.

@Schnark, I think I was able to fix it just a few minutes ago. Can you please try again?

Tue, Oct 16, 7:47 AM · User-thiemowmde
thiemowmde added a comment to T195714: Allow collapsing and uncollapsing not changed text blocks (js version) (No. 4).

Possible issues I see with the current collapsing algorithm:

  • Why are the lines cut off so early? There is plenty of room (depending on the window size). I would like to see more text.
  • The cut-off point does not dynamically respond to the browser in any way (window size, font size, zoom). This is a pity.
  • Why is the last line not right-aligned?
  • The three dots appear like they are part of the text. It's hard, sometimes impossible to tell the difference.
  • Shouldn't there be a space separating the dots from the text?
Tue, Oct 16, 7:45 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), WMDE-QWERTY-Sprint-2018-10-09, WMDE-QWERTY-Sprint-2018-09-25, Patch-For-Review, WMDE-QWERTY-Sprint-2018-08-14, Design, TCB-Team, WMDE-Design, Two-Column-Edit-Conflict-Merge, WMDE-QWERTY-Team
thiemowmde closed T206956: Wikitext is displaced in Diff on de.wikipedia when Benutzer:TMg/cleanDiff.js is used as Resolved.
Tue, Oct 16, 6:45 AM · User-thiemowmde

Mon, Oct 15

thiemowmde edited projects for T206956: Wikitext is displaced in Diff on de.wikipedia when Benutzer:TMg/cleanDiff.js is used, added: User-thiemowmde; removed TCB-Team, MediaWiki-History-or-Diffs.

Oh, that's my script. I'm very much interested in fixing it, if there is a problem.

Mon, Oct 15, 1:35 PM · User-thiemowmde

Fri, Oct 12

thiemowmde moved T206753: Use new helpNotice icon on WMDE extensions from Incoming to Revision Slider on the TCB-Team board.
Fri, Oct 12, 11:59 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), WMDE-QWERTY-Sprint-2018-10-09, Design, Revision-Slider, WMDE-Design, TCB-Team
thiemowmde set the point value for T206753: Use new helpNotice icon on WMDE extensions to 1.
Fri, Oct 12, 11:59 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), WMDE-QWERTY-Sprint-2018-10-09, Design, Revision-Slider, WMDE-Design, TCB-Team
thiemowmde assigned T206753: Use new helpNotice icon on WMDE extensions to Volker_E.

The icon was in a circle before, see https://commons.wikimedia.org/wiki/File:Revisionslider-screenshot-de-large.png. So the fact it became a stray "?" is technically a regression, and the patch technically a bugfix. I went ahead and merged it. Can easily be rolled back in case WMDE-Design doesn't agree.

Fri, Oct 12, 11:58 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), WMDE-QWERTY-Sprint-2018-10-09, Design, Revision-Slider, WMDE-Design, TCB-Team

Wed, Oct 10

thiemowmde committed rEFLIc02752f1af5c: Edit Project Config (authored by thiemowmde).
Edit Project Config
Wed, Oct 10, 4:12 PM
thiemowmde committed rEWBI8c319a68e29d: Remove unnecessary method overrides (authored by matthiasmullie).
Remove unnecessary method overrides
Wed, Oct 10, 2:18 PM
thiemowmde added a comment to T202053: Update headers of the conflicting versions.

Notes for @Andrew-WMDE and possibly WMDE-Design:

  • Linker::revUserTools is the function that combines the user and tools links in one call.
  • MediaWiki core provides messages for hours-ago, minutes-ago, and seconds-ago.
  • There is also an ago message we could use together with with the messages for days, weeks, months, and years. However, I suggest to not use these because conflicts that old are super-unlikely, but the code for this would be pretty complex. Instead, I would start showing the formatted date and time when a conflict happened more than 23 hours ago.
Wed, Oct 10, 2:09 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2018-10-09, WMDE-Design, TCB-Team, Design, Two-Column-Edit-Conflict-Merge

Tue, Oct 9

thiemowmde added a comment to T195721: Support JS enhanced editing on the merge view (No. 7).

While reviewing the browser tests for this, I run into a surprising UX issue. According to the specifications above the reset button (back arrow) only appears in edit mode. I totally expected the button to do what every other reset button I have seen so far does: discard the current edit. But it undoes all edits (to the same paragraph) I have done and saved before.

Tue, Oct 9, 11:31 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), WMDE-QWERTY-Sprint-2018-10-09, WMDE-QWERTY-Sprint-2018-09-25, Patch-For-Review, WMDE-QWERTY-Sprint-2018-08-29, Design, TCB-Team, WMDE-Design, Two-Column-Edit-Conflict-Merge, WMDE-QWERTY-Team
thiemowmde created T206526: Reduce copy-pasted <textarea> CSS to a maintainable subset.
Tue, Oct 9, 11:06 AM · TCB-Team, WMDE-QWERTY-Team, Two-Column-Edit-Conflict-Merge
thiemowmde committed rESCC5e678fc2970d: Invert toggleHelpDialog( hide ) to …( show ) (authored by thiemowmde).
Invert toggleHelpDialog( hide ) to …( show )
Tue, Oct 9, 10:39 AM

Mon, Oct 8

thiemowmde closed T206286: FileImporter tests are failing on PHP 7.1 as Resolved.
Mon, Oct 8, 9:21 AM · WMDE-QWERTY-Sprint-2018-09-25, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, TCB-Team, PHP 7.1 support, Move-Files-To-Commons
thiemowmde closed T206286: FileImporter tests are failing on PHP 7.1, a subtask of T204884: Run MediaWiki tests on PHP 7.3, as Resolved.
Mon, Oct 8, 9:21 AM · PHP 7.3 support, Core Platform Team Kanban (Doing), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), Continuous-Integration-Infrastructure
thiemowmde moved T206286: FileImporter tests are failing on PHP 7.1 from Sprint Backlog to Done on the WMDE-QWERTY-Sprint-2018-09-25 board.
Mon, Oct 8, 9:21 AM · WMDE-QWERTY-Sprint-2018-09-25, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, TCB-Team, PHP 7.1 support, Move-Files-To-Commons
thiemowmde added a project to T206286: FileImporter tests are failing on PHP 7.1: WMDE-QWERTY-Sprint-2018-09-25.
Mon, Oct 8, 9:20 AM · WMDE-QWERTY-Sprint-2018-09-25, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, TCB-Team, PHP 7.1 support, Move-Files-To-Commons
thiemowmde committed rEFLI5aff8e51149e: Fix non-numeric value in ApiDetailRetrieverTest (authored by thiemowmde).
Fix non-numeric value in ApiDetailRetrieverTest
Mon, Oct 8, 8:22 AM
thiemowmde claimed T206286: FileImporter tests are failing on PHP 7.1.
Mon, Oct 8, 7:54 AM · WMDE-QWERTY-Sprint-2018-09-25, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, TCB-Team, PHP 7.1 support, Move-Files-To-Commons
thiemowmde committed rEWBI2b9909a9a91e: Fix incomplete Property constructor in FilePageMediaInfoViewTest (authored by thiemowmde).
Fix incomplete Property constructor in FilePageMediaInfoViewTest
Mon, Oct 8, 7:47 AM
thiemowmde committed rEWBI154c04753de0: Fix incomplete Property constructor in FilePageMediaInfoViewTest (authored by thiemowmde).
Fix incomplete Property constructor in FilePageMediaInfoViewTest
Mon, Oct 8, 7:47 AM
thiemowmde added a project to T206100: Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeCompletionSearchTest fails on PHP 7.1: Elasticsearch.
Mon, Oct 8, 7:39 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata-Campsite, wikidata-tech-focus, Discovery-Search, Elasticsearch, PHP 7.1 support, Lexicographical data, Wikidata
thiemowmde added a project to T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1: Elasticsearch.
Mon, Oct 8, 7:39 AM · Discovery-Search (Current work), User-Addshore, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata-Campsite, wikidata-tech-focus, User-Smalyshev, Elasticsearch, PHP 7.1 support, Wikidata, MediaWiki-extensions-WikibaseRepository

Thu, Oct 4

thiemowmde committed rESCC5ee4ff375c6e: Wait for conflict JS to fully load (authored by WMDE-Fisch).
Wait for conflict JS to fully load
Thu, Oct 4, 12:51 PM

Fri, Sep 28

thiemowmde committed rESCC8ea26755f7be: Rewrite empty line handling in LineBasedUnifiedDiffFormatter (authored by thiemowmde).
Rewrite empty line handling in LineBasedUnifiedDiffFormatter
Fri, Sep 28, 5:23 PM
thiemowmde committed rEFLIab0fbbcf77ec: Add docs/wikitext-cleanup.md (authored by thiemowmde).
Add docs/wikitext-cleanup.md
Fri, Sep 28, 12:41 PM

Thu, Sep 27

thiemowmde committed rESCC3a18dca8da0e: Add link to README pointing to mediawiki.org (authored by thiemowmde).
Add link to README pointing to mediawiki.org
Thu, Sep 27, 2:20 PM
thiemowmde committed rEFLI216cd49aa390: Mention the option to cache HTTP requests in "throttling" docs (authored by thiemowmde).
Mention the option to cache HTTP requests in "throttling" docs
Thu, Sep 27, 1:32 PM
thiemowmde committed rEFLI164ae5e25666: Add links to on-wiki documentation to the README (authored by thiemowmde).
Add links to on-wiki documentation to the README
Thu, Sep 27, 1:32 PM
thiemowmde committed rEFLI5b6cb280e599: Add missing documentation for CommonsHelper configuration (authored by thiemowmde).
Add missing documentation for CommonsHelper configuration
Thu, Sep 27, 1:32 PM
thiemowmde committed rEFLIf434e874dd7d: Add missing documentation for CommonsHelper configuration (authored by thiemowmde).
Add missing documentation for CommonsHelper configuration
Thu, Sep 27, 1:31 PM
thiemowmde committed rESCC34a315a4e576: Make it possible to restart the tour once more (authored by thiemowmde).
Make it possible to restart the tour once more
Thu, Sep 27, 9:39 AM
thiemowmde committed rESCCcd10c398a9ef: Move buttons in OOUI popups into the $footer (authored by thiemowmde).
Move buttons in OOUI popups into the $footer
Thu, Sep 27, 9:31 AM
thiemowmde committed rESCCf173a9a3dc0a: Remove $… from variables that are not jQuery elements (authored by thiemowmde).
Remove $… from variables that are not jQuery elements
Thu, Sep 27, 9:26 AM

Wed, Sep 26

thiemowmde committed rESCC711aa071d8f6: Fixes and cleanups for the tour (authored by thiemowmde).
Fixes and cleanups for the tour
Wed, Sep 26, 4:05 PM
thiemowmde updated subscribers of T158739: Create a Github notification bot for phabricator.

WMDE, especially the WMDE-FUN-Team might be interested in this as well.

Wed, Sep 26, 1:12 PM · User-notice, Github-notif-bot, User-LokalProfil, WMSE

Tue, Sep 25

thiemowmde updated subscribers of T205379: intro tour popups resize when scrolling the page.

We had a quick chat with @Jan_Dittrich and concluded:

  • Making the popups wider (as already discussed in T203066) would make the problem occur less often.
  • We suggest to not mess with the scroll behavior, as this is a "standard" OOUI thing.
  • When the scrollbar appears, the only action item (the button) disappears at the bottom. Idea: Have the button outside of the scroll area so it's always visible. Does OOUI allow this?
Tue, Sep 25, 2:23 PM · WMDE-QWERTY-Sprint-2018-09-25, MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, OOUI, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde added a comment to T205379: intro tour popups resize when scrolling the page.

Note that with the investigation and bugfixes we plan to do for T203066: Fix the header overlapping the tour window these scrollbars will become much less of an issue.

Tue, Sep 25, 1:22 PM · WMDE-QWERTY-Sprint-2018-09-25, MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, OOUI, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde added a comment to T203066: Fix the header overlapping the tour window.

A little more investigation:

  • OOUI supports dialog (a.k.a. window) sizes "small" (300px), "medium" (500px), "large" (600px), "larger" (900px), and "full" (100%). Currently our code for the tour dialogs sets "large", but this is apparently ignored or not set correctly because the popups end up being 300px. Apparently this is an actual bug we should fix!
  • Using the $container option as described in https://www.mediawiki.org/wiki/OOUI/Widgets/Popups#containerExample sounds great. I will continue the investigation @jkroll started.
Tue, Sep 25, 1:21 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, WMDE-QWERTY-Sprint-2018-09-25, WMDE-QWERTY-Sprint-2018-09-13, WMDE-QWERTY-Sprint-2018-08-29, TCB-Team, Two-Column-Edit-Conflict-Merge, WMDE-QWERTY-Team
thiemowmde triaged T205379: intro tour popups resize when scrolling the page as Low priority.

I had a quick look and I believe this is all totally normal, expected behavior as defined by OOUI. Which of the 3 screenshots you think shows an actual issue, and what would be the expected behavior instead?

Tue, Sep 25, 1:06 PM · WMDE-QWERTY-Sprint-2018-09-25, MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, OOUI, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde added a project to T203066: Fix the header overlapping the tour window: WMDE-QWERTY-Sprint-2018-09-25.
Tue, Sep 25, 12:56 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, WMDE-QWERTY-Sprint-2018-09-25, WMDE-QWERTY-Sprint-2018-09-13, WMDE-QWERTY-Sprint-2018-08-29, TCB-Team, Two-Column-Edit-Conflict-Merge, WMDE-QWERTY-Team
thiemowmde moved T203066: Fix the header overlapping the tour window from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-09-13 board.
Tue, Sep 25, 12:56 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, WMDE-QWERTY-Sprint-2018-09-25, WMDE-QWERTY-Sprint-2018-09-13, WMDE-QWERTY-Sprint-2018-08-29, TCB-Team, Two-Column-Edit-Conflict-Merge, WMDE-QWERTY-Team
thiemowmde added a project to T202402: Consistent newline handling in the (editable) two column conflict view: WMDE-QWERTY-Sprint-2018-09-25.
Tue, Sep 25, 12:54 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), WMDE-QWERTY-Sprint-2018-09-25, WMDE-QWERTY-Sprint-2018-09-13, WMDE-QWERTY-Sprint-2018-08-29, Patch-For-Review, WMDE-QWERTY-Sprint-2018-08-14, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde added a project to T195713: Have an intro tour (No. 2): WMDE-QWERTY-Sprint-2018-09-25.
Tue, Sep 25, 12:54 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), WMDE-QWERTY-Sprint-2018-09-25, WMDE-QWERTY-Sprint-2018-09-13, WMDE-QWERTY-Sprint-2018-08-29, WMDE-QWERTY-Sprint-2018-08-14, Patch-For-Review, WMDE-QWERTY-Sprint-2018-07-31, Design, TCB-Team, WMDE-Design, Two-Column-Edit-Conflict-Merge, WMDE-QWERTY-Team
thiemowmde added a comment to T205386: Add loading animation when advanced parameters panel has not loaded yet.
NOTE: The default delay jQuery uses is 400ms, while the "fast" option is half of that, 200ms.
Tue, Sep 25, 9:40 AM · WMDE-FUN-Sprint-2018-09-17, TCB-Team, Advanced-Search
thiemowmde added a comment to T205391: Reduce number of loaded OOUI modules if possible.

I had a quick look at the ResourceLoader module definitions for OOjs, see https://phabricator.wikimedia.org/source/mediawiki/browse/master/resources/Resources.php$2805 and below. My brief impression:

  • The module "oojs" does have a scary name. It sounds like it loads the entirety of OOjs. But it doesn't.
  • The module "oojs-ui" is the big boy that contains all of "oojs-ui-core", "oojs-ui-widgets", "oojs-ui-toolbars", and "oojs-ui-windows". But this is not used in Advanced-Search, as far as I can see.
  • The "oojs-ui-widgets" module can not be split, because it's all in one file.
Tue, Sep 25, 9:34 AM · WMDE-FUN-Sprint-2018-09-17, TCB-Team, Advanced-Search

Mon, Sep 24

thiemowmde added a comment to T170526: Adjust vertical scale for a better resolution with big changes.

Even with the fixed .ods my biggest issues with this approach remain: All bars are smaller than before, and there is a huge spike that heavily exaggerates edits with 52 or more bytes, while edits with 51 or less bytes all look identical.

Mon, Sep 24, 2:23 PM · Patch-For-Review, Season of RevisionSlider, WMDE volunteer workboard, Revision-Slider, TCB-Team
thiemowmde added a project to T203373: Split and lazy-load initially not needed ResourceLoader modules: WMDE-Design.

There is an other performance metric, and that is how long the user sees this:

Mon, Sep 24, 10:42 AM · WMDE-Design, Design, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, WMDE-FUN-Sprint-2018-09-17, WMDE-FUN-Sprint-2018-09-03, Advanced-Search, TCB-Team

Fri, Sep 21

thiemowmde added a comment to T136105: Highlight revisions from the same user.

It's hard to describe the current behavior of the patch. It feels somewhat unpredictable. I think we had a very productive IRC session with @Gopavasanth yesterday and he will figure this out.

Fri, Sep 21, 1:28 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Season of RevisionSlider, TCB-Team, Revision-Slider

Sep 20 2018

thiemowmde added a comment to T170526: Adjust vertical scale for a better resolution with big changes.

I mapped the algorithms as graphs via LibreOffice Calc. It might be that I did something wrong, but this is what I get:

Sep 20 2018, 4:21 PM · Patch-For-Review, Season of RevisionSlider, WMDE volunteer workboard, Revision-Slider, TCB-Team
thiemowmde added a comment to T136105: Highlight revisions from the same user.

I tested with Firefox, and run into some issues, unfortunately:

Sep 20 2018, 3:49 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Season of RevisionSlider, TCB-Team, Revision-Slider

Sep 19 2018

thiemowmde added a comment to T144248: No RDF builder defined for data type time nor for value type bad in DispatchingValueSnakRdfBuilder::getValueBuilder.

the problem does appear to be the precision

Sep 19 2018, 1:29 PM · Regression, DataValues, Wikidata-Sprint-2016-09-21, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error
thiemowmde added projects to T144248: No RDF builder defined for data type time nor for value type bad in DispatchingValueSnakRdfBuilder::getValueBuilder: DataValues, Regression.

There are indeed coordinate values in the database the current code can not deserialize any more: https://www.wikidata.org/wiki/Special:Diff/135258698

Sep 19 2018, 9:17 AM · Regression, DataValues, Wikidata-Sprint-2016-09-21, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error

Sep 18 2018

thiemowmde triaged T204723: Normalize Wikimedia Commons file names via a ValueParser as Low priority.
Sep 18 2018, 2:37 PM · goodfirstbug, Need-volunteer, DataValues, MediaWiki-extensions-WikibaseRepository, Wikidata
thiemowmde created T204723: Normalize Wikimedia Commons file names via a ValueParser.
Sep 18 2018, 2:37 PM · goodfirstbug, Need-volunteer, DataValues, MediaWiki-extensions-WikibaseRepository, Wikidata
thiemowmde committed rEWBI25daf4d8b5fb: Relax outdated HistoryEntityAction constructor (authored by matthiasmullie).
Relax outdated HistoryEntityAction constructor
Sep 18 2018, 2:19 PM
thiemowmde committed rEWBI62498abd3a8a: Relax outdated HistoryEntityAction constructor (authored by matthiasmullie).
Relax outdated HistoryEntityAction constructor
Sep 18 2018, 1:06 PM
thiemowmde committed rEWLEa0a3a867083d: Relax outdated HistoryEntityAction constructor (authored by thiemowmde).
Relax outdated HistoryEntityAction constructor
Sep 18 2018, 12:41 PM
thiemowmde added a comment to T99664: [Bug] Diff does not show stored capitalisation of first letter.

In T99664#3848557I suggested to apply normalization to Wikimedia Commons file names before they are stored. This would solve a few related issues. Should I open a new ticket for this?

Sep 18 2018, 12:38 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), goodfirstbug, Need-volunteer, MediaWiki-extensions-WikibaseRepository, Patch-For-Review, Wikidata

Sep 14 2018

thiemowmde committed rESCC364665ea422c: Rework headers showing conflicting revision time and user name (authored by thiemowmde).
Rework headers showing conflicting revision time and user name
Sep 14 2018, 4:46 PM
thiemowmde committed rESCC11a69040f2dc: Rework headers showing conflicting revision time and user name (authored by thiemowmde).
Rework headers showing conflicting revision time and user name
Sep 14 2018, 1:55 PM
thiemowmde committed rEWLE9e3330ddf9f9: Relax outdated HistoryEntityAction constructor (authored by thiemowmde).
Relax outdated HistoryEntityAction constructor
Sep 14 2018, 11:16 AM
thiemowmde committed rEWLE24c048bdc8bf: Relax outdated HistoryEntityAction constructor (authored by thiemowmde).
Relax outdated HistoryEntityAction constructor
Sep 14 2018, 11:16 AM

Sep 13 2018

thiemowmde moved T203069: Release and deploy wikidiff2 v1.8.0 with changed signature from Doing to Sprint Backlog on the WMDE-QWERTY-Sprint-2018-08-29 board.
Sep 13 2018, 2:28 PM · WMDE-QWERTY-Sprint-2018-08-29, wikidiff2, WMDE-QWERTY-Team, MediaWiki-History-or-Diffs, TCB-Team
thiemowmde placed T203069: Release and deploy wikidiff2 v1.8.0 with changed signature up for grabs.
Sep 13 2018, 2:28 PM · WMDE-QWERTY-Sprint-2018-08-29, wikidiff2, WMDE-QWERTY-Team, MediaWiki-History-or-Diffs, TCB-Team

Sep 12 2018

thiemowmde committed rESCCef27e0ecb46b: Rework headers showing conflicting revision time and user name (authored by thiemowmde).
Rework headers showing conflicting revision time and user name
Sep 12 2018, 5:36 PM
thiemowmde committed rESCC091d3b7a328f: Narrow HtmlSplitConflictHeader to not rely on it's (only) user (authored by thiemowmde).
Narrow HtmlSplitConflictHeader to not rely on it's (only) user
Sep 12 2018, 5:36 PM

Sep 11 2018

thiemowmde committed rESCCcaececb5e295: Rework headers showing conflicting revision time and user name (authored by thiemowmde).
Rework headers showing conflicting revision time and user name
Sep 11 2018, 1:29 PM
thiemowmde added a comment to T203558: Push release tags.

I think tagging does not really need another review, when this was already done on the merged patches. However, I had a brief look and this looks good to me.

Sep 11 2018, 10:31 AM · MediaWiki-extensions-Variables
thiemowmde added a comment to T203980: Disallow use of @private and @protected using MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation.

Personally, I believe a @private annotation is a hint at a suboptimal architecture. However, having a @private annotation on an otherwise public method is clearly better than not having one. And extra bonus points for having a comment – that's super helpful!

Sep 11 2018, 10:27 AM · MediaWiki-Codesniffer
thiemowmde added a comment to T203312: Add sniff that preg_quote should not be used with 1 argument.

/…/ is the standard, and used in the majority of cases – unless there is a good reason to free the slash from being a special character. A typical example is something like /^http:\/\/\w+\/\w+\//, which is painful and often written as !^http://\w+/\w+/! instead. Alternative delimiters I see quite often in real-life code are !…! and @…@. I assume this is mostly because most developers don't know about the possibility to use {…}. Note this still allows to use the brackets as quantifiers, e.g. {1,2}, which is why I think this is the (almost, because it's uncommon) perfect delimiter.

Sep 11 2018, 9:52 AM · MediaWiki-Codesniffer

Sep 10 2018

thiemowmde added a comment to T195714: Allow collapsing and uncollapsing not changed text blocks (js version) (No. 4).

I would find it very confusing to […] scroll to the end […] and see the arrow facing down again, now having the feeling there is still more to see.

Sep 10 2018, 12:13 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), WMDE-QWERTY-Sprint-2018-10-09, WMDE-QWERTY-Sprint-2018-09-25, Patch-For-Review, WMDE-QWERTY-Sprint-2018-08-14, Design, TCB-Team, WMDE-Design, Two-Column-Edit-Conflict-Merge, WMDE-QWERTY-Team
thiemowmde updated subscribers of T195714: Allow collapsing and uncollapsing not changed text blocks (js version) (No. 4).

@Hanna_Petruschat_WMDE, please correct me if I'm wrong, but if I remember correctly the style guide asks us to not flip such expand/collapse arrows any more. See T187099#4015542 and T190147 from the Advanced-Search project.

Sep 10 2018, 11:21 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), WMDE-QWERTY-Sprint-2018-10-09, WMDE-QWERTY-Sprint-2018-09-25, Patch-For-Review, WMDE-QWERTY-Sprint-2018-08-14, Design, TCB-Team, WMDE-Design, Two-Column-Edit-Conflict-Merge, WMDE-QWERTY-Team
thiemowmde added a comment to T202053: Update headers of the conflicting versions.

This is really awesome, thank you very much! I think the addition of the summary lines is very helpful, as well as the additional user links.

Sep 10 2018, 11:13 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2018-10-09, WMDE-Design, TCB-Team, Design, Two-Column-Edit-Conflict-Merge

Sep 7 2018

thiemowmde added a comment to T203800: Add sniff to replace !! by explicit boolean cast (bool).

I support the idea for PHP. From my experience, I can't think of a reason to ever use !! in PHP. So as long as it's an auto-fix sniff, go for it.

Sep 7 2018, 8:27 PM · MediaWiki-Codesniffer

Sep 5 2018

thiemowmde committed rESCCce1b2884e662: Reduce InlineTwoColConflictHelper code referencing WikiPage (authored by thiemowmde).
Reduce InlineTwoColConflictHelper code referencing WikiPage
Sep 5 2018, 3:19 PM
thiemowmde committed rESCC770503e7ab59: Narrow HtmlSplitConflictHeader to not rely on it's (only) user (authored by thiemowmde).
Narrow HtmlSplitConflictHeader to not rely on it's (only) user
Sep 5 2018, 3:19 PM
thiemowmde committed rESCCc9ffcafa046e: Narrow HtmlSplitConflictHeader to not rely on it's (only) user (authored by thiemowmde).
Narrow HtmlSplitConflictHeader to not rely on it's (only) user
Sep 5 2018, 3:05 PM
thiemowmde committed rESCC7955d3ce5c44: Make use of SpecialPageHtmlFragment in another class (authored by thiemowmde).
Make use of SpecialPageHtmlFragment in another class
Sep 5 2018, 12:15 PM
thiemowmde committed rESCC038a120aafaf: Make use of SpecialPageHtmlFragment in another class (authored by thiemowmde).
Make use of SpecialPageHtmlFragment in another class
Sep 5 2018, 12:15 PM
thiemowmde committed rESCCc04cc3b687bd: Add abstract SpecialPageHtmlFragment and start using it (authored by thiemowmde).
Add abstract SpecialPageHtmlFragment and start using it
Sep 5 2018, 12:15 PM
thiemowmde committed rESCC7ce00714c356: Streamline construction of the two …ConflictHelper factories (authored by thiemowmde).
Streamline construction of the two …ConflictHelper factories
Sep 5 2018, 12:15 PM
thiemowmde committed rESCCf27ed6d8a86f: Streamline construction of the two …ConflictHelper factories (authored by thiemowmde).
Streamline construction of the two …ConflictHelper factories
Sep 5 2018, 12:15 PM
thiemowmde committed rESCC224d8fd9a9f2: Stop forwarding from the simulation special page to the real page (authored by thiemowmde).
Stop forwarding from the simulation special page to the real page
Sep 5 2018, 12:15 PM
thiemowmde committed rESCCedfba6ad7eaa: Make use of SpecialPageHtmlFragment in another class (authored by thiemowmde).
Make use of SpecialPageHtmlFragment in another class
Sep 5 2018, 10:50 AM
thiemowmde committed rESCCb1976fe6c83b: Add abstract SpecialPageHtmlFragment and start using it (authored by thiemowmde).
Add abstract SpecialPageHtmlFragment and start using it
Sep 5 2018, 10:25 AM
thiemowmde committed rESCCc18eaa758418: Remove die() from HtmlPreview (authored by thiemowmde).
Remove die() from HtmlPreview
Sep 5 2018, 10:22 AM
thiemowmde committed rESCC3d68af36b6c8: Document all getHtml methods to @return HTML (authored by thiemowmde).
Document all getHtml methods to @return HTML
Sep 5 2018, 10:17 AM
thiemowmde committed rESCCae59ad345969: Add newlines to structure PHPDoc tags into groups (authored by thiemowmde).
Add newlines to structure PHPDoc tags into groups
Sep 5 2018, 10:17 AM
thiemowmde committed rESCC7b1f85104b11: Streamline construction of the two …ConflictHelper factories (authored by thiemowmde).
Streamline construction of the two …ConflictHelper factories
Sep 5 2018, 8:28 AM

Sep 4 2018

thiemowmde committed rESCC8f338a2499c3: Stop forwarding from the simulation special page to the real page (authored by thiemowmde).
Stop forwarding from the simulation special page to the real page
Sep 4 2018, 3:06 PM