Page MenuHomePhabricator

thiemowmde (Thiemo Kreuz (WMDE))
Senior Software Engineer

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 11:45 AM (492 w, 5 d)
Availability
Available
IRC Nick
Thiemo_WMDE
LDAP User
Thiemo Kreuz (WMDE)
MediaWiki User
Thiemo Kreuz (WMDE) [ Global Accounts ]

Recent Activity

Today

thiemowmde closed T202304: Mobile diff does not show the cutting points between two diffs as Resolved.

Looks like there are in the visual diffs now at exactly the points where we missed them before.

Tue, Mar 19, 6:22 AM · MediaWiki-Page-diffs, Design, patch-welcome, wikidiff2, Mobile

Fri, Mar 15

thiemowmde moved T358652: Investigate unit test coverage of Cite visual editor JS from Doing to Tech Review on the WMDE-TechWish-Sprint-2024-03-13 board.
Fri, Mar 15, 1:24 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-03-13, Patch-For-Review, Test-Coverage, WMDE-TechWish-Sprint-2024-02-28, WMDE-References-FocusArea, Cite, VisualEditor
thiemowmde renamed T334073: Investigation: Autonaming of references in VE from Autonaming of references in VE to Investigation: Autonaming of references in VE.
Fri, Mar 15, 10:57 AM · Epic, WMDE-TechWish-Sprint-2023-05-03, WMDE-TechWish-Sprint-2023-04-19, WMDE-TechWish-Sprint-2023-04-05, WMDE-References-FocusArea
thiemowmde moved T247922: Display parent references of subreferences in the VE pop up and wizard from In progress to Ready for pickup on the WMDE-References-FocusArea board.
Fri, Mar 15, 10:56 AM · MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), WMDE-TechWish-Sprint-2023-05-03, WMDE-TechWish-Sprint-2023-04-19, WMDE-References-FocusArea, WMDE-TechWish, Cite-Extends
thiemowmde moved T247921: Ensure subreferences displayed in VE are visually consistent with read mode from In progress to Ready for pickup on the WMDE-References-FocusArea board.
Fri, Mar 15, 10:56 AM · WMDE-TechWish-Sprint-2023-05-03, WMDE-TechWish-Sprint-2023-04-19, WMDE-References-FocusArea, WMDE-TechWish, Cite-Extends
thiemowmde moved T336874: Configure a VE citation template for docker-dev from In progress to Ready for pickup on the WMDE-References-FocusArea board.
Fri, Mar 15, 10:55 AM · WMDE-References-FocusArea, WMDE-TechWish-Sprint-2023-05-03
thiemowmde moved T245299: Sub-reference support in VE from In progress to Watching on the WMDE-References-FocusArea board.
Fri, Mar 15, 10:54 AM · WMDE-TechWish-Sprint-2023-05-03, Epic, WMDE-References-FocusArea, Cite-Extends, Editing-team (Tracking), VisualEditor
thiemowmde archived WMDE-TechWish-Sprint-2024-02-28.
Fri, Mar 15, 10:12 AM
thiemowmde moved T357125: Scraper: handle references produced at the top level of a template from Incoming to In progress on the WMDE-References-FocusArea board.
Fri, Mar 15, 10:11 AM · WMDE-TechWish-Sprint-2024-03-13, WMDE-TechWish-Sprint-2024-02-28, WMDE-References-FocusArea, WMDE-TechWish-Maintenance
thiemowmde moved T357613: Measure the reference use and re-use in VE from Incoming to In progress on the WMDE-References-FocusArea board.
Fri, Mar 15, 10:11 AM · WMDE-TechWish-Sprint-2024-03-13, WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Sprint-2024-02-15, WMDE-References-FocusArea
thiemowmde moved T358652: Investigate unit test coverage of Cite visual editor JS from Incoming to In progress on the WMDE-References-FocusArea board.
Fri, Mar 15, 10:10 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-03-13, Patch-For-Review, Test-Coverage, WMDE-TechWish-Sprint-2024-02-28, WMDE-References-FocusArea, Cite, VisualEditor
thiemowmde moved T358657: Create a basic end to end test for adding a reference in VisualEditor using templates from Incoming to In progress on the WMDE-References-FocusArea board.
Fri, Mar 15, 10:10 AM · Patch-For-Review, WMDE-TechWish-Sprint-2024-03-13, WMDE-TechWish-Sprint-2024-02-28, WMDE-References-FocusArea, Cite, VisualEditor
thiemowmde moved T358851: Cleanup end to end test setup in the Cite extension from Incoming to In progress on the WMDE-References-FocusArea board.
Fri, Mar 15, 10:10 AM · Patch-For-Review, WMDE-TechWish-Sprint-2024-03-13, WMDE-TechWish-Sprint-2024-02-28, WMDE-References-FocusArea, Cite

Thu, Mar 14

thiemowmde added a comment to T359082: Kartographer not night mode friendly.

Serious question: The black rectangles on the bright map look somewhat misplaced to me. I mean, the map is not inverted, and probably shouldn't. The footer with the license information is not inverted as well. Why the buttons? Wouldn't it be better to stick to bright buttons in this situation, i.e. exclude them from dark mode?

Thu, Mar 14, 8:01 PM · FY2023-24-WE 2.1 Typography and palette customizations, Maps (Kartographer)
thiemowmde added a comment to T359943: Can't unset the group of a <ref>/<references> list in VisualEditor.

My understanding is that the mw data structure with its body and attrs is a 1:1 representation of what can be seen in the wikitext. We know the attribute was always called <ref group="…">. From what I have seen Parsoid just passes this along. Because of this I'm relatively sure this was really a copy-paste mistake. I suspect the feature (removing a group) is just never used, or used so rarely that it never made it into a bug report. The effect is also quite confusing. The user probably thinks they made a mistake.

Thu, Mar 14, 5:20 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-03-13, Unplanned-Sprint-Work, VisualEditor-MediaWiki-References, VisualEditor-VisualDiffs, WMDE-TechWish-Sprint-2024-02-28, WMDE-References-FocusArea, VisualEditor
thiemowmde added a comment to T335129: Check different formating of references on wikis.

I had a closer look at the remaining messages.

Thu, Mar 14, 4:47 PM · Cite, WMDE-References-FocusArea
thiemowmde edited projects for T267580: QINU issue occurs when Lua module modifies text that contains a Cite reference, added: MediaWiki-Parser; removed I18n.

These UNIQ--ref-00000002-QINU sequences are temporary placeholders for multipass parsing. They start with what's called MARKER_PREFIX in the code, followed by the tag name "ref" and an 8-digit sequence number. The sequence number in the example just happens to be 2. That's why it's unaffected when the other digits are replaced.

Thu, Mar 14, 3:29 PM · MediaWiki-Parser, Scribunto, Cite
thiemowmde added a comment to T360034: Confusing cursor key navigation in VE reference re-use dialog due to missing highlighting.

Here is a before vs. after comparison for the patch https://gerrit.wikimedia.org/r/1010895.

Screenshot from 2024-03-13 15-11-52.png (451×653 px, 36 KB)

Thu, Mar 14, 9:01 AM · VisualEditor, Patch-For-Review, Regression, WMDE-References-FocusArea, VisualEditor-MediaWiki-References
thiemowmde added a project to T360026: Skip and then fix flapping reuseRefs tests: ci-test-error.

For reference, here is where I have seen this:
https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/87601/console
https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/87887/console

Thu, Mar 14, 8:59 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), ci-test-error, WMDE-TechWish-Sprint-2024-03-13, Patch-For-Review, WMDE-TechWish-Sprint-2024-02-28, VisualEditor, WMDE-References-FocusArea, Cite
thiemowmde closed T356858: Create a first set of end to end test for reference re-use in VE as Resolved.

Whoops., sorry, T360026 already exists.

Thu, Mar 14, 8:57 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Sprint-2024-02-15, WMDE-TechWish-Sprint-2024-01-31, VisualEditor, WMDE-References-FocusArea, Cite
thiemowmde closed T356858: Create a first set of end to end test for reference re-use in VE, a subtask of T358212: Improve test coverage for the reference usage in VisualEditor, as Resolved.
Thu, Mar 14, 8:56 AM · WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Sprint-2024-02-15, WMDE-References-FocusArea, Citoid, Cite, VisualEditor
thiemowmde reopened T356858: Create a first set of end to end test for reference re-use in VE as "Open".

More failures: https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/87887/console. That's not good. Should we create a new ticket for this or is it ok to consider this one at least partially unfinished?

Thu, Mar 14, 8:49 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Sprint-2024-02-15, WMDE-TechWish-Sprint-2024-01-31, VisualEditor, WMDE-References-FocusArea, Cite
thiemowmde added projects to T356858: Create a first set of end to end test for reference re-use in VE: WMDE-TechWish-Sprint-2024-03-13, ci-test-error.
Thu, Mar 14, 8:48 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Sprint-2024-02-15, WMDE-TechWish-Sprint-2024-01-31, VisualEditor, WMDE-References-FocusArea, Cite
thiemowmde reopened T356858: Create a first set of end to end test for reference re-use in VE, a subtask of T358212: Improve test coverage for the reference usage in VisualEditor, as Open.
Thu, Mar 14, 8:48 AM · WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Sprint-2024-02-15, WMDE-References-FocusArea, Citoid, Cite, VisualEditor
thiemowmde moved T359943: Can't unset the group of a <ref>/<references> list in VisualEditor from Tech Review to Demo on the WMDE-TechWish-Sprint-2024-03-13 board.
Thu, Mar 14, 8:45 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-03-13, Unplanned-Sprint-Work, VisualEditor-MediaWiki-References, VisualEditor-VisualDiffs, WMDE-TechWish-Sprint-2024-02-28, WMDE-References-FocusArea, VisualEditor

Wed, Mar 13

thiemowmde created T360034: Confusing cursor key navigation in VE reference re-use dialog due to missing highlighting.
Wed, Mar 13, 2:10 PM · VisualEditor, Patch-For-Review, Regression, WMDE-References-FocusArea, VisualEditor-MediaWiki-References
thiemowmde added a project to T352169: Unexpected click behavior on RTL wikis with browser zoom >100%: User-notice.

Quick proposal for the TechNews:

Wed, Mar 13, 1:31 PM · User-notice, Patch-For-Review, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Sprint-2024-02-15, WMDE-TechWish-Sprint-2023-11-22, Regression, WMDE-TechWish-Maintenance, Revision-Slider

Tue, Mar 12

thiemowmde added a comment to T356858: Create a first set of end to end test for reference re-use in VE.

Oh no. I see the new test failing in unrelated repositories, e.g. https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/87601/console.

Tue, Mar 12, 5:09 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Sprint-2024-02-15, WMDE-TechWish-Sprint-2024-01-31, VisualEditor, WMDE-References-FocusArea, Cite
thiemowmde claimed T359943: Can't unset the group of a <ref>/<references> list in VisualEditor.
Tue, Mar 12, 2:47 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-03-13, Unplanned-Sprint-Work, VisualEditor-MediaWiki-References, VisualEditor-VisualDiffs, WMDE-TechWish-Sprint-2024-02-28, WMDE-References-FocusArea, VisualEditor
thiemowmde added a project to T359943: Can't unset the group of a <ref>/<references> list in VisualEditor: Unplanned-Sprint-Work.
Tue, Mar 12, 2:46 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-03-13, Unplanned-Sprint-Work, VisualEditor-MediaWiki-References, VisualEditor-VisualDiffs, WMDE-TechWish-Sprint-2024-02-28, WMDE-References-FocusArea, VisualEditor
thiemowmde moved T359943: Can't unset the group of a <ref>/<references> list in VisualEditor from Incoming to In progress on the WMDE-References-FocusArea board.
Tue, Mar 12, 2:46 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-03-13, Unplanned-Sprint-Work, VisualEditor-MediaWiki-References, VisualEditor-VisualDiffs, WMDE-TechWish-Sprint-2024-02-28, WMDE-References-FocusArea, VisualEditor
thiemowmde created T359943: Can't unset the group of a <ref>/<references> list in VisualEditor.
Tue, Mar 12, 2:44 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-03-13, Unplanned-Sprint-Work, VisualEditor-MediaWiki-References, VisualEditor-VisualDiffs, WMDE-TechWish-Sprint-2024-02-28, WMDE-References-FocusArea, VisualEditor
thiemowmde removed a project from T352169: Unexpected click behavior on RTL wikis with browser zoom >100%: Desktop Improvements (Vector 2022).
Tue, Mar 12, 1:18 PM · User-notice, Patch-For-Review, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Sprint-2024-02-15, WMDE-TechWish-Sprint-2023-11-22, Regression, WMDE-TechWish-Maintenance, Revision-Slider
thiemowmde added a comment to T176885: Mediawiki CodeSniffer MediaWiki.Classes.UnusedUseStatement.UnusedUse does not recognize Annotations.

make the list of docblock tags that reference class names configurable […]

Tue, Mar 12, 12:23 PM · MediaWiki-Codesniffer
thiemowmde updated the task description for T352676: Replace underscores with dashes in all cite_error_… and cite_warning_… messages.
Tue, Mar 12, 9:20 AM · Patch-For-Review, I18n, Technical-Debt, WMDE-TechWish-Maintenance, Cite
thiemowmde merged task T26600: Cite: 'Cite error references missing key' not properly invoked into T269531: Define a named ref in <references> without using this named ref results into a wrong error message.
Tue, Mar 12, 9:16 AM · Cite
thiemowmde merged T26600: Cite: 'Cite error references missing key' not properly invoked into T269531: Define a named ref in <references> without using this named ref results into a wrong error message.
Tue, Mar 12, 9:16 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Maintenance, WMDE-References-FocusArea, Cite
thiemowmde updated the task description for T335189: Investigation: When do Cite errors appear? (Scraper).
Tue, Mar 12, 9:12 AM · WMDE-TechWish-Sprint-2023-05-03, WMDE-TechWish-Sprint-2023-04-19, WMDE-References-FocusArea
thiemowmde added a comment to T332022: [Epic] Undeploying StructuredDiscussions (Flow).

Can I somehow help pushing this forward? The Flow boards on wikis like mediawiki.org are currently heavily hit by spam bots. This is especially frustrating when the bots do exclusive Flow actions like editing the same topic summary over and over again. While this can be undone it's clumsy and frustrating as it is – by the nature of the separated Flow databases – not fully integrated into the normal MediaWiki workflows. And then there is this: T309941: IPInfo refuses to show IP informations if IP made only Flow modifications.

Tue, Mar 12, 8:34 AM · Epic, StructuredDiscussions, DiscussionTools, Editing-team, Growth-Team
thiemowmde merged T358759: IPInfo claims no edit was made from an IP that made edits into T309941: IPInfo refuses to show IP informations if IP made only Flow modifications.
Tue, Mar 12, 8:27 AM · StructuredDiscussions, Growth-Team, IP Info
thiemowmde merged task T358759: IPInfo claims no edit was made from an IP that made edits into T309941: IPInfo refuses to show IP informations if IP made only Flow modifications.
Tue, Mar 12, 8:26 AM · StructuredDiscussions, Growth-Team, IP Info

Mon, Mar 11

thiemowmde committed rEDKMa562f2971176: Fix double negotiation in ext.DarkMode.js (authored by thiemowmde).
Fix double negotiation in ext.DarkMode.js
Mon, Mar 11, 8:12 PM
thiemowmde archived WMDE-TechWish-Sprint-2024-02-15.
Mon, Mar 11, 9:53 AM

Thu, Mar 7

thiemowmde added projects to T358573: PHP Warning: Illegal offset type: WMDE-TechWish-Sprint-2024-02-28, Unplanned-Sprint-Work.
Thu, Mar 7, 5:12 PM · Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-02-28, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Maps (Kartographer), Parsoid, Wikimedia-production-error
thiemowmde moved T358573: PHP Warning: Illegal offset type from Sprint Backlog to Done on the WMDE-TechWish-Sprint-2024-02-28 board.
Thu, Mar 7, 5:11 PM · Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-02-28, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Maps (Kartographer), Parsoid, Wikimedia-production-error
thiemowmde added a project to T359290: ArgumentCountError: Too few arguments to function MediaWiki\Extension\Gadgets\GadgetRepo::titleWithoutPrefix(), 1 passed in /srv/mediawiki/php-1.42.0-wmf.21/extensions/Gadgets/includes/GadgetResourceLoaderModule.php on line 80 : Unplanned-Sprint-Work.
Thu, Mar 7, 5:11 PM · Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-02-28, MediaWiki-Platform-Team (Radar), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-extensions-Gadgets, Wikimedia-production-error
thiemowmde added a project to T359290: ArgumentCountError: Too few arguments to function MediaWiki\Extension\Gadgets\GadgetRepo::titleWithoutPrefix(), 1 passed in /srv/mediawiki/php-1.42.0-wmf.21/extensions/Gadgets/includes/GadgetResourceLoaderModule.php on line 80 : WMDE-TechWish-Sprint-2024-02-28.
Thu, Mar 7, 5:09 PM · Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-02-28, MediaWiki-Platform-Team (Radar), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-extensions-Gadgets, Wikimedia-production-error
thiemowmde added a comment to T333336: Kartographer's marker title tooltips show SGML entities (&amp; &lt; &gt; &#...;).

Minimal example:

<maplink>
{
  "type": "Feature",
  "geometry": { "coordinates": [ 0, 0 ], "type": "Point" },
  "properties": { "title": "[[File:Profil A.jpg|50px]] & B", "marker-symbol": "water" }
}
</maplink>
Thu, Mar 7, 10:25 AM · Maps (Kartographer)
thiemowmde claimed T358652: Investigate unit test coverage of Cite visual editor JS.
Thu, Mar 7, 8:51 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-03-13, Patch-For-Review, Test-Coverage, WMDE-TechWish-Sprint-2024-02-28, WMDE-References-FocusArea, Cite, VisualEditor
thiemowmde moved T358652: Investigate unit test coverage of Cite visual editor JS from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2024-02-28 board.
Thu, Mar 7, 8:51 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-03-13, Patch-For-Review, Test-Coverage, WMDE-TechWish-Sprint-2024-02-28, WMDE-References-FocusArea, Cite, VisualEditor

Wed, Mar 6

thiemowmde moved T269531: Define a named ref in <references> without using this named ref results into a wrong error message from In progress to Done on the WMDE-References-FocusArea board.
Wed, Mar 6, 1:43 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Maintenance, WMDE-References-FocusArea, Cite
thiemowmde updated the task description for T357613: Measure the reference use and re-use in VE.
Wed, Mar 6, 1:37 PM · WMDE-TechWish-Sprint-2024-03-13, WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Sprint-2024-02-15, WMDE-References-FocusArea
thiemowmde added a comment to T359290: ArgumentCountError: Too few arguments to function MediaWiki\Extension\Gadgets\GadgetRepo::titleWithoutPrefix(), 1 passed in /srv/mediawiki/php-1.42.0-wmf.21/extensions/Gadgets/includes/GadgetResourceLoaderModule.php on line 80 .

I believe https://gerrit.wikimedia.org/r/1009213 is the most minimal patch possible. Either that or reverting https://gerrit.wikimedia.org/r/981622 as a quick workaround, if that's still possible, and re-applying it later.

Wed, Mar 6, 10:15 AM · Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-02-28, MediaWiki-Platform-Team (Radar), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-extensions-Gadgets, Wikimedia-production-error

Tue, Mar 5

thiemowmde moved T352984: "Undefined index: content" error in FileImporter/src/Data/TextRevision.php:62 from Tech Review to Demo on the WMDE-TechWish-Sprint-2024-02-28 board.
Tue, Mar 5, 9:54 AM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-02-28, Regression, WMDE-TechWish-Maintenance, Wikimedia-production-error, Move-Files-To-Commons
thiemowmde added a comment to T354215: Move Parsoid's Cite implementation to the Cite repository.

@MSantos, just some code clean ups I couldn't find a better task for. 😇️ Totally optional.

Tue, Mar 5, 8:51 AM · MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), Patch-For-Review, WMDE-TechWish-Sprint-2024-01-17, Content-Transform-Team-WIP, Essential-Work, WMDE-References-FocusArea, WMDE-TechWish, Cite, Parsoid

Mon, Mar 4

thiemowmde claimed T269531: Define a named ref in <references> without using this named ref results into a wrong error message.
Mon, Mar 4, 12:08 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Maintenance, WMDE-References-FocusArea, Cite
thiemowmde moved T269531: Define a named ref in <references> without using this named ref results into a wrong error message from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2024-02-28 board.
Mon, Mar 4, 12:07 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Maintenance, WMDE-References-FocusArea, Cite
thiemowmde added a comment to T354239: rendering of <mapframe> (karthographer) is corrupt when width="100%".

For reference, here is a direct comparison of the old 800px vs. the new 1024px setting. It's not a massive improvement, but already better.

Screenshot from 2024-01-08 11-45-39.png (901×1 px, 761 KB)

Mon, Mar 4, 10:41 AM · MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), WMDE-GeoInfo-FocusArea, Maps (Kartographer)
thiemowmde added a project to T352984: "Undefined index: content" error in FileImporter/src/Data/TextRevision.php:62: Regression.
Mon, Mar 4, 10:22 AM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-02-28, Regression, WMDE-TechWish-Maintenance, Wikimedia-production-error, Move-Files-To-Commons

Thu, Feb 29

thiemowmde created T358786: Can't search for multi-line regex any more.
Thu, Feb 29, 5:10 PM · VPS-project-Codesearch
thiemowmde closed T299280: Message cite_error_ref_too_many_keys is confusing as Resolved.
Thu, Feb 29, 3:01 PM · WMDE-TechWish-Sprint-2024-02-15, WMDE-TechWish-Sprint-2024-01-31, WMDE-TechWish-Sprint-2024-01-17, WMDE-TechWish-Sprint-2024-01-04, MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), WMDE-TechWish-Sprint-2023-12-06, WMDE-TechWish-Sprint-2023-11-22, I18n, Cite
thiemowmde closed T202593: Show a warning if the same named ref tag has two conflicting dir values as Resolved.
Thu, Feb 29, 3:01 PM · WMDE-TechWish-Sprint-2024-02-15, WMDE-TechWish-Sprint-2024-01-31, WMDE-TechWish-Sprint-2024-01-17, WMDE-TechWish-Sprint-2024-01-04, MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ), WMDE-TechWish-Sprint-2023-12-06, WMDE-TechWish-Maintenance, MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), WMDE-References-FocusArea, I18n, Cite
thiemowmde updated the task description for T358770: Improve user-facing Cite errors, one at a time.
Thu, Feb 29, 2:59 PM · Design, WMDE-Design, Epic, WMDE-References-FocusArea, Cite
thiemowmde closed T238188: Full UX (and possibly PM) review of all new user-facing (error) messages as Resolved.

This never happened, but we will try again via T358770: Improve user-facing Cite errors, one at a time. Let's close this as a successful investigation task.

Thu, Feb 29, 2:56 PM · WMDE-QWERTY-Sprint-2020-02-04, User-thiemowmde, Design, WMDE-QWERTY-Sprint-2020-01-21, WMDE-Design, WMDE-TechWish, Cite, Cite-Extends
thiemowmde created T358770: Improve user-facing Cite errors, one at a time.
Thu, Feb 29, 2:51 PM · Design, WMDE-Design, Epic, WMDE-References-FocusArea, Cite
thiemowmde updated the task description for T358759: IPInfo claims no edit was made from an IP that made edits.
Thu, Feb 29, 1:13 PM · StructuredDiscussions, Growth-Team, IP Info
thiemowmde created T358759: IPInfo claims no edit was made from an IP that made edits.
Thu, Feb 29, 1:12 PM · StructuredDiscussions, Growth-Team, IP Info

Wed, Feb 28

thiemowmde claimed T352169: Unexpected click behavior on RTL wikis with browser zoom >100%.
Wed, Feb 28, 2:13 PM · User-notice, Patch-For-Review, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Sprint-2024-02-15, WMDE-TechWish-Sprint-2023-11-22, Regression, WMDE-TechWish-Maintenance, Revision-Slider
thiemowmde renamed T352169: Unexpected click behavior on RTL wikis with browser zoom >100% from SliderView.revisionsClickHandler broken on RTL wikis with Vector 2022 to Unexpected click behavior on RTL wikis with browser zoom >100%.
Wed, Feb 28, 2:12 PM · User-notice, Patch-For-Review, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Sprint-2024-02-15, WMDE-TechWish-Sprint-2023-11-22, Regression, WMDE-TechWish-Maintenance, Revision-Slider
thiemowmde renamed T358641: Cite js docs should be published to doc.wikimedia.org from Cite js docs should be published to doc.wmo to Cite js docs should be published to doc.wikimedia.org.
Wed, Feb 28, 9:36 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-02-28, Documentation, WMDE-TechWish-Sprint-2024-02-15, Unplanned-Sprint-Work, WMDE-TechWish-Maintenance, doc.wikimedia.org, WMDE-References-FocusArea, Cite
thiemowmde raised the priority of T352169: Unexpected click behavior on RTL wikis with browser zoom >100% from High to Needs Triage.
Wed, Feb 28, 9:34 AM · User-notice, Patch-For-Review, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Sprint-2024-02-15, WMDE-TechWish-Sprint-2023-11-22, Regression, WMDE-TechWish-Maintenance, Revision-Slider

Tue, Feb 27

thiemowmde updated subscribers of T358523: Reconsider copy for the preferences.
Tue, Feb 27, 10:53 AM · Math
thiemowmde attached a referenced file: F42045482: Screenshot 2024-02-22 at 8.57.43 AM.png.
Tue, Feb 27, 10:49 AM · Math
thiemowmde committed rEEPSd47be4cca65d: Remove a few pieces of dead code (authored by thiemowmde).
Remove a few pieces of dead code
Tue, Feb 27, 10:23 AM

Mon, Feb 26

thiemowmde added a comment to T358492: Clarify current status and future directions for Status and StatusValue classes.

I have an easier time talking about code. Considering that the patch https://gerrit.wikimedia.org/r/1005462 triggered all this, I wonder what I'm missing in the following proposal?

class EditEntityStatus extends StatusValue {
	public static function wrap( StatusValue $status ) {
		if ( !( $status instanceof static ) ) {
			$status = static::newGood( $status->value );
		}
		if ( !( $status->getValue()['revision'] instanceof EntityRevision ) ) {
			throw new UnexpectedValueException( 'Unexpected status' );
		}
		// Can add more assertions here…
		return $status;
	}
Mon, Feb 26, 4:13 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Patch-For-Review, MediaWiki-General

Fri, Feb 23

thiemowmde added a comment to T336863: Show diff for rollback action on confirmation prompt page.

If you want to know more about how the MediaWiki ecosystem is developed I suggest https://www.mediawiki.org/wiki/Developer_hub. https://www.mediawiki.org/wiki/Bug_management/Development_prioritization is also a good read.

Fri, Feb 23, 10:37 AM · MediaWiki-Page-history, Confirmation prompt for rollback action
thiemowmde closed T223058: Change usage analysis dashboard for rollback confirmation prompts as Declined.

I don't think anyone actually needs numbers for this feature any more.

Fri, Feb 23, 10:19 AM · Confirmation prompt for rollback action
thiemowmde closed T221843: Grafana board for rollback confirmation prompts does not show daily interaction graph as Declined.

The Grafana page still exists, but all graphs stop in 2019. Nobody is looking at them any more anyway.

Fri, Feb 23, 10:19 AM · WMDE-TechWish-Maintenance, WMDE-FUN-Sprint-2019-04-29, Confirmation prompt for rollback action, WMDE-FUN-Team
thiemowmde closed T219781: Confirm on mobiles only as Declined.

The worlds of desktop and mobile devices are getting closer again over the years, and so is MediaWiki. See T158181: Aim for workflow equivalence for MediaWiki on desktop and mobile web and related.

Fri, Feb 23, 10:15 AM · Confirmation prompt for rollback action
thiemowmde closed T215019: Add an option for wikis to set the default of showing confirmation prompts for rollbacks, a subtask of T199534: Confirmation prompt for rollback action (#7 2017), as Resolved.
Fri, Feb 23, 10:12 AM · WMDE-TechWish, German-Community-Wishlist, Confirmation prompt for rollback action
thiemowmde closed T215019: Add an option for wikis to set the default of showing confirmation prompts for rollbacks as Resolved.

Long solved via a user option that can have different defaults per wiki: https://codesearch.wmcloud.org/search/?q=ShowRollbackConfirmation

Fri, Feb 23, 10:12 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), WMDE-FUN-Sprint-2019-02-04, Confirmation prompt for rollback action
thiemowmde closed T215021: Show a confirmation prompt for rollback link on list pages, a subtask of T199534: Confirmation prompt for rollback action (#7 2017), as Resolved.
Fri, Feb 23, 10:08 AM · WMDE-TechWish, German-Community-Wishlist, Confirmation prompt for rollback action
thiemowmde closed T215021: Show a confirmation prompt for rollback link on list pages as Resolved.
Fri, Feb 23, 10:08 AM · WMDE-FUN-Sprint-2019-02-04, Confirmation prompt for rollback action
thiemowmde closed T215024: Make sure users with enabled confirmation prompt cannot accidentally rollback without confirmation as Resolved.

As far as I understand it this is solved via T215303.

Fri, Feb 23, 10:07 AM · Confirmation prompt for rollback action
thiemowmde closed T215024: Make sure users with enabled confirmation prompt cannot accidentally rollback without confirmation, a subtask of T199534: Confirmation prompt for rollback action (#7 2017), as Resolved.
Fri, Feb 23, 10:07 AM · WMDE-TechWish, German-Community-Wishlist, Confirmation prompt for rollback action
thiemowmde closed T215022: Find out what list pages display a rollback link, a subtask of T215021: Show a confirmation prompt for rollback link on list pages, as Resolved.
Fri, Feb 23, 10:04 AM · WMDE-FUN-Sprint-2019-02-04, Confirmation prompt for rollback action
thiemowmde closed T215022: Find out what list pages display a rollback link as Resolved.
Fri, Feb 23, 10:04 AM · WMDE-FUN-Sprint-2019-02-04, Confirmation prompt for rollback action
thiemowmde closed T199534: Confirmation prompt for rollback action (#7 2017) as Resolved.
Fri, Feb 23, 10:03 AM · WMDE-TechWish, German-Community-Wishlist, Confirmation prompt for rollback action
thiemowmde edited projects for T237915: Make rollbacks on list pages asynchronous (using AJAX), added: MediaWiki-Recent-changes, MediaWiki-Page-history; removed Confirmation prompt for rollback action.
Fri, Feb 23, 10:02 AM · Growth-Team, MediaWiki-Page-history, MediaWiki-Recent-changes
thiemowmde closed T336863: Show diff for rollback action on confirmation prompt page as Declined.

While I understand the idea, I don't think it will ever be implemented. It would be quite a big investment (notice how the regular diff page became more complicated especially the past months) for not much benefit (only no-JS users). It's also very easy to achieve pretty much exactly the same by clicking one of the diff links first before doing the rollback. I'm sorry, but for the sake of keeping our priority lists in a manageable state I would like to archive this ticket.

Fri, Feb 23, 9:44 AM · MediaWiki-Page-history, Confirmation prompt for rollback action
thiemowmde changed the subtype of T89582: Category related changes should include recently removed items from "Task" to "Feature Request".
Fri, Feb 23, 8:58 AM · Patch-For-Review, Growth-Team, CatWatch, MediaWiki-Categories, MediaWiki-Recent-changes
thiemowmde closed T109672: [CatWatch] Preference for whether category changes affecting watched categories should trigger an email notification (separate from general enotifwatchlist), a subtask of T9148: Watch edits which add or remove pages from a category, as Declined.
Fri, Feb 23, 8:57 AM · User-notice-archive, CatWatch, MW-1.27-release, WMF-deploy-2015-08-25_(1.26wmf20), WMF-deploy-2015-08-18_(1.26wmf19), TCB-Team-Sprint-2015-08-12, TCB-Team-Sprint-2015-07-29, TCB-Team-Sprint-2015-07-15, TCB-Team-Sprint-2015-07-01, TCB-Team-Sprint-2015-06-17, TCB-Team-Sprint-2015-06-03, TCB-Team (now WMDE-TechWish), German-Community-Wishlist, MediaWiki-Watchlist
thiemowmde closed T109672: [CatWatch] Preference for whether category changes affecting watched categories should trigger an email notification (separate from general enotifwatchlist) as Declined.

A ticket as brief as this is probably not worth keeping around after 7 years of inactivity. Please feel free to re-open if anyone plans to work on this.

Fri, Feb 23, 8:56 AM · CatWatch, German-Community-Wishlist, MediaWiki-Categories, MediaWiki-Email
thiemowmde closed T126855: [CatWatch] does not reflect (un)categorization via transcluded templates as Invalid.

https://gerrit.wikimedia.org/r/281195 mentions 3 bugs as possibly being fixed, including this one. Since there was no response after that I assume we can close this here as well. Please feel free to re-open the ticket or submit a new report if there is still an issue.

Fri, Feb 23, 8:47 AM · Growth-Team-Filtering, Growth-Team, TCB-Team-Sprint-2016-04-13, CatWatch, TCB-Team-Sprint-2016-03-02, MediaWiki-Recent-changes, MediaWiki-Watchlist
thiemowmde changed the subtype of T130888: Category addition/removal should be displayed in the watchlist independently of further edits on articles from "Task" to "Feature Request".

I think this effectively qualifies as a new feature. very similar if not the same as T130134: Watching (only) categorization (additions and removals) of an arbitrary category.

Fri, Feb 23, 8:37 AM · Growth-Team, MediaWiki-Watchlist, CatWatch
thiemowmde changed the subtype of T130134: Watching (only) categorization (additions and removals) of an arbitrary category from "Task" to "Feature Request".

Sounds like this is effectively the same issue as T130888: Category addition/removal should be displayed in the watchlist independently of further edits on articles?

Fri, Feb 23, 8:37 AM · MediaWiki-Watchlist, Growth-Team-Filtering, Growth-Team, CatWatch
thiemowmde added a project to T130373: [Catwatch] Refine WhatLinksHere results for category additions/removals: MediaWiki-Recent-changes.
Fri, Feb 23, 8:31 AM · Growth-Team, MediaWiki-Recent-changes, TCB-Team-Sprint-2016-03-16, CatWatch
thiemowmde added a project to T130888: Category addition/removal should be displayed in the watchlist independently of further edits on articles: MediaWiki-Watchlist.
Fri, Feb 23, 8:29 AM · Growth-Team, MediaWiki-Watchlist, CatWatch
thiemowmde added projects to T129199: CatWatch does not recognize logger actions like deleting pages: MediaWiki-Watchlist, MediaWiki-Page-deletion.
Fri, Feb 23, 8:28 AM · Growth-Team, MediaWiki-Page-deletion, MediaWiki-Watchlist, CatWatch
thiemowmde added a project to T178038: Rebuildrecentchanges.php should regenerate CatWatch entries: MediaWiki-Watchlist.
Fri, Feb 23, 8:27 AM · MediaWiki-Watchlist, Growth-Team-Filtering, WMDE-TechWish-Maintenance, Regression, Growth-Team, MediaWiki-Recent-changes, CatWatch