Page MenuHomePhabricator

thiemowmde (Thiemo Kreuz (WMDE))
Software Developer

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 11:45 AM (320 w, 2 d)
Availability
Available
IRC Nick
Thiemo_WMDE
LDAP User
Thiemo Kreuz (WMDE)
MediaWiki User
Thiemo Kreuz (WMDE) [ Global Accounts ]

Recent Activity

Yesterday

thiemowmde committed rEMMSc37d1b1e6225: Fix MediaWiki.Files.ClassMatchesFilename.NotMatch exclude for PHPCS, (authored by Kizule).
Fix MediaWiki.Files.ClassMatchesFilename.NotMatch exclude for PHPCS,
Fri, Nov 27, 8:10 AM

Thu, Nov 26

thiemowmde added a comment to T248925: Make MediaWiki compatible with PHP 8.

unexpected token "match"

Yea, see http://maettig.com/2020-09-21-prepare-for-php-8. Functions named match might be one of the bigger PHP 7→8 problems we have. I started renaming some already. Here is the rest: https://codesearch.wmcloud.org/search/?q=function%20match%5Cb&files=%5C.php%24. This doesn't cover Wikia codebases, unfortunately.

Thu, Nov 26, 8:05 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, MW-1.35-notes, PHP 8.0 support, MediaWiki-General, MediaWiki-Stakeholders-Group
thiemowmde committed rERLSecb334c15600: Fix all PHPCS warnings (authored by thiemowmde).
Fix all PHPCS warnings
Thu, Nov 26, 5:41 PM

Wed, Nov 25

thiemowmde committed rEFLI839edb2a9579: Replace deprecated WikiRevision::setText (authored by Ammarpad).
Replace deprecated WikiRevision::setText
Wed, Nov 25, 2:34 PM

Tue, Nov 24

thiemowmde added a comment to T222445: Disable FileExporter on all Arabic projects per Commons community request.

Good to hear that! However, from this point on it's up to the Commons community to do this and make use of https://commons.wikimedia.org/wiki/MediaWiki:Fileimporter-post-import-revision-annotation.

Tue, Nov 24, 8:21 AM · WMDE-Technical-Wishes-Team, Community-consensus-needed, Commons, Move-Files-To-Commons
thiemowmde updated the task description for T268315: Investigation: Check core's conflict detection for changes possibly causing more conflicts.
Tue, Nov 24, 7:50 AM · WMDE-Technical-Wishes-Team, WMDE-Technical-Wishes-Maintenance, Two-Column-Edit-Conflict-Merge

Mon, Nov 23

thiemowmde committed rEMNH72f2dd8ffa03: Fix all PHPCS issues (authored by thiemowmde).
Fix all PHPCS issues
Mon, Nov 23, 9:36 PM
thiemowmde added a comment to T267926: Track number of times TemplateData is changed in the editor vs. by writing JSON.

I did a bit of investigation for this task. In the TemplateData extension, in TemplateDataHooks.php, there is a line $parser->getOutput()->setProperty( 'templatedata', … ) that stores a TemplateData blob in the page properties table. This code is executed after all templates are expanded, i.e. this will work with the German {{templatedata}} template.

Mon, Nov 23, 2:26 PM · WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
thiemowmde updated the task description for T258920: Collect on-going numbers related to VE template dialog and TemplateWizard use.
Mon, Nov 23, 2:10 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
thiemowmde updated subscribers of T258920: Collect on-going numbers related to VE template dialog and TemplateWizard use.

When an existing parameter is added (and filled) to a template using the VE template dialog
When an existing parameter is edited using the VE template dialog
When a parameter which was not auto added (optional params) is added to a template
When an unnamed parameter is added to a template

It seems we need to talk about some of the terminology here.

  • "Unnamed" refers to template parameters that don't have a name, but a number. For example, in {{Messagebox|Hello}} the text "Hello" is the value of the first parameter, but the parameter doesn't have a name, i.e. is "unnamed". That's the same as {{Messagebox|1=Hello}}, i.e. "unnamed" parameters are automatically numbered, but specifying that number is optional when the template is used.
    • For what this ticket here is about, there is nothing special about unnamed parameters. I don't see a need to track them separately.
  • "Optional parameters" are all parameters that are not required, i.e. parameters I can remove.
  • I'm not sure what "existing" refers to. "Existing" in which context?

@Lena_WMDE?

Mon, Nov 23, 1:31 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
thiemowmde placed T260138: Record baseline statistics about syntax highlighting (CodeMirror) use up for grabs.
Mon, Nov 23, 8:36 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), WMDE-QWERTY-Sprint-2020-11-18, WMDE-QWERTY-Sprint-2020-10-07, WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, Community-Tech, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea
thiemowmde moved T260138: Record baseline statistics about syntax highlighting (CodeMirror) use from Doing to Sprint Backlog on the WMDE-QWERTY-Sprint-2020-11-18 board.
Mon, Nov 23, 8:35 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), WMDE-QWERTY-Sprint-2020-11-18, WMDE-QWERTY-Sprint-2020-10-07, WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, Community-Tech, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea

Fri, Nov 20

thiemowmde moved T268313: Unexpected null error when the 2-column merge form is build from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-11-18 board.
Fri, Nov 20, 8:24 PM · WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Maintenance, WMDE-Technical-Wishes-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T268314: Add missing unit test for recent whitespace-only detection from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-11-18 board.
Fri, Nov 20, 8:24 PM · WMDE-Technical-Wishes-Team, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Maintenance, Two-Column-Edit-Conflict-Merge
thiemowmde claimed T268314: Add missing unit test for recent whitespace-only detection.
Fri, Nov 20, 8:23 PM · WMDE-Technical-Wishes-Team, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Maintenance, Two-Column-Edit-Conflict-Merge
thiemowmde claimed T268313: Unexpected null error when the 2-column merge form is build.
Fri, Nov 20, 8:23 PM · WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Maintenance, WMDE-Technical-Wishes-Team, Two-Column-Edit-Conflict-Merge
thiemowmde updated the task description for T267926: Track number of times TemplateData is changed in the editor vs. by writing JSON.
Fri, Nov 20, 10:14 AM · WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
thiemowmde updated the task description for T260343: Collect on-going numbers related to TemplateData editor dialog use.
Fri, Nov 20, 10:04 AM · WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
thiemowmde created T268315: Investigation: Check core's conflict detection for changes possibly causing more conflicts.
Fri, Nov 20, 9:06 AM · WMDE-Technical-Wishes-Team, WMDE-Technical-Wishes-Maintenance, Two-Column-Edit-Conflict-Merge
thiemowmde created T268314: Add missing unit test for recent whitespace-only detection.
Fri, Nov 20, 8:57 AM · WMDE-Technical-Wishes-Team, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Maintenance, Two-Column-Edit-Conflict-Merge
thiemowmde created T268313: Unexpected null error when the 2-column merge form is build.
Fri, Nov 20, 8:45 AM · WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Maintenance, WMDE-Technical-Wishes-Team, Two-Column-Edit-Conflict-Merge

Wed, Nov 18

thiemowmde updated subscribers of T268139: ComboBoxInputWidget: does not close when tabbing out with selected value.

Thanks for letting me know. I had a look and was indeed able to reproduce the issue. It looks like the code that open the dropdown menu when e.g. the field is focused gets triggered in to many situations. I uploaded an alternative bugfix.

Wed, Nov 18, 4:24 PM · OOUI (OOUI-0.41.0)
thiemowmde added a parent task for T261314: ComboBoxInputWidget.setValue shows warning if called before element attached: T268139: ComboBoxInputWidget: does not close when tabbing out with selected value.
Wed, Nov 18, 4:24 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), WMDE-QWERTY-Sprint-2020-08-26, WMDE-QWERTY-Sprint-2020-08-12, OOUI
thiemowmde added a subtask for T268139: ComboBoxInputWidget: does not close when tabbing out with selected value: T261314: ComboBoxInputWidget.setValue shows warning if called before element attached.
Wed, Nov 18, 4:24 PM · OOUI (OOUI-0.41.0)
thiemowmde added a project to T258999: Update CodeMirror extension to the latest CodeMirror library 5.x.x: WMDE-QWERTY-Sprint-2020-11-18.
Wed, Nov 18, 2:00 PM · WMDE-QWERTY-Sprint-2020-11-18, Community-Tech, WMDE-Templates-FocusArea, Technical-Debt, MediaWiki-extensions-CodeMirror
thiemowmde updated the task description for T258999: Update CodeMirror extension to the latest CodeMirror library 5.x.x.
Wed, Nov 18, 2:00 PM · WMDE-QWERTY-Sprint-2020-11-18, Community-Tech, WMDE-Templates-FocusArea, Technical-Debt, MediaWiki-extensions-CodeMirror
thiemowmde moved T258999: Update CodeMirror extension to the latest CodeMirror library 5.x.x from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.
Wed, Nov 18, 1:58 PM · WMDE-QWERTY-Sprint-2020-11-18, Community-Tech, WMDE-Templates-FocusArea, Technical-Debt, MediaWiki-extensions-CodeMirror
thiemowmde set the point value for T267951: Add browser test for conflict with popups to 3.
Wed, Nov 18, 1:54 PM · WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Team, WMDE-QWERTY-Sprint-2020-11-04, Reference Previews
thiemowmde moved T259705: Log template metadata whenever a template dialog is opened from In preparation to In sprint on the WMDE-Templates-FocusArea board.
Wed, Nov 18, 1:51 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2020-11-18, MediaWiki-extensions-TemplateWizard, VisualEditor, Community-Tech, WMDE-Templates-FocusArea
thiemowmde moved T262209: Set up Grafana board for VE template dialog, TemplateWizard and TemplateData editor metrics from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.
Wed, Nov 18, 1:50 PM · WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
thiemowmde moved T258920: Collect on-going numbers related to VE template dialog and TemplateWizard use from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.
Wed, Nov 18, 1:50 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
thiemowmde moved T258917: Record template use and dialog interaction metrics from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.
Wed, Nov 18, 1:50 PM · WMDE-QWERTY-Sprint-2020-11-18, Epic, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
thiemowmde moved T260138: Record baseline statistics about syntax highlighting (CodeMirror) use from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.
Wed, Nov 18, 1:50 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), WMDE-QWERTY-Sprint-2020-11-18, WMDE-QWERTY-Sprint-2020-10-07, WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, Community-Tech, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea
thiemowmde moved T267902: Set up Grafana board for syntax highlighting (CodeMirror) use from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.
Wed, Nov 18, 1:50 PM · WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
thiemowmde closed T267316: FileImporter throws backend errors on Special:SpecialPages as Resolved.
Wed, Nov 18, 1:37 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), WMDE-QWERTY-Sprint-2020-11-04, Unplanned-Sprint-Work, Wikimedia-production-error, WMDE-Technical-Wishes-Maintenance, WMDE-Technical-Wishes-Team
thiemowmde moved T268134: ReferencePreviews browser tests not execute on CI from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-11-18 board.
Wed, Nov 18, 1:35 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), WMDE-QWERTY-Sprint-2020-11-18, WMDE-QWERTY-Sprint-2020-11-04, Reference Previews, WMDE-Technical-Wishes-Team
thiemowmde added a project to T268134: ReferencePreviews browser tests not execute on CI: WMDE-QWERTY-Sprint-2020-11-18.
Wed, Nov 18, 1:35 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), WMDE-QWERTY-Sprint-2020-11-18, WMDE-QWERTY-Sprint-2020-11-04, Reference Previews, WMDE-Technical-Wishes-Team
thiemowmde moved T267951: Add browser test for conflict with popups from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-11-18 board.
Wed, Nov 18, 1:35 PM · WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Team, WMDE-QWERTY-Sprint-2020-11-04, Reference Previews
thiemowmde added a project to T267951: Add browser test for conflict with popups: WMDE-QWERTY-Sprint-2020-11-18.
Wed, Nov 18, 1:35 PM · WMDE-QWERTY-Sprint-2020-11-18, WMDE-Technical-Wishes-Team, WMDE-QWERTY-Sprint-2020-11-04, Reference Previews
thiemowmde archived WMDE-QWERTY-Sprint-2020-10-21.
Wed, Nov 18, 1:34 PM
thiemowmde added members for WMDE-QWERTY-Sprint-2020-11-18: Lena_WMDE, awight, WMDE-Fisch, lilients_WMDE, Andrew-WMDE, ECohen_WMDE.
Wed, Nov 18, 1:34 PM
thiemowmde added a member for WMDE-QWERTY-Sprint-2020-11-18: thiemowmde.
Wed, Nov 18, 1:33 PM
thiemowmde edited Description on WMDE-QWERTY-Sprint-2020-11-18.
Wed, Nov 18, 1:33 PM
thiemowmde set the image for WMDE-QWERTY-Sprint-2020-11-18 to F33918302: fa-calendar-green.png.
Wed, Nov 18, 1:33 PM
thiemowmde created WMDE-QWERTY-Sprint-2020-11-18.
Wed, Nov 18, 1:33 PM

Tue, Nov 17

thiemowmde created T268021: Remove people's names from extension.json in TechWish projects.
Tue, Nov 17, 1:55 PM · WMDE-Technical-Wishes-Maintenance, WMDE-Technical-Wishes-Team
thiemowmde added a parent task for T197525: Let users sort results by time (older or newer results): T268018: Clean up messages for sorting orders.
Tue, Nov 17, 1:41 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), User-notice, Wikimedia-Hackathon-2019, Advanced-Search, archived--TCB-Team
thiemowmde added a parent task for T239030: Search sort by create_timestamp_asc not recognised: T268018: Clean up messages for sorting orders.
Tue, Nov 17, 1:40 PM · WMDE-QWERTY-Sprint-2020-11-04, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), WMDE-Technical-Wishes-Team, WMDE-QWERTY-Sprint-2020-09-09, Advanced-Search
thiemowmde added subtasks for T268018: Clean up messages for sorting orders: T197525: Let users sort results by time (older or newer results), T239030: Search sort by create_timestamp_asc not recognised.
Tue, Nov 17, 1:40 PM · WMDE-Technical-Wishes-Maintenance, Design, WMDE-Design, WMDE-Technical-Wishes-Team, Advanced-Search
thiemowmde created T268018: Clean up messages for sorting orders.
Tue, Nov 17, 1:39 PM · WMDE-Technical-Wishes-Maintenance, Design, WMDE-Design, WMDE-Technical-Wishes-Team, Advanced-Search
thiemowmde added a parent task for T251898: Validate TwoColConflict interface on Lua and JavaScript pages: T268017: Disable TwoColConflict on code pages (Lua etc.).
Tue, Nov 17, 1:28 PM · WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, User-thiemowmde, WMDE-Technical-Wishes-Team, Two-Column-Edit-Conflict-Merge
thiemowmde added a subtask for T268017: Disable TwoColConflict on code pages (Lua etc.): T251898: Validate TwoColConflict interface on Lua and JavaScript pages.
Tue, Nov 17, 1:28 PM · WMDE-Technical-Wishes-Team, Two-Column-Edit-Conflict-Merge
thiemowmde created T268017: Disable TwoColConflict on code pages (Lua etc.).
Tue, Nov 17, 1:28 PM · WMDE-Technical-Wishes-Team, Two-Column-Edit-Conflict-Merge
thiemowmde closed T267199: Port difflinks.feature from Ruby to Node.js, a subtask of T180247: Port RevisionSlider Selenium tests from Ruby to Node.js, as Resolved.
Tue, Nov 17, 1:19 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Epic, WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, Technical-Debt, WMDE-Technical-Wishes-Team, WMDE volunteer workboard, WMDE-QWERTY-XMAS-Sprint-2017-12-20, patch-welcome, Revision-Slider
thiemowmde closed T267199: Port difflinks.feature from Ruby to Node.js as Resolved.
Tue, Nov 17, 1:19 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), WMDE-QWERTY-Sprint-2020-11-04, Revision-Slider
thiemowmde closed T267198: Port autoexpand.feature and expand.feature from Ruby to Node.js, a subtask of T180247: Port RevisionSlider Selenium tests from Ruby to Node.js, as Resolved.
Tue, Nov 17, 1:18 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Epic, WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, Technical-Debt, WMDE-Technical-Wishes-Team, WMDE volunteer workboard, WMDE-QWERTY-XMAS-Sprint-2017-12-20, patch-welcome, Revision-Slider
thiemowmde closed T267198: Port autoexpand.feature and expand.feature from Ruby to Node.js as Resolved.
Tue, Nov 17, 1:18 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), WMDE-QWERTY-Sprint-2020-11-04, Revision-Slider
thiemowmde closed T267206: Port pointers.feature from Ruby to Node.js, a subtask of T180247: Port RevisionSlider Selenium tests from Ruby to Node.js, as Resolved.
Tue, Nov 17, 1:18 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Epic, WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, Technical-Debt, WMDE-Technical-Wishes-Team, WMDE volunteer workboard, WMDE-QWERTY-XMAS-Sprint-2017-12-20, patch-welcome, Revision-Slider
thiemowmde closed T267206: Port pointers.feature from Ruby to Node.js as Resolved.
Tue, Nov 17, 1:18 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), WMDE-QWERTY-Sprint-2020-11-04, Revision-Slider
thiemowmde closed T267205: Port timeline.feature from Ruby to Node.js, a subtask of T180247: Port RevisionSlider Selenium tests from Ruby to Node.js, as Resolved.
Tue, Nov 17, 1:18 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Epic, WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, Technical-Debt, WMDE-Technical-Wishes-Team, WMDE volunteer workboard, WMDE-QWERTY-XMAS-Sprint-2017-12-20, patch-welcome, Revision-Slider
thiemowmde closed T267205: Port timeline.feature from Ruby to Node.js as Resolved.
Tue, Nov 17, 1:18 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), WMDE-QWERTY-Sprint-2020-11-04, Revision-Slider
thiemowmde closed T267201: Port history.feature from Ruby to Node.js, a subtask of T180247: Port RevisionSlider Selenium tests from Ruby to Node.js, as Resolved.
Tue, Nov 17, 1:18 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Epic, WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, Technical-Debt, WMDE-Technical-Wishes-Team, WMDE volunteer workboard, WMDE-QWERTY-XMAS-Sprint-2017-12-20, patch-welcome, Revision-Slider
thiemowmde closed T267204: Port tooltips.feature from Ruby to Node.js, a subtask of T180247: Port RevisionSlider Selenium tests from Ruby to Node.js, as Resolved.
Tue, Nov 17, 1:18 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Epic, WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, Technical-Debt, WMDE-Technical-Wishes-Team, WMDE volunteer workboard, WMDE-QWERTY-XMAS-Sprint-2017-12-20, patch-welcome, Revision-Slider
thiemowmde closed T267201: Port history.feature from Ruby to Node.js as Resolved.
Tue, Nov 17, 1:18 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), WMDE-QWERTY-Sprint-2020-11-04, Revision-Slider
thiemowmde closed T267200: Port help.feature from Ruby to Node.js, a subtask of T180247: Port RevisionSlider Selenium tests from Ruby to Node.js, as Resolved.
Tue, Nov 17, 1:18 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Epic, WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, Technical-Debt, WMDE-Technical-Wishes-Team, WMDE volunteer workboard, WMDE-QWERTY-XMAS-Sprint-2017-12-20, patch-welcome, Revision-Slider
thiemowmde closed T267204: Port tooltips.feature from Ruby to Node.js as Resolved.
Tue, Nov 17, 1:18 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), WMDE-QWERTY-Sprint-2020-11-04, Revision-Slider
thiemowmde closed T267200: Port help.feature from Ruby to Node.js as Resolved.
Tue, Nov 17, 1:18 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2020-11-04, Revision-Slider
thiemowmde closed T251898: Validate TwoColConflict interface on Lua and JavaScript pages as Resolved.
Tue, Nov 17, 1:15 PM · WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, User-thiemowmde, WMDE-Technical-Wishes-Team, Two-Column-Edit-Conflict-Merge
thiemowmde closed T239030: Search sort by create_timestamp_asc not recognised as Resolved.
Tue, Nov 17, 1:15 PM · WMDE-QWERTY-Sprint-2020-11-04, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), WMDE-Technical-Wishes-Team, WMDE-QWERTY-Sprint-2020-09-09, Advanced-Search
thiemowmde closed T255264: Import success message is possibly shown to other users as Resolved.
Tue, Nov 17, 1:14 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), WMDE-QWERTY-Sprint-2020-11-04, WMDE-QWERTY-Sprint-2020-10-21, User-thiemowmde, Technical-Debt, WMDE-Technical-Wishes-Team, Move-Files-To-Commons
thiemowmde closed T267316: FileImporter throws backend errors on Special:SpecialPages as Resolved.
Tue, Nov 17, 1:09 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), WMDE-QWERTY-Sprint-2020-11-04, Unplanned-Sprint-Work, Wikimedia-production-error, WMDE-Technical-Wishes-Maintenance, WMDE-Technical-Wishes-Team
thiemowmde added a subtask for T243220: Create logstash monitoring dashboard for Technical Wishes products: T267332: Determine which projects WMDE Technical Wishes is responsible for.
Tue, Nov 17, 12:51 PM · WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, WMDE-Technical-Wishes-Team
thiemowmde added a parent task for T267332: Determine which projects WMDE Technical Wishes is responsible for: T243220: Create logstash monitoring dashboard for Technical Wishes products.
Tue, Nov 17, 12:51 PM · Unplanned-Sprint-Work, WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, WMDE-Technical-Wishes-Team
thiemowmde added a project to T174726: Page Preview preference should be a checkbox: WMDE-QWERTY-Sprint-2020-11-04.
Tue, Nov 17, 12:18 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), WMDE-QWERTY-Sprint-2020-11-04, Readers-Web-Backlog (Kanbanana-FY-2020-21), UI-Standardization, MediaWiki-User-preferences, Page-Previews
thiemowmde moved T174726: Page Preview preference should be a checkbox from Sprint Backlog to Watching on the WMDE-QWERTY-Sprint-2020-11-04 board.
Tue, Nov 17, 12:18 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), WMDE-QWERTY-Sprint-2020-11-04, Readers-Web-Backlog (Kanbanana-FY-2020-21), UI-Standardization, MediaWiki-User-preferences, Page-Previews
thiemowmde moved T265872: Disable ReferencePreviews when gadget is detected from Review to Demo on the WMDE-QWERTY-Sprint-2020-11-04 board.
Tue, Nov 17, 11:15 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2020-11-04, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), WMDE-QWERTY-Sprint-2020-10-21, Reference Previews, WMDE-Technical-Wishes-Team
thiemowmde renamed T258999: Update CodeMirror extension to the latest CodeMirror library 5.x.x from Update CodeMirror extension to CodeMirror library 5.56.0 to Update CodeMirror extension to the latest CodeMirror library 5.x.x.
Tue, Nov 17, 9:28 AM · WMDE-QWERTY-Sprint-2020-11-18, Community-Tech, WMDE-Templates-FocusArea, Technical-Debt, MediaWiki-extensions-CodeMirror
thiemowmde moved T251898: Validate TwoColConflict interface on Lua and JavaScript pages from Doing to Demo on the WMDE-QWERTY-Sprint-2020-11-04 board.
Tue, Nov 17, 8:37 AM · WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, User-thiemowmde, WMDE-Technical-Wishes-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T267332: Determine which projects WMDE Technical Wishes is responsible for from Review to Demo on the WMDE-QWERTY-Sprint-2020-11-04 board.
Tue, Nov 17, 8:37 AM · Unplanned-Sprint-Work, WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, WMDE-Technical-Wishes-Team

Mon, Nov 16

thiemowmde updated the task description for T267911: Add line numbering to syntax highlighting (CodeMirror extension) on first wikis.
Mon, Nov 16, 1:40 PM · Community-Tech, MediaWiki-extensions-CodeMirror, Epic, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
thiemowmde updated the task description for T258999: Update CodeMirror extension to the latest CodeMirror library 5.x.x.
Mon, Nov 16, 1:14 PM · WMDE-QWERTY-Sprint-2020-11-18, Community-Tech, WMDE-Templates-FocusArea, Technical-Debt, MediaWiki-extensions-CodeMirror

Fri, Nov 13

thiemowmde created T267846: Investigation: Using ReferencePreviews together with NavigationPopups.
Fri, Nov 13, 5:13 PM · Navigation-Popups, WMDE-Technical-Wishes-Team, Reference Previews
thiemowmde added a comment to T251898: Validate TwoColConflict interface on Lua and JavaScript pages.

For reference, dev tools like Gerrit allow the user to decide how much context (number of lines above and below a change) they want to see.

Fri, Nov 13, 4:10 PM · WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, User-thiemowmde, WMDE-Technical-Wishes-Team, Two-Column-Edit-Conflict-Merge
thiemowmde created T267843: Sort order selector is broken on 3rd-party wikis without CirrusSearch.
Fri, Nov 13, 3:23 PM · WMDE-Technical-Wishes-Maintenance, Advanced-Search
thiemowmde created T267842: Search order can't be removed, but shows a remove button.
Fri, Nov 13, 3:01 PM · WMDE-Design, WMDE-Technical-Wishes-Maintenance, WMDE-Technical-Wishes-Team, Design, Advanced-Search

Thu, Nov 12

thiemowmde reopened T198372: Make sure people understand which template prevents them to moving a file to Commons as "Open".

I think what was written in the comment T198372#4380653 still applies. With T194132 we list only the first reason why a file can not be imported. But we neither list all of the templates and categories, nor can we distinguish between direct and indirect template usages. I.e. the task asking for "which template" is still unresolved, as far as I'm aware of.

Thu, Nov 12, 11:39 AM · Move-Files-To-Commons
thiemowmde committed rEFLIba17f02b8373: Make some more regex patterns Unicode-aware (authored by thiemowmde).
Make some more regex patterns Unicode-aware
Thu, Nov 12, 9:42 AM
thiemowmde moved T267204: Port tooltips.feature from Ruby to Node.js from Review to Done on the WMDE-QWERTY-Sprint-2020-11-04 board.
Thu, Nov 12, 8:48 AM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), WMDE-QWERTY-Sprint-2020-11-04, Revision-Slider
thiemowmde added a comment to T222445: Disable FileExporter on all Arabic projects per Commons community request.

Thanks for looking into this!

  1. It's true, users can edit the configuration pages. However, there is a bit of protection as users need to be autoconfirmed to do this, see T202071#6520637.
  2. For what FileImporter cares about there is no difference between templates and categories. I believe the question is about T256205: Add configurable template to imported file info. There is a brief description of the feature at https://meta.wikimedia.org/wiki/WMDE_Technical_Wishes/Move_files_to_Commons#How_it_works. The message https://commons.wikimedia.org/wiki/MediaWiki:Fileimporter-post-import-revision-annotation is currently empty, but can be used to either add a category or template to every imported file on Commons. One advantage of a template is that you can change it without touching the message in the MediaWiki: namespace.
Thu, Nov 12, 8:16 AM · WMDE-Technical-Wishes-Team, Community-consensus-needed, Commons, Move-Files-To-Commons
thiemowmde edited Description on CatWatch.
Thu, Nov 12, 7:58 AM
thiemowmde added a watcher for CatWatch: thiemowmde.
Thu, Nov 12, 7:52 AM

Wed, Nov 11

thiemowmde created T267756: Add de-localization support for the special {{self}} wrapper template.
Wed, Nov 11, 7:25 PM · WMDE-Technical-Wishes-Team, Move-Files-To-Commons
thiemowmde added a comment to T251898: Validate TwoColConflict interface on Lua and JavaScript pages.

For reference, this is how it looks like when I merge code in PHPStorm.

Wed, Nov 11, 2:44 PM · WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, User-thiemowmde, WMDE-Technical-Wishes-Team, Two-Column-Edit-Conflict-Merge
thiemowmde added a comment to T251898: Validate TwoColConflict interface on Lua and JavaScript pages.

Here is an example as I had it in mind (from de:Module:TemplUtl).

Wed, Nov 11, 2:31 PM · WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, User-thiemowmde, WMDE-Technical-Wishes-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T267316: FileImporter throws backend errors on Special:SpecialPages from Review to Demo on the WMDE-QWERTY-Sprint-2020-11-04 board.
Wed, Nov 11, 11:38 AM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), WMDE-QWERTY-Sprint-2020-11-04, Unplanned-Sprint-Work, Wikimedia-production-error, WMDE-Technical-Wishes-Maintenance, WMDE-Technical-Wishes-Team
thiemowmde updated subscribers of T267332: Determine which projects WMDE Technical Wishes is responsible for.

@Lydia_Pintscher, is it correct when we assume the following products are owned by the Wikidata team(s) and PMs? The relevant question for this ticket here is if anybody is or want's to actively watch the error channels for these projects? And if so, which team should that be?

Wed, Nov 11, 11:31 AM · Unplanned-Sprint-Work, WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, WMDE-Technical-Wishes-Team
thiemowmde added a comment to T267319: XMP errors when using FileImporter on jpeg images.

It looks like there is another FileImporter-related error happening in XMPReader:

#0 [internal function]: Wikimedia\XMPReader\Reader->char(resource, string)
#1 /srv/mediawiki/php-1.36.0-wmf.16/vendor/wikimedia/xmp-reader/src/Reader.php(373): xml_parse(resource, string, boolean)
#2 /srv/mediawiki/php-1.36.0-wmf.16/includes/media/BitmapMetadataHandler.php(214): Wikimedia\XMPReader\Reader->parse(string)
#3 /srv/mediawiki/php-1.36.0-wmf.16/includes/media/PNGHandler.php(39): BitmapMetadataHandler::PNG(string)
#4 /srv/mediawiki/php-1.36.0-wmf.16/includes/utils/MWFileProps.php(87): PNGHandler->getMetadata(FSFile, string)
#5 /srv/mediawiki/php-1.36.0-wmf.16/includes/filerepo/file/LocalFile.php(1393): MWFileProps->getPropsFromPath(string, string)
#6 /srv/mediawiki/php-1.36.0-wmf.16/includes/import/ImportableUploadRevisionImporter.php(127): LocalFile->upload(string, string, string, integer, boolean, string, User, array, boolean)
#7 /srv/mediawiki/php-1.36.0-wmf.16/extensions/FileImporter/src/Operations/FileRevisionFromRemoteUrl.php(197): ImportableUploadRevisionImporter->import(WikiRevision)
…

Similar to above:

  • In BitmapMetadataHandler::PNG() is a parse() call. We could wrap this in a try-catch and just not extract metadata if they can't be parsed, but not mark the entire file as "broken" just because of this.
  • There is a third one in BitmapMetadataHandler::GIF().
Wed, Nov 11, 10:20 AM · XMPReader, Wikimedia-production-error, WMDE-Technical-Wishes-Team, WMDE-Technical-Wishes-Maintenance, Move-Files-To-Commons
thiemowmde added a comment to T267720: CommentParser.php: PHP Notice: Trying to get property 'length' of non-object / Argument 4 passed to MediaWiki\Extension\DiscussionTools\ImmutableRange::__construct() must be of the type integer, null given.

Yes, that's it for sure. I suggest to close this ticket here as a duplicate. Thanks for looking into this!

Wed, Nov 11, 9:56 AM · Editing-team (FY2020-21 Kanban Board), DiscussionTools
thiemowmde updated the task description for T267332: Determine which projects WMDE Technical Wishes is responsible for.
Wed, Nov 11, 9:00 AM · Unplanned-Sprint-Work, WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, WMDE-Technical-Wishes-Team
thiemowmde updated the task description for T267332: Determine which projects WMDE Technical Wishes is responsible for.
Wed, Nov 11, 8:51 AM · Unplanned-Sprint-Work, WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, WMDE-Technical-Wishes-Team