thiemowmde (Thiemo Kreuz (WMDE))
Software Developer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 11:45 AM (201 w, 1 d)
Availability
Available
IRC Nick
Thiemo_WMDE
LDAP User
Thiemo Kreuz (WMDE)
MediaWiki User
Thiemo Kreuz (WMDE) [ Global Accounts ]

Recent Activity

Yesterday

thiemowmde committed rEFLI6ee020923fd6: Remove unused code from ImportPlan and add tests (authored by thiemowmde).
Remove unused code from ImportPlan and add tests
Thu, Aug 16, 4:38 PM
thiemowmde committed rESCCc582ea2f74ab: Change "save" to "publish" everywhere (authored by thiemowmde).
Change "save" to "publish" everywhere
Thu, Aug 16, 11:24 AM
thiemowmde committed rESCC3ce107ba5b02: Remove current time from edit conflict header (authored by thiemowmde).
Remove current time from edit conflict header
Thu, Aug 16, 11:24 AM
thiemowmde created T202053: Remove current time from edit conflict header.
Thu, Aug 16, 11:17 AM · Patch-For-Review, WMDE-Design, TCB-Team, Two-Column-Edit-Conflict-Merge, Design
thiemowmde created T202052: Change "save" to "publish" in all messages in the TwoColConflict interface.
Thu, Aug 16, 11:04 AM · Patch-For-Review, Design, WMDE-Design, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T197157: New diffs show lines in the wrong order from Doing to Review on the WMDE-QWERTY-Sprint-2018-08-14 board.
Thu, Aug 16, 10:58 AM · WMDE-QWERTY-Sprint-2018-08-14, Patch-For-Review, WMDE-QWERTY-Sprint-2018-07-31, WMDE-QWERTY-Sprint-2018-07-17, wikidiff2, Regression, MediaWiki-History-or-Diffs
thiemowmde archived WMDE-QWERTY-Sprint-2018-07-31.
Thu, Aug 16, 10:02 AM
thiemowmde committed rEASR9ba9cb2da712: Split ext.advancedSearch.AdvancedOptionsConfig module into three (authored by thiemowmde).
Split ext.advancedSearch.AdvancedOptionsConfig module into three
Thu, Aug 16, 9:29 AM
thiemowmde committed rEASR4491ccbc33fc: Split ext.advancedSearch.AdvancedOptionsConfig module into three (authored by thiemowmde).
Split ext.advancedSearch.AdvancedOptionsConfig module into three
Thu, Aug 16, 9:18 AM
thiemowmde committed rESCC0577dce4fe2f: Remove current time and rename "save" to "publish" (authored by thiemowmde).
Remove current time and rename "save" to "publish"
Thu, Aug 16, 9:09 AM
thiemowmde committed rESCCe61390220f6e: Clean-ups to SplitTwoColConflict code and tests (authored by thiemowmde).
Clean-ups to SplitTwoColConflict code and tests
Thu, Aug 16, 7:05 AM
thiemowmde committed rEASRf623d17641e2: Replace setTimeout with requestIdleCallback (authored by thiemowmde).
Replace setTimeout with requestIdleCallback
Thu, Aug 16, 5:40 AM

Wed, Aug 15

thiemowmde claimed T201914: Add edge-case test to wikidiff2 C++ tests.
Wed, Aug 15, 9:59 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2018-08-14, wikidiff2
thiemowmde moved T201914: Add edge-case test to wikidiff2 C++ tests from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-08-14 board.
Wed, Aug 15, 9:58 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2018-08-14, wikidiff2
thiemowmde committed rESCCf5e03faa3b7e: Remove current time and rename "save" to "publish" (authored by thiemowmde).
Remove current time and rename "save" to "publish"
Wed, Aug 15, 9:35 AM
thiemowmde committed rESCC3ca939b99aa1: Clean-ups to SplitTwoColConflict code and tests (authored by thiemowmde).
Clean-ups to SplitTwoColConflict code and tests
Wed, Aug 15, 9:35 AM
thiemowmde committed rESCC583901082252: Clean-ups to SplitTwoColConflict code and tests (authored by thiemowmde).
Clean-ups to SplitTwoColConflict code and tests
Wed, Aug 15, 9:30 AM
thiemowmde committed rESCC5fc7eeb74323: Clean-ups to SplitTwoColConflict code and tests (authored by thiemowmde).
Clean-ups to SplitTwoColConflict code and tests
Wed, Aug 15, 9:26 AM
thiemowmde added a comment to T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations().

I just realized what this error message means: Some test (at the moment I don't know which) creates an Item, but this Item ends in code that expects a Lexeme.

Wed, Aug 15, 8:41 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, Wikidata-Editor-Experience-Improvements-Iteration5, Wikidata, Lexicographical data
thiemowmde committed rECOGb2f6cccc700c: Avoid overhead of converting Title objects to TitleValue (authored by Legoktm).
Avoid overhead of converting Title objects to TitleValue
Wed, Aug 15, 8:14 AM

Tue, Aug 14

thiemowmde committed rEFLI04758cf5b36b: Remove obsolete empty <div> (authored by thiemowmde).
Remove obsolete empty <div>
Tue, Aug 14, 3:26 PM
thiemowmde updated the image for Season of RevisionSlider from F24925420: profile to F24925500: profile.
Tue, Aug 14, 12:30 PM
thiemowmde updated the image for Season of RevisionSlider from F24439510: profile to F24925420: profile.
Tue, Aug 14, 12:28 PM
thiemowmde archived WMDE-QWERTY-Sprint-2018-07-17.
Tue, Aug 14, 12:14 PM
thiemowmde moved T197157: New diffs show lines in the wrong order from Review to Doing on the WMDE-QWERTY-Sprint-2018-07-31 board.
Tue, Aug 14, 10:50 AM · WMDE-QWERTY-Sprint-2018-08-14, Patch-For-Review, WMDE-QWERTY-Sprint-2018-07-31, WMDE-QWERTY-Sprint-2018-07-17, wikidiff2, Regression, MediaWiki-History-or-Diffs
thiemowmde moved T201408: Request labs project for testing of the TwoColConflict extension from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-07-31 board.
Tue, Aug 14, 10:01 AM · WMDE-QWERTY-Sprint-2018-08-14, Cloud-Services, Two-Column-Edit-Conflict-Merge, WMDE-QWERTY-Sprint-2018-07-31, TCB-Team
thiemowmde moved T199801: Update wikidiff2 library on the WMF production cluster to v1.7.2 from Doing to Review on the WMDE-QWERTY-Sprint-2018-07-31 board.
Tue, Aug 14, 10:00 AM · WMDE-QWERTY-Sprint-2018-08-14, WMDE-QWERTY-Sprint-2018-07-31, Operations, WMDE-QWERTY-Sprint-2018-07-17, wikidiff2, TCB-Team
thiemowmde added a comment to T201802: Performance review for Assert library.

[…] Thiemo already did analysis/review on the library (correct me if I'm wrong).

Tue, Aug 14, 8:50 AM · Performance-Team (Radar), MediaWiki-General-or-Unknown

Mon, Aug 13

thiemowmde committed rESCCa7db4cb715bb: Clean-ups to SplitTwoColConflict code and tests (authored by thiemowmde).
Clean-ups to SplitTwoColConflict code and tests
Mon, Aug 13, 2:54 PM
thiemowmde committed rESCC0267daf00a87: Remove current time and rename "save" to "publish" (authored by thiemowmde).
Remove current time and rename "save" to "publish"
Mon, Aug 13, 2:54 PM
thiemowmde committed rESCC0f6793115f47: Save the currently selected version of the diff (authored by WMDE-Fisch).
Save the currently selected version of the diff
Mon, Aug 13, 2:54 PM
thiemowmde committed rESCC28112ccc3222: Remove current time and rename "save" to "publish" (authored by thiemowmde).
Remove current time and rename "save" to "publish"
Mon, Aug 13, 2:42 PM
thiemowmde committed rEFLId396e418c180: Remove obsolete empty <div> (authored by thiemowmde).
Remove obsolete empty <div>
Mon, Aug 13, 2:18 PM
thiemowmde committed rESCCf3057cc1e361: Clean-ups to SplitTwoColConflict code and tests (authored by thiemowmde).
Clean-ups to SplitTwoColConflict code and tests
Mon, Aug 13, 2:02 PM
thiemowmde committed rESCCb27823a99bef: Improve generic array type hints (authored by thiemowmde).
Improve generic array type hints
Mon, Aug 13, 12:30 PM
thiemowmde added a comment to T201801: Improve TitleValue, TitleFactory, TitleParser performance to be on-par with Title.

not that anyone cares if an integer is passed as a float […]

Mon, Aug 13, 8:30 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, User-Daniel, MediaWiki-General-or-Unknown, Performance, Core-Platform-Team (CPT-Q1-Jul-Sep-2018)
thiemowmde added a comment to T201802: Performance review for Assert library.

From the header of Assert.php:

Note that assertions evaluate expressions and add function calls, so using assertions may have a negative impact on performance when used in performance hotspots. The idea of this class is to have a neat tool for assertions if and when they are needed. It is not recommended to place assertions all over the code indiscriminately.

Mon, Aug 13, 8:17 AM · Performance-Team (Radar), MediaWiki-General-or-Unknown
thiemowmde added a comment to T194613: Replace custom pin icon with OOUI's 'pushPin'.

I reviewed patch set 6 of the patch https://gerrit.wikimedia.org/r/451611, and can confirm that it successfully replaces the icon as requested. But the patch does have two issues, both visible in this screenshot:

  • The new icon is not centered on it's button.
  • The slider UI below is partly shifted and appears broken with this patch. The vertical yellow bar belongs to the left side of the diff, but is shifted to the right. The blue bar does not connect to the circle any more.
Mon, Aug 13, 7:59 AM · Season of RevisionSlider, Patch-For-Review, Easy, Need-volunteer, WMDE volunteer workboard, UI-Standardization, TCB-Team, Design, UI-Standardization-Kanban, Revision-Slider

Fri, Aug 10

thiemowmde triaged T200837: PHP Notice: Undefined index from extensions/FileImporter/src/Services/WikiTextContentCleaner.php:83 as Normal priority.

As a user reported in T198711 the mistake in the code responsible for this error also created a user-facing issue. We already resolved this via https://gerrit.wikimedia.org/r/448565, and backported to the wmf/1.32.0-wmf.14 branch via https://gerrit.wikimedia.org/r/448801. We did not bothered backporting to the wmf.13 branch since Commons was on wmf.14 already at this point in time.

Fri, Aug 10, 2:53 PM · TCB-Team, Move-Files-To-Commons, Wikimedia-log-errors
thiemowmde committed rECOG0d6bb99e610f: More specific array type hints (authored by thiemowmde).
More specific array type hints
Fri, Aug 10, 8:09 AM

Thu, Aug 9

thiemowmde committed rEFLId959ffd06cac: Use more specific array type hints where possible (authored by thiemowmde).
Use more specific array type hints where possible
Thu, Aug 9, 5:54 PM
thiemowmde committed rECOGf0a917426e36: More specific array type hints (authored by thiemowmde).
More specific array type hints
Thu, Aug 9, 5:37 PM

Sun, Aug 5

thiemowmde committed rECOG9b8e67527bcd: Minor fixes to PHPDoc tags (authored by thiemowmde).
Minor fixes to PHPDoc tags
Sun, Aug 5, 6:46 PM

Thu, Aug 2

thiemowmde committed rERSL2d5b40c40b9d: Make use of JavaScript "in" feature instead of "undefined" (authored by thiemowmde).
Make use of JavaScript "in" feature instead of "undefined"
Thu, Aug 2, 7:44 AM

Tue, Jul 31

thiemowmde added a comment to T198021: Resolve inconsistent numbering of references in text and in bibliography.

This is achieved through the use of group parameter […]

It looks like this feature was added in 2010 via T24265: Allow references to be listed with letters. Notice the discussion that followed after it was implemented. I'm working with <ref>s since they have been introduced, and are very familiar with the syntax and it's limitations. I'm very surprised this misuse of the existing group="…" parameter for styling was accepted.

Tue, Jul 31, 5:24 PM · Design, Need-volunteer, Cite
thiemowmde committed rEFLI5bc35a1734af: Add missing test cases for two Data classes (authored by thiemowmde).
Add missing test cases for two Data classes
Tue, Jul 31, 4:27 PM

Mon, Jul 30

thiemowmde committed rECOGf48394de80a1: Minor improvements to code coverage tags and type hints (authored by thiemowmde).
Minor improvements to code coverage tags and type hints
Mon, Jul 30, 8:28 AM

Sat, Jul 28

thiemowmde committed rEASR86913d5fa18a: Split ext.advancedSearch.AdvancedOptionsConfig module into three (authored by thiemowmde).
Split ext.advancedSearch.AdvancedOptionsConfig module into three
Sat, Jul 28, 10:44 AM
thiemowmde committed rEASRfa3eb670d733: Split ext.advancedSearch.AdvancedOptionsConfig module into three (authored by thiemowmde).
Split ext.advancedSearch.AdvancedOptionsConfig module into three
Sat, Jul 28, 7:06 AM

Fri, Jul 27

thiemowmde committed rEFLIaad713385b94: Fix flipped array indexes in template removal code (authored by thiemowmde).
Fix flipped array indexes in template removal code
Fri, Jul 27, 10:27 PM
thiemowmde committed rEFLI0657f37e22ce: Fix flipped array indexes in template removal code (authored by thiemowmde).
Fix flipped array indexes in template removal code
Fri, Jul 27, 10:27 PM
thiemowmde added a comment to T199768: Discourage use of is_null() with PHPCS.

I gave this a bit more time and agree that what we are discussing here is not different from, for example, (boolean) vs. (bool). However, what I don't want us to do is to disallow is_null without a proper auto-fix. is_null appears about 1600 times in 900 files: https://codesearch.wmflabs.org/search/?q=is_null\(&i=1. Having to manually deal with these would be tedious and mostly pointless, given we all agreed there is not really anything wrong with is_null. I believe such a sniff must have an auto-fix that's clever enough to understand edge-cases like the one I listed above, as well as being able to replace !is_null( $foo ) with $foo !== null.

Fri, Jul 27, 10:22 PM · Patch-For-Review, MediaWiki-Codesniffer
thiemowmde added a comment to T145932: [Bug] Special:NewItem does not validate maximum label length.

Are we really checking characters? I seem to remember something else but am not entirely sure.

Fri, Jul 27, 10:06 PM · Patch-For-Review, Wikidata-Campsite, Technical-Debt, Wikidata-Sprint-2016-09-21, MediaWiki-extensions-WikibaseRepository, Wikidata
thiemowmde committed rEFLI9c484dfd476b: Fix flipped array indexes in template removal code (authored by thiemowmde).
Fix flipped array indexes in template removal code
Fri, Jul 27, 3:29 PM
thiemowmde committed rEFLI7ed9b3a30eaf: Fix flipped array indexes in template removal code (authored by thiemowmde).
Fix flipped array indexes in template removal code
Fri, Jul 27, 3:24 PM

Wed, Jul 25

thiemowmde committed rEASRf85efc0df337: Split ext.advancedSearch.AdvancedOptionsConfig module into three (authored by thiemowmde).
Split ext.advancedSearch.AdvancedOptionsConfig module into three
Wed, Jul 25, 7:02 PM

Tue, Jul 24

thiemowmde added a comment to T199076: Moving a file to Commons should not auto-create a Commons user account for the original uploader of the file.

This got renamed and moved to the "ready for pickup" column without further discussion – at least none I can see at the moment. As I tried to explain in T199076#4407943 I am certain the Commons user account must be created. Otherwise the user can't find his own contributions any more (after the file got deleted at the source). Being able to find my own files on

as well as

and others is an essential (if not the one critical) feature FileImporter is build for.

Tue, Jul 24, 8:07 AM · Move-Files-To-Commons, TCB-Team, WMDE-QWERTY-Team

Sun, Jul 22

thiemowmde committed rERSL5f722039be74: RevisionSlider: Fix missing pin icon (authored by thiemowmde).
RevisionSlider: Fix missing pin icon
Sun, Jul 22, 10:06 AM
thiemowmde added a comment to T194613: Replace custom pin icon with OOUI's 'pushPin'.

Thanks for bringing this up!

Sun, Jul 22, 9:33 AM · Season of RevisionSlider, Patch-For-Review, Easy, Need-volunteer, WMDE volunteer workboard, UI-Standardization, TCB-Team, Design, UI-Standardization-Kanban, Revision-Slider

Wed, Jul 18

thiemowmde added a comment to T199768: Discourage use of is_null() with PHPCS.

is_null can make code more readable in cases where an extra pair of lose parenthesis would be needed anyway to make sure the operator precedence does not conflict with the intent, or when it simply helps making the intent more clear.

Wed, Jul 18, 9:26 AM · Patch-For-Review, MediaWiki-Codesniffer
thiemowmde added a comment to T199768: Discourage use of is_null() with PHPCS.

I struggle to understand how either of is_null() or === null could be clearer than the other […]

Wed, Jul 18, 9:13 AM · Patch-For-Review, MediaWiki-Codesniffer
thiemowmde updated subscribers of T199865: +2 for Matěj Suchánek in mediawiki/*.

Every interaction I had with @matej_suchanek so far was an absolute, joyful breeze. I totally support this.

Wed, Jul 18, 9:07 AM · Repository-Ownership-Requests
thiemowmde added a comment to T199768: Discourage use of is_null() with PHPCS.

Guys, I honestly don't think this is worth anybodies time. Yes, isset is problematic because of it's hidden semantics. But what is problematic about is_null? Is it not readable? Does it not do what it says it does? What is the gain win by actively forbidding it?

Wed, Jul 18, 7:09 AM · Patch-For-Review, MediaWiki-Codesniffer

Jul 16 2018

thiemowmde added a comment to T198021: Resolve inconsistent numbering of references in text and in bibliography.

[…] annoying is for people to -1 patches very quickly […], but refusing to appear on this Phab task […]

Jul 16 2018, 7:20 AM · Design, Need-volunteer, Cite

Jul 15 2018

thiemowmde committed rEFLIc0ee86e39f24: Add missing expected function argument in ImporterComponentTest (authored by thiemowmde).
Add missing expected function argument in ImporterComponentTest
Jul 15 2018, 8:56 AM
thiemowmde committed rEFLI9b234440149c: Add ImporterComponentTest case for 1 file revision (authored by thiemowmde).
Add ImporterComponentTest case for 1 file revision
Jul 15 2018, 8:56 AM
thiemowmde committed rEFLI5f5eba90b939: Allow cleanedText to be null in ImportDetails (authored by WMDE-Fisch).
Allow cleanedText to be null in ImportDetails
Jul 15 2018, 8:46 AM
thiemowmde committed rEFLI4c15b2a99ec9: Add @var docs to TestingAccessWrappers (authored by thiemowmde).
Add @var docs to TestingAccessWrappers
Jul 15 2018, 8:46 AM
thiemowmde committed rEFLI0690db9ffbff: Remove unused WebResponse variable from a test (authored by thiemowmde).
Remove unused WebResponse variable from a test
Jul 15 2018, 8:46 AM

Jul 13 2018

thiemowmde lowered the priority of T198021: Resolve inconsistent numbering of references in text and in bibliography from High to Low.

Come on. It's not even 3 weeks old.

Jul 13 2018, 7:21 AM · Design, Need-volunteer, Cite

Jul 12 2018

thiemowmde added a comment to T118498: Rename "DataType" to "PropertyType" across the code base and documentation. .

Personally, I don't think it makes sense to touch the string datatype in any machine-readable output. (In other words: I don't think this is worth a breaking change.) But I think it makes sense to prefer $propertyType as a variable name in code, and "property data type" in documentation. Especially the later. What can you loose if you do this?

Jul 12 2018, 9:22 PM · User-Addshore, Technical-Debt, Wikidata

Jul 9 2018

thiemowmde added a comment to T47134: Copyright popup specifies "save" button even if using "remove".

Legally, every edit requires the user to agree to the license. Even if the license is CC-0. Even if the edit removes something. Every edit becomes part of the CC-0 dataset, and this can only be done if every edit is compatible with CC-0.

Jul 9 2018, 4:55 PM · I18n, Wikidata, Need-volunteer, MediaWiki-extensions-WikibaseRepository
thiemowmde committed rEFLI36f841a46081: Do not bind against Message class where not necessary (authored by thiemowmde).
Do not bind against Message class where not necessary
Jul 9 2018, 3:00 PM
thiemowmde committed rEFLIab8074fd1ec1: Add missing test cases to CommonsHelperConfigParserTest (authored by thiemowmde).
Add missing test cases to CommonsHelperConfigParserTest
Jul 9 2018, 2:32 PM
thiemowmde committed rEFLI5464c5d466de: Reduce code duplication in CommonsHelperConfigParser (authored by thiemowmde).
Reduce code duplication in CommonsHelperConfigParser
Jul 9 2018, 2:32 PM
thiemowmde committed rEFLI0b11d7fd6ebf: Replace localized headings with Wikimedia Commons syntax (authored by thiemowmde).
Replace localized headings with Wikimedia Commons syntax
Jul 9 2018, 2:32 PM
thiemowmde moved T198681: Template replacements are made 1 revision too early from Incoming to Move files to Commons on the TCB-Team board.
Jul 9 2018, 1:31 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, WMDE-QWERTY-Sprint-2018-07-03, TCB-Team, Move-Files-To-Commons
thiemowmde moved T198709: Rename misleading "Submit" buttons on title/wikitext edit forms from Incoming to Move files to Commons on the TCB-Team board.
Jul 9 2018, 1:31 PM · WMDE-Design, TCB-Team, Design, Move-Files-To-Commons
thiemowmde moved T198711: Remove templates as indicated by the config files from Incoming to Move files to Commons on the TCB-Team board.
Jul 9 2018, 1:30 PM · MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), WMDE-QWERTY-Sprint-2018-07-17, Patch-For-Review, TCB-Team, WMDE-QWERTY-Sprint-2018-07-03, Move-Files-To-Commons
thiemowmde moved T199076: Moving a file to Commons should not auto-create a Commons user account for the original uploader of the file from Incoming to Move files to Commons on the TCB-Team board.
Jul 9 2018, 1:30 PM · Move-Files-To-Commons, TCB-Team, WMDE-QWERTY-Team
thiemowmde moved T199108: Block all imports if no configuration file for a source wiki exists from Incoming to Move files to Commons on the TCB-Team board.
Jul 9 2018, 1:30 PM · TCB-Team, Move-Files-To-Commons
thiemowmde triaged T199110: Link log entries, page creations, and edits to the users CentralAuth account as High priority.
Jul 9 2018, 1:30 PM · TCB-Team, Move-Files-To-Commons
thiemowmde created T199110: Link log entries, page creations, and edits to the users CentralAuth account.
Jul 9 2018, 1:29 PM · TCB-Team, Move-Files-To-Commons
thiemowmde created T199108: Block all imports if no configuration file for a source wiki exists.
Jul 9 2018, 1:12 PM · TCB-Team, Move-Files-To-Commons
thiemowmde added a comment to T199076: Moving a file to Commons should not auto-create a Commons user account for the original uploader of the file.

This ticket confuses me. Auto-creating the user in a CentralAuth a.k.a. SUL environment is the right thing to do, and a technical prerequisite for other features we want (e.g. properly linking the edits to the users own [[Special:Contributions]]).

Jul 9 2018, 12:58 PM · Move-Files-To-Commons, TCB-Team, WMDE-QWERTY-Team
thiemowmde committed rEFLI7c230317d566: Add missing test cases to CommonsHelperConfigParserTest (authored by thiemowmde).
Add missing test cases to CommonsHelperConfigParserTest
Jul 9 2018, 12:33 PM
thiemowmde committed rEFLI5ea96a2a2267: Replace localized headings with Wikimedia Commons syntax (authored by thiemowmde).
Replace localized headings with Wikimedia Commons syntax
Jul 9 2018, 12:32 PM
thiemowmde committed rEFLI285c80105690: Clean-up and fix bad validation in CommonsHelperConfigParser (authored by thiemowmde).
Clean-up and fix bad validation in CommonsHelperConfigParser
Jul 9 2018, 12:32 PM
thiemowmde committed rEFLI477b1acfa043: Relax template parser return format (authored by thiemowmde).
Relax template parser return format
Jul 9 2018, 12:32 PM
thiemowmde committed rEFLI106acb7a5875: Replace localized headings with Wikimedia Commons syntax (authored by thiemowmde).
Replace localized headings with Wikimedia Commons syntax
Jul 9 2018, 10:52 AM
thiemowmde committed rEBTX0f9ecbe07771: Fix typo in word string (authored by Umherirrender).
Fix typo in word string
Jul 9 2018, 9:56 AM
thiemowmde committed rEFLI1fca19116f8b: Test unedited/edited requests separately in ImporterComponentTest (authored by thiemowmde).
Test unedited/edited requests separately in ImporterComponentTest
Jul 9 2018, 8:58 AM

Jul 8 2018

thiemowmde added a comment to T117659: mwext-testextension-zend should load extension mathsearch after math.

Please change this code to not use any of the Wikibase constants, but read the incoming format as MIME type. E.g. see if the format string starts with "text/html".

Jul 8 2018, 8:29 AM · Patch-For-Review, MathSearch, Continuous-Integration-Config

Jul 6 2018

thiemowmde committed rEFLIc4e36b162a1b: Replace localized headings with Wikimedia Commons syntax (authored by thiemowmde).
Replace localized headings with Wikimedia Commons syntax
Jul 6 2018, 2:06 PM
thiemowmde claimed T198317: Replace localized "Description" and "Licensing" headings with {{int:…}} syntax.
Jul 6 2018, 1:17 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, WMDE-QWERTY-Sprint-2018-07-03, TCB-Team, Move-Files-To-Commons
thiemowmde moved T198317: Replace localized "Description" and "Licensing" headings with {{int:…}} syntax from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-07-03 board.
Jul 6 2018, 1:16 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, WMDE-QWERTY-Sprint-2018-07-03, TCB-Team, Move-Files-To-Commons
thiemowmde committed rEFLIb0549bb31d70: [WIP] Mark code that needs to be worked on with FIXMEs (authored by thiemowmde).
[WIP] Mark code that needs to be worked on with FIXMEs
Jul 6 2018, 10:15 AM
thiemowmde committed rEFLI1ee4ca8a03a9: [WIP] Update ImporterComponentTest to use NullRevisionCreator (authored by thiemowmde).
[WIP] Update ImporterComponentTest to use NullRevisionCreator
Jul 6 2018, 10:09 AM
thiemowmde committed rEFLI1cfb36d61552: Test unedited/edited requests separately in ImporterComponentTest (authored by thiemowmde).
Test unedited/edited requests separately in ImporterComponentTest
Jul 6 2018, 10:05 AM
thiemowmde committed rEFLI65bb762039bd: [WIP] Update ImporterComponentTest to use NullRevisionCreator (authored by thiemowmde).
[WIP] Update ImporterComponentTest to use NullRevisionCreator
Jul 6 2018, 9:48 AM