Page MenuHomePhabricator

thiemowmde (Thiemo Kreuz (WMDE))
Software Developer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 11:45 AM (237 w, 1 d)
Availability
Available
IRC Nick
Thiemo_WMDE
LDAP User
Thiemo Kreuz (WMDE)
MediaWiki User
Thiemo Kreuz (WMDE) [ Global Accounts ]

Recent Activity

Today

thiemowmde committed rESCCfa7d4b41a819: Prevent HTML entities from being decoded automatically (authored by Andrew-WMDE).
Prevent HTML entities from being decoded automatically
Thu, Apr 25, 4:14 PM
thiemowmde committed rESCC6e39b6d5369b: Prevent HTML entities from being decoded automatically (authored by Andrew-WMDE).
Prevent HTML entities from being decoded automatically
Thu, Apr 25, 3:29 PM
thiemowmde committed rESCC25adbc3efe4e: Prevent HTML entities from being decoded automatically (authored by Andrew-WMDE).
Prevent HTML entities from being decoded automatically
Thu, Apr 25, 3:07 PM
thiemowmde committed rESCC890a130f7fe8: Remove unused boolean flag from …DiffFormatter::composeLines() (authored by thiemowmde).
Remove unused boolean flag from …DiffFormatter::composeLines()
Thu, Apr 25, 2:55 PM
thiemowmde committed rESCCcf2616480b03: Add missing test cases to LineBasedUnifiedDiffFormatterTest (authored by thiemowmde).
Add missing test cases to LineBasedUnifiedDiffFormatterTest
Thu, Apr 25, 2:55 PM
thiemowmde committed rESCC66b6da912daa: Remove unused boolean flag from …DiffFormatter::composeLines() (authored by thiemowmde).
Remove unused boolean flag from …DiffFormatter::composeLines()
Thu, Apr 25, 1:36 PM
thiemowmde added a comment to T220657: Establish Architecture Principles as a policy.

I think I have to go crazy right now. By saying that wikitext is not allowed to be part of any API any more you are banning APIs like export and action=edit that either return or expect wikitext. It even bans the action=parse API whose entire purpose is to accept wikitext. Neither of these APIs does make any sense any more when we require clients to not have any knowledge about wikitext any more.

Thu, Apr 25, 1:09 PM · TechCom-RFC, TechCom
thiemowmde committed rESCC927a041e15b1: Remove unused boolean flag from …DiffFormatter::composeLines() (authored by thiemowmde).
Remove unused boolean flag from …DiffFormatter::composeLines()
Thu, Apr 25, 12:45 PM
thiemowmde committed rESCCb7314407aa09: Remove unused boolean flag from …DiffFormatter::composeLines() (authored by thiemowmde).
Remove unused boolean flag from …DiffFormatter::composeLines()
Thu, Apr 25, 12:01 PM
thiemowmde committed rESCCfb9835864f2c: Prevent HTML entities from being decoded automatically (authored by Andrew-WMDE).
Prevent HTML entities from being decoded automatically
Thu, Apr 25, 11:57 AM
thiemowmde committed rESCCe0e9ef073f15: Remove unused private …ConflictHelper::getOutput() method (authored by thiemowmde).
Remove unused private …ConflictHelper::getOutput() method
Thu, Apr 25, 11:16 AM
thiemowmde added a comment to T220718: URLs with no slashes after domain name are "invalid" but are still shortened.

I just run into the same problem with https://de.wikipedia.org (= https://w.wiki/49) vs. https://de.wikipedia.org/ (= https://w.wiki/Ga).

Thu, Apr 25, 10:59 AM · MediaWiki-extensions-UrlShortener
thiemowmde awarded T220718: URLs with no slashes after domain name are "invalid" but are still shortened a Like token.
Thu, Apr 25, 10:53 AM · MediaWiki-extensions-UrlShortener
thiemowmde triaged T220923: URL Shortener Should Not Mystery Meat Important Links as High priority.
Thu, Apr 25, 10:53 AM · MediaWiki-extensions-UrlShortener
thiemowmde added a comment to T213704: Wikidata Tours don't load correctly.

you would be able to fix this issue if you were given it as a task by your line manager?

Thu, Apr 25, 10:32 AM · User-Mrjohncummings, Wikidata-Campsite, User-Sebastian_Berlin-WMSE, Wikidata
thiemowmde added a comment to T220657: Establish Architecture Principles as a policy.

The purpose of the API is to provide or convey a specific piece of information, not a format.

Thu, Apr 25, 10:18 AM · TechCom-RFC, TechCom

Yesterday

thiemowmde added a comment to T210281: Find a better way to highligth letters then bold.

Thanks a lot for bringing this up! This is certainly a very relevant issue with the idea I presented above. Applying the padding only on one character is a neat idea. The one issue with this approach is that it causes a reflow every time the padding appears and disappears. But this might be acceptable.

Wed, Apr 24, 5:13 PM · WMDE-Design, Cite, Design, TCB-Team
thiemowmde added a comment to T213410: Start using PHP 7.0 features in WMDE maintained extensions.

The bump to 1.27 was fine, thanks a lot for that! But to mark this task here as resolved we would need to bump to 1.31 (assuming my analysis in the task description was correct), and actually start using PHP 7.0 features in the listed codebases.

Wed, Apr 24, 4:46 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, WMDE-MediaWiki-maintenance, User-thiemowmde, Electron-PDFs, Advanced-Search, Revision-Slider, Move-Files-To-Commons, Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde awarded T220196: Reference previews broken with umlauts on named references a Love token.
Wed, Apr 24, 4:17 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, WMDE-QWERTY-Sprint-2019-04-17, Reference Previews, TCB-Team
thiemowmde added a comment to T213704: Wikidata Tours don't load correctly.

I believe we run into a very similar issue in the tour we have in the Two-Column-Edit-Conflict-Merge extension, see T195713: Have an intro tour (No. 2) as well as the patch https://gerrit.wikimedia.org/r/456176. The issue was that all the positions have been calculated to early, directly after the page finished loading. The moment the positions became relevant (i.e. the user clicked a button and the next popup was shown), all the other elements on the page could have been moved, i.e. when the user resized the browser window in the meantime, or a lazy-loading gadget made parts of the page reflow. I guess something similar might happen here. I know some quite relevant parts of the Wikibase UI (term box, collapsing references and qualifiers) only show up after the basic page loaded.

Wed, Apr 24, 3:53 PM · User-Mrjohncummings, Wikidata-Campsite, User-Sebastian_Berlin-WMSE, Wikidata
thiemowmde triaged T221236: RfC: self vs <ClassName> for class self-references as Normal priority.
Wed, Apr 24, 2:58 PM · MediaWiki-Codesniffer
thiemowmde committed rESCCb9323bca0efa: Prevent HTML entities from being decoded automatically (authored by Andrew-WMDE).
Prevent HTML entities from being decoded automatically
Wed, Apr 24, 1:15 PM
thiemowmde closed T128710: Create a Lua infobox template for books that use wikidata metadata based on work/edition as Invalid.
  • It was the author of this task who closed it.
  • The task description was not very specific and actionable to begin with.
  • This is something the Wikisource community can better manage on-wiki. I don't think they need this ticket to be able to do what the task asks for.
Wed, Apr 24, 1:01 PM · patch-welcome, Wikisource, Wikidata
thiemowmde added a comment to T220657: Establish Architecture Principles as a policy.

What situations are those? If something is expected to return wikitext, the API should have an option to parse it and return HTML. That's not hard to achieve.

Wed, Apr 24, 10:53 AM · TechCom-RFC, TechCom
thiemowmde added a comment to T219001: Doxygen doesn't handle `@inheritDoc` by default, only `@inheritdoc`.

I, personally, would push for #3. Ideally not just with a bug report, but an actual pull request. In the meantime we can apply #2 as a temporary workaround. @Legoktm, is it possibly to use our almighty Libraryupgrader to update all Doxyfile?

Wed, Apr 24, 9:30 AM · Upstream, Patch-For-Review, MediaWiki-Codesniffer, Documentation, MediaWiki-Documentation
thiemowmde triaged T221752: Cognate data is not restored (any more) on page undeletion as High priority.
Wed, Apr 24, 9:04 AM · Wikidata-Campsite, Core Platform Team, Wikidata, Cognate
thiemowmde created T221752: Cognate data is not restored (any more) on page undeletion.
Wed, Apr 24, 9:04 AM · Wikidata-Campsite, Core Platform Team, Wikidata, Cognate
thiemowmde committed rECOG1dcf6659fb08: Fix Phan errors with return values and Database type hints (authored by aaron).
Fix Phan errors with return values and Database type hints
Wed, Apr 24, 8:53 AM

Fri, Apr 12

thiemowmde added a comment to T220657: Establish Architecture Principles as a policy.

Issues I see in the current text:

  • The introduction makes it sound like it would be possible to always comply to all principles the same time, just by trying hard enough. In reality such principles often conflict with each other. Our job is more to find a good balance. I wish the introduction would accept and mention this. I certainly don't want anybody to pick a single principle from the list, run around and make everybodies life hard who needs to balance all of them, and isn't able to fully comply to one because of this.
  • "MUST be designed to avoid any need for clients to process wikitext." I find combining a "MUST" with an "avoid" confusing and dangerous. I feel this needs to be a "SHOULD". There are certainly situations where it is not possible to "avoid" wikitext entirely. What happens then? Does the "MUST" still allow users to enforce this rule and block patches?
Fri, Apr 12, 7:06 PM · TechCom-RFC, TechCom

Thu, Apr 11

thiemowmde added a comment to T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text.

Asking users to provide "legitimate reasons" to be allowed to use one of the (literally) most basic characters is, … how to put this? It scares me. It's like asking users to provide "legitimate reasons" to use Wikidata with a screenreader software, or asking users to first provide "legitimate reasons" why they want to become a community member before they are allowed to do their first edit.

Thu, Apr 11, 8:35 PM · Wikidata-Campsite, Patch-For-Review, Wikidata
thiemowmde added a comment to T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text.

Sorry for writing so much, but I feel there is an important lesson to learn here, despite this appearing like it would be a minor thing. I feel this highlights a quite fundamental misunderstanding.

Thu, Apr 11, 8:20 PM · Wikidata-Campsite, Patch-For-Review, Wikidata
thiemowmde added a comment to T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text.

Item pages should split alias entries containing | character to be consistent with Special:SetAliases

Thu, Apr 11, 5:37 PM · Wikidata-Campsite, Patch-For-Review, Wikidata
thiemowmde awarded T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text a Dislike token.
Thu, Apr 11, 5:32 PM · Wikidata-Campsite, Patch-For-Review, Wikidata
thiemowmde updated subscribers of T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text.

I'm afraid I have to agree with @Addshore here. Sure, it might be that many of the aliases that currently contain pipe characters are mistakes. It might even be the vast majority. But even if this is the case, …

  • There are certainly items that actually have a title or alternative titles that require the use of one or more pipe characters. Why should we ban them from the Wikidata knowledge base? Just because of a bug? Why not fix it instead? I drafted a few alternatives above.
  • Disallowing a random low-ASCII (!) character just feels wrong. Again, why? Why not, let's say, disallow comma, semicolon, and more non-alphanumeric characters as well? They all might be from a broken import.
  • Wikibase disallows tabs and vertical whitespace (newlines and such) for good reasons. But we never blocked the use of a visible character, as far as I'm aware of.
Thu, Apr 11, 5:32 PM · Wikidata-Campsite, Patch-For-Review, Wikidata

Wed, Apr 10

thiemowmde added a comment to T220432: Clean up "easter egg" short URLs before extension goes live.

This thread makes me cry. We are not opening a domain registry or something like this here. We are not going to install a bidding or voting process for the most wanted IDs. These IDs are effectively random. You get the next ID that is free the moment you use the service. And then it's gone. There is no going back. There is no reassigning, no veto, no discussion. That's not the purpose of a URL shortener. If you need a meaningful, self-explaining URL, than for heavens sake use the original URL.

Wed, Apr 10, 7:38 AM · MediaWiki-extensions-UrlShortener
thiemowmde added a comment to T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text.

I'm sorry for my rude comment at https://gerrit.wikimedia.org/r/502530. I made that in a hurry.

Wed, Apr 10, 7:03 AM · Wikidata-Campsite, Patch-For-Review, Wikidata

Mon, Apr 8

thiemowmde committed rESCCa88e5d3cfc55: Mark unused ConflictHelper methods as private (authored by thiemowmde).
Mark unused ConflictHelper methods as private
Mon, Apr 8, 3:01 PM
thiemowmde added a comment to T219727: UnexpectedValueException: The title "Discussioni utente:Barstein" does not refer to an existing page.

I was just looking for the page and found it exists: https://it.wikipedia.org/wiki/Discussioni_utente:Barstein

Mon, Apr 8, 12:59 PM · TCB-Team, Wikimedia-production-error, Two-Column-Edit-Conflict-Merge

Fri, Apr 5

Mill <mill@mail.com> committed rEWLE1893fe93af6e: kkbaaaaaaaaaaa (authored by thiemowmde).
kkbaaaaaaaaaaa
Fri, Apr 5, 10:42 PM

Tue, Apr 2

thiemowmde committed rEFLI35b730d3b3c8: Allow multiple source parameters map to same target parameter (authored by thiemowmde).
Allow multiple source parameters map to same target parameter
Tue, Apr 2, 6:29 PM
thiemowmde moved T143597: Consider using prefix search for Special:Search integration from Doing to To Do Next on the ArticlePlaceholder board.
Tue, Apr 2, 10:29 AM · Wikidata-Sprint-2016-09-06, Wikidata-Sprint-2016-08-30, Wikidata-Sprint-2016-08-16, Patch-For-Review, Wikidata, ArticlePlaceholder
thiemowmde placed T143597: Consider using prefix search for Special:Search integration up for grabs.
Tue, Apr 2, 10:28 AM · Wikidata-Sprint-2016-09-06, Wikidata-Sprint-2016-08-30, Wikidata-Sprint-2016-08-16, Patch-For-Review, Wikidata, ArticlePlaceholder
thiemowmde added a comment to T215897: Update Popups Extension page.

Done.

Tue, Apr 2, 9:03 AM · WMDE-QWERTY-Sprint-2019-04-03, WMDE-QWERTY-Season-Sprint-2019-03-20, WMDE-QWERTY-Sprint-2019-03-06, Reference Previews

Sun, Mar 31

thiemowmde moved T218770: Improve UI glitch in user name bubble from Doing to Prioritized on the WMDE-QWERTY-Season-Sprint-2019-03-20 board.
Sun, Mar 31, 8:25 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), WMDE-QWERTY-Sprint-2019-04-03, Patch-For-Review, TCB-Team, WMDE-QWERTY-Season-Sprint-2019-03-20, Revision-Slider
thiemowmde placed T218770: Improve UI glitch in user name bubble up for grabs.
Sun, Mar 31, 8:25 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), WMDE-QWERTY-Sprint-2019-04-03, Patch-For-Review, TCB-Team, WMDE-QWERTY-Season-Sprint-2019-03-20, Revision-Slider

Thu, Mar 28

thiemowmde added a comment to T219434: No popup is shown when quickly hovering the same link twice.

We are investigating this. But since this is about code none of us here at WMDE wrote, we would love if your team could pick this task up.

Thu, Mar 28, 3:07 PM · WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, Readers-Web-Backlog, Patch-For-Review, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews

Wed, Mar 27

thiemowmde added a parent task for T219434: No popup is shown when quickly hovering the same link twice: T218765: Show referencePreviews on click.
Wed, Mar 27, 6:30 PM · WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, Readers-Web-Backlog, Patch-For-Review, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews
thiemowmde added a subtask for T218765: Show referencePreviews on click: T219434: No popup is shown when quickly hovering the same link twice.
Wed, Mar 27, 6:30 PM · WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, Patch-For-Review, WMDE-QWERTY-Season-Sprint-2019-03-20, Reference Previews
thiemowmde triaged T219434: No popup is shown when quickly hovering the same link twice as High priority.
Wed, Mar 27, 6:29 PM · WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, Readers-Web-Backlog, Patch-For-Review, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews
thiemowmde created T219434: No popup is shown when quickly hovering the same link twice.
Wed, Mar 27, 6:27 PM · WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, Readers-Web-Backlog, Patch-For-Review, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews

Tue, Mar 26

D3r1ck01 awarded T219306: 20% maintenance tasks in QWERTY sprint 2019-03-20 a Mountain of Wealth token.
Tue, Mar 26, 8:33 PM · TCB-Team, WMDE-QWERTY-Season-Sprint-2019-03-20
Krinkle awarded T219306: 20% maintenance tasks in QWERTY sprint 2019-03-20 a Orange Medal token.
Tue, Mar 26, 5:46 PM · TCB-Team, WMDE-QWERTY-Season-Sprint-2019-03-20
thiemowmde moved T219306: 20% maintenance tasks in QWERTY sprint 2019-03-20 from Backlog to Doing on the WMDE-QWERTY-Season-Sprint-2019-03-20 board.
Tue, Mar 26, 5:10 PM · TCB-Team, WMDE-QWERTY-Season-Sprint-2019-03-20
thiemowmde created T219306: 20% maintenance tasks in QWERTY sprint 2019-03-20.
Tue, Mar 26, 5:10 PM · TCB-Team, WMDE-QWERTY-Season-Sprint-2019-03-20

Mar 26 2019

thiemowmde awarded T218574: Add rollback confirmation code to existing module instead of registering a new one a Like token.
Mar 26 2019, 4:23 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Performance-Team (Radar), WMDE-FUN-Sprint-2019-03-18, Confirmation prompt for rollback action, WMDE-FUN-Team
thiemowmde added a comment to T198609: Investigate if magic words `%AUTHOR%` and `%TRANSFERUSER%` are needed.

Dear PM. My advice here would be to ditch these %…% tags. We should remove them from all config pages as well as help pages to not confuse people. Both the original uploader of a file as well as the user doing the transfer are well tracked when using FileImporter, and clearly visible in the page history, upload and import logs, user contributions, and such. This is an essential feature of the extension, in contrast to CommonsHelper where all uploads are done by the same bot account.

Mar 26 2019, 4:18 PM · TCB-Team, Move-Files-To-Commons
thiemowmde added a comment to T198315: Investigate what the "Template" part of the "Information" section in the config files is supposed to do.

Dear PM. My advice her would be to close this ticket as resolved. The result of the investigation is that we don't need the "Information" section. We should remove it from all config pages to not confuse people.

Mar 26 2019, 4:12 PM · TCB-Team, Move-Files-To-Commons

Mar 25 2019

thiemowmde renamed T219154: Change Popups user setting description to also fit reference previews from Change Popups user setting descritpion to also fit reference previews to Change Popups user setting description to also fit reference previews.
Mar 25 2019, 1:25 PM · Readers-Web-Backlog, Page-Previews, Reference Previews, TCB-Team
thiemowmde triaged T219154: Change Popups user setting description to also fit reference previews as Low priority.

Isn't this a duplicate of T219153: Change Popups descriptive title to also fit reference previews?

Mar 25 2019, 1:25 PM · Readers-Web-Backlog, Page-Previews, Reference Previews, TCB-Team
thiemowmde triaged T219153: Change Popups descriptive title to also fit reference previews as Low priority.
Mar 25 2019, 1:24 PM · Readers-Web-Backlog, Page-Previews, Reference Previews, TCB-Team
thiemowmde added a comment to T219139: Avoid use of isset( ..., ..., [...] ) function construct / syntax.

My suggestion is to simply add this to the ForbiddenFunctions sniff. I suggest to not invest time on an auto-fix. Code that calls isset( …, … ) with multiple arguments is so rare, it's probably more effective to just manually fix these few places than to write, review, and maintain an auto-fix.

Mar 25 2019, 12:54 PM · MediaWiki-Codesniffer
thiemowmde added a comment to T215897: Update Popups Extension page.

I did another update:

  • Removed all configuration settings that don't exist any more.
  • It said the popup would show when a page was edited. This is not true any more. I removed it.
  • I moved the description of our Reference Previews configuration down into the configuration section.
Mar 25 2019, 10:36 AM · WMDE-QWERTY-Sprint-2019-04-03, WMDE-QWERTY-Season-Sprint-2019-03-20, WMDE-QWERTY-Sprint-2019-03-06, Reference Previews

Mar 21 2019

thiemowmde committed rENPUe8bbd1ab6061: Update .phpcs.xml issues and fix an undeclared variable (authored by thiemowmde).
Update .phpcs.xml issues and fix an undeclared variable
Mar 21 2019, 5:50 PM
thiemowmde added a comment to T218844: Update Gerrit /r/p/ links to /r/.

As far as I understand this ticket here, it is

  1. exclusively about Gerrit links.
  2. exclusively about links that are used to clone a repository.
Mar 21 2019, 4:03 PM · User-zeljkofilipin, Patch-For-Review, good first bug, Documentation, Epic, Wikimedia-General-or-Unknown, Gerrit
thiemowmde committed rEASRd7a0ab482385: Update outdated documentation and links in settings.md (authored by Nikitrain).
Update outdated documentation and links in settings.md
Mar 21 2019, 4:02 PM
thiemowmde added a comment to T218844: Update Gerrit /r/p/ links to /r/.

What are the exact steps to see that breakage? […]

Mar 21 2019, 3:26 PM · User-zeljkofilipin, Patch-For-Review, good first bug, Documentation, Epic, Wikimedia-General-or-Unknown, Gerrit
thiemowmde added a comment to T218844: Update Gerrit /r/p/ links to /r/.

May I ask why all the patches uploaded so far actually break URLs that worked before?

Mar 21 2019, 2:54 PM · User-zeljkofilipin, Patch-For-Review, good first bug, Documentation, Epic, Wikimedia-General-or-Unknown, Gerrit
thiemowmde committed rEASR92ea83048187: Change `/r/p/` to `/r/` for gerrit links (authored by Nikitrain).
Change `/r/p/` to `/r/` for gerrit links
Mar 21 2019, 2:44 PM
Mill <mill@mail.com> committed rESCCcf60e3cf2d32: weaaaaaaaaaaaa (authored by thiemowmde).
weaaaaaaaaaaaa
Mar 21 2019, 12:30 AM
thiemowmde committed rESCCd72617246bc1: Avoid expensive WebRequest::getVal() where possible (authored by thiemowmde).
Avoid expensive WebRequest::getVal() where possible
Mar 21 2019, 12:30 AM
thiemowmde committed rESCCbb6888bbbc26: Replace all remaining pause() with a chain of then() (authored by thiemowmde).
Replace all remaining pause() with a chain of then()
Mar 21 2019, 12:30 AM
thiemowmde committed rESCC630a4a5eeda1: Remove all remaining pause() (authored by thiemowmde).
Remove all remaining pause()
Mar 21 2019, 12:30 AM
thiemowmde committed rESCCfea5815eb360: Merge ….BaseVersionSelector module into ….initJs module (authored by thiemowmde).
Merge ….BaseVersionSelector module into ….initJs module
Mar 21 2019, 12:30 AM
Mill <mill@mail.com> committed rEASRb5cf398ad6e3: snaaaaaaaaaaaa (authored by thiemowmde).
snaaaaaaaaaaaa
Mar 21 2019, 12:28 AM
Mill <mill@mail.com> committed rADES8737cba948ea: 5%5eaaaaaaaaaaaa (authored by thiemowmde).
5%5eaaaaaaaaaaaa
Mar 21 2019, 12:19 AM
Mill <mill@mail.com> committed rADES5d20b24750cf: $%2aaaaaaaaaaaaa (authored by thiemowmde).
$%2aaaaaaaaaaaaa
Mar 21 2019, 12:19 AM
Mill <mill@mail.com> committed rADESe7c36889c7c4: !%2aaaaaaaaaaaaa (authored by thiemowmde).
!%2aaaaaaaaaaaaa
Mar 21 2019, 12:19 AM
Mill <mill@mail.com> committed rADESdc42e22e3acc: %26%2aaaaaaaaaaaaa (authored by thiemowmde).
%26%2aaaaaaaaaaaaa
Mar 21 2019, 12:19 AM
Mill <mill@mail.com> committed rEFILEEXPORTe3bac53380db: (naaaaaaaaaaaa (authored by thiemowmde).
(naaaaaaaaaaaa
Mar 21 2019, 12:11 AM
Mill <mill@mail.com> committed rEFLI37910790f644: fwaaaaaaaaaaaa (authored by thiemowmde).
fwaaaaaaaaaaaa
Mar 21 2019, 12:10 AM
Mill <mill@mail.com> committed rEFLIb4b203a30317: 8zaaaaaaaaaaaa (authored by thiemowmde).
8zaaaaaaaaaaaa
Mar 21 2019, 12:10 AM
Mill <mill@mail.com> committed rEFLI8afd65b32bec: 0zaaaaaaaaaaaa (authored by thiemowmde).
0zaaaaaaaaaaaa
Mar 21 2019, 12:10 AM
Mill <mill@mail.com> committed rEFLI597a9c45f3f8: 86aaaaaaaaaaaa (authored by thiemowmde).
86aaaaaaaaaaaa
Mar 21 2019, 12:10 AM

Mar 20 2019

thiemowmde awarded T218324: MediaWiki.Commenting.FunctionComment.DefaultNullTypeParam wants redundant "mixed|null" a Like token.
Mar 20 2019, 8:18 PM · Patch-For-Review, MediaWiki-Codesniffer
thiemowmde added a comment to T218816: MediaWiki.Commenting.FunctionComment.DefaultNullTypeParam wants null even if type is nullable.

Call me oldskool, but I find string|null much more readable. The question mark not only looks like a misplaced character, it can also be very confusing to see all these special characters in the same line:

  • @foo
  • ?foo
  • &$foo

It's like we are trying to come up with a new markup language here where all special characters have a different meaning, and everybody needs to memorize all this noise to be able to read it. Can we avoid this? Less is more. We will always use the | character in documentation, e.g. for stuff like string[]|string. Why not continue to use it?

Mar 20 2019, 8:17 PM · MediaWiki-Codesniffer
thiemowmde archived WMDE-QWERTY-Sprint-2019-02-20.
Mar 20 2019, 1:18 PM
thiemowmde moved T215063: Rename link in footer to "Jump to footnote" from Backlog to Demo on the WMDE-QWERTY-Season-Sprint-2019-03-20 board.

@Lea_WMDE, with the two patches linked above all messages are now consistently talking about "references" again, not "footnotes".

Mar 20 2019, 1:06 PM · WMDE-QWERTY-Season-Sprint-2019-03-20, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Reference Previews
thiemowmde placed T215063: Rename link in footer to "Jump to footnote" up for grabs.
Mar 20 2019, 1:05 PM · WMDE-QWERTY-Season-Sprint-2019-03-20, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Reference Previews

Mar 19 2019

thiemowmde added a project to T143419: Insights/ Voices from the Community for the page protection wish (#7): German-Community-Wishlist-Main-Wishes.
Mar 19 2019, 9:27 AM · German-Community-Wishlist-Main-Wishes, MediaWiki-Page-protection, TCB-Team
thiemowmde reassigned T168956: Meta issue: Technical Wishlist Usability testing 7-2017 from thiemowmde to Jan_Dittrich.
Mar 19 2019, 9:25 AM · WMDE-Design, Design, TCB-Team
thiemowmde closed T168956: Meta issue: Technical Wishlist Usability testing 7-2017 as Resolved.
Mar 19 2019, 9:25 AM · WMDE-Design, Design, TCB-Team
thiemowmde triaged T218583: Document AdvancedSearchDeepcatEnabled setting as Normal priority.
Mar 19 2019, 7:30 AM · good first bug, Documentation, TCB-Team, Advanced-Search

Mar 18 2019

thiemowmde created T218583: Document AdvancedSearchDeepcatEnabled setting.
Mar 18 2019, 3:04 PM · good first bug, Documentation, TCB-Team, Advanced-Search
thiemowmde committed rESCC05f580208be4: TwoColConflictHooks: Minor cleanup in the Hooks class (authored by D3r1ck01).
TwoColConflictHooks: Minor cleanup in the Hooks class
Mar 18 2019, 1:48 PM
thiemowmde triaged T218105: reference#fetchPreviewForTitle() should use model constructor as Low priority.

I agree with the acceptance criteria. But I, personally, would not try to squeeze every code path through the existing createModel() helper method. I suspect this helper method is what is meant when this task talks about a "constructor"?

Mar 18 2019, 12:21 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Page-Previews, Patch-For-Review, Reference Previews, Technical-Debt, Readers-Web-Backlog
thiemowmde committed rESCC2bd3a5ac649b: Remove pause() from tests (authored by thiemowmde).
Remove pause() from tests
Mar 18 2019, 8:34 AM

Mar 17 2019

thiemowmde added a comment to T217835: PHP Fatal Error: Argument 1 passed to SpecialCollection::postZip() must be an instance of array, bool given.

Oh dear. I would like to point out that it was not really the type hint I added who is creating an issue here. What the type hint did was making an existing issue visible. The actual issue is this code:

$title = Title::newFromText( $request->getVal( 'colltitle', '' ) );
if ( !$title ) {
    return;
}
$collection = $this->loadCollection( $title );
// …
$this->postZip( $collection, $partner );

Along with this code:

private function loadCollection( $title, $append = false ) {
    if ( !$title->exists() ) {
        // …
        return false;
    }

What this means:

  • When the user provides a string that is not a valid title, it is silently ignored.
  • When the user provides a valid page name that doesn't exist, postZip() is called with $collection set to false, which triggered an inherently broken API request before.

This misbehavior is now blocked by the type hint.

Mar 17 2019, 7:58 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Collection, Wikimedia-production-error
thiemowmde closed T218472: gerrit.wikimedia.org is down as Resolved.

Gerrit is not "down" any more, reopening this was a mistake. Sorry.

Mar 17 2019, 7:36 PM · User-greg, Operations, Release-Engineering-Team, Gerrit
thiemowmde closed T218507: I'm refused to login to Gerrit as Invalid.

I'm in contact with the security team. Long story short: It's not me.

Mar 17 2019, 5:00 PM · Operations, Release-Engineering-Team, Gerrit
thiemowmde reopened T218472: gerrit.wikimedia.org is down as "Open".

I can't login to Gerrit any more. I created T218507, not knowing what was going on. Given this ticket doesn't explain much, I still don't know.

Mar 17 2019, 11:26 AM · User-greg, Operations, Release-Engineering-Team, Gerrit