Page MenuHomePhabricator

thiemowmde (Thiemo Kreuz (WMDE))
Software Developer

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 11:45 AM (286 w, 2 d)
Availability
Available
IRC Nick
Thiemo_WMDE
LDAP User
Thiemo Kreuz (WMDE)
MediaWiki User
Thiemo Kreuz (WMDE) [ Global Accounts ]

Recent Activity

Thu, Apr 2

thiemowmde added a comment to T148701: Automatic references list after page-terminal ordered or bullet list generates unbalanced HTML.

I'm sorry for the revert. It turns out I missed the fact this only affects pages that don't have a <references /> tag. These should indeed be rare. Not only that. I can not really think of a situation where a user was intentionally using this as a feature. The auto-generated <references /> was appended to the end of the page with no separation. This either does not have any effect, or causes bug, as explained in this ticket.

Thu, Apr 2, 11:46 AM · Patch-For-Review, Editing-team (Q3 2019-2020 Kanban Board), good first task, Cite

Wed, Apr 1

thiemowmde added a comment to T214495: Delete several deprecated WMDE tools.

What's the state of these specific tools?

  • Killing Phragile sounds iffy. Are we sure we never want to use it again?
  • That commons-mass-upload tool sounds like something we gave to museums and such so they can quickly upload many files. Again, are we sure nobody at WMDE still refers to this?
Wed, Apr 1, 11:16 AM · Toolforge (Tools to be deleted), Projects-Cleanup
thiemowmde added a comment to T249093: Redirect link to dewiki talk page in message for feedback.

Just to be sure I checked again. In the German Wikipedia the message doesn't talk about "Beta" any more. The correct message is used.

Wed, Apr 1, 11:09 AM · WMDE-QWERTY-Sprint-2020-04-01, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde added a comment to T249093: Redirect link to dewiki talk page in message for feedback.

I changed the wrong message. More precisely: I changed only 1 of 2 messages. The other one is now fixed as well: https://translatewiki.net/wiki/MediaWiki:Twocolconflict-split-header-hint/de

Wed, Apr 1, 11:07 AM · WMDE-QWERTY-Sprint-2020-04-01, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T249093: Redirect link to dewiki talk page in message for feedback from Sprint Backlog to Demo on the WMDE-QWERTY-Sprint-2020-04-01 board.
Wed, Apr 1, 10:53 AM · WMDE-QWERTY-Sprint-2020-04-01, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T245420: Record "must-have" information about potential data loss in TwoColConflict from Review to Demo on the WMDE-QWERTY-Sprint-2020-03-18 board.
Wed, Apr 1, 10:41 AM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), WMDE-QWERTY-Sprint-2020-04-01, WMDE-QWERTY-Sprint-2020-03-18, WMDE-QWERTY-Sprint-2020-03-04, WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T245420: Record "must-have" information about potential data loss in TwoColConflict from Sprint Backlog to Demo on the WMDE-QWERTY-Sprint-2020-04-01 board.
Wed, Apr 1, 10:37 AM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), WMDE-QWERTY-Sprint-2020-04-01, WMDE-QWERTY-Sprint-2020-03-18, WMDE-QWERTY-Sprint-2020-03-04, WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde archived WMDE-QWERTY-Sprint-2020-03-04.
Wed, Apr 1, 10:32 AM
thiemowmde added a project to T148701: Automatic references list after page-terminal ordered or bullet list generates unbalanced HTML: User-notice.

I don't say the change done in the patch https://gerrit.wikimedia.org/r/585003 is wrong. The test cases do indeed make a lot more sense with the patch applied. But: This will most probably change the output of thousands of pages. Have you been able to estimate how many pages will be affected? Is this communicated? Do you plan to mention this in, for example, TechNews? Do our user bases know how to fix templates and pages that look more broken now than before?

Wed, Apr 1, 6:24 AM · Patch-For-Review, Editing-team (Q3 2019-2020 Kanban Board), good first task, Cite

Tue, Mar 31

thiemowmde committed rESCC85d9be19ffed: Revert "Default to enable talk page use case (for CI)" (authored by thiemowmde).
Revert "Default to enable talk page use case (for CI)"
Tue, Mar 31, 9:11 AM
thiemowmde added a reverting change for rESCC30b11cf66fd2: Default to enable talk page use case (for CI): rESCC85d9be19ffed: Revert "Default to enable talk page use case (for CI)".
Tue, Mar 31, 9:11 AM
thiemowmde added a comment to T244452: Add global $wgUser to DeprecatedGlobalVariablesSniff.

Personally, I veto this idea. The variable still exists in a ton of code: https://codesearch.wmflabs.org/search/?q=%5C%24wgUser%5Cb. Let's please give the developers some time to notice the deprecation warnings, before we make a sniff yell at them.

Tue, Mar 31, 6:08 AM · Patch-For-Review, MediaWiki-General, User-DannyS712, MediaWiki-Codesniffer

Wed, Mar 25

thiemowmde moved T247771: Line height in drawers is tight (viewing references on mobile) from Sprint Backlog to Demo on the WMDE-QWERTY-Sprint-2020-03-18 board.
Wed, Mar 25, 7:39 AM · Readers-Web-Backlog (Tracking), MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Editing QA, WMDE-QWERTY-Sprint-2020-03-18, Editing-team (Tracking), MobileFrontend, MinervaNeue
thiemowmde added a project to T247771: Line height in drawers is tight (viewing references on mobile): WMDE-QWERTY-Sprint-2020-03-18.

Oh dear. I believe our mistake in the patch https://gerrit.wikimedia.org/r/570090 (done as part of T242899) was that we only tested 1-line references. Thanks a lot for fixing this mistake!

Wed, Mar 25, 7:39 AM · Readers-Web-Backlog (Tracking), MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Editing QA, WMDE-QWERTY-Sprint-2020-03-18, Editing-team (Tracking), MobileFrontend, MinervaNeue

Tue, Mar 24

thiemowmde moved T248243: Stop dropping large conflicts from EventLogging from Review to Demo on the WMDE-QWERTY-Sprint-2020-03-18 board.
Tue, Mar 24, 12:24 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2020-04-01, MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), WMDE-QWERTY-Sprint-2020-03-18, Two-Column-Edit-Conflict-Merge, TCB-Team

Mon, Mar 23

thiemowmde added a project to T246782: FileImporter cannot import files with missing sha1 field: WMDE-QWERTY-Team.

There is indeed one file revision without a sha1 in this file's history:
https://nl.wikipedia.org/wiki/Speciaal:ApiSandbox#action=query&prop=imageinfo&titles=Bestand:Wiki.png&iiprop=timestamp%7Csha1&iilimit=500

Mon, Mar 23, 9:23 AM · WMDE-QWERTY-Team, TCB-Team, Move-Files-To-Commons
thiemowmde updated subscribers of T244059: Consistent authorship for all WMDE codebases (i.e. don't use TCB).
Mon, Mar 23, 7:13 AM · Technical-Debt, WMDE-QWERTY-Team, TCB-Team, User-thiemowmde
thiemowmde created T248296: Investigation: Discuss fallback mechanisms for missing config pages.
Mon, Mar 23, 7:02 AM · Move-Files-To-Commons, TCB-Team
thiemowmde updated subscribers of T247753: FileImporter's CSRF error message is incomprehensible to the average user.
Mon, Mar 23, 6:53 AM · I18n, Move-Files-To-Commons, TCB-Team

Sun, Mar 22

thiemowmde created T248268: Investigation: Some wikis want {{Now Commons}} to be placed with subst:.
Sun, Mar 22, 6:49 PM · TCB-Team, Move-Files-To-Commons

Fri, Mar 20

thiemowmde committed rESPR4aff28d2bda5: Remove default constructor and update PHPCS (authored by thiemowmde).
Remove default constructor and update PHPCS
Fri, Mar 20, 4:25 PM
thiemowmde added a comment to T203916: MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation reports @@ as error.

For reference, the example from the commit message is here: https://gerrit.wikimedia.org/g/mediawiki/extensions/CodeReview/+/master/includes/backend/DiffHighlighter.php#219.

Fri, Mar 20, 3:13 PM · MediaWiki-Codesniffer
thiemowmde added a comment to T172836: Provide Codesniffer rules to enforce primitive types in lowercase in documentation.

I feel violations are relatively rare, and barely have any impact. In my opinion this does not justify creating a sniff that potentially breaks code that does have a String class.

Fri, Mar 20, 3:01 PM · MediaWiki-Codesniffer
thiemowmde added a comment to T214300: Square brackets not allowed in URLs on Wikidata.

Yes, I believe so. Short answer: It's not Wikibase, it's MediaWiki.

Fri, Mar 20, 2:38 PM · Internet-Archive, Wikidata
thiemowmde committed rEMEMc895ddfd88d6: Fix some very rare PHPCS violations (authored by thiemowmde).
Fix some very rare PHPCS violations
Fri, Mar 20, 3:16 AM

Thu, Mar 19

thiemowmde committed rEWCS34fa3b15f021: Fix a few PHPCS violations (authored by thiemowmde).
Fix a few PHPCS violations
Thu, Mar 19, 6:19 PM
thiemowmde committed rEHTW4ee5a1219e22: Fix a series of easy to fix PHPCS issues (authored by thiemowmde).
Fix a series of easy to fix PHPCS issues
Thu, Mar 19, 1:06 PM
thiemowmde moved T245505: Non-JS error handling when a conflict is submitted with no column selected from Sprint Backlog to Demo on the WMDE-QWERTY-Sprint-2020-03-18 board.

The browser test is done. Should we consider this done, or is there a specific cleanup you still want to do?

Thu, Mar 19, 10:37 AM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), WMDE-QWERTY-Sprint-2020-03-18, WMDE-QWERTY-Sprint-2020-03-04, Patch-For-Review, WMDE-QWERTY-Sprint-2020-02-19, WMDE-QWERTY-Sprint-2020-02-04, Design, WMDE-Design, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde placed T245505: Non-JS error handling when a conflict is submitted with no column selected up for grabs.
Thu, Mar 19, 7:46 AM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), WMDE-QWERTY-Sprint-2020-03-18, WMDE-QWERTY-Sprint-2020-03-04, Patch-For-Review, WMDE-QWERTY-Sprint-2020-02-19, WMDE-QWERTY-Sprint-2020-02-04, Design, WMDE-Design, TCB-Team, Two-Column-Edit-Conflict-Merge

Wed, Mar 18

thiemowmde added a comment to T92009: Support more fine-grained date fields than xsd:dateTime.

The question was: A lot of time values in the Wikidata database name a year only. Does it even make sense to export these as xsd:dateTime? Shouldn't we export these as xsd:gYear?

Wed, Mar 18, 1:55 PM · Discovery, Wikidata-Query-Service, Wikidata
thiemowmde added a comment to T247903: cite error ref red needs to fulfill color contrast ratio.

Note it was just recently that we changed the color of <code> elements in error messages: https://gerrit.wikimedia.org/r/559714. Before, a <code> element would appear black on gray, in the middle of a red error message, which made it look like it is not part of the error message. If this change was a mistake and you believe <code> should look black again, please tell us.

Wed, Mar 18, 6:35 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), covid-19, Accessibility, Cite

Tue, Mar 17

thiemowmde closed T245601: Placeholder ticket for Templates investigations: featured templates as Resolved.

Relevant data collection documents:

Tue, Mar 17, 12:58 PM · WMDE-QWERTY-Sprint-2020-03-04, WMDE-Templates-FocusArea, WMDE-QWERTY-Sprint-2020-02-19
thiemowmde closed T245119: Bad interaction between VisualEditor and TwoColConflict as Resolved.
Tue, Mar 17, 12:47 PM · User-Ryasmeen, WMDE-QWERTY-Sprint-2020-03-04, Editing QA, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), WMDE-QWERTY-Sprint-2020-02-19, Editing-team (Q3 2019-2020 Kanban Board), WMDE-QWERTY-Sprint-2020-02-04, TCB-Team, VisualEditor, Two-Column-Edit-Conflict-Merge
thiemowmde closed T245410: Neither column of a conflict should be selected by default, a subtask of T246646: Add missing browser tests for "nothing selected by default" behavior, as Resolved.
Tue, Mar 17, 12:43 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), WMDE-QWERTY-Sprint-2020-03-04, WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde closed T245410: Neither column of a conflict should be selected by default as Resolved.
Tue, Mar 17, 12:43 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), WMDE-QWERTY-Sprint-2020-03-04, Patch-For-Review, WMDE-QWERTY-Sprint-2020-02-19, WMDE-QWERTY-Sprint-2020-02-04, Design, WMDE-Design, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T209702: Edit icon in new two column edit conflict design appears active when it can't be edited from Demo to Done on the WMDE-QWERTY-Sprint-2020-03-04 board.
Tue, Mar 17, 12:43 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), WMDE-QWERTY-Sprint-2020-03-04, WMDE-Design, Design, WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde renamed T209702: Edit icon in new two column edit conflict design appears active when it can't be edited from New two column edit conflict design should not contain edit icon when it can't be edited to Edit icon in new two column edit conflict design appears active when it can't be edited.
Tue, Mar 17, 12:43 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), WMDE-QWERTY-Sprint-2020-03-04, WMDE-Design, Design, WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde closed T247292: Don't use beta feature mode on CI and beta clusters as Resolved.
Tue, Mar 17, 12:41 PM · Two-Column-Edit-Conflict-Merge, WMDE-QWERTY-Sprint-2020-03-04, TCB-Team
thiemowmde closed T245999: Implement opt-out user preference for TwoColConflict, a subtask of T244863: Deploy Two-Column Edit Conflict as the default workflow for a small set of wikis, as Resolved.
Tue, Mar 17, 12:40 PM · WMDE-QWERTY-Sprint-2020-03-18, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde closed T245999: Implement opt-out user preference for TwoColConflict, a subtask of T246104: Track opt-out user preference for new conflict UI, as Resolved.
Tue, Mar 17, 12:40 PM · WMDE-QWERTY-Sprint-2020-03-18, WMDE-QWERTY-Sprint-2020-03-04, TCB-Team, WMDE-QWERTY-Team, Two-Column-Edit-Conflict-Merge
thiemowmde closed T245999: Implement opt-out user preference for TwoColConflict as Resolved.
Tue, Mar 17, 12:40 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), WMDE-QWERTY-Sprint-2020-03-04, Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde closed T247506: Do not mention the beta feature if it's not used as such as Resolved.
Tue, Mar 17, 12:39 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), WMDE-QWERTY-Sprint-2020-03-04, Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde closed T247662: Fix misleading help text talking about yellow/blue knobs as Resolved.
Tue, Mar 17, 12:38 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), WMDE-Design, WMDE-QWERTY-Sprint-2020-03-04, Design, TCB-Team, Revision-Slider
thiemowmde added a comment to T170332: Avoid assignment in return statements.

How I would do it:

if ( !$this->cache ) {
    $this->cache = $this->longCodeThatDefinesCache();
}
Tue, Mar 17, 11:43 AM · MediaWiki-Codesniffer

Mon, Mar 16

thiemowmde added a comment to T170332: Avoid assignment in return statements.

I don't know, but what is bad about being enforced to split something like

return $this->cache = $this->queryDatabase();

into

$this->cache = $this->queryDatabase();
return $this->cache;

In my opinion this is way more readable. It's way to easy to miss the = in the return line.

Mon, Mar 16, 4:04 PM · MediaWiki-Codesniffer
thiemowmde added a comment to T245307: Ensures <img> elements have alternate text or a role of none or presentation..

I would love to be able to force people to do something. But this is not how people work, any it is especially not how a community of volunteers works. Sorry, but there is no way this can happen.

Mon, Mar 16, 3:48 PM · Accessibility, Editing-team (Q3 2019-2020 Kanban Board), Patch-For-Review, VisualEditor
thiemowmde added a comment to T245505: Non-JS error handling when a conflict is submitted with no column selected.

Finally, PM and I had a chance to talk. We decided to continue with the decision previously made (that is selecting the right side by default, as done by patch https://gerrit.wikimedia.org/r/578516), collect user input during the small default phase, and possibly change the decision before the feature becomes the default for all wikis. Main motivation for this way forward is that we want to collect user feedback for the "your side selected" solution right now, and possibly collect more user input for the "nothing selected" solution later.

Mon, Mar 16, 12:26 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), WMDE-QWERTY-Sprint-2020-03-18, WMDE-QWERTY-Sprint-2020-03-04, Patch-For-Review, WMDE-QWERTY-Sprint-2020-02-19, WMDE-QWERTY-Sprint-2020-02-04, Design, WMDE-Design, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T247662: Fix misleading help text talking about yellow/blue knobs from Review to Demo on the WMDE-QWERTY-Sprint-2020-03-04 board.
Mon, Mar 16, 9:42 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), WMDE-Design, WMDE-QWERTY-Sprint-2020-03-04, Design, TCB-Team, Revision-Slider

Sat, Mar 14

thiemowmde added a comment to T245289: Create sniff to help prevent logstash_formatter_key_conflict in mediawiki logs.

Yea, please go for Phan. A PHPCS sniff for this will most probably be tremendously complicated, and still miss many places. For example, how should PHPCS know when $this->logger actually is a LoggerInterface, and not something else? How should it check the $context array in $this->logger->info( '…', $context );?

Sat, Mar 14, 2:15 PM · phan
thiemowmde moved T247662: Fix misleading help text talking about yellow/blue knobs from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-03-04 board.
Sat, Mar 14, 2:03 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), WMDE-Design, WMDE-QWERTY-Sprint-2020-03-04, Design, TCB-Team, Revision-Slider
thiemowmde moved T247662: Fix misleading help text talking about yellow/blue knobs from Incoming to Doing on the Revision-Slider board.
Sat, Mar 14, 2:03 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), WMDE-Design, WMDE-QWERTY-Sprint-2020-03-04, Design, TCB-Team, Revision-Slider
thiemowmde created T247662: Fix misleading help text talking about yellow/blue knobs.
Sat, Mar 14, 2:02 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), WMDE-Design, WMDE-QWERTY-Sprint-2020-03-04, Design, TCB-Team, Revision-Slider
thiemowmde added a comment to T247562: Warning: Memcached::setMulti(): failed to set key global:segment:....

Which of the action APIs is causing this? Is it even a specific one, or all of them?

Sat, Mar 14, 10:36 AM · User-notice, MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Cache, User-brennen, Wikimedia-production-error

Thu, Mar 12

thiemowmde added a comment to T247458: PHP Notice: Undefined index: wgKartographerLiveData.

I do not know the involved CachingKartographerEmbeddingHandler class in Wikibase very well. But according to what I see in https://codesearch.wmflabs.org/search/?q=wgKartographerLiveData I suspect that:

  1. I believe this is not a serious issue. Just a notice. The missing variable is cast to an empty array. From there, I believe all following code is fine with an empty array.
  2. The root cause appears to be a mismatch between the code in the Kartographer extension where the variable is created, and the code in Wikibase that consumes it. Note that the variable is only created under specific circumstances, but Wikibase always expects it.
Thu, Mar 12, 5:06 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Patch-For-Review, Wikidata-Campsite, User-brennen, Wikidata, Wikimedia-production-error

Wed, Mar 11

thiemowmde added a comment to T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension.

When someone is able and willing to identify the original issue, we can undo code changes that are not needed any more then. As long as this is not the case let us please, please unblock people from working on these codebases.

Wed, Mar 11, 5:32 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Wikimedia-production-error (Shared Build Failure), MW-1.35-release, MediaWiki-Configuration, ci-test-error, Wikidata-Campsite, Wikidata, Shape Expressions

Tue, Mar 10

thiemowmde added a comment to T245505: Non-JS error handling when a conflict is submitted with no column selected.

We also decided that for now, the default of pre-selecting the "other" side should be switch to the "your" side […]

Tue, Mar 10, 12:18 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), WMDE-QWERTY-Sprint-2020-03-18, WMDE-QWERTY-Sprint-2020-03-04, Patch-For-Review, WMDE-QWERTY-Sprint-2020-02-19, WMDE-QWERTY-Sprint-2020-02-04, Design, WMDE-Design, TCB-Team, Two-Column-Edit-Conflict-Merge

Sun, Mar 8

thiemowmde committed rEASR25a1684f6163: Fix duplicate expandable pane id and aria control (authored by Bkudiess-msft).
Fix duplicate expandable pane id and aria control
Sun, Mar 8, 9:31 AM

Fri, Mar 6

thiemowmde added a comment to T245190: Implement guidelines around logos creation.

For whitespace, we should minimize it as much as possible and add it via CSS where needed, that provides us best flexibility and lowest image data.

Fri, Mar 6, 6:35 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q4), Desktop Improvements, Logos

Thu, Mar 5

thiemowmde added a comment to T245601: Placeholder ticket for Templates investigations: featured templates.

I wrote a longer mail about template categorization. Summary: I suggest to use the existing category tree for templates that's already maintained by the communities:

These trees might miss a lot of templates, but I believe it's safe to assume that:

  • The good templates we are interested in are already categorized.
  • The community will add more categories the moment they become more visible in a "featured templates" interface.
Thu, Mar 5, 7:50 PM · WMDE-QWERTY-Sprint-2020-03-04, WMDE-Templates-FocusArea, WMDE-QWERTY-Sprint-2020-02-19
thiemowmde added a comment to T246430: [SPIKE?] Create new logos for all projects.

Without knowing much about the project, I would like to suggest:

  • Drop the globe from all .svg images and make it a separate file.
  • Don't try to crop any of the images. Leave all of them as is, including the globe, and just position the two on top of each other using CSS.
Thu, Mar 5, 7:27 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q4), Desktop Improvements, Spike, Logos
thiemowmde added a comment to T245999: Implement opt-out user preference for TwoColConflict.

Third-parties can just not install the extension.

Thu, Mar 5, 8:55 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), WMDE-QWERTY-Sprint-2020-03-04, Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde added a comment to T245999: Implement opt-out user preference for TwoColConflict.

@JStrodt_WMDE and @Hanna_Petruschat_WMDE, personally I would prefer to turn the option around, while still using a positive wording. I find it problematic to give users an option they can use to express their dissatisfaction. ("Why is this enabled by default? I never asked for this.")

Thu, Mar 5, 7:36 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), WMDE-QWERTY-Sprint-2020-03-04, Two-Column-Edit-Conflict-Merge, TCB-Team

Mar 4 2020

thiemowmde added a comment to T209702: Edit icon in new two column edit conflict design appears active when it can't be edited.

Done: https://gerrit.wikimedia.org/r/575988

Mar 4 2020, 10:43 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), WMDE-QWERTY-Sprint-2020-03-04, WMDE-Design, Design, WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde committed rEFLI18a70abf8293: Pass a user when creating a new ParserOptions (authored by DannyS712).
Pass a user when creating a new ParserOptions
Mar 4 2020, 10:32 AM

Mar 3 2020

thiemowmde created T246783: Let users recover from data loss after closing tabs with unsaved changes.
Mar 3 2020, 3:40 PM · MediaWiki-Page-editing, Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde added a comment to T245601: Placeholder ticket for Templates investigations: featured templates.

Answers, in order:

Mar 3 2020, 3:25 PM · WMDE-QWERTY-Sprint-2020-03-04, WMDE-Templates-FocusArea, WMDE-QWERTY-Sprint-2020-02-19
thiemowmde added a comment to T246726: Prevent data loss in DiscussionTools caused by MediaWiki not detecting edit conflicts with yourself.

The discussion mentions basetimestamp and starttimestamp. While working on Two-Column-Edit-Conflict-Merge I just learned that relying on timestamps is an outdated mechanism. It will especially fail if two edits happen the same second. Instead, I found parentRevId and editRevId, which correspond to the two parameters mentioned above, but are revision IDs instead.

Mar 3 2020, 3:14 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), DiscussionTools
thiemowmde added a comment to T245601: Placeholder ticket for Templates investigations: featured templates.

Template documentation we (can) have according to the TemplateData specification:

  • Plain text description of a template
  • Machine-readable information which template parameters belong together
  • For each parameter:
    • Label
    • Description
    • A single example for the parameter value
    • Documentation of the default behavior a parameter will have if it's not filled
    • If a UI should suggest the parameter to be filled
Mar 3 2020, 2:54 PM · WMDE-QWERTY-Sprint-2020-03-04, WMDE-Templates-FocusArea, WMDE-QWERTY-Sprint-2020-02-19
thiemowmde created T246781: Non-JS conflict resolution might forget about edits made in the UI.
Mar 3 2020, 2:41 PM · TCB-Team, WMDE-QWERTY-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T246646: Add missing browser tests for "nothing selected by default" behavior from Backlog to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.
Mar 3 2020, 1:06 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), WMDE-QWERTY-Sprint-2020-03-04, WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde added a comment to T245119: Bad interaction between VisualEditor and TwoColConflict.

Note: VisualEditor on the Beta cluster is broken right now, so we failed to demo this today. I suggest a demo on Adams computer.

Mar 3 2020, 1:01 PM · User-Ryasmeen, WMDE-QWERTY-Sprint-2020-03-04, Editing QA, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), WMDE-QWERTY-Sprint-2020-02-19, Editing-team (Q3 2019-2020 Kanban Board), WMDE-QWERTY-Sprint-2020-02-04, TCB-Team, VisualEditor, Two-Column-Edit-Conflict-Merge
thiemowmde closed T245507: Radio elements in TwoColConflict don't show a keyboard focus indicator as Resolved.
Mar 3 2020, 1:00 PM · WMDE-QWERTY-Sprint-2020-02-19, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), WMDE-QWERTY-Sprint-2020-02-04, Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde closed T245112: Make edit conflict view tab indexes linear as Resolved.
Mar 3 2020, 1:00 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), WMDE-QWERTY-Sprint-2020-02-19, MediaWiki-General, WMDE-QWERTY-Sprint-2020-02-04, TCB-Team, Two-Column-Edit-Conflict-Merge, WMDE-Design, Design, Accessibility
thiemowmde closed T245730: Edits while solving a conflict trigger broken conflict as Resolved.
Mar 3 2020, 12:54 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), WMDE-QWERTY-Sprint-2020-02-19, Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde closed T245506: Signature not expanded in the TwoColConflict preview interface as Resolved.
Mar 3 2020, 12:51 PM · WMDE-QWERTY-Sprint-2020-02-19, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Two-Column-Edit-Conflict-Merge, TCB-Team, WMDE-QWERTY-Sprint-2020-02-04
thiemowmde closed T245736: Show dynamic label text depending on conflict column selection, a subtask of T245410: Neither column of a conflict should be selected by default, as Resolved.
Mar 3 2020, 12:49 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), WMDE-QWERTY-Sprint-2020-03-04, Patch-For-Review, WMDE-QWERTY-Sprint-2020-02-19, WMDE-QWERTY-Sprint-2020-02-04, Design, WMDE-Design, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde closed T245736: Show dynamic label text depending on conflict column selection as Resolved.
Mar 3 2020, 12:49 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), WMDE-QWERTY-Sprint-2020-02-19, Design, WMDE-Design, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T207149: TwoColConflict gives no warning if closing the tab or using browser back button from Demo to Done on the WMDE-QWERTY-Sprint-2020-02-19 board.
Mar 3 2020, 12:45 PM · WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde closed T207149: TwoColConflict gives no warning if closing the tab or using browser back button as Invalid.
Mar 3 2020, 12:42 PM · WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge

Mar 2 2020

thiemowmde added a comment to T246674: Treat assertEmpty() as problematic in PHPUnitAssertEquals.

In the past, I liked PHP's empty() exactly because it is so relaxed. Whenever I saw something like if ( !empty( $var ) ), I was sure no unwanted empty or empty-ish value can make it to my code.

Mar 2 2020, 3:56 PM · MediaWiki-Codesniffer
thiemowmde updated subscribers of T235892: [BUG?] FileImporter does not mark source files with NowCommons even though I selected it.

Another user reporting the same issue: https://www.mediawiki.org/wiki/Topic:Vhm2enq0u01a86i0

Mar 2 2020, 2:27 PM · WMDE-QWERTY-Team, Regression, TCB-Team, Move-Files-To-Commons
Daimona awarded T246662: Add potentially problematic assertEquals( 1 ) to the PHPUnitAssertEquals sniff a Like token.
Mar 2 2020, 1:57 PM · Patch-For-Review, MediaWiki-Codesniffer
thiemowmde created T246662: Add potentially problematic assertEquals( 1 ) to the PHPUnitAssertEquals sniff.
Mar 2 2020, 1:54 PM · Patch-For-Review, MediaWiki-Codesniffer
thiemowmde added a comment to T207149: TwoColConflict gives no warning if closing the tab or using browser back button.

Sorry, I don't get what you are proposing. First, we can clearly argue that the "issue" is not an issue, but an intentional browser feature. Second, the same happens in the old conflict interface.

Mar 2 2020, 11:20 AM · WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde added a parent task for T245410: Neither column of a conflict should be selected by default: T246646: Add missing browser tests for "nothing selected by default" behavior.
Mar 2 2020, 10:57 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), WMDE-QWERTY-Sprint-2020-03-04, Patch-For-Review, WMDE-QWERTY-Sprint-2020-02-19, WMDE-QWERTY-Sprint-2020-02-04, Design, WMDE-Design, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde added a parent task for T245505: Non-JS error handling when a conflict is submitted with no column selected: T246646: Add missing browser tests for "nothing selected by default" behavior.
Mar 2 2020, 10:57 AM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), WMDE-QWERTY-Sprint-2020-03-18, WMDE-QWERTY-Sprint-2020-03-04, Patch-For-Review, WMDE-QWERTY-Sprint-2020-02-19, WMDE-QWERTY-Sprint-2020-02-04, Design, WMDE-Design, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde added subtasks for T246646: Add missing browser tests for "nothing selected by default" behavior: T245410: Neither column of a conflict should be selected by default, T245505: Non-JS error handling when a conflict is submitted with no column selected.
Mar 2 2020, 10:57 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), WMDE-QWERTY-Sprint-2020-03-04, WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde created T246646: Add missing browser tests for "nothing selected by default" behavior.
Mar 2 2020, 10:54 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), WMDE-QWERTY-Sprint-2020-03-04, WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde created T246636: Bogus MediaWiki.WhiteSpace.SpaceyParenthesis auto-fix when there is whitespace at the end of the line.
Mar 2 2020, 10:31 AM · MediaWiki-Codesniffer
thiemowmde created T246630: Auto-fix misses to add a required newline to single-line if().
Mar 2 2020, 10:18 AM · MediaWiki-Codesniffer
thiemowmde reassigned T209702: Edit icon in new two column edit conflict design appears active when it can't be edited from thiemowmde to Hanna_Petruschat_WMDE.

Current colors for comparison:

Mar 2 2020, 10:05 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), WMDE-QWERTY-Sprint-2020-03-04, WMDE-Design, Design, WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde claimed T209702: Edit icon in new two column edit conflict design appears active when it can't be edited.
Mar 2 2020, 9:23 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), WMDE-QWERTY-Sprint-2020-03-04, WMDE-Design, Design, WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde placed T209702: Edit icon in new two column edit conflict design appears active when it can't be edited up for grabs.
Mar 2 2020, 9:22 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), WMDE-QWERTY-Sprint-2020-03-04, WMDE-Design, Design, WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde claimed T209702: Edit icon in new two column edit conflict design appears active when it can't be edited.
Mar 2 2020, 9:22 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), WMDE-QWERTY-Sprint-2020-03-04, WMDE-Design, Design, WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T209702: Edit icon in new two column edit conflict design appears active when it can't be edited from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-02-19 board.
Mar 2 2020, 9:22 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), WMDE-QWERTY-Sprint-2020-03-04, WMDE-Design, Design, WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde placed T245505: Non-JS error handling when a conflict is submitted with no column selected up for grabs.
Mar 2 2020, 9:22 AM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), WMDE-QWERTY-Sprint-2020-03-18, WMDE-QWERTY-Sprint-2020-03-04, Patch-For-Review, WMDE-QWERTY-Sprint-2020-02-19, WMDE-QWERTY-Sprint-2020-02-04, Design, WMDE-Design, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde placed T245410: Neither column of a conflict should be selected by default up for grabs.
Mar 2 2020, 9:22 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), WMDE-QWERTY-Sprint-2020-03-04, Patch-For-Review, WMDE-QWERTY-Sprint-2020-02-19, WMDE-QWERTY-Sprint-2020-02-04, Design, WMDE-Design, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T207149: TwoColConflict gives no warning if closing the tab or using browser back button from Review to Demo on the WMDE-QWERTY-Sprint-2020-02-19 board.

TL;DR: The description in the commit message describes a browser feature we can not change.

Mar 2 2020, 9:20 AM · WMDE-QWERTY-Sprint-2020-02-19, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T245505: Non-JS error handling when a conflict is submitted with no column selected from Doing to Review on the WMDE-QWERTY-Sprint-2020-02-19 board.
Mar 2 2020, 9:09 AM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), WMDE-QWERTY-Sprint-2020-03-18, WMDE-QWERTY-Sprint-2020-03-04, Patch-For-Review, WMDE-QWERTY-Sprint-2020-02-19, WMDE-QWERTY-Sprint-2020-02-04, Design, WMDE-Design, TCB-Team, Two-Column-Edit-Conflict-Merge

Feb 28 2020

thiemowmde closed T70324: Cite: Add namespace detection for automatically generated reference list as Declined.
Feb 28 2020, 8:22 PM · Cite