thiemowmde (Thiemo Kreuz (WMDE))
Software Developer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 11:45 AM (227 w, 6 d)
Availability
Available
IRC Nick
Thiemo_WMDE
LDAP User
Thiemo Kreuz (WMDE)
MediaWiki User
Thiemo Kreuz (WMDE) [ Global Accounts ]

Recent Activity

Yesterday

thiemowmde added a comment to T216086: ErrorException from includes/HeaderCallback.php: PHP Notice: Undefined offset: 1.

I looked at the code in the HeaderCallback class. Questions:

  1. Does the HTTP spec actually forbid headers without a colon? If this is the case, we should make violations visible.
  2. Is it the job of the HeaderCallback class to validate all headers? If it is, it should properly log bad headers so we can see them. If not, my proposal in https://gerrit.wikimedia.org/r/491539 makes the class stop failing on headers it actually does not care about.
Tue, Feb 19, 5:58 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Core Platform Team Kanban (Waiting for Review), Patch-For-Review, Wikimedia-production-error
thiemowmde moved T214908: Investigate references endpoint from Doing to Demo on the WMDE-QWERTY-Sprint-2019-02-06 board.

We know on what basis it is decided which type a reference has

Tue, Feb 19, 3:35 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Reference Previews
thiemowmde closed T215899: Make sure referencepreviews show up in all namespaces as Resolved by committing rEPOP943821088976: Teach the title parser to always accept self-links.
Tue, Feb 19, 11:56 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Reference Previews

Thu, Feb 14

thiemowmde added a comment to T178136: Encourage type hints for function parameters and return after moving MediaWiki to PHP 7.

I'm not sure I understand the idea presented in this tickets description. Is the suggestion to somehow force people to type hint all code? How would we set this up? Who would be in charge to update the code? Are we in a position to assign budget on a task as massive as updating multiple tens of thousand function headers in a thousand codebases? How do we communicate this new requirement to all the dev teams? How can we check if code conforms to this new standard? I mean, it's not like PHP 7 suddenly forbids to have function parameters that can be, for example int|string, string[]|string, or even mixed, just to name the most prominent examples that don't involve null.

Thu, Feb 14, 8:06 PM · MediaWiki-Codesniffer, Technical-Debt, MediaWiki-General-or-Unknown

Wed, Feb 13

thiemowmde moved T214908: Investigate references endpoint from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-02-06 board.
Wed, Feb 13, 4:08 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Reference Previews
thiemowmde placed T176595: Missing line break in email notification for minor edits up for grabs.
Wed, Feb 13, 12:22 PM · good first bug, Patch-For-Review, MediaWiki-Email
thiemowmde closed T176595: Missing line break in email notification for minor edits as Resolved.

I believe this was fixed via https://gerrit.wikimedia.org/r/404161 already, uploaded in January 2018, merged in October 2018.

Wed, Feb 13, 12:22 PM · good first bug, Patch-For-Review, MediaWiki-Email
thiemowmde updated subscribers of T215063: Rename link in footer to "Jump to footnote".

Pinging @Raymond because we are renaming one message key in https://gerrit.wikimedia.org/r/489743. Maybe he is able to help?

Wed, Feb 13, 10:06 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Reference Previews

Tue, Feb 12

thiemowmde moved T214169: Limit the pop up size from Review to Demo on the WMDE-QWERTY-Sprint-2019-02-06 board.

Here are screenshots of how the design looks like after https://gerrit.wikimedia.org/r/488938:

Tue, Feb 12, 5:42 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Reference Previews
thiemowmde updated subscribers of T214463: Show external link icons in popups.

For future reference: Originally this ticket mentioned "lock" icons, as described at https://en.wikipedia.org/wiki/Help:Citation_Style_1#Registration_or_subscription_required. This confused me for a long time. Very late I realized there are (to) many different ways such icons can be implemented:

  1. Via [[File:Lock-….svg|9px|…]] in the wikitext. Such images are part of the content of a footnote. There is no way they can disappear, except some code intentionally removes them. Example: https://en.wikipedia.org/wiki/Template:Free_access
  2. Via global styles in the MediaWiki namespace. These are typically generic enough to also be active in popups. Example: https://en.wikipedia.org/wiki/MediaWiki:Common.css
  3. Via TemplateStyles. These are automatically limited to elements with the mw-parser-output class. Example: https://en.wikipedia.org/wiki/Module:Citation/CS1/styles.css
Tue, Feb 12, 4:06 PM · WMDE-QWERTY-Sprint-2019-01-23, MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Reference Previews
thiemowmde added a comment to T214908: Investigate references endpoint.

Some notes from today:

Tue, Feb 12, 2:07 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Reference Previews
thiemowmde committed rEPFM3182194a2176: Replace deprecated SpecialPage::getTitle with getPageTitle (authored by thiemowmde).
Replace deprecated SpecialPage::getTitle with getPageTitle
Tue, Feb 12, 11:48 AM

Mon, Feb 11

thiemowmde moved T215063: Rename link in footer to "Jump to footnote" from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-02-06 board.
Mon, Feb 11, 6:30 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Reference Previews
thiemowmde triaged T214861: Reference popups not working with unexpected URL parameters as Normal priority.

I explored a bunch of ideas to get a grip on this issue. Finding some solution isn't that hard, but I want a solution that is sustainable and guaranteed to not mess with regular page previews. It should especially not make T198652 worse.

  • As far as I can tell the title parser was intentionally build as restricted as it is. It should only accept links it absolutely must accept.
  • One idea I had was to create a whitelist of URL parameters the title parser is allowed to ignore. We would need a list of use-cases where we want reference previews to be shown, and a (hopefully) complete list of use-cases where we do not want page previews to be shown. I tried, but this gets somewhat bonkers and unmaintainable pretty quickly.
  • I believe the gold solution is to detect self-links, as discussed in T198652.
Mon, Feb 11, 6:24 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Reference Previews, TCB-Team
thiemowmde committed rEASRcecfec221ec7: Add missing test cases for GetPreferences hook handler (authored by thiemowmde).
Add missing test cases for GetPreferences hook handler
Mon, Feb 11, 3:44 PM
thiemowmde placed T215195: [Bug] Hovering over references in reference previews dismisses dialog up for grabs.
Mon, Feb 11, 1:17 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Readers-Web-Backlog (Tracking), Reference Previews

Sat, Feb 9

Ivanhercaz awarded T66515: [Story] Direct link to download the raw JSON data of each Entity a Goat token.
Sat, Feb 9, 2:11 AM · good first bug, Story, Wikidata, Need-volunteer, MediaWiki-extensions-WikibaseRepository

Fri, Feb 8

thiemowmde added a comment to T215063: Rename link in footer to "Jump to footnote".

I 100% agree. :-) Just to have this documented: the previous label was following the mocks as presented in T213415 and especially T213905:

Fri, Feb 8, 5:47 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Reference Previews

Wed, Feb 6

thiemowmde added projects to T215194: [Bug] Pointer is incorrectly aligned for some references: OOjs, Page-Previews.

Please note that this issue is most probably unrelated to any of the new code we introduced for Reference Previews, as it can happen on regular page previews as well:

Wed, Feb 6, 6:01 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Page-Previews, WMDE-QWERTY-Sprint-2019-02-06, Readers-Web-Backlog (Tracking), Reference Previews
thiemowmde added a comment to T214693: Investigate why Page and Reference Previews interfere when footnote comes right behind link.

@WMDE-Fisch, I can confirm this observation.

Wed, Feb 6, 7:56 AM · WMDE-QWERTY-Sprint-2019-01-23, TCB-Team, Reference Previews

Tue, Feb 5

thiemowmde created T215317: Accessibility and/or highlighting code destroys up-arrow back links.
Tue, Feb 5, 6:06 PM · Regression, TCB-Team, Cite

Mon, Feb 4

thiemowmde added a comment to T213905: Add link to reference in reference section to reference previews.

As far as I understand what you refer to as being "fixed" now was never broken.

Mon, Feb 4, 2:52 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews
thiemowmde added a comment to T214693: Investigate why Page and Reference Previews interfere when footnote comes right behind link.

The best idea I have so far is the ABANDON_END_DELAY, that defaults to 300 ms, and is used in a single place in the code: https://phabricator.wikimedia.org/diffusion/EPOP/browse/master/src/actions.js$266. I tried to set this to 1, and the issue seems to disappear.

Mon, Feb 4, 1:59 PM · WMDE-QWERTY-Sprint-2019-01-23, TCB-Team, Reference Previews
thiemowmde added a comment to T213905: Add link to reference in reference section to reference previews.

Hm. Generally, the monkey testing page is not the best to do such tests. It contains extreme edge-cases of unknown relevance for real-world wiki pages. We never specified an expected behavior for most of these edge-cases. If a report refers to an example on the monkey testing page, it is important to let us know which one was used.

Mon, Feb 4, 12:39 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews
thiemowmde updated the task description for T214970: Popups: Code and documentation refactorings and clean-ups.
Mon, Feb 4, 9:52 AM · Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Technical-Debt, TCB-Team, Page-Previews, Reference Previews
D3r1ck01 awarded T215144: Enforce @covers… tags to have full qualified class names starting with backslash a Like token.
Mon, Feb 4, 9:23 AM · MediaWiki-Codesniffer
thiemowmde created T215144: Enforce @covers… tags to have full qualified class names starting with backslash.
Mon, Feb 4, 9:00 AM · MediaWiki-Codesniffer

Fri, Feb 1

thiemowmde updated the task description for T214971: Popups: Raise test coverage for the new reference preview type.
Fri, Feb 1, 11:52 AM · Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Test-Coverage, WMDE-QWERTY-Sprint-2019-01-23, TCB-Team, Page-Previews, Reference Previews
thiemowmde updated the task description for T214970: Popups: Code and documentation refactorings and clean-ups.
Fri, Feb 1, 11:52 AM · Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Technical-Debt, TCB-Team, Page-Previews, Reference Previews
thiemowmde updated the task description for T214970: Popups: Code and documentation refactorings and clean-ups.
Fri, Feb 1, 11:52 AM · Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Technical-Debt, TCB-Team, Page-Previews, Reference Previews
thiemowmde moved T215058: Blueprint ticket for wiki test server creation from Backlog to reappearing ticket types on the WMDE-Blueprint-tickets board.
Fri, Feb 1, 11:24 AM · WMDE-Blueprint-tickets

Thu, Jan 31

thiemowmde committed rEFLI03c8e2ae9b2b: [WIP] Mark code that needs to be worked on with FIXMEs (authored by thiemowmde).
[WIP] Mark code that needs to be worked on with FIXMEs
Thu, Jan 31, 2:12 PM
thiemowmde committed rEFLI976821b6bfec: Add comment explaining the "www." in CommonsHelperConfigRetriever (authored by thiemowmde).
Add comment explaining the "www." in CommonsHelperConfigRetriever
Thu, Jan 31, 11:53 AM

Wed, Jan 30

thiemowmde moved T213905: Add link to reference in reference section to reference previews from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-01-23 board.
Wed, Jan 30, 7:20 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews
thiemowmde added a comment to T213905: Add link to reference in reference section to reference previews.

I was under the impression the font size of this link is derived from the existing styling of page previews. For example:

Wed, Jan 30, 7:20 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews
thiemowmde updated the task description for T214970: Popups: Code and documentation refactorings and clean-ups.
Wed, Jan 30, 6:59 PM · Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Technical-Debt, TCB-Team, Page-Previews, Reference Previews
thiemowmde moved T214971: Popups: Raise test coverage for the new reference preview type from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-01-23 board.
Wed, Jan 30, 4:02 PM · Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Test-Coverage, WMDE-QWERTY-Sprint-2019-01-23, TCB-Team, Page-Previews, Reference Previews
thiemowmde moved T214971: Popups: Raise test coverage for the new reference preview type from Backlog to Doing on the Reference Previews board.
Wed, Jan 30, 4:02 PM · Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Test-Coverage, WMDE-QWERTY-Sprint-2019-01-23, TCB-Team, Page-Previews, Reference Previews
thiemowmde triaged T214971: Popups: Raise test coverage for the new reference preview type as Normal priority.
Wed, Jan 30, 4:00 PM · Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Test-Coverage, WMDE-QWERTY-Sprint-2019-01-23, TCB-Team, Page-Previews, Reference Previews
thiemowmde moved T214970: Popups: Code and documentation refactorings and clean-ups from Backlog to Doing on the Reference Previews board.
Wed, Jan 30, 3:58 PM · Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Technical-Debt, TCB-Team, Page-Previews, Reference Previews
thiemowmde moved T214970: Popups: Code and documentation refactorings and clean-ups from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-01-23 board.
Wed, Jan 30, 3:58 PM · Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Technical-Debt, TCB-Team, Page-Previews, Reference Previews
thiemowmde triaged T214970: Popups: Code and documentation refactorings and clean-ups as Normal priority.
Wed, Jan 30, 3:58 PM · Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Technical-Debt, TCB-Team, Page-Previews, Reference Previews
thiemowmde created T214971: Popups: Raise test coverage for the new reference preview type.
Wed, Jan 30, 3:52 PM · Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Test-Coverage, WMDE-QWERTY-Sprint-2019-01-23, TCB-Team, Page-Previews, Reference Previews
thiemowmde created T214970: Popups: Code and documentation refactorings and clean-ups.
Wed, Jan 30, 3:48 PM · Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Technical-Debt, TCB-Team, Page-Previews, Reference Previews
thiemowmde committed rEFLI1d65a3e05aa9: Don't hard-code assumed setup of CommonsHelper config server (authored by thiemowmde).
Don't hard-code assumed setup of CommonsHelper config server
Wed, Jan 30, 3:36 PM
thiemowmde committed rEFLIb43b13160236: Don't hard-code assumed setup of CommonsHelper config server (authored by thiemowmde).
Don't hard-code assumed setup of CommonsHelper config server
Wed, Jan 30, 11:44 AM
thiemowmde removed a project from T214365: Allow merging of multiple source parameters into one Commons parameter: Patch-For-Review.

For your information: We realized that that a transfer rule containing subst:Изображение would trigger a bug in FileImporter. The template name after the colon would get lost and the resulting wikitext would contain something like {{subst|…}}. The bugfix https://gerrit.wikimedia.org/r/485761 should go live on February 5th.

Wed, Jan 30, 9:53 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), TCB-Team, Move-Files-To-Commons

Tue, Jan 29

thiemowmde removed a project from T214710: Sometimes, page popups appear instead of reference previews: Patch-For-Review.
Tue, Jan 29, 1:57 PM · WMDE-QWERTY-Sprint-2019-02-06, MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Reference Previews, TCB-Team
thiemowmde added a comment to T213907: Add footnote type to the header of reference previews.

Thanks a lot, that sounds good.

Tue, Jan 29, 7:44 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews

Mon, Jan 28

thiemowmde updated subscribers of T214761: Unit test Wikibase\Test\ClientDefaultsTest::testDefaults is flaky on MW Jenkins jobs.

Is there a chance this gets fixed fast? Otherwise we will temporarily disable the test. This should buy you enough time. The only thing you need to take care of then is to not forget to enable it again.

Mon, Jan 28, 1:35 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Wikidata, MediaWiki-extensions-WikibaseClient, Wikimedia-production-error (Shared Build Failure)
thiemowmde committed rEWLE004d396079bf: Mention "spelling variants" in Form::getRepresentations() documentation (authored by Greta Doçi <greta.doci@wikimedia.de>).
Mention "spelling variants" in Form::getRepresentations() documentation
Mon, Jan 28, 1:32 PM
thiemowmde updated subscribers of T214776: Reference popups add _blank target without rel=noopener.

Oh. I suggest to lift the limitation from this and the other ticket T214754, as both are not exploitable on any production server.

Mon, Jan 28, 1:00 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews, Page-Previews, Security
thiemowmde added a comment to T214707: Reference popups somtimes not showing.

This might be related to T214710#4914267, or might become much less of a problem after T214710 is solved. Let's make sure the fix is merged before we test this again.

Mon, Jan 28, 12:41 PM · Reference Previews, TCB-Team
thiemowmde moved T214710: Sometimes, page popups appear instead of reference previews from Backlog to Ready for pickup on the Reference Previews board.

This happens when the name of a reference contains a : character. jQuery requires that almost every special character must be escaped to be able to use it as a plain text character in an ID or class name. See http://api.jquery.com/category/selectors/. We did not anticipated this. I guess we unintentionally limited our tests so far to the characters set used for identifiers in programming languages. ;-)

Mon, Jan 28, 12:38 PM · WMDE-QWERTY-Sprint-2019-02-06, MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Reference Previews, TCB-Team
thiemowmde added a project to T214776: Reference popups add _blank target without rel=noopener: Patch-For-Review.

What's wrong with this bot?

Mon, Jan 28, 11:10 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews, Page-Previews, Security
thiemowmde moved T214776: Reference popups add _blank target without rel=noopener from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-01-23 board.
Mon, Jan 28, 11:08 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews, Page-Previews, Security
thiemowmde claimed T214776: Reference popups add _blank target without rel=noopener.
Mon, Jan 28, 10:55 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews, Page-Previews, Security

Fri, Jan 25

thiemowmde added a comment to T213907: Add footnote type to the header of reference previews.

Yes, disambiguation pages are handled by the regular page preview code. They are just presented a little different (with the icon and a fixed message), because it would not be terribly helpful to show a text extract from a disambiguation page.

Fri, Jan 25, 4:33 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews

Thu, Jan 24

thiemowmde moved T213907: Add footnote type to the header of reference previews from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-01-23 board.
Thu, Jan 24, 5:55 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews
thiemowmde claimed T213907: Add footnote type to the header of reference previews.
Thu, Jan 24, 5:55 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews
thiemowmde added a comment to T213907: Add footnote type to the header of reference previews.

Question to PM and possibly UX: I noticed that all existing icons are gray, not black. Well, "all existing" is more like a single icon for disambiguation pages:

Thu, Jan 24, 4:32 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews
thiemowmde added a comment to T213908: Links in footnote preview open in a new tab.

Is this a change in behavior from the way references work today? For me personally, I usually control or middle-click when a new tab is wanted. […]

Thu, Jan 24, 4:02 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews
thiemowmde moved T213415: Show the footnote contents when hovering over footnote indicators from Doing to Review on the WMDE-QWERTY-Sprint-2019-01-23 board.
Thu, Jan 24, 2:59 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Tracking), WMDE-QWERTY-Sprint-2019-01-23, Page-Previews, Patch-For-Review, Reference Previews, WMDE-QWERTY-Sprint-2019-01-10, TCB-Team
thiemowmde moved T213905: Add link to reference in reference section to reference previews from Sprint Backlog to Demo on the WMDE-QWERTY-Sprint-2019-01-23 board.
Thu, Jan 24, 2:58 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews
thiemowmde moved T213908: Links in footnote preview open in a new tab from Doing to Review on the WMDE-QWERTY-Sprint-2019-01-23 board.
Thu, Jan 24, 1:51 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews
thiemowmde claimed T213908: Links in footnote preview open in a new tab.
Thu, Jan 24, 1:47 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews
thiemowmde moved T213908: Links in footnote preview open in a new tab from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-01-23 board.
Thu, Jan 24, 1:47 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews
thiemowmde archived WMDE-QWERTY-X-Mas-Sprint-2018-12-18.
Thu, Jan 24, 1:36 PM
thiemowmde committed rESCC6c453b063b55: Several minor fixups to recently introduced preview feature (authored by thiemowmde).
Several minor fixups to recently introduced preview feature
Thu, Jan 24, 11:17 AM
thiemowmde committed rESCC3a815b85127a: Rename addCSS()/addJS() methods to follow lowerCamelCaps convention (authored by thiemowmde).
Rename addCSS()/addJS() methods to follow lowerCamelCaps convention
Thu, Jan 24, 10:57 AM
thiemowmde added a comment to T214558: Puppet failure on deployment-prometheus01.deployment-prep.eqiad.wmflabs.

It looks like I also get these emails. I don't understand why. They are of zero use for me. How can I turn them off?

Thu, Jan 24, 10:46 AM · monitoring, Puppet, Beta-Cluster-Infrastructure
thiemowmde committed rESCCa2becbccec40: Mimic "show preview" functionality (authored by Andrew-WMDE).
Mimic "show preview" functionality
Thu, Jan 24, 9:36 AM

Wed, Jan 23

thiemowmde created T214493: Decide how to track usage data for reference previews.
Wed, Jan 23, 5:15 PM · Readers-Web-Backlog (Tracking), TCB-Team, Page-Previews, Reference Previews
thiemowmde committed rEFLI3536f0f1c06b: Allow to use subst:… in template transfer rules (authored by thiemowmde).
Allow to use subst:… in template transfer rules
Wed, Jan 23, 2:42 PM

Tue, Jan 22

thiemowmde committed rEFLI531e027b0f52: Simplify error message about incomplete config pages (authored by thiemowmde).
Simplify error message about incomplete config pages
Tue, Jan 22, 2:19 PM
thiemowmde committed rEFLIf2ec9bc8e677: Don't hard-code assumed setup of CommonsHelper config server (authored by thiemowmde).
Don't hard-code assumed setup of CommonsHelper config server
Tue, Jan 22, 9:49 AM
thiemowmde committed rEFLI856b6aaef79e: Show some sensible default when no help page is configured (authored by thiemowmde).
Show some sensible default when no help page is configured
Tue, Jan 22, 9:25 AM
thiemowmde committed rEFLI29ee6946309d: Allow to use subst:… in template transfer rules (authored by thiemowmde).
Allow to use subst:… in template transfer rules
Tue, Jan 22, 9:22 AM
thiemowmde committed rEFLI30d765d0d2e6: Fix CommonsHelper parser error on incomplete parameters (authored by thiemowmde).
Fix CommonsHelper parser error on incomplete parameters
Tue, Jan 22, 9:18 AM

Mon, Jan 21

thiemowmde moved T213643: Fix CSS for username bubble tooltip from Review to Demo on the WMDE-QWERTY-Sprint-2019-01-10 board.
Mon, Jan 21, 10:55 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), CSS, WMDE-QWERTY-Sprint-2019-01-10, Patch-For-Review, Revision-Slider, TCB-Team
thiemowmde moved T212419: Page preview shows own page when hovering reference backlinks from Review to Demo on the WMDE-QWERTY-Sprint-2019-01-10 board.
Mon, Jan 21, 10:54 AM · Readers-Web-Backlog (Design), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-10, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Need-volunteer, TCB-Team, Page-Previews

Jan 18 2019

thiemowmde committed rEFLIc90a61916e83: Start using array constants (authored by thiemowmde).
Start using array constants
Jan 18 2019, 9:45 PM
thiemowmde committed rEFLI9102dd1abace: Fixup incomplete test coverage in various places (authored by thiemowmde).
Fixup incomplete test coverage in various places
Jan 18 2019, 9:37 PM
thiemowmde committed rEFLI4d8521d3d6f1: Fixup incomplete test coverage in various places (authored by thiemowmde).
Fixup incomplete test coverage in various places
Jan 18 2019, 9:31 PM
thiemowmde committed rEFLI07aca9b16330: Start using array constants (authored by thiemowmde).
Start using array constants
Jan 18 2019, 9:31 PM
thiemowmde committed rEFLIbc78db666097: Fixup incomplete test coverage in various places (authored by thiemowmde).
Fixup incomplete test coverage in various places
Jan 18 2019, 9:27 PM
thiemowmde created T214151: Use FileImporter for cross-wiki transfers of media not allowed on Commons.
Jan 18 2019, 9:57 AM · TCB-Team, Move-Files-To-Commons

Jan 17 2019

thiemowmde added a comment to T211922: German character insertion toolbar appears multiple times in conflict screen.

Thanks a lot for working on this!

Jan 17 2019, 8:06 PM · Need-volunteer, WMDE-QWERTY-X-Mas-Sprint-2018-12-18, Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde committed rEFLIb5cd52ba5370: Start using array constants (authored by thiemowmde).
Start using array constants
Jan 17 2019, 7:55 PM
JStrodt_WMDE awarded T213955: Add support for aliased parameter names in source-wiki templates a Goat token.
Jan 17 2019, 1:13 PM · Patch-For-Review, TCB-Team, Move-Files-To-Commons

Jan 16 2019

thiemowmde committed rEFLI6fd2e98c2f0a: Consistently talke about "configuration pages", not "files" (authored by thiemowmde).
Consistently talke about "configuration pages", not "files"
Jan 16 2019, 7:44 PM
thiemowmde committed rEFLI20e5df6d2004: Allow multiple source parameters map to same target parameter (authored by thiemowmde).
Allow multiple source parameters map to same target parameter
Jan 16 2019, 7:37 PM
thiemowmde committed rEFLIce54a499c794: Allow multiple source parameters map to same target parameter (authored by thiemowmde).
Allow multiple source parameters map to same target parameter
Jan 16 2019, 7:24 PM
thiemowmde created T213955: Add support for aliased parameter names in source-wiki templates.
Jan 16 2019, 7:21 PM · Patch-For-Review, TCB-Team, Move-Files-To-Commons
thiemowmde added a comment to T213929: Replace local date format with the Commons date format.

Quick first story grooming:

  • Converting dates is an extremely hard problem. See T87764, for example. Whatever we implement will most probably be a "good enough" solution that will stop working in many situations (e.g. Chinese).
  • Deleting template parameters is certainly possible. It was not part of the original CommonsHelper2 specification, that's why we have not talked about it yet.
  • Wrapping text in language templates is part of the original CommonsHelper2 specification. We decided this should not be part of an MVP. A separate ticket exists: T198607.
  • I think the last bit is technically already resolved via T198316. I juts went to https://www.mediawiki.org/wiki/Extension:FileImporter/Data/de.wikipedia#Licensing and added this alternative headline.
Jan 16 2019, 6:07 PM · Move-Files-To-Commons, TCB-Team
thiemowmde added a comment to T198652: Links to anchors within the same page trigger page previews..

Why is suppressing the preview better than showing a possibly redundant one?

Jan 16 2019, 4:57 PM · good first bug, Readers-Web-Backlog, Page-Previews
thiemowmde moved T212419: Page preview shows own page when hovering reference backlinks from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-01-10 board.
Jan 16 2019, 4:55 PM · Readers-Web-Backlog (Design), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-10, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Need-volunteer, TCB-Team, Page-Previews
thiemowmde reopened T212419: Page preview shows own page when hovering reference backlinks as "Open".
Jan 16 2019, 4:54 PM · Readers-Web-Backlog (Design), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-10, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Need-volunteer, TCB-Team, Page-Previews
thiemowmde removed the image for WMDE-MediaWiki-maintenance.
Jan 16 2019, 3:31 PM
thiemowmde renamed WMDE-MediaWiki-maintenance from WMDE-mediawiki-maintenance to WMDE-MediaWiki-maintenance.
Jan 16 2019, 3:30 PM