Page MenuHomePhabricator

thiemowmde (Thiemo Kreuz (WMDE))
Software Developer

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 11:45 AM (343 w, 4 d)
Availability
Available
IRC Nick
Thiemo_WMDE
LDAP User
Thiemo Kreuz (WMDE)
MediaWiki User
Thiemo Kreuz (WMDE) [ Global Accounts ]

Recent Activity

Wed, May 5

thiemowmde added a comment to T280471: Flagging new usages of inappropriate words.

[…] help teach/remind the users […] about the problem and solution.

Wed, May 5, 2:10 PM · MediaWiki-Codesniffer, Voice & Tone

Tue, May 4

thiemowmde added a comment to T273971: Increase VE template dialog size.

Yes, this needs fixing. The behavior is confusing. Instead of 1 there are 2 breakpoints now: 1.) The width becomes flexible when the dialog starts touching the window. 2.) The height changes from 90% to 100% for no apparent reason.

Tue, May 4, 3:36 PM · Patch-For-Review, WMDE-TechWish-Sprint-2021-04-28, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-Templates-FocusArea
thiemowmde added a comment to T273971: Increase VE template dialog size.

What the keywords "medium" and "large" originally mean is specified in OO.ui.WindowManager.

  • "medium" is { width: 500 }
  • "large" is { width: 700 }
  • "larger" is { width: 900 }
Tue, May 4, 2:14 PM · Patch-For-Review, WMDE-TechWish-Sprint-2021-04-28, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-Templates-FocusArea
thiemowmde moved T281324: "Dwelling on a valid reference link" selenium tests failing from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-04-28 board.

Some quick investigation results:

  • I'm able to run these tests locally with no problem.
  • When I put Reference Previews back in Beta mode, the tests are skipped. No failure.
  • When I enable a conflicting gadget, the tests fail, but with a very different error (element (".mwe-popups") still not existing after 10000ms).
  • The failure described in this ticket happens because the ResourceLoader module ext.popups.main never loads.
  • This can actually happen when a registered user disabled both Page Previews as well as Reference Previews. However, the test forces the popupsreferencepreviews option to be enabled.
  • … since T281235 there are 2 options. popupsreferencepreviews while in Beta, and popups-reference-previews after Beta. That might be it.
Tue, May 4, 8:47 AM · Readers-Web-Backlog (Tracking), MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2021-04-28, Reference Previews, Page-Previews
thiemowmde added a comment to T281170: Regression: Inconsistent inner top padding in all popup types.

We currently don't have plans to pick this ticket up. The impact is very low. We don't know much about the code and the ticket that introduced it (T269336). I gave it a try (as I always do) to see if I can come up with an easy 1-line fix, but wasn't able to. Would be great if you could put this in your backlog.

Tue, May 4, 7:30 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Reference Previews, Page-Previews

Mon, May 3

thiemowmde added a comment to T281698: Browser tests for Reference Previews anonymous settings dialog.

Footer is always available.

Only when at least one of the popup types is disabled.

Mon, May 3, 1:19 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Reference Previews
thiemowmde updated subscribers of T281352: Broken settings dialogue for reference previews when in conflict with a skin/gadget.

[…] causes invisible "Cancel" text to be highlighted […]

Mon, May 3, 11:51 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2021-04-28, Regression, Reference Previews
thiemowmde moved T280590: Special:ImportFile does not check permissions from own config FileImporterRequiredRight from Review to Demo on the WMDE-TechWish-Sprint-2021-04-28 board.
Mon, May 3, 7:39 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2021-04-28, Move-Files-To-Commons, Security, Security-Team

Fri, Apr 30

thiemowmde moved T280590: Special:ImportFile does not check permissions from own config FileImporterRequiredRight from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-04-28 board.
Fri, Apr 30, 12:55 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2021-04-28, Move-Files-To-Commons, Security, Security-Team
thiemowmde added a project to T280590: Special:ImportFile does not check permissions from own config FileImporterRequiredRight: Patch-For-Review.

As written at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FileImporter/+/683860 this is not relevant on the Wikimedia cluster. The $wgFileImporterRequiredRight config is set to "upload" by default, but the upload right is checked anyway, independent from that config. The config was introduced for 2 reasons:

  • To be able to quickly change it in case there is a legitimate reason to limit the user group allowed to use the special page.
  • For 3rd party installations.

While this is a legitimate bug, it does not allow to bypass the upload restriction. Therefor I think this does not need to be market as a restricted security issue.

Fri, Apr 30, 12:47 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2021-04-28, Move-Files-To-Commons, Security, Security-Team
thiemowmde claimed T280590: Special:ImportFile does not check permissions from own config FileImporterRequiredRight.
Fri, Apr 30, 12:39 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2021-04-28, Move-Files-To-Commons, Security, Security-Team
WMDE-Fisch awarded T276319: Reference Previews breaks CiteTooltip on he.wikipedia.org a Like token.
Fri, Apr 30, 8:36 AM · WMDE-TechWish-Sprint-2021-04-28, Reference Previews
thiemowmde added a comment to T276319: Reference Previews breaks CiteTooltip on he.wikipedia.org.

It's done: https://he.wikipedia.org/wiki/Special:Diff/31279543

Fri, Apr 30, 8:33 AM · WMDE-TechWish-Sprint-2021-04-28, Reference Previews
thiemowmde moved T276319: Reference Previews breaks CiteTooltip on he.wikipedia.org from Watching (Stalled) to Demo on the WMDE-TechWish-Sprint-2021-04-28 board.
Fri, Apr 30, 8:32 AM · WMDE-TechWish-Sprint-2021-04-28, Reference Previews

Thu, Apr 29

thiemowmde moved T281353: Broken image in the hint to the settings link on mobile view from Review to Demo on the WMDE-TechWish-Sprint-2021-04-28 board.
Thu, Apr 29, 11:00 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Page-Previews, WMDE-TechWish-Sprint-2021-04-28, Reference Previews
thiemowmde updated subscribers of T267911: Add line numbering to syntax highlighting (CodeMirror extension).

Here is a code snippet everybody can copy-paste to their own https://de.wikipedia.org/wiki/Special:MyPage/common.css page in case they want to hide the line numbers.

Thu, Apr 29, 9:57 AM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Patch-For-Review, WMDE-TechWish-Sprint-2021-03-31, Community-Tech, MediaWiki-extensions-CodeMirror, Epic, WMDE-Templates-FocusArea
thiemowmde claimed T276319: Reference Previews breaks CiteTooltip on he.wikipedia.org.

I posted a request on the user page of the user that appears to be the main author/maintainer of the gadget: https://he.wikipedia.org/wiki/Special:Diff/31276698. Let's wait a few days for a response now, but ideally not longer than May 5th, see T271206. Alternatively we could contact one of the other users that edited the page.

Thu, Apr 29, 9:15 AM · WMDE-TechWish-Sprint-2021-04-28, Reference Previews
thiemowmde claimed T281351: Settings icon cut of in mobile view.
Thu, Apr 29, 8:36 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2021-04-28, Page-Previews, Regression, Reference Previews
thiemowmde claimed T281353: Broken image in the hint to the settings link on mobile view.

According to my first git bisect in the Popups codebase this issue exists since the very first patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/571465/ (T236097, April 2020) that enabled Page-Previews on mobile.

Thu, Apr 29, 7:58 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Page-Previews, WMDE-TechWish-Sprint-2021-04-28, Reference Previews
thiemowmde set the point value for T271206: Enable RefPreviews on first wikis to 1.
Thu, Apr 29, 7:34 AM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Patch-For-Review, WMDE-TechWish-Sprint-2021-04-28, User-notice, Reference Previews
thiemowmde added a comment to T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`.

I'm not working with these codebases any more. But since I created this ticket once, I had a quick look at some random codebases I could find.

Thu, Apr 29, 6:58 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wdwb-tech, User-Addshore, Wikibase-DataModel, Technical-Debt, Wikidata

Wed, Apr 28

Ladsgroup awarded T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test` a Like token.
Wed, Apr 28, 5:34 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wdwb-tech, User-Addshore, Wikibase-DataModel, Technical-Debt, Wikidata
thiemowmde set the point value for T281351: Settings icon cut of in mobile view to 1.
Wed, Apr 28, 1:43 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2021-04-28, Page-Previews, Regression, Reference Previews
thiemowmde moved T281227: Make settings dialog elements (checkboxes and buttons) use OOUI styles from Review to Demo on the WMDE-TechWish-Sprint-2021-04-28 board.
Wed, Apr 28, 1:36 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), WMDE-TechWish-Sprint-2021-04-28, Readers-Web-Backlog (Tracking), Page-Previews, Reference Previews
thiemowmde claimed T281352: Broken settings dialogue for reference previews when in conflict with a skin/gadget.
Wed, Apr 28, 1:33 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2021-04-28, Regression, Reference Previews
thiemowmde updated the task description for T281351: Settings icon cut of in mobile view.
Wed, Apr 28, 1:27 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2021-04-28, Page-Previews, Regression, Reference Previews
thiemowmde added projects to T281351: Settings icon cut of in mobile view: Regression, Page-Previews.

Quick investigation: Page previews are enabled on mobile since T236097: Dev: Popups modules should set targets to mobile and desktop. So the fact that we end here is intentional. The icon might have been broken because of some CSS optimizations we did while working on ReferencePreviews. Let's do a git bisect to see if a specific patch pops up.

Wed, Apr 28, 1:26 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2021-04-28, Page-Previews, Regression, Reference Previews
thiemowmde renamed T281352: Broken settings dialogue for reference previews when in conflict with a skin/gadget from Broken settings dialogue for reference previews on mobile view to Broken settings dialogue for reference previews when in conflict with a skin/gadget.
Wed, Apr 28, 1:26 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2021-04-28, Regression, Reference Previews
thiemowmde added a project to T281352: Broken settings dialogue for reference previews when in conflict with a skin/gadget: Regression.

The fact that ReferencePreviews are listed in the dialog is clearly a bug. Since T243822: Reference -Preview and -Popup shown both with Minerva in desktop mode ReferencePreviews are unavailable in the mobile skin (a.k.a. Minerva). In the patch https://gerrit.wikimedia.org/r/680293 (T277640) we introduced a 3-state model where null means a popup type is not available. We forgot to pass this information to the settings dialog. As of now the only thing the settings dialog respects is the BetaFeature flag, but not if there is a conflict with the skin or a gadget.

Wed, Apr 28, 1:24 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2021-04-28, Regression, Reference Previews
thiemowmde added a comment to T281353: Broken image in the hint to the settings link on mobile view.

Suggestion: Let's do a quick git bisect and see if we find a specific patch that might be responsible for this.

Wed, Apr 28, 1:24 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Page-Previews, WMDE-TechWish-Sprint-2021-04-28, Reference Previews
thiemowmde edited Description on WMDE-TechWish-Sprint-2021-04-28.
Wed, Apr 28, 8:46 AM
thiemowmde set the point value for T276319: Reference Previews breaks CiteTooltip on he.wikipedia.org to 1.
Wed, Apr 28, 8:44 AM · WMDE-TechWish-Sprint-2021-04-28, Reference Previews
thiemowmde claimed T281227: Make settings dialog elements (checkboxes and buttons) use OOUI styles.
Wed, Apr 28, 8:38 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), WMDE-TechWish-Sprint-2021-04-28, Readers-Web-Backlog (Tracking), Page-Previews, Reference Previews
thiemowmde added a comment to T281227: Make settings dialog elements (checkboxes and buttons) use OOUI styles.

Wed, Apr 28, 8:36 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), WMDE-TechWish-Sprint-2021-04-28, Readers-Web-Backlog (Tracking), Page-Previews, Reference Previews
thiemowmde added a comment to T276319: Reference Previews breaks CiteTooltip on he.wikipedia.org.

Next step: Message the user and ask if they can update the gadget to include both the old as well as the new setting name popups-reference-previews (see https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/682926/2/src/isReferencePreviewsEnabled.js#36).

Wed, Apr 28, 8:20 AM · WMDE-TechWish-Sprint-2021-04-28, Reference Previews
thiemowmde closed T276330: Remove RefPreviews conflicting gadget configuration: CiteTooltip on hewiki as Resolved.
Wed, Apr 28, 8:17 AM · WMDE-TechWish-Sprint-2021-03-03, Reference Previews
thiemowmde closed T276330: Remove RefPreviews conflicting gadget configuration: CiteTooltip on hewiki, a subtask of T276319: Reference Previews breaks CiteTooltip on he.wikipedia.org, as Resolved.
Wed, Apr 28, 8:17 AM · WMDE-TechWish-Sprint-2021-04-28, Reference Previews
thiemowmde moved T274903: Change template search in VisualEditor to use standard search API from Doing to Review on the WMDE-TechWish-Sprint-2021-04-28 board.
Wed, Apr 28, 8:11 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), WMDE-TechWish-Sprint-2021-04-28, WMDE-TechWish-Sprint-2021-04-14, WMDE-TechWish-Sprint-2021-03-03, Editing-team (Tracking), WMDE-TechWish-Sprint-2021-02-17, VisualEditor, WMDE-Templates-FocusArea, VisualEditor-MediaWiki-Templates
thiemowmde archived WMDE-TechWish-Sprint-2021-04-14.
Wed, Apr 28, 8:10 AM
thiemowmde added a comment to T281227: Make settings dialog elements (checkboxes and buttons) use OOUI styles.

For comparison, this is how the dialog looks right now. The checkboxes are the native ones from Chrome.

Wed, Apr 28, 7:29 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), WMDE-TechWish-Sprint-2021-04-28, Readers-Web-Backlog (Tracking), Page-Previews, Reference Previews

Tue, Apr 27

thiemowmde added a comment to T281227: Make settings dialog elements (checkboxes and buttons) use OOUI styles.

This is how it looks like with the first patch https://gerrit.wikimedia.org/r/682914:
{F34429776}

Tue, Apr 27, 1:39 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), WMDE-TechWish-Sprint-2021-04-28, Readers-Web-Backlog (Tracking), Page-Previews, Reference Previews
thiemowmde updated the task description for T281235: Separate beta and non-beta user setting for reference previews.
Tue, Apr 27, 12:34 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-04-28, Readers-Web-Backlog (Tracking), WMDE-TechWish-Sprint-2021-04-14, Patch-For-Review, Page-Previews, Reference Previews
thiemowmde merged T281234: Users that never opted out of reference preview beta should have the setting enabled into T281235: Separate beta and non-beta user setting for reference previews.
Tue, Apr 27, 11:22 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-04-28, Readers-Web-Backlog (Tracking), WMDE-TechWish-Sprint-2021-04-14, Patch-For-Review, Page-Previews, Reference Previews
thiemowmde merged task T281234: Users that never opted out of reference preview beta should have the setting enabled into T281235: Separate beta and non-beta user setting for reference previews.
Tue, Apr 27, 11:22 AM · WMDE-TechWish-Sprint-2021-04-14, Reference Previews
thiemowmde added a project to T281235: Separate beta and non-beta user setting for reference previews: Unplanned-Sprint-Work.
Tue, Apr 27, 11:21 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-04-28, Readers-Web-Backlog (Tracking), WMDE-TechWish-Sprint-2021-04-14, Patch-For-Review, Page-Previews, Reference Previews
thiemowmde moved T281235: Separate beta and non-beta user setting for reference previews from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-04-14 board.
Tue, Apr 27, 11:20 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-04-28, Readers-Web-Backlog (Tracking), WMDE-TechWish-Sprint-2021-04-14, Patch-For-Review, Page-Previews, Reference Previews
thiemowmde claimed T281235: Separate beta and non-beta user setting for reference previews.
Tue, Apr 27, 11:17 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-04-28, Readers-Web-Backlog (Tracking), WMDE-TechWish-Sprint-2021-04-14, Patch-For-Review, Page-Previews, Reference Previews
thiemowmde created T281235: Separate beta and non-beta user setting for reference previews.
Tue, Apr 27, 10:41 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-04-28, Readers-Web-Backlog (Tracking), WMDE-TechWish-Sprint-2021-04-14, Patch-For-Review, Page-Previews, Reference Previews
thiemowmde created T281227: Make settings dialog elements (checkboxes and buttons) use OOUI styles.
Tue, Apr 27, 9:00 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), WMDE-TechWish-Sprint-2021-04-28, Readers-Web-Backlog (Tracking), Page-Previews, Reference Previews

Mon, Apr 26

thiemowmde created T281170: Regression: Inconsistent inner top padding in all popup types.
Mon, Apr 26, 3:21 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Reference Previews, Page-Previews
thiemowmde updated the task description for T277640: Settings link to bottom of page for RefPreviews and Page Previews anonymous/non logged-in users.
Mon, Apr 26, 7:25 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-04-14, WMDE-TechWish-Sprint-2021-03-31, WMDE-TechWish-Sprint-2021-03-17, Reference Previews
thiemowmde moved T277639: Settings pop up for RefPreviews and Page Previews from Review to Demo on the WMDE-TechWish-Sprint-2021-04-14 board.
Mon, Apr 26, 7:24 AM · WMDE-TechWish-Sprint-2021-04-14, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-03-31, WMDE-TechWish-Sprint-2021-03-17, Reference Previews
thiemowmde updated the task description for T277639: Settings pop up for RefPreviews and Page Previews.
Mon, Apr 26, 7:24 AM · WMDE-TechWish-Sprint-2021-04-14, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-03-31, WMDE-TechWish-Sprint-2021-03-17, Reference Previews
thiemowmde moved T277640: Settings link to bottom of page for RefPreviews and Page Previews anonymous/non logged-in users from Review to Demo on the WMDE-TechWish-Sprint-2021-04-14 board.
Mon, Apr 26, 7:19 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-04-14, WMDE-TechWish-Sprint-2021-03-31, WMDE-TechWish-Sprint-2021-03-17, Reference Previews
thiemowmde updated the task description for T277640: Settings link to bottom of page for RefPreviews and Page Previews anonymous/non logged-in users.
Mon, Apr 26, 7:19 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-04-14, WMDE-TechWish-Sprint-2021-03-31, WMDE-TechWish-Sprint-2021-03-17, Reference Previews
thiemowmde moved T280762: Icon placement in reference previews is broken (again) from Review to Demo on the WMDE-TechWish-Sprint-2021-04-14 board.
Mon, Apr 26, 7:07 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Unplanned-Sprint-Work, Regression, WMDE-TechWish-Sprint-2021-04-14, Reference Previews
thiemowmde moved T254958: Syntax highlighting causes Firefox tab to freeze on long pages while editing from Sprint Backlog to Done on the WMDE-TechWish-Sprint-2021-04-14 board.
Mon, Apr 26, 7:06 AM · WMDE-TechWish-Sprint-2021-04-14, Community-Tech, MediaWiki-extensions-CodeMirror
thiemowmde closed T254958: Syntax highlighting causes Firefox tab to freeze on long pages while editing as Resolved.

Wonderful, thanks a lot for the fast response!

Mon, Apr 26, 7:06 AM · WMDE-TechWish-Sprint-2021-04-14, Community-Tech, MediaWiki-extensions-CodeMirror

Fri, Apr 23

thiemowmde merged T188305: CodeMirror: HTML comment before first pipe in template ends template highlighting into T277767: Wikitext syntax highlighter fails on comments in template names.
Fri, Apr 23, 5:58 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-04-14, Community-Tech, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea
thiemowmde merged task T188305: CodeMirror: HTML comment before first pipe in template ends template highlighting into T277767: Wikitext syntax highlighter fails on comments in template names.
Fri, Apr 23, 5:58 PM · MediaWiki-extensions-CodeMirror
thiemowmde added a comment to T254958: Syntax highlighting causes Firefox tab to freeze on long pages while editing.

While the performance on this example page is still not great, I believe it's already much better after the fixes we did in T270237. @AntiCompositeNumber, are you able to test this again and let us know if it behaves different now?

Fri, Apr 23, 5:49 PM · WMDE-TechWish-Sprint-2021-04-14, Community-Tech, MediaWiki-extensions-CodeMirror
thiemowmde claimed T277767: Wikitext syntax highlighter fails on comments in template names.
Fri, Apr 23, 1:35 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-04-14, Community-Tech, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea
thiemowmde changed the point value for T280978: Bracket matching sticks even when cursor leaves brackets from 1 to 2.
Fri, Apr 23, 1:35 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Community-Tech, Unplanned-Sprint-Work, Regression, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea, WMDE-TechWish-Sprint-2021-04-14
thiemowmde set the point value for T280978: Bracket matching sticks even when cursor leaves brackets to 1.
Fri, Apr 23, 12:44 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Community-Tech, Unplanned-Sprint-Work, Regression, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea, WMDE-TechWish-Sprint-2021-04-14
thiemowmde added a parent task for T278840: Bracket matching loses highlight when scrolling: T280978: Bracket matching sticks even when cursor leaves brackets.
Fri, Apr 23, 12:44 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Unplanned-Sprint-Work, Regression, WMDE-TechWish-Sprint-2021-03-31, WMDE-Templates-FocusArea
thiemowmde added a subtask for T280978: Bracket matching sticks even when cursor leaves brackets: T278840: Bracket matching loses highlight when scrolling.
Fri, Apr 23, 12:44 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Community-Tech, Unplanned-Sprint-Work, Regression, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea, WMDE-TechWish-Sprint-2021-04-14
thiemowmde created T280978: Bracket matching sticks even when cursor leaves brackets.
Fri, Apr 23, 12:44 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Community-Tech, Unplanned-Sprint-Work, Regression, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea, WMDE-TechWish-Sprint-2021-04-14
thiemowmde merged task T276406: Bracket matching styling shouldn't disappear after clicking the scroll bar into T278840: Bracket matching loses highlight when scrolling.
Fri, Apr 23, 12:41 PM · Community-Tech, MediaWiki-extensions-CodeMirror
thiemowmde merged T276406: Bracket matching styling shouldn't disappear after clicking the scroll bar into T278840: Bracket matching loses highlight when scrolling.
Fri, Apr 23, 12:41 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Unplanned-Sprint-Work, Regression, WMDE-TechWish-Sprint-2021-03-31, WMDE-Templates-FocusArea
thiemowmde added a comment to T280866: Make SVG rectangles expand/contract on platform-specific fonts label length.

I'm sure I miss something, but why don't you use HTML + CSS then?

Fri, Apr 23, 9:34 AM · Wikimedia Design Style Guide
thiemowmde added a comment to T280866: Make SVG rectangles expand/contract on platform-specific fonts label length.

To be honest I don't see an issue here. This specific constraint is not new. Over the years I learned that …

  1. We often forget this, but the text on a button changes with the language. This means it will be significantly longer in one language, and significantly shorter in another.
  2. This means we must design all our UI elements to be flexible, no matter how long the text is. We don't want a long text to be cut off or stick out of the element.
  3. What we often forget is what happens when the text is extremely short. Let's say the English button Publish changes becomes in Chinese. See what happens? The button becomes tiny. It's significantly harder to hit it with the mouse – an UX issue especially for users with motor impairments. Because of this pretty much all our UI elements need some min-width.
Fri, Apr 23, 8:28 AM · Wikimedia Design Style Guide
thiemowmde added a comment to T280471: Flagging new usages of inappropriate words.

[…] we have exceptions and ways to make the rule be ignored in certain cases

I know, but as we have seen this doesn't solve the fundamental issues. Not only is it still punishment, I pushes users in a defensive corner. Nobody should be forced to explain why they talk about e.g. "blind people" or "mastering something".

Fri, Apr 23, 8:15 AM · MediaWiki-Codesniffer, Voice & Tone

Thu, Apr 22

thiemowmde added a comment to T280866: Make SVG rectangles expand/contract on platform-specific fonts label length.

I dug a bit into what I know about SVG, as well as what the internet knows. Literally "enlarging the rectangle" when the text gets bigger is not possible, as far as I can tell. I mean, everything is possible, but only with JavaScript, not with pure SVG + CSS.

Thu, Apr 22, 1:10 PM · Wikimedia Design Style Guide
thiemowmde moved T277640: Settings link to bottom of page for RefPreviews and Page Previews anonymous/non logged-in users from Doing to Review on the WMDE-TechWish-Sprint-2021-04-14 board.
Thu, Apr 22, 10:27 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-04-14, WMDE-TechWish-Sprint-2021-03-31, WMDE-TechWish-Sprint-2021-03-17, Reference Previews

Wed, Apr 21

thiemowmde added a comment to T280471: Flagging new usages of inappropriate words.

I wonder if we can make sure this is going to be implemented in a way that does not feel like punishment? Tools like codesniffers are boolean. Either a word is in the list and nobody can ever use it, under no circumstances, or everybody can. But this is not how language works. Context matters a lot.

Wed, Apr 21, 11:25 AM · MediaWiki-Codesniffer, Voice & Tone
thiemowmde claimed T280762: Icon placement in reference previews is broken (again).
Wed, Apr 21, 10:31 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Unplanned-Sprint-Work, Regression, WMDE-TechWish-Sprint-2021-04-14, Reference Previews
thiemowmde updated subscribers of T280762: Icon placement in reference previews is broken (again).

I did a git bisect and found the responsible patch in core, not OOUI: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/673034.

Wed, Apr 21, 10:31 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Unplanned-Sprint-Work, Regression, WMDE-TechWish-Sprint-2021-04-14, Reference Previews
thiemowmde added a project to T280762: Icon placement in reference previews is broken (again): Unplanned-Sprint-Work.
Wed, Apr 21, 9:10 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Unplanned-Sprint-Work, Regression, WMDE-TechWish-Sprint-2021-04-14, Reference Previews
thiemowmde created T280762: Icon placement in reference previews is broken (again).
Wed, Apr 21, 9:10 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Unplanned-Sprint-Work, Regression, WMDE-TechWish-Sprint-2021-04-14, Reference Previews

Fri, Apr 16

thiemowmde committed rEBKK273ca16c4e95: Remove a lot of broken/deleted/unused code (authored by thiemowmde).
Remove a lot of broken/deleted/unused code
Fri, Apr 16, 7:40 AM

Thu, Apr 15

thiemowmde added a project to T278949: Remove dead code in Popup extension: Reference Previews.
Thu, Apr 15, 1:35 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Unplanned-Sprint-Work, Reference Previews, WMDE-TechWish-Sprint-2021-04-14, Readers-Web-Backlog (Tracking), Page-Previews
thiemowmde moved T278949: Remove dead code in Popup extension from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-04-14 board.
Thu, Apr 15, 1:34 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Unplanned-Sprint-Work, Reference Previews, WMDE-TechWish-Sprint-2021-04-14, Readers-Web-Backlog (Tracking), Page-Previews
thiemowmde claimed T278949: Remove dead code in Popup extension.
Thu, Apr 15, 1:30 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Unplanned-Sprint-Work, Reference Previews, WMDE-TechWish-Sprint-2021-04-14, Readers-Web-Backlog (Tracking), Page-Previews

Mon, Apr 12

thiemowmde committed rEFLIb9a0228b483d: Better error message when importing an "instant Commons" file (authored by thiemowmde).
Better error message when importing an "instant Commons" file
Mon, Apr 12, 3:33 PM

Apr 9 2021

JStrodt_WMDE awarded T278840: Bracket matching loses highlight when scrolling a Like token.
Apr 9 2021, 12:50 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Unplanned-Sprint-Work, Regression, WMDE-TechWish-Sprint-2021-03-31, WMDE-Templates-FocusArea
thiemowmde moved T278840: Bracket matching loses highlight when scrolling from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-03-31 board.
Apr 9 2021, 9:12 AM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Unplanned-Sprint-Work, Regression, WMDE-TechWish-Sprint-2021-03-31, WMDE-Templates-FocusArea
thiemowmde claimed T278840: Bracket matching loses highlight when scrolling.
Apr 9 2021, 9:12 AM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Unplanned-Sprint-Work, Regression, WMDE-TechWish-Sprint-2021-03-31, WMDE-Templates-FocusArea
thiemowmde added a comment to T279670: Text overflow after deleting several lines .

While I have seen this bug before, I can not reproduce it any more with the current state of the codebase. Is this on a specific browser? Can you verify if your codebase is up to date?

Apr 9 2021, 8:35 AM · MediaWiki-extensions-CodeMirror, Community-Tech

Apr 8 2021

thiemowmde added a comment to T278949: Remove dead code in Popup extension.

There is an existing patch with extensive investigation: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/662743

Apr 8 2021, 12:12 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Unplanned-Sprint-Work, Reference Previews, WMDE-TechWish-Sprint-2021-04-14, Readers-Web-Backlog (Tracking), Page-Previews

Apr 6 2021

thiemowmde added a comment to T271897: Add suggested values parameter property to TemplateData and to TemplateData editor.

We realized that "behind a feature flag" can have a surprising large number of meanings:

  1. It could mean that no UI element in VisualEditor ever shows suggested values, even if they are there.
  2. … it could mean the above, plus the TemplateData wizard's UI doesn't allow to add suggested values to a field, except the field already has suggested values.
  3. … it could mean all of the above, plus the TemplateData wizard's UI never shows the UI element, even if there are already suggested values.
  4. … it could mean all of the above, plus the HTML table rendered on the template page doesn't show suggested values, even if they are there.
  5. … it could mean all of the above, plus the TemplateData API never returns suggested values, even if they are there.
  6. … it could mean all of the above, plus when there is a "suggestedvalues" field in the JSON, it is silently discarded.
  7. … it could mean all of the above, plus the template can't be saved when there is a "suggestedvalues" field.
Apr 6 2021, 1:50 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), WMDE-TechWish-Sprint-2021-03-31, WMDE-TechWish-Sprint-2021-03-03, Editing-team (Tracking), VisualEditor, TemplateData, WMDE-Templates-FocusArea
thiemowmde added a comment to T271897: Add suggested values parameter property to TemplateData and to TemplateData editor.

Authors MUST give suggested values which match the field type.

Apr 6 2021, 12:15 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), WMDE-TechWish-Sprint-2021-03-31, WMDE-TechWish-Sprint-2021-03-03, Editing-team (Tracking), VisualEditor, TemplateData, WMDE-Templates-FocusArea

Apr 1 2021

thiemowmde added a comment to T274903: Change template search in VisualEditor to use standard search API.

@Lena_WMDE: https://docs.google.com/document/d/1SCtl31pMchiUkJV1iPdPUhUNyKzDcZoVyH37pSldSTA#heading=h.acnh93ezs5as already contains a comparison matrix. I tried to come up with a more complex matrix that incorporates everything written and said so far.

Apr 1 2021, 12:36 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), WMDE-TechWish-Sprint-2021-04-28, WMDE-TechWish-Sprint-2021-04-14, WMDE-TechWish-Sprint-2021-03-03, Editing-team (Tracking), WMDE-TechWish-Sprint-2021-02-17, VisualEditor, WMDE-Templates-FocusArea, VisualEditor-MediaWiki-Templates

Mar 31 2021

thiemowmde closed T267846: Investigation: Using ReferencePreviews together with NavigationPopups as Invalid.
Mar 31 2021, 12:45 PM · Navigation-Popups-Gadget, WMDE-TechWish, Reference Previews
thiemowmde moved T277639: Settings pop up for RefPreviews and Page Previews from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-03-31 board.
Mar 31 2021, 8:06 AM · WMDE-TechWish-Sprint-2021-04-14, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-03-31, WMDE-TechWish-Sprint-2021-03-17, Reference Previews
thiemowmde moved T277364: Alignment problem in link hovering from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2021-03-31 board.
Mar 31 2021, 8:06 AM · WMDE-TechWish-Sprint-2021-03-31, MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), WMDE-TechWish-Sprint-2021-03-17, Reference Previews
thiemowmde added a project to T277640: Settings link to bottom of page for RefPreviews and Page Previews anonymous/non logged-in users: WMDE-TechWish-Sprint-2021-03-31.
Mar 31 2021, 8:06 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-04-14, WMDE-TechWish-Sprint-2021-03-31, WMDE-TechWish-Sprint-2021-03-17, Reference Previews
thiemowmde added a project to T277364: Alignment problem in link hovering: WMDE-TechWish-Sprint-2021-03-31.
Mar 31 2021, 8:06 AM · WMDE-TechWish-Sprint-2021-03-31, MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), WMDE-TechWish-Sprint-2021-03-17, Reference Previews
thiemowmde moved T277364: Alignment problem in link hovering from Review to Demo on the WMDE-TechWish-Sprint-2021-03-17 board.
Mar 31 2021, 8:06 AM · WMDE-TechWish-Sprint-2021-03-31, MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), WMDE-TechWish-Sprint-2021-03-17, Reference Previews
thiemowmde added a project to T277639: Settings pop up for RefPreviews and Page Previews: WMDE-TechWish-Sprint-2021-03-31.
Mar 31 2021, 8:05 AM · WMDE-TechWish-Sprint-2021-04-14, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), WMDE-TechWish-Sprint-2021-03-31, WMDE-TechWish-Sprint-2021-03-17, Reference Previews
thiemowmde set Sprint Start to Mar 30 2021, 10:00 PM on WMDE-TechWish-Sprint-2021-03-31.
Mar 31 2021, 8:03 AM