Page MenuHomePhabricator

thiemowmde (Thiemo Kreuz (WMDE))
Software Developer

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 11:45 AM (253 w, 6 d)
Availability
Available
IRC Nick
Thiemo_WMDE
LDAP User
Thiemo Kreuz (WMDE)
MediaWiki User
Thiemo Kreuz (WMDE) [ Global Accounts ]

Recent Activity

Jun 7 2019

thiemowmde committed rEFLI228735adf47c: Isolate FileImporter integration test from external web services (authored by Andrew-WMDE).
Isolate FileImporter integration test from external web services
Jun 7 2019, 9:28 AM
thiemowmde committed rEFLIc91381d54fb9: Isolate FileImporter integration test from external web services (authored by Andrew-WMDE).
Isolate FileImporter integration test from external web services
Jun 7 2019, 9:24 AM

Jun 6 2019

thiemowmde reopened T223771: "Everything" tab in codesearch does not search any extension any more as "Open".

It seems it's broken again.

Jun 6 2019, 4:31 PM · Regression, VPS-project-codesearch
thiemowmde updated subscribers of T225195: EventBus jobs failing heavily because of CentralNotice and WikibaseRepo.
Jun 6 2019, 1:36 PM · Patch-For-Review, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-WikibaseRepository, EventBus, MediaWiki-extensions-CentralAuth, Analytics, Wikidata, Wikimedia-production-error (Shared Build Failure)
thiemowmde committed rEFLIada1c48d04a6: Redesign the WikitextConversions constructor signature (authored by thiemowmde).
Redesign the WikitextConversions constructor signature
Jun 6 2019, 12:54 PM
thiemowmde added a parent task for T225195: EventBus jobs failing heavily because of CentralNotice and WikibaseRepo: T225162: Fix flapping tests in gated extensions as of 2019-06-06.
Jun 6 2019, 10:49 AM · Patch-For-Review, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-WikibaseRepository, EventBus, MediaWiki-extensions-CentralAuth, Analytics, Wikidata, Wikimedia-production-error (Shared Build Failure)
thiemowmde added a subtask for T225162: Fix flapping tests in gated extensions as of 2019-06-06: T225195: EventBus jobs failing heavily because of CentralNotice and WikibaseRepo.
Jun 6 2019, 10:49 AM · Release-Engineering-Team (Unit & Int & System Tooling), Release-Engineering-Team-TODO, MediaWiki-extensions-General
Restricted Application added projects to T225195: EventBus jobs failing heavily because of CentralNotice and WikibaseRepo: Wikidata, Analytics.
Jun 6 2019, 10:49 AM · Patch-For-Review, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-WikibaseRepository, EventBus, MediaWiki-extensions-CentralAuth, Analytics, Wikidata, Wikimedia-production-error (Shared Build Failure)
thiemowmde added a project to T225163: Spurious timeout in MediaWiki's rollback browser test: Confirmation prompt for rollback action.

I have seen this almost every day now, for weeks. Here is the most recent one: https://gerrit.wikimedia.org/r/514495.

18:21:39 1) Rollback with confirmation should offer a way to cancel rollbacks:
18:21:39 element (".mw-rollback-link .jquery-confirmable-button-no") still not visible after 5000ms
18:21:39 running chrome
18:21:39 Error: element (".mw-rollback-link .jquery-confirmable-button-no") still not visible after 5000ms
18:21:39     at elements(".mw-rollback-link .jquery-confirmable-button-no") - isVisible.js:54:17
18:21:39     at isVisible(".mw-rollback-link .jquery-confirmable-button-no") - waitForVisible.js:73:22

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/22363/console

Jun 6 2019, 10:22 AM · Patch-For-Review, Confirmation prompt for rollback action, Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing, Browser-Tests
thiemowmde committed rEFLI1464e7705e36: Simplify WikidataTemplateLookup code utilizing array_reduce() (authored by thiemowmde).
Simplify WikidataTemplateLookup code utilizing array_reduce()
Jun 6 2019, 10:13 AM
thiemowmde committed rEFLIdf3ac17c17ec: Streamline SpecialImportFile::handleImportException() code (authored by thiemowmde).
Streamline SpecialImportFile::handleImportException() code
Jun 6 2019, 9:27 AM

Jun 5 2019

thiemowmde committed rEFLIdef805dc2b12: Simplify WikidataTemplateLookup code utilizing array_reduce() (authored by thiemowmde).
Simplify WikidataTemplateLookup code utilizing array_reduce()
Jun 5 2019, 3:05 PM
thiemowmde committed rEFLI64f48fcfa4db: Streamline SpecialImportFile::handleImportException() code (authored by thiemowmde).
Streamline SpecialImportFile::handleImportException() code
Jun 5 2019, 2:48 PM
thiemowmde committed rEFLI800a40014d81: Suggest NowCommons template for source wiki (authored by awight).
Suggest NowCommons template for source wiki
Jun 5 2019, 2:48 PM
thiemowmde created T225095: Duplicate, native +/- buttons on all NumberInputWidgets in Firefox.
Jun 5 2019, 1:53 PM · OOUI
thiemowmde created T225094: Unexpected global state sharing between different alert windows.
Jun 5 2019, 1:45 PM · OOUI
thiemowmde committed rEFLI447893e6852b: Streamline SpecialImportFile::handleImportException() code (authored by thiemowmde).
Streamline SpecialImportFile::handleImportException() code
Jun 5 2019, 1:42 PM
thiemowmde committed rEFLI8d3b4cf39ba5: Fix NamespaceUnlocalizer messing with interwiki prefixes (authored by thiemowmde).
Fix NamespaceUnlocalizer messing with interwiki prefixes
Jun 5 2019, 12:04 PM
thiemowmde added a comment to T198584: Update wikilinks to point back to source project.

That's a fascinating edge-case, thanks for reporting! I created T225083 to take care of it.

Jun 5 2019, 12:00 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), WMDE-QWERTY-Sprint-2019-05-15, WMDE-QWERTY-Sprint-2019-04-30, TCB-Team, Move-Files-To-Commons
thiemowmde created T225083: Issues when cleaning up wikilinks that point to the target wiki.
Jun 5 2019, 11:58 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), TCB-Team, WMDE-QWERTY-Team, Move-Files-To-Commons
thiemowmde added a comment to T193125: Change font color in messages.

I had a quick look at the exception. I believe there is a misconfiguration in one of the filters on this wiki: https://commons.wikimedia.beta.wmflabs.org/wiki/Special:AbuseFilter?furtheroptions%5B%5D=hidedisabled. I don't know which. In other words, I believe this is not us, and there is nothing we can do to fix this in our codebase. To not make a badly configured filter make the AbuseFilter extension crash, that extension would need a fix/partly rewrite. This might be worth opening a separate ticket.

Jun 5 2019, 10:37 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), WMDE-QWERTY-Sprint-2019-05-29, WMDE-QWERTY-Team, good first bug, Design, WMDE-Design, TCB-Team, Move-Files-To-Commons
thiemowmde committed rEFLIa7e26671c12d: Improve test coverage for ImportPlanValidator::cleanWikitext() (authored by thiemowmde).
Improve test coverage for ImportPlanValidator::cleanWikitext()
Jun 5 2019, 10:01 AM
thiemowmde committed rEFLI9217056303f7: Prefer Title::makeTitleSafe() instead of Title::newFromText() (authored by thiemowmde).
Prefer Title::makeTitleSafe() instead of Title::newFromText()
Jun 5 2019, 9:43 AM
thiemowmde moved T223709: Namespace selection in AdvancedSearch is not respected any more from Doing to Demo on the WMDE-QWERTY-Sprint-2019-05-29 board.

This task turned out to be pretty painful because of a multitude of unrelated failing tests. Here is a quick post mortem:

Jun 5 2019, 9:34 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), WMDE-QWERTY-Sprint-2019-05-29, Patch-For-Review, Discovery-Search, TCB-Team, Regression, Advanced-Search
thiemowmde moved T224969: 20% time things for 5/29 from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-05-29 board.
Jun 5 2019, 9:10 AM · WMDE-QWERTY-Sprint-2019-05-29
thiemowmde added a project to T223021: Clean up FileImporter test class namespaces: WMDE-QWERTY-Sprint-2019-05-29.
Jun 5 2019, 9:10 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-29, good first bug, WMDE-QWERTY-Team, Move-Files-To-Commons, TCB-Team
thiemowmde edited projects for T223017: Isolate FileImporter integration test from external web services, added: WMDE-QWERTY-Sprint-2019-05-29; removed MW-1.34-notes (1.34.0-wmf.7; 2019-05-28).

Briefly discussed and estimated with the team.

  • We do not want to split the test, but replace the API call with a mocked one.
  • We suggest to store the JSON responses from the actual API calls in a series of files (e.g. in the existing tests/phpunit/res/ folder), and use these files in the mock.
Jun 5 2019, 9:09 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), WMDE-QWERTY-Sprint-2019-05-29, WMDE-QWERTY-Team, Move-Files-To-Commons, TCB-Team
thiemowmde updated the task description for T223021: Clean up FileImporter test class namespaces.
Jun 5 2019, 9:06 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-29, good first bug, WMDE-QWERTY-Team, Move-Files-To-Commons, TCB-Team
thiemowmde committed rEFLI628c850f4a1d: Prefer Title::makeTitleSafe() instead of Title::newFromText() (authored by thiemowmde).
Prefer Title::makeTitleSafe() instead of Title::newFromText()
Jun 5 2019, 8:31 AM

Jun 4 2019

thiemowmde committed rEFLI9381bb5918a8: Fix WikitextConversions possibly removing non-obsolete templates (authored by thiemowmde).
Fix WikitextConversions possibly removing non-obsolete templates
Jun 4 2019, 3:00 PM
thiemowmde committed rEFLIdfaa4e6de1d6: Run recoverable CommonsHelper checks after unrecoverable errors (authored by thiemowmde).
Run recoverable CommonsHelper checks after unrecoverable errors
Jun 4 2019, 3:00 PM
thiemowmde committed rEFLI9c59ed24710b: Remove not needed check for Title being null in ImportPlan (authored by thiemowmde).
Remove not needed check for Title being null in ImportPlan
Jun 4 2019, 2:48 PM
thiemowmde added a comment to T224230: Reorder order of file-move-checks to show blocking errors first.

I had a quick look at the patch, and it's a nice and helpful change. Unfortunately it seems to miss one thing. Why can't we run all these unrecoverable errors (user isn't allowed to upload files, bad file extension, duplicate file already exists) before the wikitext conversions? That's what I originally reported: The error message that asks to create a config page for the source wiki (that's a recoverable error!) should not appear before any unrecoverable one. Is there a technical reason this isn't possible?

Jun 4 2019, 2:13 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), WMDE-QWERTY-Sprint-2019-05-29, WMDE-QWERTY-Team, TCB-Team, Move-Files-To-Commons
thiemowmde added a comment to T216498: Invite to access Contributions for users that reached Content translation through other invites.

There you go:


The most obvious thing was to not duplicate the code that makes up the two sheets of paper, but reuse it.

Jun 4 2019, 10:38 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Language-Team (Language-2019-July-September), CX-out-of-beta
thiemowmde added a comment to T18691: RFC: Section headings should have a clickable anchor.

I would suggest not to call any code from the Popups extension (tagged as Page-Previews here on Phabricator, as well as Reference Previews). I would also suggest not to reuse the design from the Popups extension. I mean, there is not really anything wrong with this design. It still fits quite well with the current style guide. But it's outdated and much older than the current OOUI styles. Please stick to the OOUI PopupButtonWidget.

Jun 4 2019, 10:14 AM · Patch-For-Review, Readers-Web-Backlog (Design), TechCom-RFC, Design, MediaWiki-Interface
thiemowmde created T224971: Break up circular dependencies between storage and view classes.
Jun 4 2019, 9:39 AM · Technical-Debt, WMDE-QWERTY-Team, TCB-Team, Revision-Slider

May 29 2019

thiemowmde closed T208994: Flaky TwoColConflict test "The help dialog is visible" (mwselenium) as Resolved.
May 29 2019, 6:31 PM · TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde closed T208994: Flaky TwoColConflict test "The help dialog is visible" (mwselenium), a subtask of T222714: Remove the code for the first interface , as Resolved.
May 29 2019, 6:31 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), WMDE-QWERTY-Sprint-2019-08-08, Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde added a comment to T208994: Flaky TwoColConflict test "The help dialog is visible" (mwselenium).

Is this a duplicate of T222441: TwoColConflict browser tests are flapping? Anyway, this got resolved with https://gerrit.wikimedia.org/r/511754. The failing test doesn't exist any more.

May 29 2019, 6:31 PM · TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde closed T223390: TwoColConflict browser tests failing because of VisualEditor welcome dialog as Resolved.
May 29 2019, 6:29 PM · User-Ryasmeen, Patch-For-Review, Regression, VisualEditor, TCB-Team, WMDE-QWERTY-Team, Two-Column-Edit-Conflict-Merge
thiemowmde closed T222441: TwoColConflict browser tests are flapping as Resolved.

Resolved with https://gerrit.wikimedia.org/r/511754: the failing test doesn't exist any more.

May 29 2019, 6:28 PM · Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde closed T222441: TwoColConflict browser tests are flapping, a subtask of T222714: Remove the code for the first interface , as Resolved.
May 29 2019, 6:28 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), WMDE-QWERTY-Sprint-2019-08-08, Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde updated the task description for T222714: Remove the code for the first interface .
May 29 2019, 6:27 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), WMDE-QWERTY-Sprint-2019-08-08, Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde added a comment to T222783: Return meaningful error message when users try to import a file with a forbidden file type.

When I need to know the file types a wiki accepts, I typically check https://commons.wikimedia.org/wiki/Special:Upload. It currently says:

Permitted file types: tiff, tif, png, gif, jpg, jpeg, webp, xcf, mid, ogg, ogv, svg, djvu, stl, oga, flac, opus, wav, webm, mp3.

We can easily do the same and just list all extensions.

May 29 2019, 3:54 PM · good first bug, WMDE-QWERTY-Team, TCB-Team, Move-Files-To-Commons
thiemowmde committed rEFLIefee912cae13: Use content language for the auto summary (authored by WMDE-Fisch).
Use content language for the auto summary
May 29 2019, 2:39 PM
thiemowmde committed rEFLIa58f22067add: Fix incomplete coverage for two more tests (authored by thiemowmde).
Fix incomplete coverage for two more tests
May 29 2019, 2:29 PM
thiemowmde committed rEFLI09bd0904386d: Add language templates when requested via `@` syntax in the configuration (authored by Andrew-WMDE).
Add language templates when requested via `@` syntax in the configuration
May 29 2019, 2:15 PM
thiemowmde added a comment to T223218: Clean up ConfigFiles.

@Lea_WMDE, may I ask why this tasks asks to remove "self, self2, and multilicense replacing placeholder"? The linked ticket T198609 doesn't help me to understand this.

May 29 2019, 1:43 PM · WMDE-QWERTY-Sprint-2019-05-29, TCB-Team, Move-Files-To-Commons
thiemowmde moved T223709: Namespace selection in AdvancedSearch is not respected any more from Backlog to Doing (others) on the Advanced-Search board.
May 29 2019, 1:28 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), WMDE-QWERTY-Sprint-2019-05-29, Patch-For-Review, Discovery-Search, TCB-Team, Regression, Advanced-Search
thiemowmde merged T224530: URL parameters vanish if namespaces are changed in Advanced Search into T223709: Namespace selection in AdvancedSearch is not respected any more.
May 29 2019, 1:14 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), WMDE-QWERTY-Sprint-2019-05-29, Patch-For-Review, Discovery-Search, TCB-Team, Regression, Advanced-Search
thiemowmde merged task T224530: URL parameters vanish if namespaces are changed in Advanced Search into T223709: Namespace selection in AdvancedSearch is not respected any more.
May 29 2019, 1:14 PM · Regression, Discovery-Search, Advanced-Search, TCB-Team
thiemowmde merged T223701: Recent search regression: changing certain components in the search bar changes the URL to a plain index.php into T223709: Namespace selection in AdvancedSearch is not respected any more.
May 29 2019, 1:13 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), WMDE-QWERTY-Sprint-2019-05-29, Patch-For-Review, Discovery-Search, TCB-Team, Regression, Advanced-Search
thiemowmde merged task T223701: Recent search regression: changing certain components in the search bar changes the URL to a plain index.php into T223709: Namespace selection in AdvancedSearch is not respected any more.
May 29 2019, 1:13 PM · TCB-Team, Wikimedia-Hackathon-2019, Advanced-Search, Regression, Patch-For-Review
thiemowmde moved T198616: Autogenerated edit-summaries should be in content-language from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-05-29 board.
May 29 2019, 12:57 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), WMDE-QWERTY-Sprint-2019-05-29, WMDE-QWERTY-Sprint-2019-05-15, TCB-Team, Move-Files-To-Commons
thiemowmde moved T198607: Add language templates when requested via `@` syntax in the configuration from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-05-29 board.
May 29 2019, 12:57 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-29, WMDE-QWERTY-Sprint-2019-05-15, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2019-04-30, TCB-Team, Move-Files-To-Commons
thiemowmde added members for WMDE-QWERTY-Sprint-2019-05-29: thiemowmde, WMDE-Fisch, Andrew-WMDE, awight, jkroll, Lea_WMDE.
May 29 2019, 12:46 PM
thiemowmde archived WMDE-QWERTY-Sprint-2019-04-30.
May 29 2019, 12:45 PM
thiemowmde added members for WMDE-QWERTY-Sprint-2019-05-15: awight, WMDE-Fisch, jkroll, Andrew-WMDE, Lea_WMDE.
May 29 2019, 12:45 PM
thiemowmde added a member for WMDE-QWERTY-Sprint-2019-05-15: thiemowmde.
May 29 2019, 12:44 PM
thiemowmde added a member for Two-Column-Edit-Conflict-Merge: thiemowmde.
May 29 2019, 12:41 PM
thiemowmde removed a member for MediaWiki-extensions-WikibaseClient: thiemowmde.
May 29 2019, 12:40 PM
thiemowmde removed a member for MediaWiki-extensions-WikibaseRepository: thiemowmde.
May 29 2019, 12:40 PM
thiemowmde removed a member for MediaWiki-extensions-WikibaseView: thiemowmde.
May 29 2019, 12:40 PM
thiemowmde removed a member for Wikibase-DataModel: thiemowmde.
May 29 2019, 12:39 PM
thiemowmde removed a member for Wikibase-DataModel-Services: thiemowmde.
May 29 2019, 12:39 PM
thiemowmde removed a member for Wikibase-Lua: thiemowmde.
May 29 2019, 12:39 PM
thiemowmde removed a member for WikibaseMediaInfo: thiemowmde.
May 29 2019, 12:39 PM
thiemowmde removed a member for Wikidata: thiemowmde.
May 29 2019, 12:38 PM
thiemowmde removed a member for MediaWiki-extensions-PropertySuggester: thiemowmde.
May 29 2019, 12:38 PM
thiemowmde added a comment to T223701: Recent search regression: changing certain components in the search bar changes the URL to a plain index.php.

I believe this can be merged as a duplicate of T223709: Namespace selection in AdvancedSearch is not respected any more, and is also already fixed via https://gerrit.wikimedia.org/r/511025. Unfortunately, the patch is blocked on failing tests.

May 29 2019, 10:56 AM · TCB-Team, Wikimedia-Hackathon-2019, Advanced-Search, Regression, Patch-For-Review
thiemowmde added a project to T224530: URL parameters vanish if namespaces are changed in Advanced Search: Regression.

I believe this is a duplicate of T223709: Namespace selection in AdvancedSearch is not respected any more, and already fixed via https://gerrit.wikimedia.org/r/511025. Unfortunately, the patch is blocked on failing tests.

May 29 2019, 10:56 AM · Regression, Discovery-Search, Advanced-Search, TCB-Team
thiemowmde committed rEFLIf2f3481cd77e: Add language templates when requested via `@` syntax in the configuration (authored by Andrew-WMDE).
Add language templates when requested via `@` syntax in the configuration
May 29 2019, 10:50 AM

May 28 2019

thiemowmde committed rEFLIe27a6c0b8465: Inline trivial method in SpecialImportFileDoImportTest (authored by thiemowmde).
Inline trivial method in SpecialImportFileDoImportTest
May 28 2019, 1:57 PM
thiemowmde committed rEFLIaf190fd07e5b: Fix @covers tags for CategoriesSnippet class (authored by thiemowmde).
Fix @covers tags for CategoriesSnippet class
May 28 2019, 1:16 PM
thiemowmde committed rEFLI7a6142eff30c: Simplify some test mocks and tests expecting exceptions (authored by thiemowmde).
Simplify some test mocks and tests expecting exceptions
May 28 2019, 8:57 AM
thiemowmde committed rEFLI40e3ca39ae4a: Simplify some test mocks and tests expecting exceptions (authored by thiemowmde).
Simplify some test mocks and tests expecting exceptions
May 28 2019, 8:49 AM
thiemowmde committed rEFLI49630fa36de5: Update test coverage for new code with some trivial tests (authored by thiemowmde).
Update test coverage for new code with some trivial tests
May 28 2019, 7:45 AM

May 27 2019

thiemowmde committed rEFLI54aef213c953: Move fields from ImportDetails to ImportPlan (authored by thiemowmde).
Move fields from ImportDetails to ImportPlan
May 27 2019, 3:56 PM
thiemowmde committed rEFLIaa1ef713fc6a: [WIP] Add language templates when requested via `@` syntax in the configuration (authored by Andrew-WMDE).
[WIP] Add language templates when requested via `@` syntax in the configuration
May 27 2019, 1:21 PM
thiemowmde committed rEFLI53b02d341ddd: Move fields from ImportDetails to ImportPlan (authored by thiemowmde).
Move fields from ImportDetails to ImportPlan
May 27 2019, 12:09 PM
thiemowmde committed rEFLI44472ea55d82: Simplify a few partial mocks (authored by thiemowmde).
Simplify a few partial mocks
May 27 2019, 10:16 AM
thiemowmde committed rEFLIa6b68c94437f: Move fields from ImportDetails to ImportPlan (authored by thiemowmde).
Move fields from ImportDetails to ImportPlan
May 27 2019, 10:14 AM
thiemowmde committed rEFLI9437832631da: Disable PhanParamReqAfterOpt check for this codebase (authored by thiemowmde).
Disable PhanParamReqAfterOpt check for this codebase
May 27 2019, 9:14 AM
thiemowmde added a comment to T220718: URLs with no slashes after domain name are "invalid" but are still shortened.

When the patch is merged and deployed, we will have a surprising amount of entries in the database that is not accessible any more. This is not strictly a problem, just a bit sad.

  • In case both URLs with and without the trailing slash have been submitted before, only the entry with the trailing slash will be used in the future.
    • If the entry with the trailing slash comes first in the database, this is fine.
    • But if the entry without the slash comes first, it's nicer, possibly shorter ID is gone.
  • In case only the URL without the slash was submitted, it's ID is gone.
May 27 2019, 7:40 AM · Patch-For-Review, MediaWiki-extensions-UrlShortener

May 24 2019

thiemowmde committed rEFLI7eadb9ff7977: Disable PhanParamReqAfterOpt check for this codebase (authored by thiemowmde).
Disable PhanParamReqAfterOpt check for this codebase
May 24 2019, 7:45 PM
thiemowmde committed rEFLI2e1b46aa6915: Disable PhanParamReqAfterOpt check for this codebase (authored by thiemowmde).
Disable PhanParamReqAfterOpt check for this codebase
May 24 2019, 7:45 PM
thiemowmde committed rEFLI5e467b3d42fd: [WIP] Add language templates when requested via `@` syntax in the configuration (authored by Andrew-WMDE).
[WIP] Add language templates when requested via `@` syntax in the configuration
May 24 2019, 7:45 PM
thiemowmde committed rEFLIb853fc534e65: Inject ImportPlanValidator services via constructor (authored by thiemowmde).
Inject ImportPlanValidator services via constructor
May 24 2019, 4:14 PM
thiemowmde committed rEFLIe5d86eea2f97: Disable PhanParamReqAfterOpt check for this codebase (authored by thiemowmde).
Disable PhanParamReqAfterOpt check for this codebase
May 24 2019, 4:12 PM
thiemowmde committed rEFLIca48622439ad: Inject ImportPlanValidator services via constructor (authored by thiemowmde).
Inject ImportPlanValidator services via constructor
May 24 2019, 1:03 PM
thiemowmde committed rEFLI14e8d0c0afa3: [WIP] Add language templates when requested via `@` syntax in the configuration (authored by Andrew-WMDE).
[WIP] Add language templates when requested via `@` syntax in the configuration
May 24 2019, 1:01 PM
thiemowmde committed rEFLI81dbed604fc7: Inject ImportPlanValidator services via constructor (authored by thiemowmde).
Inject ImportPlanValidator services via constructor
May 24 2019, 12:47 PM
thiemowmde committed rEFLIde40d1796f20: Add missing tests for WikiLinkParserFactory (authored by thiemowmde).
Add missing tests for WikiLinkParserFactory
May 24 2019, 11:07 AM
thiemowmde committed rEFLIe1bc9791157c: Avoid extra API request for the source wiki language (authored by thiemowmde).
Avoid extra API request for the source wiki language
May 24 2019, 10:52 AM
thiemowmde committed rEFLIa6dd81d61f42: Avoid extra API request for the source wiki language (authored by thiemowmde).
Avoid extra API request for the source wiki language
May 24 2019, 10:11 AM
thiemowmde committed rEFLId7da9ae2144a: Fix confusing "can't parse" error for empty source URLs (authored by thiemowmde).
Fix confusing "can't parse" error for empty source URLs
May 24 2019, 9:43 AM

May 23 2019

thiemowmde committed rEFLIed2e68312881: Avoid extra API request for the source wiki language (authored by thiemowmde).
Avoid extra API request for the source wiki language
May 23 2019, 5:25 PM
thiemowmde committed rEFLI09ac9117c4de: Inject ImportPlanValidator services via constructor (authored by thiemowmde).
Inject ImportPlanValidator services via constructor
May 23 2019, 5:25 PM
thiemowmde committed rEFLI37d7ade3002b: Avoid extra API request for the source wiki language (authored by thiemowmde).
Avoid extra API request for the source wiki language
May 23 2019, 3:51 PM
thiemowmde committed rEFLI3b33427b33d2: Add missing tests for WikiLinkParserFactory (authored by thiemowmde).
Add missing tests for WikiLinkParserFactory
May 23 2019, 3:09 PM