thiemowmde (Thiemo Kreuz (WMDE))
Software Developer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 11:45 AM (218 w, 4 d)
Availability
Available
IRC Nick
Thiemo_WMDE
LDAP User
Thiemo Kreuz (WMDE)
MediaWiki User
Thiemo Kreuz (WMDE) [ Global Accounts ]

Recent Activity

Fri, Dec 14

thiemowmde updated subscribers of T154789: Closure formatting is ugly.

Can we decline this, please, along with https://gerrit.wikimedia.org/r/355368? I mean, what is even the problem we are trying to solve here? array_map( function ( $x ) { return $this->format( $x ); }, $array ); is close to being unreadable. Enforcing it to be formatted as

array_map( function ( $x ) {
    return $this->format( $x );
}, $array );

or even

array_map(
    function ( $x ) {
        return $this->format( $x );
    },
    $array
);

is a really good thing, in my humble opinion.

Fri, Dec 14, 5:34 PM · Patch-For-Review, MediaWiki-Codesniffer
thiemowmde added a comment to T211919: Unbalanced 1 pixel gap in the red progress bar.

Yea, sorry. Chromium. Version 71.0.3578.80 (Official Build) Built on Ubuntu , running on Ubuntu 18.04 (64-bit).

Fri, Dec 14, 2:29 PM · WMDE-FUN-Team, WMDE-Fundraising-Tech

Thu, Dec 13

thiemowmde created T211925: Description of the reset/undo feature is not exact after using preview.
Thu, Dec 13, 7:46 PM · TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde created T211922: German character insertion toolbar appears multiple times in conflict screen.
Thu, Dec 13, 7:38 PM · Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde added projects to T211919: Unbalanced 1 pixel gap in the red progress bar: WMDE-Fundraising-Tech, WMDE-FUN-Team.
Thu, Dec 13, 7:27 PM · WMDE-FUN-Team, WMDE-Fundraising-Tech
thiemowmde created T211919: Unbalanced 1 pixel gap in the red progress bar.
Thu, Dec 13, 7:26 PM · WMDE-FUN-Team, WMDE-Fundraising-Tech

Wed, Dec 12

thiemowmde added a comment to T210755: Create upload log entries for all imported file revisions.

should we create the logs as we import each revision or should we create all the logs once at the end of the import process?

Wed, Dec 12, 6:57 PM · WMDE-QWERTY-Sprint-2018-12-04, WMDE-QWERTY-Sprint-2018-11-20, Move-Files-To-Commons, TCB-Team
thiemowmde edited Description on WMDE-QWERTY-Sprint-2018-12-04.
Wed, Dec 12, 5:02 PM
thiemowmde moved T210501: Edits on the left (other) side get lost when using preview/diff from Review to Demo on the WMDE-QWERTY-Sprint-2018-12-04 board.
Wed, Dec 12, 4:58 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, WMDE-QWERTY-Sprint-2018-12-04, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde edited Description on WMDE-QWERTY-Sprint-2018-12-04.
Wed, Dec 12, 4:56 PM
thiemowmde committed rESCCcebdd82aa126: Add missing code to not loose edits on the "other" side (authored by thiemowmde).
Add missing code to not loose edits on the "other" side
Wed, Dec 12, 10:31 AM
thiemowmde moved T210501: Edits on the left (other) side get lost when using preview/diff from Doing to Review on the WMDE-QWERTY-Sprint-2018-12-04 board.
Wed, Dec 12, 9:56 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, WMDE-QWERTY-Sprint-2018-12-04, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T211576: Cite silently ignores all parameters in <ref> with more than two parameters from Sprint Backlog to Done on the WMDE-QWERTY-Sprint-2018-12-04 board.
Wed, Dec 12, 9:56 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Need-volunteer, User-notice, WMDE-QWERTY-Sprint-2018-12-04, TCB-Team, Cite
thiemowmde updated the task description for T211576: Cite silently ignores all parameters in <ref> with more than two parameters.
Wed, Dec 12, 9:39 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Need-volunteer, User-notice, WMDE-QWERTY-Sprint-2018-12-04, TCB-Team, Cite
thiemowmde committed rEPFMbee2ffda4b20: Remove 'UnitTestList' hook (authored by Gopavasanth).
Remove 'UnitTestList' hook
Wed, Dec 12, 9:22 AM

Tue, Dec 11

thiemowmde committed rESCC3a733af3dcfa: Add missing code to not loose edits on the "other" side (authored by thiemowmde).
Add missing code to not loose edits on the "other" side
Tue, Dec 11, 4:37 PM
thiemowmde committed rESCCe56ae1762d9d: Add missing code to not loose edits on the "other" side (authored by thiemowmde).
Add missing code to not loose edits on the "other" side
Tue, Dec 11, 4:19 PM
thiemowmde edited projects for T211557: Bad interaction between RevisionSlider and CollapsibleVector extension, added: Revision-Slider; removed Multi-Content-Revisions (Reactive).

Just a mistake, sorry, @daniel. The one I wanted to point you at is T211473.

Tue, Dec 11, 3:33 PM · Revision-Slider, Regression, TCB-Team, MediaWiki-extensions-CollapsibleVector
thiemowmde added a comment to T210281: Find a better way to highligth letters then bold.

There is already a class:

:target .mw-cite-targeted-backlink {
	/* customizations go here */
}
Tue, Dec 11, 1:53 PM · WMDE-Design, Cite, Design, TCB-Team
thiemowmde committed rEPFMc22960057fc9: Make use of the …::class feature whenever possible (authored by thiemowmde).
Make use of the …::class feature whenever possible
Tue, Dec 11, 12:24 PM
thiemowmde committed rEPFMbc646a073a88: Make use of the …::class feature whenever possible (authored by thiemowmde).
Make use of the …::class feature whenever possible
Tue, Dec 11, 12:21 PM
thiemowmde committed rEPFM1bbdaadc6997: Use instanceof instead of get_class (authored by thiemowmde).
Use instanceof instead of get_class
Tue, Dec 11, 12:18 PM
thiemowmde committed rEPFM62d1a3117a2e: Type hints to narrow "parameter must be an array" error down (authored by Paladox).
Type hints to narrow "parameter must be an array" error down
Tue, Dec 11, 12:15 PM
thiemowmde committed rEPFM368c5989bcf0: Remove redundant text documenting constructors as "constructors" (authored by thiemowmde).
Remove redundant text documenting constructors as "constructors"
Tue, Dec 11, 12:11 PM
thiemowmde committed rEPFMf3846ad20f64: Add some missing PHPDoc type hints (authored by thiemowmde).
Add some missing PHPDoc type hints
Tue, Dec 11, 12:11 PM
thiemowmde closed T184912: Extra spaces are meaningful in sfn (differs from article text behavior) as Resolved.
Tue, Dec 11, 8:37 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Need-volunteer, MediaWiki-Parser, Cite
thiemowmde added a comment to T210684: Advanced search stuck showing three dots: "defaultUri is undefined" (Swedish wikis).

While it might be possible to make an educated guess based on heuristics that might turn out to be true or not in the individual case (e.g. just assuming Windows-1251 will most certainly be correct in the vast majority of situations), no code can know what I meant when I manually type …?title=%86%96%96. It might even be EBCDIC and decode as "foo" then.

Tue, Dec 11, 8:30 AM · WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, TCB-Team, Advanced-Search

Mon, Dec 10

thiemowmde triaged T211576: Cite silently ignores all parameters in <ref> with more than two parameters as Normal priority.
Mon, Dec 10, 1:20 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Need-volunteer, User-notice, WMDE-QWERTY-Sprint-2018-12-04, TCB-Team, Cite
thiemowmde created T211576: Cite silently ignores all parameters in <ref> with more than two parameters.
Mon, Dec 10, 11:54 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Need-volunteer, User-notice, WMDE-QWERTY-Sprint-2018-12-04, TCB-Team, Cite
thiemowmde committed rESCC9682b6a4c89e: Disable diff button on conflict solving screen (authored by WMDE-Fisch).
Disable diff button on conflict solving screen
Mon, Dec 10, 11:02 AM
thiemowmde added a comment to T210501: Edits on the left (other) side get lost when using preview/diff.

The issue with the statement "the conflict resolution screen already is a diff" is this: It's a diff the users are not familiar with. As a user I want a way to release myself from the limitations of the conflict resolution screen provided by the extension, and continue working in my familiar environment. I want a button to accept the current selections and continue editing in whatever wikitext editor I was using before. There I would then have access to a diff as usual.

Mon, Dec 10, 10:30 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, WMDE-QWERTY-Sprint-2018-12-04, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde added a project to T211473: JADE\Tests\Hooks\MoveHooksTest::testOnMovePageIsValidMove is broken: Multi-Content-Revisions.
Mon, Dec 10, 9:29 AM · Scoring-platform-team, Core Platform Team Backlog (Watching / External), Multi-Content-Revisions (Reactive), Jade
thiemowmde created T211557: Bad interaction between RevisionSlider and CollapsibleVector extension.
Mon, Dec 10, 8:47 AM · Revision-Slider, Regression, TCB-Team, MediaWiki-extensions-CollapsibleVector
thiemowmde committed rEASR26ab90e2656a: Stop using broken Uri class from MediaWiki core (authored by thiemowmde).
Stop using broken Uri class from MediaWiki core
Mon, Dec 10, 8:07 AM
thiemowmde added a comment to T210684: Advanced search stuck showing three dots: "defaultUri is undefined" (Swedish wikis).

I don't see what value a single, arbitrary "industry" example has. The user input is 100% wrong. There is no "right" way to make sense of it. Every "industry leader" I try does something different. GitHub does something different than https://www.google.com/search?q=a%01b, Google does something different than https://www.facebook.com/search/top/?q=a%01b, Facebook does something different than https://twitter.com/search?q=a%01b, …

Mon, Dec 10, 8:06 AM · WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, TCB-Team, Advanced-Search

Thu, Dec 6

thiemowmde committed rEFLIa94c8278a34a: Add config setting for the config help page (authored by WMDE-Fisch).
Add config setting for the config help page
Thu, Dec 6, 6:44 PM
thiemowmde committed rESCCdb542870410e: Use valid "data:…" URLs in the last step of tests (authored by thiemowmde).
Use valid "data:…" URLs in the last step of tests
Thu, Dec 6, 2:05 PM
thiemowmde awarded T106244: URL encoded values using fallback 8-bit encoding (invalid UTF-8) cause mediawiki.Uri to crash a Heartbreak token.
Thu, Dec 6, 1:42 PM · MediaWiki-General-or-Unknown, Performance-Team, JavaScript
thiemowmde added a comment to T210684: Advanced search stuck showing three dots: "defaultUri is undefined" (Swedish wikis).

Short answer: It's impossible to "guess" the "right 8-but character encoding". It would be wrong to assume anything.

Thu, Dec 6, 1:41 PM · WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, TCB-Team, Advanced-Search

Tue, Dec 4

thiemowmde set the point value for T210591: Create incident report for the get-editconflict-everywhere issue to 3.
Tue, Dec 4, 9:49 AM · WMDE-QWERTY-Sprint-2018-11-20, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde set the point value for T210508: Highlighting does not work if span with mw-cite-backlink class is removed to 5.
Tue, Dec 4, 9:49 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, Cite, TCB-Team

Mon, Dec 3

thiemowmde added a comment to T210758: Add browser test for preview functionality to MediaWiki core.

An actual incident report (in addition to the Google doc) is published now: https://wikitech.wikimedia.org/wiki/Incident_documentation/20181107-TwoColConflict

Mon, Dec 3, 5:31 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), WMDE-QWERTY-Sprint-2018-12-04, User-zeljkofilipin, MediaWiki-Core-Tests, Patch-For-Review, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2018-11-20, Two-Column-Edit-Conflict-Merge, Browser-Tests, TCB-Team
thiemowmde moved T210684: Advanced search stuck showing three dots: "defaultUri is undefined" (Swedish wikis) from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-11-20 board.
Mon, Dec 3, 2:58 PM · WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, TCB-Team, Advanced-Search
thiemowmde claimed T210684: Advanced search stuck showing three dots: "defaultUri is undefined" (Swedish wikis).

I was very curious and found this is actually a core bug in the mw.Uri module. Unfortunately I wasn't able to find the correct Phabricator tag yet.

Mon, Dec 3, 1:54 PM · WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, TCB-Team, Advanced-Search
thiemowmde added a comment to T199108: Block all imports if no configuration file for a source wiki exists.

@Lea_WMDE, the problem is that all we currently have in the FileImporter configuration is a base name for the CommonsHelper2 configuration pages. In our specific setup this base name is Extension:FileImporter/Data/. We append the abbreviated domain name, e.g. en.wikipedia, and expect to find a page via https://www.mediawiki.org/w/api.php?action=query&titles=Extension:FileImporter/Data/en.wikipedia, which is then either found or not.

Mon, Dec 3, 12:40 PM · WMDE-QWERTY-Sprint-2018-12-04, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-20, TCB-Team, Move-Files-To-Commons

Fri, Nov 30

thiemowmde added a comment to T210758: Add browser test for preview functionality to MediaWiki core.

@zeljkofilipin, whoops. Thanks for the hint. I changed the access rights for the document. An incident report will follow.

Fri, Nov 30, 6:14 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), WMDE-QWERTY-Sprint-2018-12-04, User-zeljkofilipin, MediaWiki-Core-Tests, Patch-For-Review, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2018-11-20, Two-Column-Edit-Conflict-Merge, Browser-Tests, TCB-Team
thiemowmde awarded T210836: +2 for Lucas_Werkmeister_WMDE in mediawiki/* a Like token.
Fri, Nov 30, 1:02 PM · User-Ladsgroup, Repository-Ownership-Requests
czar awarded T210501: Edits on the left (other) side get lost when using preview/diff a Burninate token.
Fri, Nov 30, 12:16 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, WMDE-QWERTY-Sprint-2018-12-04, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde added a comment to T209788: Unable to select and copy text on the right side of the donation form.

Ah, thanks. For your information, on https://spenden.wikimedia.de/?skin=0 with the current Firefox the text is not selectable.

Fri, Nov 30, 12:15 PM · WMDE-Fundraising-Tech, WMDE-FUN-Team
thiemowmde added a comment to T209788: Unable to select and copy text on the right side of the donation form.

Either my original test was with a slightly older Chrome version, or the donation interface changed in the meantime. It had nothing to do with the cursor. It really was not possible to select the text. Unfortunately I can not test this any more because I have neither access to the older Chrome any more, nor to older versions of the interface.

Fri, Nov 30, 10:29 AM · WMDE-Fundraising-Tech, WMDE-FUN-Team

Thu, Nov 29

thiemowmde committed rEASR4e9d9b41e5e5: Fix search page content significantly jumping again (authored by thiemowmde).
Fix search page content significantly jumping again
Thu, Nov 29, 6:28 PM
thiemowmde triaged T210758: Add browser test for preview functionality to MediaWiki core as Low priority.
Thu, Nov 29, 6:13 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), WMDE-QWERTY-Sprint-2018-12-04, User-zeljkofilipin, MediaWiki-Core-Tests, Patch-For-Review, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2018-11-20, Two-Column-Edit-Conflict-Merge, Browser-Tests, TCB-Team
thiemowmde created T210758: Add browser test for preview functionality to MediaWiki core.
Thu, Nov 29, 6:04 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), WMDE-QWERTY-Sprint-2018-12-04, User-zeljkofilipin, MediaWiki-Core-Tests, Patch-For-Review, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2018-11-20, Two-Column-Edit-Conflict-Merge, Browser-Tests, TCB-Team
thiemowmde committed rEFLIf6c4f6caf7c0: Add docs/wikitext-cleanup.md (authored by thiemowmde).
Add docs/wikitext-cleanup.md
Thu, Nov 29, 4:21 PM
thiemowmde committed rEFLIa4ba9f2c078a: Avoid using the real User class in tests, where possible (authored by thiemowmde).
Avoid using the real User class in tests, where possible
Thu, Nov 29, 3:10 PM
thiemowmde created T210722: Write help page describing "CommonHelper2" config page format in detail.
Thu, Nov 29, 1:06 PM · TCB-Team, Move-Files-To-Commons
thiemowmde committed rEFLI8a256332ce4e: Block imports if no configuration exists (authored by WMDE-Fisch).
Block imports if no configuration exists
Thu, Nov 29, 10:09 AM
thiemowmde committed rEFLIc498fe03a652: Block imports if no configuration exists (authored by WMDE-Fisch).
Block imports if no configuration exists
Thu, Nov 29, 10:06 AM
JStrodt_WMDE awarded T210520: Customized messages mess order of DOM elements up a Love token.
Thu, Nov 29, 9:11 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-20, TCB-Team, Cite

Wed, Nov 28

thiemowmde triaged T210625: Search page content significantly jumps again as Normal priority.
Wed, Nov 28, 4:39 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, TCB-Team, WMDE-FUN-Team, Advanced-Search
thiemowmde created T210625: Search page content significantly jumps again.
Wed, Nov 28, 4:38 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, TCB-Team, WMDE-FUN-Team, Advanced-Search
thiemowmde committed rESCC8fadcf01f04d: Collect statistics on the new interface. (authored by Andrew-WMDE).
Collect statistics on the new interface.
Wed, Nov 28, 2:44 PM
thiemowmde committed rESCC44a45653a183: Fix unescaped HTML injected into conflict resolution interface (authored by thiemowmde).
Fix unescaped HTML injected into conflict resolution interface
Wed, Nov 28, 2:16 PM
thiemowmde committed rESCCda5b4930bcca: Fix unescaped HTML injected into conflict resolution interface (authored by thiemowmde).
Fix unescaped HTML injected into conflict resolution interface
Wed, Nov 28, 1:31 PM
thiemowmde triaged T210603: Wikitext with HTML elements can mess the conflict resolution interface up as High priority.
Wed, Nov 28, 1:29 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-20, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde created T210603: Wikitext with HTML elements can mess the conflict resolution interface up.
Wed, Nov 28, 1:28 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-20, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde committed rEFLIbddcf7a7f372: Reuse existing URL to point to missing ComonsHelper config page (authored by thiemowmde).
Reuse existing URL to point to missing ComonsHelper config page
Wed, Nov 28, 1:01 PM
thiemowmde moved T210520: Customized messages mess order of DOM elements up from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-11-20 board.
Wed, Nov 28, 11:43 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-20, TCB-Team, Cite
thiemowmde claimed T210520: Customized messages mess order of DOM elements up.
Wed, Nov 28, 11:43 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-20, TCB-Team, Cite
thiemowmde moved T210508: Highlighting does not work if span with mw-cite-backlink class is removed from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-11-20 board.
Wed, Nov 28, 11:43 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, Cite, TCB-Team
thiemowmde claimed T210508: Highlighting does not work if span with mw-cite-backlink class is removed.
Wed, Nov 28, 11:43 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, Cite, TCB-Team
thiemowmde triaged T210520: Customized messages mess order of DOM elements up as High priority.
Wed, Nov 28, 11:13 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-20, TCB-Team, Cite

Tue, Nov 27

thiemowmde created T210520: Customized messages mess order of DOM elements up.
Tue, Nov 27, 5:23 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-20, TCB-Team, Cite
thiemowmde committed rEASR121389708bda: Fix search page content significantly jumping again (authored by thiemowmde).
Fix search page content significantly jumping again
Tue, Nov 27, 5:07 PM
thiemowmde created T210501: Edits on the left (other) side get lost when using preview/diff.
Tue, Nov 27, 2:42 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, WMDE-QWERTY-Sprint-2018-12-04, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde closed T194129: Parse the config files for bad templates and categories as Resolved.
Tue, Nov 27, 2:21 PM · MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), WMDE-QWERTY-Sprint-2018-05-23, WMDE-QWERTY-Team, Move-Files-To-Commons, TCB-Team, German-Community-Wishlist
thiemowmde closed T194129: Parse the config files for bad templates and categories, a subtask of T146751: Don't allow the moving of files with a wrong licence, as Resolved.
Tue, Nov 27, 2:21 PM · WMDE-QWERTY-Team, Move-Files-To-Commons, TCB-Team, German-Community-Wishlist
thiemowmde updated subscribers of T210281: Find a better way to highligth letters then bold.

I played around with a few styling options. The little "b" is what is relevant in the following examples.

.mw-cite-backlink a sup {
    padding: 0 0.3em;
}
.mw-cite-backlink a:target sup {
    background: rgba(0, 110, 255, 0.3);
    text-shadow: 0 0 1px #fff;
}

The idea is to apply the padding to all these small letters (they are barely clickable with the mouse anyway), and add the color to the relevant one.

Tue, Nov 27, 2:13 PM · WMDE-Design, Cite, Design, TCB-Team

Thu, Nov 22

Lea_WMDE awarded T195724: Adapt Save-, Preview- and Cancel buttons to new version (No. 8) a Love token.
Thu, Nov 22, 12:00 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), WMDE-QWERTY-Sprint-2018-10-23, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), WMDE-QWERTY-Sprint-2018-10-09, WMDE-QWERTY-Sprint-2018-09-13, Design, TCB-Team, WMDE-Design, Two-Column-Edit-Conflict-Merge, WMDE-QWERTY-Team

Wed, Nov 21

thiemowmde added a comment to T206323: Establish caret/arrow as jump mark for screen readers.

The patch https://gerrit.wikimedia.org/r/474893 will have a few effects:

  • The two messages "Jump up" and "Jump back up" will be visible to every user as a mouse hover tooltip, when hovering the up arrows. This was not the case before.
  • Some up arrows will say "Jump up", some others will say "Jump back up".
  • "Jump up" will be the tooltip for up arrows that are always visible (on references that are only used one time).
  • "Jump back up" will appear dynamically on references that are used multiple times. For these, the up arrow will only become clickable (and this will include the tooltip) when the reference got highlighted.
Wed, Nov 21, 3:20 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, Cite, WMDE-QWERTY-Sprint-2018-11-06, TCB-Team, Accessibility, German-Community-Wishlist, Need-volunteer
thiemowmde committed rEBOPf03be52640b8: Inline setSubmitCallback in BoilerPlate example code (authored by thiemowmde).
Inline setSubmitCallback in BoilerPlate example code
Wed, Nov 21, 1:31 PM

Tue, Nov 20

thiemowmde triaged T209942: FileImporter should add entries to the import log as Normal priority.
Tue, Nov 20, 1:27 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-20, TCB-Team, Move-Files-To-Commons
thiemowmde added a project to T209346: If a user's file was moved to Commons, their account should be autocreated: WMDE-QWERTY-Sprint-2018-11-20.
Tue, Nov 20, 12:52 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-20, Move-Files-To-Commons, TCB-Team
thiemowmde triaged T209268: Remove hint that TwoColConflict will soon be changed as Normal priority.
Tue, Nov 20, 12:45 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-20, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T209360: Fix TwoColConflict dashboard to show numbers for v2 interface from Incoming to Edit Conflict Handling on the TCB-Team board.
Tue, Nov 20, 12:44 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-20, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde triaged T209360: Fix TwoColConflict dashboard to show numbers for v2 interface as Normal priority.
Tue, Nov 20, 12:44 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-20, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde added a project to T207639: Make AdvancedSearch default on all wikis: WMDE-QWERTY-Sprint-2018-11-20.
Tue, Nov 20, 12:40 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-20, TCB-Team, Advanced-Search
thiemowmde moved T206323: Establish caret/arrow as jump mark for screen readers from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-11-20 board.
Tue, Nov 20, 12:35 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, Cite, WMDE-QWERTY-Sprint-2018-11-06, TCB-Team, Accessibility, German-Community-Wishlist, Need-volunteer
thiemowmde added a project to T206323: Establish caret/arrow as jump mark for screen readers: WMDE-QWERTY-Sprint-2018-11-20.
Tue, Nov 20, 12:35 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, Cite, WMDE-QWERTY-Sprint-2018-11-06, TCB-Team, Accessibility, German-Community-Wishlist, Need-volunteer
thiemowmde updated subscribers of T206323: Establish caret/arrow as jump mark for screen readers.

We briefly discussed this today and we think:

  • We definitely should not add aria-labels and keep the old "hidden spans" code the same time. This might lead to the situation that screen readers read the text twice, which is almost as bad as having no label.
  • I checked and there is barely any code in core that uses aria-labels: https://codesearch.wmflabs.org/search/?q=aria-label%5Cb. Some extensions use it much more extensively. I, personally, think we should follow and start using it. Following a standard is just "the right thing" to do, isn't it?
Tue, Nov 20, 10:38 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, Cite, WMDE-QWERTY-Sprint-2018-11-06, TCB-Team, Accessibility, German-Community-Wishlist, Need-volunteer

Mon, Nov 19

thiemowmde added a project to T206323: Establish caret/arrow as jump mark for screen readers: Cite.
Mon, Nov 19, 5:14 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, Cite, WMDE-QWERTY-Sprint-2018-11-06, TCB-Team, Accessibility, German-Community-Wishlist, Need-volunteer
thiemowmde added a project to T205270: Highlight the important jump mark letter by making it bold: Cite.
Mon, Nov 19, 5:14 PM · Cite, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-06, TCB-Team, German-Community-Wishlist, Need-volunteer
thiemowmde added a project to T205271: Make arrows/carets links whenever we know where the user came from: Cite.
Mon, Nov 19, 5:14 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Cite, Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-06, TCB-Team, German-Community-Wishlist, Need-volunteer
thiemowmde triaged T184912: Extra spaces are meaningful in sfn (differs from article text behavior) as Normal priority.

I had a brief look at this and found this is, technically, not a Cite but a MediaWiki core issue.

Mon, Nov 19, 5:13 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Need-volunteer, MediaWiki-Parser, Cite
thiemowmde added a comment to T209814: Change variant banner text for desktop enwiki #2.

Note that in the English language currency units are typically in front of the number (e.g. "€ 21.48"). This is different in the German language, where the unit must be after the number (e.g. "21,48 €").

Mon, Nov 19, 1:47 PM · WMDE-Fundraising-Funban-2018, WMDE-FUN-Team, WMDE-Fundraising-Tech
thiemowmde added a comment to T209790: Don't force users to pick "man/women", with no other choice.

That's sad. :-( But thanks a lot for replying so fast!

Mon, Nov 19, 1:42 PM · WMDE-FUN-Team, WMDE-Fundraising-Tech
Liuxinyu970226 awarded T208840: Monitor user reports about imaginary conflicts a Baby Tequila token.
Mon, Nov 19, 1:39 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-06, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T205271: Make arrows/carets links whenever we know where the user came from from Doing to Sprint Backlog on the WMDE-QWERTY-Sprint-2018-11-06 board.
Mon, Nov 19, 9:27 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Cite, Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-06, TCB-Team, German-Community-Wishlist, Need-volunteer
thiemowmde placed T205271: Make arrows/carets links whenever we know where the user came from up for grabs.
Mon, Nov 19, 9:27 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Cite, Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-06, TCB-Team, German-Community-Wishlist, Need-volunteer
thiemowmde claimed T205271: Make arrows/carets links whenever we know where the user came from.
Mon, Nov 19, 8:22 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Cite, Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-06, TCB-Team, German-Community-Wishlist, Need-volunteer