Page MenuHomePhabricator

thiemowmde (Thiemo Kreuz (WMDE))
Software Developer

Projects (11)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 11:45 AM (270 w, 3 d)
Availability
Available
IRC Nick
Thiemo_WMDE
LDAP User
Thiemo Kreuz (WMDE)
MediaWiki User
Thiemo Kreuz (WMDE) [ Global Accounts ]

Recent Activity

Fri, Dec 13

thiemowmde committed rEFILEEXPORT914939e7058c: Simplify hook definitions in extension.json (authored by thiemowmde).
Simplify hook definitions in extension.json
Fri, Dec 13, 3:55 PM
thiemowmde added a project to T240671: Retrospective and learnings from the Parser/Cite clone incident: WMDE-QWERTY-Sprint-2019-12-11.
Fri, Dec 13, 11:55 AM · WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Team, Book-Referencing, Cite
thiemowmde created T240671: Retrospective and learnings from the Parser/Cite clone incident.
Fri, Dec 13, 11:55 AM · WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Team, Book-Referencing, Cite

Thu, Dec 12

thiemowmde moved T220486: 2ColConf: Reset Edit warning should be clear on what it resets – just line edit or the whole text from Review to Demo on the WMDE-QWERTY-Sprint-2019-12-11 board.
Thu, Dec 12, 1:09 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), WMDE-QWERTY-Sprint-2019-12-11, TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde created T240548: References with no visible content are reported as empty now.
Thu, Dec 12, 10:42 AM · WMDE-QWERTY-Team, Regression, Cite, Book-Referencing
thiemowmde created T240543: Don't show reference previews that don't have visible content.
Thu, Dec 12, 10:04 AM · Patch-For-Review, WMDE-QWERTY-Team, Reference Previews

Wed, Dec 11

thiemowmde committed rECITf86b5073fd84: Add parser tests for reused extended <ref> before defined (authored by thiemowmde).
Add parser tests for reused extended <ref> before defined
Wed, Dec 11, 4:05 PM
thiemowmde added a comment to T240424: Decide whether to support "extends" in the references section.

The difference is that for the "general LDR case" the parser is able to decide on an index number the moment the first <ref name="…" /> appears somewhere in the text. It doesn't matter if the full reference appears before or after this point. The numbers are simply incremented from the top of the document to the bottom.

Wed, Dec 11, 3:37 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Sprint-2019-11-20, Book-Referencing, Design, WMDE-Design, TCB-Team, Cite
thiemowmde committed rECIT193b84001081: Add parser test for duplicate extended references (authored by thiemowmde).
Add parser test for duplicate extended references
Wed, Dec 11, 3:36 PM
thiemowmde committed rECIT01bcfa773da5: Rename CiteParserTagHooks::initialize to register (authored by thiemowmde).
Rename CiteParserTagHooks::initialize to register
Wed, Dec 11, 3:36 PM
thiemowmde committed rECITd0cb639e03bc: Minor improvements to the test coverage (authored by thiemowmde).
Minor improvements to the test coverage
Wed, Dec 11, 3:36 PM
thiemowmde created T240459: Merge sub-references when they have the same content.
Wed, Dec 11, 2:55 PM · Cite, Book-Referencing
thiemowmde reopened T151305: More edge case handling for "extends" parameter as "Open".
Wed, Dec 11, 12:34 PM · WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, WMDE-QWERTY-Sprint-2019-11-20, Book-Referencing, Design, WMDE-Design, TCB-Team, Cite
thiemowmde reopened T151305: More edge case handling for "extends" parameter, a subtask of T151301: Implement "extends"-attribute for ref-tag, as Open.
Wed, Dec 11, 12:34 PM · Book-Referencing, TCB-Team, Cite
thiemowmde reopened T151305: More edge case handling for "extends" parameter, a subtask of T236256: Collect use cases for interactions with refined <ref>s, as Open.
Wed, Dec 11, 12:34 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), WMDE-QWERTY-Sprint-2019-11-06, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2019-10-23, Book-Referencing
thiemowmde moved T151305: More edge case handling for "extends" parameter from Sprint Backlog to Demo on the WMDE-QWERTY-Sprint-2019-12-11 board.
Wed, Dec 11, 12:34 PM · WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, WMDE-QWERTY-Sprint-2019-11-20, Book-Referencing, Design, WMDE-Design, TCB-Team, Cite
thiemowmde set the point value for T240447: Write blog post about the big Cite rewrite to 5.
Wed, Dec 11, 12:27 PM · WMDE-QWERTY-Sprint-2019-12-11, Cite, Book-Referencing
thiemowmde created T240447: Write blog post about the big Cite rewrite.
Wed, Dec 11, 12:27 PM · WMDE-QWERTY-Sprint-2019-12-11, Cite, Book-Referencing
thiemowmde closed T151305: More edge case handling for "extends" parameter as Resolved.
Wed, Dec 11, 12:20 PM · WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, WMDE-QWERTY-Sprint-2019-11-20, Book-Referencing, Design, WMDE-Design, TCB-Team, Cite
thiemowmde closed T151305: More edge case handling for "extends" parameter, a subtask of T151301: Implement "extends"-attribute for ref-tag, as Resolved.
Wed, Dec 11, 12:20 PM · Book-Referencing, TCB-Team, Cite
thiemowmde closed T151305: More edge case handling for "extends" parameter, a subtask of T236256: Collect use cases for interactions with refined <ref>s, as Resolved.
Wed, Dec 11, 12:20 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), WMDE-QWERTY-Sprint-2019-11-06, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2019-10-23, Book-Referencing
thiemowmde committed rECIT83fc9921594a: Rename $type to $action in rollbackRef() (authored by thiemowmde).
Rename $type to $action in rollbackRef()
Wed, Dec 11, 11:50 AM
thiemowmde closed T186129: Set up Extension:Popups to support multiple preview types as Resolved.

Yes! We are currently in Beta, and plan to roll it out as a default feature within the next months.

Wed, Dec 11, 8:48 AM · Reference Previews, Readers-Web-Backlog (Tracking), German-Community-Wishlist, TCB-Team, Page-Previews
thiemowmde added a comment to T239989: Use category rather than page prop to mark Book Referencing pages.

I don't mind much at this point. We said we want to be able to find all pages utilizing extends="…" just in case something goes wrong. But we don't have an actual plan to use this information. So what would be the benefit of making it a category?

Wed, Dec 11, 8:38 AM · Book-Referencing, Cite
thiemowmde added a comment to T240345: {{#expr: expression }} breaks references in the whole article if expression throws an error.

For the sake of completeness: The undefined indexes in T240248 are essentially just a side-effect. This here was the actual user-facing issue that silently (after we got rid of the log spam) broke content pages, as described in the commit message.

Wed, Dec 11, 8:30 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), WMDE-QWERTY-Sprint-2019-11-20, Cite, ParserFunctions, MediaWiki-Parser
thiemowmde committed rECIT75016551e75c: Rename formatNumNoSeparators() to localizeDigits() (authored by thiemowmde).
Rename formatNumNoSeparators() to localizeDigits()
Wed, Dec 11, 8:29 AM
thiemowmde committed rECIT66069d9dcf7c: Use a guard clause in Cite::checkRefsNoReferences (authored by thiemowmde).
Use a guard clause in Cite::checkRefsNoReferences
Wed, Dec 11, 8:19 AM
thiemowmde added a comment to T151305: More edge case handling for "extends" parameter.

We need to split this off to a new, separate ticket. @awight, I guess you are most knowledgeable about this edge case at the moment. Can you create such a ticket so we can close this one here?

Wed, Dec 11, 8:18 AM · WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, WMDE-QWERTY-Sprint-2019-11-20, Book-Referencing, Design, WMDE-Design, TCB-Team, Cite
thiemowmde removed a project from T168719: On enwp, Cite error messages are not shown in User namespace if UI language is English (due to custom on wiki code): Cite.

I had a closer look and learned this is not a Cite bug. The fact errors are sometimes hidden is a decision entirely made by the English Wikipedia community, via customized messages and templates:

[[en:MediaWiki:Cite error]]
{{broken ref
[[en:Template:Broken ref]]
| other             = <span class="brokenref">
[[en:MediaWiki:Common.css]]
span.brokenref {
	display: none;
}

This issue does not occur in most namespaces, only in a few that fall under "other". That includes the user namespace.

Wed, Dec 11, 8:15 AM · Wikimedia-General-or-Unknown, I18n

Tue, Dec 10

thiemowmde committed rECITcad4d18458e5: Integration test to hit cloned Cite bug (authored by awight).
Integration test to hit cloned Cite bug
Tue, Dec 10, 6:32 PM
thiemowmde added a comment to T240248: "PHP Notice: Undefined index: key" and similar in Cite.php and ReferenceStack.php.

What we have done so far:

  • Some of the errors are from a parse API call, some aren't. It appears the way the parser is called is unrelated.
  • Some of the stack traces I have seen happen when an article uses {{#tag:references|…}}. This triggers the rollbackRefs() and $redoStack code, undoing and redoing some previous actions. We suspected this might mess with the ReferenceStack::$refs array in a way that's not clean.
  • There is a foreach loop in referencesFormat(), rendering the <ol> list of all individual <ref>s in a group. This code is using a copy of the values from ReferenceStack::$refs. Is it possible this code is using a conflicting copy and the original ReferenceStack::$refs the same time?
  • We suspected PHPs garbage collection to mess ReferenceStack::$refs up.
  • All the wiki pages I have seen so far contain the Cite error about a <ref> being declared twice, with conflicting content (it says "name … defined multiple times with different content"). It turns out this was indeed relevant, even if the issue might not be strictly limited to this code.
  • We suspected the ParserClearState and/or ParserCloned hook handlers being involved. Both intentionally mess with the Cite classes internal state.
  • Some array index errors happen in ReferenceStack::pushRef() in a place that looks like it is protected by an isset( $this->refs[$group][$name] ). With this check it should be impossible to run into array index errors, except the code between the isset() and the error is secretly modifying $this->refs. The only calls we can see are StripState::unstripBoth(), which looks trivial, and Parser::addTrackingCategory(), which does a suspicious Message call.
Tue, Dec 10, 3:47 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, Wikimedia-Incident, WMDE-QWERTY-Sprint-2019-11-20, Cite, Wikimedia-production-error
thiemowmde committed rECITdf1a45b84c95: Fix incomplete cloning of the Parser::$extCite instance (authored by thiemowmde).
Fix incomplete cloning of the Parser::$extCite instance
Tue, Dec 10, 3:34 PM
thiemowmde committed rECIT9c278d06c6dc: Fix incomplete cloning of the Parser::$extCite instance (authored by thiemowmde).
Fix incomplete cloning of the Parser::$extCite instance
Tue, Dec 10, 3:31 PM

Mon, Dec 9

thiemowmde committed rECIT90fd655e72ad: Fix config for some book referencing parser tests (authored by thiemowmde).
Fix config for some book referencing parser tests
Mon, Dec 9, 6:24 PM
thiemowmde committed rECITf92792f64a61: Fix bad localization of extended references numbers when reused (authored by thiemowmde).
Fix bad localization of extended references numbers when reused
Mon, Dec 9, 6:06 PM
thiemowmde added a comment to T239329: [Design] How should book references appear when reused?.

Yea, this is per-wiki configuration. For most wikis we get "a", "b", and so on. There is not much we need to do for these wikis. What we need to take care of is the behavior for wikis that don't have such a customization.

Mon, Dec 9, 3:12 PM · WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Sprint-2019-11-20, Design, WMDE-Design, Book-Referencing, Cite
thiemowmde committed rECIT7c1849d7b03d: Report both nested <ref> and <references> as an error (authored by thiemowmde).
Report both nested <ref> and <references> as an error
Mon, Dec 9, 2:29 PM
thiemowmde added a comment to T236605: Fatal when using FileImporter: "Call to a member function isOK() on boolean".

I would like to keep this open. Things to do:

  • Check the logs for the message "Failed to retrieve import result from".
  • Based on what we see we should decide on a new action, e.g. opening a new ticket.
  • Possibly remove the logging.
Mon, Dec 9, 11:59 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), WMDE-QWERTY-Sprint-2019-11-06, Move-Files-To-Commons, TCB-Team, Wikimedia-production-error
thiemowmde committed rECITc5fe49ff117f: Fail early on nested extends="…", if possible (authored by thiemowmde).
Fail early on nested extends="…", if possible
Mon, Dec 9, 10:13 AM
thiemowmde committed rECIT92312b4421b2: Add fail-safe default branch to switch-case (authored by thiemowmde).
Add fail-safe default branch to switch-case
Mon, Dec 9, 9:53 AM
thiemowmde committed rECITfc1865780d1b: Add missing dot to "1.2." list numbering for extended refs (authored by thiemowmde).
Add missing dot to "1.2." list numbering for extended refs
Mon, Dec 9, 9:51 AM
thiemowmde committed rECITd18c0871a8df: Fix broken reference list numbering in Firefox (authored by thiemowmde).
Fix broken reference list numbering in Firefox
Mon, Dec 9, 9:48 AM
thiemowmde moved T229307: Reference numbers wrong in Firefox when following a list from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-11-20 board.
Mon, Dec 9, 9:14 AM · WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Cite, WMDE-QWERTY-Sprint-2019-11-20, Upstream, VisualEditor, VisualEditor-MediaWiki-References, Browser-Support-Firefox
thiemowmde added projects to T229307: Reference numbers wrong in Firefox when following a list: WMDE-QWERTY-Sprint-2019-11-20, Cite.
Mon, Dec 9, 9:14 AM · WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Cite, WMDE-QWERTY-Sprint-2019-11-20, Upstream, VisualEditor, VisualEditor-MediaWiki-References, Browser-Support-Firefox

Sat, Dec 7

thiemowmde awarded T234907: RFC: Where to implement Desktop Improvements project a Love token.
Sat, Dec 7, 4:33 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, TechCom-RFC

Fri, Dec 6

thiemowmde added a comment to T238195: Check ApiQueryReferences compatibility with extended references.

For reference: We announced the removal of this API on 2019-12-05 via wikitext-l. We expect it to disappear in the builds https://www.mediawiki.org/wiki/MediaWiki_1.35/wmf.10 and later in MediaWiki 1.36.

Fri, Dec 6, 9:58 AM · WMDE-QWERTY-Sprint-2019-11-20, Editing-team, MediaWiki-API, WMDE-QWERTY-Team, Cite, Book-Referencing

Wed, Dec 4

thiemowmde committed rECITa7c4e14f4262: Remove obsolete ParserBeforeTidy hook handler (authored by thiemowmde).
Remove obsolete ParserBeforeTidy hook handler
Wed, Dec 4, 4:53 PM
thiemowmde added a comment to T239785: when hovering over cite extension, tooltip currently only shows page number .

At the moment, this ticket is only about the Reference Previews feature developed by WMDE. We plan to create a separate ticket for the gadget when it becomes more relevant, and we are able to suggest a fix for the community to apply on the gadget.

Wed, Dec 4, 4:03 PM · Reference Previews, Book-Referencing
thiemowmde committed rECIT0f146cd56e24: Fix possibly broken reference list counters in Firefox (authored by thiemowmde).
Fix possibly broken reference list counters in Firefox
Wed, Dec 4, 12:39 PM
thiemowmde moved T239787: CSS counters are messing up <references> list numbering in Firefox from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-11-20 board.
Wed, Dec 4, 11:14 AM · WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Book-Referencing, WMDE-QWERTY-Sprint-2019-11-20, Cite
thiemowmde added a project to T239787: CSS counters are messing up <references> list numbering in Firefox: Book-Referencing.

I did a bisect and the bug was not there before the patch https://gerrit.wikimedia.org/r/553111. That was the patch that introduced new CSS counters for sub-references.

Wed, Dec 4, 11:09 AM · WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Book-Referencing, WMDE-QWERTY-Sprint-2019-11-20, Cite
thiemowmde added a subtask for T230231: Allow (semi-)automated resolution of edit conflicts on discussion pages: T239792: Exploration: What data do we have to decide if a conflict can be resolved?.
Wed, Dec 4, 10:18 AM · Patch-For-Review, Two-Column-Edit-Conflict-Merge, Wikimania-Hackathon-2019, TCB-Team
thiemowmde added a parent task for T239792: Exploration: What data do we have to decide if a conflict can be resolved?: T230231: Allow (semi-)automated resolution of edit conflicts on discussion pages.
Wed, Dec 4, 10:18 AM · WMDE-QWERTY-Sprint-2019-12-11, TCB-Team, WMDE-QWERTY-Team, Two-Column-Edit-Conflict-Merge
thiemowmde created T239792: Exploration: What data do we have to decide if a conflict can be resolved?.
Wed, Dec 4, 10:18 AM · WMDE-QWERTY-Sprint-2019-12-11, TCB-Team, WMDE-QWERTY-Team, Two-Column-Edit-Conflict-Merge
thiemowmde closed T207161: Size of textarea not changeable as Resolved.

I think I just did that in a patch that's not linked to this ticket, because I found it annoying as well.

Wed, Dec 4, 10:07 AM · TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T237529: Create grafana panels for user conflicts, bucketed by edit count from Backlog to Before default on the Two-Column-Edit-Conflict-Merge board.
Wed, Dec 4, 9:57 AM · TCB-Team, WMDE-QWERTY-Sprint-2019-11-06, Two-Column-Edit-Conflict-Merge
thiemowmde closed T211922: German character insertion toolbar appears multiple times in conflict screen as Resolved.
Wed, Dec 4, 9:53 AM · patch-welcome, WMDE-QWERTY-X-Mas-Sprint-2018-12-18, Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde moved T217012: Parsing error on TwoColConflict preview note message from Before default to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.
Wed, Dec 4, 9:52 AM · WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), WMDE-QWERTY-Sprint-2019-11-20, WMDE-QWERTY-Team, Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde moved T234253: Signature syntax ~~~~ is not expanded in the conflict resolution UI from Backlog to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.
Wed, Dec 4, 9:52 AM · WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), WMDE-QWERTY-Sprint-2019-11-20, TCB-Team, good first task, WMDE-QWERTY-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T230231: Allow (semi-)automated resolution of edit conflicts on discussion pages from Backlog to Before default on the Two-Column-Edit-Conflict-Merge board.
Wed, Dec 4, 9:52 AM · Patch-For-Review, Two-Column-Edit-Conflict-Merge, Wikimania-Hackathon-2019, TCB-Team
thiemowmde moved T203738: Add tooltips from Tickets ready for pickup to Before default on the Two-Column-Edit-Conflict-Merge board.
Wed, Dec 4, 9:51 AM · TCB-Team, Two-Column-Edit-Conflict-Merge
thiemowmde moved T202060: Non-js editors should have flexible height set in PHP from Tickets ready for pickup to Before default on the Two-Column-Edit-Conflict-Merge board.
Wed, Dec 4, 9:51 AM · Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde moved T217012: Parsing error on TwoColConflict preview note message from Tickets ready for pickup to Before default on the Two-Column-Edit-Conflict-Merge board.
Wed, Dec 4, 9:51 AM · WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), WMDE-QWERTY-Sprint-2019-11-20, WMDE-QWERTY-Team, Two-Column-Edit-Conflict-Merge, TCB-Team
thiemowmde added a project to T239785: when hovering over cite extension, tooltip currently only shows page number : Reference Previews.
Wed, Dec 4, 9:41 AM · Reference Previews, Book-Referencing
thiemowmde committed rECIT54333c9bd60b: Stop formatting "1.2" as "1,2" in languages like German (authored by thiemowmde).
Stop formatting "1.2" as "1,2" in languages like German
Wed, Dec 4, 9:12 AM
thiemowmde created T239787: CSS counters are messing up <references> list numbering in Firefox.
Wed, Dec 4, 9:07 AM · WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Book-Referencing, WMDE-QWERTY-Sprint-2019-11-20, Cite
thiemowmde updated the task description for T239725: Mismatch between footnote numbering in article body and references section [1,1] vs. [1.1].
Wed, Dec 4, 8:30 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Cite, WMDE-QWERTY-Sprint-2019-11-20, Book-Referencing
thiemowmde moved T234253: Signature syntax ~~~~ is not expanded in the conflict resolution UI from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-11-20 board.
Wed, Dec 4, 8:29 AM · WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), WMDE-QWERTY-Sprint-2019-11-20, TCB-Team, good first task, WMDE-QWERTY-Team, Two-Column-Edit-Conflict-Merge
thiemowmde closed T238195: Check ApiQueryReferences compatibility with extended references as Resolved.
Wed, Dec 4, 8:27 AM · WMDE-QWERTY-Sprint-2019-11-20, Editing-team, MediaWiki-API, WMDE-QWERTY-Team, Cite, Book-Referencing
thiemowmde moved T238195: Check ApiQueryReferences compatibility with extended references from Review to Done on the WMDE-QWERTY-Sprint-2019-11-20 board.
Wed, Dec 4, 8:27 AM · WMDE-QWERTY-Sprint-2019-11-20, Editing-team, MediaWiki-API, WMDE-QWERTY-Team, Cite, Book-Referencing
thiemowmde moved T239725: Mismatch between footnote numbering in article body and references section [1,1] vs. [1.1] from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-11-20 board.
Wed, Dec 4, 8:27 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Cite, WMDE-QWERTY-Sprint-2019-11-20, Book-Referencing
thiemowmde added projects to T239725: Mismatch between footnote numbering in article body and references section [1,1] vs. [1.1]: WMDE-QWERTY-Sprint-2019-11-20, Cite.
Wed, Dec 4, 8:26 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Cite, WMDE-QWERTY-Sprint-2019-11-20, Book-Referencing

Tue, Dec 3

thiemowmde committed rECIT0f2c56e0ac70: Fix top-level reference numbering (authored by awight).
Fix top-level reference numbering
Tue, Dec 3, 11:56 AM
thiemowmde committed rECITb14586998060: Inline and streamline code in the formatter classes (authored by thiemowmde).
Inline and streamline code in the formatter classes
Tue, Dec 3, 10:43 AM

Mon, Dec 2

thiemowmde committed rECIT2cb7e5d438e2: Add test cases for duplicate <references> with same group (authored by thiemowmde).
Add test cases for duplicate <references> with same group
Mon, Dec 2, 3:26 PM
thiemowmde added a comment to T220719: Standardize return type hint spacing.

I evaluated my arguments from the mw.org talk page and still think the character sequence … ) : … is not automatically better. I still suggest to follow PSR and enforce … ): ….

Mon, Dec 2, 11:32 AM · MediaWiki-Documentation, MediaWiki-Codesniffer

Sun, Dec 1

thiemowmde committed rECITffedf86a19ef: Clean up text and name conditionals (authored by awight).
Clean up text and name conditionals
Sun, Dec 1, 10:05 AM

Fri, Nov 29

thiemowmde committed rECIT22627f074dae: Make the normalizeKey() method private (authored by thiemowmde).
Make the normalizeKey() method private
Fri, Nov 29, 6:16 PM
thiemowmde committed rECITf8affe8eee07: Remove redundant variable names from @var docs (authored by thiemowmde).
Remove redundant variable names from @var docs
Fri, Nov 29, 2:52 PM
thiemowmde added a comment to T116561: Position of boolean operators inside an if condition.

Personally, I don't really like the idea of having a strict rule for this. Not only because it's a matter of taste. From my experience the code is sometimes more readable when all boolean operators are at the beginning of the line, and sometimes when they are at the end of the line. In rare edge-cases this might even vary within a single file, sometimes even within a single if.

Fri, Nov 29, 1:22 PM · Patch-For-Review, MediaWiki-Codesniffer
thiemowmde added a comment to T170526: Adjust vertical scale for a better resolution with big changes.

Personally, I don't think such an upper bound should be variable. The idea really is to have it fixed.

Fri, Nov 29, 1:16 PM · Wikimedia-Hackathon-2019, Patch-For-Review, Season of RevisionSlider, WMDE volunteer workboard, Revision-Slider, TCB-Team
thiemowmde committed rECITa176e22097db: Remove ApiQueryReferences support (authored by awight).
Remove ApiQueryReferences support
Fri, Nov 29, 11:33 AM

Thu, Nov 28

thiemowmde updated subscribers of T229939: Use wikidata entity selector in OOUI input field.

That looks right.

Thu, Nov 28, 11:05 AM · Wikidata, OOUI, Math
thiemowmde added a comment to T236339: Code review Mitmachen-Tool.

Today, we got a ping via https://github.com/wmde/mitmachen/issues/49#issuecomment-559351592 saying "Please check, it is fixed". I did.

Thu, Nov 28, 9:29 AM · WMDE-QWERTY-Sprint-2019-11-06, Mitmachen, User-thiemowmde, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2019-10-23
thiemowmde added a comment to T229939: Use wikidata entity selector in OOUI input field.

I checked, and the module "jquery.wikibase.entityselector" still exists. But it might be that it is not loaded by default any more. You need to request it, either via "dependencies" in the definition of your ResourceLoader module, or via $parserOutput->addModules( … ) in your PHP code, or via mw.loader.using( … ) in your JavaScript code. Without knowing much about your code, I assume the last option would be the best.

Thu, Nov 28, 8:01 AM · Wikidata, OOUI, Math

Wed, Nov 27

thiemowmde committed rECIT22a0350d84f4: [Refactor] Pass validation error with StatusValue (authored by awight).
[Refactor] Pass validation error with StatusValue
Wed, Nov 27, 9:23 PM
thiemowmde committed rECIT99ee9e443bea: Rename $valid to $status for clarity (authored by thiemowmde).
Rename $valid to $status for clarity
Wed, Nov 27, 9:23 PM
thiemowmde committed rECIT249982e353f3: Rewrite loop in ReferenceStack (authored by awight).
Rewrite loop in ReferenceStack
Wed, Nov 27, 8:51 PM
thiemowmde committed rECITf00b21943bfa: Minor fixups to the ReferenceStack class (authored by thiemowmde).
Minor fixups to the ReferenceStack class
Wed, Nov 27, 8:50 PM
thiemowmde committed rECITb30340ba2b05: Clean up pushRef (authored by awight).
Clean up pushRef
Wed, Nov 27, 8:47 PM
thiemowmde committed rECIT38a38ae472a5: Add smoke tests for previously uncovered combinations (authored by thiemowmde).
Add smoke tests for previously uncovered combinations
Wed, Nov 27, 8:47 PM
thiemowmde committed rECIT0013943a4a5a: Rewrite argument parsing and use for both <ref> & <references> (authored by thiemowmde).
Rewrite argument parsing and use for both <ref> & <references>
Wed, Nov 27, 1:28 PM
thiemowmde committed rECIT04f784bc024d: Remove non-existing property from ReferenceStack (authored by thiemowmde).
Remove non-existing property from ReferenceStack
Wed, Nov 27, 12:26 PM
thiemowmde committed rECITf5b9360467a3: Add test to cover Cite::listToText() (authored by thiemowmde).
Add test to cover Cite::listToText()
Wed, Nov 27, 11:47 AM
thiemowmde committed rECIT2ffcae04253b: Add seperate unit test cases for Cite::testValidateRef() (authored by thiemowmde).
Add seperate unit test cases for Cite::testValidateRef()
Wed, Nov 27, 11:47 AM
thiemowmde committed rECIT9f1521a77363: Rename ambiguous tests to …UnitTest (authored by thiemowmde).
Rename ambiguous tests to …UnitTest
Wed, Nov 27, 10:52 AM
thiemowmde committed rECITa6a16f070346: Update and increase ReferenceStack test coverage (authored by thiemowmde).
Update and increase ReferenceStack test coverage
Wed, Nov 27, 10:25 AM

Tue, Nov 26

thiemowmde added a comment to T170526: Adjust vertical scale for a better resolution with big changes.

Gerrit also shows bars to visualize the size of a change. This feature is quite similar to what Revision-Slider does.

Tue, Nov 26, 1:56 PM · Wikimedia-Hackathon-2019, Patch-For-Review, Season of RevisionSlider, WMDE volunteer workboard, Revision-Slider, TCB-Team
thiemowmde created T239230: Should links to the same site open in new tabs?.
Tue, Nov 26, 1:13 PM · WMDE-Design, Design, Reference Previews
thiemowmde added a parent task for T236902: Spike: Check book ref. compatibility with the REST API endpoint: T239228: Make Popups and MobileFrontend compatible with BookReferencing.
Tue, Nov 26, 12:45 PM · Product-Infrastructure-Team-Backlog, Page Content Service, WMDE-QWERTY-Team, Book-Referencing