User Details
- User Since
- Oct 8 2014, 11:45 AM (262 w, 2 d)
- Availability
- Available
- IRC Nick
- Thiemo_WMDE
- LDAP User
- Thiemo Kreuz (WMDE)
- MediaWiki User
- Thiemo Kreuz (WMDE) [ Global Accounts ]
Thu, Oct 17
Thanks, @ovasileva! Let's go with "Previews" for now. This is really just the Special:Version page and nothing else. We can change it again any time if needed.
This function was moved around multiple times now. I'm not sure since when $.escapeRE existed, but I remember when it stopped working without a hint I was able to notice in time. All user scripts I wrote broke, leaving all my users puzzled. Just a few months later the same scripts broke again because the function stopped being available without requesting it first. That was the point I got sick of running after a single line (!) of code and copy pasted it into my code.
Wed, Oct 16
Outcome of today's story time:
- We will create a spike ticket for properly detecting the exact type of edit. E.g. we are not sure how to detect "both edits tried to add text at the exact same position" from what wikidiff2 gives us.
- The mock screenshot displays a little image and a preview. We suggest to merge this: No image, just the preview text, but the two conflicting paragraphs are highlighted (probably in color). Pinging @Hanna_Petruschat_WMDE to make a call on this. This also needs a tech spike: How to color paragraphs in a diff?
- Tech spike: Should this feature be a separate extension?
@Andrew-WMDE, it would be pretty critical if we (the WMDE-QWERTY-Team) could merge the patch https://gerrit.wikimedia.org/r/542117 (along with it's requirements) this week, latest next Monday (21 October). We need it to be in the wmf.3 branch cut that will happen on 22 October, see https://www.mediawiki.org/wiki/MediaWiki_1.35/Roadmap.
Fri, Oct 11
@Jdlrobson, for your information, we are doing this change now. The name we propose is "Preview Popups". Do you think this is ok? Or should it be "Popups" only?
Thu, Oct 10
Wed, Oct 9
We just realized this is not only about tables, but:
- Not only tables can be collapsed, but other elements as well.
- It's also about the sorting feature.
Following the arguments given by our PM in T224674#5450274 we decided to not do an extra deployment for the two no and nn wikis. Instead, Reference Previews will become a Beta-Feature within the next weeks via T235083: Full Beta for the ReferencePreviews feature.
We had a quick look and can confirm this is indeed a "lego message", made from https://de.wikipedia.org/wiki/MediaWiki:Advancedsearch-field-preview-sort and https://de.wikipedia.org/wiki/MediaWiki:Advancedsearch-sort-preview-relevance.
The example diffs in the comment T146781#3806765 are all because of the same edge case situation. While it would indeed be possible to improve the wikidiff2 code further to make such diffs even better, this is out of the scope of this particular ticket. It's also not a consequence of the code changes being done here. These diffs have been disconnected before. The code introduced here added the arrows and inline diffs to these paragraphs, which is an improvement already. Further improvements on top of that should be tracked in another ticket.
Fri, Oct 4
https://gerrit.wikimedia.org/r/540425 is the only patch open here. It seems it fails because it uses a Webdriverio version 5 feature, but we aren't on version 5 yet. @zeljkofilipin, is there a backwards-compatible method we can use instead of scrollIntoView? Or are we able to update to version 5 within the next days?
If I'm not mistaken, two patches are still open here. They depend on each other, so it's conceptually only one patch.
Wed, Oct 2
It's 2 years now that a fix for this bug exists. The patch doesn't even conflict. Sorry, but I refuse to be assigned to this. There is nothing I can do.
Closing, not because what this task asks for shouldn't be done, but because having this ticket does not help actually making it happen. It's old, contains barely any information, and is not on any board that is relevant for the team(s) currently working on the codebase.