Page MenuHomePhabricator

tstarling (Tim Starling)
UserAdministrator

Projects (22)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 8:27 PM (509 w, 6 d)
Roles
Administrator
Availability
Available
LDAP User
Tim Starling
MediaWiki User
Tim Starling (WMF) [ Global Accounts ]

Recent Activity

Today

tstarling added a comment to T370835: Wishlist Test: Not displaying words in quotes on the Wishlist Dashboard.

Bot updated. Template diff after editing "last updated" vs "created"

Wed, Jul 24, 12:16 AM · Community-Tech (Darwin's Fox (July 15-26, 2024))

Yesterday

tstarling updated subscribers of T370610: Toolforge build service: Can't process an image larger than 128 Mpx using ImageMagick.

@aborrero tells me that the Debian maintainer is willing to remove the resource limits from policy.xml in the Debian package. That would be great to see, and will eventually help us to avoid production issues like T344233. It will also carry weight with Heroku if we decide to open a pull request there.

Tue, Jul 23, 1:26 AM · Patch-For-Review, Toolforge

Mon, Jul 22

tstarling created T370610: Toolforge build service: Can't process an image larger than 128 Mpx using ImageMagick.
Mon, Jul 22, 3:49 AM · Patch-For-Review, Toolforge

Wed, Jul 17

tstarling added a comment to T370230: Migrate translations to Community Requests.

This might be true, but the main issue is that none of the fallbacks are applied, isn't it?

Wed, Jul 17, 10:50 AM · Patch-For-Review, Community-Tech (Darwin's Fox (July 15-26, 2024)), Community Wishlist (Translations)
tstarling updated subscribers of T370230: Migrate translations to Community Requests.

Fallback to zh is not ideal given the mutual intelligibility gap between Simplified and Traditional Chinese.

Wed, Jul 17, 12:20 AM · Patch-For-Review, Community-Tech (Darwin's Fox (July 15-26, 2024)), Community Wishlist (Translations)

Tue, Jul 16

Tgr awarded T157658: Factor out a backend from EditPage a Love token.
Tue, Jul 16, 8:34 PM · MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), Patch-For-Review, MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (External Code Reviews), Platform Engineering Roadmap Decision Making, User-DannyS712, MediaWiki-Page-editing
tstarling added a comment to T369623: Projects being added twice by intake form.

I can reproduce this with breakpoints set. onUpdateProject() is called first from the cdx-card @click handler, and then second from the cdx-checkbox @update:model-value handler.

Tue, Jul 16, 12:58 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), Community Wishlist (Intake form)

Mon, Jul 15

tstarling updated the task description for T360934: Deploy intake form to Meta.
Mon, Jul 15, 12:02 PM · Community-Tech (Darwin's Fox (July 15-26, 2024)), Epic, Community Wishlist (Intake form)
tstarling added a comment to T369554: Change the "date" to "last updated" vs "created".

@tstarling Please review issue below, thanks!
The title "Lorem ipsum" is below the "Last updated" title in the table, even though "Lorem ipsum" has a more recent date

Mon, Jul 15, 11:58 AM · Community-Tech (Darwin's Fox (July 15-26, 2024))
tstarling updated the task description for T360934: Deploy intake form to Meta.
Mon, Jul 15, 9:48 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), Epic, Community Wishlist (Intake form)
tstarling updated the task description for T360934: Deploy intake form to Meta.
Mon, Jul 15, 9:45 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), Epic, Community Wishlist (Intake form)

Fri, Jul 12

tstarling added a comment to T223772: Extend #time parser function to display time in format specific to each language.

{{int:lang}} is a hack, and requires wikis creating some MediaWiki messages. See T4085: Add a {{USERLANGUAGE}} magic word

Fri, Jul 12, 1:31 AM · MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), Community-Tech (Darwin's Fox (July 15-26, 2024)), Patch-For-Review, I18n, ParserFunctions
tstarling added a comment to T223772: Extend #time parser function to display time in format specific to each language.

#time allows the user to specify an arbitrary language code, so I may as well extend that feature to the new function. The target keyword is not really necessary, since omitting the parameter would have the same effect. I can split the user keyword out to a separate commit.

Fri, Jul 12, 12:04 AM · MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), Community-Tech (Darwin's Fox (July 15-26, 2024)), Patch-For-Review, I18n, ParserFunctions

Thu, Jul 11

tstarling claimed T223772: Extend #time parser function to display time in format specific to each language.

Goals:

  • Reasonably compact
  • Encourage the use of the page language
  • Give access to the user language, for the convenience of Commons where user and content language are conflated
  • Give access to date, time and "both" formats
Thu, Jul 11, 5:51 AM · MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), Community-Tech (Darwin's Fox (July 15-26, 2024)), Patch-For-Review, I18n, ParserFunctions
tstarling created T369785: Incorrect date formatting in wish pages and wishlist indexes.
Thu, Jul 11, 5:07 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), Community Wishlist, I18n
tstarling moved T369554: Change the "date" to "last updated" vs "created" from Ready for dev to Feedback and review on the Community-Tech (July 1-12 2024 (Corsac Fox)) board.
Thu, Jul 11, 4:37 AM · Community-Tech (Darwin's Fox (July 15-26, 2024))
tstarling moved T368349: Translate tags are shown in wish table from In development to QA on the Community-Tech (July 1-12 2024 (Corsac Fox)) board.
Thu, Jul 11, 4:10 AM · Community-Tech (July 1-12 2024 (Corsac Fox)), Community Wishlist (Intake form)

Wed, Jul 10

tstarling added a comment to T368358: Add abuse filters to wishlist-test wiki.

I installed AbuseFilter: https://wishlist-test.toolforge.org/wiki/Special:AbuseFilter

Wed, Jul 10, 11:30 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), Community Wishlist (Intake form)
tstarling claimed T369554: Change the "date" to "last updated" vs "created".
Wed, Jul 10, 4:38 AM · Community-Tech (Darwin's Fox (July 15-26, 2024))

Tue, Jul 9

tstarling added a comment to T235397: Add API module to "mark a page for translation".

What about creating a first version that doesn’t allow overriding any defaults (no changes to fuzzy units, no changes to priority languages, no toggling of page title translation, no toggling of translation-aware transclusion, no syntax version updates)? If I understand correctly, neither Community Tech nor @DannyS712’s bot needs the ability to override anything.

Tue, Jul 9, 7:40 AM · Patch-For-Review, Community-Tech (Darwin's Fox (July 15-26, 2024)), MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Action-API, User-DannyS712, MediaWiki-extensions-Translate

Mon, Jul 8

tstarling added a comment to T235397: Add API module to "mark a page for translation".

We need it for the community wishlist. The idea is to mark wishes for translation in a semi-automated way, with a gadget that runs as a translation admin (T365558). I don't think we need to override the defaults for the nofuzzy checkboxes.

Mon, Jul 8, 5:56 AM · Patch-For-Review, Community-Tech (Darwin's Fox (July 15-26, 2024)), MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Action-API, User-DannyS712, MediaWiki-extensions-Translate
tstarling added a comment to T235397: Add API module to "mark a page for translation".

Or there can be a nofuzzyunits parameter and a fuzzyunits parameter, the latter subtracting from the default set.

Mon, Jul 8, 5:13 AM · Patch-For-Review, Community-Tech (Darwin's Fox (July 15-26, 2024)), MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Action-API, User-DannyS712, MediaWiki-extensions-Translate
tstarling added a comment to T235397: Add API module to "mark a page for translation".

For API usability, I think an API request with action=markfortranslation & title=Foo should be equivalent to loading the form for that title and submitting it without changing any defaults. There's a couple of things in TranslatablePageMarker that make this inconvenient, like its need to overwrite the priority languages unconditionally. But it can be done.

Mon, Jul 8, 5:02 AM · Patch-For-Review, Community-Tech (Darwin's Fox (July 15-26, 2024)), MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Action-API, User-DannyS712, MediaWiki-extensions-Translate
tstarling claimed T235397: Add API module to "mark a page for translation".
Mon, Jul 8, 4:03 AM · Patch-For-Review, Community-Tech (Darwin's Fox (July 15-26, 2024)), MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Action-API, User-DannyS712, MediaWiki-extensions-Translate

Fri, Jul 5

tstarling added a comment to T235397: Add API module to "mark a page for translation".

The POST branch of PageTranslationSpecialPage::onActionMark() seems simple enough, but I assume a query API similar to showPage() will also be needed, and that looks a bit bigger. Unless it's enough to expect the client to guess the unit IDs for $noFuzzyUnits.

Fri, Jul 5, 5:56 AM · Patch-For-Review, Community-Tech (Darwin's Fox (July 15-26, 2024)), MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Action-API, User-DannyS712, MediaWiki-extensions-Translate

Mon, Jul 1

tstarling closed T355034: Deploy new block_target schema as Resolved.
Mon, Jul 1, 5:59 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Multiblocks, MediaWiki-Blocks
tstarling closed T355034: Deploy new block_target schema, a subtask of T346293: ipblocks schema redesign for multiblocks, as Resolved.
Mon, Jul 1, 5:58 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Multiblocks, Community-Tech (CommTech-Kanban), MediaWiki-Blocks
tstarling closed T355034: Deploy new block_target schema, a subtask of T361945: Toolforge view for blocks is very slow, as Resolved.
Mon, Jul 1, 5:57 AM · cloud-services-team, Data-Services

Jun 24 2024

tstarling closed T365075: Lua parameter keys which are integers should be stringified if they have a magnitude > 2^53 - 1, not 2^53 as Declined.
Jun 24 2024, 12:48 AM · Patch-For-Review, Scribunto

Jun 20 2024

tstarling created T368006: htmlCacheUpdate missed for new template pages due to backlink partition cache.
Jun 20 2024, 1:24 AM · MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), MediaWiki-Page-derived-data

Jun 18 2024

tstarling moved T362133: Clean up block_target migration code from Ready for dev to Feedback and review on the Community-Tech (June 17-28 2024 Bat-Eared Fox) board.
Jun 18 2024, 12:30 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), MW-1.43-notes (1.43.0-wmf.12; 2024-07-02), Multiblocks, MediaWiki-Blocks

Jun 12 2024

tstarling added a comment to T363228: WMF staff should be able to update the status of a wish.

There's no permissions in the gadget implementation. You can't restrict who gets to change a status.

Jun 12 2024, 12:20 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), Community Wishlist (Wish page)
tstarling added a comment to T361067: Rewrite Wishlist Survey bot.

Random tech debt thing -- we have a few terms for whatever the subpage name for a wish/focus area is. Is slug a good name and if so maybe the db and backend things could be renamed? Or vice versa :)

Jun 12 2024, 12:17 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), Patch-For-Review, Community Wishlist

Jun 11 2024

tstarling moved T323076: GlobalPreferences blocks API changes to preference table (mediawiki.user saveOption function doesn't work) from In development to Feedback and review on the Community-Tech (June 3-14 2024 Arctic Fox) board.
Jun 11 2024, 11:27 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), MW-Interfaces-Team, MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), MediaWiki-extensions-GlobalPreferences
tstarling added a comment to T77151: Full Zoom Feature in Media Viewer.

@JScherer-WMF asked on Slack for image size statistics.

Jun 11 2024, 2:37 AM · Design, Wikimedia-Design, Multimedia, MediaViewer

Jun 8 2024

tstarling added a comment to T366824: Add a changelog and apply a custom version number to our patched bundled Lua binaries.

I wish I understood how coroutines were disabled, but searching the Scribunto codebase found only a couple of references to the word coroutine in the tests. Fiddling ignorantly with those tests didn't seem to provide any meaningful change.

Jun 8 2024, 7:10 AM · SecTeam-Processed, Scribunto, Security, Security-Team

Jun 6 2024

tstarling added a comment to T138933: Explore moving the Panoviewer gadget/Toolforge tool into production.

@tstarling I don't understand the gerritbot comment above. Would you be able to give an update on where this task is at?

Jun 6 2024, 1:58 AM · Patch-For-Review, Thumbor, MediaViewer, Tools, Platform Team Legacy (Watching / External), Services (watching), Multimedia

Jun 4 2024

tstarling added a comment to T363630: Score audio cannot be played if the page has other embedded media.

TMH should set its own class attributes on the server side and avoid mangling unrelated content. Per my commit message comments on cf8a4f2133cb, TMH is too broken to use with Score. Requiring every other extension to set a fake TMH attribute to trick TMH into not breaking it doesn't seem like a good solution.

Jun 4 2024, 12:24 AM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), VideoJS player, MediaWiki-extensions-Score

Jun 3 2024

tstarling updated the task description for T366433: CentralAuth tests broken unless you run them inside Quibble.
Jun 3 2024, 12:37 AM · MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
tstarling created T366433: CentralAuth tests broken unless you run them inside Quibble.
Jun 3 2024, 12:33 AM · MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth

Jun 2 2024

Don-vip awarded T357251: [build-service,apt-buildpack] Add local Ubuntu mirror or package cache a Hungry Hippo token.
Jun 2 2024, 12:43 PM · Toolforge

May 31 2024

tstarling updated subscribers of T323076: GlobalPreferences blocks API changes to preference table (mediawiki.user saveOption function doesn't work).

I just discovered T224245, which is a different approach to the same problem, already implemented.

May 31 2024, 4:47 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), MW-Interfaces-Team, MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), MediaWiki-extensions-GlobalPreferences
tstarling added a comment to T201340: Local notification settings stuck at latest global preference.

Do we want to do the row cleanup as part of this ticket? If not, let's get another ticket in.

May 31 2024, 2:29 AM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Community-Tech-Sprint, MediaWiki-Core-Preferences, Community-Tech, MediaWiki-extensions-GlobalPreferences

May 29 2024

tstarling moved T355034: Deploy new block_target schema from In Development 💻 to Ready 🎬 on the Community-Tech (CommTech-Kanban) board.
May 29 2024, 10:20 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Multiblocks, MediaWiki-Blocks
tstarling moved T362133: Clean up block_target migration code from Review/Feedback 💬 to Ready 🎬 on the Community-Tech (CommTech-Kanban) board.
May 29 2024, 10:19 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), MW-1.43-notes (1.43.0-wmf.12; 2024-07-02), Multiblocks, MediaWiki-Blocks
tstarling added a comment to T362133: Clean up block_target migration code.

Some usages of $wgBlockTargetMigrationStage remain in WMF-maintained extensions.

May 29 2024, 10:19 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), MW-1.43-notes (1.43.0-wmf.12; 2024-07-02), Multiblocks, MediaWiki-Blocks
tstarling closed T51504: ipb_range_start and ipb_range_end should be blank for single-IP blocks as Resolved.
May 29 2024, 10:18 AM · Patch-For-Review, MediaWiki-Blocks, Performance Issue
tstarling closed T51504: ipb_range_start and ipb_range_end should be blank for single-IP blocks, a subtask of T346293: ipblocks schema redesign for multiblocks, as Resolved.
May 29 2024, 10:18 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Multiblocks, Community-Tech (CommTech-Kanban), MediaWiki-Blocks
tstarling moved T346293: ipblocks schema redesign for multiblocks from In Development 💻 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.
May 29 2024, 10:09 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Multiblocks, Community-Tech (CommTech-Kanban), MediaWiki-Blocks
tstarling moved T361067: Rewrite Wishlist Survey bot from In Development 💻 to Ready 🎬 on the Community-Tech (CommTech-Kanban) board.
May 29 2024, 10:09 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), Patch-For-Review, Community Wishlist

May 28 2024

tstarling added a comment to T209892: SecurePoll is not compatible with GPG 2.1+.

@tstarling @dom_walden Is it possible to test an election on the mw-debug deployment of MW-on-K8s using XWD, or are we missing some configuration to try this in production?

May 28 2024, 3:21 AM · MW-1.43-notes (1.43.0-wmf.7; 2024-05-28), Community-Tech (CommTech-Kanban), MW-on-K8s, MediaWiki-extensions-SecurePoll

May 24 2024

tstarling claimed T323076: GlobalPreferences blocks API changes to preference table (mediawiki.user saveOption function doesn't work).
May 24 2024, 6:29 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), MW-Interfaces-Team, MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), MediaWiki-extensions-GlobalPreferences
tstarling moved T323076: GlobalPreferences blocks API changes to preference table (mediawiki.user saveOption function doesn't work) from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.
May 24 2024, 6:29 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), MW-Interfaces-Team, MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), MediaWiki-extensions-GlobalPreferences
tstarling added a comment to T352499: Use extension registration (extension.json/skin.json) for preloaded i18n messages.

FWIW We need some more background on why these messages were selected in the first case.

May 24 2024, 2:50 AM · MediaWiki-Engineering, Patch-For-Review, Web-Team-Backlog (Needs Prioritization (Tech)), I18n, MediaWiki-Internationalization, Desktop Improvements (Vector 2022)
tstarling added a comment to T365075: Lua parameter keys which are integers should be stringified if they have a magnitude > 2^53 - 1, not 2^53.

It seems to me that it should be possible to represent all powers of two up to the limit of the exponent, since the mantissa is just 1 for those numbers. So 2^53+1 is the lowest positive integer which needs to be rounded in order to fit in a double.

May 24 2024, 2:12 AM · Patch-For-Review, Scribunto

May 16 2024

tstarling added a comment to T361067: Rewrite Wishlist Survey bot.

I suggest renaming bot.js to update-indexes.js.

May 16 2024, 5:28 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), Patch-For-Review, Community Wishlist

May 14 2024

Rexogamer awarded T214998: RFC: Remove .m. subdomain, serve mobile and desktop variants through the same URL a Love token.
May 14 2024, 10:04 AM · Web-Team-Backlog, Traffic-Icebox, MobileFrontend (Tracking), TechCom-RFC, SRE
Dreamy_Jazz awarded T214998: RFC: Remove .m. subdomain, serve mobile and desktop variants through the same URL a Like token.
May 14 2024, 8:34 AM · Web-Team-Backlog, Traffic-Icebox, MobileFrontend (Tracking), TechCom-RFC, SRE
tstarling added a comment to T361067: Rewrite Wishlist Survey bot.

Proposed implementation plan:

  • Use sqlite3 for data persistence, using the filesystem to avoid the need for an SSH tunnel to a Cloud Services database (or local MySQL-like dependency)
May 14 2024, 5:51 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), Patch-For-Review, Community Wishlist
tstarling closed T364610: CI Blocker: MergeUserTest::testBasicMerge: Error 1054: Unknown column 'bt_address' in 'field list' as Resolved.

This was fixed.

May 14 2024, 5:23 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), Patch-For-Review, MediaWiki-extensions-UserMerge, ci-test-error
tstarling closed T364610: CI Blocker: MergeUserTest::testBasicMerge: Error 1054: Unknown column 'bt_address' in 'field list', a subtask of T346293: ipblocks schema redesign for multiblocks, as Resolved.
May 14 2024, 5:21 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Multiblocks, Community-Tech (CommTech-Kanban), MediaWiki-Blocks
tstarling updated subscribers of T364644: Set $wgEnableAsyncUploads = true on all wikis.

@aaron disabled it on 2013-03-14 and re-enabled it for Commons only on 2013-03-29. But there was no UI for it on wikis other than Commons, and that remains the case.

May 14 2024, 5:20 AM · Wikimedia-Site-requests
tstarling added a comment to T354949: Tool:Panoviewer - Grid Engine web service cannot be reached..

Hallo,

https://panoviewer.toolforge.org/ does not work. Error 403 "Forbidden". Can somebody fixed it maybe?

May 14 2024, 3:23 AM · Tools
tstarling closed T363752: CodeMirror shouldn't load in the 2017 editor on RTL pages as Resolved.

Confirmed fix on ar.wikipedia.org

May 14 2024, 12:38 AM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), VisualEditor, Community-Tech (CommTech-Kanban), VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror

May 10 2024

tstarling added a comment to T346293: ipblocks schema redesign for multiblocks.

Looking here: https://gerrit.wikimedia.org/g/mediawiki/core/+/bc11d8072a47fdc2f9d3a60f78c09716948b626e/includes/block/DatabaseBlockStore.php#336 tables does not list block_target, but it refers to bt_* fields from that table.

The query definition a few lines below: https://gerrit.wikimedia.org/g/mediawiki/core/+/bc11d8072a47fdc2f9d3a60f78c09716948b626e/includes/block/DatabaseBlockStore.php#367 does list block_target when using fields from that table.

I'm not sure if that's a mistake, but it looks suspicious.

May 10 2024, 11:48 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Multiblocks, Community-Tech (CommTech-Kanban), MediaWiki-Blocks
tstarling added a comment to T364221: PanoProjector -- equirectangular to rectilinear reprojection in C++.

Temporary repo with unreviewed code: https://github.com/tstarling/pano-projector

May 10 2024, 12:37 AM · Community-Tech

May 9 2024

DAlangi_WMF awarded T240307: Hook container with strong types and DI a Love token.
May 9 2024, 9:37 PM · Platform Team Workboards (Epics), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), MW-1.33-notes, MW-1.31-release-notes, MW-1.34-notes, Core Platform Team Initiatives (New Hook System), MediaWiki-Core-Hooks, Dependency injection, TechCom-RFC (TechCom-RFC-Closed), User-Daniel, Platform Engineering

May 7 2024

real68er awarded T33366: File description page thumbnail click versus EXIF rotation, mustRender() a Love token.
May 7 2024, 9:37 AM · Commons, Multimedia, MediaWiki-File-management
tstarling added a comment to T363891: Panoramic images tiling component.

Panellum falls back to a low resolution full size image if the results are not yet ready. The toolforge tool also renders on the fly i believe and it will 'fill in' results as they arrive based on a JS poll.

There's no Pannellum support for that, it's only in the panoviewer tool.

May 7 2024, 12:35 AM · Thumbor, MediaViewer

May 4 2024

tstarling added a parent task for T364221: PanoProjector -- equirectangular to rectilinear reprojection in C++: T363891: Panoramic images tiling component.
May 4 2024, 12:14 PM · Community-Tech
tstarling added a subtask for T363891: Panoramic images tiling component: T364221: PanoProjector -- equirectangular to rectilinear reprojection in C++.
May 4 2024, 12:14 PM · Thumbor, MediaViewer
tstarling created T364221: PanoProjector -- equirectangular to rectilinear reprojection in C++.
May 4 2024, 12:13 PM · Community-Tech

May 3 2024

tstarling added a comment to T363891: Panoramic images tiling component.

I did a rough prototype of this in C++, and I got it down to 5.9 seconds for single-threaded extraction of a single cube face. So I think this is the way to go. I'll write a custom cube face extractor, and Thumbor will run it on demand, no need for a job.

May 3 2024, 10:39 AM · Thumbor, MediaViewer

May 2 2024

tstarling triaged T348136: Error: Class 'MediaWiki\HookContainer\HookRunner' not found as Low priority.

The frequency of these errors before March 6 g1008752 reflected the frequency of Redis connection timeout errors. About 1 in every 160 errors raised by excimerFlushToArclamp() would fail with "HookRunner not found". So following Timo's patch, we can expect this to be very rare indeed. In logstash since that date, there has only been one such error. So I think it is a low priority.

May 2 2024, 12:13 PM · MW-Interfaces-Team, MediaWiki-Engineering, API Platform, MediaWiki-Core-Hooks, Wikimedia-production-error
tstarling added a comment to T363891: Panoramic images tiling component.

DENIVIP's panorama converter shows how simple it can be. It does all 6 cube faces in 67 seconds, single threaded. They messed up the interpolation somehow, the CImg library they used is weird and scary, and the dependencies are wrong (it doesn't really need xorg-dev), but it's certainly inspiring. It's basically doing the thing we need in 229 lines of code.

May 2 2024, 7:20 AM · Thumbor, MediaViewer
tstarling added a comment to T363891: Panoramic images tiling component.

By specifying bilinear interpolation I was able to reduce the time taken by PTmender to extract a cube face from 42 to 33 seconds. By default it uses a cubic polynomial on a 4x4 region of the input image, but I think that's excessive given we're only upscaling by a factor of between 1 and 2.

May 2 2024, 5:31 AM · Thumbor, MediaViewer
tstarling added a comment to T138933: Explore moving the Panoviewer gadget/Toolforge tool into production.

I made subtasks for what I see as the three main components of spherical panorama support:

May 2 2024, 2:39 AM · Patch-For-Review, Thumbor, MediaViewer, Tools, Platform Team Legacy (Watching / External), Services (watching), Multimedia
tstarling added a comment to T363891: Panoramic images tiling component.

Where would we store the results ? Make a new file storage subspace like score-render ?

May 2 2024, 2:24 AM · Thumbor, MediaViewer
tstarling added a comment to T345334: Cache thumbs in our caching infrastructure (e.g. ATS).

That'd work on overall hits, as you said "sort images by popularity". That's not the case here. Front caches absorb all of the hits and collapse the power law distribution.

May 2 2024, 1:45 AM · SRE, Thumbor, SRE-swift-storage, Traffic

May 1 2024

tstarling added a comment to T363885: Panoramic images thumbnailing component.

In my experiments so far, i've noticed that we also have a LOT of images that do NOT have GPano metadata.

May 1 2024, 11:30 PM · Community-Tech, Commons, MediaWiki-File-management, Thumbor
tstarling created T363891: Panoramic images tiling component.
May 1 2024, 5:20 AM · Thumbor, MediaViewer
tstarling added a comment to T363885: Panoramic images thumbnailing component.

It only supports TIFF output, so it's necessary to pass the resulting image through ImageMagick to convert it to a JPEG.

What input formats are supported?

May 1 2024, 1:46 AM · Community-Tech, Commons, MediaWiki-File-management, Thumbor
tstarling updated the task description for T363885: Panoramic images thumbnailing component.
May 1 2024, 1:33 AM · Community-Tech, Commons, MediaWiki-File-management, Thumbor
tstarling created T363885: Panoramic images thumbnailing component.
May 1 2024, 1:30 AM · Community-Tech, Commons, MediaWiki-File-management, Thumbor

Apr 30 2024

tstarling moved T209892: SecurePoll is not compatible with GPG 2.1+ from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.

Following the merge of https://gerrit.wikimedia.org/r/1003091 it would be good if @dom_walden could do a test election using the new OpenSSL encryption method. See my local test log comment on PS5 for information about generating keys and creating an election.

Apr 30 2024, 11:28 AM · MW-1.43-notes (1.43.0-wmf.7; 2024-05-28), Community-Tech (CommTech-Kanban), MW-on-K8s, MediaWiki-extensions-SecurePoll
tstarling added a project to T209892: SecurePoll is not compatible with GPG 2.1+: Community-Tech (CommTech-Kanban).
Apr 30 2024, 11:20 AM · MW-1.43-notes (1.43.0-wmf.7; 2024-05-28), Community-Tech (CommTech-Kanban), MW-on-K8s, MediaWiki-extensions-SecurePoll
tstarling merged T363810: Publish wikidiff2 to pecl into T196132: wikidiff2 binaries are not distributable due to PHP / GPL license incompatibilities.
Apr 30 2024, 10:29 AM · WMDE-TechWish-Maintenance, Software-Licensing, wikidiff2
tstarling merged task T363810: Publish wikidiff2 to pecl into T196132: wikidiff2 binaries are not distributable due to PHP / GPL license incompatibilities.
Apr 30 2024, 10:28 AM · wikidiff2
tstarling added a comment to T363810: Publish wikidiff2 to pecl.

We can't, due to T196132: wikidiff2 binaries are not distributable due to PHP / GPL license incompatibilities

Apr 30 2024, 10:28 AM · wikidiff2
tstarling added a project to T363786: MultimediaViewer Pannellum integration: Community-Tech (CommTech-Kanban).
Apr 30 2024, 2:06 AM · Community-Tech, MediaViewer
tstarling moved T362133: Clean up block_target migration code from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.
Apr 30 2024, 2:06 AM · Community-Tech (Darwin's Fox (July 15-26, 2024)), MW-1.43-notes (1.43.0-wmf.12; 2024-07-02), Multiblocks, MediaWiki-Blocks
tstarling created T363786: MultimediaViewer Pannellum integration.
Apr 30 2024, 2:03 AM · Community-Tech, MediaViewer

Apr 29 2024

tstarling added a comment to T345334: Cache thumbs in our caching infrastructure (e.g. ATS).

If we do extrapolation after 10,000th hit. The Theil-Sen extrapolation becomes more useful:
So the simplest is to see is boundary problem and say it's 130 hits at zero and zero at 200M and draw a line.

Apr 29 2024, 3:40 AM · SRE, Thumbor, SRE-swift-storage, Traffic

Apr 26 2024

tstarling closed T353194: Fix support for firejail versions 0.9.72+ as Resolved.

Should be fixed in Shellbox 4.0.1 which is required by MediaWiki 1.42.

Apr 26 2024, 1:31 AM · MediaWiki-Shell
tstarling added a comment to T228292: API uploads fatal with UploadChunkFileException: Error storing file in '/tmp' backend-fail-internal.

If there is some aspect of this that is not addressed by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1010344/ , feel free to reopen.

Apr 26 2024, 12:55 AM · MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), Commons, MediaWiki-File-management, Unstewarded-production-error, Structured-Data-Backlog, Structured Data Engineering, Wikimedia-production-error
tstarling merged task T228292: API uploads fatal with UploadChunkFileException: Error storing file in '/tmp' backend-fail-internal into T358830: Uploads fail due to 401 error from swift on wednesdays.
Apr 26 2024, 12:54 AM · MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), Commons, MediaWiki-File-management, Unstewarded-production-error, Structured-Data-Backlog, Structured Data Engineering, Wikimedia-production-error
tstarling merged T228292: API uploads fatal with UploadChunkFileException: Error storing file in '/tmp' backend-fail-internal into T358830: Uploads fail due to 401 error from swift on wednesdays.
Apr 26 2024, 12:52 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MediaWiki-Engineering, Commons, MediaWiki-File-management, SRE-swift-storage
tstarling merged task T206252: Spike of HTTP errors from SwiftFileBackend::doStoreInternal into T358830: Uploads fail due to 401 error from swift on wednesdays.
Apr 26 2024, 12:51 AM · MediaWiki-File-management, Multimedia, Commons, Wikimedia-production-error
tstarling merged T206252: Spike of HTTP errors from SwiftFileBackend::doStoreInternal into T358830: Uploads fail due to 401 error from swift on wednesdays.
Apr 26 2024, 12:50 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MediaWiki-Engineering, Commons, MediaWiki-File-management, SRE-swift-storage
tstarling closed T358830: Uploads fail due to 401 error from swift on wednesdays as Resolved.
Apr 26 2024, 12:48 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MediaWiki-Engineering, Commons, MediaWiki-File-management, SRE-swift-storage