tstarling (Tim Starling)Administrator
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 8:27 PM (170 w, 17 h)
Roles
Administrator
Availability
Available
LDAP User
Tim Starling
MediaWiki User
Tim Starling (WMF)

Recent Activity

Fri, Jan 12

Liuxinyu970226 awarded T89331: Replace HTML4 Tidy in MW parser with an equivalent HTML5 based tool a Mountain of Wealth token.
Fri, Jan 12, 12:19 PM · Services (watching), User-notice, Tidy, RfC, Parsing-Team, TechCom-RFC, Parsoid

Tue, Jan 9

tstarling added a project to T18700: Nesting templates lead to excess whitespace: Parsing-Team.
Tue, Jan 9, 2:51 AM · Parsing-Team, MediaWiki-Platform-Team, Parser, MediaWiki-Parser
tstarling renamed T173481: Investigate why sign-up fatal resulted in a blank page and fix from Investigate why sign-up fatal resulted in a blank page and fix to Investigate why sign-up fatal resulted in a blank page and fix.
Tue, Jan 9, 2:21 AM · Wikimedia-Incident, MediaWiki-Debug-Logger, MediaWiki-Platform-Team, Wikimedia-log-errors, MediaWiki-General-or-Unknown

Wed, Jan 3

tstarling closed T1124: Write design document for content/storage APIs as Declined.
Wed, Jan 3, 9:43 PM · Documentation, TechCom, Availability

Mon, Jan 1

tstarling added a comment to T172165: Require either PHP 7.0+ or HHVM in MW 1.31.

The thing that has been approved is in the task description section labelled "Current proposal". Some time before April 2018, we will migrate remaining uses of PHP 5.x in WMF production to either PHP 7 or HHVM. Then, we will update the version requirements in MW core master, before the release of MW 1.31.

Mon, Jan 1, 10:21 PM · TechCom-RFC (TechCom-Approved), MediaWiki-General-or-Unknown

Dec 13 2017

tstarling moved T176370: Migrate to PHP 7 in WMF production from In progress to Last Call on the TechCom-RFC board.

This is now moving to last call after a TC discussion.

Dec 13 2017, 9:28 PM · TechCom-RFC (TechCom-Approved), User-ArielGlenn, NewPHP, HHVM, MediaWiki-Platform-Team, Operations

Dec 12 2017

tstarling added a comment to T182645: Avoid using array_map in ExtensionRegistry and ExtensionProcessor for simple operations.

One alternative is to use the reference form of foreach:

Dec 12 2017, 4:10 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Performance, Google-Code-in-2017, MediaWiki-Configuration

Dec 8 2017

tstarling added a comment to T111441: SiteConfiguration::getConfig() does not work in Wikimedia production.

Incredible how a single line of rubbish code I wrote in 2004 can have so many people scratching their heads for so long. I hadn't seen this task before today.

Dec 8 2017, 4:46 AM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), Patch-For-Review, Wikimedia-Incident, MediaWiki-Maintenance-scripts, MediaWiki-Configuration
tstarling closed T145819: Jobs invoking SiteConfiguration::getConfig cause HHVM to fail updating the bytecode cache due to being filesize limited to 512MBytes as Resolved.

The fix is merged, and searching logstash for SiteConfiguration shows no further errors of this type.

Dec 8 2017, 4:27 AM · MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Patch-For-Review, Release-Engineering-Team (Someday), Scap, MW-1.28-release-notes, Wikimedia-Incident, Beta-Cluster-reproducible, MediaWiki-extensions-WikibaseRepository, Wikidata
tstarling closed T145819: Jobs invoking SiteConfiguration::getConfig cause HHVM to fail updating the bytecode cache due to being filesize limited to 512MBytes, a subtask of T143328: MW-1.28.0-wmf.19 deployment blockers, as Resolved.
Dec 8 2017, 4:27 AM · RelEng-Archive-FY201718-Q2, Train Deployments, Patch-For-Review, Release
tstarling closed T145819: Jobs invoking SiteConfiguration::getConfig cause HHVM to fail updating the bytecode cache due to being filesize limited to 512MBytes, a subtask of T146285: Switch mwscript from Zend PHP5 to default php alternative (e.g. HHVM or PHP7), as Resolved.
Dec 8 2017, 4:27 AM · Release-Engineering-Team (Someday), Deployments, User-Joe, Beta-Cluster-reproducible, HHVM, Operations

Dec 7 2017

tstarling created T182275: Don't send annual appeals to recurring donors.
Dec 7 2017, 4:31 AM · FR-Email

Dec 4 2017

tstarling created P6421 fixFileHeader.php output for Ie0cea0ef5027c7e583318aed04454bd33e26fcee.
Dec 4 2017, 2:40 AM

Nov 30 2017

tstarling added a comment to T174160: Language code(s) for nowiki should be changed to nb.

@tstarling: And what about the babel, e.g. here?

Nov 30 2017, 5:36 AM · Wikimedia-Site-requests

Nov 29 2017

tstarling added a comment to T174160: Language code(s) for nowiki should be changed to nb.

ll_lang is actually the interwiki prefix, it's written by LinksUpdate based on what's currently in the wikitext on the page in question, you can't just change it in the database. You'd have to change it on every page with an explicit (non-Wikidata) language link to nowiki.

Nov 29 2017, 11:46 PM · Wikimedia-Site-requests
tstarling renamed T174160: Language code(s) for nowiki should be changed to nb from Language code(s) for nowiki should be changed to nbwiki to Language code(s) for nowiki should be changed to nb.
Nov 29 2017, 10:32 PM · Wikimedia-Site-requests
tstarling moved T179832: Handling of imported usernames from Last Call to TechCom-Approved on the TechCom-RFC board.
Nov 29 2017, 9:24 PM · TechCom-RFC (TechCom-Approved)

Nov 27 2017

Steinsplitter awarded T168218: Tor hidden service for WMF websites a Love token.
Nov 27 2017, 1:00 PM · Wikimedia-General-or-Unknown, Tor

Nov 23 2017

tstarling moved T172165: Require either PHP 7.0+ or HHVM in MW 1.31 from Under discussion to Last Call on the TechCom-RFC board.
Nov 23 2017, 2:07 AM · TechCom-RFC (TechCom-Approved), MediaWiki-General-or-Unknown

Nov 22 2017

tstarling closed T178538: Bump PHP requirement to 5.6 in 1.31 as Declined.
Nov 22 2017, 11:00 PM · TechCom-RFC, Operations, MediaWiki-General-or-Unknown
tstarling closed T178538: Bump PHP requirement to 5.6 in 1.31, a subtask of T94149: Get rid of Zend 5.5 tests for wmf branches, as Declined.
Nov 22 2017, 11:00 PM · Release-Engineering-Team (Someday), Continuous-Integration-Config, Continuous-Integration-Infrastructure (Little Steps Sprint)
tstarling closed T178538: Bump PHP requirement to 5.6 in 1.31, a subtask of T170281: Raise PHP version requirement of Wikibase (and its related extensions) to 5.6, as Declined.
Nov 22 2017, 11:00 PM · MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, Wikidata
tstarling renamed T172165: Require either PHP 7.0+ or HHVM in MW 1.31 from Bump PHP requirement to 7.0 in MW 1.31 to Require either PHP 7.0+ or HHVM in MW 1.31.
Nov 22 2017, 10:56 PM · TechCom-RFC (TechCom-Approved), MediaWiki-General-or-Unknown

Nov 17 2017

Liuxinyu970226 awarded T168218: Tor hidden service for WMF websites a Love token.
Nov 17 2017, 3:17 PM · Wikimedia-General-or-Unknown, Tor

Nov 14 2017

tstarling updated subscribers of T172165: Require either PHP 7.0+ or HHVM in MW 1.31.

In puppet, the following things require php5:

Nov 14 2017, 10:38 AM · TechCom-RFC (TechCom-Approved), MediaWiki-General-or-Unknown
tstarling renamed T172165: Require either PHP 7.0+ or HHVM in MW 1.31 from Bump PHP requirement to 7.0 in 1.32 to Bump PHP requirement to 7.0 in MW 1.31.
Nov 14 2017, 10:10 AM · TechCom-RFC (TechCom-Approved), MediaWiki-General-or-Unknown
tstarling added a comment to T172165: Require either PHP 7.0+ or HHVM in MW 1.31.

If the minimum will be "either PHP 7 or HHVM" then we need to stop using PHP 5.6 in production. Hence the subtask I just added. I'm changing the title back to MW 1.31 since that is what @Anomie is proposing. It will have to be done prior to migration to stretch if we are going to keep to that timeline.

Nov 14 2017, 10:10 AM · TechCom-RFC (TechCom-Approved), MediaWiki-General-or-Unknown
tstarling closed T125748: PHP 5.5.9's getopt does not respect global $argv like HHVM does, causing issues parsing command line parameters via multiversion's MWScript. as Resolved.

This was fixed by @Krenair by just not using getopt() anymore, which seems good enough to me. I confirmed that we're not using it, except in tests.

Nov 14 2017, 10:03 AM · MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)), Upstream, MediaWiki-General-or-Unknown, MediaWiki-Maintenance-scripts
tstarling added a parent task for T146285: Switch mwscript from Zend PHP5 to default php alternative (e.g. HHVM or PHP7): T172165: Require either PHP 7.0+ or HHVM in MW 1.31.
Nov 14 2017, 9:26 AM · Release-Engineering-Team (Someday), Deployments, User-Joe, Beta-Cluster-reproducible, HHVM, Operations
tstarling added a subtask for T172165: Require either PHP 7.0+ or HHVM in MW 1.31: T146285: Switch mwscript from Zend PHP5 to default php alternative (e.g. HHVM or PHP7).
Nov 14 2017, 9:26 AM · TechCom-RFC (TechCom-Approved), MediaWiki-General-or-Unknown

Nov 10 2017

tstarling added a comment to T180183: Profiling for X-Wikimedia-Debug seems to start fairly late.

It helps a little bit, but you still don't get multiversion. Maybe we should use auto_prepend_file.

Nov 10 2017, 2:34 AM · MediaWiki-General-or-Unknown, Performance-Team
tstarling added a comment to T175672: Make apache/maintenance hosts TLS connections to mariadb work.

I forget to mention, using the CA file parameter instead of the CA directory (ca=/etc/ssl/certs/Puppet_Internal_CA.pem) gives "SSL connection error: unknown error number (10.192.32.108)".

Nov 10 2017, 1:33 AM · Patch-For-Review, Performance-Team (Radar), Availability (Multiple-active-datacenters), DBA, Operations
tstarling added a comment to T175672: Make apache/maintenance hosts TLS connections to mariadb work.

Looking at http://php.net/manual/en/mysqli.ssl-set.php, I would think you'd only need to set capath=/etc/ssl/certs, while setting all other parameters to NULL (except maybe cipher, as I have no idea what is the actual default cipherlist for mysqli on HHVM).

I tried that first but it yields "SSL connection error: SSL_CTX_set_default_verify_paths failed (10.192.32.108)".

Nov 10 2017, 12:35 AM · Patch-For-Review, Performance-Team (Radar), Availability (Multiple-active-datacenters), DBA, Operations

Nov 8 2017

tstarling moved T179832: Handling of imported usernames from Inbox to Request IRC meeting on the TechCom-RFC board.
Nov 8 2017, 8:59 PM · TechCom-RFC (TechCom-Approved)

Nov 3 2017

tstarling created P6255 T170779 idea.
Nov 3 2017, 10:35 AM

Oct 17 2017

tstarling placed T161671: Compacting the revision table up for grabs.
Oct 17 2017, 1:07 AM · Multi-Content-Revisions, MediaWiki-Platform-Team, Epic, Patch-For-Review, MediaWiki-Database, Schema-change

Oct 9 2017

tstarling moved T170184: Refactor anti-spam/vandalism checks out of EditPage.php from Watching to Backlog on the MediaWiki-Platform-Team board.
Oct 9 2017, 1:50 AM · Patch-For-Review, Technical-Debt, MediaWiki-Platform-Team, MediaWiki-Page-editing

Oct 4 2017

D3r1ck01 awarded T176370: Migrate to PHP 7 in WMF production a Mountain of Wealth token.
Oct 4 2017, 7:40 PM · TechCom-RFC (TechCom-Approved), User-ArielGlenn, NewPHP, HHVM, MediaWiki-Platform-Team, Operations

Sep 26 2017

tstarling added a comment to T176749: Requesting access to pingback data for cicalese.

There is research-client.cnf, accessible from the researchers group, and stats-research-client.cnf, which is identical, but accessible from the stats group. There's no such file as analytics-research-client.cnf, I updated the docs in one place where I saw that filename. I see in puppet/modules/admin/data/data.yaml that researchers is the group usually used for this, I don't see any stats group. So, please give Cindy SSH access in the researchers group.

Sep 26 2017, 10:05 PM · Operations, Ops-Access-Requests
tstarling created MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018).
Sep 26 2017, 12:30 AM
tstarling created MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017).
Sep 26 2017, 12:29 AM
tstarling created MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2017).
Sep 26 2017, 12:27 AM

Sep 21 2017

Ricordisamoa awarded T176370: Migrate to PHP 7 in WMF production a Yellow Medal token.
Sep 21 2017, 10:26 AM · TechCom-RFC (TechCom-Approved), User-ArielGlenn, NewPHP, HHVM, MediaWiki-Platform-Team, Operations
tstarling closed T173786: Convert Wikimedia production HHVM instances to have hhvm.php7.all set true as Declined.

I don't think it's a duplicate, we could theoretically do both. But like Max says, there's not really a rationale for it anymore.

Sep 21 2017, 12:44 AM · MediaWiki-Platform-Team, Performance-Team, Operations, HHVM
tstarling closed T173786: Convert Wikimedia production HHVM instances to have hhvm.php7.all set true, a subtask of T172165: Require either PHP 7.0+ or HHVM in MW 1.31, as Declined.
Sep 21 2017, 12:44 AM · TechCom-RFC (TechCom-Approved), MediaWiki-General-or-Unknown

Sep 20 2017

tstarling closed T121913: Enable HHVM Repo Authoritative mode as Declined.

Declining due to T176370: Migrate to PHP 7 in WMF production

Sep 20 2017, 10:21 PM · HHVM
tstarling updated the task description for T176370: Migrate to PHP 7 in WMF production.
Sep 20 2017, 10:20 PM · TechCom-RFC (TechCom-Approved), User-ArielGlenn, NewPHP, HHVM, MediaWiki-Platform-Team, Operations
tstarling created T176370: Migrate to PHP 7 in WMF production.
Sep 20 2017, 10:19 PM · TechCom-RFC (TechCom-Approved), User-ArielGlenn, NewPHP, HHVM, MediaWiki-Platform-Team, Operations
tstarling added a comment to T176312: Don’t check format constraint via SPARQL (safely evaluating user-provided regular expressions).

If you just want an approximately PCRE-like syntax, you could just translate the regex to a Lua pattern. Scribunto has equivalent code going in the other direction, in Scribunto_LuaUstringLibrary::patternToRegex(), which you could look at for ideas. Obviously you would be implementing a subset of PCRE features.

Sep 20 2017, 10:02 PM · TechCom-RFC, Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata

Sep 19 2017

tstarling assigned T144962: Run MediaWiki tests on PHP 7 to Legoktm.

@Legoktm is taking this on next quarter.

Sep 19 2017, 5:36 AM · Continuous-Integration-Infrastructure (shipyard), MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Patch-For-Review
tstarling closed T176101: Cannot delete File:MKC,S.jpg on zhwiki due to DBQueryError as Resolved.

Applied that patch in https://gerrit.wikimedia.org/r/#/c/378818/ , deployed.

Sep 19 2017, 5:31 AM · Patch-For-Review, Vuln-Inject, Wikimedia-log-errors, Chinese-Sites, MediaWiki-Page-deletion

Sep 18 2017

tstarling assigned T176101: Cannot delete File:MKC,S.jpg on zhwiki due to DBQueryError to Anomie.
Sep 18 2017, 12:01 PM · Patch-For-Review, Vuln-Inject, Wikimedia-log-errors, Chinese-Sites, MediaWiki-Page-deletion

Sep 5 2017

tstarling added a project to T175099: PHP-parser + Remex combo output differs from PHP-parser + Tidy combo on some dl-dt wikitext snippets: RemexHtml.
Sep 5 2017, 11:49 PM · MediaWiki-Parser, Patch-For-Review, RemexHtml, Tidy
tstarling created RemexHtml.
Sep 5 2017, 11:48 PM

Sep 1 2017

tstarling added a comment to T87753: Space between final 2 words in a page with ≥2 category tags is removed in arabic mediawiki.

I reverted that patch on account of it having a serious error in it, as described in T174639, and there was no response from the developer after 1 day.

Sep 1 2017, 12:59 AM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, I18n, MediaWiki-Categories, MediaWiki-Parser
tstarling closed T174639: Recent replaceInternalLinks() patch causes line breaks to be stripped from an internal link following a category as Resolved.

Reverted, cherry picked and deployed

Sep 1 2017, 12:58 AM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, MediaWiki-Parser

Aug 31 2017

tstarling added a comment to T166010: The Great Namespaceization and Reorg.

Has there already been an official decision? Because change rEBOP8c136be2d1eed004961fd1baa0eb3517b805192b suggests that MediaWiki\Extension\ExtensionName is now the convention. Can anybody confirm?
This topic is pretty important to me, because the BlueSpice team is switching to namespaces rigth now. And I want to make sure we stick as close to MediaWiki core patterns as possible. At the moment we use BlueSpice\ExtensionName as pattern.

Aug 31 2017, 7:02 AM · MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Epic, TechCom-RFC
tstarling moved T164898: PostgreSQL schema change for consistency with MySQL from Last Call to TechCom-Approved on the TechCom-RFC board.
Aug 31 2017, 5:43 AM · TechCom-RFC (TechCom-Approved), Technical-Debt, MediaWiki-Platform-Team, PostgreSQL
tstarling created T174639: Recent replaceInternalLinks() patch causes line breaks to be stripped from an internal link following a category.
Aug 31 2017, 1:45 AM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, MediaWiki-Parser

Aug 30 2017

tstarling updated the task description for T164898: PostgreSQL schema change for consistency with MySQL.
Aug 30 2017, 8:39 PM · TechCom-RFC (TechCom-Approved), Technical-Debt, MediaWiki-Platform-Team, PostgreSQL
tstarling added a comment to T164898: PostgreSQL schema change for consistency with MySQL.

Not sure how I missed this task until now. I'm mostly okay with this, but the timestamp change in particular seems a step in the wrong direction.

Aug 30 2017, 8:38 PM · TechCom-RFC (TechCom-Approved), Technical-Debt, MediaWiki-Platform-Team, PostgreSQL

Aug 28 2017

tstarling added a comment to P5926 (An Untitled Masterwork).
MariaDB [mw]> \s
--------------
mysql  Ver 15.1 Distrib 5.5.36-MariaDB, for debian-linux-gnu (x86_64) using readline 5.1
Aug 28 2017, 1:23 AM
tstarling created P5926 (An Untitled Masterwork).
Aug 28 2017, 1:20 AM

Aug 24 2017

tstarling moved T156924: Allow integration of data from etcd into the MediaWiki configuration from Backlog to Future on the MediaWiki-Platform-Team board.
Aug 24 2017, 3:38 AM · MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), MediaWiki-Configuration, Performance-Team (Radar), Availability (Multiple-active-datacenters), Services (watching), User-Joe, User-mobrovac, Operations

Aug 22 2017

tstarling moved T152540: Migrate to HTML5 section ids from Under discussion to Request IRC meeting on the TechCom-RFC board.
Aug 22 2017, 9:55 PM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Readers-Web-Backlog (Tracking), User-notice, Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, Community-Wishlist-Survey-2016, Community-Tech, ContentTranslation, MediaWiki-Parser, Parsoid, Parsing-Team
Samtar awarded T168218: Tor hidden service for WMF websites a Like token.
Aug 22 2017, 7:07 AM · Wikimedia-General-or-Unknown, Tor
tstarling closed T65027: Improve poolcounter error messages. as Resolved.
Aug 22 2017, 1:46 AM · MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), Patch-For-Review, MediaWiki-extensions-PoolCounter

Aug 18 2017

tstarling added a comment to T166010: The Great Namespaceization and Reorg.

I moved ChangesFeed from includes/changes to the Feed namespace because I think it was missorted. It doesn't call anything else in the changes directory, and nothing in the changes directory calls it. It's integrated with ChannelFeed from Feed.php.

Aug 18 2017, 10:39 AM · MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Epic, TechCom-RFC
tstarling added a comment to T166010: The Great Namespaceization and Reorg.

The API classes could potentially use a similar treatment (see the breakdown in T166010#3370599) if we go with options 2-5.

Aug 18 2017, 7:12 AM · MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Epic, TechCom-RFC
tstarling added a member for Security: VColeman.
Aug 18 2017, 12:12 AM
tstarling added a comment to T171166: Build and push a new hhvm-luasandbox package.

The status is just what I wrote in the task description of T171267, I haven't done any more work on it since then, except for merging another change into master. I built a package for trusty, but not for jessie. Building a package for jessie will require at least updating the control file. I haven't tested it in deployment-prep.

Aug 18 2017, 12:01 AM · Operations, MediaWiki-extensions-Scribunto

Aug 17 2017

Nemo_bis awarded T164898: PostgreSQL schema change for consistency with MySQL a Mountain of Wealth token.
Aug 17 2017, 6:58 AM · TechCom-RFC (TechCom-Approved), Technical-Debt, MediaWiki-Platform-Team, PostgreSQL

Aug 15 2017

tstarling added a comment to T166010: The Great Namespaceization and Reorg.

Looking at the number of classes per namespace, including the changes above, two namespaces stand out as being underpopulated:

Aug 15 2017, 11:24 PM · MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Epic, TechCom-RFC

Aug 11 2017

tstarling added a comment to T166010: The Great Namespaceization and Reorg.

I've started to work on the core alias map. A few questions:

Aug 11 2017, 12:24 AM · MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Epic, TechCom-RFC

Aug 10 2017

tstarling moved T166010: The Great Namespaceization and Reorg from Backlog to Watching on the MediaWiki-Platform-Team board.
Aug 10 2017, 11:44 PM · MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Epic, TechCom-RFC

Aug 7 2017

tstarling added a comment to T172477: Attribute anonymous contributions to the first IP address used in a session.

Is there any benefit in using a prefixed IP as the username, as opposed to using a session ID (possibly something easier to remember, such as a diceware string) and exposing the IP address separately?

Aug 7 2017, 4:50 AM · TechCom-RFC, MediaWiki-User-management

Aug 4 2017

tstarling updated the task description for T172477: Attribute anonymous contributions to the first IP address used in a session.
Aug 4 2017, 3:05 AM · TechCom-RFC, MediaWiki-User-management
tstarling created T172477: Attribute anonymous contributions to the first IP address used in a session.
Aug 4 2017, 2:55 AM · TechCom-RFC, MediaWiki-User-management
tstarling closed T58252: IPv6 range blocks should be limited to /48s, not /19s as Declined.
Aug 4 2017, 1:34 AM · IPv6, MediaWiki-User-management
tstarling added a comment to T153333: RFC: How should we store longer revision comments?.

I only suggested the comment_text(100) index because some people is obsessed with hashes

Aug 4 2017, 1:07 AM · TechCom-RFC (TechCom-Approved), User-Daniel, Community-Tech

Aug 2 2017

tstarling added a comment to T166732: Refactor comment storage in the database and abstract access in MediaWiki.

I wrote about my concerns about the deduplication scheme at T153333#3491632 , since that's where most of the discussion on that topic was. Apologies for the late review, but seeing the code has made the problems clearer to me.

Aug 2 2017, 3:11 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, MediaWiki-Database
tstarling reopened T153333: RFC: How should we store longer revision comments?, a subtask of T6715: Allow comments longer than 255 bytes, as Open.
Aug 2 2017, 12:04 AM · Hindi-Sites, Malayalam-Sites, Community-Tech, User-notice, Schema-change, MediaWiki-Database
tstarling reopened T153333: RFC: How should we store longer revision comments? as "Open".

I'm very skeptical about deduplication via the comment_text(100) index, for the following reasons:

Aug 2 2017, 12:04 AM · TechCom-RFC (TechCom-Approved), User-Daniel, Community-Tech
tstarling reopened T153333: RFC: How should we store longer revision comments?, a subtask of T161671: Compacting the revision table, as Open.
Aug 2 2017, 12:04 AM · Multi-Content-Revisions, MediaWiki-Platform-Team, Epic, Patch-For-Review, MediaWiki-Database, Schema-change

Jul 27 2017

tstarling added a comment to T162395: Add .mp3 to the list of accepted file types on Wikimedia Commons uploads.

Note that legal review is complete now, there doesn't seem to be any blocker.

Jul 27 2017, 3:00 AM · WMF-Legal, Commons

Jul 26 2017

tstarling added a comment to T167784: WMF ParserCache disk space exhaustion.

Note that the whole wikidata request rate spike only reduced disk free space from 11% to 9% -- so by deleting the relevant rows, we might expect a similar 2% increase in free space. It's not the main culprit for increased disk space usage in the long term, that award apparently goes to wrapclass and responsiveimages, which are cumulatively responsible for ~38% of rows.

Jul 26 2017, 6:20 AM · MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2017), Performance-Team, DBA, MediaWiki-Parser
tstarling created P5806 (An Untitled Masterwork).
Jul 26 2017, 6:09 AM · Chinese-Sites
tstarling added a comment to T167784: WMF ParserCache disk space exhaustion.

The cache miss spike I mentioned earlier was apparently due to wikidata: 75% of the cache entries written with the relevant expiry time were for wikidatawiki, whereas that wiki is normally a very small percentage. Of those cache entries, 99% had options "!canonical!wb3", whereas normally wikidata cache options are highly fragmented. $wgCacheEpoch was updated for wikidatawiki, about 8 hours before the start of the spike (https://gerrit.wikimedia.org/r/#/c/367391/ for T170668). It's possible that someone ran a bot or crawler to fetch a lot of wikidatawiki pages, either coincidentally after the cache epoch bump, or in an attempt to fix a related problem.

Jul 26 2017, 5:15 AM · MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2017), Performance-Team, DBA, MediaWiki-Parser
tstarling added a comment to T167784: WMF ParserCache disk space exhaustion.

I had a look at cache-fragmenting parser options on pc1004 parsercache.pc001.

Jul 26 2017, 2:05 AM · MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2017), Performance-Team, DBA, MediaWiki-Parser
tstarling added a comment to T167784: WMF ParserCache disk space exhaustion.

I added disk free space, and the derivative of disk free space, to the parser cache dashboard in Grafana: https://grafana.wikimedia.org/dashboard/db/parser-cache?refresh=5m&orgId=1&from=1500783303871&to=1501027037629

Jul 26 2017, 12:52 AM · MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2017), Performance-Team, DBA, MediaWiki-Parser

Jul 25 2017

tstarling moved T162379: Decide which non-standard CSS properties to support in TemplateStyles from Future to Backlog on the MediaWiki-Platform-Team board.
Jul 25 2017, 1:40 AM · MediaWiki-Platform-Team, css-sanitizer, TemplateStyles

Jul 24 2017

tstarling merged T171267: Deploy LuaSandbox 2.0.13 into T171166: Build and push a new hhvm-luasandbox package.
Jul 24 2017, 2:29 AM · Operations, MediaWiki-extensions-Scribunto
tstarling merged task T171267: Deploy LuaSandbox 2.0.13 into T171166: Build and push a new hhvm-luasandbox package.
Jul 24 2017, 2:29 AM · MediaWiki-Platform-Team

Jul 23 2017

tstarling moved T65027: Improve poolcounter error messages. from Inbox to Future on the MediaWiki-Platform-Team board.
Jul 23 2017, 11:58 PM · MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), Patch-For-Review, MediaWiki-extensions-PoolCounter
tstarling claimed T65027: Improve poolcounter error messages..
Jul 23 2017, 11:57 PM · MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), Patch-For-Review, MediaWiki-extensions-PoolCounter

Jul 21 2017

tstarling added a comment to T65027: Improve poolcounter error messages..

The key, and error message in English, were done in February 2014. The pool type was added in April 2014. The URL is included in the monolog stream. So I guess it's just the PC server that is missing? That would be easy enough for errors that originate in the extension, like connect failures. For errors that come from the core, like pool overflow, the PC server is more difficult to determine, and less likely to be relevant.

Jul 21 2017, 6:26 AM · MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), Patch-For-Review, MediaWiki-extensions-PoolCounter
tstarling added a comment to T133318: High levels of PoolCounter errors should trigger alerts.

MW already provides a log of all PoolCounter errors, including queue overflow, in the poolcounter channel. So this is presumably just a matter of monitoring configuration, which my team is not very familiar with.

Jul 21 2017, 6:02 AM · MediaWiki-Platform-Team, Operations, monitoring
tstarling moved T171267: Deploy LuaSandbox 2.0.13 from Inbox to Future on the MediaWiki-Platform-Team board.
Jul 21 2017, 5:46 AM · MediaWiki-Platform-Team
tstarling lowered the priority of T171267: Deploy LuaSandbox 2.0.13 from High to Normal.
Jul 21 2017, 5:42 AM · MediaWiki-Platform-Team
tstarling created T171267: Deploy LuaSandbox 2.0.13.
Jul 21 2017, 5:42 AM · MediaWiki-Platform-Team