Page MenuHomePhabricator

tstarling (Tim Starling)
UserAdministrator

Projects (21)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 8:27 PM (424 w, 3 d)
Roles
Administrator
Availability
Available
LDAP User
Tim Starling
MediaWiki User
Tim Starling (WMF) [ Global Accounts ]

Recent Activity

Yesterday

tstarling added a comment to T291015: Add per-request flamegraph option to WikimediaDebug.

Send or store somewhere

Fri, Dec 2, 5:37 AM · Arc-Lamp, Performance-Team

Thu, Dec 1

tstarling added a comment to T49578: Score should output SVG.

@Jonathanischoice you should use git-review to upload changes. It is not possible to push to refs/heads/*, you need to push to refs/for/* to create a change for review, which git-review takes care of.

Thu, Dec 1, 2:45 AM · Upstream, Wikimedia-SVG-rendering, Patch-For-Review, MediaWiki-extensions-Score
tstarling added a comment to T304515: PHP Warning: Cannot use a scalar value as an array.

require DIR . '/../includes/WebStart.php';

Thu, Dec 1, 2:32 AM · MW-1.35-notes, MW-1.38-notes, MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Patch-For-Review, VisualEditor, Wikidata, MediaWiki-extensions-WikibaseClient, JavaScript, ci-test-error (WMF-deployed Build Failure)
tstarling added a comment to T304515: PHP Warning: Cannot use a scalar value as an array.

I noticed such a parse error on https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/9834/ :

Thu, Dec 1, 2:11 AM · MW-1.35-notes, MW-1.38-notes, MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Patch-For-Review, VisualEditor, Wikidata, MediaWiki-extensions-WikibaseClient, JavaScript, ci-test-error (WMF-deployed Build Failure)

Tue, Nov 29

tstarling added a comment to T155604: Diff formatter for screen readers.

Maybe the natural language idea was too ambitious, and we should just do something dense and technical. I see there is now also T245409 which is an idea for CSS-only screen reader compatibility.

Tue, Nov 29, 10:12 PM · WCAG-Level-A, MediaWiki-Page-diffs, Accessibility

Sun, Nov 27

tstarling claimed T299387: Database corruption due to compressOld array plus bug, April 2006.
Sun, Nov 27, 11:38 PM · Patch-For-Review, Wikimedia-database-issue (Bad data), Platform Engineering, MediaWiki-Core-Revision-backend, Wikimedia-production-error
tstarling renamed T299387: Database corruption due to compressOld array plus bug, April 2006 from Bad revision in German Wikipedia to Database corruption due to compressOld array plus bug, April 2006.
Sun, Nov 27, 11:13 PM · Patch-For-Review, Wikimedia-database-issue (Bad data), Platform Engineering, MediaWiki-Core-Revision-backend, Wikimedia-production-error

Fri, Nov 25

tstarling added a comment to T299387: Database corruption due to compressOld array plus bug, April 2006.

We know that a version of compressOld.php without the 120 byte threshold was run on dewiki, because that's the only thing that could create the empty HBS objects. It was run some time after 2005-05-14, which is the latest rev_timestamp for such an object. The upgrade to MW 1.5 was done in June-July 2005. The compressOld.inc in the REL1_4 branch indeed does not have the 120 byte threshold. So that all makes sense since the SAL shows me running compressOld.php in late May.

Fri, Nov 25, 12:47 AM · Patch-For-Review, Wikimedia-database-issue (Bad data), Platform Engineering, MediaWiki-Core-Revision-backend, Wikimedia-production-error

Thu, Nov 24

tstarling added a comment to T299387: Database corruption due to compressOld array plus bug, April 2006.
		if ( $text === '' ) {
			// This is what happens if the revision was broken at the time the
			// dump was made. Unfortunately, it also happens if the revision was
			// legitimately blank, so there's no way to tell the difference. To
			// be safe, we'll skip it and leave it broken
			$id = $id ? $id : '';
			echo "Revision $id is blank in the dump, may have been broken before export\n";
			return;
		}
Thu, Nov 24, 1:05 AM · Patch-For-Review, Wikimedia-database-issue (Bad data), Platform Engineering, MediaWiki-Core-Revision-backend, Wikimedia-production-error

Wed, Nov 23

tstarling added a comment to T299387: Database corruption due to compressOld array plus bug, April 2006.

A possible cause of this data corruption is the bug in compressOld.inc

Wed, Nov 23, 5:36 AM · Patch-For-Review, Wikimedia-database-issue (Bad data), Platform Engineering, MediaWiki-Core-Revision-backend, Wikimedia-production-error
tstarling closed T320864: Incorrect email headers using PHP mail in PHP 8.0 as Resolved.
Wed, Nov 23, 3:22 AM · MW-1.35-notes, MW-1.39-notes, MW-1.38-notes, MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), MediaWiki-Email, Infrastructure-Foundations, PHP 8.2 support, PHP 8.1 support, PHP 8.0 support, Mail
tstarling closed T278183: Score generatePngAndMidi.sh hides individual shell commands as Resolved.
Wed, Nov 23, 3:20 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), MediaWiki-extensions-Score

Wed, Nov 16

tstarling added a comment to T299387: Database corruption due to compressOld array plus bug, April 2006.
[0448][tstarling@mwmaint1002:~]$ mwscript maintenance/storage/storageTypeStats.php --wiki=dewiki
Using bin size of 100000
226000000
Wed, Nov 16, 5:13 AM · Patch-For-Review, Wikimedia-database-issue (Bad data), Platform Engineering, MediaWiki-Core-Revision-backend, Wikimedia-production-error
tstarling added a comment to T299387: Database corruption due to compressOld array plus bug, April 2006.

$blob = $dbc->selectField('blobs','blob_text', ['blob_id' => 16645]);
$obj = unserialize($blob);
print $obj->getItem('d41d8cd98f00b204e9800998ecf8427e');

Actually $obj here is a DiffHistoryBlob and DiffHistoryBlob::getItem() casts the key to an int, so the text is just some random text, not actually the text of the revision.

Wed, Nov 16, 4:34 AM · Patch-For-Review, Wikimedia-database-issue (Bad data), Platform Engineering, MediaWiki-Core-Revision-backend, Wikimedia-production-error

Tue, Nov 15

tstarling added a comment to T299387: Database corruption due to compressOld array plus bug, April 2006.

Haha d41d8cd98f00b204e9800998ecf8427e is the MD5 hash of the empty string. We can recover the text from the hash.

Tue, Nov 15, 6:19 AM · Patch-For-Review, Wikimedia-database-issue (Bad data), Platform Engineering, MediaWiki-Core-Revision-backend, Wikimedia-production-error
tstarling added a comment to T299387: Database corruption due to compressOld array plus bug, April 2006.

Actually $obj here is a DiffHistoryBlob and DiffHistoryBlob::getItem() casts the key to an int, so the text is just some random text, not actually the text of the revision.

Tue, Nov 15, 5:17 AM · Patch-For-Review, Wikimedia-database-issue (Bad data), Platform Engineering, MediaWiki-Core-Revision-backend, Wikimedia-production-error
tstarling added a comment to T299387: Database corruption due to compressOld array plus bug, April 2006.

A server admin log entry from March 30, 2006 indicates that I ran resolveStubs.php. This was supposed to remove all HistoryBlobStub objects from the database.

Tue, Nov 15, 3:45 AM · Patch-For-Review, Wikimedia-database-issue (Bad data), Platform Engineering, MediaWiki-Core-Revision-backend, Wikimedia-production-error

Mon, Nov 14

tstarling updated subscribers of T307132: PHP Deprecated: Caller from Wikimedia\Rdbms\Database::ping ignored an error originally raised from WikiPage::updateRevisionOn: [1205] Lock wait timeout exceeded; try restarting transaction ([db]).

I noticed that these deprecation warnings are still happening. Example log entry:

Mon, Nov 14, 6:12 AM · MediaWiki-Core-Revision-backend, Wikimedia-production-error
tstarling added a comment to T289189: getid3: PHP Warning: Division by zero.

https://github.com/JamesHeinrich/getID3/pull/404

Mon, Nov 14, 3:26 AM · PHP 8.1 support, Upstream, User-brennen, TimedMediaHandler, Wikimedia-production-error
tstarling added a project to T289189: getid3: PHP Warning: Division by zero: PHP 8.1 support.

Per the stack trace I posted at T303784, this also affects module.audio-video.matroska.php, line 299. I found a few more issues by code review. I'll make a PR.

Mon, Nov 14, 12:11 AM · PHP 8.1 support, Upstream, User-brennen, TimedMediaHandler, Wikimedia-production-error

Sun, Nov 13

tstarling added a comment to T303784: InvalidArgumentException: Cannot add non-finite floats to ApiResult.

More recently there is

Sun, Nov 13, 11:36 PM · MediaWiki-Uploading, Platform Engineering, MediaWiki-Action-API, Wikimedia-production-error
tstarling closed T321328: TypeError: Cannot read properties of null (reading 'nextElementSibling') as Resolved.

It was probably resolved by https://gerrit.wikimedia.org/r/844521 . I can't find anything in logstash for that URL.

Sun, Nov 13, 10:47 PM · Unstewarded-production-error, Wikimedia-production-error

Thu, Nov 10

tstarling closed T313004: Cold cache page view to metawiki times out then fails with OOM in timeout handler as Resolved.

I confirmed that there are no recent timeouts from MessageCache::loadFromDBWithLock, so presumably it was fixed by 813883.

Thu, Nov 10, 7:16 AM · MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Performance-Team, Performance Issue, MediaWiki-Internationalization, MediaWiki-extensions-CentralNotice

Wed, Nov 9

tstarling updated subscribers of T322278: MediaWiki core should pass Phan on PHP 8.1.

Under PHP 8.0 there are a lot of PhanUndeclaredClassAttribute Reference to undeclared class \ReturnTypeWillChange in an attribute (annotations added via T289879). Maybe we need a stub for this class when running under PHP 8.0?

Wed, Nov 9, 10:46 PM · Patch-For-Review, MW-1.40-notes (1.40.0-wmf.10; 2022-11-14), MediaWiki-General, phan, PHP 8.1 support

Nov 3 2022

tstarling added a comment to T322278: MediaWiki core should pass Phan on PHP 8.1.

Yes, those are the 6 errors I mentioned. My analysis:

Nov 3 2022, 11:17 AM · Patch-For-Review, MW-1.40-notes (1.40.0-wmf.10; 2022-11-14), MediaWiki-General, phan, PHP 8.1 support
tstarling created T322278: MediaWiki core should pass Phan on PHP 8.1.
Nov 3 2022, 2:31 AM · Patch-For-Review, MW-1.40-notes (1.40.0-wmf.10; 2022-11-14), MediaWiki-General, phan, PHP 8.1 support

Nov 1 2022

tstarling created T322099: TwoColConflict support for PHP 8.1.
Nov 1 2022, 3:33 AM · WMDE-TechWish-Maintenance, MW-1.40-notes (1.40.0-wmf.10; 2022-11-14), Two-Column-Edit-Conflict-Merge, PHP 8.1 support
tstarling created T322098: GeoData support for PHP 8.1.
Nov 1 2022, 3:25 AM · MW-1.40-notes (1.40.0-wmf.10; 2022-11-14), GeoData, Discovery-Search, PHP 8.1 support
tstarling added a comment to T321692: FileImporter support for PHP 8.1.

Tests where everything is mocked, the fields are null, validation is disabled, and then you call random methods and expect them to work. Fragile and sensitive to private details of the classes being tested.

Nov 1 2022, 2:27 AM · MW-1.40-notes (1.40.0-wmf.10; 2022-11-14), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2022-10-26, WMDE-TechWish-Maintenance, WMDE-TechWish, Move-Files-To-Commons, PHP 8.1 support
tstarling reopened T321692: FileImporter support for PHP 8.1, a subtask of T319065: All Wikimedia production extensions and skins must support PHP 8.1, as Open.
Nov 1 2022, 2:18 AM · MediaWiki-extensions-General, PHP 8.1 support
tstarling reopened T321692: FileImporter support for PHP 8.1 as "Open".
1) FileImporter\Tests\Data\ImportDetailsTest::testInvalidFileRevisionTimestamp
strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated
Nov 1 2022, 2:18 AM · MW-1.40-notes (1.40.0-wmf.10; 2022-11-14), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2022-10-26, WMDE-TechWish-Maintenance, WMDE-TechWish, Move-Files-To-Commons, PHP 8.1 support
tstarling added a comment to T277766: PHP Warning: XMLReader::read(): .
Nov 1 2022, 1:13 AM · Unstewarded-production-error, MediaWiki-Core-Snapshots, Wikimedia-production-error
tstarling committed rESMX0f49a23e5968: Check the return value from SiteConfiguration::siteFromDB() (authored by tstarling).
Check the return value from SiteConfiguration::siteFromDB()
Nov 1 2022, 1:01 AM

Oct 31 2022

tstarling added a comment to T277766: PHP Warning: XMLReader::read(): .

Sorry, made the same mistake. I'm not sure how the jump was made from the prod error to this Toolforge tool, but I'm guessing it was in the referrer or user-agent string. I agree the input seems invalid and that should be fixed.

Oct 31 2022, 11:44 PM · Unstewarded-production-error, MediaWiki-Core-Snapshots, Wikimedia-production-error
tstarling added a comment to T316078: Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries).

CI has 8.1 voting for MediaWiki core itself and MediaWiki vendor, but it's not running for extensions/skins and there are some libraries (T307506) whose tests (and so possibly code in untested core usage?) fail. Hence the subsidiary tasks.

Oct 31 2022, 4:35 AM · Patch-For-Review, Continuous-Integration-Config, PHP 8.1 support
tstarling added a comment to T307618: mediawiki/libs/Dodo test failure for php8.1.

It needs to be maintained until it stops being a core dependency. If we don't want to maintain it, we should remove it from Parsoid's composer.json.

Oct 31 2022, 4:01 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Patch-For-Review, Parsoid (Dodo), PHP 8.1 support

Oct 27 2022

tstarling closed T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11, a subtask of T319432: Migrate WMF production from PHP 7.4 to PHP 8.1, as Resolved.
Oct 27 2022, 2:58 AM · Patch-For-Review, serviceops, Performance-Team
tstarling closed T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11 as Resolved.
Oct 27 2022, 2:58 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling updated the task description for T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.
Oct 27 2022, 2:57 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling updated the task description for T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.
Oct 27 2022, 2:57 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling updated the task description for T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.
Oct 27 2022, 2:48 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.

The script is now running with --run, i.e. the automatic renames and deletes are in progress.

Oct 27 2022, 1:38 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.

I reviewed the list of proposed page moves. In some cases a redirect would have been moved to an inappropriate title, such as a redirect to the article about ligatures being moved to a title that is no longer a ligature. So I deleted those redirects. The list is at https://meta.wikimedia.org/wiki/Unicode_11_case_map_migration#Manual_deletes .

Oct 27 2022, 12:32 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops

Oct 26 2022

tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.
  • st, ſt: manually renamed
Oct 26 2022, 11:46 PM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.
  • ῦΰῡΏ, ⅵ5lasevilsion, ⅹシンバⅹ, ⓕⓤⓒⓚ ⓨⓞⓤ, ⓘⓢⓑⓔⓣⓗ ⓟⓔⓡⓔⓩ, ⓙⓤⓐⓝ ⓜ ⓥⓔⓡⓣⓔⓛ, ⓛⓘⓝⓐ- -ⓒⓐⓓⓔⓝⓐ, fiamma86, fiammettina, filomena85, fittesaft, st~rowiki: manually renamed
Oct 26 2022, 11:08 PM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.

Note that fixStuckGlobalRename.php was generally not appropriate because the global user had not been renamed. The whole operation had to be restarted, not just one job.

Oct 26 2022, 10:47 PM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling updated the task description for T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.
Oct 26 2022, 10:46 PM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.
  • LJ: done with Special:GlobalRenameUser
  • LJ no. Ƽ: renamed to ~~Lj no. Ƽ since there was already a ~Lj no. Ƽ on enwiki, not sure where it came from
  • ẗercasek: I ran fixStuckGlobalRename.php, but this only renamed the local account. I renamed the global account with Special:GlobalRenameUser, and then it showed up as admin attached.
  • ὒλη: renamed with Special:GlobalRenameUser
  • ⅽⅽⅽⅽombobreaker!: deleted renameuser_status row, wiped cache with eval.php and renamed with Special:GlobalRenameUser
  • ⓖⓡⓤⓢⓣⓝⓐⓨⓐ ⓕⓔⓔⓗⓖⓐ: ditto
  • ⓗⓐⓖⓖⓔⓡ?: ditto
  • ⓙⓗⓐⓨ-ⓑ: ditto
  • ⓛⓞⓛⓟⓔⓝⓘⓢ: ditto
  • ⓜⓐⓢⓓⓙⓘⓓⓧⓓⓖⓥ: ditto
  • ⓣⓐⓝⓙⓘⓜⓐⓖⓞ: ditto
  • ff: ditto
  • fi: ditto
  • fireworkeaterr: ditto
  • fl: ditto
  • ffi: ditto
  • ffl: ditto
  • ſtinky: ditto
Oct 26 2022, 10:32 PM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.

Trying to clean up the remaining stuck renames with

Oct 26 2022, 5:27 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.

I used attachAccount.php to reattach the remaining Ⓝⓘⓙⓦⓜ accounts.

Oct 26 2022, 4:51 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.

I reinserted the 14 ⓝⓘⓙⓦⓜ -> Ⓝⓘⓙⓦⓜ rows into renameuser_status that I previously deleted, and I ran fixStuckGlobalRename.php for all of them. Now there's no local ⓝⓘⓙⓦⓜ accounts remaining, but there are still 239 unattached Ⓝⓘⓙⓦⓜ accounts.

Oct 26 2022, 4:46 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.

I deduplicated the user rename list by destination name, although this misses some users due to different users being renamed to the same name.

Oct 26 2022, 4:22 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.

The script is still running.

Oct 26 2022, 2:54 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling closed T321419: Flaky test RevisionStoreDbTest::testNewRevisionFromRow_getQueryInfo as Resolved.

Should be fixed.

Oct 26 2022, 1:48 AM · Performance-Team, MW-1.40-notes (1.40.0-wmf.8; 2022-10-31), ci-test-error, MediaWiki-Core-Revision-backend
tstarling added a comment to T307816: Installing Mediawiki: Error: Class "FormatJson" not found.

opcache will only read a file if its timestamp has changed, so it is possible to engineer a situation where opcache permanently has the wrong file contents, due to the file being updated without its timestamp being updated. But it's unclear to me how that could happen during a MediaWiki update. Note that FormatJson.php existed in MW 1.35 and it had the relevant class in it.

Oct 26 2022, 1:42 AM · PHP 8.1 support, MediaWiki-Installer

Oct 25 2022

hashar awarded T315270: PHP discrete event simulator a Love token.
Oct 25 2022, 9:00 AM · MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Patch-For-Review, Sustainability (Incident Followup), MediaWiki-libs-Rdbms, Performance-Team
tstarling added a comment to T316078: Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries).

Is this fixed? It looks fixed.

Oct 25 2022, 7:11 AM · Patch-For-Review, Continuous-Integration-Config, PHP 8.1 support
tstarling merged T314211: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated into T313663: Failing phpunit tests on php8.1.
Oct 25 2022, 7:04 AM · MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), MW-1.39-notes, MW-1.37-notes, MW-1.38-notes, MW-1.35-notes, Patch-For-Review, MediaWiki-Core-Tests, PHP 8.1 support
tstarling merged task T314211: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated into T313663: Failing phpunit tests on php8.1.
Oct 25 2022, 7:04 AM · MediaWiki-Core-Tests, PHP 8.1 support, MediaWiki-General
tstarling added a comment to T314211: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated.

Was apparently fixed in I51fe4c54832914055a624d94ad1a1c2720b23ec9 T313663

Oct 25 2022, 7:03 AM · MediaWiki-Core-Tests, PHP 8.1 support, MediaWiki-General
tstarling closed T315202: Exif passing null to preg_match() as Resolved.
Oct 25 2022, 6:51 AM · MW-1.40-notes (1.40.0-wmf.8; 2022-10-31), Commons, MediaWiki-File-management, PHP 8.1 support
tstarling merged T317149: BagOStuff.php:731 strtr(): Passing null to parameter #1 ($string) of type string is deprecated into T313663: Failing phpunit tests on php8.1.
Oct 25 2022, 6:26 AM · MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), MW-1.39-notes, MW-1.37-notes, MW-1.38-notes, MW-1.35-notes, Patch-For-Review, MediaWiki-Core-Tests, PHP 8.1 support
tstarling merged task T317149: BagOStuff.php:731 strtr(): Passing null to parameter #1 ($string) of type string is deprecated into T313663: Failing phpunit tests on php8.1.
Oct 25 2022, 6:25 AM · Performance-Team (Radar), MW-1.35-release, MW-1.38-release, MW-1.37-release, MW-1.39-release, MediaWiki-libs-ObjectCache, PHP 8.1 support
tstarling added a comment to T317149: BagOStuff.php:731 strtr(): Passing null to parameter #1 ($string) of type string is deprecated.
Oct 25 2022, 6:25 AM · Performance-Team (Radar), MW-1.35-release, MW-1.38-release, MW-1.37-release, MW-1.39-release, MediaWiki-libs-ObjectCache, PHP 8.1 support
tstarling added a comment to T314210: strtr(): Passing null to parameter #1 ($string) of type string is deprecated.

I'm closing this because if we're fixing it case-by-case then we will need backtraces for any other instances, a generic bug doesn't help.

Oct 25 2022, 5:44 AM · PHP 8.1 support, Performance-Team, MediaWiki-libs-ObjectCache
tstarling merged T314210: strtr(): Passing null to parameter #1 ($string) of type string is deprecated into T313663: Failing phpunit tests on php8.1.
Oct 25 2022, 5:43 AM · MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), MW-1.39-notes, MW-1.37-notes, MW-1.38-notes, MW-1.35-notes, Patch-For-Review, MediaWiki-Core-Tests, PHP 8.1 support
tstarling merged task T314210: strtr(): Passing null to parameter #1 ($string) of type string is deprecated into T313663: Failing phpunit tests on php8.1.
Oct 25 2022, 5:42 AM · PHP 8.1 support, Performance-Team, MediaWiki-libs-ObjectCache
tstarling added a comment to T314210: strtr(): Passing null to parameter #1 ($string) of type string is deprecated.

That stack trace was fixed in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/831233, linking to T313663, and that task lists various other cases which were fixed. I wouldn't mind just casting to string in BagOStuff but it was already fixed case-by-case, at least in core.

Oct 25 2022, 5:42 AM · PHP 8.1 support, Performance-Team, MediaWiki-libs-ObjectCache
tstarling closed T320726: Fix RandomImageGenerator as used in tests to work on PHP 8.1 without errors or warnings, a subtask of T319065: All Wikimedia production extensions and skins must support PHP 8.1, as Resolved.
Oct 25 2022, 5:00 AM · MediaWiki-extensions-General, PHP 8.1 support
tstarling closed T320726: Fix RandomImageGenerator as used in tests to work on PHP 8.1 without errors or warnings as Resolved.

Reproduced, confirmed the fix

Oct 25 2022, 5:00 AM · MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), MediaWiki-Core-Tests, PHP 8.1 support
tstarling updated subscribers of T321419: Flaky test RevisionStoreDbTest::testNewRevisionFromRow_getQueryInfo.

Forcing a miss reproduces the test error.

Oct 25 2022, 2:19 AM · Performance-Team, MW-1.40-notes (1.40.0-wmf.8; 2022-10-31), ci-test-error, MediaWiki-Core-Revision-backend
tstarling added a comment to T321419: Flaky test RevisionStoreDbTest::testNewRevisionFromRow_getQueryInfo.

In the debug log from https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php74-docker/13035/ :

Oct 25 2022, 1:52 AM · Performance-Team, MW-1.40-notes (1.40.0-wmf.8; 2022-10-31), ci-test-error, MediaWiki-Core-Revision-backend

Oct 24 2022

tstarling updated the task description for T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.
Oct 24 2022, 10:32 PM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops

Oct 21 2022

tstarling closed T314090: RestrictionStore::loadRestrictions is racey and seems likely to cache old data as Resolved.

The fix was merged a month ago, and I'm not seeing the test failure, so I assume this is resolved.

Oct 21 2022, 1:56 AM · Patch-For-Review, PHP 8.1 support, MediaWiki-User-management
tstarling added a comment to T317149: BagOStuff.php:731 strtr(): Passing null to parameter #1 ($string) of type string is deprecated.

We could support null and false in makeKey() if we wanted to. Are we protecting callers from their own errors or just nitpicking?

Oct 21 2022, 12:25 AM · Performance-Team (Radar), MW-1.35-release, MW-1.38-release, MW-1.37-release, MW-1.39-release, MediaWiki-libs-ObjectCache, PHP 8.1 support

Oct 20 2022

tstarling added a comment to T320864: Incorrect email headers using PHP mail in PHP 8.0.

Hi @Anomie, how's it going?

Oct 20 2022, 6:02 AM · MW-1.35-notes, MW-1.39-notes, MW-1.38-notes, MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), MediaWiki-Email, Infrastructure-Foundations, PHP 8.2 support, PHP 8.1 support, PHP 8.0 support, Mail

Oct 18 2022

tstarling added a comment to T320335: Rename match() method.

I filed https://github.com/microsoft/tolerant-php-parser/issues/392

Oct 18 2022, 7:10 AM · phan, PHP 8.0 support, Technical-Debt, IPSet
tstarling closed T260735: Stop using is_resource() as Resolved.

This is fixed in core and deployed extensions.

Oct 18 2022, 5:49 AM · MW-1.36-notes, MW-1.37-notes, MW-1.35-notes, MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), wdwb-tech, Upstream, PHP 8.1 support, Wikidata, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-Html2Wiki, MediaWiki-extensions-QuickGV, MediaWiki-General, PHP 8.0 support
tstarling added a comment to T261462: Migrate away from wikimedia/oauth2-server fork to upstream.

The other option is to fully fork it. Change the name, update the readme, register it in packagist.

Oct 18 2022, 5:43 AM · Technical-Debt, Platform Team Workboards (Green), Platform Team Initiatives (API Gateway), Upstream
tstarling added a comment to T320282: PHP Warning: XMLReader::open(): URI must not contain percent-encoded NUL bytes.

I confirmed with eval.php that the null byte warning still happens 0.8.4. My fix is linked above.

Oct 18 2022, 5:21 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), PHP 8.0 support, PHP 8.1 support, PHP 7.4 support, XMPReader, MediaWiki-Uploading, Commons, Wikimedia-production-error

Oct 16 2022

tstarling updated the task description for T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.
Oct 16 2022, 9:30 PM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.

I notified those 8 users via their user talk pages. I also sent ⓝⓘⓙⓦⓜ an email.

Oct 16 2022, 9:29 PM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops

Oct 14 2022

tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.

The list of affected pages and users is at https://meta.wikimedia.org/wiki/Unicode_11_case_map_migration

Oct 14 2022, 6:40 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling updated the task description for T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.
Oct 14 2022, 6:40 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling renamed T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11 from Rename articles and users to prepare for PHP 7.4 unicode changes to Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.
Oct 14 2022, 2:14 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling renamed T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11 from Rename articles and users to prepare for PHP 7.3 unicode changes to Rename articles and users to prepare for PHP 7.4 unicode changes.
Oct 14 2022, 2:13 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to P35451 ucfirst-72-to-title.php.

Edit: fixed accidental use of PHP 8.0 in the destination array. Now it is actually PHP 7.4.

Oct 14 2022, 1:32 AM
tstarling edited P35451 ucfirst-72-to-title.php.
Oct 14 2022, 1:30 AM

Oct 13 2022

tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.

I added the Eszett override to the proposed Gerrit change.

Oct 13 2022, 3:49 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling edited P35451 ucfirst-72-to-title.php.
Oct 13 2022, 3:44 AM
tstarling created P35451 ucfirst-72-to-title.php.
Oct 13 2022, 3:42 AM
tstarling added a comment to T292824: {{ucfirst:$1}} have different capitalization in PHP and in JavaScript.

If I am reading the intent of T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11 right, PHP will and must instead go the other way.

Oct 13 2022, 2:55 AM · MediaWiki-Internationalization, I18n

Oct 12 2022

tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.

That reduced the number of user renames to 441, of which 370 are for decorative Eszett (ß) characters (ßlackHeart, ßrandon, etc.). The number of page renames was reduced to 912, of which 124 begin with Eszett.

Oct 12 2022, 11:39 PM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to T320335: Rename match() method.

Are you sure this is not just a phan bug?

Oct 12 2022, 11:16 PM · phan, PHP 8.0 support, Technical-Debt, IPSet
tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.

I removed the Georgian characters from Pchelolo's case map, and I'm running the dry run script again.

Oct 12 2022, 11:01 PM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.

The script would rename 306,244 out of 462,201 pages on kawiki. I'm pretty sure we shouldn't go ahead with that.

Oct 12 2022, 10:43 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.

There's 11584 global users to be renamed, which is a lot. Most of them are in the Georgian script -- the change is apparently not desirable and may need to be permanently overridden. Wikipedia says "Nowadays, Mtavruli is typically used in all-caps text in titles or to emphasize a word, though in the late 19th and early 20th centuries it was occasionally used, as in Latin and Cyrillic scripts, to capitalize proper nouns or the first word of a sentence." Using these letters for title case is not correct.

Oct 12 2022, 10:16 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11.

I'm trying a dry run. But the proposed suffix "former Unicode character" seems weird. I think I would prefer something more technical and technically correct.

Oct 12 2022, 6:34 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Patch-For-Review, PHP 7.4 support, PHP 7.3 support, Platform Team Workboards (Clinic Duty Team), serviceops
tstarling added a comment to T308017: Design Schema for page state and page state with content (enriched) streams.

I think is_temp is fine. I don't think it's future-proof to add user_type since if we decide we want such a concept in MW core, the details may differ from what you decide on here.

Oct 12 2022, 4:53 AM · Event-Platform Value Stream, Data-Engineering, Patch-For-Review

Oct 11 2022

tstarling added a comment to T319685: Work out if we can use non forked league/oauth2-server in REL1_XX branches.

17:50:01 Error: Interface 'League\OAuth2\Server\Repositories\ClaimRepositoryInterface' not found

Oct 11 2022, 6:32 AM · Patch-For-Review, MW-1.39-release, MW-1.38-release, Technical-Debt, MediaWiki-extensions-OAuth