Page MenuHomePhabricator

tstarling (Tim Starling)
UserAdministrator

Projects (17)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 8:27 PM (230 w, 5 d)
Roles
Administrator
Availability
Available
LDAP User
Tim Starling
MediaWiki User
Tim Starling (WMF) [ Global Accounts ]

Recent Activity

Sat, Mar 16

dbarratt awarded T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL a Love token.
Sat, Mar 16, 2:25 PM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations
tstarling edited projects for T218135: +2 in mediawiki/* for WMDE engineers, added: MediaWiki-Gerrit-Group-Requests; removed Repository-Ownership-Requests.
Sat, Mar 16, 1:59 AM · MediaWiki-Gerrit-Group-Requests
tstarling edited projects for T218362: +2 for Ciencia Al Poder in mediawiki/tools/grabbers, added: Gerrit-Privilege-Requests; removed Repository-Ownership-Requests.
Sat, Mar 16, 1:58 AM · Gerrit-Privilege-Requests, Utilities-grabbers
tstarling archived Repository-Ownership-Requests.
Sat, Mar 16, 1:58 AM

Thu, Mar 14

TerraCodes awarded T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL a Dislike token.
Thu, Mar 14, 7:31 AM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations
tstarling added a comment to T217850: Remex could use some helper/utility classes.

I punted on this originally, hoping that once we had some users, we would know what pipelines are most commonly used and thus need shortcuts to access them. But last time I checked, I think everyone was using a different pipeline. Maybe we need a pipeline builder class, with chainable mutator methods and sensible defaults, so that even diverse use cases can be catered for. A possibly complimentary option is to have local convenience functions, so that the kind of pipeline Parsoid generally needs would be provided by a utility class within Parsoid.

Thu, Mar 14, 12:01 AM · RemexHtml

Wed, Mar 13

tstarling edited projects for T193049: Make MGChecker maintainer of Extension:LanguageTag & InteractiveBlockMessage, added: Gerrit-Privilege-Requests; removed Repository-Ownership-Requests.
Wed, Mar 13, 4:37 AM · Gerrit-Privilege-Requests
tstarling edited projects for T212452: Requesting repository ownership : Push, added: Gerrit-Privilege-Requests; removed Repository-Ownership-Requests.
Wed, Mar 13, 4:36 AM · Gerrit-Privilege-Requests
tstarling set the color for MediaWiki-Gerrit-Group-Requests to Violet.
Wed, Mar 13, 4:36 AM
tstarling set the icon for Gerrit-Privilege-Requests to Group.
Wed, Mar 13, 4:35 AM
tstarling edited projects for T214618: Requesting repository ownership for /mediawiki/extensions/OdbcDatabase, added: Gerrit-Privilege-Requests; removed Repository-Ownership-Requests.
Wed, Mar 13, 4:33 AM · Gerrit-Privilege-Requests
tstarling created Gerrit-Privilege-Requests.
Wed, Mar 13, 4:15 AM
tstarling created MediaWiki-Gerrit-Group-Requests.
Wed, Mar 13, 4:13 AM
tstarling moved T191231: RFC: Abstract schemas and schema changes from Request IRC meeting to Under discussion on the TechCom-RFC board.
Wed, Mar 13, 2:23 AM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
tstarling moved T217158: RFC: Skin templating from Under discussion to Request IRC meeting on the TechCom-RFC board.

That said, I think the proposal is ready for an IRC meeting to finish discussing it. There are still some unresolved things such as how to handle caching of skins, which I can't entirely qualify by myself.

Wed, Mar 13, 2:16 AM · TechCom-RFC

Sun, Mar 10

tstarling created T218000: Set up CI for wikipeg.
Sun, Mar 10, 11:08 PM · Patch-For-Review, Continuous-Integration-Config

Sat, Mar 9

Platonides awarded T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL a Like token.
Sat, Mar 9, 9:40 PM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations

Thu, Mar 7

tstarling added a comment to T217708: Remex should offer an option to not set namespaceURI.

Element namespaces are specified in detail in the HTML 5 parsing spec, and are required for compliance, in order to support MathML and SVG fragments embedded in HTML. Elements with the same tag name can have different content models depending on the namespace they are in. But once the element comes out of TreeBuilder you are free to throw away whatever you like.

Thu, Mar 7, 12:30 AM · Patch-For-Review, RemexHtml
tstarling added a comment to T217708: Remex should offer an option to not set namespaceURI.

I don't think it needs to be refactored. You can just have an option to DOMBuilder which tells it to ignore namespaces. TreeBuilder needs to keep track of namespaces, and it stores them in Element objects, but Element objects are just temporary state, there is no requirement for DOMBuilder to retain the information from Element.

Thu, Mar 7, 12:16 AM · Patch-For-Review, RemexHtml

Mon, Mar 4

D3r1ck01 awarded T166010: The Great Namespaceization and Reorg a 100 token.
Mon, Mar 4, 5:41 PM · TechCom, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), Epic, TechCom-RFC
Ladsgroup awarded T166010: The Great Namespaceization and Reorg a Love token.
Mon, Mar 4, 5:38 PM · TechCom, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), Epic, TechCom-RFC

Wed, Feb 27

Ladsgroup awarded T176370: Migrate to PHP 7 in WMF production a Love token.
Wed, Feb 27, 12:29 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations

Mon, Feb 18

tstarling created P8102 https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/490564/.
Mon, Feb 18, 10:30 AM

Feb 11 2019

tstarling added a comment to T209565: Dry run for normalizeThrottleParameters.php.
arwiki:  Throttle count and period are malformed or empty for the following filters: 66, 96. Please fix them by hand in the way they're meant to be, then launch the script again.
cawiki:  normalizeThrottleParameter has found 1 rows to change in abuse_filter_action for the following IDs: 9
cawiki:  normalizeThrottleParameter would insert 1 rows in abuse_filter_history for the following filters: 9
cawiki:  Throttle parameter normalization would change a total of 2 rows.
cawikinews:  normalizeThrottleParameter has found 1 rows to change in abuse_filter_action for the following IDs: 15
cawikinews:  normalizeThrottleParameter would insert 1 rows in abuse_filter_history for the following filters: 15
cawikinews:  Throttle parameter normalization would change a total of 2 rows.
dawiki:  Throttle groups are empty for the following filters: 5. Please add some groups or disable throttling, then launch the script again.
glwiki:  Throttle groups are empty for the following filters: 15. Please add some groups or disable throttling, then launch the script again.
mrwiki:  Throttle count and period are malformed or empty for the following filters: 9. Please fix them by hand in the way they're meant to be, then launch the script again.
rowiki:  Throttle groups are empty for the following filters: 67. Please add some groups or disable throttling, then launch the script again.
trwiki:  normalizeThrottleParameter has found 5 rows to change in abuse_filter_action for the following IDs: 37, 46, 47, 48, 50
trwiki:  normalizeThrottleParameter would insert 5 rows in abuse_filter_history for the following filters: 37, 46, 47, 48, 50
trwiki:  Throttle parameter normalization would change a total of 10 rows.
ukwiki:  Throttle groups are empty for the following filters: 29, 30, 53. Please add some groups or disable throttling, then launch the script again.
Feb 11 2019, 4:37 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-notice, Patch-For-Review, MW-1.32-release, Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Wikimedia-maintenance-script-run, AbuseFilter

Feb 8 2019

tstarling added a comment to T209565: Dry run for normalizeThrottleParameters.php.

Thanks for all your work on this, @Daimona. If the number of unfixable filters is small (<50) then I would be inclined to fix them manually, since changing the script takes a while, and a bug in the script could cause data corruption. Also, I don't think you should do do any more performance optimisations on this script, since the time it takes to write and review them is presumably much larger than the amount of time they will save. IIRC the script only takes a second or two per wiki.

Feb 8 2019, 2:19 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-notice, Patch-For-Review, MW-1.32-release, Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Wikimedia-maintenance-script-run, AbuseFilter

Feb 7 2019

tstarling committed rMSCA070c0a5e181c: Run rebuildLocalisationCache.php as www-data (authored by tstarling).
Run rebuildLocalisationCache.php as www-data
Feb 7 2019, 12:10 PM
tstarling committed rMSCA68d383989ed8: Run rebuildLocalisationCache.php as www-data (authored by tstarling).
Run rebuildLocalisationCache.php as www-data
Feb 7 2019, 12:10 PM
tstarling committed rMSCAbe440b59f182: Run rebuildLocalisationCache.php as www-data (authored by tstarling).
Run rebuildLocalisationCache.php as www-data
Feb 7 2019, 12:10 PM
tstarling committed rMSCA4c13bbdf058f: Run rebuildLocalisationCache.php as www-data (authored by tstarling).
Run rebuildLocalisationCache.php as www-data
Feb 7 2019, 12:10 PM

Feb 6 2019

tstarling reopened T202322: Draft a proposal for multiblocks table schema(s) and get consensus as "Open".

Reopening and untagging Anti-Harrassment per T202673#4933221 : a task should be left open if it is a good idea but there is no resourcing.

Feb 6 2019, 10:14 PM · MediaWiki-User-management
tstarling reopened T202322: Draft a proposal for multiblocks table schema(s) and get consensus, a subtask of T204903: Epic ⚡️ unprioritized Partial Blocks features, as Open.
Feb 6 2019, 10:14 PM · Anti-Harassment
tstarling reopened T194697: Multiblocks — Allow for multiple, simultaneously blocks with different expiration dates. as "Open".

Reopening and untagging Anti-Harrassment per T202673#4933221 : a task should be left open if it is a good idea but there is no resourcing.

Feb 6 2019, 10:14 PM · MediaWiki-User-management
tstarling reopened T194697: Multiblocks — Allow for multiple, simultaneously blocks with different expiration dates., a subtask of T204903: Epic ⚡️ unprioritized Partial Blocks features, as Open.
Feb 6 2019, 10:14 PM · Anti-Harassment
tstarling reopened T202673: RFC: Multiblocks - let admins create multiple, overlapping blocks on a single user as "Open".

We discussed this in TechCom: we think that it's not correct to decline a task for lack of resourcing. The "declined" status means that the change would be rejected for merging even if the work were somehow completed and submitted to Gerrit. See Bug management/Bug report life cycle. Roan mentioned that the anti-harrassment team does not want to "own" the blocking component or be responsible for future work in this area — if this is correct then the anti-harrassment team should also disclaim control over resourcing of work on blocking.

Feb 6 2019, 10:11 PM · TechCom-RFC

Feb 5 2019

tstarling added a comment to T215000: Fill gaps in PHP DOM's functionality.

Doesn't T204608#4925526 affect this?

Feb 5 2019, 11:10 PM · Patch-For-Review, Parsoid-PHP
tstarling added a comment to T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL.

It complicates SEO in the sense that, when I wrote this task, I was looking at Google Search Console for a few of our domains with an eye towards SEO for sister projects, and found that mobile traffic was split 50/50 between the dashboards for the m and non-m subdomains. So it was hard to draw any conclusions without manually aggregating the data.

Feb 5 2019, 11:03 PM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations
tstarling added a comment to T215000: Fill gaps in PHP DOM's functionality.

body property on the DOMDocument

Feb 5 2019, 10:58 PM · Patch-For-Review, Parsoid-PHP

Feb 2 2019

Kaartic awarded T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL a Love token.
Feb 2 2019, 4:07 AM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations

Jan 31 2019

tstarling added a comment to T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL.

If you add some redirection, add a way to circumvent it please (via some specific query?). Right now testing for mobile version involves just changing a domain, with this proposal it would involve changing a user agent string which is much harder to explain to people (and impossible to link to, in fact).

Jan 31 2019, 8:11 PM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations
Addshore awarded T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL a Orange Medal token.
Jan 31 2019, 6:00 PM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations
tstarling added a comment to T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL.

My problem is that you are making fun of MobileFrontend, and by implication, the engineers who designed MobileFrontend, who may well be reading your comments. Please note that Phabricator comments are subject to a Code of Conduct — discussion here is held to a higher standard of civility than on a Wikipedia talk page.

Jan 31 2019, 9:34 AM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations
tstarling added a comment to T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL.

Yeah, very funny. In case it needs to be said, your comment was an attempt to support my proposal by reductio ad absurdum, via a reference to the CSS 2.1 media types, following on from your previous comment that CSS has existed since 1998. But @media is off topic, since the mobile website differs significantly from the desktop website in ways that cannot efficiently be dealt with in CSS. See for example MobileFormatter. I'm not proposing to remove MobileFormatter or to somehow merge the mobile and desktop skins so that they differ only by CSS. I'm an advocate for responsive design, but that's a big project and a very long way off topic from what I'm proposing here.

Jan 31 2019, 8:59 AM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations
tstarling added a comment to T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL.

Alternate proposal: create

  • [langcode].braille.[project].org
Jan 31 2019, 8:12 AM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations
Legoktm awarded T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL a Love token.
Jan 31 2019, 6:13 AM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations
Krinkle awarded T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL a Orange Medal token.
Jan 31 2019, 1:08 AM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations
Krenair awarded T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL a Mountain of Wealth token.
Jan 31 2019, 12:43 AM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations
Harej awarded T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL a Love token.
Jan 31 2019, 12:42 AM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations
tstarling created T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL.
Jan 31 2019, 12:19 AM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations

Jan 22 2019

tstarling added a comment to T40432: Uploading MS Word files doesn't work ("File extension does not match the detected MIME type of the file").

I added a CFB directory reader as a new patchset to the existing change. It should hopefully fix the issue, and any other failures to identify old MS Office files.

Jan 22 2019, 1:25 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Multimedia, MediaWiki-Uploading

Jan 21 2019

tstarling added a comment to T40432: Uploading MS Word files doesn't work ("File extension does not match the detected MIME type of the file").

To make things extra complicated, we do actually have some MS Office file type detection code in MimeAnalyzer, but it is only triggered when there is an EOCDR in the last 64KB of the file. It fails to detect the type of the ICD_3_1.xls file, so that file is detected as application/zip, based on the misplaced EOCDR. It identifies Test.doc correctly, so it gives a type of application/msword for that file. But if we fix the ZIP detection code to only detect actual ZIP files, then it fails for both test cases.

Jan 21 2019, 5:36 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Multimedia, MediaWiki-Uploading

Jan 18 2019

tstarling added a comment to T40432: Uploading MS Word files doesn't work ("File extension does not match the detected MIME type of the file").

OK, now that I have looked at the test cases, I see that I misdiagnosed the issue. The test cases are not ODF/ZIP files deviating from the spec, they are both OLE compound binary files with embedded ZIP files. The ZIP signature triggers ZIP detection when it is seen less than 64KB from the end. Since the only thing that really identifies a ZIP file is the EOCDR occurring exactly at the end of the file, we could instead treat the "trailing bytes" error as indicating that the file is not a ZIP file.

Jan 18 2019, 5:43 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Multimedia, MediaWiki-Uploading

Jan 16 2019

RandomDSdevel awarded T209565: Dry run for normalizeThrottleParameters.php a Grey Medal token.
Jan 16 2019, 5:56 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-notice, Patch-For-Review, MW-1.32-release, Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Wikimedia-maintenance-script-run, AbuseFilter
RandomDSdevel awarded T212268: Make the abusefilter-blocker user not be a sysop a Piece of Eight token.
Jan 16 2019, 5:55 PM · AbuseFilter, User-Daimona, Patch-For-Review

Jan 15 2019

tstarling added a comment to T40432: Uploading MS Word files doesn't work ("File extension does not match the detected MIME type of the file").

You can apply the patch and test it. ZipDirectoryReader has changed very little since I introduced it in February 2011 to fix T26230. Based on the quoted debug log snippets, the issue is that Microsoft has extended the end of central directory record, adding new fields to the end of it. When I wrote ZipDirectoryReader, I had it flag any deviation from the ZIP specification as an error, since that seemed to be the safest way to flag potentially malicious files. For example, it is possible to deviate from the spec in ways that make files visible to one ZIP library but invisible to another. But extending the EOCDR does not help an attacker in any obvious way, so this particular error is needlessly paranoid. That's why I propose removing it in my patch.

Jan 15 2019, 5:03 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Multimedia, MediaWiki-Uploading
tstarling added a comment to T40432: Uploading MS Word files doesn't work ("File extension does not match the detected MIME type of the file").

I can't recall having seen this bug before. It is the simplest thing to fix. The patch is untested but probably works. Sorry @Pavel.petrovic, I don't know why it has taken so long.

Jan 15 2019, 3:29 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Multimedia, MediaWiki-Uploading

Dec 19 2018

tstarling added a comment to T209565: Dry run for normalizeThrottleParameters.php.

Ran it again:

Dec 19 2018, 1:58 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-notice, Patch-For-Review, MW-1.32-release, Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Wikimedia-maintenance-script-run, AbuseFilter
tstarling added a comment to T209565: Dry run for normalizeThrottleParameters.php.

Thanks for your feedback, @Stryn and @Pxos. I filed T212268 for the problem of automatically created sysop users. Please put any further discussion on that task.

Dec 19 2018, 12:24 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-notice, Patch-For-Review, MW-1.32-release, Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Wikimedia-maintenance-script-run, AbuseFilter
tstarling created T212268: Make the abusefilter-blocker user not be a sysop.
Dec 19 2018, 12:21 AM · AbuseFilter, User-Daimona, Patch-For-Review

Dec 17 2018

tstarling added a comment to T209565: Dry run for normalizeThrottleParameters.php.

It would be convenient if the script would report all malformed throttle rows, instead of stopping on the first one. Or maybe we could think of some way automatically deal with the bad rows, since there seems to be quite a lot. For example, disabling the throttle and generating a report for admins to check later.

Dec 17 2018, 5:08 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-notice, Patch-For-Review, MW-1.32-release, Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Wikimedia-maintenance-script-run, AbuseFilter

Dec 14 2018

tstarling closed T207530: Deleting pages on the English Wikipedia is very slow as Resolved.
Dec 14 2018, 5:22 AM · Performance-Team (Radar), MW-1.32-release, Operations, MediaWiki-Page-deletion
tstarling triaged T211953: LiquidThreads deletion fails due to unindexed DELETE query as High priority.
Dec 14 2018, 5:21 AM · Schema-change, Performance, MediaWiki-extensions-LiquidThreads
tstarling added a comment to T207530: Deleting pages on the English Wikipedia is very slow.

@Krinkle's test case appears to be unrelated, although it is a bug. I filed T211953 for it.

Dec 14 2018, 5:18 AM · Performance-Team (Radar), MW-1.32-release, Operations, MediaWiki-Page-deletion
tstarling created T211953: LiquidThreads deletion fails due to unindexed DELETE query.
Dec 14 2018, 5:18 AM · Schema-change, Performance, MediaWiki-extensions-LiquidThreads

Dec 11 2018

tstarling added a comment to T209981: Confirm that post-send functions work fine with mediawiki under PHP 7.

@Krinkle, by corruption, do you just mean things like aborted LinksUpdate operations as in T201482? PHP timeouts are expected to break things, the main solution should be to make things be fast enough or to increase the timeout. It seems to me that a missed LinksUpdate would not be a failure mode so severe as to be a blocker for PHP 7 deployment.

Dec 11 2018, 3:06 AM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), PHP 7.0 support

Dec 6 2018

tstarling added a comment to T206152: Set up request debug profiling for PHP 7.

Please install tideways, but it should only be enabled in php.ini on the debug servers, since it will cause a performance degradation even without being used. Also, please install php-mongodb, the PHP driver for MongoDB, since this is recommended for XHGui saving on PHP 7. I am working on the mediawiki-config patch which will use these extensions.

Dec 6 2018, 11:50 PM · Performance-Team, MediaWiki-Debug-Logger, Operations

Dec 4 2018

Michael awarded T176370: Migrate to PHP 7 in WMF production a Love token.
Dec 4 2018, 12:17 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations
RandomDSdevel awarded T71237: Use of SVG nominal size in MMV a Haypence token.
Dec 4 2018, 2:48 AM · User-notice, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Google-Code-in-2018, Multimedia, good first bug, MediaWiki-extensions-MultimediaViewer
tstarling added a comment to T210567: Create a way to intentionally trigger fatal errors in MediaWiki.
  • create a new directory under operations/mediawiki-config/ where this script, and potentially any other such script can reside. This way, it will be easier to restrict access from the normal virtual host and to create an ad-hoc one for such requests.
Dec 4 2018, 2:29 AM · serviceops, User-Joe, Core Platform Team Kanban (Done with CPT), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support

Dec 3 2018

MichaelSchoenitzer_WMDE awarded T71237: Use of SVG nominal size in MMV a Love token.
Dec 3 2018, 8:00 PM · User-notice, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Google-Code-in-2018, Multimedia, good first bug, MediaWiki-extensions-MultimediaViewer
CKoerner_WMF awarded T71237: Use of SVG nominal size in MMV a Love token.
Dec 3 2018, 4:19 PM · User-notice, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Google-Code-in-2018, Multimedia, good first bug, MediaWiki-extensions-MultimediaViewer

Dec 2 2018

tstarling added a comment to T210567: Create a way to intentionally trigger fatal errors in MediaWiki.

Maybe I'm missing something, but how do you intentionally cause PHP to segfault? Shouldn't any code that triggers a segfault be a PHP bug that should/would be reported upstream?

Dec 2 2018, 7:56 AM · serviceops, User-Joe, Core Platform Team Kanban (Done with CPT), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support

Nov 30 2018

jcrespo awarded T176370: Migrate to PHP 7 in WMF production a Love token.
Nov 30 2018, 3:21 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations
tstarling added a comment to T205059: Excimer: new profiler for PHP.

Also, the zend_interrupt_function hook is only called after the internal function returns to the VM, at which point it is not in the stack anymore. At best you would only see functions that re-enter the VM, like array_map(). So it would be misleading.

Nov 30 2018, 4:29 AM · serviceops, Core Platform Team (PHP7 (TEC4)), Excimer, Core Platform Team Kanban (Doing), Performance-Team (Radar), PHP 7.1 support

Nov 28 2018

tstarling added a comment to T205059: Excimer: new profiler for PHP.

@Joehoyle: internal functions were just skipped for simplicity. We configure xhprof to skip them, so we presumably don't need that feature for production. Finding the function name for an internal function requires a few more lines of code. So I guess it depends on how much you want them.

Nov 28 2018, 10:05 AM · serviceops, Core Platform Team (PHP7 (TEC4)), Excimer, Core Platform Team Kanban (Doing), Performance-Team (Radar), PHP 7.1 support

Nov 26 2018

tstarling added a comment to T150826: Remove unblockself right on wikimedia wikis (but allow blocked admins to block their blocker).

I think we should remove unblockself on all Wikimedia wikis, and see if it helps with vandalism by compromised admin accounts like T210192. In the case of Killiondude, the compromised admin account was blocked after 2 minutes, but unblocked itself twice and thus was able to carry on vandalising for an additional 2 minutes prior to a steward-imposed global lock.

Nov 26 2018, 3:19 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-User-management, User-notice, Community-consensus-needed, Wikimedia-Site-requests

Nov 21 2018

tstarling updated the task description for T54921: Database tables to be dropped on Wikimedia wikis and other WMF databases (tracking).
Nov 21 2018, 5:22 AM · Epic, DBA, Tracking
tstarling added a comment to T54921: Database tables to be dropped on Wikimedia wikis and other WMF databases (tracking).

@tstarling As a background task for myself I am slowly cleaning up all the tables listed here to be removed, so they don't pile up much.

I was checking this comment

bv2011_edits.ibd	E:SecurePoll	@tstarling	Yes		
bv2015_edits.ibd	E:SecurePoll	@tstarling	Yes

Those can be removed but they do not have a task for them, if you double confirm they can be killed, I will create a task for those and link them here.

Nov 21 2018, 5:21 AM · Epic, DBA, Tracking
tstarling added a comment to T147146: Text of many early edits missing to Massachusetts article on the English Wikipedia.

Deletion of articles with CGZ compression was not supposed to be possible after r6640 (a7371b7228aeb4891c3352f783591a169bce0704), which should have been active at the time of this deletion. I don't know why/how the deletion succeeded.

Nov 21 2018, 3:26 AM · Wikimedia-General-or-Unknown, MediaWiki-History-and-Diffs

Nov 20 2018

tstarling added a comment to T199332: PHP Warning: count(): Parameter must be an array or an object that implements Countable in Serializer.php.

OK, but there would have been a notice as well, and probably broken output, regardless of PHP version.

Nov 20 2018, 11:52 AM · Core Platform Team Kanban (Blocked Externally), Core Platform Team (Security, stability, performance and scalability (TEC1)), RemexHtml
tstarling added a comment to T147146: Text of many early edits missing to Massachusetts article on the English Wikipedia.

As I noted on the community wishlist page, IA has a dump from December 23, 2004. I think it may be our best bet for the majority of these revisions.

Nov 20 2018, 4:54 AM · Wikimedia-General-or-Unknown, MediaWiki-History-and-Diffs
tstarling triaged T147146: Text of many early edits missing to Massachusetts article on the English Wikipedia as Low priority.

There is some regularity for ealier versions: the history page shows that every 20th version is accessible (exactly 19 versions lost between accessible ones).
And this regularity looks strange: was there some database partition between 20 database files or so? (And 19 of them being lost?)

Nov 20 2018, 4:33 AM · Wikimedia-General-or-Unknown, MediaWiki-History-and-Diffs
tstarling created P7827 T147146 revision and text tables.
Nov 20 2018, 4:13 AM
tstarling triaged T199332: PHP Warning: count(): Parameter must be an array or an object that implements Countable in Serializer.php as Low priority.

Removing PHP 7 projects since it does not appear to be a PHP 7 migration issue, it's a RemexHtml issue which was observed on PHP 7.

Nov 20 2018, 2:58 AM · Core Platform Team Kanban (Blocked Externally), Core Platform Team (Security, stability, performance and scalability (TEC1)), RemexHtml
tstarling claimed T209565: Dry run for normalizeThrottleParameters.php.
Nov 20 2018, 1:32 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-notice, Patch-For-Review, MW-1.32-release, Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Wikimedia-maintenance-script-run, AbuseFilter

Nov 19 2018

tstarling updated subscribers of T209892: SecurePoll is not compatible with GPG 2.1+.
Nov 19 2018, 10:51 PM · MediaWiki-extensions-SecurePoll
tstarling created T209892: SecurePoll is not compatible with GPG 2.1+.
Nov 19 2018, 10:49 PM · MediaWiki-extensions-SecurePoll
tstarling closed T209802: Cannot vote on votewiki as Resolved.

One thing that was confusing me was why timeout in limit.sh wasnt killing the process eventually. But after reading docs i guess that is because it didnt have a -k flag

Nov 19 2018, 10:31 PM · Patch-For-Review, Operations, Wikimedia-production-error, MediaWiki-extensions-SecurePoll
tstarling added a comment to T209802: Cannot vote on votewiki.

Installing the package gnupg1 and using

Nov 19 2018, 12:34 PM · Patch-For-Review, Operations, Wikimedia-production-error, MediaWiki-extensions-SecurePoll

Nov 15 2018

Bawolff awarded T209556: In AuthManager, avoid encrypted storage of the password in the session a Like token.
Nov 15 2018, 10:20 AM · Security, MediaWiki-Authentication-and-authorization
tstarling created T209556: In AuthManager, avoid encrypted storage of the password in the session.
Nov 15 2018, 3:15 AM · Security, MediaWiki-Authentication-and-authorization

Nov 14 2018

tstarling added a comment to T204617: Identify a suitable PEG.js replacement in PHP.

I've just been looking at the phpegjs code. Performance will be extremely sensitive to character class matching. Ideally, that should be inlined, instead of split out to a runtime library function peg_char_class_test(). If the class is purely ASCII, then it should be possible to consume text without doing UTF-8 parsing. For example, Parsoid has:

Nov 14 2018, 2:23 AM · Parsoid-PHP
tstarling created T209448: Profiler subclass for excimer.
Nov 14 2018, 1:37 AM · Excimer

Nov 11 2018

Liuxinyu970226 awarded T46667: Review and merge chinese-collation branch into master, configure Chinese wikis to use it a Manufacturing Defect? token.
Nov 11 2018, 8:17 AM · Chinese-Sites, MediaWiki-Internationalization, Wikimedia-Site-requests
Liuxinyu970226 awarded T185607: Provide an inline discussion feature, "DiscussThis" a Like token.
Nov 11 2018, 8:14 AM · Growth-Team, VisualEditor-MediaWiki-Plugins, Collaboration-Team-Triage, StructuredDiscussions, VisualEditor, TechCom-RFC
Liuxinyu970226 awarded T108664: Provide an interactive edit conflict resolution tool a Like token.
Nov 11 2018, 7:06 AM · Epic, Contributors-Team, MediaWiki-Page-editing
Liuxinyu970226 awarded T161671: Compacting the revision table a Like token.
Nov 11 2018, 6:48 AM · Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), Multi-Content-Revisions, Epic, Patch-For-Review, MediaWiki-Database, Schema-change

Nov 8 2018

tstarling added a comment to T199332: PHP Warning: count(): Parameter must be an array or an object that implements Countable in Serializer.php.

I need to dig into PHP semantics. Is it possible you might be suppressing the notice on $parent->children because of the =& instead of plain =? (line 246)

Nov 8 2018, 11:20 PM · Core Platform Team Kanban (Blocked Externally), Core Platform Team (Security, stability, performance and scalability (TEC1)), RemexHtml
tstarling added a comment to T193352: Update librsvg to ≥2.42.3.

paravoid explained to me that librsvg 2.44 was uploaded to sid on November 3. There was some consternation about the ports which are still missing, but it looks like the change will not be reverted. This upload to sid was the thing that was previously blocked by lack of architecture support.

Nov 8 2018, 10:54 PM · Operations, Upstream, Wikimedia-SVG-rendering
tstarling added a comment to T199332: PHP Warning: count(): Parameter must be an array or an object that implements Countable in Serializer.php.

I'm guessing the "non-existent elements" also have a funny $this->nodes[$self->parentId]->children ?

Nov 8 2018, 3:59 AM · Core Platform Team Kanban (Blocked Externally), Core Platform Team (Security, stability, performance and scalability (TEC1)), RemexHtml
tstarling added a comment to T205059: Excimer: new profiler for PHP.

@Krinkle asked whether we can do function counts in excimer, to provide feature parity with xhprof. I think the answer is no, not without a PHP patch. The relevant hook (zend_execute_ex) is a true global, so it needs to be installed unconditionally, on MINIT. When this hook is overridden, the VM switches into a slow mode which uses the C stack for internal function calls, instead of the internal stack. For example, in the DO_FCALL handler:

Nov 8 2018, 3:37 AM · serviceops, Core Platform Team (PHP7 (TEC4)), Excimer, Core Platform Team Kanban (Doing), Performance-Team (Radar), PHP 7.1 support