Page MenuHomePhabricator

vadim-kovalenko (Vadim Kovalenko)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 20 2020, 1:35 PM (47 w, 4 d)
Availability
Available
LDAP User
Vadim Kovalenko
MediaWiki User
Unknown

Recent Activity

Mon, Sep 27

vadim-kovalenko moved T290568: [spike] Use w3c accessibility standards to detect readability issues with dark themes from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Mon, Sep 27, 10:08 AM · Product-Infrastructure-Team-Backlog (Kanban), Accessibility, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service
vadim-kovalenko moved T290569: [spike] Introduce a mobile app preview of the rendered article for editors from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Mon, Sep 27, 10:08 AM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service
vadim-kovalenko moved T290569: [spike] Introduce a mobile app preview of the rendered article for editors from Upcoming to Kanban on the Product-Infrastructure-Team-Backlog board.
Mon, Sep 27, 10:06 AM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service
vadim-kovalenko moved T290568: [spike] Use w3c accessibility standards to detect readability issues with dark themes from Upcoming to Kanban on the Product-Infrastructure-Team-Backlog board.
Mon, Sep 27, 10:05 AM · Product-Infrastructure-Team-Backlog (Kanban), Accessibility, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service
vadim-kovalenko added a comment to T290568: [spike] Use w3c accessibility standards to detect readability issues with dark themes.

Theme issues appears because of the wrong contrast ratio value for elements. From wiki:

Mon, Sep 27, 10:01 AM · Product-Infrastructure-Team-Backlog (Kanban), Accessibility, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service
vadim-kovalenko added a comment to T290569: [spike] Introduce a mobile app preview of the rendered article for editors.

I suggest to implement mobile preview button for the Edit section in desktop wiki (see the screenshot)

mobile-preview-btn.png (672×1 px, 161 KB)

This button should pass request into mobilehtml route and retrieve the article with transformed styles and ability to change themes.
As I mentioned in T290570, I created an example (https://vadimkovalenkosnf.github.io/wiki-colour-issues-filter/) which can accept articles from desktop wiki (for now) and pass it into iframe.

Mon, Sep 27, 7:37 AM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service

Fri, Sep 24

vadim-kovalenko claimed T290569: [spike] Introduce a mobile app preview of the rendered article for editors.
Fri, Sep 24, 2:19 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service
vadim-kovalenko claimed T290568: [spike] Use w3c accessibility standards to detect readability issues with dark themes.
Fri, Sep 24, 12:37 PM · Product-Infrastructure-Team-Backlog (Kanban), Accessibility, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service
vadim-kovalenko changed the status of T291625: <blockquote> elements containing ref elements are scrollable when they shouldn't be from Open to In Progress.
Fri, Sep 24, 8:15 AM · Product-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, Wikipedia-Android-App-Backlog
vadim-kovalenko claimed T291625: <blockquote> elements containing ref elements are scrollable when they shouldn't be.
Fri, Sep 24, 7:35 AM · Product-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, Wikipedia-Android-App-Backlog

Thu, Sep 23

vadim-kovalenko updated subscribers of T290570: [spike] Use a heuristic to detect colour issues on rendered content for dark theme.

I decided to create a draft version of the possible solution which I've placed into repo - https://github.com/VadimKovalenkoSNF/wiki-colour-issues-filter
There are two branches: main and client-filtering
In the main branch you are able to check both approaches with filtering - client side and server side.
Server side is commented because I haven't managed to init filtering using domino package (which is using as virtual DOM library for mobileapps).
Probably, they haven't implemented functionality of the window.getComputedStyle (check here - https://github.com/fgnass/domino/blob/12a5f67136a0ac10e3fa1649b8787ba3b309e9a7/lib/Window.js#L55)
As for client side (it is default in my code), it works, but the time of the parsing of the page may vary. Also, at the moment it checks only equal colors and highlight nodes with the wrong styling with red border.

Thu, Sep 23, 4:04 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service
vadim-kovalenko moved T290570: [spike] Use a heuristic to detect colour issues on rendered content for dark theme from Upcoming to Kanban on the Product-Infrastructure-Team-Backlog board.
Thu, Sep 23, 10:50 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service
vadim-kovalenko moved T290570: [spike] Use a heuristic to detect colour issues on rendered content for dark theme from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Thu, Sep 23, 10:50 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service

Wed, Sep 22

vadim-kovalenko moved T290573: Upgrade push notifications to nodejs 12 from Doing to Blocked on the Product-Infrastructure-Team-Backlog (Kanban) board.
Wed, Sep 22, 1:26 PM · Product-Infrastructure-Team-Backlog (Kanban), Push-Notification-Service
vadim-kovalenko claimed T290570: [spike] Use a heuristic to detect colour issues on rendered content for dark theme.
Wed, Sep 22, 8:40 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service

Sep 16 2021

vadim-kovalenko moved T290573: Upgrade push notifications to nodejs 12 from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Sep 16 2021, 8:19 AM · Product-Infrastructure-Team-Backlog (Kanban), Push-Notification-Service
vadim-kovalenko moved T290576: Upgrade proton to nodejs 12 from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Sep 16 2021, 8:19 AM · Product-Infrastructure-Team-Backlog (Kanban)
vadim-kovalenko moved T290574: Upgrade wikifeeds to nodejs 12 from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Sep 16 2021, 8:18 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikifeeds
vadim-kovalenko moved T290576: Upgrade proton to nodejs 12 from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog board.
Sep 16 2021, 8:18 AM · Product-Infrastructure-Team-Backlog (Kanban)
vadim-kovalenko moved T290574: Upgrade wikifeeds to nodejs 12 from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog board.
Sep 16 2021, 8:18 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikifeeds
vadim-kovalenko moved T290573: Upgrade push notifications to nodejs 12 from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog board.
Sep 16 2021, 8:18 AM · Product-Infrastructure-Team-Backlog (Kanban), Push-Notification-Service
vadim-kovalenko claimed T290576: Upgrade proton to nodejs 12.
Sep 16 2021, 8:13 AM · Product-Infrastructure-Team-Backlog (Kanban)
vadim-kovalenko claimed T290573: Upgrade push notifications to nodejs 12.
Sep 16 2021, 8:12 AM · Product-Infrastructure-Team-Backlog (Kanban), Push-Notification-Service

Sep 13 2021

vadim-kovalenko claimed T290574: Upgrade wikifeeds to nodejs 12.
Sep 13 2021, 7:02 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikifeeds

Sep 9 2021

vadim-kovalenko moved T290572: Upgrade mobileapps to nodejs 12 from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Sep 9 2021, 1:33 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
vadim-kovalenko moved T290572: Upgrade mobileapps to nodejs 12 from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog board.
Sep 9 2021, 1:33 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
vadim-kovalenko claimed T290572: Upgrade mobileapps to nodejs 12.
Sep 9 2021, 1:16 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service

Sep 7 2021

vadim-kovalenko added a comment to T237827: Incorrect longitude/latitude handling on anything that is not a city/town etc in summary endpoint.

Hi @Jdlrobson ! Regarding template docs it does not display in the mobile view of Wikipedia, it is desktop only.
I've checked /summary endpoint for Acropolis article, it doesn't have coordinates property because this article does not have a dedicated template (which is expected). I've dove deeper and checked coordinates restrictions on mobile html level. These restrictions persist here in MobileHTML and styles. It seems, template works as expected, please re-check.

Sep 7 2021, 11:25 AM · Product-Infrastructure-Team-Backlog (Kanban), RESTBase-API, Mobile-Content-Service
vadim-kovalenko moved T237827: Incorrect longitude/latitude handling on anything that is not a city/town etc in summary endpoint from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Sep 7 2021, 7:25 AM · Product-Infrastructure-Team-Backlog (Kanban), RESTBase-API, Mobile-Content-Service
vadim-kovalenko claimed T237827: Incorrect longitude/latitude handling on anything that is not a city/town etc in summary endpoint.
Sep 7 2021, 7:25 AM · Product-Infrastructure-Team-Backlog (Kanban), RESTBase-API, Mobile-Content-Service

Sep 6 2021

vadim-kovalenko updated subscribers of T284327: Investigate texts hard to read on dark themes in mobile Apps.

Hi @Izno! As per discussion here and this thread (check 'Calculate text color automatically depending of the table header background color' there), could you assist with Template_talk:Episode_table issue?

Sep 6 2021, 9:29 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog

Sep 2 2021

vadim-kovalenko moved T289575: Resolve redirects for page/related endpoint from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Sep 2 2021, 7:23 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service

Aug 26 2021

vadim-kovalenko moved T289575: Resolve redirects for page/related endpoint from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Aug 26 2021, 10:19 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
vadim-kovalenko claimed T289575: Resolve redirects for page/related endpoint.
Aug 26 2021, 10:18 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service

Aug 25 2021

vadim-kovalenko added a comment to T284327: Investigate texts hard to read on dark themes in mobile Apps.

For example when you say “I think, it is better to add specific class (or even style logic) inside Template to handle different text colors in heading” you mentioned that for the episode_table template but couldn’t that logic apply across the board to all times text appears with certain header backgrounds? Perhaps I am oversimplifying

Aug 25 2021, 4:14 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog
vadim-kovalenko added a comment to T284327: Investigate texts hard to read on dark themes in mobile Apps.

@Ijm8710

attaching image for Mars Volta as requested

Yes, now I see it. Correct link is https://en.wikipedia.org/api/rest_v1/page/mobile-html/The_Mars_Volta_discography?theme=dark. Issue the same as in Maria Andrejczyk article.

Don’t want to jump the gun, but I’d be curious which of these mean they can/are unlikely to be improved. The more universal they are, the more I’d hope they can be like those affecting most athlete pages across the board

I think we need to prepare a list of these templates and then discuss about style issues with their authors

The commentary on the lindor example has me curious. Why would that be any different from say “Tom Brady” who is themed in dark mode?

Because they utilize different templates. Francisco Lindor uses Infobox baseball biography and Tom Brady Infobox NFL biography

Aug 25 2021, 4:11 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog
vadim-kovalenko added a comment to T284327: Investigate texts hard to read on dark themes in mobile Apps.

Hi! I went through this checklist. Here is my summary:

Aug 25 2021, 3:32 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog

Aug 23 2021

vadim-kovalenko moved T271566: Issue with pie graphs on some articles from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Aug 23 2021, 10:05 AM · Patch-For-Review, Product-Infrastructure-Team-Backlog, Wikipedia-iOS-App-Backlog, iOS-app-Bugs
vadim-kovalenko updated subscribers of T271566: Issue with pie graphs on some articles.

I've fixed issue with the white background. However, there is still a bug with a horizontal bar on the top caused by redundant <p> element. It seems, it is on the Template level.

chart-issue.png (998×1 px, 243 KB)

cc: @ABorbaWMF , @MSantos , @Jgiannelos

Aug 23 2021, 10:01 AM · Patch-For-Review, Product-Infrastructure-Team-Backlog, Wikipedia-iOS-App-Backlog, iOS-app-Bugs

Aug 19 2021

vadim-kovalenko moved T271566: Issue with pie graphs on some articles from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Aug 19 2021, 2:01 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog, Wikipedia-iOS-App-Backlog, iOS-app-Bugs
vadim-kovalenko moved T271566: Issue with pie graphs on some articles from Backlog to Kanban on the Product-Infrastructure-Team-Backlog board.
Aug 19 2021, 2:00 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog, Wikipedia-iOS-App-Backlog, iOS-app-Bugs
vadim-kovalenko claimed T271566: Issue with pie graphs on some articles.
Aug 19 2021, 1:59 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog, Wikipedia-iOS-App-Backlog, iOS-app-Bugs

Aug 18 2021

vadim-kovalenko moved T262581: Cyclists Infobox not displayed in the iOS app from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Aug 18 2021, 1:33 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog, iOS-app-Bugs

Aug 17 2021

vadim-kovalenko moved T131393: Page indicators aren't visible in articles from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Aug 17 2021, 1:46 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
vadim-kovalenko moved T131393: Page indicators aren't visible in articles from Backlog to Kanban on the Product-Infrastructure-Team-Backlog board.
Aug 17 2021, 1:46 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
vadim-kovalenko claimed T131393: Page indicators aren't visible in articles.
Aug 17 2021, 1:43 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service

Aug 13 2021

vadim-kovalenko added a comment to T262581: Cyclists Infobox not displayed in the iOS app.

Hi @Envlh ! I've checked this issue on the mobile-html side and indeed if we disable the forbidden infobox class name from div element here we'll be able to retrieve French cyclist infobox. This happens because this infobox wraps into div, not into the table like it does in other wikis. I would rather not delete this regexp rule on the level of the mobile app ( at least for now ). I took a look at the French infobox module source code and found that it could be probably fixed in this string:
local infobox = mw.html.create( 'div' )
I think div should be replaced with the table there ( plus implemented logic for th, tr and other nested table elements ).
cc: @MSantos

Aug 13 2021, 3:07 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog, iOS-app-Bugs
vadim-kovalenko moved T262581: Cyclists Infobox not displayed in the iOS app from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Aug 13 2021, 1:03 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog, iOS-app-Bugs
vadim-kovalenko claimed T262581: Cyclists Infobox not displayed in the iOS app.
Aug 13 2021, 1:03 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog, iOS-app-Bugs

Aug 10 2021

vadim-kovalenko moved T235869: Additional point added over unordered list from To Do to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Aug 10 2021, 11:15 AM · Product-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, Page Content Service, Wikipedia-Android-App-Backlog, Parsoid (Tracking)
vadim-kovalenko moved T235869: Additional point added over unordered list from Backlog to Kanban on the Product-Infrastructure-Team-Backlog board.
Aug 10 2021, 11:15 AM · Product-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, Page Content Service, Wikipedia-Android-App-Backlog, Parsoid (Tracking)
vadim-kovalenko moved T285192: <dd> elements containing ref tags are scrollable when they shouldn't be from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Aug 10 2021, 9:08 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog

Aug 6 2021

vadim-kovalenko moved T285192: <dd> elements containing ref tags are scrollable when they shouldn't be from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Aug 6 2021, 2:18 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog
vadim-kovalenko moved T285192: <dd> elements containing ref tags are scrollable when they shouldn't be from Backlog to Kanban on the Product-Infrastructure-Team-Backlog board.
Aug 6 2021, 2:18 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog
vadim-kovalenko claimed T285192: <dd> elements containing ref tags are scrollable when they shouldn't be.
Aug 6 2021, 2:08 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog
vadim-kovalenko moved T275558: Mobile App lacks CSS for class="mw-empty-elt" from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Aug 6 2021, 1:41 PM · Product-Infrastructure-Team-Backlog (Kanban), MediaWiki-extensions-MobileApp, Wikipedia-Android-App-Backlog
vadim-kovalenko moved T275558: Mobile App lacks CSS for class="mw-empty-elt" from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Aug 6 2021, 12:40 PM · Product-Infrastructure-Team-Backlog (Kanban), MediaWiki-extensions-MobileApp, Wikipedia-Android-App-Backlog
vadim-kovalenko moved T275558: Mobile App lacks CSS for class="mw-empty-elt" from Upcoming to Kanban on the Product-Infrastructure-Team-Backlog board.
Aug 6 2021, 12:39 PM · Product-Infrastructure-Team-Backlog (Kanban), MediaWiki-extensions-MobileApp, Wikipedia-Android-App-Backlog
vadim-kovalenko claimed T275558: Mobile App lacks CSS for class="mw-empty-elt".
Aug 6 2021, 12:37 PM · Product-Infrastructure-Team-Backlog (Kanban), MediaWiki-extensions-MobileApp, Wikipedia-Android-App-Backlog
vadim-kovalenko moved T253479: Flags in infoboxes in the Wikipedia Android app are shown with a wrong-looking border from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Aug 6 2021, 8:18 AM · Page Content Service, Product-Infrastructure-Team-Backlog (Kanban), Android-app-Bugs
vadim-kovalenko moved T253479: Flags in infoboxes in the Wikipedia Android app are shown with a wrong-looking border from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Aug 6 2021, 7:06 AM · Page Content Service, Product-Infrastructure-Team-Backlog (Kanban), Android-app-Bugs
vadim-kovalenko moved T253479: Flags in infoboxes in the Wikipedia Android app are shown with a wrong-looking border from Backlog to Kanban on the Product-Infrastructure-Team-Backlog board.
Aug 6 2021, 7:06 AM · Page Content Service, Product-Infrastructure-Team-Backlog (Kanban), Android-app-Bugs
vadim-kovalenko claimed T253479: Flags in infoboxes in the Wikipedia Android app are shown with a wrong-looking border.
Aug 6 2021, 7:02 AM · Page Content Service, Product-Infrastructure-Team-Backlog (Kanban), Android-app-Bugs

Aug 5 2021

vadim-kovalenko added a comment to T256172: [Bug] mobile-html: template for merging template not displaying properly.

Hi @JoeWalsh ! I think this bug has been fixed already.

Aug 5 2021, 12:58 PM · Page Content Service, Product-Infrastructure-Team-Backlog

Aug 4 2021

vadim-kovalenko added a comment to T258455: [BUG] mobile-html does not handle specific <p> with style properly.

Hi @cooltey ! Could you, please, provide some other article or doc/example where the content is wrapped by id=spoiler, or at least element <p id="spoiler"></p> exists? I've just checked the article from the description, no spoiler elements exist there in the DOM. Moreover, regarding this doc - https://en.wikipedia.org/wiki/Wikipedia:Spoiler, spoiler warnings are no longer used.

Aug 4 2021, 11:31 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
vadim-kovalenko moved T258455: [BUG] mobile-html does not handle specific <p> with style properly from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Aug 4 2021, 8:17 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
vadim-kovalenko claimed T258455: [BUG] mobile-html does not handle specific <p> with style properly.
Aug 4 2021, 8:15 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
vadim-kovalenko moved T258455: [BUG] mobile-html does not handle specific <p> with style properly from Upcoming to Kanban on the Product-Infrastructure-Team-Backlog board.
Aug 4 2021, 8:15 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service

Aug 3 2021

vadim-kovalenko added a comment to T266361: Minerva should use a single ResourceLoader module for shipping its styles.

Hi @Mholloway ! Could you provide some input regarding this patch?

Aug 3 2021, 3:03 PM · MW-1.38-notes (1.38.0-wmf.3; 2021-10-05), Patch-For-Review, Readers-Web-Backlog (Needs Prioritization (Tech)), MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Performance-Team (Radar), patch-welcome, MinervaNeue, Technical-Debt
vadim-kovalenko added a comment to T277059: [Bug] Blue links are broken on the Serbian (Latin) Burek article on iOS.

@Tsevener Is there any update regarding this task? Does my assistance is needed in the current stage?

Aug 3 2021, 2:59 PM · Serbian-Sites, Language-Team (Language-2021-July-September), Wikipedia-Android-App-Backlog, Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog
vadim-kovalenko updated subscribers of T278272: Rest API endpoints do not respect Accept-Language header for some Wikis.

Hi @Tsevener ! I reproduced this issue and also checked response output for different language variants:

  1. kk-latn and kk-arab, kk-cn, kk-cyrl, kk-kz, kk-tr;
  2. ike-latn and ike-cans;

(More language codes here - https://www.wikidata.org/wiki/Help:Wikimedia_language_codes/lists/all)

Aug 3 2021, 1:22 PM · Product-Infrastructure-Team-Backlog, Page Content Service, Wikipedia-iOS-App-Backlog

Aug 2 2021

vadim-kovalenko moved T278272: Rest API endpoints do not respect Accept-Language header for some Wikis from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Aug 2 2021, 9:57 AM · Product-Infrastructure-Team-Backlog, Page Content Service, Wikipedia-iOS-App-Backlog
vadim-kovalenko claimed T278272: Rest API endpoints do not respect Accept-Language header for some Wikis.
Aug 2 2021, 9:56 AM · Product-Infrastructure-Team-Backlog, Page Content Service, Wikipedia-iOS-App-Backlog

Jul 14 2021

vadim-kovalenko added a comment to T269476: [OTRS bug] Disappearing text due to custom styling.

Hi @Ijm8710 ! We aware of issues you have mentioned. We're working on them in this patch which is currently in progress because at the moment we are looking for a solution that can cover all dark/theme issues which you can take a look at this umbrella task - https://phabricator.wikimedia.org/T252904.

Jul 14 2021, 2:48 PM · Patch-For-Review, Page Content Service, Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-iOS-App-Backlog
vadim-kovalenko added a comment to T277059: [Bug] Blue links are broken on the Serbian (Latin) Burek article on iOS.

@Tsevener I expect to see these changes working in the beta cluster once this patch with reverted changes and other fixes is merged. You will no need to setup RESTBase locally then. But for local testing, I had to use it.

Jul 14 2021, 2:34 PM · Serbian-Sites, Language-Team (Language-2021-July-September), Wikipedia-Android-App-Backlog, Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog
vadim-kovalenko added a comment to T269312: Media list endpoint returning unexpected and out of order item responses.

Hi @Dmantena ! Thank you for pointing out this bug. The reason why this happened is that item.srcset[0].src property in routes/page/media.js can contain encoded URI characters for some images. I'll push relevant bug fix along with other fixes in the upcoming patch.

Jul 14 2021, 11:34 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog

Jul 13 2021

vadim-kovalenko moved T278023: Paragraph order on some disambiguation pages is wrong in Wikipedia apps from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jul 13 2021, 1:29 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, iOS-app-Bugs

Jul 9 2021

vadim-kovalenko claimed T278023: Paragraph order on some disambiguation pages is wrong in Wikipedia apps.
Jul 9 2021, 9:45 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, iOS-app-Bugs

Jul 8 2021

vadim-kovalenko added a comment to T277059: [Bug] Blue links are broken on the Serbian (Latin) Burek article on iOS.

Hi @cooltey
I've added title redirection for /related pages in the patch above along with other changes that have been implemented in the reverted patch
To check 'read more' section locally I had a need to deploy a RESTBase

Jul 8 2021, 2:31 PM · Serbian-Sites, Language-Team (Language-2021-July-September), Wikipedia-Android-App-Backlog, Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog

Jun 23 2021

vadim-kovalenko added a comment to T269476: [OTRS bug] Disappearing text due to custom styling.

Hi @Ijm8710 @MSantos !
I've uploaded a patch that solves these recent issues.
I want to emphasize about /Mary_Matalin however. Article was created incorrectly itself (wrong template usage). I fixed this issue in the latest revision.
Issue with black text in /Francisco_Lindor article already fixed in the patch related to T284327
Issue with salmon color rows in /Don_Mattingly fixed in the path related to T282295
We continue working on similar issues. If you find anything else, please, let me know.

Jun 23 2021, 2:12 PM · Patch-For-Review, Page Content Service, Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-iOS-App-Backlog

Jun 22 2021

vadim-kovalenko claimed T269476: [OTRS bug] Disappearing text due to custom styling.
Jun 22 2021, 1:07 PM · Patch-For-Review, Page Content Service, Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-iOS-App-Backlog

Jun 18 2021

vadim-kovalenko moved T266361: Minerva should use a single ResourceLoader module for shipping its styles from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jun 18 2021, 2:49 PM · MW-1.38-notes (1.38.0-wmf.3; 2021-10-05), Patch-For-Review, Readers-Web-Backlog (Needs Prioritization (Tech)), MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Performance-Team (Radar), patch-welcome, MinervaNeue, Technical-Debt
vadim-kovalenko added a comment to T266361: Minerva should use a single ResourceLoader module for shipping its styles.

I've uploaded a preliminary patch with updated minerva styles for mobileapps, pls check.
cc: @MSantos, @Jdlrobson

Jun 18 2021, 2:49 PM · MW-1.38-notes (1.38.0-wmf.3; 2021-10-05), Patch-For-Review, Readers-Web-Backlog (Needs Prioritization (Tech)), MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Performance-Team (Radar), patch-welcome, MinervaNeue, Technical-Debt

Jun 17 2021

vadim-kovalenko moved T248966: Remove unused PCS JS functionality from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jun 17 2021, 8:11 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service

Jun 15 2021

vadim-kovalenko moved T248966: Remove unused PCS JS functionality from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jun 15 2021, 12:14 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
vadim-kovalenko claimed T248966: Remove unused PCS JS functionality.
Jun 15 2021, 12:07 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service

Jun 14 2021

vadim-kovalenko updated subscribers of T266361: Minerva should use a single ResourceLoader module for shipping its styles.

I've checked minerva theme handling in mobileapps and it seems that all it does is just getting .less files from private/styles/minerva and transpile/concat them into base.css during build process.
As per commit [1] minerva styles were added manually. However, here [2] was added functionality to handle request directly to ResourceLoader module. Regarding commit message from [2] we are unable to access load.php explicitly via preq module to get the relevant minerva theme from the ResourceLoader.
I was expecting that within the scope of this task I need to implement some sort of async function to upload particular theme styles (as a single bundle file), but last research confused me about whether it is appropriate.
@MSantos , @Mholloway could you assist?

Jun 14 2021, 1:02 PM · MW-1.38-notes (1.38.0-wmf.3; 2021-10-05), Patch-For-Review, Readers-Web-Backlog (Needs Prioritization (Tech)), MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Performance-Team (Radar), patch-welcome, MinervaNeue, Technical-Debt

Jun 11 2021

vadim-kovalenko added a comment to T277059: [Bug] Blue links are broken on the Serbian (Latin) Burek article on iOS.

Hi @Tsevener , thank you for the testing! We've merged T277059 and T269312 today and now you are able to check this on the staging environment:

Jun 11 2021, 10:35 AM · Serbian-Sites, Language-Team (Language-2021-July-September), Wikipedia-Android-App-Backlog, Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog

Jun 8 2021

vadim-kovalenko moved T266361: Minerva should use a single ResourceLoader module for shipping its styles from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jun 8 2021, 1:18 PM · MW-1.38-notes (1.38.0-wmf.3; 2021-10-05), Patch-For-Review, Readers-Web-Backlog (Needs Prioritization (Tech)), MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Performance-Team (Radar), patch-welcome, MinervaNeue, Technical-Debt
vadim-kovalenko claimed T266361: Minerva should use a single ResourceLoader module for shipping its styles.
Jun 8 2021, 1:18 PM · MW-1.38-notes (1.38.0-wmf.3; 2021-10-05), Patch-For-Review, Readers-Web-Backlog (Needs Prioritization (Tech)), MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Performance-Team (Radar), patch-welcome, MinervaNeue, Technical-Debt
vadim-kovalenko added a comment to T269312: Media list endpoint returning unexpected and out of order item responses.

Update: I combined T277059 with patch related to this task.
cc: @MSantos

Jun 8 2021, 1:09 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog
vadim-kovalenko added a comment to T277059: [Bug] Blue links are broken on the Serbian (Latin) Burek article on iOS.

Hi @MSantos , @Tsevener !
I've uploaded the patch that solves both this task and T269312
I created resolve redirection method and chained it to these routes:

  • /v1/page/summary/{title}
  • /v1/page/media-list/{title}
  • /v1/page/mobile-html/{title}

Worth mentioning that I perform overriding title parameter of the request - in the previous patchset it was a real redirect invocation with changing URL
Now there is an implicit redirection - for example, article sr.wikipedia.org/v1/page/mobile-html/Burek will redirect to article with title Бурек but URL title param in the search bar will remain Burek.

Jun 8 2021, 1:06 PM · Serbian-Sites, Language-Team (Language-2021-July-September), Wikipedia-Android-App-Backlog, Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog

Jun 4 2021

vadim-kovalenko added a comment to T269312: Media list endpoint returning unexpected and out of order item responses.

@MSantos
I've checked the differences between those two articles locally (title a bit different, but article itself the same):

  1. localhost/en.wikipedia.org/v1/page/media-list/Barack_Obama
  2. localhost/en.wikipedia.org/v1/page/media-list/Barack_obama
Jun 4 2021, 2:48 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog
vadim-kovalenko moved T190847: Lazy loaded image placeholder flash in dark mode from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jun 4 2021, 11:39 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog

Jun 2 2021

schoenbaechler awarded T251354: Increase touch target for superscript links a Orange Medal token.
Jun 2 2021, 12:36 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service

May 31 2021

vadim-kovalenko moved T190847: Lazy loaded image placeholder flash in dark mode from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
May 31 2021, 12:37 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog
vadim-kovalenko claimed T190847: Lazy loaded image placeholder flash in dark mode.
May 31 2021, 12:36 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog

May 28 2021

vadim-kovalenko moved T277059: [Bug] Blue links are broken on the Serbian (Latin) Burek article on iOS from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
May 28 2021, 2:27 PM · Serbian-Sites, Language-Team (Language-2021-July-September), Wikipedia-Android-App-Backlog, Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog
vadim-kovalenko added a comment to T277059: [Bug] Blue links are broken on the Serbian (Latin) Burek article on iOS.

I've uploaded a patch with redirection algorithm. The main logic there is to check the converted: [{ 'from': '...', 'to': '...' }] property from mediawiki api for each request. If this property exists, mobile html will perform redirection to route, specified in converted[0].to property. Link titles remain untouched, the redirect route will recalculate only when the user clicks the link.
cc: @MSantos , @Tsevener

May 28 2021, 2:26 PM · Serbian-Sites, Language-Team (Language-2021-July-September), Wikipedia-Android-App-Backlog, Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog

May 24 2021

vadim-kovalenko moved T277059: [Bug] Blue links are broken on the Serbian (Latin) Burek article on iOS from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
May 24 2021, 12:13 PM · Serbian-Sites, Language-Team (Language-2021-July-September), Wikipedia-Android-App-Backlog, Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog