Page MenuHomePhabricator

vadim-kovalenko (Vadim Kovalenko)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 20 2020, 1:35 PM (20 w, 2 d)
Availability
Available
LDAP User
Vadim Kovalenko
MediaWiki User
Unknown

Recent Activity

Wed, Apr 7

vadim-kovalenko updated subscribers of T253390: Edit Preview of a "Notes" section should not show actual notes.

Can you clarify what exactly needs to be fixed in the scope of this task?
I've found, that some articles have Notes as a separate section, and some — as embedded.

Wed, Apr 7, 3:47 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Page Content Service, Wikipedia-iOS-App-Backlog

Mon, Apr 5

vadim-kovalenko moved T278428: LinkRenderer should accept both PageIdentity and LinkTarget arguments for its methods from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.
Mon, Apr 5, 10:20 AM · Patch-For-Review, Platform Team Workboards (MW Expedition)
vadim-kovalenko moved T278940: Update LinkCache methods to accept PageIdentity from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.
Mon, Apr 5, 10:19 AM · Patch-For-Review, Platform Team Workboards (MW Expedition)

Wed, Mar 31

vadim-kovalenko created T278940: Update LinkCache methods to accept PageIdentity.
Wed, Mar 31, 11:44 AM · Patch-For-Review, Platform Team Workboards (MW Expedition)

Tue, Mar 30

vadim-kovalenko claimed T253390: Edit Preview of a "Notes" section should not show actual notes.
Tue, Mar 30, 12:34 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Page Content Service, Wikipedia-iOS-App-Backlog
vadim-kovalenko updated subscribers of T277522: [Bug] Short description template changes not reflected when requesting specific revision of mobile-html.

I've tried to reproduce the issue and have some questions/info to share about

Tue, Mar 30, 8:50 AM · Wikipedia-iOS-App-Backlog, Product-Infrastructure-Team-Backlog (Kanban), Page Content Service

Fri, Mar 26

vadim-kovalenko moved T261019: [OTRS]: Article images above the fold not loading at first from Blocked to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Fri, Mar 26, 2:18 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
vadim-kovalenko claimed T261019: [OTRS]: Article images above the fold not loading at first.
Fri, Mar 26, 2:18 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
vadim-kovalenko added a comment to T261019: [OTRS]: Article images above the fold not loading at first.

@ssastry Yes, I've uploaded a patch using this approach. In addition, I want to mention that not only section with id=1 can show the issue but with id=0, so I've implemented fix for both cases. Also, I've added additional filtering for collapse tables to make sure that lazy loading is applied to their inner images even if that tables are inside the first two sections.
Also, I've checked this issue in a different articles (this might be useful when testing on local environment):

  • localhost/en.wikipedia.org/v1/page/mobile-html/WYSIWYG - this one from description, image is inside section id=1
  • localhost/de.wikipedia.org/v1/page/mobile-html/Great_Western_Railway - image is inside section id=0
  • localhost/de.wikipedia.org/v1/page/mobile-html/IBM - image inside collapse table inside section id=0
Fri, Mar 26, 2:16 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Thu, Mar 25

vadim-kovalenko created T278428: LinkRenderer should accept both PageIdentity and LinkTarget arguments for its methods.
Thu, Mar 25, 11:38 AM · Patch-For-Review, Platform Team Workboards (MW Expedition)

Wed, Mar 24

vadim-kovalenko placed T261019: [OTRS]: Article images above the fold not loading at first up for grabs.
Wed, Mar 24, 5:17 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
vadim-kovalenko added a comment to T261019: [OTRS]: Article images above the fold not loading at first.

As I mentioned before, I need some attribute for incoming images to intercept them in prepareImage() method. Also, I've tested a filter function for the first image and this approach did not work well because in this particular article there is an image wrapped by display-none section. Other articles probably can have such kind of hidden images so we are unable to prevent lazy load just for the first image on the page.

Wed, Mar 24, 5:06 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
vadim-kovalenko added a comment to T261019: [OTRS]: Article images above the fold not loading at first.

I've researched this issue. This is how lazy loading applied to the images:

  1. All images intercept by prepareImage() method in MobileHTML class (link)
  2. Inside that method images push into this.lazyLoadableImages array and then passed one by one to finalizeStep -> LazyLoad.convertImageToPlaceholder(this.doc, node); method (link).
  3. When a single image passes to convertImageToPlaceholder, it receives special classes and attributes for lazy loading behavior
Wed, Mar 24, 3:23 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Mon, Mar 22

vadim-kovalenko created T278125: TitleFormatter (implemented in MediaWikiTitleCodec) should accept PageIdentity as argument.
Mon, Mar 22, 1:24 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (MW Expedition)

Fri, Mar 19

vadim-kovalenko moved T261019: [OTRS]: Article images above the fold not loading at first from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Fri, Mar 19, 2:16 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Wed, Mar 17

vadim-kovalenko claimed T272557: Convert blocks to PageIdentity.
Wed, Mar 17, 3:00 PM · Patch-For-Review, Platform Team Workboards (MW Expedition)
vadim-kovalenko moved T252893: Collapse table title includes math symbols from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Wed, Mar 17, 1:03 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
vadim-kovalenko updated subscribers of T252893: Collapse table title includes math symbols.

@MSantos , @Charlotte
Here is the algorithm to solve this issue:

  1. Inside prepareTable() intercept tables with class pcs-collapse-table except infobox. We don't need infobox, because even if they have math symbols, their header text generate from th.infobox-above, th.plainlist etc. th tag in the tables which we need has only span.mwe-math-element.
  2. Inside each specific table init document.createTreeWalker() to find relevant img tags and store their URL into array.
  3. Pass this array into newCollapsedHeaderDiv().
  4. Invoke this function inside newCaptionFragment(), check if each array element of headerText is matching to URL regexp.
  5. Generate table for math images, style it and insert into collapse table title.
Wed, Mar 17, 1:01 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Page Content Service

Mar 7 2021

vadim-kovalenko moved T202923: [BUG] Internal link to a section in the article takes to to the beginning of the article from To Do to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Mar 7 2021, 8:58 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Page Content Service

Mar 4 2021

vadim-kovalenko added a comment to T202923: [BUG] Internal link to a section in the article takes to to the beginning of the article.
  1. In Java article there is an anchor tag
Mar 4 2021, 2:41 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Page Content Service
vadim-kovalenko claimed T253004: [Bug] mobile-html: exclude reference lists with `data-mw-group` from collapsing logic.
Mar 4 2021, 1:24 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
vadim-kovalenko updated subscribers of T202923: [BUG] Internal link to a section in the article takes to to the beginning of the article.

Hi @MSantos , @Sharvaniharan !
Does this bug relate to the mobileapps eventually? I've checked the incoming response here.
It seems, that this broken link is building on some other level of the application, because I receive it in response as-is.
Could you point me where to find the source of this bug?

Mar 4 2021, 11:36 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Page Content Service

Mar 3 2021

vadim-kovalenko claimed T202923: [BUG] Internal link to a section in the article takes to to the beginning of the article.
Mar 3 2021, 3:06 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Page Content Service

Mar 1 2021

vadim-kovalenko added a comment to T275226: Some terms on glossary articles do not appear on black theme.

Steps to reproduce on the local environment
Run application ( mobileapps ), check 'black' and 'dark' themes by adding '?theme=black' and '?theme=dark' as a parameter. Example:

Mar 1 2021, 7:21 AM · Product-Infrastructure-Team-Backlog (Kanban)
vadim-kovalenko moved T275226: Some terms on glossary articles do not appear on black theme from Sprint Backlog (1/19-2/2.2021) to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Mar 1 2021, 7:16 AM · Product-Infrastructure-Team-Backlog (Kanban)

Feb 25 2021

vadim-kovalenko claimed T274972: Hard deprecate WatchedItem::getUser.
Feb 25 2021, 11:03 AM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Technical-Debt, Platform Team Workboards (MW Expedition)

Feb 23 2021

vadim-kovalenko renamed T275482: Avoid using UserIdentity::getUserId. Use UserIdentity::getId instead. from Removing UserIdentity::getId to Avoid using UserIdentity::getUserId. Use UserIdentity::getId instead..
Feb 23 2021, 12:16 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Growth-Team (Current Sprint), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management
vadim-kovalenko created T275482: Avoid using UserIdentity::getUserId. Use UserIdentity::getId instead..
Feb 23 2021, 11:04 AM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Growth-Team (Current Sprint), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management

Feb 22 2021

vadim-kovalenko added a comment to T274329: Replace LogEntry::getPerformer with ::getPerformerIdentity.

Patch 665639 depends on 664909

Feb 22 2021, 11:55 AM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Platform Team Workboards (MW Expedition)

Feb 17 2021

vadim-kovalenko committed rEFLI1063a591a9c9: Avoid using LogEntry::getPerformer in favor of getPerformerIdentity (authored by vadim-kovalenko).
Avoid using LogEntry::getPerformer in favor of getPerformerIdentity
Feb 17 2021, 9:50 PM

Jan 29 2021

vadim-kovalenko moved T254047: [OTRS bug] horizontal scrolling issue on German IBM article from Sprint Backlog (1/19-2/2.2021) to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jan 29 2021, 10:43 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog
vadim-kovalenko moved T109596: Media help should not be displayed from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jan 29 2021, 10:43 AM · Page Content Service, Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Android-app-Bugs, WorkType-Maintenance, Wikipedia-Android-App-Backlog

Jan 20 2021

vadim-kovalenko moved T265687: Update PCS language variants mapping from siteinfo from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jan 20 2021, 3:25 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Chinese-Sites, Page Content Service

Jan 15 2021

vadim-kovalenko moved T198534: [BUG] Thumb border images in articles shown are being shown with no border in the Android app from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jan 15 2021, 3:50 PM · Product-Infrastructure-Team-Backlog (Kanban), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Wikipedia-Android-App-Backlog, Page Content Service, Android-app-Bugs
vadim-kovalenko added a comment to T269569: Wikipedia app - random article randomness is weak.

Hi! I've tried to reproduce the issue on Android platform. I've tested "Random article" function with over 300 items but did not get duplicates.

Jan 15 2021, 2:39 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Wikifeeds, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog

Dec 29 2020

vadim-kovalenko claimed T198534: [BUG] Thumb border images in articles shown are being shown with no border in the Android app.
Dec 29 2020, 5:06 PM · Product-Infrastructure-Team-Backlog (Kanban), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Wikipedia-Android-App-Backlog, Page Content Service, Android-app-Bugs