Page MenuHomePhabricator

vadim-kovalenko (Vadim Kovalenko)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 20 2020, 1:35 PM (89 w, 5 d)
Availability
Available
LDAP User
Vadim Kovalenko
MediaWiki User
Unknown

Recent Activity

Yesterday

vadim-kovalenko added a comment to T279472: Page previews show last revision instead of flagged revision.

@Tacsipacsi , thank you for the extra info!

What does your patch affect? It’s in a repo named mobileapps, while the original report was about Page Previews, a desktop browser feature.

Page Previews extension relies on the response of the /summary endpoint which is handled inside mobileapps service.

Tue, Aug 9, 7:39 AM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Mobile-Content-Service, MediaWiki-extensions-FlaggedRevs

Mon, Aug 8

vadim-kovalenko moved T279472: Page previews show last revision instead of flagged revision from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Mon, Aug 8, 2:47 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Mobile-Content-Service, MediaWiki-extensions-FlaggedRevs
vadim-kovalenko added a comment to T279472: Page previews show last revision instead of flagged revision.

I've uploaded the patch to resolve flagged revisions (only for the German wiki for now). Useful links:

Mon, Aug 8, 2:36 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Mobile-Content-Service, MediaWiki-extensions-FlaggedRevs

Tue, Jul 26

vadim-kovalenko updated subscribers of T312667: Articles have incorrect horizontal scrolling with blank space..

Hi @LGoto!
Patch with the fix has been deployed to prod.
cc: @Tsevener

Tue, Jul 26, 6:14 PM · iOS-app-v6.9.3, Wikipedia-Android-App-Backlog (Android Release FY2022-23), Page Content Service, Wikipedia-iOS-App-Backlog, Product-Infrastructure-Team-Backlog

Wed, Jul 20

vadim-kovalenko moved T311616: On English Wikipedia, Template:Ref overlaps with surrounding text from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog (Kanban) board.
Wed, Jul 20, 12:30 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog

Tue, Jul 19

vadim-kovalenko moved T301007: [Bug] Reference links not working in HIV/AIDs article from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog (Kanban) board.
Tue, Jul 19, 6:40 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog, iOS-app-Bugs
vadim-kovalenko moved T301007: [Bug] Reference links not working in HIV/AIDs article from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog board.
Tue, Jul 19, 6:39 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog, iOS-app-Bugs
vadim-kovalenko added a comment to T209837: Smaller font in euwiki PDF downloads than in other wikis.

Hi @Theklan ! Could you provide an example of the issue? Seems that articles with galleries are converted fine at the moment.

Tue, Jul 19, 10:36 AM · Proton, Product-Infrastructure-Team-Backlog
vadim-kovalenko added a comment to T275987: Proton drops wiki markup bullet points from lists that are left-aligned on RTL page.

@Aklapper, this has been fixed. Could you recheck?

Tue, Jul 19, 10:33 AM · Product-Infrastructure-Team-Backlog, I18n, Proton

Mon, Jul 18

vadim-kovalenko moved T311804: Update Proton to include Chromium 103.0.5060.53 from To Do to To Deploy on the Product-Infrastructure-Team-Backlog (Kanban) board.
Mon, Jul 18, 8:15 AM · Product-Infrastructure-Team-Backlog (Kanban), Proton
vadim-kovalenko moved T311804: Update Proton to include Chromium 103.0.5060.53 from Upcoming to Kanban on the Product-Infrastructure-Team-Backlog board.
Mon, Jul 18, 8:14 AM · Product-Infrastructure-Team-Backlog (Kanban), Proton

Fri, Jul 15

vadim-kovalenko changed the status of T312667: Articles have incorrect horizontal scrolling with blank space. from Open to In Progress.
Fri, Jul 15, 4:14 PM · iOS-app-v6.9.3, Wikipedia-Android-App-Backlog (Android Release FY2022-23), Page Content Service, Wikipedia-iOS-App-Backlog, Product-Infrastructure-Team-Backlog
vadim-kovalenko updated subscribers of T305357: Long captions overflow their parent.

I reverted these changes here
Revised issue from the description using Xcode for multiple iPads (see the shots), was unable to reproduce overflow of the parent element.
iPad Pro (12.9 inch)

iPad Pro (12.9 inch).png (1×1 px, 462 KB)

iPad Pro (11 inch)
iPad Pro (11 inch).png (1×1 px, 494 KB)

iPad Pro (9.7 inch)
iPad Pro (9.7 inch).png (1×1 px, 547 KB)

Fri, Jul 15, 4:12 PM · Patch-For-Review, Page Content Service, Parsoid (Tracking)

Thu, Jul 14

vadim-kovalenko added a comment to T284837: Article content scrolls horizontally.

Yes, it's the same issue. For some reason, arbitrary sections nested into the previous section. Set this task in progress.

nested-sections.png (338×605 px, 75 KB)

Thu, Jul 14, 2:30 PM · Product-Infrastructure-Team-Backlog (Kanban), ios-app-v7.0, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
vadim-kovalenko changed the status of T284837: Article content scrolls horizontally from Open to In Progress.
Thu, Jul 14, 2:28 PM · Product-Infrastructure-Team-Backlog (Kanban), ios-app-v7.0, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
vadim-kovalenko moved T284837: Article content scrolls horizontally from Backlog to Kanban on the Product-Infrastructure-Team-Backlog board.
Thu, Jul 14, 2:19 PM · Product-Infrastructure-Team-Backlog (Kanban), ios-app-v7.0, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
vadim-kovalenko moved T284837: Article content scrolls horizontally from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Thu, Jul 14, 2:19 PM · Product-Infrastructure-Team-Backlog (Kanban), ios-app-v7.0, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
vadim-kovalenko claimed T284837: Article content scrolls horizontally.
Thu, Jul 14, 2:18 PM · Product-Infrastructure-Team-Backlog (Kanban), ios-app-v7.0, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
vadim-kovalenko added a comment to T284837: Article content scrolls horizontally.

For some reason, the horizontal scroll disappears and works fine after scrolling down the article.

Thu, Jul 14, 12:00 PM · Product-Infrastructure-Team-Backlog (Kanban), ios-app-v7.0, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
vadim-kovalenko added a comment to T284837: Article content scrolls horizontally.

Hi @Tsevener ! Do you mean this bug?


I reproduced it on both Android and iOS mobile phones.

Thu, Jul 14, 11:58 AM · Product-Infrastructure-Team-Backlog (Kanban), ios-app-v7.0, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Wed, Jul 13

vadim-kovalenko moved T311616: On English Wikipedia, Template:Ref overlaps with surrounding text from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Wed, Jul 13, 7:09 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog
vadim-kovalenko updated subscribers of T311616: On English Wikipedia, Template:Ref overlaps with surrounding text.

This issue happened because the template utilizes .plainlinks a { padding: 0 !important } rule from base.css. I explicitly set !important for paddings of the touch target links.
@MSantos , @Jgiannelos

Wed, Jul 13, 7:09 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog

Tue, Jul 12

vadim-kovalenko moved T311616: On English Wikipedia, Template:Ref overlaps with surrounding text from Upcoming to Kanban on the Product-Infrastructure-Team-Backlog board.
Tue, Jul 12, 9:05 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog
vadim-kovalenko moved T311616: On English Wikipedia, Template:Ref overlaps with surrounding text from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Tue, Jul 12, 9:05 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog
vadim-kovalenko claimed T311616: On English Wikipedia, Template:Ref overlaps with surrounding text.
Tue, Jul 12, 9:04 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog

Jul 11 2022

vadim-kovalenko moved T301007: [Bug] Reference links not working in HIV/AIDs article from To Do to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jul 11 2022, 3:23 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog, iOS-app-Bugs
vadim-kovalenko claimed T301007: [Bug] Reference links not working in HIV/AIDs article .
Jul 11 2022, 3:23 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog, iOS-app-Bugs

Jul 1 2022

vadim-kovalenko updated subscribers of T279472: Page previews show last revision instead of flagged revision.

Considering Flagged Revision description (link - https://en.wikipedia.org/wiki/Wikipedia:Flagged_revisions) not all wikis use it.
For those wikis, that have FlaggedRevs, related API helps to retrieve more information for current and stable revisions. Example for German wiki:
https://de.wikipedia.org/w/api.php?action=query&prop=info|flagged&titles=sandbox

Jul 1 2022, 2:38 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Mobile-Content-Service, MediaWiki-extensions-FlaggedRevs

Jun 29 2022

vadim-kovalenko added a comment to T298814: Add optional talk page icon to the mobile-html endpoint.

Hi @cooltey . Please, take a look at the screenshot:

edit-icon-issue.png (1×3 px, 851 KB)

The very first section has different CSS rules for the edit button compared to the next and upcoming sections. Reasons for that are unknown, but I'd like to make these sections consistent somehow. Maybe it is a good idea to create a dedicated container that will store all possible icons and then attach this container to sections and the header. This will help to prevent glitches while button toggling. But the caveat is if the button container will have a width more than width of 2 buttons and we decide to add 3rd button later, text on the left side will have more line breaks.

Jun 29 2022, 3:40 PM · Product-Infrastructure-Team-Backlog, Patch-For-Review, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog
vadim-kovalenko added a comment to T305763: "View edit history" menu item in the mobile-html footer shows incorrect edit status in zhwiki.

Not sure if we can override messages directly in mobileapps/i18n since the Translation updater bot does this automatically. @MSantos, what do you think?

Jun 29 2022, 10:11 AM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Parsoid (Tracking), Wikipedia-Android-App-Backlog, Chinese-Sites, Page Content Service, RESTBase

Jun 28 2022

vadim-kovalenko added a comment to T298814: Add optional talk page icon to the mobile-html endpoint.

@MSantos , @Jgiannelos pls take a look at this patch:
https://gerrit.wikimedia.org/r/c/mediawiki/services/mobileapps/+/805336

Jun 28 2022, 3:28 PM · Product-Infrastructure-Team-Backlog, Patch-For-Review, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog

Jun 22 2022

vadim-kovalenko moved T301007: [Bug] Reference links not working in HIV/AIDs article from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog board.
Jun 22 2022, 12:05 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog, iOS-app-Bugs
vadim-kovalenko added a comment to T305763: "View edit history" menu item in the mobile-html footer shows incorrect edit status in zhwiki.

@cooltey , I'm going to refactor i18n plural rules for messages for zh-hant here and zh-hans here in mobileapps. Could you suggest the right translation for both variants (zh-hant and zh-hans) when it comes to translating these words: Updated today, Updated yesterday, Updated N days ago ?

Jun 22 2022, 11:07 AM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Parsoid (Tracking), Wikipedia-Android-App-Backlog, Chinese-Sites, Page Content Service, RESTBase

Jun 17 2022

vadim-kovalenko added a comment to T305763: "View edit history" menu item in the mobile-html footer shows incorrect edit status in zhwiki.

Hi @Nikerabbit , thank you for the additional info about the banana-i18n library. I will provide more details. Please, install banana-i18n in isolated environment and check this code snippet for zh-hant:

const Banana = require('banana-i18n')
const banana = new Banana('lzh')
Jun 17 2022, 2:47 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Parsoid (Tracking), Wikipedia-Android-App-Backlog, Chinese-Sites, Page Content Service, RESTBase

Jun 14 2022

vadim-kovalenko added a comment to T298814: Add optional talk page icon to the mobile-html endpoint.

Hi @cooltey ! I suspect that happens when you try to set the talk page icon before all other HTML has been rendered. In the current implementation, this button is configured inside the onBodyEnd() function here and this is expected because we need the header to render first to append the icon to it. I have a few questions that might help me to reduce the scope of the problem:

  1. Do all articles throw an error when you try to set talkPageButton: true or the only these two mentioned in your comment?
  2. Do you try to set it before HTML has been loaded? In that case, it won't work.
  3. Maybe you could explain how you wire the button in the app itself so I can also be able to reproduce this issue?
Jun 14 2022, 12:03 PM · Product-Infrastructure-Team-Backlog, Patch-For-Review, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog

Jun 10 2022

vadim-kovalenko moved T279472: Page previews show last revision instead of flagged revision from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jun 10 2022, 1:26 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Mobile-Content-Service, MediaWiki-extensions-FlaggedRevs
vadim-kovalenko moved T279472: Page previews show last revision instead of flagged revision from Needs investigation to Kanban on the Product-Infrastructure-Team-Backlog board.
Jun 10 2022, 1:26 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Mobile-Content-Service, MediaWiki-extensions-FlaggedRevs
vadim-kovalenko changed the status of T279472: Page previews show last revision instead of flagged revision from Open to In Progress.
Jun 10 2022, 1:25 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Mobile-Content-Service, MediaWiki-extensions-FlaggedRevs
vadim-kovalenko moved T273132: Featured article missing from feeds in Spanish from Needs triage to Tracking on the Product-Infrastructure-Team-Backlog board.
Jun 10 2022, 1:10 PM · Product-Infrastructure-Team-Backlog, RESTBase, Wikipedia-Android-App-Backlog
vadim-kovalenko edited projects for T273132: Featured article missing from feeds in Spanish, added: Product-Infrastructure-Team-Backlog; removed Product-Infrastructure-Team-Backlog (Kanban).
Jun 10 2022, 1:10 PM · Product-Infrastructure-Team-Backlog, RESTBase, Wikipedia-Android-App-Backlog
vadim-kovalenko moved T305763: "View edit history" menu item in the mobile-html footer shows incorrect edit status in zhwiki from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jun 10 2022, 12:04 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Parsoid (Tracking), Wikipedia-Android-App-Backlog, Chinese-Sites, Page Content Service, RESTBase
vadim-kovalenko updated subscribers of T305763: "View edit history" menu item in the mobile-html footer shows incorrect edit status in zhwiki.

I've implemented View edit history functionality and added i18n tests for Arabic. As for zh languages, they won't work properly till zh-hans and zh-hant (along with some others) be introduced in the banana-i18n package (full list of supported languages here). @Nikerabbit , what do you think? You've mentioned zh and mk languages in https://phabricator.wikimedia.org/T249541#7569365 but mobileapps has 134 predefined language variants compared with banana-i18n which has only ~12 corresponding langs and some fallbacks.

Jun 10 2022, 12:03 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Parsoid (Tracking), Wikipedia-Android-App-Backlog, Chinese-Sites, Page Content Service, RESTBase

Jun 8 2022

vadim-kovalenko moved T305763: "View edit history" menu item in the mobile-html footer shows incorrect edit status in zhwiki from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jun 8 2022, 2:58 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Parsoid (Tracking), Wikipedia-Android-App-Backlog, Chinese-Sites, Page Content Service, RESTBase
vadim-kovalenko moved T305763: "View edit history" menu item in the mobile-html footer shows incorrect edit status in zhwiki from Upcoming to Kanban on the Product-Infrastructure-Team-Backlog board.
Jun 8 2022, 2:58 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Parsoid (Tracking), Wikipedia-Android-App-Backlog, Chinese-Sites, Page Content Service, RESTBase
vadim-kovalenko changed the status of T305763: "View edit history" menu item in the mobile-html footer shows incorrect edit status in zhwiki from Open to In Progress.
Jun 8 2022, 2:57 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Parsoid (Tracking), Wikipedia-Android-App-Backlog, Chinese-Sites, Page Content Service, RESTBase
vadim-kovalenko added a comment to T306876: Android app edit summary becomes URL encoded.

Thank you @cscott, I've added a fix for parsing the legacy HTML output and set the patch to the code review.

Jun 8 2022, 11:03 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Chinese-Sites
vadim-kovalenko moved T306876: Android app edit summary becomes URL encoded from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jun 8 2022, 11:01 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Chinese-Sites

Jun 7 2022

vadim-kovalenko added a comment to T306876: Android app edit summary becomes URL encoded.

The patch above is intended to test a possible solution. Seems that Parsoid propagates already encoded id values and I'm able to decode them on mobile apps (only for zh wiki). Parsoid output - https://zh.wikipedia.org/api/rest_v1/page/html/%E5%BC%80%E5%B9%B3%E5%B8%82/71986109 (see the shot as well).

Screenshot 2022-06-07 at 16.47.06.png (1×1 px, 563 KB)

Jun 7 2022, 1:58 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Chinese-Sites
vadim-kovalenko updated subscribers of T306191: Display issue with pie chart in dark mode.

This problem can be fixed by adding the background-color: initial rule to the pie chart divs which represent sectors.

Jun 7 2022, 1:43 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog

Jun 6 2022

vadim-kovalenko moved T306876: Android app edit summary becomes URL encoded from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jun 6 2022, 1:39 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Chinese-Sites
vadim-kovalenko moved T306876: Android app edit summary becomes URL encoded from Upcoming to Kanban on the Product-Infrastructure-Team-Backlog board.
Jun 6 2022, 1:38 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Chinese-Sites
vadim-kovalenko changed the status of T306876: Android app edit summary becomes URL encoded from Open to In Progress.
Jun 6 2022, 1:36 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Chinese-Sites
vadim-kovalenko moved T306191: Display issue with pie chart in dark mode from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jun 6 2022, 8:35 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog
vadim-kovalenko moved T306191: Display issue with pie chart in dark mode from Upcoming to Kanban on the Product-Infrastructure-Team-Backlog board.
Jun 6 2022, 8:34 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog
vadim-kovalenko changed the status of T306191: Display issue with pie chart in dark mode from Open to In Progress.
Jun 6 2022, 8:32 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog

Jun 3 2022

vadim-kovalenko updated subscribers of T305777: On this day feed card content cannot be found in the on this day list.

This might be an issue on the Anroid devices only. I reproduced this issue with these steps:

  1. Check the explore feed on the Android app. Feature feed triggers this endpoint - https://en.wikipedia.org/api/rest_v1/feed/featured/2022/04/08 where onthisday property contains the page that we need to view when clicking to More on this day →link.
  2. Click More on this day →. From this point, I suspect that Android app invokes https://en.wikipedia.org/api/rest_v1/feed/onthisday/events/4/8 instead of https://en.wikipedia.org/api/rest_v1/feed/onthisday/selected/4/8 ( If you check selected API, you'll be able to find The Knights Hospitaller … Mamluk sultan Baibars. which was mentioned in the description )
Jun 3 2022, 3:18 PM · Product-Infrastructure-Team-Backlog, Wikifeeds, Wikipedia-Android-App-Backlog

Jun 2 2022

vadim-kovalenko moved T305777: On this day feed card content cannot be found in the on this day list from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jun 2 2022, 7:54 AM · Product-Infrastructure-Team-Backlog, Wikifeeds, Wikipedia-Android-App-Backlog
vadim-kovalenko moved T305777: On this day feed card content cannot be found in the on this day list from Upcoming to Kanban on the Product-Infrastructure-Team-Backlog board.
Jun 2 2022, 7:54 AM · Product-Infrastructure-Team-Backlog, Wikifeeds, Wikipedia-Android-App-Backlog

Jun 1 2022

vadim-kovalenko changed the status of T305777: On this day feed card content cannot be found in the on this day list from Open to In Progress.
Jun 1 2022, 10:32 AM · Product-Infrastructure-Team-Backlog, Wikifeeds, Wikipedia-Android-App-Backlog

May 31 2022

vadim-kovalenko moved T307407: Issues w/ Arabic Wikipedia in app from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog board.
May 31 2022, 2:23 PM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog
vadim-kovalenko moved T307407: Issues w/ Arabic Wikipedia in app from To Do to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
May 31 2022, 2:23 PM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog

May 30 2022

vadim-kovalenko updated subscribers of T305763: "View edit history" menu item in the mobile-html footer shows incorrect edit status in zhwiki.

A similar issue was mentioned here: T249541. After additional research, I've found that View edit history functionality had not been implemented at all. Check PCS here - https://github.com/wikimedia/mobileapps/blob/master/pagelib/src/pcs/c1/DemoMode.js#L23. The value of editedDaysAgo is hardcoded and was intended to be replaced by upcoming (?) functionality. I checked example of the summary endpoint of one of the article, but it seems that there is no explicit property editedDaysAgo there. However, I can calculate it inside PCS using the timestamp property and then render it on the footer.
@MSantos, @Jgiannelos , what do you think?

May 30 2022, 2:09 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Parsoid (Tracking), Wikipedia-Android-App-Backlog, Chinese-Sites, Page Content Service, RESTBase
vadim-kovalenko updated subscribers of T307407: Issues w/ Arabic Wikipedia in app.

After additional research and testing, I've found that attempting to add body.pcs-platform-ios didn't make any changes. But instead, font overriding applied for wikipedia-ios.
Here is a screenshot that compares wikipedia-ios updated font | current font (which is actual now) | mobileapps updated font via body.pcs-platform-ios class:

Screen comparison.png (1×3 px, 1 MB)

May 30 2022, 10:02 AM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog

May 27 2022

vadim-kovalenko added a comment to T307407: Issues w/ Arabic Wikipedia in app.

I will try to test both variants. I already have some results with overridden styleoverrides.css but will test with PSC as well.

May 27 2022, 7:15 PM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog

May 25 2022

vadim-kovalenko added a comment to T306281: Boxes in French Wikipedia Skew Section Headers.

These cc rules affect the output of mobile devices. I disabled them to quickly check if it helps.

template-style.png (543×1 px, 138 KB)

I could try to reset them in mobile apps considering it works fine on the mobile version of the wiki. @MattCleinman , what do you think?

May 25 2022, 10:05 AM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog

May 24 2022

alaa awarded T307407: Issues w/ Arabic Wikipedia in app a Like token.
May 24 2022, 3:53 PM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog
vadim-kovalenko added a comment to T307407: Issues w/ Arabic Wikipedia in app.

@MattCleinman CSS rules came from load.php for parsoid output and from https://ar.wikipedia.org/api/rest_v1/data/css/mobile/site for mobileapps ( even for local instance ). Check the shot:

site-css.png (1×3 px, 2 MB)

site.css depends on ResourceLoader. Because it provides styles for the entire body, I’m unable to override it with different font only for iOS ( if at least I can apply something like body.pcs-platform-ios {font-family: -apple-system !important;} ). Maybe it is possible to override that font directly in wikipedia-ios?

May 24 2022, 3:46 PM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog

May 20 2022

vadim-kovalenko claimed T307407: Issues w/ Arabic Wikipedia in app.
May 20 2022, 11:25 AM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog

May 19 2022

vadim-kovalenko moved T298814: Add optional talk page icon to the mobile-html endpoint from Sign off to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
May 19 2022, 5:50 PM · Product-Infrastructure-Team-Backlog, Patch-For-Review, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog

May 18 2022

vadim-kovalenko added a comment to T306281: Boxes in French Wikipedia Skew Section Headers.

Styles of the template Autres_projets break layout in this particular article. I suggest refactoring template styles or re-editing the article. I've checked other articles with this template on mobile-html (see the list of them here - https://fr.wikipedia.org/wiki/Sp%C3%A9cial:Pages_li%C3%A9es/Mod%C3%A8le:Autres_projets). Though most of them don't look quite well on mobile viewport, no similar issues have been found.

May 18 2022, 2:29 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog
vadim-kovalenko moved T306281: Boxes in French Wikipedia Skew Section Headers from Upcoming to Kanban on the Product-Infrastructure-Team-Backlog board.
May 18 2022, 1:34 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog
vadim-kovalenko moved T306281: Boxes in French Wikipedia Skew Section Headers from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
May 18 2022, 1:34 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog
vadim-kovalenko changed the status of T306281: Boxes in French Wikipedia Skew Section Headers from Open to In Progress.
May 18 2022, 1:34 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog

May 12 2022

vadim-kovalenko added a comment to T307783: Generate dataset of pages to check for colour contrast issues.

Created first MR here - https://gitlab.wikimedia.org/jgiannelos/mobileapps-a11y-tests/-/merge_requests/1

May 12 2022, 3:23 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service

May 11 2022

vadim-kovalenko added a comment to T289575: Resolve redirects for page/related endpoint.

@Jgiannelos It should be closed because PR has been merged.

May 11 2022, 1:39 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service

May 10 2022

vadim-kovalenko updated subscribers of T279432: Android app: All references appear empty on one specific article.

Fixed regression caused by patch for May 5. Pls, check the updated one.
cc: @MSantos , @Jgiannelos

May 10 2022, 11:04 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-Android-App-Backlog

May 9 2022

vadim-kovalenko added a comment to T298814: Add optional talk page icon to the mobile-html endpoint.

Hi @cooltey . Sure, I'll take a look.

May 9 2022, 10:02 AM · Product-Infrastructure-Team-Backlog, Patch-For-Review, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog

May 2 2022

vadim-kovalenko updated subscribers of T306277: Tapping article image pushes on web view instead of presenting gallery.

Hi @Tsevener ! I've restored previous functionality and kept fixes from the T294899 at the same time. The issue was in the in sGalleryImage method which was intended to parse all images instead of only nested in the unordered list with typeof = mw:Extension/gallery attribute. Pls, check.
cc: @Jgiannelos

May 2 2022, 11:32 AM · Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.1-Carp-On-A-Moon-Lander, Regression, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
vadim-kovalenko changed the status of T306277: Tapping article image pushes on web view instead of presenting gallery from Open to In Progress.
May 2 2022, 9:58 AM · Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.1-Carp-On-A-Moon-Lander, Regression, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
vadim-kovalenko added a comment to T270833: Span node title attribute not (always?) rendered properly in mobile.

@Kelson I've just asked a question about this in the template discussion thread. I'll keep you posted if get any updates.

May 2 2022, 7:21 AM · Product-Infrastructure-Team-Backlog, Mobile-Content-Service, Parsoid (Tracking), affects-Kiwix-and-openZIM
vadim-kovalenko added a comment to T295255: Page Previews API returns empty summaries for certain requests on Wikivoyage.

@Titore Thank you for your attention to this problem. I will take into consideration your case while working on the patch which is currently in progress.

May 2 2022, 5:49 AM · Product-Infrastructure-Team-Backlog (Kanban), Mobile-Content-Service, Page-Previews (Tracking)

Apr 29 2022

vadim-kovalenko updated the task description for T305549: Collect analytics for theme issues across different wikis which uses specific templates. Add performance tests..
Apr 29 2022, 2:50 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service
vadim-kovalenko added a comment to T305549: Collect analytics for theme issues across different wikis which uses specific templates. Add performance tests..

Related repo with analytics functionality - https://github.com/VadimKovalenkoSNF/wmf-theme-issues-analytics
cc: @Jgiannelos

Apr 29 2022, 2:47 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service

Apr 25 2022

vadim-kovalenko added a comment to T306277: Tapping article image pushes on web view instead of presenting gallery.

Hi @Tsevener ! I was unable to reproduce the issue on my Android device (see the version on the shot). Could you please provide some more screenshots or videos of the current gallery behavior?

wiki-android-version.jpg (447×1 px, 22 KB)

Apr 25 2022, 2:44 PM · Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.1-Carp-On-A-Moon-Lander, Regression, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Apr 19 2022

vadim-kovalenko added a comment to T270833: Span node title attribute not (always?) rendered properly in mobile.

@Kelson As per docs for this template the tip should not be rendered on the mobile app. And it actually doesn't - see the shot. Not sure whether we need to do extra actions here.

comment-template.jpg (1×647 px, 132 KB)

Apr 19 2022, 9:16 AM · Product-Infrastructure-Team-Backlog, Mobile-Content-Service, Parsoid (Tracking), affects-Kiwix-and-openZIM
vadim-kovalenko added a comment to T295255: Page Previews API returns empty summaries for certain requests on Wikivoyage.

@Brycehughes cases with Barcelona and Tokyo also have been fixed in the patch above, I've just checked them. Once this patch goes to the beta cluster it will be more convenient to test other cases where this issue might happen.

Apr 19 2022, 7:19 AM · Product-Infrastructure-Team-Backlog (Kanban), Mobile-Content-Service, Page-Previews (Tracking)

Apr 15 2022

vadim-kovalenko updated subscribers of T295255: Page Previews API returns empty summaries for certain requests on Wikivoyage.

@Brycehughes could you specify which exactly article did you test? I suspect that this might be a cache issue but not sure. I also found another article with exactly the same problem ( go to https://en.wikivoyage.org/wiki/Auschwitz-Birkenau, hover Oświęcim), so I put additional fixes in the follow-up patch above.
cc: @Arlolra , @MSantos

Apr 15 2022, 9:37 AM · Product-Infrastructure-Team-Backlog (Kanban), Mobile-Content-Service, Page-Previews (Tracking)

Apr 13 2022

vadim-kovalenko moved T279432: Android app: All references appear empty on one specific article from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Apr 13 2022, 11:02 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-Android-App-Backlog

Apr 8 2022

vadim-kovalenko updated subscribers of T298814: Add optional talk page icon to the mobile-html endpoint.

@MattCleinman Patch above is ready for review.
cc: @MSantos , @Jgiannelos

Apr 8 2022, 6:47 PM · Product-Infrastructure-Team-Backlog, Patch-For-Review, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog
vadim-kovalenko closed T299130: Upgrade kartotherian/snapshot to node12, a subtask of T301475: Migrate kartotherian production service to node12, as Resolved.
Apr 8 2022, 12:53 PM · WMDE-TechWish-Maintenance, serviceops
vadim-kovalenko closed T299130: Upgrade kartotherian/snapshot to node12 as Resolved.
Apr 8 2022, 12:53 PM · Maps (Kartotherian)
vadim-kovalenko added a comment to T299130: Upgrade kartotherian/snapshot to node12.

No, it isn't. I'm closing it.

Apr 8 2022, 12:52 PM · Maps (Kartotherian)

Apr 6 2022

vadim-kovalenko changed the status of T305549: Collect analytics for theme issues across different wikis which uses specific templates. Add performance tests. from Open to In Progress.
Apr 6 2022, 1:17 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service
vadim-kovalenko changed the status of T305549: Collect analytics for theme issues across different wikis which uses specific templates. Add performance tests., a subtask of T286643: [EPIC] Systematic solution on preventing rendering issues on user styles between dark/light themes, from Open to In Progress.
Apr 6 2022, 1:17 PM · Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Product-Infrastructure-Team-Backlog, Page Content Service
vadim-kovalenko created T305549: Collect analytics for theme issues across different wikis which uses specific templates. Add performance tests..
Apr 6 2022, 1:15 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service

Mar 28 2022

vadim-kovalenko moved T279432: Android app: All references appear empty on one specific article from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Mar 28 2022, 11:50 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-Android-App-Backlog
vadim-kovalenko moved T279432: Android app: All references appear empty on one specific article from Needs investigation to Kanban on the Product-Infrastructure-Team-Backlog board.
Mar 28 2022, 11:50 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-Android-App-Backlog
vadim-kovalenko moved T298814: Add optional talk page icon to the mobile-html endpoint from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Mar 28 2022, 11:49 AM · Product-Infrastructure-Team-Backlog, Patch-For-Review, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog
vadim-kovalenko changed the status of T279432: Android app: All references appear empty on one specific article from Open to In Progress.
Mar 28 2022, 11:49 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-Android-App-Backlog

Mar 22 2022

vadim-kovalenko updated subscribers of T284423: Inline templates in the lead sections won't show on page preview, reducing readability.

This issue happens because /summary endpoint receives wrong extract and extract_html properties. Similar problem has been resolved in this task: https://phabricator.wikimedia.org/T295255
However, this particular case happens because mobileapps removes necessary data from the tag attribute.
Here is the problem part of the Parsoid output that is received by processing module (lib/processing.js):

Mar 22 2022, 2:49 PM · Parsoid, Page-Previews (Tracking), Mobile-Content-Service, Product-Infrastructure-Team-Backlog, Chinese-Sites