Page MenuHomePhabricator

valhallasw (Merlijn van Deen)
Pywikibot / Tool Labs

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 3 2014, 1:14 PM (490 w, 1 d)
Availability
Available
IRC Nick
valhallasw (typically around in European evenings)
LDAP User
Merlijn van Deen
MediaWiki User
Valhallasw [ Global Accounts ]

Recent Activity

Sun, Feb 18

valhallasw added a comment to T357851: bd808's big pile of refactoring ideas.

Sounds like a good way to bring wikibugs up to date with what has been learned in the software engineering world over the last 10 years :-)

Sun, Feb 18, 9:30 AM · Wikibugs
valhallasw added a comment to T357852: Replace pywikibot with mwclient in taxonomy.py.

From what I can see, this role has been taken over by Crystal-bot so I would suggest to just remove the code althogether.

Sun, Feb 18, 9:25 AM · Wikibugs

Sat, Feb 17

valhallasw closed T89674: get redis2irc to show formatting errors as Invalid.

I don't 😅. My guess would be that it has something to do with incorrect IRC formatting being ignored, but I can't find an obvious "except Exception: ..." in the 2015-era source code. So closing, if it had been important it wouldn't have stayed a 1-line bug for 10 years.

Sat, Feb 17, 11:06 AM · Wikibugs
valhallasw added a comment to T357729: wikibugs having a hard time staying connected to libera.chat IRC network.

Until @valhallasw gets annoyed by me and kicks me out anyway. ;)

I, for one, welcome our new unicorn overlords.

Sat, Feb 17, 10:58 AM · User-bd808, Wikibugs

Fri, Feb 16

valhallasw added a comment to T357729: wikibugs having a hard time staying connected to libera.chat IRC network.

Is anything visible from other IRC clients? i.e. do they see a connection reset by peer, a forced close due to X, ...?

Fri, Feb 16, 6:15 PM · User-bd808, Wikibugs

Wed, Feb 14

valhallasw added a comment to T199007: Frequent exception while trying to extract anchors from task.

I also think this may have been broken for 6 years now without too much notice except when folks are staring at the bot's logs for some other reason.

The corollary of that is that maybe linking to a specific comment/action isn't that relevant to begin with - so just removing the functionality might be a sensible option as well :-)

Wed, Feb 14, 5:08 PM · User-bd808, Wikibugs

Fri, Jan 26

valhallasw added a comment to T288381: Connect WikiBugs IRC bot to Wikimedia GitLab.

This could now presumably be built on top of https://wikitech.wikimedia.org/wiki/GitLab/Phabricator_integration (either using Redis as intermediary between the two repos, or by moving Wikibugs under the gitlab-webhooks repo).

Fri, Jan 26, 10:02 AM · Release-Engineering-Team (Priority Backlog 📥), GitLab (Integrations), Wikibugs
valhallasw added a comment to T289712: Investigate whether we can/should integrate Git/Reviewers with GitLab.

@valhallasw Can you explain this section of ReviewerFactory._reviewer_generator() in the Gerrit reviewer bot code:
https://github.com/valhallasw/gerrit-reviewer-bot/blob/dcb31716af142494716a35a5fad239add8e368af/add_reviewer.py#L61

elif part.name == "every":
    modulo = self._tryParseInt(part.value, 1)
    if modulo < 2:
        modulo = 1

I wasn't able to find any documentation about an every template parameter. It appears that the intention is to add matching reviewers somewhat probabilistically. I notice in ReviewerFactory._filter_reviewers() that variable i is never advanced past 0 which appears to be a bug.

Fri, Jan 26, 9:58 AM · Patch-For-Review, Release-Engineering-Team (Priority Backlog 📥), GitLab (Integrations), User-brennen, Developer Productivity, Code-Health

Jan 7 2024

Don-vip awarded T97861: [toolforge.infra] Provide centralized logging (logstash) for Toolforge a Hungry Hippo token.
Jan 7 2024, 12:32 PM · cloud-services-team, observability, Toolforge

Nov 26 2023

valhallasw closed T350778: Better message than "This change is ready for review" when patch stops being WIP as Resolved.
Nov 26 2023, 2:56 PM · Wikibugs
valhallasw added a comment to T350778: Better message than "This change is ready for review" when patch stops being WIP.

Tested with https://gerrit.wikimedia.org/r/c/labs/tools/wikibugs2/+/977293, seems to work as expected:

Nov 26 2023, 2:56 PM · Wikibugs

Nov 18 2023

valhallasw added a comment to T350778: Better message than "This change is ready for review" when patch stops being WIP.

Took an initial stab at adding the scaffolding for changing the behavior in the WIP patchset above. Implementation still to be done (and open to pick up as I might not get to it).

Nov 18 2023, 2:47 PM · Wikibugs

Nov 17 2023

valhallasw added a comment to T350778: Better message than "This change is ready for review" when patch stops being WIP.

Did an online test with Jon and we were able to reproduce and log the issue. See attached (anonymized)

, resulting in the following IRC entry:

Nov 17 2023, 2:16 PM · Wikibugs

Nov 11 2023

valhallasw added a comment to T350778: Better message than "This change is ready for review" when patch stops being WIP.

Having logged a WIP change, I'm actually a bit confused by the behaviour you're describing. From what I can see, there _is_ now a new event, but that event shouldn't be logged as it's not one of the supported events:

Nov 11 2023, 3:37 PM · Wikibugs

Nov 10 2023

valhallasw added a comment to T350778: Better message than "This change is ready for review" when patch stops being WIP.

The last time I looked at it, the json provided by stream-events looked like this:

Nov 10 2023, 6:03 PM · Wikibugs

Aug 29 2023

valhallasw added a comment to T345181: No branch cut label applied to phab ticket after +2 on CheckUser extension.

Hacked a timeout -k 3700 3600 into forrestbot.sh which (assuming this is an issue in the python script/pop handling/etc and not in the toolforge jobs framework) would kill the bot if not done in an hour.

Aug 29 2023, 5:28 PM · ReleaseTaggerBot

Aug 19 2023

valhallasw updated the task description for T44477: lst: transcluding a broken redirect does not show a clear error message.
Aug 19 2023, 9:53 AM · MediaWiki-extensions-LabeledSectionTransclusion
valhallasw updated the task description for T44477: lst: transcluding a broken redirect does not show a clear error message.
Aug 19 2023, 9:52 AM · MediaWiki-extensions-LabeledSectionTransclusion
valhallasw updated the task description for T344449: ProofreadPage CI test lstIncorrectParserTest.txt: LST: Transclude double redirect (bug 42477) is failing .
Aug 19 2023, 9:50 AM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), MediaWiki-extensions-LabeledSectionTransclusion, ProofreadPage, ci-test-error

Jul 20 2023

valhallasw added a comment to T342066: gerrit-reviewer-bot got stuck due to non-existing account.

Merlijn van Deen - alternative — valhallasw-alt
from LDAP

Jul 20 2023, 4:43 PM · Developer Productivity, Gerrit

Jul 18 2023

valhallasw added a comment to T342066: gerrit-reviewer-bot got stuck due to non-existing account.

Typical error log entry:

{'id': 'operations%2Fpuppet~production~I5017ee944346ac8bb797b4ef862156418f6a3eb1', 'project': 'operations/puppet', 'branch': 'production', 'attention_set': {'9922': {'account': {'_account_id': 9922, 'name': 'Hokwelum', 'email': 'hokwelum@wikimedia.org', 'username': 'hokwelum'}, 'last_update': '2023-07-17 22:51:15.000000000', 'reason': 'Reviewer was added'}, '10626': {'account': {'_account_id': 10626, 'name': 'Jennifer Ebe', 'email': 'jebe@wikimedia.org', 'username': 'jebe'}, 'last_update': '2023-07-17 22:51:15.000000000', 'reason': 'Reviewer was added'}, '9379': {'account': {'_account_id': 9379, 'name': 'Btullis', 'email': 'btullis@wikimedia.org', 'username': 'btullis'}, 'last_update': '2023-07-17 17:52:43.000000000', 'reason': '<GERRIT_ACCOUNT_6> replied on the change', 'reason_account': {'_account_id': 6, 'name': 'ArielGlenn', 'email': 'ariel@wikimedia.org', 'username': 'ariel'}}}, 'hashtags': [], 'change_id': 'I5017ee944346ac8bb797b4ef862156418f6a3eb1', 'subject': 'make sure certain systemd jobs run only on the primary xml dumps NFS shares', 'status': 'NEW', 'created': '2023-07-17 10:11:43.000000000', 'updated': '2023-07-17 22:51:15.000000000', 'submit_type': 'REBASE_IF_NECESSARY', 'mergeable': True, 'insertions': 35, 'deletions': 3, 'total_comment_count': 3, 'unresolved_comment_count': 1, 'has_review_started': True, 'meta_rev_id': 'd740927c470fc97cec7a9889f2fb9540bbd882c5', '_number': 938816, 'owner': {'_account_id': 6, 'name': 'ArielGlenn', 'email': 'ariel@wikimedia.org', 'username': 'ariel'}, 'current_revision': 'a6c30abf227160608c960199bb99b273bc6ff146', 'revisions': {'a6c30abf227160608c960199bb99b273bc6ff146': {'kind': 'REWORK', '_number': 6, 'created': '2023-07-17 18:30:11.000000000', 'uploader': {'_account_id': 6, 'name': 'ArielGlenn', 'email': 'ariel@wikimedia.org', 'username': 'ariel'}, 'ref': 'refs/changes/16/938816/6', 'fetch': {'anonymous http': {'url': 'https://gerrit.wikimedia.org/r/operations/puppet', 'ref': 'refs/changes/16/938816/6'}}, 'files': {'modules/role/manifests/dumps/generation/server/xmlfallback.pp': {'lines_inserted': 2, 'size_delta': 129, 'size': 791}, 'modules/profile/manifests/dumps/generation/server/exceptionchecker.pp': {'lines_inserted': 2, 'size_delta': 111, 'size': 434}, 'modules/role/manifests/dumps/generation/server/misccrons.pp': {'lines_inserted': 2, 'size_delta': 129, 'size': 669}, 'hieradata/common/profile/dumps/generation/server.yaml': {'status': 'A', 'lines_inserted': 8, 'size_delta': 314, 'size': 314}, 'hieradata/common/profile/dumps/generation/server/xmldumps.yaml': {'status': 'A', 'lines_inserted': 4, 'size_delta': 220, 'size': 220}, 'hieradata/common/profile/dumps.yaml': {'lines_inserted': 2, 'size_delta': 102, 'size': 1761}, 'hieradata/hosts/dumpsdata1006.yaml': {'lines_deleted': 1, 'size_delta': -65, 'size': 591}, 'modules/dumps/manifests/generation/server/exceptionchecker.pp': {'lines_inserted': 3, 'lines_deleted': 1, 'size_delta': 67, 'size': 1160}, 'modules/role/manifests/dumps/generation/server/spare.pp': {'lines_inserted': 3, 'size_delta': 167, 'size': 684}, 'hieradata/common/profile/dumps/generation/server/alldumps.yaml': {'status': 'A', 'lines_inserted': 4, 'size_delta': 220, 'size': 220}, 'modules/profile/manifests/dumps/generation/server/jobswatcher.pp': {'lines_inserted': 2, 'size_delta': 106, 'size': 534}, 'modules/dumps/manifests/generation/server/jobswatcher.pp': {'lines_inserted': 3, 'lines_deleted': 1, 'size_delta': 67, 'size': 1022}}}}, 'requirements': [], 'submit_records': [{'rule_name': 'gerrit~DefaultSubmitRule', 'status': 'NOT_READY', 'labels': [{'label': 'Verified', 'status': 'OK', 'applied_by': {'_account_id': 75, 'name': 'jenkins-bot', 'username': 'jenkins-bot', 'tags': ['SERVICE_USER']}}, {'label': 'Code-Review', 'status': 'NEED'}]}]}
 caused exception:Traceback (most recent call last):
  File "/data/project/gerrit-reviewer-bot/src/gerrit-reviewer-bot/pop3bot.py", line 134, in <module>
    main()
  File "/data/project/gerrit-reviewer-bot/src/gerrit-reviewer-bot/pop3bot.py", line 122, in main
    add_reviewers(changeset['id'], reviewers)
  File "/data/project/gerrit-reviewer-bot/src/gerrit-reviewer-bot/add_reviewer.py", line 150, in add_reviewers
    raise Exception(command + ' was not executed successfully (code %i)' % retval)
Exception: gerrit set-reviewers --add ' Xcollazo ' --add jebe --add Hokwelum 'operations%2Fpuppet~production~I5017ee944346ac8bb797b4ef862156418f6a3eb1' was not executed successfully (code 1)
Jul 18 2023, 4:11 PM · Developer Productivity, Gerrit

Jul 13 2023

valhallasw added a comment to T123417: Create conduit method to query the feed and return records with relevant details populated instead of just a bunch of phids.

Wikibugs uses the task page html for

Jul 13 2023, 3:50 PM · Wikibugs, NewFunctionality-Worktype, Phabricator, Gerrit-Migration, Differential

Jul 12 2023

valhallasw added a comment to T289712: Investigate whether we can/should integrate Git/Reviewers with GitLab.

See T288381 for the related discussion from two years ago on Wikibugs. Long story short: No, not really, unless you pay for GitLab EE (which I think we don't).

Jul 12 2023, 4:43 PM · Patch-For-Review, Release-Engineering-Team (Priority Backlog 📥), GitLab (Integrations), User-brennen, Developer Productivity, Code-Health

May 15 2023

valhallasw added a comment to T336661: ReleaseTaggerBot not working since 2023-04-17.

@Jdforrester-WMF note that due to the bot hanging for so long, there will be quite a few tasks tagged with a newer release (anything that went to master will be marked as MW-1.41-notes (1.41.0-wmf.9; 2023-05-15) rather than the applicable wmf release). Hopefully not a huge deal to sort out by hand (and maybe it doesn't matter too much to fold them into one set of release notes for wmf5-9?)

May 15 2023, 5:22 PM · ReleaseTaggerBot
valhallasw added a comment to T336661: ReleaseTaggerBot not working since 2023-04-17.
tools.forrestbot@tools-sgebastion-10:~$ toolforge-jobs list
Job name:         Job type:            Status:
----------------  -------------------  --------------------
releasetaggerbot  schedule: 0 * * * *  Running for 28d1h44m

so it seems that the job is hanging in some sort of error loop.

May 15 2023, 2:47 PM · ReleaseTaggerBot

May 8 2023

Michael awarded T136633: Support multi-task commits a Like token.
May 8 2023, 8:53 AM · ReleaseTaggerBot

May 6 2023

valhallasw added a comment to T327936: Limit paws storage.

For home directories who's capacity goes above 1 gigabyte, the largest files will be removed to bring the total usage below 1 gigabyte.

May 6 2023, 3:36 AM · PAWS

Apr 11 2023

Lucas_Werkmeister_WMDE awarded T136633: Support multi-task commits a Like token.
Apr 11 2023, 3:37 PM · ReleaseTaggerBot

Apr 6 2023

valhallasw added a comment to T334118: Reviewer-bot option to be added as CC instead of reviewer.

Hiya, the reviewer bot is in very low maintenance mode a a) Gerrit has much more powerful features than when the bot was originally written, and b) we're moving over to Gitlab at... some point?

Apr 6 2023, 8:29 PM · Gerrit

Mar 9 2023

valhallasw added a comment to T331626: Mailman hasn't delivered emails since 2023-03-07 14 UTC (was: reviewer-bot is not working).

Not entirely sure what's going on. The bot is running but there do not seem to be any emails coming in:

Mar 9 2023, 2:24 PM · Wikimedia-Incident, SRE, Infrastructure-Foundations, Wikimedia-Mailing-lists, Mail

Oct 21 2022

valhallasw added a comment to T321342: wikibugs losing connection to IRC.

Thanks! It seems that it's an issue with some of the k8s hosts, but it happens relatively rarely. Combined with the overall migration to Gitlab (which will likely require a complete rethink of the bot) it's not a high priority to fix for me (but happy to give access to anyone who is interested to dig in!)

Oct 21 2022, 8:23 AM · Wikibugs

Oct 7 2022

valhallasw closed T319925: Migrate nlwiki-bronlinks from Toolforge GridEngine to Toolforge Kubernetes as Resolved.

Cronjob disabled (one-off project which already finished a long time ago, but had forgotten to turn off the cronjob before...)

Oct 7 2022, 3:35 PM · Grid-Engine-to-K8s-Migration

Aug 14 2022

valhallasw committed rTGPU73fcefce2821: Configurable pophost (authored by valhallasw).
Configurable pophost
Aug 14 2022, 6:15 PM
valhallasw committed rTGPUdcb31716af14: Run with 1h timeout (authored by valhallasw).
Run with 1h timeout
Aug 14 2022, 6:15 PM

Aug 8 2022

SD0001 awarded T306311: toolforge-jobs should have a method to easily restart a specific job a Like token.
Aug 8 2022, 9:27 AM · Toolforge Jobs framework

Jun 15 2022

valhallasw added a comment to T310734: Wikibugs no more sends Gerrit/Phabricator announcements to IRC 2022-06-15.

I think someone just restarted everything. Looking at the logs, there doesn't seem to be anything wrong with the Phab integration, rather the IRC bot had trouble connecting.

Jun 15 2022, 7:00 PM · Wikibugs

May 23 2022

valhallasw updated the task description for T308013: Assign SPDX headers to puppet.git.
May 23 2022, 5:13 PM · Patch-For-Review, Infrastructure-Foundations, SRE
valhallasw added a comment to T308995: wikibugs has stopped showing phab/gerrit comments on IRC as of 2022-05-22Z17:00.

@Marostegui which command(s) did you run, exactly?

May 23 2022, 3:47 PM · SRE, Wikibugs

Apr 17 2022

valhallasw updated the task description for T306322: Request increased quota for wikibugs Toolforge tool.
Apr 17 2022, 8:18 PM · cloud-services-team (Kanban), Toolforge (Quota-requests)
valhallasw created T306324: Consider improving quota workflow.
Apr 17 2022, 8:16 PM · cloud-services-team, Toolforge
valhallasw created T306322: Request increased quota for wikibugs Toolforge tool.
Apr 17 2022, 8:08 PM · cloud-services-team (Kanban), Toolforge (Quota-requests)
valhallasw added a subtask for T285944: Toolforge: beta phase for the new jobs framework: T306312: toolforge-jobs should have a method to load a single task (or a subset of tasks) from a yaml file.
Apr 17 2022, 10:39 AM · cloud-services-team, Toolforge Jobs framework
valhallasw added a parent task for T306312: toolforge-jobs should have a method to load a single task (or a subset of tasks) from a yaml file: T285944: Toolforge: beta phase for the new jobs framework.
Apr 17 2022, 10:39 AM · Toolforge Jobs framework
valhallasw created T306312: toolforge-jobs should have a method to load a single task (or a subset of tasks) from a yaml file.
Apr 17 2022, 10:39 AM · Toolforge Jobs framework
valhallasw created T306311: toolforge-jobs should have a method to easily restart a specific job.
Apr 17 2022, 10:33 AM · Toolforge Jobs framework
valhallasw created T306310: toolforge-jobs job emails should have information on why events happened.
Apr 17 2022, 10:25 AM · Toolforge, User-aborrero
valhallasw created T306309: toolforge-jobs job emails should have timestamps in events.
Apr 17 2022, 10:25 AM · Toolforge Jobs framework
valhallasw closed T306306: Move wikibugs over to k8s as Resolved.
Apr 17 2022, 10:21 AM · Wikibugs
valhallasw added a comment to T306308: ERROR: unable to create job: "HTTP 403: likely an internal bug: 403 Client Error: Forbidden for url: https://k8s.tools.eqiad1.wikimedia.cloud:6443/apis/apps/v1/namespaces/tool-wikibugs/deployments.

And it works if I first kill the webservice. Probably a quota issue then? A limit of 3 continuous jobs seemed pretty limited when I read it the first time, and when the webservice also counts against it...

Apr 17 2022, 10:19 AM · Toolforge
valhallasw added a comment to T306308: ERROR: unable to create job: "HTTP 403: likely an internal bug: 403 Client Error: Forbidden for url: https://k8s.tools.eqiad1.wikimedia.cloud:6443/apis/apps/v1/namespaces/tool-wikibugs/deployments.

I get the same exception if I try to run the job by hand:

tools.wikibugs@tools-sgebastion-10:~$ toolforge-jobs run redis2irc --command "libera/wrapper.sh redis2irc" --image tf-python39 --continuous --emails all
ERROR: unable to create job: "HTTP 403: likely an internal bug: 403 Client Error: Forbidden for url: https://k8s.tools.eqiad1.wikimedia.cloud:6443/apis/apps/v1/namespaces/tool-wikibugs/deployments. k8s JSON: {\"kind\": \"Deployment\", \"apiVersion\": \"apps/v1\", \"metadata\": {\"name\": \"redis2irc\", \"namespace\": \"tool-wikibugs\", \"labels\": {\"toolforge\": \"tool\", \"app.kubernetes.io/version\": \"1\", \"app.kubernetes.io/managed-by\": \"toolforge-jobs-framework\", \"app.kubernetes.io/created-by\": \"wikibugs\", \"app.kubernetes.io/component\": \"deployments\", \"app.kubernetes.io/name\": \"redis2irc\", \"jobs.toolforge.org/filelog\": \"yes\", \"jobs.toolforge.org/emails\": \"all\"}}, \"spec\": {\"template\": {\"metadata\": {\"labels\": {\"toolforge\": \"tool\", \"app.kubernetes.io/version\": \"1\", \"app.kubernetes.io/managed-by\": \"toolforge-jobs-framework\", \"app.kubernetes.io/created-by\": \"wikibugs\", \"app.kubernetes.io/component\": \"deployments\", \"app.kubernetes.io/name\": \"redis2irc\", \"jobs.toolforge.org/filelog\": \"yes\", \"jobs.toolforge.org/emails\": \"all\"}}, \"spec\": {\"restartPolicy\": \"Always\", \"containers\": [{\"name\": \"redis2irc\", \"image\": \"docker-registry.tools.wmflabs.org/toolforge-python39-sssd-base:latest\", \"workingDir\": \"/data/project/wikibugs\", \"command\": [\"/bin/sh\", \"-c\", \"--\", \"libera/wrapper.sh redis2irc 1>>redis2irc.out 2>>redis2irc.err\"], \"resources\": {}, \"env\": [{\"name\": \"HOME\", \"value\": \"/data/project/wikibugs\"}], \"volumeMounts\": [{\"mountPath\": \"/data/project\", \"name\": \"home\"}]}], \"volumes\": [{\"name\": \"home\", \"hostPath\": {\"path\": \"/data/project\", \"type\": \"Directory\"}}]}}, \"replicas\": 1, \"selector\": {\"matchLabels\": {\"toolforge\": \"tool\", \"app.kubernetes.io/version\": \"1\", \"app.kubernetes.io/managed-by\": \"toolforge-jobs-framework\", \"app.kubernetes.io/created-by\": \"wikibugs\", \"app.kubernetes.io/component\": \"deployments\", \"app.kubernetes.io/name\": \"redis2irc\", \"jobs.toolforge.org/filelog\": \"yes\", \"jobs.toolforge.org/emails\": \"all\"}}}}"
Apr 17 2022, 10:18 AM · Toolforge
valhallasw created T306308: ERROR: unable to create job: "HTTP 403: likely an internal bug: 403 Client Error: Forbidden for url: https://k8s.tools.eqiad1.wikimedia.cloud:6443/apis/apps/v1/namespaces/tool-wikibugs/deployments.
Apr 17 2022, 10:16 AM · Toolforge
valhallasw created T306307: Toolforce ulimit insufficient for normal work.
Apr 17 2022, 10:03 AM · Toolforge
valhallasw added a comment to T306306: Move wikibugs over to k8s.

fdsfadsdfsa

Apr 17 2022, 9:53 AM · Wikibugs
valhallasw added a comment to T306306: Move wikibugs over to k8s.

bump²

Apr 17 2022, 9:50 AM · Wikibugs
valhallasw added a comment to T306306: Move wikibugs over to k8s.

fdsa

Apr 17 2022, 9:49 AM · Wikibugs
valhallasw added a comment to T306306: Move wikibugs over to k8s.

Test

Apr 17 2022, 9:47 AM · Wikibugs
valhallasw created T306306: Move wikibugs over to k8s.
Apr 17 2022, 9:46 AM · Wikibugs

Apr 16 2022

valhallasw committed rTGPU1ad825222421: Add ssh to container (authored by valhallasw).
Add ssh to container
Apr 16 2022, 9:51 PM
valhallasw committed rTGPUa4463762fb82: K8s job monitoring (authored by valhallasw).
K8s job monitoring
Apr 16 2022, 9:51 PM
valhallasw committed rTGPUa52e670bbc63: Refactor run scripts into separate stretch/k8s versions (authored by valhallasw).
Refactor run scripts into separate stretch/k8s versions
Apr 16 2022, 9:51 PM
valhallasw committed rTGPU1f720e674168: Longer MAXLINE (authored by valhallasw).
Longer MAXLINE
Apr 16 2022, 9:51 PM

Feb 14 2022

valhallasw added a comment to T299325: Add wikibugs to #wikimedia-ve.

See https://www.mediawiki.org/wiki/Wikibugs#Configuring_channels for how to do this.
An admin has to autovoice Wikibugs in the channel before the channel can be added to the configuration.

Feb 14 2022, 8:38 PM · Wikimedia-Venezuela, Wikibugs

Dec 14 2021

valhallasw added a comment to T297723: ReleaseTaggerBot tagged a task with a later branch than when the code landed, as the branch was created between the merge and the time the bot ran.

From the log file:

Dec 14 2021, 5:13 PM · ReleaseTaggerBot

Nov 14 2021

valhallasw added a comment to T259702: Add version number for the 3 versions at https://pywikibot.toolforge.org/.

The main bit of code seems to be in https://github.com/pywikibot/Pywikibot-nightly-creator

Nov 14 2021, 3:18 PM · Pywikibot

Sep 28 2021

valhallasw committed rTGPU9782efceddc0: Backport changes from Forrestbot (authored by valhallasw).
Backport changes from Forrestbot
Sep 28 2021, 11:24 PM
valhallasw added a comment to T290905: Gerrit Reviewer Bot is unreliable.
tools.gerrit-reviewer-bot@tools-sgebastion-07:~$ grep gerrit_reviewer_bot.out -e 'Ie4d0ef0495b40abeff825d83bf1c28303e81c848' -C5
0 e-mails to process (0 kB)
Done.
Sep 28 2021, 6:35 PM · Gerrit
Tgr awarded T288392: GitLab uses 'real name' as username (rather than 'shell name' or an user-specified name) a Love token.
Sep 28 2021, 12:49 AM · GitLab (Auth & Access), Release-Engineering-Team (Doing), User-brennen, Privacy

Sep 27 2021

greg awarded T288392: GitLab uses 'real name' as username (rather than 'shell name' or an user-specified name) a Barnstar token.
Sep 27 2021, 9:04 PM · GitLab (Auth & Access), Release-Engineering-Team (Doing), User-brennen, Privacy

Sep 24 2021

thcipriani awarded T288392: GitLab uses 'real name' as username (rather than 'shell name' or an user-specified name) a Yellow Medal token.
Sep 24 2021, 4:17 AM · GitLab (Auth & Access), Release-Engineering-Team (Doing), User-brennen, Privacy

Sep 20 2021

valhallasw added a comment to T290905: Gerrit Reviewer Bot is unreliable.

I think I know what's going on -- it's an issue I fixed earlier for ReleaseTaggerBot (which uses the same email based system), but forgot to also apply here: T284587: https://github.com/wikimedia/labs-tools-forrestbot/commit/76a76db66a2fa6a54493b402bd9c68376f0d70e0

Sep 20 2021, 8:35 AM · Gerrit

Sep 19 2021

valhallasw added a comment to T290905: Gerrit Reviewer Bot is unreliable.

https://gerrit-reviewer-bot.toolforge.org/ contains the last 50-or-so log lines; if you have access to tool labs I'm fairly certain you can just read the .out and .err logs in the home dir. The logging is not super extensive but should give a decent idea of what's happening.

Sep 19 2021, 9:12 AM · Gerrit

Sep 2 2021

valhallasw added a comment to T288381: Connect WikiBugs IRC bot to Wikimedia GitLab.

:S

Do you have a patch or an idea how much changes are needed for adding the integration? That does seem like the best way forward. cc'ing @brennen since I'm not really sure what our capacity for local patches is .

Sep 2 2021, 7:57 PM · Release-Engineering-Team (Priority Backlog 📥), GitLab (Integrations), Wikibugs

Aug 27 2021

valhallasw added a comment to T288381: Connect WikiBugs IRC bot to Wikimedia GitLab.

by "building" do you mean patching the GitLab code?

Aug 27 2021, 8:02 PM · Release-Engineering-Team (Priority Backlog 📥), GitLab (Integrations), Wikibugs

Aug 8 2021

valhallasw updated subscribers of T288381: Connect WikiBugs IRC bot to Wikimedia GitLab.

@Legoktm mentioned Debian's gitlab instance (Salsa) has some irc integration as well. Seems to be the built-in Irker plus something based on webhooks & https://salsa.debian.org/kgb-team/kgb/-/blob/master/script/kgb-bot. This is something we could also deploy in principle (with wikibugs just handling phab, and kgb handling merge requests etc).

Aug 8 2021, 8:50 AM · Release-Engineering-Team (Priority Backlog 📥), GitLab (Integrations), Wikibugs

Aug 7 2021

valhallasw added a comment to T288381: Connect WikiBugs IRC bot to Wikimedia GitLab.

With a little bit of hacking, I was able to make the Mattermost integration act like a regular webhook:

Aug 7 2021, 7:13 PM · Release-Engineering-Team (Priority Backlog 📥), GitLab (Integrations), Wikibugs
valhallasw added a comment to T288381: Connect WikiBugs IRC bot to Wikimedia GitLab.

A few further notes after fiddling with a fresh Gitlab instance.

Aug 7 2021, 6:37 PM · Release-Engineering-Team (Priority Backlog 📥), GitLab (Integrations), Wikibugs
valhallasw added a comment to T288381: Connect WikiBugs IRC bot to Wikimedia GitLab.

Some thoughts on architecture when using a webhook

Aug 7 2021, 11:30 AM · Release-Engineering-Team (Priority Backlog 📥), GitLab (Integrations), Wikibugs
valhallasw updated the task description for T288392: GitLab uses 'real name' as username (rather than 'shell name' or an user-specified name).
Aug 7 2021, 9:37 AM · GitLab (Auth & Access), Release-Engineering-Team (Doing), User-brennen, Privacy
valhallasw created T288392: GitLab uses 'real name' as username (rather than 'shell name' or an user-specified name).
Aug 7 2021, 9:36 AM · GitLab (Auth & Access), Release-Engineering-Team (Doing), User-brennen, Privacy
valhallasw updated the task description for T288381: Connect WikiBugs IRC bot to Wikimedia GitLab.
Aug 7 2021, 9:26 AM · Release-Engineering-Team (Priority Backlog 📥), GitLab (Integrations), Wikibugs
valhallasw added a comment to T288381: Connect WikiBugs IRC bot to Wikimedia GitLab.

https://gitlab.wikimedia.org/api/v4/events?target_type=merge_request seems to be pretty much what we need, except it can only filter by after={date} and not by date and time... so it's not particularly convenient for polling. We may have to go for the inverse route (either emails or webhooks).

Aug 7 2021, 9:24 AM · Release-Engineering-Team (Priority Backlog 📥), GitLab (Integrations), Wikibugs
valhallasw added a comment to T288381: Connect WikiBugs IRC bot to Wikimedia GitLab.

Oooh, yes, that's going to be fun. A few thoughts.

Aug 7 2021, 9:17 AM · Release-Engineering-Team (Priority Backlog 📥), GitLab (Integrations), Wikibugs
valhallasw added a comment to T282842: Early adoption signup for WMF GitLab.

Would be happy to be on the front lines with Wikibugs2, as it needs to be adapted for GitLab (T288381). Eat your own dog food, etc. (cc @Legoktm)

Aug 7 2021, 9:13 AM · Release-Engineering-Team (Priority Backlog 📥), GitLab (Project Migration), User-brennen

Jun 12 2021

valhallasw updated subscribers of T284587: ReleaseTaggerBot skipping some Tasks/Patches?.

Note that I may have missed changes before 6 jun (which is the oldest log file).

Jun 12 2021, 8:22 PM · ReleaseTaggerBot
valhallasw added a comment to T284587: ReleaseTaggerBot skipping some Tasks/Patches?.

Decided to use a script after realizing the number of clicks required for the manual approach. Should all be sorted now :-)

Jun 12 2021, 8:13 PM · ReleaseTaggerBot
valhallasw added a project to T219215: Don’t suggest edits to real items in API sandbox: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).
Jun 12 2021, 8:04 PM · User-Ladsgroup, MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)), Wikidata
valhallasw added a comment to T284587: ReleaseTaggerBot skipping some Tasks/Patches?.

List seems to be the following:

Jun 12 2021, 8:03 PM · ReleaseTaggerBot
valhallasw added a comment to T284587: ReleaseTaggerBot skipping some Tasks/Patches?.

Deployed and re-enabled bot. Looking into the logs now.

Jun 12 2021, 7:28 PM · ReleaseTaggerBot
valhallasw added a comment to T284587: ReleaseTaggerBot skipping some Tasks/Patches?.

For (b): found a source email with the same issue -- the email has mixed CRLF and LF newlines which explains why things got confused. Created test + fix (see above). Will deploy this first, and will then investigate what I can find on other situations where the \r may have caused issues.

Jun 12 2021, 7:09 PM · ReleaseTaggerBot
valhallasw triaged T284587: ReleaseTaggerBot skipping some Tasks/Patches? as High priority.
Jun 12 2021, 6:29 PM · ReleaseTaggerBot
valhallasw updated subscribers of T284587: ReleaseTaggerBot skipping some Tasks/Patches?.

Hmm, that doesn't look good:

forrestbot.log.2021-06-05:2021-06-05 15:00:13,036 - forrestbot - DEBUG - <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/698040>: skipping (SkipMailException('Project mediawiki/core\r is not being watched',))
Jun 12 2021, 6:29 PM · ReleaseTaggerBot

May 25 2021

valhallasw closed T218612: wb2-phab having issues as Resolved.
May 25 2021, 6:48 PM · Wikibugs
valhallasw added a comment to T218612: wb2-phab having issues.

It's always great when you fix a bug twice, merge once, then come back yet another year later to merge the first one.

May 25 2021, 6:48 PM · Wikibugs

May 16 2021

valhallasw added a comment to T282962: ui_tests are failing on Travis.

Ooof. That was a long time ago :-)

May 16 2021, 12:47 PM · Pywikibot-tests, Pywikibot
valhallasw added a comment to T282964: ui_tests TestWindowsTerminalUnicode and TestWindowsTerminalUnicode are failing on Windows.

The main issue seems solved when replacing connect_ by connect; however the tests then still fail, most likely because the font settings etc. in Windows 10 have changed significantly over where they were in Windows 7. Given that the code is largely 'battle-tested' and the tests cannot be run automatically indeed removing the tests seems like a reasonable approach.

May 16 2021, 11:26 AM · Pywikibot, Pywikibot-tests

Apr 26 2021

valhallasw added a comment to T281105: Wikibugs should not accidentally ping SREs by sending text "# page".

I'm not entirely convinced this should be solved by Wikibugs -- isn't this better solved at the client side by ignoring bots when it comes to alerts?

Apr 26 2021, 1:59 PM · Wikibugs

Apr 13 2021

valhallasw closed T279710: wikibugs should display the same type of name that the Gerrit UI displays as Declined.

That would be nice! Unfortunately the display name is not part of the stream-events data format:

Apr 13 2021, 6:38 PM · Wikibugs

Mar 29 2021

valhallasw added a comment to T278645: SGE Job gerrit_reviewer_bot (9999704) stuck in delete state.

Thanks, @Legoktm!

Mar 29 2021, 6:09 PM · Toolforge

Mar 28 2021

valhallasw created T278645: SGE Job gerrit_reviewer_bot (9999704) stuck in delete state.
Mar 28 2021, 1:36 PM · Toolforge

Feb 28 2021

valhallasw added a comment to T275982: i18n messages were deleted due to unknown reason.

@Nikerabbit this is a bit confusing to me. My understanding of the linked news post is that

Feb 28 2021, 10:40 AM · Patch-For-Review, Pywikibot-i18n, I18n, translatewiki.net, Pywikibot