Page MenuHomePhabricator

valhallasw (Merlijn van Deen)
Pywikibot / Tool Labs

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 3 2014, 1:14 PM (296 w, 9 h)
Availability
Available
IRC Nick
valhallasw (typically around in European evenings)
LDAP User
Merlijn van Deen
MediaWiki User
Valhallasw [ Global Accounts ]

Recent Activity

Apr 28 2020

valhallasw added a comment to T251194: ReleaseTaggerBot fighting with itself on T249613 (trying to add two milestones of the same parent project which is not possible).

Apologies for the mess; the bot was blocked on adding a task to T249730. When it crashes, it reprocesses the entire queue -- which is supposed to be idempotent as it checks whether the requested tags are already present...

Apr 28 2020, 6:09 AM · ReleaseTaggerBot

Mar 1 2020

valhallasw closed T245657: Whitelist wikibugs for ##revi as Resolved.
Mar 1 2020, 3:43 PM · Wikibugs, User-revi

Feb 19 2020

valhallasw created T245657: Whitelist wikibugs for ##revi.
Feb 19 2020, 6:43 PM · Wikibugs, User-revi

Feb 18 2020

Krenair awarded T168677: Add new Cloud Services domains to public suffix list a Evil Spooky Haunted Tree token.
Feb 18 2020, 12:25 AM · Toolforge, Cloud-VPS, cloud-services-team (Kanban)

Feb 12 2020

Dzahn awarded T241109: wikibugs needs restart almost everyday a Barnstar token.
Feb 12 2020, 6:10 PM · Operations, Wikibugs
valhallasw closed T241109: wikibugs needs restart almost everyday as Resolved.

....except that I forgot to update the dependencies! Did that and restarted wb2-phab... I think that should now really fix it.

Feb 12 2020, 5:32 PM · Operations, Wikibugs
valhallasw added a comment to T241109: wikibugs needs restart almost everyday.
2020-02-12 12:43:01,182 - urllib3.connectionpool - DEBUG - https://phabricator.wikimedia.org:443 "POST /api/feed.query HTTP/1.1" 200 58
2020-02-12 12:43:02,311 - urllib3.connectionpool - DEBUG - https://phabricator.wikimedia.org:443 "POST /api/feed.query HTTP/1.1" 200 58
2020-02-12 12:43:03,429 - urllib3.connectionpool - DEBUG - https://phabricator.wikimedia.org:443 "POST /api/feed.query HTTP/1.1" 200 None
2020-02-12 12:43:04,547 - urllib3.connectionpool - DEBUG - https://phabricator.wikimedia.org:443 "POST /api/feed.query HTTP/1.1" 200 None
2020-02-12 12:43:05,651 - urllib3.connectionpool - DEBUG - https://phabricator.wikimedia.org:443 "POST /api/feed.query HTTP/1.1" 200 160
Feb 12 2020, 5:20 PM · Operations, Wikibugs

Feb 5 2020

valhallasw closed T244391: Update IRC priority output from "Normal" to "Medium", a subtask of T228757: Rename Phabricator's "Normal" Priority field value to "Medium", as Resolved.
Feb 5 2020, 8:55 PM · Developer-Advocacy (Oct-Dec 2019), Phabricator
valhallasw closed T244391: Update IRC priority output from "Normal" to "Medium" as Resolved.

Jobs restarted so this should be working now

Feb 5 2020, 8:55 PM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), User-greg, Wikibugs
valhallasw closed T244193: Exclude "SonarQube Bot" comments in wikibugs on IRC as Resolved.

Jobs restarted so this should be working now

Feb 5 2020, 8:55 PM · Code-Health-Metrics, Wikibugs
valhallasw added a comment to T244193: Exclude "SonarQube Bot" comments in wikibugs on IRC.

I assume this should be handled equivalently to jenkins-bot and pipelinebot, i.e.: only report changes towards negative votes?

Feb 5 2020, 5:09 PM · Code-Health-Metrics, Wikibugs

Jan 28 2020

valhallasw reopened T243540: Exception: No PHID found for slug #mwwmf_deploy! as "Open".

Forgot to reopen this...

Jan 28 2020, 7:27 PM · Release-Engineering-Team, ReleaseTaggerBot

Jan 23 2020

valhallasw closed T243540: Exception: No PHID found for slug #mwwmf_deploy! as Resolved.
Jan 23 2020, 7:45 PM · Release-Engineering-Team, ReleaseTaggerBot
valhallasw added a comment to T243540: Exception: No PHID found for slug #mwwmf_deploy!.

Discussed on IRC. Made two main changes:

Jan 23 2020, 7:33 PM · Release-Engineering-Team, ReleaseTaggerBot
valhallasw created T243540: Exception: No PHID found for slug #mwwmf_deploy!.
Jan 23 2020, 7:06 PM · Release-Engineering-Team, ReleaseTaggerBot

Jan 19 2020

valhallasw added a comment to T241109: wikibugs needs restart almost everyday.

From what I can see the bot crashes and restarts a few times per day, which -- although not great -- I think is acceptable. About 2/3rd of those are errors retrieving anchors, the rest are about 50-50 503s from the API and cursor errors that would have caused hangs.

Jan 19 2020, 3:05 PM · Operations, Wikibugs
valhallasw closed T241109: wikibugs needs restart almost everyday as Resolved.
Jan 19 2020, 3:00 PM · Operations, Wikibugs
valhallasw added a comment to T242802: RTB errors with "Fatal Python error: Py_Initialize: Unable to get the locale encoding".

python-phabricator supports tokens as well: https://github.com/disqus/python-phabricator/blob/master/phabricator/__init__.py#L378
and still uses params: https://github.com/disqus/python-phabricator/blob/master/phabricator/__init__.py#L307

Jan 19 2020, 12:36 PM · ReleaseTaggerBot
valhallasw added a comment to T242802: RTB errors with "Fatal Python error: Py_Initialize: Unable to get the locale encoding".

Looking at the examples, a call is now supposed to be done along these lines:

Jan 19 2020, 12:24 PM · ReleaseTaggerBot
valhallasw closed T242920: Adapt RTB to new yaml release config as Resolved.

Thanks, deployed!

Jan 19 2020, 12:18 PM · ReleaseTaggerBot

Jan 15 2020

valhallasw created T242920: Adapt RTB to new yaml release config.
Jan 15 2020, 10:18 PM · ReleaseTaggerBot
valhallasw added a comment to T242802: RTB errors with "Fatal Python error: Py_Initialize: Unable to get the locale encoding".

I reverted the config.py back to use certificates. I'm not entirely sure how api keys are supposed to be used in phab; should they just be passed as part of the API request, the same way the session key is passed at the moment?

Jan 15 2020, 6:27 AM · ReleaseTaggerBot

Jan 14 2020

valhallasw added a comment to T242802: RTB errors with "Fatal Python error: Py_Initialize: Unable to get the locale encoding".

Sorry, that's an old venv that should be removed.

Jan 14 2020, 10:16 PM · ReleaseTaggerBot

Jan 13 2020

valhallasw added a comment to T242590: Gerrit creates duplicate changes when pushing same commit twice in quick succession.

The same issue also caused Gerrit-Reviewer-Bot to stop working: (see https://github.com/valhallasw/gerrit-reviewer-bot/issues/22)

Jan 13 2020, 8:59 PM · Gerrit

Dec 31 2019

valhallasw updated subscribers of T241109: wikibugs needs restart almost everyday.

I have deployed this patchset; it needs some work (formatting etc) and the change should really go upstream to Fab; I'll discuss that with @Legoktm. For now I just want to have the code running so we have some more information on how often we get errors back from the API. Based on that we could either have somewhat extensive error handling, or just let it be handled by the crash-and-restart loop.

Dec 31 2019, 3:34 PM · Operations, Wikibugs
valhallasw added a comment to T1152: wikibugs test bug.

test

Dec 31 2019, 3:33 PM · Wikibugs
valhallasw added a comment to T1152: wikibugs test bug.

test

Dec 31 2019, 2:57 PM · Wikibugs

Dec 20 2019

valhallasw added a comment to T241109: wikibugs needs restart almost everyday.

First of all thank you for restarting wikibugs when this happens!

Dec 20 2019, 11:32 PM · Operations, Wikibugs

Dec 11 2019

valhallasw added a comment to T236532: "extdist" Cloud VPS project jessie deprecation.

I'm actually unsure what needs to happen for these hosts... and not really sure why I'm a maintainer. Probably needed to fix something as admin at some point :-)

Dec 11 2019, 9:03 PM · Cloud-VPS (Debian Jessie Deprecation)

Nov 23 2019

valhallasw committed rTGPUf343eaf932f4: + Add alert email when bot is reporting errors (authored by valhallasw).
+ Add alert email when bot is reporting errors
Nov 23 2019, 11:39 PM
valhallasw committed rTGPU9752ba25b57e: Disable automatic prune, leads to lost output/error messages (authored by valhallasw).
Disable automatic prune, leads to lost output/error messages
Nov 23 2019, 11:39 PM

Nov 19 2019

valhallasw added a comment to T222983: reviewer-bot sometimes not working.

The bot is running again -- the issue was an empty file_regexp on the configuration page and the bot crashing because of that. I'll add some extra monitoring as well as checks for the config page over the coming week, but for now at least the bot is running again.

Nov 19 2019, 9:29 PM · Gerrit
valhallasw added a comment to T222983: reviewer-bot sometimes not working.

Thanks for spotting that -- I think something has changed in the API response used to get the reviewers:

Nov 19 2019, 6:22 AM · Gerrit

Nov 1 2019

valhallasw added a comment to T237111: @ReleaseTaggerBot (forrestbot) crashing when parsing a r/485486 from extension-Wikisource.

Thanks for noticing & fixing this -- I had received a bunch of alerts, but didn't have time to look into it until tonight (and given that RTB is not super time critical I thought I would be in time -- but y'all were faster! :-)).

Nov 1 2019, 8:25 PM · ReleaseTaggerBot
valhallasw added a comment to T237109: Exempt 'wikibugs' IRC bot from flood rate limits.

The bot is not being klined (we should indeed be exempt from that on a per-channel level), but being disconnected. Still problematic, but a little bit less so.

Nov 1 2019, 8:24 PM · Wikibugs, wikimedia-irc-freenode

Oct 25 2019

valhallasw created T236512: tbpmelder crasht bij pagina's met nobots.
Oct 25 2019, 7:24 PM · Tool-nlwikibots

Oct 12 2019

valhallasw closed T201261: Exclude secondary jenkins-bot/PipelineBot messages from Gerrit in Wikibugs on IRC as Resolved.

Ok, deployed this implementation. Let me know if you run into anymore messages that should be filtered out (or should _not_ be filtered out), if possible with the date/time (UTC) of the message; I'll then try to be quick enough to grab the relevant log file from toolforge to write a test :-)

Oct 12 2019, 3:48 PM · Release-Engineering-Team, Wikibugs
valhallasw added a comment to T201261: Exclude secondary jenkins-bot/PipelineBot messages from Gerrit in Wikibugs on IRC.

After some more digging:

Oct 12 2019, 3:21 PM · Release-Engineering-Team, Wikibugs
valhallasw added a comment to T201261: Exclude secondary jenkins-bot/PipelineBot messages from Gerrit in Wikibugs on IRC.

Ok, fiddled a bit with the implementation (which now only reports jenkins-bot/pipelinebot if they change their vote to something negative). This seems to work overall, and I believe it filters out most if not all the offending messages.

Oct 12 2019, 2:34 PM · Release-Engineering-Team, Wikibugs
valhallasw added a comment to T231733: Bulk actions triggers wikibugs.

IRC is a bit different as it's a broadcast notification in addition to the regular email notifications. Because it's a broadcast, it's also not possible to configure it per-user (other than filtering in your IRC client).

Oct 12 2019, 11:11 AM · Wikibugs

Oct 6 2019

valhallasw added a comment to T201261: Exclude secondary jenkins-bot/PipelineBot messages from Gerrit in Wikibugs on IRC.

I've looked into gerrit stream-events log files a bit today. The only reference to Fresnel that I can find is in e.g. the first jenkins-bot comment on https://gerrit.wikimedia.org/r/540525. Is that the Fresnel we're discussing? Because (as far as I can see) those are already correctly filtered out as jenkins-bots _almost_ always sets "CR: 0" in its reviews.

Oct 6 2019, 3:33 PM · Release-Engineering-Team, Wikibugs

Sep 29 2019

valhallasw reopened T231733: Bulk actions triggers wikibugs as "Open".
Sep 29 2019, 1:26 PM · Wikibugs
valhallasw updated subscribers of T231733: Bulk actions triggers wikibugs.

Ah, I had not realized bulk edits were a restricted group. Unfortunately, it doesn't help much...

Sep 29 2019, 1:26 PM · Wikibugs
valhallasw added a comment to T231733: Bulk actions triggers wikibugs.

Testing bulk action

Sep 29 2019, 1:01 PM · Wikibugs
valhallasw closed T231733: Bulk actions triggers wikibugs as Declined.

This is intended, as we don't want untrusted users to be able to perform silent mass actions, and don't want to add the complexity of rights management or per-user configuration.

Sep 29 2019, 11:52 AM · Wikibugs
valhallasw added a comment to T201261: Exclude secondary jenkins-bot/PipelineBot messages from Gerrit in Wikibugs on IRC.

What, exactly, should be filtered out for PipelineBot and Fresnel? Anything from those users, or only if the patch is already merged...?

Sep 29 2019, 11:00 AM · Release-Engineering-Team, Wikibugs

Sep 28 2019

valhallasw added a comment to T234119: Whitelist wikibugs in ##RhinosF1.

Why do we need to whitelist the bot? Is it going to "speak too much" that we risk that it be automatically disconnected by services due to flood? Thanks.

It did once so it's a blanket policy as far as I know

Sep 28 2019, 6:49 PM · User-RhinosF1, Wikibugs
valhallasw closed T234119: Whitelist wikibugs in ##RhinosF1 as Resolved.

Thanks!

Sep 28 2019, 6:46 PM · User-RhinosF1, Wikibugs
valhallasw created T234119: Whitelist wikibugs in ##RhinosF1.
Sep 28 2019, 10:07 AM · User-RhinosF1, Wikibugs

Sep 17 2019

valhallasw added a comment to T233093: ReleaseTaggerBot assumes that a task can only be tagged with one release per minor version?.

The RTB code could theoretically be changed from 'last patch merged' to 'lowest version number', or something along those lines -- but this would be a complex bit of code: currently, we add a hashtag based on the branch, and phabricator will resolve this to a tag through an alias. To support 'lowest version number', we'd need to parse all tags and somehow figure out which version they are.

Sep 17 2019, 4:02 PM · ReleaseTaggerBot

Sep 7 2019

valhallasw added a comment to T232247: wikibugs is down on IRC.

Testing

Sep 7 2019, 12:06 PM · Wikibugs
valhallasw added a comment to T232247: wikibugs is down on IRC.

Not entirely clear to me what is happening; The log files show

Sep 7 2019, 12:05 PM · Wikibugs

Aug 29 2019

JeanFred awarded T97861: Provide centralized logging (logstash) for Toolforge a Like token.
Aug 29 2019, 10:09 AM · cloud-services-team (Kanban), Toolforge

Aug 23 2019

valhallasw closed T230698: ReleaseTaggerBot hasn't tagged anything since 8 August 2019 as Resolved.

I've extended the monitoring a bit so that I get an email when the bot fails (at least, that's the plan) so that issues like this can be resolved more quickly. I think it's not worth spending time to think of how to handle this edge case as it only rarely happens and there's an easy workaround available (creating an extra tag).

Aug 23 2019, 6:33 PM · ReleaseTaggerBot

Aug 21 2019

valhallasw added a comment to T230698: ReleaseTaggerBot hasn't tagged anything since 8 August 2019.

The change has later been cherry-picked to the correct branch in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/528211/. Maybe the incorrect branch has been deleted?

Aug 21 2019, 4:12 PM · ReleaseTaggerBot
valhallasw added a comment to T230698: ReleaseTaggerBot hasn't tagged anything since 8 August 2019.

Note that these changes were in AbuseFilter, not in core. Do we expect
extensions to follow the same branch naming as core, or should it be more
lenient there?

Aug 21 2019, 11:38 AM · ReleaseTaggerBot

Aug 20 2019

valhallasw added a comment to T230698: ReleaseTaggerBot hasn't tagged anything since 8 August 2019.

Shouldn't the branch name then have been wmf/1.34.0-wmf.16 instead of wmf/1.34-wmf.16? Looking at the branch-to-slug logic:

Aug 20 2019, 8:02 PM · ReleaseTaggerBot

Aug 19 2019

valhallasw added a comment to T230698: ReleaseTaggerBot hasn't tagged anything since 8 August 2019.

The issue seems to be with the following commits:
https://gerrit.wikimedia.org/r/528108
https://gerrit.wikimedia.org/r/528111

Aug 19 2019, 6:50 PM · ReleaseTaggerBot

Aug 14 2019

valhallasw closed T86304: Gerrit-patch-uploader fails under git 1.9 as Resolved.

Ok, then I'm going to close this ticket as this seems unrelated.

Aug 14 2019, 7:10 PM · RelEng-Archive-FY201718-Q1, Gerrit, Tool-Gerrit-Patch-Uploader

Aug 13 2019

valhallasw added a comment to T86304: Gerrit-patch-uploader fails under git 1.9.

I'm a bit confused -- are you trying to use Gerrit Patch Uploader and/or Wikimedia's Gerrit, or just testing something locally?

Aug 13 2019, 8:04 PM · RelEng-Archive-FY201718-Q1, Gerrit, Tool-Gerrit-Patch-Uploader

Jul 31 2019

valhallasw closed T229395: Cannot login to Gerrit Patch Uploader as Resolved.

Not sure what to do on this -- if the infra doesn't work there's not much to do other than erroring out.

Jul 31 2019, 6:51 PM · Tool-Gerrit-Patch-Uploader
valhallasw added a comment to T229395: Cannot login to Gerrit Patch Uploader.

From the error logs:

Traceback (most recent call last):
  File "/data/project/gerrit-patch-uploader/www/python/venv/lib/python3.4/site-packages/urllib3/connectionpool.py", line 600, in urlopen
    chunked=chunked)
  File "/data/project/gerrit-patch-uploader/www/python/venv/lib/python3.4/site-packages/urllib3/connectionpool.py", line 343, in _make_request
    self._validate_conn(conn)
  File "/data/project/gerrit-patch-uploader/www/python/venv/lib/python3.4/site-packages/urllib3/connectionpool.py", line 839, in _validate_conn
    conn.connect()
  File "/data/project/gerrit-patch-uploader/www/python/venv/lib/python3.4/site-packages/urllib3/connection.py", line 301, in connect
    conn = self._new_conn()
  File "/data/project/gerrit-patch-uploader/www/python/venv/lib/python3.4/site-packages/urllib3/connection.py", line 168, in _new_conn
    self, "Failed to establish a new connection: %s" % e)
urllib3.exceptions.NewConnectionError: <urllib3.connection.VerifiedHTTPSConnection object at 0x7fd4ab209ba8>: Failed to establish a new connection: [Errno -2] Name or service not known
Jul 31 2019, 6:51 PM · Tool-Gerrit-Patch-Uploader

Jul 27 2019

valhallasw added a comment to T201261: Exclude secondary jenkins-bot/PipelineBot messages from Gerrit in Wikibugs on IRC.

Does the bot have enough information to be able to filter it out? If so, then I imagine it will also be able to filter out the non-voting information messages from Fresnel, and Patch coverage. Right now they cause duplicate messages as well if a previous voting build failed because the "new" Gerrit always re-broadcasts old scores.

Jul 27 2019, 8:09 PM · Release-Engineering-Team, Wikibugs

Jul 16 2019

Krinkle awarded T201261: Exclude secondary jenkins-bot/PipelineBot messages from Gerrit in Wikibugs on IRC a Orange Medal token.
Jul 16 2019, 12:33 AM · Release-Engineering-Team, Wikibugs

Jun 25 2019

valhallasw added a comment to T226507: Port pywikibot-core to new pywikibot IV repository (tracking).

@valhallasw We are trying to break as little as possible. So if anyone's cron automatically updates git and it still runs under py2 (per my experience and per our Wikimedia Hackathon meetup a dominant group of users), this would break their cron scripts. That's why we are trying to freeze the current master (I like the idea of final v3 release anyway) and start a new branch from it.

Jun 25 2019, 7:43 PM · Pywikibot-RfCs, Pywikibot
valhallasw added a comment to T226507: Port pywikibot-core to new pywikibot IV repository (tracking).

Based on the experience we had with moving from compat to core, I would advice against a new repository for the continued development. I'm afraid it will lead to a slow death of v3 (with lots of people not moving, and then once they move it becomes very painful due to the large difference between the versions).

Jun 25 2019, 5:59 PM · Pywikibot-RfCs, Pywikibot

Jun 11 2019

valhallasw added a comment to T137805: API action=login is deprecated.

Of course, but still we have different Botpassword for Beta Cluster and different for wikis, which is a thing we need to overcome somehow. I suggested to have an environment variable containing Botpassword for each wiki family we use to test (I think there are 3 or 4 of them), which needs some additional code to make it work, but it should work.

Jun 11 2019, 7:09 PM · Pywikibot-tests, Pywikibot, Pywikibot-login.py

Jun 5 2019

valhallasw added a comment to T225130: Whitelist wikibugs for #wikimedia-codehealth.

Test deployment

Jun 5 2019, 7:50 PM · Code-Health, Wikibugs
valhallasw closed T225130: Whitelist wikibugs for #wikimedia-codehealth as Resolved.

Thanks!

Jun 5 2019, 7:48 PM · Code-Health, Wikibugs
valhallasw created T225130: Whitelist wikibugs for #wikimedia-codehealth.
Jun 5 2019, 6:03 PM · Code-Health, Wikibugs

May 31 2019

valhallasw added a comment to T137805: API action=login is deprecated.
  • Wouldnt ("en", "wikipedia", "my_username", BotPassword("botpassword suffix", "bot password")) work in the password file? See LoginManager.readPassword in login.py.
    • If not, that sounds like something we should support...
  • I believe it is possible to pass the botpassword in the classic login process by using "prefix@password" as password (this is not clearly documented on mw.org but is shown after creating a botpassword).
May 31 2019, 5:54 PM · Pywikibot-tests, Pywikibot, Pywikibot-login.py

May 30 2019

valhallasw added a comment to T224622: Verkeerde berichtgeving nominaties 2019-05-28.

Ik ben even door de lijst van vannacht heengelopen; daar geen bijzonderheden gespot.

May 30 2019, 10:23 AM · Tool-nlwikibots
valhallasw added a comment to T224622: Verkeerde berichtgeving nominaties 2019-05-28.

Excuus, dat had ik inderdaad niet overgenomen uit de oorspronkelijke email. Maar je hebt het gelukkig zelf gevonden.

May 30 2019, 10:23 AM · Tool-nlwikibots

May 29 2019

valhallasw created T224622: Verkeerde berichtgeving nominaties 2019-05-28.
May 29 2019, 7:55 PM · Tool-nlwikibots

May 28 2019

valhallasw added a comment to T218442: Hide successful PipelineBot messages from wikibugs's feed, the same way we do for jenkins-bot.

Another 🥨 here to test wikibugs

May 28 2019, 6:30 PM · Release-Engineering-Team, Release Pipeline, Wikibugs

May 22 2019

valhallasw added a comment to T123121: Linkwatcher spawns many processes without parent.

Can someone please move all other bots away from the instance that runs linkwatcher? @valhallasw?

May 22 2019, 7:55 PM · Cloud-Services, Toolforge

May 19 2019

valhallasw added a comment to T219573: Have a system to automatically ping individuals in IRC when a task in a given component goes UBN.

Looking at the code:

May 19 2019, 2:07 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO, Wikibugs

May 12 2019

valhallasw added a comment to T222983: reviewer-bot sometimes not working.

There's another odd thing here. If we look at changeset 508721, GRB adds the reviewer at 21:30 UTC.

May 12 2019, 3:11 PM · Gerrit
valhallasw added a comment to T222983: reviewer-bot sometimes not working.

I cannot find any reference to this changeset in the bot logs. This suggests the changeset never showed up on the mediawiki-commits mailing list (which is odd), the email was filtered out as spam (again, unclear why that would happen), or the email was ignored by the bot (but there's nothing in the log to suggest this -- skipped emails are also logged).

May 12 2019, 3:03 PM · Gerrit

Apr 23 2019

valhallasw closed T86354: Serve static resources from //tools-static.wmflabs.org or /static/ project as Resolved.

Yep, thanks for the reminder!

Apr 23 2019, 6:27 PM · Tool-Gerrit-Patch-Uploader

Apr 6 2019

valhallasw added a comment to T219091: toolforge: Update python image to Stretch.

Python 3.4 is now no longer supported by upstream; one consequence is that mypy has dropped support for it, making my CI build for a tool fail.

Apr 6 2019, 7:18 PM · Wikimedia-Hackathon-2019, cloud-services-team (Kanban), Toolforge

Mar 27 2019

bd808 awarded T219336: contact tool returning 500 error response for searches a 100 token.
Mar 27 2019, 7:40 PM · Tools
valhallasw closed T219336: contact tool returning 500 error response for searches as Resolved.

Fixed with a tiny bit of jinja magic:

Mar 27 2019, 7:31 PM · Tools
valhallasw added a comment to T219336: contact tool returning 500 error response for searches.

The code suggests this has always been a dict:

{% for group in v['groups'].values() | sort %}
<li>{{ group['cn'] | querylink }}</li>
{% endfor %}</ul></dd>{% endif %}

(otherwise group['cn'] would not make sense), so this only worked because in Python 2 dicts can be ordered. The tool _does_ work without issues for tools, so I think I just did not test with a user instead of a tool.

Mar 27 2019, 7:23 PM · Tools
valhallasw added a comment to T219336: contact tool returning 500 error response for searches.

Could also be fallout from https://phabricator.wikimedia.org/T216354#4999683, although I did test the deployment, and everything seemed OK afterwards. Did anything change with respect to what is stored in ldap?

Mar 27 2019, 7:17 PM · Tools

Mar 21 2019

GitHub <noreply@github.com> committed rTGPUd74b523e7f6d: Merge pull request #20 from valhallasw/stretch-upgrade (authored by valhallasw).
Merge pull request #20 from valhallasw/stretch-upgrade
Mar 21 2019, 12:47 AM
valhallasw committed rTGPU4bffb42e2dd9: Update crontab (authored by valhallasw).
Update crontab
Mar 21 2019, 12:47 AM
valhallasw committed rTGPU8c87cfa61f2c: Install flake8 via requirements.txt (authored by valhallasw).
Install flake8 via requirements.txt
Mar 21 2019, 12:47 AM
valhallasw committed rTGPUa6d7d96eed26: Mailbox generates bytes, not str (authored by valhallasw).
Mailbox generates bytes, not str
Mar 21 2019, 12:47 AM
valhallasw committed rTGPU08958244aa15: Add Cirrus CI (authored by valhallasw).
Add Cirrus CI
Mar 21 2019, 12:47 AM
valhallasw committed rTGPU5d29344cc4e3: Re-add simplified online test (authored by valhallasw).
Re-add simplified online test
Mar 21 2019, 12:47 AM
valhallasw committed rTGPU34eb311d300a: Add pop3bot tests (authored by valhallasw).
Add pop3bot tests
Mar 21 2019, 12:47 AM
valhallasw committed rTGPUb988978662d8: Rename test.py to something more sensible (authored by valhallasw).
Rename test.py to something more sensible
Mar 21 2019, 12:47 AM
valhallasw committed rTGPU93a2803ca0e5: Move test to tests/ (authored by valhallasw).
Move test to tests/
Mar 21 2019, 12:47 AM
valhallasw committed rTGPU0a0f41721a94: Remove some old test files (authored by valhallasw).
Remove some old test files
Mar 21 2019, 12:47 AM
valhallasw committed rTGPUb376b5d5abd5: Ignore Pycharm files (authored by valhallasw).
Ignore Pycharm files
Mar 21 2019, 12:47 AM
valhallasw committed rTGPUd3050fe6ad61: Cleanup, pep8, etc (authored by valhallasw).
Cleanup, pep8, etc
Mar 21 2019, 12:47 AM
valhallasw committed rTGPU3002ce4d69ed: Move get_changeset, filter_reviewers and get_reviewers_for_changeset to more… (authored by valhallasw).
Move get_changeset, filter_reviewers and get_reviewers_for_changeset to more…
Mar 21 2019, 12:47 AM
valhallasw committed rTGPU406e2edc78b7: 2to3 conversion (authored by valhallasw).
2to3 conversion
Mar 21 2019, 12:47 AM
valhallasw committed rTGPU4e93e216345a: Add SGE scripts (authored by valhallasw).
Add SGE scripts
Mar 21 2019, 12:47 AM