Page MenuHomePhabricator

vas (Vas Yaremchuk)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 3 2020, 9:34 AM (156 w, 6 d)
Availability
Available
LDAP User
Vas Yaremchuk
MediaWiki User
Unknown

Recent Activity

Jun 24 2020

vas added a comment to T219793: Mobile web donate link.

Hi Jon,

Jun 24 2020, 12:29 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Fundraising-Backlog, MobileFrontend, Design, Wikimedia-Design

Jun 22 2020

vas added a comment to T219793: Mobile web donate link.

Hi Jon,

Jun 22 2020, 4:08 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Fundraising-Backlog, MobileFrontend, Design, Wikimedia-Design
vas added a comment to T219793: Mobile web donate link.

@Ammarpad Thank you! It works now.

Jun 22 2020, 1:08 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Fundraising-Backlog, MobileFrontend, Design, Wikimedia-Design

Jun 19 2020

vas reassigned T219793: Mobile web donate link from vas to Jdlrobson.

Hi Jon,

Jun 19 2020, 2:26 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Fundraising-Backlog, MobileFrontend, Design, Wikimedia-Design
vas claimed T219793: Mobile web donate link.
Jun 19 2020, 11:42 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Fundraising-Backlog, MobileFrontend, Design, Wikimedia-Design

Jun 17 2020

vas reassigned T219793: Mobile web donate link from vas to Jdlrobson.

please review my patch.

Jun 17 2020, 6:21 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Fundraising-Backlog, MobileFrontend, Design, Wikimedia-Design
vas reassigned T254378: Drop wgVectorResponsive support from modern Vector from vas to Jdlrobson.

Jon, please review it again.

Jun 17 2020, 11:24 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, patch-welcome, Vector (legacy skin)

Jun 16 2020

vas reassigned T254378: Drop wgVectorResponsive support from modern Vector from vas to Jdlrobson.

Hi Jon,
please review it again,
I have followed your recommendations, but in that approach I can see following issues:

Jun 16 2020, 12:57 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, patch-welcome, Vector (legacy skin)

Jun 15 2020

vas reassigned T253814: [Dev] Deprecate SkinTemplatePreventOtherActiveTabs and SkinTemplateTabAction hooks from Jdlrobson to Ammarpad.

Ammar, please review it again.

Jun 15 2020, 11:59 AM · MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q4), MW-1.35-release, Technical-Debt (Deprecation process), MediaWiki-Interface, MediaWiki-Core-Skin-Architecture
vas reassigned T254378: Drop wgVectorResponsive support from modern Vector from vas to Jdlrobson.

Jon, please review it again.

Jun 15 2020, 10:54 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, patch-welcome, Vector (legacy skin)

Jun 12 2020

vas added a comment to T253814: [Dev] Deprecate SkinTemplatePreventOtherActiveTabs and SkinTemplateTabAction hooks.

Jon, please review my release-notes.

Jun 12 2020, 1:51 PM · MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q4), MW-1.35-release, Technical-Debt (Deprecation process), MediaWiki-Interface, MediaWiki-Core-Skin-Architecture
vas reassigned T254378: Drop wgVectorResponsive support from modern Vector from vas to Jdlrobson.

Hi Jon,
I made my patch, but I'm not 100% sure that my logic correct, it's not explained in the description
should we add that script if there is no get parameter 'useskinversion'.

Jun 12 2020, 12:48 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, patch-welcome, Vector (legacy skin)

Jun 11 2020

vas claimed T254378: Drop wgVectorResponsive support from modern Vector.
Jun 11 2020, 2:12 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, patch-welcome, Vector (legacy skin)
vas reassigned T251957: skinScripts cannot be used alongside packageFiles: should throw exception. from vas to Jdlrobson.

Jon, please ignore https://gerrit.wikimedia.org/r/604647
The correct version to review in https://gerrit.wikimedia.org/r/604011

Jun 11 2020, 10:17 AM · MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Patch-For-Review, Developer Productivity, Readers-Web-Backlog (Kanbanana-2019-20-Q4), Performance-Team, MediaWiki-ResourceLoader, Desktop Improvements (Vector 2022)

Jun 9 2020

vas reassigned T251957: skinScripts cannot be used alongside packageFiles: should throw exception. from vas to Jdlrobson.

Jon, I have fixed 2 issues in includes/resourceloader/ResourceLoaderFileModule.php

Jun 9 2020, 5:21 PM · MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Patch-For-Review, Developer Productivity, Readers-Web-Backlog (Kanbanana-2019-20-Q4), Performance-Team, MediaWiki-ResourceLoader, Desktop Improvements (Vector 2022)
vas reassigned T251957: skinScripts cannot be used alongside packageFiles: should throw exception. from vas to Jdlrobson.

Jon, please check my patch.

Jun 9 2020, 1:39 PM · MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Patch-For-Review, Developer Productivity, Readers-Web-Backlog (Kanbanana-2019-20-Q4), Performance-Team, MediaWiki-ResourceLoader, Desktop Improvements (Vector 2022)

Jun 8 2020

vas assigned T254620: [technical] Drop VectorSimpleSearch config flag to Jdlrobson.

I have taken a look at that task and it seems it was resolved in change 602799 (see above), but I think that we have to put comments about that in the HISTORY file.

Jun 8 2020, 12:44 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Patch-For-Review, Technical-Debt, Vector (legacy skin), Readers-Web-Backlog (Kanbanana-2019-20-Q4)

Jun 5 2020

vas reassigned T253814: [Dev] Deprecate SkinTemplatePreventOtherActiveTabs and SkinTemplateTabAction hooks from vas to Jdlrobson.

Jon, please review the patch.

Jun 5 2020, 12:28 PM · MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q4), MW-1.35-release, Technical-Debt (Deprecation process), MediaWiki-Interface, MediaWiki-Core-Skin-Architecture