@Niharika I'm not really sure on that. I don't think it's likely, so this is a very edge case. @Tchanders do you have any thoughts on when this might occur?

Sure! Right now, we only get that information if we return valid information for both the local and recent edits. If either one of those are invalid, the entire section under Contributions is "Not Available". Do we want to redesign the way Contributions are populated so that if some of the information is valid we see that?

This is a very unlikely scenario so we may not need to address it at all. Is this something we need to consider and prepare for?

Not triaging because this is still a Product Decision for @Niharika .

Thanks!

How can we go about testing that this works on Wikimedia? I haven't worked with unsupported languages before.

My WIP patch is to see if I'm going in the right direction for this bug or if there's a code style/convention I'm not following to fix this properly.

There seems to be an issue with the overflow CSS property. I'm able to remove that by setting it to hidden, but that also removes the bullet points from the left, which we want to keep. This is only happening in FF and changing overflow in Chrome doesn't seem to affect anything at all.

@STran & @Prtksxna I've looked at the patch and it appears to work well on the IPInfobox but these aren't displaying in the popup. Just to clarify from the previous comments, we are NOT doing these in the popup? If that's the case, I'm good to +2.

I'm testing this on Firefox 95 and I can't see a difference between this and what's happening on Chrome. @Prtksxna Can you spot what I'm supposed to fix?

I'm happy to add all of these things and will defer to @Tchanders decision on including them.

@Niharika @ARamirez_WMF Can you guys take a look at the wording I used and let me know what you would like to say differently? Otherwise this should be good, right?

the decision is to change to 'infobox' the two file directories noted above and to change 'InfoBoxHandler' to 'InfoboxHandler'

@phuedx yes, I'm working on it now. I was looking up how to properly create things on a Translate wiki page, as it's more complicated than just putting in some text and hyperlinks. I haven't moved it to In Progress until my other ticket passes CR

per @STran we can likely ignore the updater and test files.

@phuedx should we be using Wikimedia Events or hard code an mw-track event?

@Niharika just to confirm, we are counting how many users open the agreement and then bounce WITHOUT accepting the terms?

This will be discussed in Engineering meeting. From our initial review, 'infobox' seems to be the default naming convention. The instances of camelCase are the two files loaded in the ResourceLoader (extension.json & dispatcher.js), infoBox/init.js & infoBox/widget.js. We can discuss if these should be renamed or left alone.

@phuedx and @Tchanders I've gotten the rebase finished but there's some part that's not letting the data display. Can either of you point me to the file/function I'm missing?

You can see these changes on Special:Contributions/ and Special:Log (popup).

@dom_walden That's more thorough than anything I thought of, so as long as it's still working that's great on the client side. I'm not sure of another way to test the server side other than what you've suggested.

@Tchanders Since we will likely need to update the text of the labels and add the actual information in a separate task, I would like to leave these changes in so the person with the new task can simply change the json data for the labels and spend more of their time on the data portion.

moving to QA because I'm not able to find any 0 registering as falsey.

@STran I've verified that inputting 0 as a value seems to trigger the appropriate messages/data. Was there anything else I need to do on this ticket specifically?

@imaigwilo You should be able to make sure you are getting the information that's on these screenshots when you test the code.

Hi @imaigwilo ! If you go to the Special:Log page and click on the ? icon for contributions, under your Network tab in developer tools you should see an api call happen. Mine just showed a number 13. Click on that and the IP address info object should have the edits and blocks there.

This only has the number of local edits and recent edits. Currently the framework is not available to pull in global edits, per @phuedx

Great job Essex!

Per testing, there is a delay of 40 seconds testing with @tstarling 's method.