Page MenuHomePhabricator

wychen (Wei-Yin Chen)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 2 2017, 6:56 PM (129 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Weiyinchen [ Global Accounts ]

Recent Activity

Mar 6 2017

wychen added a comment to T159477: Use <img> tag instead of <span> as the placeholder for lazy loading.

I'd like to see the DOM state before image loading more semantically correct. Currently there's no hints in the DOM saying there would be an image appearing. Having a place-holding <img> would give out this intention better, even though the src and srcset are incorrect (temporarily). For most mobile-optimized sites, lazy image loading is implemented this way, and some sites add dummy data URI as src to be standard compliant like you suggested.

Mar 6 2017, 9:52 PM · Readers-Web-Backlog, MobileFrontend
wychen added a comment to T159475: isWideScreen() should only check the width of the device when determining whether a device is wide screen.

So let's use width. It's simpler.

Mar 6 2017, 9:36 PM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), patch-welcome, good first bug, MobileFrontend
wychen added a comment to T159475: isWideScreen() should only check the width of the device when determining whether a device is wide screen.

I don't really use phones in landscape mode for web browsing, but from the comment, it seems it's desirable to keep the behavior the same for both portrait and landscape modes. The section folding is only done when the document is loaded, but not on device rotation. If we load the page in landscape mode, the section wouldn't be folded, and when changing to portrait, it would still not be folded, unlike if we load the document in portrait in the beginning.

Mar 6 2017, 6:45 PM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), patch-welcome, good first bug, MobileFrontend
wychen added a comment to T159477: Use <img> tag instead of <span> as the placeholder for lazy loading.

We can still keep the <span> as the container for the loading indicator. It could be something like

<span><img data-src="..." ...></span>

before expansion, and

<span><img src="..." ...></span>

in the end.

Mar 6 2017, 4:40 PM · Readers-Web-Backlog, MobileFrontend

Mar 2 2017

wychen created T159477: Use <img> tag instead of <span> as the placeholder for lazy loading.
Mar 2 2017, 8:20 PM · Readers-Web-Backlog, MobileFrontend
wychen added a project to T159475: isWideScreen() should only check the width of the device when determining whether a device is wide screen: MobileFrontend.
Mar 2 2017, 7:58 PM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), patch-welcome, good first bug, MobileFrontend
wychen created T159475: isWideScreen() should only check the width of the device when determining whether a device is wide screen.
Mar 2 2017, 7:40 PM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), patch-welcome, good first bug, MobileFrontend