minify was not enabled at that time. After rebasing, I noticed that we have enabled minifying for debug builds as well. Multidex is not needed now.
Here's the dex method count for a dev debug build:

In T76953#4018081, @Dbrant wrote:

@yashasvi Since you've claimed T166903, let's make sure it's completed before delving into this.

As you expected, it exceeds the 64k method count. I've made a proof of concept patch (had to enable multidex) which replaces otto with rx for ThemeChangeEvent.

Hi @Dbrant , I went through the code. Some observations/questions below (Correct me if I am wrong anywhere) :

In T76953#4005393, @Deskana wrote:

Hey @yashasvi! I've not been involved with the mobile apps for a few years now, so you should probably ask @Charlotte and @Dbrant for their input.

In terms of the code that I wrote three years ago, I highly doubt it's useful any more since the app will have changed a lot in those years. Starting from scratch would probably better. :-)

In T166903#4006249, @Dbrant wrote:

@yashasvi You're welcome to pick it up, but we'd like it to be completed before the hackathon.

I am willing to take this up in the upcoming hackathon (provided I get through the scholarship grant :) ).

Thanks for the information.

I was planning to pick this task in the upcoming hackathon but seems like it's already been picked up. Please correct me if I am wrong.

Hi team,

Hi Team,

In T167314#3891169, @cooltey wrote:

Thanks @yashasvi and @Niedzielski , I will do it :)

I've created a patch for this.

In T146091#3855218, @cooltey wrote:

@yashasvi Hi, I can review the patch for you and will leave some comments on the patch.

Wanted to check if you or someone else in the team had time to check the patch ? :)

Just checking if you had a chance to look at the patch.

@RHo , Great! Thanks for verifying.

Updated the patch. Let me know if anything else is needed.

I've made the change, modified and added some strings in strings.xml (and appropriately in values-qq/strings.xml). The units shown on various screens look good to me in english locale.

Sorry I missed this task earlier.

In T146091#3808825, @RHo wrote:

In T146091#3808645, @RHo wrote:

Hi @yashasvi - the snackbar on top of the actions is correct, but I'm unable to check your patch showing this change.

Actually I cleaned out the project and can see the action now, and it looks great! Only thing is that when user scrolls, the snackbar should also scroll off with the bottom toolbar, instead of remaining in place:

(open full screen to view animated gif)

updated the patch and snackbar now shows on top of actions bar as per other screens in app.

I've made a patch such that the actions bar adjusts its height itself when snackbar appears. Here are the screenshots :

I am thinking of picking this up. Needed some help from you.

Test Plan :

Thanks for the clarification.

Have you tried exploring Crashlytics yet?

I am picking this up. Had few questions before going ahead.

We are not receiving the correct text from the web :

I am thinking of picking this up.

I've a patch for this. Can you please review the same.

In T152404#3391750, @Mholloway wrote:

Anytime!

I'm not sure you got my replies on IRC, so if you'd like to pick up additional tasks, besides anything tagged good first task you can look at the "Bug Backlog" column on Wikipedia-Android-App-Backlog and pick out anything that interests you.

I'm glad you're enjoying contributing to the app!

Thanks for merging the patch @Mholloway :).

the patch for this has been merged. Can we mark it as done?

I'd like to pick this up. Have created the patch.

I've submitted a patch for the tests here

In T152404#3367434, @Mholloway wrote:

@yashasvi The patch is looking good! I made a small change to the commit message and re-uploaded in order to auto-tag this task. My uploading will also trigger the CI tests.

Are you up for writing tests for it? I usually do that in a follow up patch, and the two end up getting merged at the same time.

I've made a patch for this here. I've tested both the image (on some random pages) as well as video items ( on Wikipedia:Videos article). Here are the screenshots :

image

video thumnbnail

video playing

Thanks for the note @Mholloway .

Yeah, it'd help definitely ! :)

Can you please explain what extra functionality does PageQueryTask adds over ApiTask ?

Cool, I had another look at it.
Seems like it shouldn't take much time now :)

Do we have any documentation material around the Async Task framework that we have in the code?

@bearND : Hey, I have created the commit for this here. Can you please review it? :)

Sceenshots after the fix :

My bad, it's api >=21 (lollipop), not 23.

happens only on api >= 23. Reason (from https://developer.android.com/about/versions/android-5.0-changes.html):

I am picking up this.

Hi Everyone,