Page MenuHomePhabricator

yashasvi (yash)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jun 4 2017, 12:02 PM (130 w, 5 d)
Availability
Available
IRC Nick
yashasvi
LDAP User
Yashasvi
MediaWiki User
Unknown

Recent Activity

Mar 8 2018

yashasvi added a comment to T166903: Replace Otto event bus.

minify was not enabled at that time. After rebasing, I noticed that we have enabled minifying for debug builds as well. Multidex is not needed now.
Here's the dex method count for a dev debug build:

Mar 8 2018, 7:22 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme), Patch-For-Review, Technical-Debt

Mar 7 2018

yashasvi added a comment to T76953: Add watchlist to app.

@yashasvi Since you've claimed T166903, let's make sure it's completed before delving into this.

Mar 7 2018, 5:36 AM · android-app-feature-watchlist, WorkType-NewFunctionality, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog

Mar 5 2018

yashasvi added a comment to T166903: Replace Otto event bus.

As you expected, it exceeds the 64k method count. I've made a proof of concept patch (had to enable multidex) which replaces otto with rx for ThemeChangeEvent.

Mar 5 2018, 6:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme), Patch-For-Review, Technical-Debt
yashasvi added a comment to T166903: Replace Otto event bus.

Hi @Dbrant , I went through the code. Some observations/questions below (Correct me if I am wrong anywhere) :

Mar 5 2018, 12:44 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme), Patch-For-Review, Technical-Debt

Mar 2 2018

yashasvi added a comment to T76953: Add watchlist to app.

Hey @yashasvi! I've not been involved with the mobile apps for a few years now, so you should probably ask @Charlotte and @Dbrant for their input.
In terms of the code that I wrote three years ago, I highly doubt it's useful any more since the app will have changed a lot in those years. Starting from scratch would probably better. :-)

Mar 2 2018, 3:45 PM · android-app-feature-watchlist, WorkType-NewFunctionality, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog
yashasvi claimed T166903: Replace Otto event bus.

@yashasvi You're welcome to pick it up, but we'd like it to be completed before the hackathon.

Mar 2 2018, 3:33 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme), Patch-For-Review, Technical-Debt

Feb 27 2018

yashasvi added a comment to T76953: Add watchlist to app.

I am willing to take this up in the upcoming hackathon (provided I get through the scholarship grant :) ).

Feb 27 2018, 9:17 AM · android-app-feature-watchlist, WorkType-NewFunctionality, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog
yashasvi added a comment to T185375: Potential projects for wikimedia hackathon 2018.

Thanks for the information.

Feb 27 2018, 9:13 AM · Tracking-Neverending, Wikipedia-Android-App-Backlog
yashasvi updated subscribers of T166903: Replace Otto event bus.

I was planning to pick this task in the upcoming hackathon but seems like it's already been picked up. Please correct me if I am wrong.

Feb 27 2018, 8:50 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme), Patch-For-Review, Technical-Debt
yashasvi added a member for Wikimedia-Hackathon-2018: yashasvi.
Feb 27 2018, 7:44 AM

Jan 20 2018

yashasvi added a comment to T185390: Potential Newcomer Tasks for wikimedia hackathon 2018.

Hi team,

Jan 20 2018, 8:05 PM · Tracking-Neverending, Wikipedia-Android-App-Backlog
yashasvi triaged T185390: Potential Newcomer Tasks for wikimedia hackathon 2018 as Low priority.
Jan 20 2018, 5:29 PM · Tracking-Neverending, Wikipedia-Android-App-Backlog
yashasvi added a comment to T185375: Potential projects for wikimedia hackathon 2018.

Hi Team,

Jan 20 2018, 12:14 PM · Tracking-Neverending, Wikipedia-Android-App-Backlog
yashasvi triaged T185375: Potential projects for wikimedia hackathon 2018 as Low priority.
Jan 20 2018, 12:02 PM · Tracking-Neverending, Wikipedia-Android-App-Backlog

Jan 15 2018

yashasvi added a comment to T167314: Create EventLogging dev setting.

Thanks @yashasvi and @Niedzielski , I will do it :)

Jan 15 2018, 2:56 PM · Patch-For-Review, good first task, Technical-Debt, Wikipedia-Android-App-Backlog

Jan 10 2018

yashasvi added a comment to T167314: Create EventLogging dev setting.

I've created a patch for this.

Jan 10 2018, 7:19 PM · Patch-For-Review, good first task, Technical-Debt, Wikipedia-Android-App-Backlog

Jan 9 2018

yashasvi added a comment to T146091: [BUG] Snackbars should appear above article toolbar.

@yashasvi Hi, I can review the patch for you and will leave some comments on the patch.

Jan 9 2018, 5:57 AM · Patch-For-Review, good first task, Android-app-Bugs, Wikipedia-Android-App-Backlog

Jan 6 2018

yashasvi added a comment to T177879: Display storage space and file size in appropriate units.

Wanted to check if you or someone else in the team had time to check the patch ? :)

Jan 6 2018, 3:27 PM · Patch-For-Review, good first task, Wikipedia-Android-App-Backlog, Android-app-feature-Compilations

Dec 21 2017

yashasvi added a comment to T177879: Display storage space and file size in appropriate units.

Just checking if you had a chance to look at the patch.

Dec 21 2017, 7:21 PM · Patch-For-Review, good first task, Wikipedia-Android-App-Backlog, Android-app-feature-Compilations
yashasvi added a comment to T146091: [BUG] Snackbars should appear above article toolbar.

@RHo , Great! Thanks for verifying.

Dec 21 2017, 7:16 PM · Patch-For-Review, good first task, Android-app-Bugs, Wikipedia-Android-App-Backlog

Dec 9 2017

yashasvi added a comment to T146091: [BUG] Snackbars should appear above article toolbar.

Updated the patch. Let me know if anything else is needed.

Dec 9 2017, 12:50 PM · Patch-For-Review, good first task, Android-app-Bugs, Wikipedia-Android-App-Backlog
yashasvi added a comment to T177879: Display storage space and file size in appropriate units.

I've made the change, modified and added some strings in strings.xml (and appropriately in values-qq/strings.xml). The units shown on various screens look good to me in english locale.

Dec 9 2017, 11:54 AM · Patch-For-Review, good first task, Wikipedia-Android-App-Backlog, Android-app-feature-Compilations

Dec 8 2017

yashasvi added a comment to T177879: Display storage space and file size in appropriate units.

Sorry I missed this task earlier.

Dec 8 2017, 8:17 PM · Patch-For-Review, good first task, Wikipedia-Android-App-Backlog, Android-app-feature-Compilations

Dec 7 2017

yashasvi added a comment to T146091: [BUG] Snackbars should appear above article toolbar.

Hi @yashasvi - the snackbar on top of the actions is correct, but I'm unable to check your patch showing this change.

Actually I cleaned out the project and can see the action now, and it looks great! Only thing is that when user scrolls, the snackbar should also scroll off with the bottom toolbar, instead of remaining in place:

(open full screen to view animated gif)

Dec 7 2017, 2:32 PM · Patch-For-Review, good first task, Android-app-Bugs, Wikipedia-Android-App-Backlog

Dec 3 2017

yashasvi added a comment to T146091: [BUG] Snackbars should appear above article toolbar.

updated the patch and snackbar now shows on top of actions bar as per other screens in app.

Dec 3 2017, 3:49 PM · Patch-For-Review, good first task, Android-app-Bugs, Wikipedia-Android-App-Backlog

Dec 2 2017

yashasvi updated subscribers of T146091: [BUG] Snackbars should appear above article toolbar.

I've made a patch such that the actions bar adjusts its height itself when snackbar appears. Here are the screenshots :

Dec 2 2017, 4:09 PM · Patch-For-Review, good first task, Android-app-Bugs, Wikipedia-Android-App-Backlog

Oct 21 2017

yashasvi added a comment to T177879: Display storage space and file size in appropriate units.

I am thinking of picking this up. Needed some help from you.

Oct 21 2017, 12:59 PM · Patch-For-Review, good first task, Wikipedia-Android-App-Backlog, Android-app-feature-Compilations

Oct 2 2017

yashasvi added a comment to T172998: [BUG] Article overflow menu is missing the "Remove from reading list" option.

Test Plan :

Oct 2 2017, 8:33 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada), Patch-For-Review, Android-app-Bugs
yashasvi added a comment to T172998: [BUG] Article overflow menu is missing the "Remove from reading list" option.

Thanks for the clarification.

Oct 2 2017, 8:01 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada), Patch-For-Review, Android-app-Bugs

Sep 16 2017

yashasvi updated subscribers of T146487: Have a way to monitor the crash rate and alert for sharp increases.

Have you tried exploring Crashlytics yet?

Sep 16 2017, 1:42 PM · Technical-Debt, Wikipedia-Android-App-Backlog
yashasvi updated subscribers of T172998: [BUG] Article overflow menu is missing the "Remove from reading list" option.

I am picking this up. Had few questions before going ahead.

Sep 16 2017, 1:13 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada), Patch-For-Review, Android-app-Bugs

Jul 12 2017

yashasvi added a comment to T168112: IPA text mangled in ShareAFact.

We are not receiving the correct text from the web :

Jul 12 2017, 6:33 PM · Wikipedia-Android-App-Backlog, Android-app-Bugs
yashasvi added a comment to T166319: Pages saved for offline are unavailable when offline.

I am thinking of picking this up.

Jul 12 2017, 6:11 PM · Android-app-Bugs, Wikipedia-Android-App-Backlog

Jul 9 2017

yashasvi updated subscribers of T167372: 'text' field in ShareAFact schema is always NULL for 'highlight' events.

I've a patch for this. Can you please review the same.

Jul 9 2017, 9:42 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.19x-Cookie🍪), Patch-For-Review, good first task, Android-app-Bugs

Jun 30 2017

yashasvi added a comment to T152404: Retrofit GalleryItemFetchTask.

Anytime!
I'm not sure you got my replies on IRC, so if you'd like to pick up additional tasks, besides anything tagged good first task you can look at the "Bug Backlog" column on Wikipedia-Android-App-Backlog and pick out anything that interests you.
I'm glad you're enjoying contributing to the app!

Jun 30 2017, 4:22 AM · Patch-For-Review, good first task, Technical-Debt, Wikipedia-Android-App-Backlog
yashasvi removed a watcher for Wikipedia-Android-App-Backlog: yashasvi.
Jun 30 2017, 4:15 AM

Jun 29 2017

yashasvi added a comment to T152404: Retrofit GalleryItemFetchTask.

Thanks for merging the patch @Mholloway :).

Jun 29 2017, 4:41 PM · Patch-For-Review, good first task, Technical-Debt, Wikipedia-Android-App-Backlog

Jun 25 2017

yashasvi added a watcher for Wikipedia-Android-App-Backlog: yashasvi.
Jun 25 2017, 2:51 PM
yashasvi added a comment to T159722: Alpha update available icon is blank on Lollipop (API 21) and later versions.

the patch for this has been merged. Can we mark it as done?

Jun 25 2017, 2:48 PM · Wikipedia-Android-App-Backlog, good first task, Android-app-Bugs
yashasvi added a comment to T141127: Remove dependency on apps-android-java-mwapi.

I'd like to pick this up. Have created the patch.

Jun 25 2017, 10:49 AM · Patch-For-Review, Technical-Debt, Wikipedia-Android-App-Backlog

Jun 24 2017

yashasvi added a comment to T152404: Retrofit GalleryItemFetchTask.

I've submitted a patch for the tests here

Jun 24 2017, 4:00 PM · Patch-For-Review, good first task, Technical-Debt, Wikipedia-Android-App-Backlog

Jun 22 2017

yashasvi added a comment to T152404: Retrofit GalleryItemFetchTask.

@yashasvi The patch is looking good! I made a small change to the commit message and re-uploaded in order to auto-tag this task. My uploading will also trigger the CI tests.
Are you up for writing tests for it? I usually do that in a follow up patch, and the two end up getting merged at the same time.

Jun 22 2017, 1:18 AM · Patch-For-Review, good first task, Technical-Debt, Wikipedia-Android-App-Backlog

Jun 20 2017

yashasvi added a comment to T152404: Retrofit GalleryItemFetchTask.

I've made a patch for this here. I've tested both the image (on some random pages) as well as video items ( on Wikipedia:Videos article). Here are the screenshots :

image
video thumnbnail
video playing
Jun 20 2017, 9:22 PM · Patch-For-Review, good first task, Technical-Debt, Wikipedia-Android-App-Backlog

Jun 19 2017

yashasvi added a comment to T152404: Retrofit GalleryItemFetchTask.

Thanks for the note @Mholloway .

Jun 19 2017, 6:37 AM · Patch-For-Review, good first task, Technical-Debt, Wikipedia-Android-App-Backlog

Jun 14 2017

yashasvi added a comment to T152404: Retrofit GalleryItemFetchTask.

Yeah, it'd help definitely ! :)

Jun 14 2017, 6:02 PM · Patch-For-Review, good first task, Technical-Debt, Wikipedia-Android-App-Backlog

Jun 11 2017

yashasvi added a comment to T152404: Retrofit GalleryItemFetchTask.

Can you please explain what extra functionality does PageQueryTask adds over ApiTask ?

Jun 11 2017, 3:27 PM · Patch-For-Review, good first task, Technical-Debt, Wikipedia-Android-App-Backlog

Jun 9 2017

yashasvi added a comment to T152404: Retrofit GalleryItemFetchTask.

Cool, I had another look at it.
Seems like it shouldn't take much time now :)

Jun 9 2017, 4:15 AM · Patch-For-Review, good first task, Technical-Debt, Wikipedia-Android-App-Backlog

Jun 7 2017

yashasvi added a comment to T152404: Retrofit GalleryItemFetchTask.

Do we have any documentation material around the Async Task framework that we have in the code?

Jun 7 2017, 5:16 PM · Patch-For-Review, good first task, Technical-Debt, Wikipedia-Android-App-Backlog
yashasvi added a comment to T159722: Alpha update available icon is blank on Lollipop (API 21) and later versions.

@bearND : Hey, I have created the commit for this here. Can you please review it? :)

Jun 7 2017, 5:01 PM · Wikipedia-Android-App-Backlog, good first task, Android-app-Bugs

Jun 6 2017

yashasvi added a comment to T159722: Alpha update available icon is blank on Lollipop (API 21) and later versions.

Sceenshots after the fix :

Jun 6 2017, 6:54 PM · Wikipedia-Android-App-Backlog, good first task, Android-app-Bugs
yashasvi renamed T159722: Alpha update available icon is blank on Lollipop (API 21) and later versions from Alpha update available icon is blank on Marshmallow (API 23) and later versions to Alpha update available icon is blank on Lollipop (API 21) and later versions.
Jun 6 2017, 3:36 PM · Wikipedia-Android-App-Backlog, good first task, Android-app-Bugs
yashasvi added a comment to T159722: Alpha update available icon is blank on Lollipop (API 21) and later versions.

My bad, it's api >=21 (lollipop), not 23.

Jun 6 2017, 3:36 PM · Wikipedia-Android-App-Backlog, good first task, Android-app-Bugs
yashasvi added a comment to T159722: Alpha update available icon is blank on Lollipop (API 21) and later versions.

happens only on api >= 23. Reason (from https://developer.android.com/about/versions/android-5.0-changes.html):

Jun 6 2017, 3:29 PM · Wikipedia-Android-App-Backlog, good first task, Android-app-Bugs
yashasvi claimed T152404: Retrofit GalleryItemFetchTask.

I am picking up this.

Jun 6 2017, 2:40 PM · Patch-For-Review, good first task, Technical-Debt, Wikipedia-Android-App-Backlog

Jun 4 2017

yashasvi added a comment to T159722: Alpha update available icon is blank on Lollipop (API 21) and later versions.

Hi Everyone,

Jun 4 2017, 12:36 PM · Wikipedia-Android-App-Backlog, good first task, Android-app-Bugs