Mar 8 2018
minify was not enabled at that time. After rebasing, I noticed that we have enabled minifying for debug builds as well. Multidex is not needed now.
Here's the dex method count for a dev debug build:
Mar 7 2018
Mar 5 2018
As you expected, it exceeds the 64k method count. I've made a proof of concept patch (had to enable multidex) which replaces otto with rx for ThemeChangeEvent.
Hi @Dbrant , I went through the code. Some observations/questions below (Correct me if I am wrong anywhere) :
Mar 2 2018
Feb 27 2018
I am willing to take this up in the upcoming hackathon (provided I get through the scholarship grant :) ).
Thanks for the information.
I was planning to pick this task in the upcoming hackathon but seems like it's already been picked up. Please correct me if I am wrong.
Jan 20 2018
Jan 15 2018
Jan 10 2018
I've created a patch for this.
Jan 9 2018
Jan 6 2018
Wanted to check if you or someone else in the team had time to check the patch ? :)
Dec 21 2017
Just checking if you had a chance to look at the patch.
@RHo , Great! Thanks for verifying.
Dec 9 2017
Updated the patch. Let me know if anything else is needed.
I've made the change, modified and added some strings in strings.xml (and appropriately in values-qq/strings.xml). The units shown on various screens look good to me in english locale.
Dec 8 2017
Sorry I missed this task earlier.
Dec 7 2017
Dec 3 2017
updated the patch and snackbar now shows on top of actions bar as per other screens in app.
Dec 2 2017
I've made a patch such that the actions bar adjusts its height itself when snackbar appears. Here are the screenshots :
Oct 21 2017
I am thinking of picking this up. Needed some help from you.
Oct 2 2017
Test Plan :
Thanks for the clarification.
Sep 16 2017
Have you tried exploring Crashlytics yet?
I am picking this up. Had few questions before going ahead.
Jul 12 2017
We are not receiving the correct text from the web :
I am thinking of picking this up.
Jul 9 2017
I've a patch for this. Can you please review the same.
Jun 30 2017
Jun 29 2017
Thanks for merging the patch @Mholloway :).
Jun 25 2017
the patch for this has been merged. Can we mark it as done?
I'd like to pick this up. Have created the patch.
Jun 24 2017
I've submitted a patch for the tests here
Jun 22 2017
Jun 20 2017
I've made a patch for this here. I've tested both the image (on some random pages) as well as video items ( on Wikipedia:Videos article). Here are the screenshots :
|image||video thumnbnail||video playing|
Jun 19 2017
Thanks for the note @Mholloway .
Jun 14 2017
Yeah, it'd help definitely ! :)
Jun 11 2017
Can you please explain what extra functionality does PageQueryTask adds over ApiTask ?
Jun 9 2017
Cool, I had another look at it.
Seems like it shouldn't take much time now :)
Jun 7 2017
Do we have any documentation material around the Async Task framework that we have in the code?
Jun 6 2017
Sceenshots after the fix :
My bad, it's api >=21 (lollipop), not 23.
happens only on api >= 23. Reason (from https://developer.android.com/about/versions/android-5.0-changes.html):
I am picking up this.