HomePhabricator

Update git submodules
828e6ccf0542Unpublished

Unpublished Commit · Learn More

Publishing Disabled: All publishing is disabled for this repository.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Update git submodules

  • Update extensions/ProofreadPage from branch 'wmf/1.31.0-wmf.21' to rEPRP000c7831b255
    • Fix .textSelection( 'encapsulateSelection', ... ) on #wpTextbox1

      After change ce6be3292e7d44d06f0aba8b98fbbbab80c5630c in MediaWiki core, .textSelection( 'encapsulateSelection', ... ) expects the other textSelection API overrides to be consistent with each other. However, ProofreadPage only overrides the 'getContents' method, causing 'encapsulateSelection' to behave in a very broken way.

      Re-implement 'encapsulateSelection' by copy-pasting a bunch of code from MediaWiki core jquery.textSelection :(

      We could implement the other overrides ('setContents', 'getSelection', 'getCaretPosition', 'setSelection'), but I think no one would actually use them, and I think no one would actually be interested in reviewing all that new code. So let's just do this the straightforward way (even though it's ugly) and fix the bug.

      Bug: T187454 Change-Id: I7d6d10f40780a4584d5edf35b4dc0d90bde0e7cc

Details

Provenance
matmarexAuthored on Feb 15 2018, 7:21 PM
Gerrit Code Review <gerrit@wikimedia.org>Committed on Feb 16 2018, 12:11 AM
ChangeId
None

Commit No Longer Exists

This commit no longer exists in the repository.