HomePhabricator

Merge pull request #1304 from wikimedia/feature/places-search-type-refactor

Authored by Andrew Mroczkowski <amrox@users.noreply.github.com> on Apr 21 2017, 6:22 PM.

Description

Merge pull request #1304 from wikimedia/feature/places-search-type-refactor

Update visual design of search box / search page and filtered search functionality on Places based on user feedback

Merged Changes

This commit merges a very large number of changes. Only the first 50 are shown.
CommitAuthorDetailsCommitted
220623ae83bd AMroczkowski
Using searchBarHeight variable instead of literal 
Apr 21 2017
305414989de2 AMroczkowski
removing accidently commited build number 
Apr 21 2017
d6a7703cb078 AMroczkowski
Removing commented out code 
Apr 21 2017
4096147f9e00 AMroczkowski
Removing commented out code 
Apr 21 2017
7f69eb83fa2a AMroczkowski
wiring up article count for top filter when it's also selected 
Apr 21 2017
4bb2f1285751 AMroczkowski
Navigation bar underlining fixes 
Apr 21 2017
400b547600c2 AMroczkowski
more cleanups 
Apr 21 2017
d3381b6dc195 AMroczkowski
Code cleanup and reorg 
Apr 21 2017
83fb86928d0d AMroczkowski
storyboard wanted to update itself 
Apr 21 2017
f4ab88a325deJoeWalsh
Merge branch 'develop' into feature/places-search-type-refactor 
Apr 21 2017
70784a0f58ec AMroczkowski
Disabling filter selector in search 
Apr 20 2017
2d3a7a32304f AMroczkowski
Updating font and spacing on empty search view 
Apr 20 2017
6947e12ca0ed AMroczkowski
Gray background for empty search overlay 
Apr 20 2017
2d442211e5be AMroczkowski
Not covering empty search view with keyboard on iPhone 
Apr 20 2017
a1b9226a682e AMroczkowski
grey close search button, better 
Apr 20 2017
ba09b2f15e4a AMroczkowski
grey close search button 
Apr 20 2017
b96bb8485c19 AMroczkowski
Pixel pushing 
Apr 20 2017
e260c3efd960 AMroczkowski
Merge remote-tracking branch 'origin/develop' into feature/places-search-type… 
Apr 20 2017
c5fb228e3920 AMroczkowski
better handling of repeated press of filter drop down button 
Apr 20 2017
7f7621a3160f AMroczkowski
adding a TODO 
Apr 20 2017
64fd0042f17e AMroczkowski
temp fix to handle performing and saving searches on Saved articles 
Apr 20 2017
ae292c94d79e AMroczkowski
accidently commited commented code 
Apr 20 2017
10b41624fffc AMroczkowski
fix autolayout issue on iPad 
Apr 20 2017
337ec57fce36 AMroczkowski
storyboard wanted to update itself 
Apr 20 2017
87b8612bb2f4Andrew Mroczkowski/GitHub
Merge branch 'develop' into feature/places-search-type-refactor 
Apr 20 2017
a3c458b78516 AMroczkowski
Merge remote-tracking branch 'origin/develop' into feature/places-search-type… 
Apr 20 2017
a9747e47719c AMroczkowski
Merge branch 'feature/places-search-type-refactor' of github.com… 
Apr 19 2017
36e39013ca96JoeWalsh/GitHub
Merge branch 'develop' into feature/places-search-type-refactor 
Apr 19 2017
e8e58c0d2d82 AMroczkowski
Showing empty search overlay 
Apr 19 2017
a6a8e3f1d1b6 AMroczkowski
Empty search overlay work 
Apr 19 2017
2d85d020beb0 AMroczkowski
Adding empty search overlay layout in storyboard 
Apr 19 2017
4d7e2970eee0 AMroczkowski
Avoid adding automatic searches when switching filters to history 
Apr 19 2017
77dbfb493fac AMroczkowski
search updates 
Apr 19 2017
a83971741fc0 AMroczkowski
Added top articles filter disabled icon, updating saved filter icon, other… 
Apr 19 2017
719887066e2b AMroczkowski
Clearing search field if closed and not actualy searching on that term 
Apr 19 2017
e525962680a6JoeWalsh/GitHub
Merge branch 'develop' into feature/places-search-type-refactor 
Apr 18 2017
107d6197139a AMroczkowski
hacking out top/saved default suggestion again 
Apr 18 2017
7705e03ec43d AMroczkowski
pixel pushing 
Apr 18 2017
c40b1aa62a19 AMroczkowski
moving close search button 
Apr 18 2017
2db354a08bcb AMroczkowski
adding missing localization description 
Apr 18 2017
eda9c5879f81 AMroczkowski
Catching case if key is missing in qqq.lproj 
Apr 18 2017
f76715074adf AMroczkowski
Cleanups 
Apr 18 2017
63437c8368fc AMroczkowski
Merge remote-tracking branch 'origin/develop' into feature/places-search-type… 
Apr 18 2017
f673db712020 AMroczkowski
Suggestion and saved article count udpates 
Apr 18 2017
db4ecfdd8b84 AMroczkowski
Filtering saved articles 
Apr 18 2017
8769c44820b3 AMroczkowski
Wiring up filter toggle 
Apr 18 2017
5cc74b467d53 AMroczkowski
SearchBar text and suggestion handling 
Apr 17 2017
2e803e75c7ec AMroczkowski
Adding search origin - user or system - to avoid saving default searches to… 
Apr 17 2017
fd954f6a023c AMroczkowski
fixing PlaceSearch deserializaion 
Apr 17 2017
1f98f01e6ec9JoeWalsh
use dataStore 
Apr 17 2017