HomePhabricator

Merge branch 'develop' into bug/T143024

Authored by montehurd <montehurd@users.noreply.github.com> on Feb 15 2017, 8:39 PM.

Description

Merge branch 'develop' into bug/T143024

Event Timeline

GitHub <noreply@github.com> committed rAPIOS2012ab7bb57b: Merge branch 'develop' into bug/T143024 (authored by montehurd <montehurd@users.noreply.github.com>).Feb 15 2017, 8:39 PM

Merged Changes

This commit merges a very large number of changes. Only the first 50 are shown.
CommitAuthorDetailsCommitted
b911f3f50b54Andrew Mroczkowski/GitHub
Merge pull request #1179 from wikimedia/refactorAuthManager 
Feb 15 2017
fbc71eb1895dMhurd
DRY up password resetter vc failure block. 
Feb 15 2017
dcf0f6447982Mhurd
Use property for auth manager sharedInstance. 
Feb 14 2017
7666b06232d3Mhurd
Guard *even more* captcha vc bits. 
Feb 14 2017
66422eaa7032Mhurd
Guard more bits in captcha vc. 
Feb 14 2017
16cc78c1dd97Mhurd
Guard more things in 2FA vc. 
Feb 14 2017
9c8b8cfe1a2cMhurd
Update nullability notation of AFHTTPSessionManager+WMFConfig.m 
Feb 14 2017
0caddceb05a2Mhurd
Guard more things in login vc. 
Feb 14 2017
9347bf08bb35Mhurd
Add guard to acct creation vc. 
Feb 14 2017
3db6a88e7227Mhurd
Add guard to change pwd vc. 
Feb 14 2017
028b8152acafMhurd
Add guard to 2FA vc. 
Feb 14 2017
6d20dd1c9a20Mhurd
Add guard to login vc. 
Feb 14 2017
9f12be7fc33dMhurd
Add guard statement to forgot pwd vc. 
Feb 14 2017
95b7909513c4Mhurd
Add guard statement to captcha vc. 
Feb 14 2017
2aff292758c6Mhurd
Remove "self" where not needed. 
Feb 14 2017
3701fed5fa77Mhurd
Fix bug preventing "password fields do not match" message from ever appearing… 
Feb 14 2017
88b6ef9f7770Mhurd
Rename method. 
Feb 14 2017
5e61e84589d2Mhurd
Don't blank out pwd change interface fields if error is no internet connection. 
Feb 14 2017
a584bd9467fdMhurd
Debounce acct creation, change pwd, forgot pwd and 2FA keyboard return buttons. 
Feb 14 2017
389acc28fd57Mhurd
Use email keyboard type on reset pwd email field. 
Feb 14 2017
36cfa170808aMhurd
Set "auto enable return key" on fields where appropriate. 
Feb 14 2017
b89b816adc18Mhurd
De-bounce login keyboard "Done" button by hiding keyboard when tapped. 
Feb 14 2017
dbf13a05ea1bMhurd
Move hide keyboard method to swift. 
Feb 14 2017
864e090a9d2fMhurd
Correct change pwd method signatures. 
Feb 14 2017
1264eb6c7833Mhurd
Correct 2FA method signatures. 
Feb 14 2017
017797e8e45dMhurd
Correct forgot pwd method signatures. 
Feb 14 2017
9d4392f7249bMhurd
Correct acct creation method signatures. 
Feb 14 2017
3bc90cf737c2Mhurd
Correct login method signatures. 
Feb 14 2017
a4c57ffcc81dMhurd
If pwds don't match when done tapped scroll up and give second pwd field focus. 
Feb 14 2017
6e744f688bafMhurd
Remove redundant "true" comparisons. 
Feb 14 2017
d6e597444947Mhurd
Fix bug preventing "password fields do not match" message from ever appearing. 
Feb 14 2017
ffda59df05d7Mhurd
Use @IBAction in acct creator vc. 
Feb 14 2017
26fe0f155a4dMhurd
DRY up some bits. 
Feb 14 2017
85beb7bce259Mhurd
Update WMFKeychainCredentials method signatures. 
Feb 14 2017
68efafdc611eMhurd
Type inference tweak. 
Feb 14 2017
d7a6d4075480Mhurd
Small tweaks to creation/captcha methods. 
Feb 14 2017
8fa463bc7433Mhurd
Wrap long comment. 
Feb 14 2017
4104b0958b8cMhurd
"fileprivate" tweaks. 
Feb 14 2017
e5691e891ffeMhurd
Small refactors to WMFKeychainCredentials. 
Feb 14 2017
980da5c427d5Mhurd
Fix bug switching user then restarting app still showed previous user. 
Feb 14 2017
021694db5eb8Mhurd
Hook up swift keychain credentials. 
Feb 14 2017
3c55492fcd62Mhurd
Swift-ify KeychainCredentials. 
Feb 14 2017
f98244ebe248Mhurd
Remove header reference. 
Feb 14 2017
55d8a21a7755Mhurd
Remove var. 
Feb 14 2017
8f1698f5d326Mhurd
MOAR TYPE INFERENCE!!! 
Feb 14 2017
abd55559c102Mhurd
Type inference cleanup. 
Feb 14 2017
592a41d37c50Mhurd
WMFAccountCreatorResult can be a struct now. 
Feb 14 2017
d8861ca84ba0Mhurd
WMFAuthAccountCreationInfo no longer need to inherit from NSObject. 
Feb 14 2017
8a21a2bc73a7Mhurd
WMFAuthLoginInfo bits no longer need to inherit from NSObject. 
Feb 14 2017
71e1f2ac74b5Mhurd
Switch WMFCurrentlyLoggedInUserFetcherError back to a LocalizedError. 
Feb 14 2017