Diffusion The official Wikipedia iOS application 5f2d5302310c

T158142
5f2d5302310c
Actions

Description

Merge branch 'develop' into feature/auth-styling/T158142

Details

Provenance

montehurd <montehurd@users.noreply.github.com>	Authored on Mar 1 2017, 3:13 AM
GitHub <noreply@github.com>	Committed on Mar 1 2017, 3:13 AM

Parents

rAPIOS1054a7d6e818: Simplify login captcha visibility logic.
rAPIOS10ee37c77358: Merge pull request #1215 from wikimedia/feature/print-container-directory-on…

Branches

Unknown

Tags

Unknown

ChangeId

None

Event Timeline

GitHub <noreply@github.com> committed rAPIOS5f2d5302310c: Merge branch 'develop' into feature/auth-styling/T158142 (authored by montehurd <montehurd@users.noreply.github.com>).Mar 1 2017, 3:13 AM

Diffusion mentioned this in rAPIOS7841cc202584: Merge 5f2d5302310ccac96f75d59d5b6da8f3fb53b1c2 into….

Merged Changes

10ee37c77358 Merge pull request #1215 from wikimedia/feature/print-container-directory-on…
Author
JoeWalsh
Browse Repository
No Builds
No Audits
f5e0442f8400 Merge branch 'develop' into feature/print-container-directory-on-start
Author
JoeWalsh
Browse Repository
No Builds
No Audits
9fd77d7464ed Removing extra /
Author
Andrew Mroczkowski <andy.mroczkowski@gmail.com>
Browse Repository
No Builds
No Audits
1a1c9dc19f03 Print container directory along with Documents dir
Author
Andrew Mroczkowski <andy.mroczkowski@gmail.com>
Browse Repository
No Builds
No Audits
6c589e95347f Merge pull request #1211 from wikimedia/bug/compiler_warnings
Author
Andrew Mroczkowski <amrox@users.noreply.github.com>
Browse Repository
No Builds
No Audits
e2bbe20e0667 Merge branch 'develop' into bug/compiler_warnings
Author
Andrew Mroczkowski <amrox@users.noreply.github.com>
Browse Repository
No Builds
No Audits
65d2e8489844 Merge pull request #1212 from wikimedia/bug/T159220
Author
Andrew Mroczkowski <amrox@users.noreply.github.com>
Browse Repository
No Builds
No Audits
459f23d38e5e Merge branch 'develop' into bug/T159220
Author
Andrew Mroczkowski <amrox@users.noreply.github.com>
Browse Repository
No Builds
No Audits
2b4618661b71 Merge branch 'develop' into bug/compiler_warnings
Author
Andrew Mroczkowski <amrox@users.noreply.github.com>
Browse Repository
No Builds
No Audits
8290b97484ab Merge pull request #1213 from wikimedia/feature/T149900
Author
Andrew Mroczkowski <amrox@users.noreply.github.com>
Browse Repository
No Builds
No Audits
8b184faef906 Merge branch 'develop' into bug/compiler_warnings
Author
Andrew Mroczkowski <amrox@users.noreply.github.com>
Browse Repository
No Builds
No Audits
776417ea63b1 Merge branch 'develop' into bug/T159220
Author
Andrew Mroczkowski <amrox@users.noreply.github.com>
Browse Repository
No Builds
No Audits
b773a8350085 Merge branch 'develop' into feature/T149900
Author
JoeWalsh
Browse Repository
No Builds
No Audits
e1f384cc6c4e Merge pull request #1214 from wikimedia/bug/verify_pr_junit
Author
JoeWalsh
Browse Repository
No Builds
No Audits
b15b79789a8d fix test response JSON to match new MCS changes - featured article is first link
Author
JoeWalsh
Browse Repository
No Builds
No Audits
e8089b861aa5 always output junit, use custom file name
Author
JoeWalsh
Browse Repository
No Builds
No Audits
667f443528a8 junit: true
Author
JoeWalsh
Browse Repository
No Builds
No Audits
74e8549ba6e1 Merge branch 'develop' into feature/T149900
Author
JoeWalsh
Browse Repository
No Builds
No Audits
4ca87500b1e5 speed up visible cell distance & heading updates
Author
JoeWalsh
Browse Repository
No Builds
No Audits
61fc072aba17 fix distance calculation
Author
JoeWalsh
Browse Repository
No Builds
No Audits
44ecc56a8507 remove unnecessary warning overrides
Author
JoeWalsh
Browse Repository
No Builds
No Audits
52f4f43cfc51 Merge pull request #1194 from wikimedia/bug/T158449
Author
JoeWalsh
Browse Repository
No Builds
No Audits
7415e0c29eb5 Merge branch 'develop' into bug/T158449
Author
JoeWalsh
Browse Repository
No Builds
No Audits
c75c401581c1 fix missing return
Author
JoeWalsh
Browse Repository
No Builds
No Audits
ed4138038c01 Merge branch 'develop' into bug/T158449
Author
Andrew Mroczkowski <amrox@users.noreply.github.com>
Browse Repository
No Builds
No Audits
8859518c1e77 updating iPhone to 10.2 sim
Author
Andrew Mroczkowski <amrox@users.noreply.github.com>
Browse Repository
No Builds
No Audits
fed43199a0ed Merge branch 'develop' into bug/T158449
Author
JoeWalsh
Browse Repository
No Builds
No Audits
4a3a21299a35 Merge branch 'develop' into bug/T158449
Author
Andrew Mroczkowski <amrox@users.noreply.github.com>
Browse Repository
No Builds
No Audits
23c4678839f2 featured article preview is now just the first preview in the list
Author
JoeWalsh
Browse Repository
No Builds
No Audits
8931c3fc3baf Merge branch 'develop' into bug/T158449
Author
JoeWalsh
Browse Repository
No Builds
No Audits
767a820bf469 Merge branch 'develop' into bug/T158449
Author
Andrew Mroczkowski <amrox@users.noreply.github.com>
Browse Repository
No Builds
No Audits
4fc99bdfea68 Merge branch 'develop' into bug/T158449
Author
JoeWalsh
Browse Repository
No Builds
No Audits
c5ab3bf3fbed Merge branch 'develop' into bug/T158449
Author
JoeWalsh
Browse Repository
No Builds
No Audits
99cece4cda1e Merge branch 'develop' into bug/T158449
Author
Andrew Mroczkowski <amrox@users.noreply.github.com>
Browse Repository
No Builds
No Audits
fca38cc6aecb Adding `verify_pull_request` lane and updating needed test images
Author
Andrew Mroczkowski <andy.mroczkowski@gmail.com>
Browse Repository
No Builds
No Audits
0ade9af6ed6f Merge branch 'develop' into bug/T158449
Author
Andrew Mroczkowski <amrox@users.noreply.github.com>
Browse Repository
No Builds
No Audits
f5092c94834c Adding Reference images for iPad Air 2, iOS 9.3, 10.2
Author
Andrew Mroczkowski <andy.mroczkowski@gmail.com>
Browse Repository
No Builds
No Audits

Changes (72)

Path

Size

WMF Framework/

WMFCaptchaViewController.swift

Wikipedia.xcodeproj/

project.pbxproj

Wikipedia/

Code/

AppDelegate.m

PlacesViewController.swift

WMFFeedContentSource.m

WikipediaUnitTests/

Fixtures/

MCSFeedTopReadNewsItem.json

ReferenceImages_64/

NSAttributedString_WMFModifyTests/

	test0ReferenceOutput_iPad10_2_768x1024@2x.png
	test0ReferenceOutput_iPhone10_1_375x667@2x.png

	test0ReferenceOutput_iPad9_3_768x1024@2x.png
	test0ReferenceOutput_iPhone9_3_375x667@2x.png

	testChangeGreenBackgroundColorsToBlue_iPad10_2_768x1024@2x.png
	testChangeGreenBackgroundColorsToBlue_iPhone10_1_375x667@2x.png

	testChangeGreenBackgroundColorsToBlue_iPad9_3_768x1024@2x.png
	testChangeGreenBackgroundColorsToBlue_iPhone9_3_375x667@2x.png

	testChangeReduceLineSpacing_iPad10_2_768x1024@2x.png
	testChangeReduceLineSpacing_iPhone10_1_375x667@2x.png

	testChangeReduceLineSpacing_iPad9_3_768x1024@2x.png
	testChangeReduceLineSpacing_iPhone9_3_375x667@2x.png

	testRemoveAllStrikeThroughs_iPad10_2_768x1024@2x.png
	testRemoveAllStrikeThroughs_iPhone10_1_375x667@2x.png

	testRemoveAllStrikeThroughs_iPad9_3_768x1024@2x.png
	testRemoveAllStrikeThroughs_iPhone9_3_375x667@2x.png

	testRemovingLink_iPad10_2_768x1024@2x.png
	testRemovingLink_iPhone10_1_375x667@2x.png

	testRemovingLink_iPad9_3_768x1024@2x.png
	testRemovingLink_iPhone9_3_375x667@2x.png

NSAttributedString_WMFTrimTests/

	testTrimReference_iPad10_2_768x1024@2x.png
	testTrimReference_iPhone10_1_375x667@2x.png

	testTrimReference_iPad9_3_768x1024@2x.png
	testTrimReference_iPhone9_3_375x667@2x.png

	testTrim_iPad10_2_768x1024@2x.png
	testTrim_iPhone10_1_375x667@2x.png

	testTrim_iPad9_3_768x1024@2x.png
	testTrim_iPhone9_3_375x667@2x.png

UIImageViewWMFImageFetchingVisualTests/

testCentersBothActorsFacesVertically_iPad10_2_768x1024@2x.png

testCentersBothActorsFacesVertically_iPad9_3_768x1024@2x.png

	testCentersPresObamasFaceVertically_iPad10_2_768x1024@2x.png
	testCentersPresObamasFaceVertically_iPhone10_1_375x667@2x.png

	testCentersPresObamasFaceVertically_iPad9_3_768x1024@2x.png
	testCentersPresObamasFaceVertically_iPhone10_1_375x667@2x.png

	testImageNotCroppedBecauseFacesAreTooSmall_iPad10_2_768x1024@2x.png
	testImageNotCroppedBecauseFacesAreTooSmall_iPhone10_2_375x667@2x.png

	testImageNotCroppedBecauseFacesAreTooSmall_iPad9_3_768x1024@2x.png
	testImageNotCroppedBecauseFacesAreTooSmall_iPhone9_3_375x667@2x.png

	testUsesSpecifiedContentModeBehaviorOnFeaturelessImage_iPad10_2_768x1024@2x.png
	testUsesSpecifiedContentModeBehaviorOnFeaturelessImage_iPhone10_2_375x667@2x.png

	testUsesSpecifiedContentModeBehaviorOnFeaturelessImage_iPad9_3_768x1024@2x.png
	testUsesSpecifiedContentModeBehaviorOnFeaturelessImage_iPhone10_2_375x667@2x.png

WMFArticleListCellVisualTests/

	testShouldCenterShortTitleWhenDescriptionIsEmpty_iPad10_2_768x1024@2x.png
	testShouldCenterShortTitleWhenDescriptionIsEmpty_iPhone10_2_375x667@2x.png

	testShouldCenterShortTitleWhenDescriptionIsEmpty_iPad9_3_768x1024@2x.png
	testShouldCenterShortTitleWhenDescriptionIsEmpty_iPhone9_3_375x667@2x.png

	testShouldHighlightMatchingSubstring_iPad10_2_768x1024@2x.png
	testShouldHighlightMatchingSubstring_iPhone10_2_375x667@2x.png

	testShouldHighlightMatchingSubstring_iPad9_3_768x1024@2x.png
	testShouldHighlightMatchingSubstring_iPhone9_3_375x667@2x.png

	testShouldNotShowLongDescriptionWhenTitleExceedsTwoLines_iPad10_2_768x1024@2x.png
	testShouldNotShowLongDescriptionWhenTitleExceedsTwoLines_iPhone10_2_375x667@2x.png

	testShouldNotShowLongDescriptionWhenTitleExceedsTwoLines_iPad9_3_768x1024@2x.png
	testShouldNotShowLongDescriptionWhenTitleExceedsTwoLines_iPhone9_3_375x667@2x.png

	testShouldShowLongDescriptionWhenTitleIsShort_iPad10_2_768x1024@2x.png
	testShouldShowLongDescriptionWhenTitleIsShort_iPhone10_2_375x667@2x.png

	testShouldShowLongDescriptionWhenTitleIsShort_iPad9_3_768x1024@2x.png
	testShouldShowLongDescriptionWhenTitleIsShort_iPhone9_3_375x667@2x.png

	testShouldShowTitleAtTheTopAndDescriptionAtTheBottom_iPad10_2_768x1024@2x.png
	testShouldShowTitleAtTheTopAndDescriptionAtTheBottom_iPhone10_2_375x667@2x.png

	testShouldShowTitleAtTheTopAndDescriptionAtTheBottom_iPad9_3_768x1024@2x.png
	testShouldShowTitleAtTheTopAndDescriptionAtTheBottom_iPhone9_3_375x667@2x.png

	testShouldTruncateAndShrinkTitle_iPad10_2_768x1024@2x.png
	testShouldTruncateAndShrinkTitle_iPhone10_2_375x667@2x.png

	testShouldTruncateAndShrinkTitle_iPad9_3_768x1024@2x.png
	testShouldTruncateAndShrinkTitle_iPhone9_3_375x667@2x.png

WMFArticlePreviewCellVisualTests/

testLayoutWithLongExtractAndImage_10_2_LTR_iPad10_2_768x1024@2x.png

testLayoutWithLongExtractAndImage_9_3_LTR_iPad9_3_768x1024@2x.png

testLayoutWithLongExtractWithoutImage_10_2_LTR_iPad10_2_768x1024@2x.png

testLayoutWithLongExtractWithoutImage_9_3_LTR_iPad9_3_768x1024@2x.png

testLayoutWithShortExtractAndImage_10_2_LTR_iPad10_2_768x1024@2x.png

testLayoutWithShortExtractAndImage_9_3_LTR_iPad9_3_768x1024@2x.png

testLayoutWithShortExtractWithoutImage_10_2_LTR_iPad10_2_768x1024@2x.png

testLayoutWithShortExtractWithoutImage_9_3_LTR_iPad9_3_768x1024@2x.png

WMFArticlePreviewViewControllerVisualTests/

testWithImageAndNoSubtitle_iPad10_2_768x1024@2x.png

testWithImageAndNoSubtitle_iPad9_3_768x1024@2x.png

testWithImage_iPad10_2_768x1024@2x.png

testWithImage_iPad9_3_768x1024@2x.png

testWithoutImageAndNoSubtitle_iPad10_2_768x1024@2x.png

testWithoutImageAndNoSubtitle_iPad9_3_768x1024@2x.png

testWithoutImage_iPad10_2_768x1024@2x.png

testWithoutImage_iPad9_3_768x1024@2x.png

WMFPicOfTheDayTableViewCellVisualTests/

	testInitialStateOnlyShowsPlaceholderWithoutCaption_iPad10_2_768x1024@2x.png
	testInitialStateOnlyShowsPlaceholderWithoutCaption_iPhone10_1_375x667@2x.png

	testInitialStateOnlyShowsPlaceholderWithoutCaption_iPad9_3_768x1024@2x.png
	testInitialStateOnlyShowsPlaceholderWithoutCaption_iPhone10_1_375x667@2x.png

	testShowsCaptionWhenImageIsFinallyDownloaded_iPad10_2_768x1024@2x.png
	testShowsCaptionWhenImageIsFinallyDownloaded_iPhone10_1_375x667@2x.png

	testShowsCaptionWhenImageIsFinallyDownloaded_iPad9_3_768x1024@2x.png
	testShowsCaptionWhenImageIsFinallyDownloaded_iPhone9_3_375x667@2x.png

	testStillShowsPlaceholderWithoutCaptionWhileImageIsDownloading_iPad10_2_768x1024@2x.png
	testInitialStateOnlyShowsPlaceholderWithoutCaption_iPhone10_1_375x667@2x.png

	testStillShowsPlaceholderWithoutCaptionWhileImageIsDownloading_iPad9_3_768x1024@2x.png
	testInitialStateOnlyShowsPlaceholderWithoutCaption_iPhone10_1_375x667@2x.png

WMFSettingsCellVisualTests/

	testLongTitle_10_2_LTR_iPad10_2_768x1024@2x.png
	testLongTitle_10_1_LTR_iPhone10_1_375x667@2x.png

	testLongTitle_9_3_LTR_iPad9_3_768x1024@2x.png
	testLongTitle_9_3_LTR_iPhone9_3_375x667@2x.png

	testShortTitle_10_2_LTR_iPad10_2_768x1024@2x.png
	testShortTitle_10_1_LTR_iPhone10_1_375x667@2x.png

	testShortTitle_9_3_LTR_iPad9_3_768x1024@2x.png
	testShortTitle_9_3_LTR_iPhone9_3_375x667@2x.png

fastlane/

Fastfile

README.md

rAPIOS5f2d5302310c

View Options

WMF Framework/WMFCaptchaViewController.swift

View Options

Wikipedia.xcodeproj/project.pbxproj

View Options

Wikipedia/Code/AppDelegate.m

View Options

Wikipedia/Code/PlacesViewController.swift

View Options

Wikipedia/Code/WMFFeedContentSource.m

View Options

Wikipedia/Code/WMFFeedNewsStory.h

View Options

Wikipedia/Code/WMFFeedNewsStory.m

View Options

Wikipedia/Code/WMFLocationManager.h

View Options

Wikipedia/Code/WMFLocationManager.m

View Options

WikipediaUnitTests/Fixtures/MCSFeedTopReadNewsItem.json

View Options

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/test0ReferenceOutput_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/test0ReferenceOutput_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/testChangeGreenBackgroundColorsToBlue_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/testChangeGreenBackgroundColorsToBlue_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/testChangeReduceLineSpacing_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/testChangeReduceLineSpacing_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/testRemoveAllStrikeThroughs_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/testRemoveAllStrikeThroughs_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/testRemovingLink_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/testRemovingLink_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFTrimTests/testTrimReference_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFTrimTests/testTrimReference_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFTrimTests/testTrim_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFTrimTests/testTrim_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/UIImageViewWMFImageFetchingVisualTests/testCentersBothActorsFacesVertically_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/UIImageViewWMFImageFetchingVisualTests/testCentersBothActorsFacesVertically_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/UIImageViewWMFImageFetchingVisualTests/testCentersPresObamasFaceVertically_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/UIImageViewWMFImageFetchingVisualTests/testCentersPresObamasFaceVertically_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/UIImageViewWMFImageFetchingVisualTests/testImageNotCroppedBecauseFacesAreTooSmall_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/UIImageViewWMFImageFetchingVisualTests/testImageNotCroppedBecauseFacesAreTooSmall_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/UIImageViewWMFImageFetchingVisualTests/testUsesSpecifiedContentModeBehaviorOnFeaturelessImage_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/UIImageViewWMFImageFetchingVisualTests/testUsesSpecifiedContentModeBehaviorOnFeaturelessImage_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldCenterShortTitleWhenDescriptionIsEmpty_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldCenterShortTitleWhenDescriptionIsEmpty_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldHighlightMatchingSubstring_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldHighlightMatchingSubstring_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldNotShowLongDescriptionWhenTitleExceedsTwoLines_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldNotShowLongDescriptionWhenTitleExceedsTwoLines_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldShowLongDescriptionWhenTitleIsShort_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldShowLongDescriptionWhenTitleIsShort_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldShowTitleAtTheTopAndDescriptionAtTheBottom_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldShowTitleAtTheTopAndDescriptionAtTheBottom_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldTruncateAndShrinkTitle_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldTruncateAndShrinkTitle_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewCellVisualTests/testLayoutWithLongExtractAndImage_10_2_LTR_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewCellVisualTests/testLayoutWithLongExtractAndImage_9_3_LTR_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewCellVisualTests/testLayoutWithLongExtractWithoutImage_10_2_LTR_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewCellVisualTests/testLayoutWithLongExtractWithoutImage_9_3_LTR_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewCellVisualTests/testLayoutWithShortExtractAndImage_10_2_LTR_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewCellVisualTests/testLayoutWithShortExtractAndImage_9_3_LTR_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewCellVisualTests/testLayoutWithShortExtractWithoutImage_10_2_LTR_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewCellVisualTests/testLayoutWithShortExtractWithoutImage_9_3_LTR_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewViewControllerVisualTests/testWithImageAndNoSubtitle_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewViewControllerVisualTests/testWithImageAndNoSubtitle_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewViewControllerVisualTests/testWithImage_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewViewControllerVisualTests/testWithImage_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewViewControllerVisualTests/testWithoutImageAndNoSubtitle_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewViewControllerVisualTests/testWithoutImageAndNoSubtitle_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewViewControllerVisualTests/testWithoutImage_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewViewControllerVisualTests/testWithoutImage_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFPicOfTheDayTableViewCellVisualTests/testInitialStateOnlyShowsPlaceholderWithoutCaption_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFPicOfTheDayTableViewCellVisualTests/testInitialStateOnlyShowsPlaceholderWithoutCaption_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFPicOfTheDayTableViewCellVisualTests/testShowsCaptionWhenImageIsFinallyDownloaded_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFPicOfTheDayTableViewCellVisualTests/testShowsCaptionWhenImageIsFinallyDownloaded_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFPicOfTheDayTableViewCellVisualTests/testStillShowsPlaceholderWithoutCaptionWhileImageIsDownloading_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFPicOfTheDayTableViewCellVisualTests/testStillShowsPlaceholderWithoutCaptionWhileImageIsDownloading_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFSettingsCellVisualTests/testLongTitle_10_2_LTR_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFSettingsCellVisualTests/testLongTitle_9_3_LTR_iPad9_3_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFSettingsCellVisualTests/testShortTitle_10_2_LTR_iPad10_2_768x1024@2x.png

View Options

WikipediaUnitTests/ReferenceImages_64/WMFSettingsCellVisualTests/testShortTitle_9_3_LTR_iPad9_3_768x1024@2x.png

View Options

fastlane/Fastfile

View Options

Merge branch 'develop' into feature/auth-styling/T1581425f2d5302310cActions

Description

Details

Event Timeline

Merged Changes

Changes (72)

rAPIOS5f2d5302310c

WMF Framework/WMFCaptchaViewController.swift

Wikipedia.xcodeproj/project.pbxproj

Wikipedia/Code/AppDelegate.m

Wikipedia/Code/PlacesViewController.swift

Wikipedia/Code/WMFFeedContentSource.m

Wikipedia/Code/WMFFeedNewsStory.h

Wikipedia/Code/WMFFeedNewsStory.m

Wikipedia/Code/WMFLocationManager.h

Wikipedia/Code/WMFLocationManager.m

WikipediaUnitTests/Fixtures/MCSFeedTopReadNewsItem.json

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/test0ReferenceOutput_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/test0ReferenceOutput_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/testChangeGreenBackgroundColorsToBlue_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/testChangeGreenBackgroundColorsToBlue_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/testChangeReduceLineSpacing_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/testChangeReduceLineSpacing_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/testRemoveAllStrikeThroughs_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/testRemoveAllStrikeThroughs_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/testRemovingLink_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests/testRemovingLink_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFTrimTests/testTrimReference_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFTrimTests/testTrimReference_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFTrimTests/testTrim_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFTrimTests/testTrim_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/UIImageViewWMFImageFetchingVisualTests/testCentersBothActorsFacesVertically_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/UIImageViewWMFImageFetchingVisualTests/testCentersBothActorsFacesVertically_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/UIImageViewWMFImageFetchingVisualTests/testCentersPresObamasFaceVertically_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/UIImageViewWMFImageFetchingVisualTests/testCentersPresObamasFaceVertically_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/UIImageViewWMFImageFetchingVisualTests/testImageNotCroppedBecauseFacesAreTooSmall_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/UIImageViewWMFImageFetchingVisualTests/testImageNotCroppedBecauseFacesAreTooSmall_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/UIImageViewWMFImageFetchingVisualTests/testUsesSpecifiedContentModeBehaviorOnFeaturelessImage_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/UIImageViewWMFImageFetchingVisualTests/testUsesSpecifiedContentModeBehaviorOnFeaturelessImage_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldCenterShortTitleWhenDescriptionIsEmpty_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldCenterShortTitleWhenDescriptionIsEmpty_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldHighlightMatchingSubstring_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldHighlightMatchingSubstring_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldNotShowLongDescriptionWhenTitleExceedsTwoLines_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldNotShowLongDescriptionWhenTitleExceedsTwoLines_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldShowLongDescriptionWhenTitleIsShort_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldShowLongDescriptionWhenTitleIsShort_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldShowTitleAtTheTopAndDescriptionAtTheBottom_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldShowTitleAtTheTopAndDescriptionAtTheBottom_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldTruncateAndShrinkTitle_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticleListCellVisualTests/testShouldTruncateAndShrinkTitle_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewCellVisualTests/testLayoutWithLongExtractAndImage_10_2_LTR_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewCellVisualTests/testLayoutWithLongExtractAndImage_9_3_LTR_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewCellVisualTests/testLayoutWithLongExtractWithoutImage_10_2_LTR_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewCellVisualTests/testLayoutWithLongExtractWithoutImage_9_3_LTR_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewCellVisualTests/testLayoutWithShortExtractAndImage_10_2_LTR_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewCellVisualTests/testLayoutWithShortExtractAndImage_9_3_LTR_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewCellVisualTests/testLayoutWithShortExtractWithoutImage_10_2_LTR_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewCellVisualTests/testLayoutWithShortExtractWithoutImage_9_3_LTR_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewViewControllerVisualTests/testWithImageAndNoSubtitle_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewViewControllerVisualTests/testWithImageAndNoSubtitle_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewViewControllerVisualTests/testWithImage_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewViewControllerVisualTests/testWithImage_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewViewControllerVisualTests/testWithoutImageAndNoSubtitle_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewViewControllerVisualTests/testWithoutImageAndNoSubtitle_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewViewControllerVisualTests/testWithoutImage_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFArticlePreviewViewControllerVisualTests/testWithoutImage_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFPicOfTheDayTableViewCellVisualTests/testInitialStateOnlyShowsPlaceholderWithoutCaption_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFPicOfTheDayTableViewCellVisualTests/testInitialStateOnlyShowsPlaceholderWithoutCaption_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFPicOfTheDayTableViewCellVisualTests/testShowsCaptionWhenImageIsFinallyDownloaded_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFPicOfTheDayTableViewCellVisualTests/testShowsCaptionWhenImageIsFinallyDownloaded_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFPicOfTheDayTableViewCellVisualTests/testStillShowsPlaceholderWithoutCaptionWhileImageIsDownloading_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFPicOfTheDayTableViewCellVisualTests/testStillShowsPlaceholderWithoutCaptionWhileImageIsDownloading_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFSettingsCellVisualTests/testLongTitle_10_2_LTR_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFSettingsCellVisualTests/testLongTitle_9_3_LTR_iPad9_3_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFSettingsCellVisualTests/testShortTitle_10_2_LTR_iPad10_2_768x1024@2x.png

WikipediaUnitTests/ReferenceImages_64/WMFSettingsCellVisualTests/testShortTitle_9_3_LTR_iPad9_3_768x1024@2x.png

fastlane/Fastfile

fastlane/README.md

Merge branch 'develop' into feature/auth-styling/T158142
5f2d5302310c
Actions