Diffusion The official Wikipedia iOS application b9453ef4dd5d

T133933
b9453ef4dd5d
Actions

Description

Merge pull request #706 from wikimedia/spike/nsurlcomponentscategories/T133933

T133933: Replace MWKSite and MWKTitle with NSURLComponents and app specific categories

Details

Provenance

• Fjalapeno	Authored on Jun 15 2016, 7:53 PM
GitHub <noreply@github.com>	Committed on Jun 15 2016, 7:53 PM

Parents

rAPIOS16e29149946b: merge
rAPIOS118f6f2df8a3: Merge pull request #717 from wikimedia/Contribution-readme-updates

Branches

Unknown

Tags

Unknown

ChangeId

None

Event Timeline

GitHub <noreply@github.com> committed rAPIOSb9453ef4dd5d: Merge pull request #706 from wikimedia/spike/nsurlcomponentscategories/T133933 (authored by • Fjalapeno).Jun 15 2016, 7:53 PM

Merged Changes

This commit merges a very large number of changes. Only the first 50 are shown.

16e29149946b merge
Author
JoeWalsh
Browse Repository
No Builds
No Audits
0a07318f97d0 add handling for unescaped/normalized titles
Author
JoeWalsh
Browse Repository
No Builds
No Audits
50bf743d0d49 add assertion for invalid percent escapes
Author
JoeWalsh
Browse Repository
No Builds
No Audits
d274e40f5962 paths no longer need to be unescaped
Author
JoeWalsh
Browse Repository
No Builds
No Audits
6a146ebc2c64 use the built in escaping on NSURLComponents rather than manually escaping
Author
JoeWalsh
Browse Repository
No Builds
No Audits
2ac8be51c305 fix tests
Author
JoeWalsh
Browse Repository
No Builds
No Audits
344cb0d91430 rename methods that take escaped denormalized titles to enhance clarity
Author
JoeWalsh
Browse Repository
No Builds
No Audits
ee08cb2bdf9f Merge branch 'develop' into spike/nsurlcomponentscategories/T133933
Author
JoeWalsh
Browse Repository
No Builds
No Audits
d870bc48b3ab fix typo
Author
JoeWalsh
Browse Repository
No Builds
No Audits
5a851bbe64f8 Merge branch 'develop' into spike/nsurlcomponentscategories/T133933
Author
montehurd <montehurd@users.noreply.github.com>
Browse Repository
No Builds
No Audits
18d1ac8e3f42 Merge branch 'develop' into spike/nsurlcomponentscategories/T133933
Author
montehurd <montehurd@users.noreply.github.com>
Browse Repository
No Builds
No Audits
48ddc3cb3839 remove deprecated stringByAddingPercentEscapesUsingEncoding: and replace with…
Author
JoeWalsh
Browse Repository
No Builds
No Audits
b72b2b898735 remove nil site language assertion
Author
JoeWalsh
Browse Repository
No Builds
No Audits
fa3b7f8d9042 add tests for language-less links
Author
JoeWalsh
Browse Repository
No Builds
No Audits
a72c0ba2bf88 fix WMF parsing for edge case URLs (mediawiki help & support page…
Author
JoeWalsh
Browse Repository
No Builds
No Audits
eefd3ff87c79 verify language is longer than one character
Author
JoeWalsh
Browse Repository
No Builds
No Audits
62ca0c58f4b3 fix nullability annotators
Author
JoeWalsh
Browse Repository
No Builds
No Audits
95fec93349db uncrustify and update MWKTitle decoder to use site URL
Author
JoeWalsh
Browse Repository
No Builds
No Audits
550bd2348e0d fix mantle decoding for older MWKSite and MWKTitle objects
Author
JoeWalsh
Browse Repository
No Builds
No Audits
ba187c90c476 add link parsing to the bridging header
Author
JoeWalsh
Browse Repository
No Builds
No Audits
9536d7d7f557 make title, mobileURL, desktopURL non nullable with reasonable defaults
Author
JoeWalsh
Browse Repository
No Builds
No Audits
5d1eb0bca59f remove unused escapedURLText
Author
JoeWalsh
Browse Repository
No Builds
No Audits
b05102e9ca86 remove unused escaped fragment property
Author
JoeWalsh
Browse Repository
No Builds
No Audits
e07826c09f5d move text alignment and layout direction into the NSURL category
Author
JoeWalsh
Browse Repository
No Builds
No Audits
d3cc9d11c412 update MWKTitle to use new NSURL methods
Author
JoeWalsh
Browse Repository
No Builds
No Audits
c202b31ada17 more tests
Author
JoeWalsh
Browse Repository
No Builds
No Audits
87023eca9618 add internal/non internal links tests
Author
JoeWalsh
Browse Repository
No Builds
No Audits
fb4935d168e6 add constructors based on site url and path, internalLink
Author
JoeWalsh
Browse Repository
No Builds
No Audits
1cc2c7a7aa84 add method for constructing URL from siteURL to match MWKTitle interface
Author
JoeWalsh
Browse Repository
No Builds
No Audits
fa56e452e5e4 doc cleanup
Author
JoeWalsh
Browse Repository
No Builds
No Audits
fd0ff127d8bb cleanup param spacing on docs
Author
JoeWalsh
Browse Repository
No Builds
No Audits
2ac6fd74ab0f docs
Author
JoeWalsh
Browse Repository
No Builds
No Audits
67aabadf9984 more doc
Author
JoeWalsh
Browse Repository
No Builds
No Audits
65a54401582c clarification for fragment
Author
JoeWalsh
Browse Repository
No Builds
No Audits
0f754ea997a2 doc
Author
JoeWalsh
Browse Repository
No Builds
No Audits
bcbd4b851eb6 remove length check on language - "commons" is set as a valid language (see…
Author
JoeWalsh
Browse Repository
No Builds
No Audits
7060e8cd426a organize NSURL+WMFLinkParsing, add method for constructing mobile/non mobile…
Author
JoeWalsh
Browse Repository
No Builds
No Audits
abb9b0f98f27 convert MWKTitle to use a URL for storage and the new categories
Author
JoeWalsh
Browse Repository
No Builds
No Audits
796995453241 add convenience method for constructing wmf_URL with domain, title and fragment
Author
JoeWalsh
Browse Repository
No Builds
No Audits
1540adc59981 add wmf_desktopURL to WMFLinkParsing
Author
JoeWalsh
Browse Repository
No Builds
No Audits
34477ecceb9d add wmf_title and wmf_fragment properties to NSURLComponents categories, add…
Author
JoeWalsh
Browse Repository
No Builds
No Audits
ccd11e622238 organize MWKSite.h
Author
JoeWalsh
Browse Repository
No Builds
No Audits
d3dd839734b1 read old domain and language
Author
JoeWalsh
Browse Repository
No Builds
No Audits
dc59b43fabf4 ensure language is 2-3 characters
Author
JoeWalsh
Browse Repository
No Builds
No Audits
72a9803bd0b3 make language nullable
Author
JoeWalsh
Browse Repository
No Builds
No Audits
faf8a17fe7e0 add isMobile flag for site URL construction
Author
JoeWalsh
Browse Repository
No Builds
No Audits
9c187cd4ee13 add title and fragment methods to NSURLComponents
Author
JoeWalsh
Browse Repository
No Builds
No Audits
f853457bf1ec add wmf_isNonStandardURL
Author
JoeWalsh
Browse Repository
No Builds
No Audits
fb0b986b9159 switch to @property notation
Author
JoeWalsh
Browse Repository
No Builds
No Audits
9b69a35359d7 URL property should be readonly
Author
JoeWalsh
Browse Repository
No Builds
No Audits

Changes (15)

Path

Size

Wikipedia.xcodeproj/

project.pbxproj

Wikipedia/

Code/

MWKImageInfoFetcher.m

NSURL+WMFLinkParsing.h

NSURL+WMFLinkParsing.m

NSURLComponents+WMFLinkParsing.h

NSURLComponents+WMFLinkParsing.m

WMFSearchDataSource.m

Wikipedia-Bridging-Header.h

WikipediaUnitTests/

Code/

MWKTitleTests.m

WMFLinkParsingTests.m

rAPIOSb9453ef4dd5d

View Options

Wikipedia.xcodeproj/project.pbxproj

View Options

Wikipedia/Code/MWKImageInfoFetcher.m

View Options

Wikipedia/Code/MWKSite.h

View Options

Wikipedia/Code/MWKSite.m

View Options

Wikipedia/Code/MWKSiteDataObject.m

View Options

Wikipedia/Code/MWKTitle.h

View Options

Wikipedia/Code/MWKTitle.m

View Options

Wikipedia/Code/NSURL+WMFLinkParsing.h

View Options

Wikipedia/Code/NSURL+WMFLinkParsing.m

View Options

Wikipedia/Code/NSURLComponents+WMFLinkParsing.h

View Options

Wikipedia/Code/NSURLComponents+WMFLinkParsing.m

View Options

Wikipedia/Code/WMFSearchDataSource.m

View Options

Wikipedia/Code/Wikipedia-Bridging-Header.h

View Options

WikipediaUnitTests/Code/MWKTitleTests.m

View Options

WikipediaUnitTests/Code/WMFLinkParsingTests.m

Merge pull request #706 from wikimedia/spike/nsurlcomponentscategories/T133933b9453ef4dd5dActions

Description

Details

Event Timeline

Merged Changes

Changes (15)

rAPIOSb9453ef4dd5d

Wikipedia.xcodeproj/project.pbxproj

Wikipedia/Code/MWKImageInfoFetcher.m

Wikipedia/Code/MWKSite.h

Wikipedia/Code/MWKSite.m

Wikipedia/Code/MWKSiteDataObject.m

Wikipedia/Code/MWKTitle.h

Wikipedia/Code/MWKTitle.m

Wikipedia/Code/NSURL+WMFLinkParsing.h

Wikipedia/Code/NSURL+WMFLinkParsing.m

Wikipedia/Code/NSURLComponents+WMFLinkParsing.h

Wikipedia/Code/NSURLComponents+WMFLinkParsing.m

Wikipedia/Code/WMFSearchDataSource.m

Wikipedia/Code/Wikipedia-Bridging-Header.h

WikipediaUnitTests/Code/MWKTitleTests.m

WikipediaUnitTests/Code/WMFLinkParsingTests.m

Merge pull request #706 from wikimedia/spike/nsurlcomponentscategories/T133933
b9453ef4dd5d
Actions