HomePhabricator

Remove onboard future bulk-resolution from ConduitEngine

Description

Remove onboard future bulk-resolution from ConduitEngine

Summary:
Depends on D21071. Ref T11968. Currently, "ConduitEngine" tries to lightly parallelize futures. This was a compromise when the initial "hardpoint" change didn't plan to pursue real request paralleization.

Now that the newer hardpoint change does, we don't need onboard resolution in ConduitEngine. Throw it away.

When the engine is supposed to resolve a future, it now just resolves that future on its own. This should be functionally identical to the previous behavior, except that it may be slower.

(In practice, because HTTP futures are backed by an internal cURL request pool, this proably has little effect anywhere. Moving to modern hardpoints will make performance no worse than it was prior to this change, in any case.)

Test Plan: Ran various modern "arc" commands.

Maniphest Tasks: T11968

Differential Revision: https://secure.phabricator.com/D21072

Details

Provenance
epriestleyAuthored on Apr 8 2020, 3:49 PM
Parents
rARC85141c4d909b: Add new "Hardpoint" classes to support request parallelization
Branches
Unknown
Tags
Unknown
Tasks
T11968: Reduce use of global and public variables
ChangeId
None