HomePhabricator

Reduce memcache traffic for central session storage

This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Reduce memcache traffic for central session storage

Reduce read traffic by using a CachedBagOStuff, and write traffic by
skipping the write if nothing has changed and it's not relatively close
to expiring.

To handle the last bit, this moves the handling of the 'expiry' central
session variable into CentralAuthUtils::setCentralSession(). It seems
that it used to be used instead of the memcache expiry to expire
sessions, but 1896fc65 got rid of that and it has been unused ever
since so we may as well repurpose it.

Bug: T127772
Change-Id: I2cfcbf98f3f98416a8c2cd6664f07c602cf03259

Details

Provenance
AnomieAuthored on Feb 23 2016, 5:28 PM
oriCommitted on Feb 25 2016, 10:04 PM
ChangeId
I2cfcbf98f3f98416a8c2cd6664f07c602cf03259

Commit No Longer Exists

This commit no longer exists in the repository.