HomePhabricator

Improve CSS and JS loading of ChessBrowser

Description

Improve CSS and JS loading of ChessBrowser

  • fix nojs message showing during load (T282503)
  • ship styles module
    • to reserve space for board and buttons
    • to apply CSS to notations upon pageload
  • Improve table for metadata layout
  • Remove inline CSS
  • Removed unused classes (pgn-board-div, pgn-tabber, pgn-selector, pgn-hidebutton, pgn-pgn-display, pgn-descriptions, pgn-comment, pgn-rtl-comment, pgn-pgndiv, .pgn-descriptions, pgn-comments-hidden
  • Add a class (pgn-loaded) after the JS loading phase is complete
  • Hide controls in print
  • Make legend non-selectable
  • Fix loading sequence for livepreview and VE
  • Don't use unnecessary JS config variables

Bug: T282503
Bug: T239446
Change-Id: If691b20a3992407c3a0cfc0ef9dc6fa5426baef6

Details

Provenance
TheDJAuthored on Aug 30 2021, 9:31 PM
WugapodesCommitted on Sep 1 2021, 7:40 AM
Parents
rECHBb70167d15fc8: Merge "Don't flip directionality of chessboards in RTL env."
Branches
Unknown
Tags
Unknown
References
refs/changes/03/715603/10
ChangeId
If691b20a3992407c3a0cfc0ef9dc6fa5426baef6