HomePhabricator

Only load ext.echo.ui if the user clicks the echo badge

Authored by Mooeypoo.

Description

Only load ext.echo.ui if the user clicks the echo badge

There is no need to load the entire of Echo's ui module (especially
since that includes ooui widgets and their styles) on every page load.
There's only need to load the entire module if and when a user clicks
the Echo notification badge.

Also, make the echo.dm model accept an external fetchNotifications
promise so we can send the API request alongside loading the echo UI
and "feed" it into the DM for processing.

CSS adjusted to make the "jump" between the nojs and the js buttons
seem less jumpy.

Bug: T112401
Change-Id: I516e655ffd198511d694489a0702c5c713a5fd68

Details

Committed
MooeypooSep 16 2015, 12:11 AM
Parents
rECHOf2ed7a6a5353: Don't load unused Echo JS/CSS on mobile
Branches
Unknown
Tags
Unknown
References
refs/changes/89/238389/9
ChangeId
I516e655ffd198511d694489a0702c5c713a5fd68