Update patch set 2

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.


Update patch set 2

Patch Set 2:

Huh? So you plan to remove the per-user option and make this a per-wiki setting? No way. This thing needs to stay opt-in per user.

Feel to assume some good faith, or at least, some competence, rather than flying off the handle so unhelpfully. :-)

This change replaces the existing, never-used functionality in the extension with a gadget that's default-active on most wikis. I imagine those wikis where the gadget isn't on by default would be happy to keep using that rather than this. For most wikis, there is no "per-user option"; this replaces the existing per-wiki option with a better one.

And in general, what's wrong with this being a Gadget?

Gadgets are slow, easily broken, poorly maintained, pose security and performance issues, and are not generally available in the way that extensions are. Gadgets are, and have always been, a way to try out simple code changes before moving it into real code (or dumping it entirely and trying something else).

Who asked for this change and why?

I did. See above. This is basic stuff.

Also note that this heavily clashes with the Popups/Hovercards extension. Popups all over the place are not helpful.

I agree that the lack of product integration between the two is pretty ugly right now, and at some point I imaging that this should be merged with the Hovercards concept, but this moves code that's live in production on dozens of wikis right now into the repo; it doesn't make any changes.

Patch-set: 2


Jforrester <366@e9e9afe9-4712-486d-8885-f54b72dd1951>Authored on Jul 10 2014, 3:29 PM
Gerrit Code Review <gerrit@wikimedia.org>Committed on Jul 10 2014, 3:29 PM

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rECITb42f434c1361: Update patch set 2 (authored by Jforrester <366@e9e9afe9-4712-486d-8885-f54b72dd1951>).Jul 10 2014, 3:29 PM

Empty Commit

This commit is empty and does not affect any paths.