HomePhabricator

CodeReview: Fixed error in CodeRevisionView::formatPathLine(). $safePath was…

Authored by HappyDog.

Description

CodeReview: Fixed error in CodeRevisionView::formatPathLine(). $safePath was being used to output the path when ViewVC is disabled, but is only being created inside the code path where it is enabled. Have moved this outside the if statement so it is available to both code paths.

I also made the path bold so that it stands out more. It's a lot harder to read this section if the paths are not differentiated from the normal text in some way. Originally, I only added this for when ViewVC was disabled, as the link colouring when it is enabled is enough to make it stand out. Then I realised that deleted paths are not made into links (for obvious reasons) and so added a bold there too, but then it looked weird to have the links in normal font and the non-links in bold, so I added it for all situations.

Details

Committed
HappyDogFeb 15 2010, 12:30 PM
Parents
rECREe97f65b5ccdf: CodeReview: Modified the first argument to svnImport.php so it is now possible…
Branches
Unknown
Tags
Unknown
ChangeId
None