HomePhabricator

[CodeReview] Fixed accidental null value being returned from CodeRepository…

Authored by HappyDog.

Description

[CodeReview] Fixed accidental null value being returned from CodeRepository::getDiff(), from r80691 (see Brion's comment: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80691#c13341), and therefore also reverted the workaround for this which was added in r80794.

We now return the constant DIFFRESULT_NotInCache when forcing a cache hit and there's nothing there, instead of null.

Details

Committed
HappyDogJan 23 2011, 5:17 PM
Parents
rECREd0df4858c712: Addition and tweaking of method documentation
Branches
Unknown
Tags
Unknown
ChangeId
None