HomePhabricator

Improve detecting already signed comments

Description

Improve detecting already signed comments

Previously, we required a signature at the end of the comment.
This was a pretty rough heuristic that did not correctly handle
many comments that we would consider entirely properly signed
in CommentParser (e.g. comments wrapped in formatting like
<small>…</small>, comments with a post-scriptum or in parentheses,
or comments generated by various templates).

Now we process the user input using the same code that adds reply
links, and only add a signature when we detect that there really
isn't a signature (including template-generated), or if the signature
is in the wrong place and would result in the reply link showing up
in the wrong place as well (not at the end of the comment).

Bug: T278442
Bug: T268558
Bug: T278355
Bug: T291421
Bug: T282983
Change-Id: I46b6110af328ebdf93b7dfc2bd941e04391a1599

Details

Provenance
matmarexAuthored on Feb 4 2022, 9:58 PM
Parents
rEDTO1d43a024f9cd: Handle reply/topic preview entirely server-side
Branches
Unknown
Tags
Unknown
References
refs/changes/41/759841/16
ChangeId
I46b6110af328ebdf93b7dfc2bd941e04391a1599