HomePhabricator

[WIP] Reorder validations so that unrecoverable errors come first
053cef474903Unpublished

Authored by awight on May 31 2019, 2:18 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

[WIP] Reorder validations so that unrecoverable errors come first

TODO:

  • Decide how to order the check for basic title validity. Without this, it

makes no sense to check whether the user is allowed to upload to that page.
Currently, $importPlan->getTitle has the side effect of throwing an exception,
which is caught in some unrelated validators and not reported nicely. Maybe
we should keep the explicit check for valid title first?

Bug: T224230
Change-Id: I3ad3c5eacfb2ca081fad0269a9f0848beb1fcaf7

Details