HomePhabricator

Refactor HTML builders accessing original WebRequest
49aed5a3c5deUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Refactor HTML builders accessing original WebRequest

The issue with this code can be seen when doing a search for "->getVal("
in this codebase. The only place reading user input from the WebRequest
is the central SpecialImportFile page. But in addition to that some of
the HTML builders also access the WebRequest object to read another
value.

This patch moves this additional "importDetailsHash" value into the
ImportRequest object that already contains all the other values
provided via the WebRequest.

This allows further refactoring of these HTML builders.

Bug: T212199
Change-Id: Ifc06729d87eb4a8f6280a415f29b98684371cfda

Details

Provenance
thiemowmdeAuthored on Dec 28 2018, 1:59 PM
MR70Committed on Mar 18 2019, 4:19 PM
ChangeId
Ifc06729d87eb4a8f6280a415f29b98684371cfda

Commit No Longer Exists

This commit no longer exists in the repository.