HomePhabricator

Clean-up and fix bad validation in CommonsHelperConfigParser
50d1e1c0e49eUnpublished

Authored by thiemowmde on Jul 4 2018, 10:27 AM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Clean-up and fix bad validation in CommonsHelperConfigParser

One of the "=== false" comparisons was missing in CommonsHelperConfigParser.
Because of this the error message was also shown when the section was not
missing, but empty.

I rewrote the test to expect specific error messages to cover this better.

This patch also removes unused code, and updates some documentation.

All this is done in preparation for T198711.

Change-Id: Icc2e3af02d029136000328588f2fd683d1274330

Details

Committed
thiemowmdeJul 4 2018, 10:27 AM
Parents
rEFLIf1f7c2a74645: Relax template parser return format
Branches
Unknown
Tags
Unknown
References
refs/changes/13/443813/1
ChangeId
Icc2e3af02d029136000328588f2fd683d1274330