HomePhabricator

Add test for FileImporter\Data\ImportDetails
59d80c7e2cbdUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Add test for FileImporter\Data\ImportDetails

This is basically just a very trivial value class. But I found the
hashing feature crucial and a lot of test cases to make sure the hash
really changes with every single field.

Note to reviewer: Please have a look at the imageDisplayUrl field! Do
you think it is correct for this field to not be part of the hash
calculation?

Bug: T190290
Change-Id: I1c7420bbe1b0655467d4690090041edb498e4a85

Details

Provenance
thiemowmdeAuthored on May 9 2018, 11:03 AM
ChangeId
I1c7420bbe1b0655467d4690090041edb498e4a85

Commit No Longer Exists

This commit no longer exists in the repository.