HomePhabricator

Remove not needed pass-by-reference from ApiDetailRetriever
af69a5f364d6Unpublished

Authored by thiemowmde on Apr 5 2018, 4:25 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Remove not needed pass-by-reference from ApiDetailRetriever

The $requestData array is manipulated within getMoreRevisions(), but the
only caller does not do anything with this new array afterwards. It's not
necessary to pass it back to the caller, at least not with the current
code.

This answers the last question I had in I7623c1c: This value does not need
an assertion.

Bug: T190821
Change-Id: I5d2ba5263994b6601f61129158ff802c8338a4b2

Details