HomePhabricator

Reduce duplicate code in ApiDetailRetrieverTest
e0d2d0e7d727Unpublished

Authored by thiemowmde on Apr 5 2018, 3:06 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Reduce duplicate code in ApiDetailRetrieverTest

This patch streamlines the ApiDetailRetrieverTest:

  • Add type hints all over the place, most notably a lot of "array" type hints.
  • Extract duplicated code to private helper functions, most notably the newInstance() method.
  • Remove not needed assertTrue( true ).
  • Replace the ones that are needed with addToAssertionCount.
  • Remove $this->any(). This is the default anyway.

Bug: T190821
Change-Id: Ia0c41b271f5762ee626d249c96ff7f43063ba930

Details