HomePhabricator

Make WikiTextConversions comparisons case-insensitive
edb3b52bc57eUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Make WikiTextConversions comparisons case-insensitive

  • Add tests.
  • Use hash-lookup instead of in_array().
  • I'm intentionally making all comparisons case-insensitive. If a template or category named "ForbiddenLicense" is forbidden, it never makes sense to allow "forbiddenlicense" then, at least not in the languages strtolower() supports. Note I'm intentionally not using mb_convert_case() because of this.

Bug: T194132
Change-Id: I45b504e895a6f5f2172cb6fde02b1dc03677f8b2

Details

Provenance
thiemowmdeAuthored on Jun 4 2018, 1:45 PM
ChangeId
I45b504e895a6f5f2172cb6fde02b1dc03677f8b2

Commit No Longer Exists

This commit no longer exists in the repository.