HomePhabricator

Fix inconsistent state issues and fatal on Special:EnableFlow

Description

Fix inconsistent state issues and fatal on Special:EnableFlow

  • Fix LqtDispatch call (global namespace)
  • Change importHeader to always return a header; I was getting inconsistent state issues when there were neither headers nor topics.

    LQT already always returned a header. Although the source page may be blank, it should always exist. This also means we will always put our template and any user-specified suffix (on Special:EnableFlow).
  • Fix several master/slave issues. A few of these I hit using fake slave lag on master/slave; title->exists( Title::GAID_FOR_UPDATE ) is potential.
  • Don't have Special:EnableFlow allowCreation itself if the page already exists. The import process handles that.

Bug: T99278
Change-Id: Ia0fb1911f5238e6e7bd436676e58e11107128da9