HomePhabricator

Various JS hygiene improvements

Description

Various JS hygiene improvements

Based on code/suggestions from Krinkle's patch at I5dea4891894794b4ea68222d69e8a1a377a8f8f0 :

  • Single quotes
  • Prefer slice
  • location rather than window.location
  • JSDuck tweaks
  • Optimize processTemplateGetFragment

Add TODOs for:

  • replaceWith instead of before()/remove
  • mw.Title usage

Change-Id: Ie931fc708221b734f043b4a8f982dd773cf9104f

Details

Provenance
SGAuthored on Oct 16 2014, 5:49 AM
Mattflaschen-WMFCommitted on Dec 17 2014, 2:15 AM
Parents
rEFLW4347d7500884: J-2e Remove all collapsing functionality
Branches
Unknown
Tags
Unknown
References
refs/changes/51/166951/24
ChangeId
Ie931fc708221b734f043b4a8f982dd773cf9104f