Diffusion extension-Flow f2013dfaa363

Fix editor focusing issues
f2013dfaa363
Actions

Tags

None

Subscribers

None

Description

Fix editor focusing issues

Autofocus needs to be evaluated before the switching promise is resolved (so callers can enable/disable autofocus after a switch) but executed after the switching promise is resolved (so callers that disable the editor while the promise is pending don't break)
BoardDescriptionWidget makes itself pending (and disabled) for a longer period of time, so it needs to manually focus the editor when it un-disables it

Bug: T97290
Change-Id: Ic0fffc61a61503a7ceca714bfcb5e939c1966ec4

Details

Provenance

Authored on

Parents

rEFLW1ff7e912cf0a: Remove obsolete incorrect comment

Branches

Unknown

Tags

Unknown

References

refs/changes/05/231405/1

ChangeId

Ic0fffc61a61503a7ceca714bfcb5e939c1966ec4

Event Timeline

Catrope committed rEFLWf2013dfaa363: Fix editor focusing issues (authored by Catrope).Aug 13 2015, 8:03 PM

Catrope mentioned this in T139972: [Regression wmf.17] "Uncaught TypeError: Cannot read property 'model' of undefined" on clicking 'Edit description'.Aug 31 2016, 2:05 AM

Changes (3)

Path

Size

handlebars/

compiled/

flow_block_header.handlebars.php

modules/

flow/

ui/

widgets/

editor/

mw.flow.ui.EditorSwitcherWidget.js

mw.flow.ui.BoardDescriptionWidget.js

rEFLWf2013dfaa363

handlebars/compiled/flow_block_header.handlebars.php

Loading...

modules/flow/ui/widgets/editor/mw.flow.ui.EditorSwitcherWidget.js

Loading...

modules/flow/ui/widgets/mw.flow.ui.BoardDescriptionWidget.js

Loading...