HomePhabricator

Append number to prevent duplicate question headers
59eb1b90921aUnpublished

Authored by kostajh on May 2 2019, 9:07 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Append number to prevent duplicate question headers

Since we now have question storage, we can look at existing question headers and
append a number if there's a match for a question filed in the same minute.

Also:

  • add body as a constructor parameter to QuestionPoster -- the class can't do

much without the body set, and this simplifies the code in that we don't need
to pass $body to various methods.

  • adjust some method visibility (addSignature)
  • Move permissions checks into a method to try to make submit() a little more readable

Bug: T222125
Change-Id: Ifc6e2d3ab0536420ec3aab162bf8ce9c47207406

Details

Committed
kostajhMay 2 2019, 9:17 PM
ChangeId
Ifc6e2d3ab0536420ec3aab162bf8ce9c47207406

Commit No Longer Exists

This commit no longer exists in the repository.