HomePhabricator

Fix getEditor and the logging of 'impression'

Authored by SBisson on Jan 8 2019, 5:06 PM.
This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Fix getEditor and the logging of 'impression'

  • Correctly figure out the editor on mobile.
  • Allow overriding the editor when it is unknown because it is not loaded yet.
  • Only attach the cta to the overlay in response to hooks.
  • Listen to the 'wikipage.editform' hook for the older wikitext editor.
  • Log impression only once.

Bug: T212973
Depends-On: I74295a5fe277d592aa87fce8ef134bc19baa9b31
Change-Id: I50ecc91d5abe58c4ad6454e74b7bb35df2db46ee
(cherry picked from commit 8da16a5e2351885d574139bb12677050b3954889)

Details

Committed
SBissonJan 9 2019, 4:16 PM
Parents
rEGRE4de96117b066: Stop logging page_token
Branches
Unknown
Tags
Unknown
ChangeId
I50ecc91d5abe58c4ad6454e74b7bb35df2db46ee