HomePhabricator

Update question archive/visibility status via API
77c4b574964aUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Update question archive/visibility status via API

Before, we relied on a DeferredUpdate in SpecialHomepage::execute to make
changes to question records stored in the user's preference.
TransactionProfiler is not happy about this as it's a write on a GET.

Additionally, we want the homepage to load as quickly as possible so we will not
do the full checks on each question (is it archived, is the revision deleted,
etc) but will do that via the API request to get updated questions after the
page has loaded.

Also, change the API to not throw an error if no questions are loaded since this
is now a common scenario - previously, the API was only used after posting a
question via the question poster dialog, so not having questions would be
considered an error.

Bug: T222124
Change-Id: I21a485c75c6a7ff90985c3b3467907de5cde21a8

Details

Provenance
kostajhAuthored on May 6 2019, 1:52 PM
ChangeId
I21a485c75c6a7ff90985c3b3467907de5cde21a8

Commit No Longer Exists

This commit no longer exists in the repository.