HomePhabricator

Help panel: ResourceLoaderHelpPanelModule handle help panel disabled
e7d3e7341f34Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Help panel: ResourceLoaderHelpPanelModule handle help panel disabled

Because ResourceLoaderHelpPanelModule has versioning based on content,
it's getScript() method gets called (to build a version based on the
content's hash) even when the help panel is disabled and not configured.
In this case the getScript() method errors out and prevent other
features (Welcome survey) in this extension from working.

This patch proposes to keep versioning based on content but
return empty string when the help panel is disable.

Also remove default values that don't make sense for
wgGEHelpPanelHelpDeskTitle and wgGEHelpPanelViewMoreTitle.
These config values were hidding the issue locally.

Bug: T213356
Change-Id: I30b3da4553178cfb658cafddb43658f01c0a166c

Details

Provenance
SBissonAuthored on Jan 18 2019, 3:36 PM
MR70Committed on Mar 18 2019, 4:22 PM
ChangeId
I30b3da4553178cfb658cafddb43658f01c0a166c

Commit No Longer Exists

This commit no longer exists in the repository.