HomePhabricator

Update patch set 7
2337a60d8206Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Update patch set 7

Patch Set 7:

So, should the goal here be to mirror wfCgiToArray precisely? I didn't do that this time because it would contradict with the existing documentation.[1] In particular: "Keys in the string without values will have a value of false; keys repeated multiple times will have sequence tables as values". wfCgiToArray maps keys without values to the empty string, and if keys are repeated multiple times ("foo=bar&foo=baz") then only the final one is used. Some people might already rely on that behaviour, although I don't personally know anywhere where it is used.

[1] https://www.mediawiki.org/wiki/Extension:Scribunto/Lua_reference_manual#mw.uri.parseQueryString

Patch-set: 7
Reviewer: Mr. Stradivarius <1590@e9e9afe9-4712-486d-8885-f54b72dd1951>
Label: Verified=0

Details

Provenance
MrStradivariusAuthored on Jan 6 2016, 9:54 PM
Gerrit Code Review <gerrit@wikimedia.org>Committed on Jan 6 2016, 9:54 PM
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rELUA2337a60d8206: Update patch set 7 (authored by MrStradivarius).Jan 6 2016, 9:54 PM

Empty Commit

This commit is empty and does not affect any paths.