HomePhabricator

Update patch set 7
800abdc12bb7Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Update patch set 7

Patch Set 7: Code-Review-1

This implementation suffers from the same bug that I discovered today on enwiki's Module:Arguments. If you explicitly erase an argument, it still shows up when iterating with pairs or ipairs. I've added a couple of test cases to demonstrate, but I'm not sure of the best fix at the moment.

Patch-set: 7
Label: Code-Review=-1

Details

Provenance
MrStradivariusAuthored on Dec 9 2014, 3:23 PM
Gerrit Code Review <gerrit@wikimedia.org>Committed on Dec 9 2014, 3:23 PM
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rELUA800abdc12bb7: Update patch set 7 (authored by MrStradivarius).Dec 9 2014, 3:23 PM

Empty Commit

This commit is empty and does not affect any paths.