HomePhabricator

Update patch set 3
9feaf5b46352Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Update patch set 3

Patch Set 3:

(3 comments)

I mostly agree with the proposed changes to getArgs.lua. Especially, the removal of parent frame access when we don't know what the parent is seems like a good idea. The wrappers option is a superior way of dealing with this, and removing the old behaviour now will allow module writers to update their modules without breaking anything.

I do wonder if some module writers would want to have the option to make frame args have precedence over parent frame args when a wrapper template is specified. This is how I originally conceived of enwiki's [[Module:Protection banner]] working, for example, although now it uses a config module for configuration of its various wrapper templates.

No plus or minus mark for now, as I've only checked the code visually. I'll report back after I've played around with it a bit, and after I've managed to get phpunit working again.

Patch-set: 3
Label: Code-Review=0

Details

Provenance
MrStradivariusAuthored on Sep 6 2014, 10:36 AM
Gerrit Code Review <gerrit@wikimedia.org>Committed on Sep 6 2014, 10:36 AM
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rELUA9feaf5b46352: Update patch set 3 (authored by MrStradivarius).Sep 6 2014, 10:36 AM

Commit No Longer Exists

This commit no longer exists in the repository.