HomePhabricator

Update patch set 1
a061feda8be8Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Update patch set 1

Patch Set 1:

Very nice work in writing this! I've just started testing the Lua parts of this, and I'm liking what I see. One thing I wondered, though - how about making the functions callable as p.funcName( a, b, c, ... ) rather than p.funcName{ a, b, c, ... }? That seems somehow more "Lua-like" to me.

Also, how about adding type-checking in using libraryUtil.lua?

Patch-set: 1
Label: Verified=0

Details

Provenance
MrStradivariusAuthored on Jul 14 2014, 12:14 PM
Gerrit Code Review <gerrit@wikimedia.org>Committed on Jul 14 2014, 12:14 PM
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rELUAa061feda8be8: Update patch set 1 (authored by MrStradivarius).Jul 14 2014, 12:14 PM

Empty Commit

This commit is empty and does not affect any paths.