HomePhabricator

Update patch set 2
b9aeaebdb76fUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Update patch set 2

Patch Set 2:

There are some ambiguous cases that a parseQueryString will have to deal with if we update it to parse parameters with square brackets. Namely:

?foo[0]=bar&foo=baz
?foo=bar&foo[0]=baz

In the first one, we have the choice of overwriting the first value, adding a new index to the query table, or raising an error. In the second one, we can either overwrite the first value or raise an error.

I'd go with adding a new index to the query table for the first one, and overwriting the value for the second. But I'd like to hear others' opinions before coding this up.

Patch-set: 2

Details

Provenance
MrStradivariusAuthored on Jul 15 2015, 3:23 PM
Gerrit Code Review <gerrit@wikimedia.org>Committed on Jul 15 2015, 3:23 PM
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rELUAb9aeaebdb76f: Update patch set 2 (authored by MrStradivarius).Jul 15 2015, 3:23 PM

Empty Commit

This commit is empty and does not affect any paths.