HomePhabricator

Update patch set 7
ba92fc9ed5daUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Update patch set 7

Patch Set 7:

Originally I just wanted mw.uri.new to produce the same output as mw.uri.localUrl et al. I didn't realise that this would mean making breaking changes, though.

The really obviously wrong things in wfCgiToArray should be fixed, of course - that shouldn't break any existing uses. I'm wondering what to do about false values, though. For example:

mw.logObject( mw.uri.parseQueryString( 'foo' ) ) --> { foo = false }

var_dump( wfCgiToArray( 'foo' ) ); --> array(1) {

["foo"]=>
string(0) ""

}

If we make Lua match PHP then we risk breaking existing modules, and likewise if we make PHP match Lua we risk breaking things in Core and extensions. I suppose the least problematic would be to make Lua match PHP and then search through existing modules (perhaps with a script) to find any affected modules. But then consciously making the two not match would not be the end of the world.

Patch-set: 7

Details

Provenance
MrStradivariusAuthored on Jan 9 2016, 8:24 AM
Gerrit Code Review <gerrit@wikimedia.org>Committed on Jan 9 2016, 8:24 AM
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rELUAba92fc9ed5da: Update patch set 7 (authored by MrStradivarius).Jan 9 2016, 8:24 AM

Empty Commit

This commit is empty and does not affect any paths.