HomePhabricator

Update patch set 1
d02fc678c29eUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Update patch set 1

Patch Set 1:

If I'm reading the PHP code right, then this would change the point that errors related to database accesses were raised. At the moment such errors are raised when the mw.title object is created, but it looks like this change would mean they would be raised when one of the expensive properties or methods was accessed instead.

I think this is a very good idea, and it will solve quite a few problems I have encountered in writing modules. However, we should also regard it as a breaking change, and advertise it as such. I can think of several widely-used modules that catch errors when creating mw.title objects, but don't do anything special when accessing e.g. title.exists. On pages that exceed the expensive function count limit or have other errors, this would cause those modules to give script errors where they weren't previously.

A couple of examples of affected modules:
https://en.wikipedia.org/wiki/Module:Redirect
https://en.wikipedia.org/wiki/Module:Archive_list

(My PHP skills are still quite basic, so I'm not going to give this a +1 or -1.)

Patch-set: 1
Reviewer: Mr. Stradivarius <1590@e9e9afe9-4712-486d-8885-f54b72dd1951>
Label: Verified=0

Details

Provenance
MrStradivariusAuthored on Dec 10 2014, 1:26 PM
Gerrit Code Review <gerrit@wikimedia.org>Committed on Dec 10 2014, 1:26 PM
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rELUAd02fc678c29e: Update patch set 1 (authored by MrStradivarius).Dec 10 2014, 1:26 PM

Empty Commit

This commit is empty and does not affect any paths.