Update patch set 1
Patch Set 1:
If I'm reading the PHP code right, then this would change the point that errors related to database accesses were raised. At the moment such errors are raised when the mw.title object is created, but it looks like this change would mean they would be raised when one of the expensive properties or methods was accessed instead.
I think this is a very good idea, and it will solve quite a few problems I have encountered in writing modules. However, we should also regard it as a breaking change, and advertise it as such. I can think of several widely-used modules that catch errors when creating mw.title objects, but don't do anything special when accessing e.g. title.exists. On pages that exceed the expensive function count limit or have other errors, this would cause those modules to give script errors where they weren't previously.
(My PHP skills are still quite basic, so I'm not going to give this a +1 or -1.)
Reviewer: Mr. Stradivarius <1590@e9e9afe9-4712-486d-8885-f54b72dd1951>