HomePhabricator

Section blocks should have id attribute
14adf55512adUnpublished

Authored by Jdlrobson on Nov 1 2016, 12:40 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Section blocks should have id attribute

An id attribute allows JavaScript to access the DOMElement
representing the section body via getElementById. Given the wider
support for this method in comparison to getElementsByClassName
and the fact that classes are not meant to be unique per element
the existing usages of mf-section- classes are discouraged.

Change-Id: I53cfd1f593405d73ff1e0c0630f3a05803a9d1c2

Details

Committed
JdlrobsonNov 1 2016, 1:14 PM
Parents
rEMFR9efeaab8c068: Hygiene: Make use of makeSectionHtml helper
Branches
Unknown
Tags
Unknown
References
refs/changes/66/319066/2
ChangeId
I53cfd1f593405d73ff1e0c0630f3a05803a9d1c2