HomePhabricator

Do not use ResourceModuleSkinStyles to define skinStyles for other skins than…

Authored by matmarex on Jun 7 2017, 3:54 PM.
This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Do not use ResourceModuleSkinStyles to define skinStyles for other skins than 'minerva'

ResourceModuleSkinStyles must only contain customizations for the
skin that is defining it: in this case, 'minerva'. For other skins,
just use 'skinStyles' in module definition. Otherwise their own
customizations get overridden (or our customizations get overridden
by theirs, depending on the loading order).

MobileFrontend owns both of the wrongly customized modules
(mobile.special.history.styles and mobile.special.mobilemenu.styles).

Both have no need to be skinStyles.

  • The mobile.special.mobilemenu.styles is an abandoned experiment in

Vector and the default stylesheet is Minerva specific.

  • mobile.special.history.styles is not overriden by any skin so can

be registered as a stylesheet

Bug: T167216
Change-Id: I39d15b9e8a1068e3ed8c6da23fbf8d7ad29ea632
(cherry picked from commit 89517bf8f821207e035d46610fb293ee3b3c6fd3)

Details

Committed
matmarexJun 7 2017, 4:40 PM
Parents
rEMFRb6e3f2c234fb: phpcs: Allow linting tools to discover rules
Branches
Unknown
Tags
Unknown
ChangeId
I39d15b9e8a1068e3ed8c6da23fbf8d7ad29ea632