Diffusion extension-MobileFrontend 676b75aacea1

Use getimagesizefromstring() instead of getimagesize()
676b75aacea1
Actions

Description

Use getimagesizefromstring() instead of getimagesize()

getimagesize() outputs warnings when the file does not exist
or when allow_url_fopen is disabled.
Now we use MWHttpRequest to retrieve the file instead
so we don't have a warning if the file can't be retrieved.

Bug: T153250
Change-Id: If1365924e52625a0c6346411faae300b2f83c25a

Details

Provenance

Rudloff

Authored on Dec 15 2016, 1:57 AM

Parents

rEMFR14f28a15397c: Show the user icon on watchlist page

Branches

Unknown

Tags

Unknown

ChangeId

If1365924e52625a0c6346411faae300b2f83c25a

Event Timeline

Rudloff committed rEMFR676b75aacea1: Use getimagesizefromstring() instead of getimagesize() (authored by Rudloff).Dec 15 2016, 2:04 AM

phuedx mentioned this in T153250: Warning: No such file or directory in /srv/mediawiki/php-1.29.0-wmf.6/extensions/MobileFrontend/includes/api/ApiWebappManifest.php on line 31.Dec 16 2016, 10:17 AM

Krinkle mentioned this in T153811: MobileFrontend: webapp-manifest is missing icon size.Dec 21 2016, 3:02 AM

Changes (1)

Path

Size

includes/

api/

ApiWebappManifest.php

rEMFR676b75aacea1

View Options

includes/api/ApiWebappManifest.php

Use getimagesizefromstring() instead of getimagesize()676b75aacea1Actions